Re: [ovs-dev] [manpages 2/2] docs: Add Makefile rule to check syntax of manpages.

On Aug 24, 2011, at 11:54 AM, Ben Pfaff wrote: --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,8 @@ EXTRA_DIST = \ REPORTING-BUGS \ SubmittingPatches \ WHY-OVS \ - boot.sh + boot.sh \ + $(MAN_FRAGMENTS) Is it just me, or does that sound kind of gross?

Re: [ovs-dev] [manpages 2/2] docs: Add Makefile rule to check syntax of manpages.

On Thu, Aug 25, 2011 at 12:53:36AM -0700, Justin Pettit wrote: On Aug 24, 2011, at 11:54 AM, Ben Pfaff wrote: --- a/Makefile.am +++ b/Makefile.am @@ -45,7 +45,8 @@ EXTRA_DIST = \ REPORTING-BUGS \ SubmittingPatches \ WHY-OVS \ - boot.sh + boot.sh \ +

[ovs-dev] [distcheck 0/4] Make make distcheck pass again.

Once in a while it's good to run make distcheck and clean up the problems that it finds. This series makes it pass again. Ben Pfaff (4): rhel: Fix make distcheck failure due to regenerating spec files. Mark uninstall-local targets phony. bugtool: Uninstall plugins on make uninstall.

[ovs-dev] [distcheck 1/4] rhel: Fix make distcheck failure due to regenerating spec files.

We want to regenerate the RPM spec files whenever the version number changes, hence the dependency on config.status. But that means that we try to modify the spec files even when the version number doesn't change, which cause make distcheck to fail because it write-protects the source directory.

[ovs-dev] [distcheck 2/4] Mark uninstall-local targets phony.

--- Makefile.am|4 +++- ovsdb/ovsdbmonitor/automake.mk |2 +- python/ovs/automake.mk |2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 2090501..75f35b3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -57,6

[ovs-dev] [distcheck 3/4] bugtool: Uninstall plugins on make uninstall.

This works toward making make distcheck succeed. --- utilities/bugtool/automake.mk | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/utilities/bugtool/automake.mk b/utilities/bugtool/automake.mk index 7d8d136..622e5aa 100644 --- a/utilities/bugtool/automake.mk

[ovs-dev] [distcheck 4/4] bugtool: Remove ovs-bugtool upon make clean, to fix make distcheck.

--- utilities/bugtool/automake.mk |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/utilities/bugtool/automake.mk b/utilities/bugtool/automake.mk index 622e5aa..98b6db4 100644 --- a/utilities/bugtool/automake.mk +++ b/utilities/bugtool/automake.mk @@ -1,5 +1,6 @@ if

Re: [ovs-dev] [PATCH] debian: Apply Ubuntu patch to add DKMS support.

Thanks for the ack. I pushed this to master. On Thu, Aug 25, 2011 at 08:52:24AM +0900, Simon Horman wrote: As this patch is based on Chuck's work. Acked-by: Simon Horman ho...@verge.net.au On Wed, Aug 24, 2011 at 12:44:23PM -0700, Ben Pfaff wrote: Thanks. Adding Simon (I should have

Re: [ovs-dev] [python3 01/15] ovs.db.idl: Fix call to ovs.db.parser.Parser constructor.

Looks good. --Justin On Aug 24, 2011, at 5:14 PM, Ben Pfaff wrote: This bug was introduced by commit 4c0f62718f ovs.db.idl: Improve error reporting for bad row-updates. Found by pychecker. --- python/ovs/db/idl.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [ovs-dev] [python3 02/15] ovs.daemon: Add missing 'global' when setting _pidfile_dev, _pidfile_ino.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/daemon.py |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/python/ovs/daemon.py b/python/ovs/daemon.py index da7eb8a..7bd7370 100644 --- a/python/ovs/daemon.py

Re: [ovs-dev] [python3 03/15] ovs.daemon: Fix name of EALREADY error.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/daemon.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/ovs/daemon.py b/python/ovs/daemon.py index 7bd7370..d4e4bf1 100644 --- a/python/ovs/daemon.py

[ovs-dev] Bug#637802: Bug #637802: DKMS support now implemented upstream

tags 637802 fixed-upstream thanks DKMS support is now on the master branch of Open vSwitch. It will likely be part of 1.3.0 when that is released. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [python3 04/15] ovs.daemon: Add missing format string argument.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/daemon.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/ovs/daemon.py b/python/ovs/daemon.py index d4e4bf1..ba18d86 100644 --- a/python/ovs/daemon.py

[ovs-dev] Processed: Bug #637802: DKMS support now implemented upstream

Processing commands for cont...@bugs.debian.org: tags 637802 fixed-upstream Bug #637802 [openvswitch-datapath-source] Please add DKMS support Added tag(s) fixed-upstream. thanks Stopping processing here. Please contact me if you need assistance. -- 637802:

Re: [ovs-dev] [python3 01/15] ovs.db.idl: Fix call to ovs.db.parser.Parser constructor.

I pushed this one, thank you. On Thu, Aug 25, 2011 at 11:05:02AM -0700, Justin Pettit wrote: Looks good. --Justin On Aug 24, 2011, at 5:14 PM, Ben Pfaff wrote: This bug was introduced by commit 4c0f62718f ovs.db.idl: Improve error reporting for bad row-updates. Found by

Re: [ovs-dev] [python3 05/15] ovs.db.idl: Fix error message format arguments.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: There's no variable table_name. Found by pychecker. --- python/ovs/db/idl.py |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py index

Re: [ovs-dev] [python3 06/15] ovs.json: Use Exception, which exists, instead of Error, which doesn't.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/json.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/ovs/json.py b/python/ovs/json.py index 5e7d8fa..96f3cff 100644 --- a/python/ovs/json.py +++

Re: [ovs-dev] [python3 07/15] ovs.jsonrpc: Fix static method Message.__validate_arg reference to 'self'.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: This method needs to be an instance method because it refers to 'self'. Found by pychecker. --- python/ovs/jsonrpc.py | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git

Re: [ovs-dev] [python3 08/15] ovs.jsonrpc: Fix static method Session.open() reference to 'self'.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/jsonrpc.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/ovs/jsonrpc.py b/python/ovs/jsonrpc.py index f10a0da..5117944 100644 ---

Re: [ovs-dev] [python3 10/15] ovs.stream: Remove unused parameter from usage().

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: This function has no callers. We could delete it entirely, instead. --- python/ovs/stream.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/ovs/stream.py b/python/ovs/stream.py index

Re: [ovs-dev] [python3 11/15] python: Remove unused imports.

I assume this is fine. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/db/data.py |5 - python/ovs/stream.py |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git a/python/ovs/db/data.py b/python/ovs/db/data.py index

Re: [ovs-dev] [python3 12/15] ovs.db.types: Remove write-only variable from constraintsToEnglish().

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/db/types.py |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/python/ovs/db/types.py b/python/ovs/db/types.py index 00b9ab4..4e8f8f1 100644 ---

Re: [ovs-dev] [python3 09/15] ovs.ovsuuid: Fix UUID.cInitUUID invocation of re.match with too few params.

Looks good. --Justin On Aug 24, 2011, at 5:15 PM, Ben Pfaff wrote: Found by pychecker. --- python/ovs/ovsuuid.py |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/python/ovs/ovsuuid.py b/python/ovs/ovsuuid.py index 8a76d3a..5d2785c 100644 ---

[ovs-dev] [manpages 0/5] more manpage infrastructure improvements

Here's some more stuff I noticed while looking over the manpages. Ben Pfaff (5): Move soexpand.pl into build-aux and make it non-executable. Implement automatic dependency generation for manpages. tests: Fix noinst_man_MANS. test-openflowd: Fix groff warning. Improve manpage checking

[ovs-dev] [manpages 1/5] Move soexpand.pl into build-aux and make it non-executable.

Scripts for the build generally go in build-aux, so move soexpand.pl. soexpand.pl had the executable bit set, but it doesn't have a #! line and it's not a shell script, so that didn't make sense. --- Makefile.am |6 ++ soexpand.pl = build-aux/soexpand.pl |0 2

[ovs-dev] [manpages 3/5] tests: Fix noinst_man_MANS.

The manpage name is test-openflowd.8, not ovs-openflowd.8. This should have caused build errors, I don't know why it didn't. --- tests/automake.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/automake.mk b/tests/automake.mk index a9bb086..569457f 100644 ---

[ovs-dev] [manpages 4/5] test-openflowd: Fix groff warning.

The warning is: tests/test-openflowd.8:365: warning: macro `DD' not defined daemon.man allows the file that is including it to include extra text in the description of --detach by defining a macro named DD. Only some of the manpages that included it did this (only those manpages that

[ovs-dev] [manpages 5/5] Improve manpage checking rule.

The coverage of the previous version of this rule was incomplete because $(MANS) does not include $(noinst_man_MANS). (Also, $(MANS) is undocumented.) Writing it out as the list of manpages variables that Open vSwitch uses is better. Also, the previous version of the rule didn't actually

[ovs-dev] [manpages 2/5] Implement automatic dependency generation for manpages.

This ensures that manpages actually get rebuilt if any of the lib/*.man fragments that they depend upon are modified. --- Makefile.am| 16 +++- build-aux/sodepends.pl | 69 +++ manpages.mk| 255

Re: [ovs-dev] [PATCH 1/1] vswitchd: PVID (Port VLAN ID) tagging feature

Le 25/08/2011 01:07, Ben Pfaff a écrit : Hi Philippe. Just dropping you a note to let you know that I haven't forgotten your patch. I spent some time writing a separate commit that fixes the bug that you reported and posted it in this thread, along with some unit tests for VLANs:

[ovs-dev] [PATCH] gitignore: Add manpage-check.

--- .gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index cd0ba81..851c391 100644 --- a/.gitignore +++ b/.gitignore @@ -38,6 +38,7 @@ /depcomp /distfiles /install-sh +/manpage-check /missing /missing-distfiles /package.m4 -- 1.7.6

Re: [ovs-dev] [PATCH] gitignore: Add manpage-check.

Looks good, thank you. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Debian: Transition to dh_python2

On Wed, Aug 24, 2011 at 10:06:29AM -0700, Ben Pfaff wrote: The Python libraries that Open vSwitch installs have been private libraries, in the sense that they are only really meant to be used by other parts of Open vSwitch. Maybe that's a mistake; I guess that there is no good reason that

Re: [ovs-dev] [PATCH] Debian: Transition to dh_python2

On Fri, Aug 26, 2011 at 08:25:30AM +0900, Simon Horman wrote: On Wed, Aug 24, 2011 at 10:06:29AM -0700, Ben Pfaff wrote: The Python libraries that Open vSwitch installs have been private libraries, in the sense that they are only really meant to be used by other parts of Open vSwitch.

[ovs-dev] [genl 1/6] lib: Rename rtnetlink.[ch] files.

The only rtnetlink specific functionality contained in the rtnetlink module is the use of the NETLINK_ROUTE protocol. This can easily be passed in by callers. In preparation for generalization, this patch renames rtnetlink.[ch] to netlink-notifier.[ch]. Future patches will complete the

[ovs-dev] [genl 2/6] netlink-notifier: Rename rtnetlink code.

This patch renames the rtnetlink module's code to nln for netlink notifier. Callers are now required to pass in the netlink protocol to he newly renamed nln_create() function. --- lib/dpif-linux.c |2 +- lib/netdev-linux.c |2 +- lib/netlink-notifier.c | 135

[ovs-dev] [genl 3/6] netlink-notifier: New function nln_set_mcgroup().

This function will be helpful when the multicast group of a netlink-notifier isn't known at creation time. --- lib/netlink-notifier.c | 78 ++- lib/netlink-notifier.h |1 + 2 files changed, 70 insertions(+), 9 deletions(-) diff --git

[ovs-dev] [genl 4/6] netlink-socket: New function nl_lookup_genl_mcgroup().

--- lib/netlink-socket.c | 54 +++-- lib/netlink-socket.h |2 + 2 files changed, 53 insertions(+), 3 deletions(-) diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c index 719f658..394107e 100644 --- a/lib/netlink-socket.c +++

[ovs-dev] [genl 5/6] datapath: genl_notify() on port disappearances.

Before this patch, if a vport detached itself from the datapath without interaction from userspace, rtnetlink notifications would be sent, but genl notifications would not. Feature #6809. Signed-off-by: Ethan Jackson et...@nicira.com --- datapath/datapath.c |6 +++--- datapath/datapath.h

[ovs-dev] [genl 6/6] dpif-linux: Stop listening for RTNL notifications.

Currently dpif-linux listens for vport change events using rtnetlink notifications. This patch switches to the ovs genl notification system. Feature #6809. --- lib/dpif-linux.c | 61 ++ 1 files changed, 43 insertions(+), 18 deletions(-)

Re: [ovs-dev] [PATCH] Debian: Transition to dh_python2

On Thu, Aug 25, 2011 at 04:28:32PM -0700, Ben Pfaff wrote: On Fri, Aug 26, 2011 at 08:25:30AM +0900, Simon Horman wrote: On Wed, Aug 24, 2011 at 10:06:29AM -0700, Ben Pfaff wrote: The Python libraries that Open vSwitch installs have been private libraries, in the sense that they are only