Hi,
this series contains a second round of patches intended to bring Open
vSwitch closer to being able to be compiled when compiling using the
Android NDK r6b (Android API level 13).
___
dev mailing list
dev@openvswitch.org
Attention,
It was resolved and agreed at the bank head quarter that your
inheritance fund would be deliver to you on a special method of payment Tag
name read swift credit card, forward to us your full information to enable us
deliver your card to you.
Mr.S.general Okom
On Fri, Sep 23, 2011 at 08:11:18PM +0900, Simon Horman wrote:
this series contains a second round of patches intended to bring Open
vSwitch closer to being able to be compiled when compiling using the
Android NDK r6b (Android API level 13).
Thanks Simon, I pushed both of these to master.
On Thu, Sep 22, 2011 at 03:59:30PM -0700, Jesse Gross wrote:
On Thu, Sep 22, 2011 at 1:11 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Sep 19, 2011 at 03:00:08PM -0700, Jesse Gross wrote:
Currently it is possible for a client on a single port to generate
a huge number of packets that miss
[adding Ethan since he designed the 'base_flow' thingy]
On Thu, Sep 22, 2011 at 05:18:30PM -0700, Pravin Shelar wrote:
Track vlan-id correctly. So that we can use that information for
composing optimized action set.
I don't think that this is a sufficient fix. The problem remains, at
On Fri, Sep 23, 2011 at 9:16 AM, Ben Pfaff b...@nicira.com wrote:
On Thu, Sep 22, 2011 at 03:59:30PM -0700, Jesse Gross wrote:
On Thu, Sep 22, 2011 at 1:11 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Sep 19, 2011 at 03:00:08PM -0700, Jesse Gross wrote:
Currently it is possible for a client
Currently we publish several multicast groups for upcalls and let
userspace sockets subscribe to them. The benefit of this is mostly
that userspace is the one doing the subscription - the actual
multicast capability is not currently used and probably wouldn't be
even if we moved to a multiprocess
Now that upcalls from the kernel use unicast sockets, we need to
tell the kernel where to send them explicitly. This means that
when the switch is restarted it's necessary to take control of any
existing objects, which is done when the dpif listen mask becomes
non-zero. Since we're going to blow
Many of our functions pass around a pointer to Netlink attributes
and a length. This exposes the version of nl_attr_find that takes
that format so it can be used by callers outside the Netlink library.
---
v2: New patch.
---
lib/netlink.c |2 +-
lib/netlink.h |2 ++
2 files changed, 3
---
debian/ovs-monitor-ipsec | 52 ++-
tests/automake.mk |1 +
tests/ovs-monitor-ipsec.at | 222
tests/testsuite.at |1 +
4 files changed, 254 insertions(+), 22 deletions(-)
create mode 100644
---
tests/MockXenAPI.py| 82
tests/automake.mk |4 +-
tests/ovs-xapi-sync.at | 74 ++
tests/testsuite.at |1 +
I pushed this series and sent out two more patches that add
unit tests.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Awesome, thanks.
Ethan
On Fri, Sep 23, 2011 at 14:25, Ben Pfaff b...@nicira.com wrote:
I pushed this series and sent out two more patches that add
unit tests.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Sep 23, 2011 at 02:20:13PM -0700, Jesse Gross wrote:
Currently we publish several multicast groups for upcalls and let
userspace sockets subscribe to them. The benefit of this is mostly
that userspace is the one doing the subscription - the actual
multicast capability is not currently
On Fri, Sep 23, 2011 at 02:20:16PM -0700, Jesse Gross wrote:
Many of our functions pass around a pointer to Netlink attributes
and a length. This exposes the version of nl_attr_find that takes
that format so it can be used by callers outside the Netlink library.
---
v2: New patch.
Looks
On Fri, Sep 23, 2011 at 02:20:17PM -0700, Jesse Gross wrote:
Currently it is possible for a client on a single port to generate
a huge number of packets that miss in the kernel flow table and
monopolize the userspace/kernel communication path. This
effectively DoS's the machine because no new
---
lib/tag.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/tag.h b/lib/tag.h
index 5885e15..9cb581d 100644
--- a/lib/tag.h
+++ b/lib/tag.h
@@ -75,7 +75,7 @@ static inline bool tag_intersects(tag_type, tag_type);
static inline bool tag_is_valid(tag_type);
/*
Looks good,
Ethan
On Fri, Sep 23, 2011 at 15:15, Ben Pfaff b...@nicira.com wrote:
---
lib/tag.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/tag.h b/lib/tag.h
index 5885e15..9cb581d 100644
--- a/lib/tag.h
+++ b/lib/tag.h
@@ -75,7 +75,7 @@ static inline
Thanks, pushed.
On Fri, Sep 23, 2011 at 03:18:33PM -0700, Ethan Jackson wrote:
Looks good,
Ethan
On Fri, Sep 23, 2011 at 15:15, Ben Pfaff b...@nicira.com wrote:
---
?lib/tag.h | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/tag.h b/lib/tag.h
index
---
tests/test-jsonrpc.py |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/test-jsonrpc.py b/tests/test-jsonrpc.py
index 064457e..fda9a03 100644
--- a/tests/test-jsonrpc.py
+++ b/tests/test-jsonrpc.py
@@ -177,7 +177,7 @@ def main(argv):
args = args[1:]
On Fri, Sep 23, 2011 at 2:38 PM, Ben Pfaff b...@nicira.com wrote:
On Fri, Sep 23, 2011 at 02:20:13PM -0700, Jesse Gross wrote:
Currently we publish several multicast groups for upcalls and let
userspace sockets subscribe to them. The benefit of this is mostly
that userspace is the one doing
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Sep 23, 2011 at 03:22:32PM -0700, Jesse Gross wrote:
On Fri, Sep 23, 2011 at 2:38 PM, Ben Pfaff b...@nicira.com wrote:
On Fri, Sep 23, 2011 at 02:20:13PM -0700, Jesse Gross wrote:
Currently we publish several multicast groups for upcalls and let
userspace sockets subscribe to them.
Pleases pep8.
---
tests/test-jsonrpc.py | 14 ++
1 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/tests/test-jsonrpc.py b/tests/test-jsonrpc.py
index fda9a03..781f1f4 100644
--- a/tests/test-jsonrpc.py
+++ b/tests/test-jsonrpc.py
@@ -23,6 +23,7 @@ import ovs.jsonrpc
On Fri, Sep 23, 2011 at 2:53 PM, Ben Pfaff b...@nicira.com wrote:
On Fri, Sep 23, 2011 at 02:20:17PM -0700, Jesse Gross wrote:
Currently it is possible for a client on a single port to generate
a huge number of packets that miss in the kernel flow table and
monopolize the userspace/kernel
Thanks, pushed.
On Fri, Sep 23, 2011 at 15:23, Ben Pfaff b...@nicira.com wrote:
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
---
utilities/bugtool/ovs-bugtool.in |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/utilities/bugtool/ovs-bugtool.in b/utilities/bugtool/ovs-bugtool.in
index c2b603f..422b2dd 100755
--- a/utilities/bugtool/ovs-bugtool.in
+++ b/utilities/bugtool/ovs-bugtool.in
@@
There's only a small race window on datapath creation when get_dpfindex()
can return 0, so it's pretty unlikely.
Found by inspection.
Signed-off-by: Ben Pfaff b...@nicira.com
---
datapath/datapath.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath/datapath.c
On Fri, Sep 23, 2011 at 03:44:49PM -0700, Jesse Gross wrote:
On Fri, Sep 23, 2011 at 3:32 PM, Ben Pfaff b...@nicira.com wrote:
There's only a small race window on datapath creation when get_dpfindex()
can return 0, so it's pretty unlikely.
Found by inspection.
Signed-off-by: Ben Pfaff
---
debian/ovs-monitor-ipsec |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec
index c123188..f62c393 100755
--- a/debian/ovs-monitor-ipsec
+++ b/debian/ovs-monitor-ipsec
@@ -436,7 +436,7 @@ def get_ssl_cert(data):
Pleases pep8.
---
debian/ovs-monitor-ipsec | 42 --
1 files changed, 24 insertions(+), 18 deletions(-)
diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ipsec
index f62c393..10b278d 100755
--- a/debian/ovs-monitor-ipsec
+++
This option gets used in the unit test for ovs-monitor-ipsec that is
currently out for review. I accidentally let part of that stray into
the wrong commit. It's fine if you delete it, though; I'll fold it
into the unit test commit.
___
dev mailing list
On Fri, Sep 23, 2011 at 05:05:56PM -0700, Ethan Jackson wrote:
Pleases pep8.
Fine with me.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
---
lib/bond.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/lib/bond.c b/lib/bond.c
index 5b984fb..e15af04 100644
--- a/lib/bond.c
+++ b/lib/bond.c
@@ -639,7 +639,6 @@ void
bond_account(struct bond *bond, const struct flow *flow, uint16_t vlan,
uint64_t
Sounds good.
pep8 complained about the global variable being defined outside module
context which is why I deleted it. Could you please fix the warning
in your patch?
Ethan
On Fri, Sep 23, 2011 at 17:13, Ben Pfaff b...@nicira.com wrote:
This option gets used in the unit test for
Will do, thanks.
On Fri, Sep 23, 2011 at 05:15:22PM -0700, Ethan Jackson wrote:
Sounds good.
pep8 complained about the global variable being defined outside module
context which is why I deleted it. Could you please fix the warning
in your patch?
Ethan
On Fri, Sep 23, 2011 at 17:13,
This second version of the vlans series adds two commits at the
beginning that fix up some internal ugliness and bugs in the OFPP_NORMAL
handling of vlans in ofproto-dpif. I've also fixed how mirroring to
VLANs works in the final commit, as well as increasing the stringency
of the tests to ensure
compose_actions(), which is part of the OFPP_NORMAL implementation, had
multiple flaws that this commit corrects.
First, it did not commit changes made to the flow by actions preceding
the output to OFPP_NORMAL. This means that, for example, if an OpenFlow
action to modify an L2 or L3 header
OFP_VLAN_NONE used to be convenient as a value for struct dst's 'vlan'
member, because it ended up being used in actions anyway, but now it's
much better to just use 0.
---
ofproto/ofproto-dpif.c | 55 ++-
1 files changed, 21 insertions(+), 34
These tests would have caught the bug fixed in the previous commit
ofproto-dpif: Fix behavior when a subset of VLANs is trunked.
---
tests/ofproto-dpif.at | 79 +++
tests/ofproto-macros.at | 43 +
2 files changed, 122
---
lib/bitmap.c | 21 -
lib/bitmap.h |2 ++
2 files changed, 22 insertions(+), 1 deletions(-)
diff --git a/lib/bitmap.c b/lib/bitmap.c
index df3c4eb..76a667a 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2008, 2009 Nicira Networks.
Significant updates by Ben Pfaff, including:
* Comment, coding style, indentation updates.
* Documentation improved.
* Added tests.
* Dropped PORT_VLAN_EMPTY.
---
NEWS |3 +
ofproto/ofproto-dpif.c | 156 +++---
ofproto/ofproto.h
On Fri, Sep 23, 2011 at 10:57:35AM -0700, Ben Pfaff wrote:
[adding Ethan since he designed the 'base_flow' thingy]
On Thu, Sep 22, 2011 at 05:18:30PM -0700, Pravin Shelar wrote:
Track vlan-id correctly. So that we can use that information for
composing optimized action set.
I don't
These look fine to me.
They're going to conflict with the unit tests I sent out today, but it
should be easy enough to fix up.
How much work would it be to fix all the remaining pychecker and pep8
warnings in one series? I think I'd rather get it all fixed in one go,
if it's practical.
Looks obviously correct.
--Justin
On Sep 23, 2011, at 5:14 PM, Ben Pfaff b...@nicira.com wrote:
---
lib/bond.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/lib/bond.c b/lib/bond.c
index 5b984fb..e15af04 100644
--- a/lib/bond.c
+++ b/lib/bond.c
@@ -639,7
Thanks, I pushed it.
On Fri, Sep 23, 2011 at 09:22:39PM -0700, Justin Pettit wrote:
Looks obviously correct.
--Justin
On Sep 23, 2011, at 5:14 PM, Ben Pfaff b...@nicira.com wrote:
---
lib/bond.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git
This series has been waiting for review for almost a month now.
I'd like to get it reviewed someday soon.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
This series has gone without any reviews for a couple of weeks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
48 matches
Mail list logo
