On Thu, Nov 3, 2011 at 2:05 PM, Ansis Atteka wrote:
>
>
> On Thu, Nov 3, 2011 at 1:32 PM, Jesse Gross wrote:
>>
>> On Thu, Nov 3, 2011 at 10:38 AM, Ansis Atteka wrote:
>> >
>> >
>> > On Wed, Nov 2, 2011 at 6:36 PM, Jesse Gross wrote:
>> >>
>> >> On Wed, Nov 2, 2011 at 5:13 PM, Ansis Atteka
>>
We currently set netdev->flags to IFF_BROADCAST | IFF_MULTICAST
but this is unnecessary because it's already done by ether_setup().
Signed-off-by: Jesse Gross
---
datapath/vport-internal_dev.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/datapath/vport-internal_dev.c
On Thu, Nov 3, 2011 at 1:26 PM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
> index a468ac8..a9212d0 100644
> --- a/datapath/vport-internal_dev.c
> +++ b/datapath/vport-internal_dev.c
> @@ -37,27 +39,35 @@ static inline struct internal_dev
>
Thanks, I've pushed this.
Ethan
On Thu, Nov 3, 2011 at 13:25, Ben Pfaff wrote:
> On Thu, Nov 03, 2011 at 01:06:53PM -0700, Ethan Jackson wrote:
>> This patch also causes eth_compose() to set the l2 and l3 pointers
>> of the packets which it modifies.
>
> Looks good, thanks.
>
___
On Thu, Nov 3, 2011 at 1:25 PM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
> index a468ac8..7132b9f 100644
> --- a/datapath/vport-internal_dev.c
> +++ b/datapath/vport-internal_dev.c
[...]
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,39)
On Thu, Nov 3, 2011 at 1:32 PM, Jesse Gross wrote:
> On Thu, Nov 3, 2011 at 10:38 AM, Ansis Atteka wrote:
> >
> >
> > On Wed, Nov 2, 2011 at 6:36 PM, Jesse Gross wrote:
> >>
> >> On Wed, Nov 2, 2011 at 5:13 PM, Ansis Atteka
> wrote:
> >> > On Wed, Nov 2, 2011 at 3:49 PM, Jesse Gross wrote:
>
On Thu, Nov 03, 2011 at 01:06:53PM -0700, Ethan Jackson wrote:
> This patch also causes eth_compose() to set the l2 and l3 pointers
> of the packets which it modifies.
Looks good, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/ma
On Thu, Nov 3, 2011 at 10:38 AM, Ansis Atteka wrote:
>
>
> On Wed, Nov 2, 2011 at 6:36 PM, Jesse Gross wrote:
>>
>> On Wed, Nov 2, 2011 at 5:13 PM, Ansis Atteka wrote:
>> > On Wed, Nov 2, 2011 at 3:49 PM, Jesse Gross wrote:
>> >>
>> >> On Mon, Oct 31, 2011 at 5:00 PM, Ansis Atteka
>> >> wrote:
Fixed according to comments from Jesse.
--8<--cut here-->8--
Signed-off-by: Pravin Shelar
---
datapath/vport-internal_dev.c | 48 ++--
1 files changed, 31 insertions(+), 17 deletions(-)
diff --git a/datapath/
Fixed according to comments from Jesse.
--8<--cut here-->8--
>From 2.6.39 kernel netdev features are set using set_features and
fix_features APIs. Since internal-dev does not need any special
checks on setting feature, there is no need to define set
This patch also causes eth_compose() to set the l2 and l3 pointers
of the packets which it modifies.
---
lib/cfm.c| 11 +--
lib/cfm.h|1 +
lib/packets.c|6 +-
vswitchd/bridge.c|2 ++
vswitchd/vswitch.xml |7 +++
5 files changed,
This was already reviewed by Ben. Reposted with minor modifications.
It's not in need of additional review, though comments are always
welcome.
Ethan
On Thu, Nov 3, 2011 at 13:06, Ethan Jackson wrote:
> This patch also causes eth_compose() to set the l2 and l3 pointers
> of the packets which it
On Wed, Nov 2, 2011 at 5:32 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin Shelar
I got a whitespace error when applying this:
Applying: datapath: Define net_device_ops->ndo_get_stats64() for internal_dev.
/home/jesse/openvswitch/.git/rebase-apply/patch:19: space before tab in indent.
On Wed, Nov 2, 2011 at 6:36 PM, Jesse Gross wrote:
> On Wed, Nov 2, 2011 at 5:13 PM, Ansis Atteka wrote:
> > On Wed, Nov 2, 2011 at 3:49 PM, Jesse Gross wrote:
> >>
> >> On Mon, Oct 31, 2011 at 5:00 PM, Ansis Atteka
> wrote:
> >> > UDP performance is currently limited to much lower numbers tha
From: Alexey I. Froloff
[Spec file changes and some documentation updates by Ben Pfaff.]
---
Hi Alexey, I made up a patch that adds your network scripts to
the RHEL RPMs. Would you mind testing it?
I also added a copyright notice with your name and specifying
the Apache 2.0 license that we use
On Wed, Nov 2, 2011 at 5:27 PM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
> index a468ac8..30cc96e 100644
> --- a/datapath/vport-internal_dev.c
> +++ b/datapath/vport-internal_dev.c
> @@ -185,6 +187,9 @@ static void do_setup(struct net_devi
On Wed, Nov 02, 2011 at 03:12:18PM -0700, Jesse Gross wrote:
> On Wed, Nov 2, 2011 at 10:47 AM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Jesse Gross
Thanks, I pushed it.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.o
On Wed, Nov 02, 2011 at 11:53:41PM -0700, Justin Pettit wrote:
> Commit 7257b5 (Implement new fragment handling policy.) added a new
> "is_frag" meta-field that used fewer bits than the width of the field.
> A comment in mf_field lists these cases, but "is_frag" wasn't included.
> This commit updat
On Wed, Nov 02, 2011 at 11:53:40PM -0700, Justin Pettit wrote:
> Previously, the ODP tests were being grouped together with the ovs-ofctl
> ones, which is clearly not right. This commit puts it in its own
> "datapath parsing and formatting" group.
Looks good, thank you.
__
On Wed, Nov 02, 2011 at 11:53:39PM -0700, Justin Pettit wrote:
> file = fopen(argv[1], "r");
> if (file == NULL) {
> -ovs_fatal(errno, "%s: open", argv[2]);
> +ovs_fatal(errno, "%s: open", argv[1]);
> }
Looks good, thank you.
_
On Wed, Nov 02, 2011 at 11:53:38PM -0700, Justin Pettit wrote:
> Commits d2c0fed (nicira-ext: Bump number of registers to five from
> four.) and 7257b5 (Implement new fragment handling policy.) added new
> match fields, but didn't update the maximum length of an NXM message.
> This commit increases
On Thu, Nov 3, 2011 at 9:04 AM, Ben Pfaff wrote:
> On Wed, Nov 02, 2011 at 04:33:26PM -0700, Jesse Gross wrote:
>> netdev_send() directly sends a packet using Linux mechanisms, skipping
>> our kernel module. Several upper layer abstractions are built on top of
>> the kernel module, so this means t
On Wed, Nov 02, 2011 at 04:33:26PM -0700, Jesse Gross wrote:
> netdev_send() directly sends a packet using Linux mechanisms, skipping
> our kernel module. Several upper layer abstractions are built on top of
> the kernel module, so this means that we loose stats, sFlow, etc. on
> these packets. Thi
On Tue, Nov 01, 2011 at 12:20:11PM -0700, Ethan Jackson wrote:
> diff --git a/lib/cfm.c b/lib/cfm.c
> index 0d79bee..8ba399c 100644
> --- a/lib/cfm.c
> +++ b/lib/cfm.c
> @@ -93,6 +93,7 @@ struct cfm {
> uint32_t seq; /* The sequence number of our last CCM. */
> uint8_t ccm_interv
24 matches
Mail list logo
