Yes, everything was recompiled and rebooted several times to narrow
down the point at which the issue appeared.
I suspect this could be related to the issue with packet out not
working when mod_dl_dst action is specified (earlier mail in
ovs-discuss), rather than the in-band issue.
Jari Sundell
On Fri, Nov 4, 2011 at 4:43 PM, Ben Pfaff wrote:
> This seems like a worthwhile improvement in itself, but it will also see
> additional users in upcoming commits.
I briefly wondered whether it was worth combining this with
format_odp_key_attr() but this function is so simple and that would
make
Sounds good.
Ethan
On Fri, Nov 4, 2011 at 18:40, Jesse Gross wrote:
> I was planning on looking at it.
>
> On Fri, Nov 4, 2011 at 5:02 PM, Ben Pfaff wrote:
>> I was hoping that you and Jesse could work out who has precedence.
>>
>> On Fri, Nov 04, 2011 at 04:56:14PM -0700, Ethan Jackson wrote:
On Fri, Nov 4, 2011 at 4:43 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> include/linux/openvswitch.h | 8
> 1 files changed, 4 insertions(+), 4 deletions(-)
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://
I was planning on looking at it.
On Fri, Nov 4, 2011 at 5:02 PM, Ben Pfaff wrote:
> I was hoping that you and Jesse could work out who has precedence.
>
> On Fri, Nov 04, 2011 at 04:56:14PM -0700, Ethan Jackson wrote:
>> Who is the appropriate person to review this? If it's me, how urgent is it?
I was hoping that you and Jesse could work out who has precedence.
On Fri, Nov 04, 2011 at 04:56:14PM -0700, Ethan Jackson wrote:
> Who is the appropriate person to review this? If it's me, how urgent is it?
>
> Ethan
>
> On Fri, Nov 4, 2011 at 16:44, Ben Pfaff wrote:
> > On Fri, Nov 04, 2011
Who is the appropriate person to review this? If it's me, how urgent is it?
Ethan
On Fri, Nov 4, 2011 at 16:44, Ben Pfaff wrote:
> On Fri, Nov 04, 2011 at 04:43:12PM -0700, Ben Pfaff wrote:
>> The Netlink flow key attribute structure is designed to allow the
>> kernel to add support for new pro
On Fri, Nov 4, 2011 at 12:22 PM, Ben Pfaff wrote:
> I'm also thinking about changing the flow key format by dropping the
> ordering restrictions. There's no real benefit to them unless
> anything is actually sensitive to ordering (e.g. we allow duplicate
> attributes, which my proposal below woul
On Fri, Nov 04, 2011 at 04:43:12PM -0700, Ben Pfaff wrote:
> The Netlink flow key attribute structure is designed to allow the
> kernel to add support for new protocols over time without breaking
> userspace applications, but the userspace side of this had not been
> implemented. This series imple
NetFlow active timeouts were only mixed in with flow expiration for
convenience: both processes need to iterate all the facets. But
an upcoming commit will change flow expiration to work in terms of
a new "subfacet" entity, so they will no longer fit together well.
This change could be seen as an
---
lib/dpif-linux.c | 12 +++-
lib/netlink.h|5 +
2 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/lib/dpif-linux.c b/lib/dpif-linux.c
index 7d0628c..88193c3 100644
--- a/lib/dpif-linux.c
+++ b/lib/dpif-linux.c
@@ -1329,9 +1329,7 @@ dpif_linux_vport_from_ofpbuf
---
lib/netlink.c | 105 +++-
1 files changed, 58 insertions(+), 47 deletions(-)
diff --git a/lib/netlink.c b/lib/netlink.c
index 1e1ec61..6445049 100644
--- a/lib/netlink.c
+++ b/lib/netlink.c
@@ -620,6 +620,51 @@ static const size_t attr_len_
I don't see a reason not to use it and it simplifies the code a lot.
---
lib/netlink.c | 41 +
1 files changed, 13 insertions(+), 28 deletions(-)
diff --git a/lib/netlink.c b/lib/netlink.c
index 7529534..1e1ec61 100644
--- a/lib/netlink.c
+++ b/lib/netlin
This seems like a worthwhile improvement in itself, but it will also see
additional users in upcoming commits.
---
lib/odp-util.c | 41 -
1 files changed, 36 insertions(+), 5 deletions(-)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 1e9289a..f348e58
Signed-off-by: Ben Pfaff
---
include/linux/openvswitch.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
index a1ffc7d..eb652cd 100644
--- a/include/linux/openvswitch.h
+++ b/include/linux/openvswitch.h
@@ -
The Netlink flow key attribute structure is designed to allow the
kernel to add support for new protocols over time without breaking
userspace applications, but the userspace side of this had not been
implemented. This series implements it.
I already have some proposed changes out that would spec
Thanks, I pushed this.
On Fri, Nov 04, 2011 at 02:08:03PM -0700, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Fri, Nov 4, 2011 at 13:59, Ben Pfaff wrote:
> > ovs-vswitchd.conf.db is distributed so it's in the source directory not
> > the build directory.
> >
> > This fixes a Debian packa
Looks good.
Ethan
On Fri, Nov 4, 2011 at 13:59, Ben Pfaff wrote:
> ovs-vswitchd.conf.db is distributed so it's in the source directory not
> the build directory.
>
> This fixes a Debian package build failure introduced by commit 9840bdbd
> "debian: Install ovs-vswitchd.conf.db(5) manpage." I di
ovs-vswitchd.conf.db is distributed so it's in the source directory not
the build directory.
This fixes a Debian package build failure introduced by commit 9840bdbd
"debian: Install ovs-vswitchd.conf.db(5) manpage." I did test that commit
but the build failure didn't show up in my environment (pr
On Fri, Nov 4, 2011 at 10:59 AM, Jesse Gross wrote:
> On Fri, Nov 4, 2011 at 10:57 AM, Pravin B Shelar wrote:
>> Fixed according to comments from Jesse.
>>
>> --8<--cut here-->8--
>>
>> From 2.6.39 kernel netdev features are set using set_features a
On Fri, Nov 4, 2011 at 12:52 PM, Jesse Gross wrote:
> On Fri, Nov 4, 2011 at 11:12 AM, Pravin B Shelar wrote:
>> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
>> index a468ac8..55f5e46 100644
>> --- a/datapath/vport-internal_dev.c
>> +++ b/datapath/vport-internal_dev.
On Fri, Nov 04, 2011 at 12:04:05PM -0700, Ethan Jackson wrote:
> > Yes, that makes sense to me. ?I thought that we had essentially agreed
> > on that change earlier in fact.
>
> Oh I'd forgotten about that. I'll go ahead and create a bug for the backlog.
Thanks.
I pushed this to master and soon
Thanks, I pushed this.
On Fri, Nov 04, 2011 at 11:47:01AM -0700, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Fri, Nov 4, 2011 at 09:57, Ben Pfaff wrote:
> > This manpage wasn't getting installed. ?This fixes it.
> >
> > The --language=C option to dh_installman is necessary to keep that
On Fri, Nov 4, 2011 at 11:12 AM, Pravin B Shelar wrote:
> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
> index a468ac8..55f5e46 100644
> --- a/datapath/vport-internal_dev.c
> +++ b/datapath/vport-internal_dev.c
> static struct net_device_stats *internal_dev_sys_stats
I'm working on a file that would go in Documentation/networking in the
kernel tree and probably in datapath/README in the OVS tree. It
describes OVS in general just a little but it's mostly about flow key
compatibility rules. It actually proposes a change to how we do VLANs
in flow keys (which I
> Yes, that makes sense to me. I thought that we had essentially agreed
> on that change earlier in fact.
Oh I'd forgotten about that. I'll go ahead and create a bug for the backlog.
Ethan
>
> On Fri, Nov 04, 2011 at 12:00:26PM -0700, Ethan Jackson wrote:
>> This looks good to me.
>>
>> Unrela
Yes, that makes sense to me. I thought that we had essentially agreed
on that change earlier in fact.
On Fri, Nov 04, 2011 at 12:00:26PM -0700, Ethan Jackson wrote:
> This looks good to me.
>
> Unrelated to this patch:
>
> The more I think about it. I don't think falling back to balance-slb
>
This looks good to me.
Unrelated to this patch:
The more I think about it. I don't think falling back to balance-slb
is the appropriate thing to do when lacp negotiations fail for
balance-tcp bonds. I think it will be much safer to fall back to
active-backup.
Generally speaking, in a properly
Looks good.
Ethan
On Fri, Nov 4, 2011 at 09:57, Ben Pfaff wrote:
> This manpage wasn't getting installed. This fixes it.
>
> The --language=C option to dh_installman is necessary to keep that script
> from thinking that the ".db" suffix indicates a translation into the "db"
> language (which do
Fixed according to comments from Jesse.
--8<--cut here-->8--
Signed-off-by: Pravin Shelar
Bug #7772
---
datapath/vport-internal_dev.c | 47 ++--
1 files changed, 30 insertions(+), 17 deletions(-)
diff --git
On Fri, Nov 4, 2011 at 9:28 AM, Ben Pfaff wrote:
> On Thu, Nov 03, 2011 at 06:20:23PM -0700, Jesse Gross wrote:
>> We currently set netdev->flags to IFF_BROADCAST | IFF_MULTICAST
>> but this is unnecessary because it's already done by ether_setup().
>>
>> Signed-off-by: Jesse Gross
>
> Acked-by:
On Fri, Nov 4, 2011 at 10:57 AM, Pravin B Shelar wrote:
> Fixed according to comments from Jesse.
>
> --8<--cut here-->8--
>
> From 2.6.39 kernel netdev features are set using set_features and
> fix_features APIs. Since internal-dev does not need any
Fixed according to comments from Jesse.
--8<--cut here-->8--
>From 2.6.39 kernel netdev features are set using set_features and
fix_features APIs. Since internal-dev does not need any special
checks on setting feature, there is no need to define set
This manpage wasn't getting installed. This fixes it.
The --language=C option to dh_installman is necessary to keep that script
from thinking that the ".db" suffix indicates a translation into the "db"
language (which doesn't actually exist) and therefore installing it into
the wrong directory wi
On Fri, Oct 28, 2011 at 01:28:57PM -0700, Ben Pfaff wrote:
> SLB bonds, for important reasons, drop most incoming packets that indicate
> that a MAC has moved to the bond from another port. These reasons do not
> apply to other types of bonds, but until now OVS has still dropped them.
>
> This fi
That is the following commit:
commit 4edb9ae90e4092f5f56b9d914d2b88783c49860d
Author: Pravin B Shelar
Date: Fri Oct 21 14:38:54 2011 -0700
datapath: Refactor actions in terms of match fields.
Almost all current actions can be expressed in the form of
push/pop/set , where field
On Thu, Nov 03, 2011 at 06:20:23PM -0700, Jesse Gross wrote:
> We currently set netdev->flags to IFF_BROADCAST | IFF_MULTICAST
> but this is unnecessary because it's already done by ether_setup().
>
> Signed-off-by: Jesse Gross
Acked-by: Ben Pfaff
___
On Fri, Nov 04, 2011 at 05:51:40PM +0400, Alexey I. Froloff wrote:
> On Thu, Nov 03, 2011 at 10:32:01AM -0700, Ben Pfaff wrote:
> > Hi Alexey, I made up a patch that adds your network scripts to
> > the RHEL RPMs. Would you mind testing it?
> Looks OK, I'll test it on monday-tuesday.
Thanks. Let
On Thu, Nov 03, 2011 at 10:32:01AM -0700, Ben Pfaff wrote:
> Hi Alexey, I made up a patch that adds your network scripts to
> the RHEL RPMs. Would you mind testing it?
Looks OK, I'll test it on monday-tuesday.
> I also added a copyright notice with your name and specifying
> the Apache 2.0 licens
Hi,
The specific change was:
git diff
a0003c0c359bc3ffe8a6683dbd0121877a3ce700..4edb9ae90e4092f5f56b9d914d2b88783c49860d
Jari Sundell
On Fri, Nov 4, 2011 at 4:53 PM, Jari Sundell wrote:
> After more testing it turns out it isn't the patch itself, rather
> something that was committed since 65
After more testing it turns out it isn't the patch itself, rather
something that was committed since 65c3058c22.
Jari Sundell
On Fri, Nov 4, 2011 at 4:30 PM, Jari Sundell wrote:
> Seems things are not yet done... Without this patch (git master)
> packets are properly being passed to local port w
Seems things are not yet done... Without this patch (git master)
packets are properly being passed to local port when disable-in-band
is true.
With the patch no packets get through, with or without disable-in-band set.
Jari Sundell
On Thu, Nov 3, 2011 at 5:10 AM, Ben Pfaff wrote:
> Thanks, push
42 matches
Mail list logo
