On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:
> static bool
> is_admissible(struct ofproto_dpif *ofproto, const struct flow *flow,
> - bool have_packet,
> - tag_type *tags, int *vlanp, struct ofbundle **in_bundlep)
> + struct ofport_dpif *in_port, uint16_t v
Don't spend thousands on email lists...
** $295 **
For ALL complete Healthcare, Business and Consumer List Volumes below
This package normally sells for $499, so buy now before the price goes up again
next week!
* All data is obtained legally through optin channels
* Available for immediate d
On Wed, Nov 16, 2011 at 4:23 PM, Pravin B Shelar wrote:
> Upstream OVS is not going to have patch vports. So there is no
> need to have special loop-detection in OVS.
>
> Signed-off-by: Pravin B Shelar
Applied.
___
dev mailing list
dev@openvswitch.org
On Wed, Nov 16, 2011 at 4:16 PM, Pravin B Shelar wrote:
> Upstream OVS vports types (internal and netdev) does not make use of
> vport_ops init() and exit() interface. So It makes sense to remove it
> from upstream OVS.
>
> Signed-off-by: Pravin B Shelar
Applied.
On Wed, Nov 16, 2011 at 4:11 PM, Ben Pfaff wrote:
> On Wed, Nov 16, 2011 at 04:13:21PM -0800, Jesse Gross wrote:
>> Any other warnings that you see?
>
> Only:
> /home/blp/db/_build/datapath/linux/actions.c:416:8: warning: symbol
> 'loop_counters' was not declared. Should it be static?
> I think w
On Wed, Nov 16, 2011 at 4:48 PM, Jesse Gross wrote:
> On Wednesday, November 16, 2011, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> datapath/datapath.c | 3 +--
>> datapath/datapath.h | 1 -
>> 2 files changed, 1 insertions(+), 3 deletions(-)
>
> Acked-by: Jesse Gros
On Wednesday, November 16, 2011, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/datapath.c |3 +--
> datapath/datapath.h |1 -
> 2 files changed, 1 insertions(+), 3 deletions(-)
Acked-by: Jesse Gross
___
dev mailing
Signed-off-by: Pravin B Shelar
---
datapath/datapath.c |3 +--
datapath/datapath.h |1 -
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index 44d31a8..47f696e 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -95,7 +95,
Upstream OVS is not going to have patch vports. So there is no
need to have special loop-detection in OVS.
Signed-off-by: Pravin B Shelar
---
net/openvswitch/actions.c | 45 +
1 files changed, 1 insertions(+), 44 deletions(-)
diff --git a/net/openvs
Upstream OVS vports types (internal and netdev) does not make use of
vport_ops init() and exit() interface. So It makes sense to remove it
from upstream OVS.
Signed-off-by: Pravin B Shelar
---
net/openvswitch/vport.c | 58 +--
net/openvswitch/vport.h
On Wed, Nov 16, 2011 at 04:13:21PM -0800, Jesse Gross wrote:
> Any other warnings that you see?
Only:
/home/blp/db/_build/datapath/linux/actions.c:416:8: warning: symbol
'loop_counters' was not declared. Should it be static?
I think we found out earlier that this one is difficult, at best, to
av
On Wed, Nov 16, 2011 at 4:05 PM, Ben Pfaff wrote:
> On Wed, Nov 16, 2011 at 04:04:55PM -0800, Ben Pfaff wrote:
>> On Wed, Nov 16, 2011 at 04:05:56PM -0800, Jesse Gross wrote:
>> > Some overzealous marking of pointers as __rcu caused sparse to flag
>> > errors that only showed up on the upstream ke
On Wed, Nov 16, 2011 at 04:04:55PM -0800, Ben Pfaff wrote:
> On Wed, Nov 16, 2011 at 04:05:56PM -0800, Jesse Gross wrote:
> > Some overzealous marking of pointers as __rcu caused sparse to flag
> > errors that only showed up on the upstream kernel tree.
> >
> > Signed-off-by: Jesse Gross
>
> Act
On Wed, Nov 16, 2011 at 04:05:56PM -0800, Jesse Gross wrote:
> Some overzealous marking of pointers as __rcu caused sparse to flag
> errors that only showed up on the upstream kernel tree.
>
> Signed-off-by: Jesse Gross
Actually I've been seeing these for ages in my build tree. I assumed
that y
Some overzealous marking of pointers as __rcu caused sparse to flag
errors that only showed up on the upstream kernel tree.
Signed-off-by: Jesse Gross
---
datapath/datapath.c |2 +-
datapath/flow.c |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/datapath/dat
On Wed, Nov 16, 2011 at 2:01 PM, Pravin B Shelar wrote:
> Following patch deletes OVS compatibility code related to older kernel,
> bridge, vlan etc and rearranges it for upstreaming.
>
> Signed-off-by: Pravin B Shelar
Applied, thanks.
___
dev mailing
Multiple-clause conditions in OVSDB operations with "where" clauses are
supposed to be conjunctions, that is, the condition is true only if every
clause is true. In fact, the implementation only checked a single clause
(not necessarily the first one) and ignored the rest. This fixes the
problem a
Fixed according to comments from Jesse.
v2-v3:
- updated to latest OVS
- removed white space changes.
v1-v2:
- Fixed memleak.
- Removed extra blank lines.
- Removed flag, offset-stats and linkname from vport.
- Inlined skb_clear_rxhash()
- F
On Wed, Nov 16, 2011 at 1:50 PM, Ben Pfaff wrote:
> On Wed, Nov 16, 2011 at 01:49:06PM -0800, Jesse Gross wrote:
>> Many of our kernel copyright messages make reference to code being
>> copied from the Linux kernel, which is a bit odd for code in the
>> kernel. This changes them to use the standa
On Wed, Nov 16, 2011 at 01:49:06PM -0800, Jesse Gross wrote:
> Many of our kernel copyright messages make reference to code being
> copied from the Linux kernel, which is a bit odd for code in the
> kernel. This changes them to use the standard GNU GPL boilerplate
> instead. It does not change th
Many of our kernel copyright messages make reference to code being
copied from the Linux kernel, which is a bit odd for code in the
kernel. This changes them to use the standard GNU GPL boilerplate
instead. It does not change the actual license, which continues to
be GPLv2.
Signed-off-by: Jesse
On Wed, Nov 16, 2011 at 12:18 PM, Pravin Shelar wrote:
> On Wed, Nov 16, 2011 at 9:57 AM, Jesse Gross wrote:
>> On Mon, Nov 14, 2011 at 2:01 PM, Pravin B Shelar wrote:
>>> diff --git a/net/openvswitch/flow.h b/net/openvswitch/flow.h
>>> index 43360cc..4596fd2 100644
>>> --- a/net/openvswitch/flo
On Wed, Nov 16, 2011 at 9:57 AM, Jesse Gross wrote:
> On Mon, Nov 14, 2011 at 2:01 PM, Pravin B Shelar wrote:
>> Following patch deletes OVS compatibility code related to older kernel,
>> bridge, vlan etc and rearranges it for upstreaming.
>>
>> Signed-off-by: Pravin B Shelar
>
> Can you update
> It's weird that this bug has been in there so long and been undetected. In
> any case, the fix looks good to me. Thanks for tracking it down.
Worth noting:
I just tried reproducing the problem on branch-1.2. OVS handles TOS
incorrectly for IPv6 traffic on this branch, but it fails to warn.
On Mon, Nov 14, 2011 at 2:01 PM, Pravin B Shelar wrote:
> Following patch deletes OVS compatibility code related to older kernel,
> bridge, vlan etc and rearranges it for upstreaming.
>
> Signed-off-by: Pravin B Shelar
Can you update this for Ben's patches?
I also got a bunch of whitespace erro
25 matches
Mail list logo
