Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-19 Thread Jesse Gross
On Fri, Nov 18, 2011 at 5:37 PM, David Miller da...@davemloft.net wrote: From: Stephen Hemminger stephen.hemmin...@vyatta.com Date: Fri, 18 Nov 2011 17:09:17 -0800 (PST) On Fri, Nov 18, 2011 at 3:23 PM, Stephen Hemminger shemmin...@vyatta.com wrote: On Fri, 18 Nov 2011 15:12:18 -0800

[ovs-dev] [PATCH] datapath: Use u64_stats_sync for datapath and vport stats.

2011-11-19 Thread Jesse Gross
We currently use a seqcount to prevent reading partial 64-bit stats on 32-bit CPUs. u64_stats_sync uses the same logic but elides it on 64-bit and uniprocessor machines. This improves performance (primarily on non-x86 architectures) at the cost of not guaranteeing that packet and byte counts

Re: [ovs-dev] [PATCH] ofp-util: Support OFPP_LOCAL in enqueue actions.

2011-11-19 Thread Justin Pettit
Do you think we should put that in DESIGN? Also, we should start chipping away at ambiguities in the OpenFlow spec by filing spec bugs in the ONF bug tracker. I've been trying to do that with areas that I see. --Justin On Nov 18, 2011, at 8:36 PM, Ben Pfaff wrote: OK, that's good enough

Re: [ovs-dev] [PATCH] ofp-util: Support OFPP_LOCAL in enqueue actions.

2011-11-19 Thread Ben Pfaff
DESIGN is OK too, at least for now. All the port terminology is changing in OpenFlow 1.2 anyway. This might be fixed, I don't know. On Sat, Nov 19, 2011 at 10:20:49AM -0800, Justin Pettit wrote: Do you think we should put that in DESIGN? Also, we should start chipping away at ambiguities in

[ovs-dev] hello

2011-11-19 Thread Prisca Habima
hello I am Prisca a single Lady looking for honest and nice man whom i can partner with I want you to know that i will be interested to know you the more because something tells me your a nice person so i will like us to become good friends and know each other the more. send me an email

[ovs-dev] [PATCH 1/2] datapath: Add genl_dereference() and use it.

2011-11-19 Thread Jesse Gross
We currently use a specialized version of what amounts to genl_dereference() to protect the flow table. This prepares to propose genl_dereference() upstream and uses it instead of our version. Signed-off-by: Jesse Gross je...@nicira.com --- datapath/datapath.c | 25

[ovs-dev] [PATCH 2/2] datapath: Directly use methods for protecting RCU/RTNL data.

2011-11-19 Thread Jesse Gross
We currently have a wrapper to protect the datapath ports array. However, this can lead to confusion over exactly what lock is protecting the access (either RTNL or RCU). This removes the wrapper in favor of directly accessing the data, which also has the benefit of being less permissive about

[ovs-dev] [PATCH 1/2] datapath: Always notify in initial namespace for port deletions.

2011-11-19 Thread Jesse Gross
We currently notify for port deletions in the namespace of the device that was deleted. In general this should be initial namespace because that's the only place where we look but it's possible that the device was moved after being attached. However, it's not semantically correct because we

[ovs-dev] [PATCH 2/2] datapath: Remove unused variable in dp_notify.c.

2011-11-19 Thread Jesse Gross
Signed-off-by: Jesse Gross je...@nicira.com --- datapath/dp_notify.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/datapath/dp_notify.c b/datapath/dp_notify.c index 415e83b..5d41d27 100644 --- a/datapath/dp_notify.c +++ b/datapath/dp_notify.c @@ -24,11 +24,10 @@

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-19 Thread Jesse Gross
On Fri, Nov 18, 2011 at 9:30 PM, John Fastabend john.r.fastab...@intel.com wrote: On 11/18/2011 3:12 PM, Jesse Gross wrote: + */ +enum ovs_frag_type { +       OVS_FRAG_TYPE_NONE, +       OVS_FRAG_TYPE_FIRST, +       OVS_FRAG_TYPE_LATER, +       __OVS_FRAG_TYPE_MAX +}; + +#define

Re: [ovs-dev] [PATCH net-next 4/4] net: Add Open vSwitch kernel components.

2011-11-19 Thread John Fastabend
On 11/19/2011 3:06 PM, Jesse Gross wrote: On Fri, Nov 18, 2011 at 9:30 PM, John Fastabend john.r.fastab...@intel.com wrote: On 11/18/2011 3:12 PM, Jesse Gross wrote: + */ +enum ovs_frag_type { + OVS_FRAG_TYPE_NONE, + OVS_FRAG_TYPE_FIRST, + OVS_FRAG_TYPE_LATER, +