We're unlikely to hit this leak, but the static checkers complain if we
don't take care of it.
Signed-off-by: Dan Carpenter
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 6cd7601..7f0ef37 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -127,8 +127,10 @
On Tue, Dec 6, 2011 at 1:37 AM, Jesse Gross wrote:
> On Sun, Dec 4, 2011 at 7:32 PM, Zhi Yong Wu wrote:
>> Although this series of patchset is a bit large, therefore their codes
>> aren't directly pasted here, but if anyone find some issues in the
>> codes, how will we point out them?
>
> I also
On Dec 5, 2011, at 11:17 AM, Ben Pfaff wrote:
> I assume you tested it, I only built it.
Yes.
> "sparse" says:
>
>../lib/netdev-linux.c:3547:47: warning: incorrect type in argument 2
>(different base types)
>../lib/netdev-linux.c:3547:47:expected unsigned int [unsigned]
>min
Thank you for the patch. It's pretty close to ready, I think.
I think that you should add updates to NEWS and vswitchd/vswitch.xml,
to inform users of this improvement.
In sflow_choose_agent_address():
I think that the 'default_port' variable could be removed, since it is
a constant. Y
On Sun, Nov 13, 2011 at 11:08:12PM +0100, Ghe Rivero wrote:
> ovs should be run with other group other than root (maybe
> netdev). This way, other users or daemons can manage it without
> suing/sudoing.
It's a good idea. I'll try to get that on the to-do list for an
upcoming version.
[patches we
On Sun, Dec 04, 2011 at 04:57:19PM -0800, Justin Pettit wrote:
> Mike Bursell pointed out that our policer only works on IPv4
> traffic--and specifically not IPv6. By using the "basic" filter, we can
> enforce policing on all traffic for a particular interface.
>
> Jamal Hadi Salim pointed out th
On Mon, Dec 05, 2011 at 02:43:12PM +, Dominic Curran wrote:
> @@ -100,10 +99,9 @@ def update(session, args):
> host_mgmt_device = None
> pool_mgmt_macs = {}
> if new_controller:
> -for n in session.xenapi.PIF.get_all():
> -rec = session.xenapi.PIF.get_record(n
On Sun, Dec 4, 2011 at 7:32 PM, Zhi Yong Wu wrote:
> Although this series of patchset is a bit large, therefore their codes
> aren't directly pasted here, but if anyone find some issues in the
> codes, how will we point out them?
I also sent out the actual patches that are referenced in this pull
On Fri, Dec 02, 2011 at 05:53:38PM -0800, Ansis Atteka wrote:
> Some while ago Netlink Family names were changed from ODP_*
> to OVS_*. This leaded to upgrade related issues when the new ovs-dpctl
> wanted to remove existing datapaths from the old kernel module
> by using 'ovs_datapath' instead of
On Sun, Dec 4, 2011 at 6:33 PM, Zhi Yong Wu wrote:
> Today i played with openvswitch on my workstation with kernel 2.6.40 and
> found that it break when i built. The
> +issue is introduced by commit ceb176fdb72bb7ce90debc66e1eeb1d25823d30a
>
> Below is the error log:
>
> from /home/zwu/work/virt/
Thanks. I doubt that a malfunction is possible in practice, so I'll
skip the backports.
On Mon, Dec 05, 2011 at 09:20:28AM +0100, Gaetano Catalli wrote:
> I actually didn't notice any malfunction.
>
> On Fri, Dec 2, 2011 at 7:43 PM, Ben Pfaff wrote:
> > Thanks. ?I pushed this to master.
> >
> >
From: Rob Hoes
When there are lots of PIFs in a XenServer/XCP pool, for example when
there are many VLANs configured on the pool, operations such as
PIF.get_all and loops over all PIFs which include database operations,
are very inefficient when executed on a pool slave, and should be
avoided as
Looks good.
I dont think i deserve the credit you are attributing to me.
Now wouldnt it have been nice to be able to say:
/sbin/tc filter add dev virt0 parent : protocol ip prio 50 u32 \
match ip src 0.0.0.0/0 \
action police rate Xkbit drop \
action vlan pop \
action vlan push tag XXX \
ac
Jesse,
I empathize with effort youve put in, i really do; youve
already created the messaging from user space to kernel
and dammit it works; however, i dont agree with your reasoning.
The classifier action code is _exactly_ the same infrastructure.
The user space API/messaging already exists. If
Hello
My name is priscilla, i saw your profile today and became
interested in you,i will also like to know you the more
and i want you to send a mail direct to my email id
so i can give you my picture for you to know whom i am.
I believe we can move from here! remember distance
or colour do
I'm certainly very happy with a re-write: this seems like a much nicer way of
doing things.
-Mike.
> -Original Message-
> From: Justin Pettit [mailto:jpet...@nicira.com]
> Sent: 05 December 2011 00:57
> To: dev@openvswitch.org
> Cc: Mike Bursell; Jamal Hadi Salim
> Subject: [PATCH] net
I actually didn't notice any malfunction.
On Fri, Dec 2, 2011 at 7:43 PM, Ben Pfaff wrote:
> Thanks. I pushed this to master.
>
> Did you actually notice any problems without this patch in practice?
> I am trying to determine whether it should be backported to
> branch-1.{2,3,4}.
>
> Thanks,
>
>
17 matches
Mail list logo
