Sounds good, thanks.
Ethan
On Fri, Apr 13, 2012 at 21:15, Ben Pfaff wrote:
> On Fri, Apr 13, 2012 at 06:06:47PM -0700, Ethan Jackson wrote:
>> I would think that bitwise_is_all_zeros() belongs in it's own patch
>> just line bitwise_one(), but I don't think it matters much.
>
> I was lazy.
>
> I
On Fri, Apr 13, 2012 at 05:58:28PM -0700, Ethan Jackson wrote:
> > + if (n_bits <= 64) {
> > + mf_set_subfield(&dst, value, &rule);
> > + } else {
> > + /* We're only setting subfields to allow us to check
> > +
Well, that was dumb of me.
I decided to just squash the two together to push and add to the commit
log of the first one, "Also, update comments of some existing
functions." Perfect commit history on comments isn't as important as
getting this patch series in.
Thanks,
Ben.
On Fri, Apr 13, 2012
On Fri, Apr 13, 2012 at 06:06:47PM -0700, Ethan Jackson wrote:
> I would think that bitwise_is_all_zeros() belongs in it's own patch
> just line bitwise_one(), but I don't think it matters much.
I was lazy.
I broke this out as a new patch just after patch 1, and I added a test.
Good thing, too, b
Thanks for reviewing the code so carefully. I'll merge this later tonight when
I get home.
Ethan (iPhone)
On Apr 13, 2012, at 20:41, Ben Pfaff wrote:
> On Wed, Apr 11, 2012 at 11:50:22PM -0700, Ethan Jackson wrote:
>>> Should we update any documentation or NEWS?
>>
>> The documentation I've
On Wed, Apr 11, 2012 at 11:50:22PM -0700, Ethan Jackson wrote:
> > Should we update any documentation or NEWS?
>
> The documentation I've looked at doesn't mention a default value so I don't
> think it needs to change. I can't imagine that any users will really care
> that
> we don't send echo's
We have 4 good lists to help with your marketing needs - each one is only $99
this week
-American Business List - 4 million emails in 9,000 SIC categories
-USA Nurses and Therapists - 135k Emails with Full Data
-USA Full Data Healthcare List - 230,000 emails in 365 Medical Specialties and
Busi
I just reviewed this patch squashed into the previous one and it looks
good to me.
Ethan
On Fri, Apr 13, 2012 at 17:49, Ethan Jackson wrote:
> I'm going to postpone reviewing this one until the rebasing is fixed as well.
>
> Ethan
>
> On Wed, Apr 11, 2012 at 17:15, Ben Pfaff wrote:
>> Signed-of
Looks good,
I would think that bitwise_is_all_zeros() belongs in it's own patch
just line bitwise_one(), but I don't think it matters much.
Ethan
On Wed, Apr 11, 2012 at 17:15, Ben Pfaff wrote:
> The implementation of the "learn" action now properly implements
> specifications such as 0x20010db
> + if (n_bits <= 64) {
> + mf_set_subfield(&dst, value, &rule);
> + } else {
> + /* We're only setting subfields to allow us to check
> + * prerequisites. No prerequisite depends on the value
> of
> +
I'm going to postpone reviewing this one until the rebasing is fixed as well.
Ethan
On Wed, Apr 11, 2012 at 17:15, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/meta-flow.c | 16
> 1 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/lib/meta-flow.c b
Due to what looks like a rebasing error, this patch doesn't compile.
I haven't read the code yet.
Ethan
On Wed, Apr 11, 2012 at 17:15, Ben Pfaff wrote:
> The existing functions for reading and writing the values of subfields only
> handle subfields up to 64 bits wide. These new functions handl
Looks good, thanks.
Ethan
On Wed, Apr 11, 2012 at 17:15, Ben Pfaff wrote:
> It's the obvious counterpart to bitwise_zero().
>
> Signed-off-by: Ben Pfaff
> ---
> lib/util.c | 48
> lib/util.h | 2 ++
> tests/library.at | 3
> Should we update any documentation or NEWS?
The documentation I've looked at doesn't mention a default value so I don't
think it needs to change. I can't imagine that any users will really care that
we don't send echo's on unix sockets so I'm reluctant to add it to the NEWS.
The following is a
On Fri, Apr 13, 2012 at 04:55:54PM -0700, Ethan Jackson wrote:
> > I'd be happier to have this and the corresponding Python change in a
> > single commit, or as a second choice to at least mention in the commit
> > log that the corresponding change was just made.
>
> That's fine with me. I'll fol
> I'd be happier to have this and the corresponding Python change in a
> single commit, or as a second choice to at least mention in the commit
> log that the corresponding change was just made.
That's fine with me. I'll fold it in. I can resend the entire think
if you'd like.
Ethan
>
> Thanks
On Wed, Apr 11, 2012 at 11:10:20PM -0700, Ethan Jackson wrote:
> This patch doesn't actually fix a bug, but it seems more consistent
> to ignore this value when it's zero.
>
> Signed-off-by: Ethan Jackson
I'd be happier to have this and the corresponding Python change in a
single commit, or as a
This patch doesn't actually fix a bug, but it seems more consistent
to ignore this value when it's zero.
Signed-off-by: Ethan Jackson
---
lib/reconnect.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/reconnect.c b/lib/reconnect.c
index 7737fcf..c750007 100644
---
Sure I'll send a separate patch.
Ethan
On Fri, Apr 13, 2012 at 16:40, Ben Pfaff wrote:
> In that case then can you make the corresponding change in
> lib/reconnect.c also?
>
> On Fri, Apr 13, 2012 at 03:57:20PM -0700, Ethan Jackson wrote:
>> Yes it appears to fix the problem according to the un
In that case then can you make the corresponding change in
lib/reconnect.c also?
On Fri, Apr 13, 2012 at 03:57:20PM -0700, Ethan Jackson wrote:
> Yes it appears to fix the problem according to the unit tests. It
> seems correct to fix it in both places to me though.
>
> Ethan
>
> On Fri, Apr 13
On Wed, Apr 11, 2012 at 10:02:10PM -0700, Ethan Jackson wrote:
> There isn't a lot of value in sending inactivity probes on unix
> sockets. This patch changes the default to disable them.
>
> Signed-off-by: Ethan Jackson
I'm half-inclined to just write a single function that can take either
a s
Yes it appears to fix the problem according to the unit tests. It
seems correct to fix it in both places to me though.
Ethan
On Fri, Apr 13, 2012 at 15:53, Ben Pfaff wrote:
> On Wed, Apr 11, 2012 at 10:02:09PM -0700, Ethan Jackson wrote:
>> The python reconnect library attempted to send a probe
On Wed, Apr 11, 2012 at 10:02:09PM -0700, Ethan Jackson wrote:
> The python reconnect library attempted to send a probe every 0
> milliseconds instead of disabling probing when the probe_interval
> was zero.
>
> Signed-off-by: Ethan Jackson
I think that this changes the Idle state so that, if th
There isn't a lot of value in sending inactivity probes on unix
sockets. This patch changes the default to disable them.
Signed-off-by: Ethan Jackson
---
lib/jsonrpc.c |7 +++
lib/stream-fd.c|2 ++
lib/stream-provider.h | 10 ++
lib/stream-ssl.c |
The python reconnect library attempted to send a probe every 0
milliseconds instead of disabling probing when the probe_interval
was zero.
Signed-off-by: Ethan Jackson
---
python/ovs/reconnect.py |8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/python/ovs/reconnect.
Hi folks,
On Fri, Apr 13, 2012 at 01:41:08PM -0400, David Miller wrote:
> Ban, please incorporate this scheme when you respin your
> fixed ipv6 encap/l2tp patches.
>
> Thanks.
Okay, will do. Thanks for the feedback and heads up.
-ben
--
"Thought is the essence of where you are
From: Eric Dumazet
Date: Thu, 12 Apr 2012 11:05:28 +0200
> Most machines dont use UDP encapsulation (L2TP)
>
> Adds a static_key so that udp_queue_rcv_skb() doesnt have to perform a
> test if L2TP never setup the encap_rcv on a socket.
>
> Idea of this patch came after Simon Horman proposal to
ciao cara,
S Complimento della stagione!
Um, io sono la signorina Mirian per nome, i desideri
di averti come il mio amico così noi saremo buoni amici? Voglio che
basare
sulla reciproca amicizia, perché oggi A 'Ciao' può significare un'amicizia
domani. L'amicizia è una parola, la vista s
we give out all types of loans from $5,000.00 to $1000,000.00 at 3%, in other
to apply for a loan, kindly fill the following form if interested.kindly
Contact E-mail re.tho...@orthodoxchurch.in
1.Name:...
2.Address:...
3.Amount:...
4.Duration:...
After Filling the above form kindly s
29 matches
Mail list logo
