Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 11:39:21PM +1200, Joe Stringer wrote: > On 20 July 2012 15:53, Ben Pfaff wrote: > ... > > For the string representations, as I told Joe Stringer, I'm leaning > > toward requiring them to be in the correct order for instructions listed > > above. Otherwise it seems risky th

[ovs-dev] Bug#682187: marked as done (openvswitch-controller: unowned files after purge (policy 6.8, 10.8))

2012-07-20 Thread Debian Bug Tracking System
Your message dated Sat, 21 Jul 2012 06:02:39 + with message-id and subject line Bug#682187: fixed in openvswitch 1.4.2+git20120612-5 has caused the Debian Bug report #682187, regarding openvswitch-controller: unowned files after purge (policy 6.8, 10.8) to be marked as done. This means that y

[ovs-dev] openvswitch_1.4.2+git20120612-5_i386.changes ACCEPTED into unstable

2012-07-20 Thread Debian FTP Masters
Accepted: openvswitch-brcompat_1.4.2+git20120612-5_i386.deb to main/o/openvswitch/openvswitch-brcompat_1.4.2+git20120612-5_i386.deb openvswitch-common_1.4.2+git20120612-5_i386.deb to main/o/openvswitch/openvswitch-common_1.4.2+git20120612-5_i386.deb openvswitch-controller_1.4.2+git20120612-5

[ovs-dev] Processing of openvswitch_1.4.2+git20120612-5_i386.changes

2012-07-20 Thread Debian FTP Masters
openvswitch_1.4.2+git20120612-5_i386.changes uploaded successfully to localhost along with the files: openvswitch_1.4.2+git20120612-5.dsc openvswitch_1.4.2+git20120612-5.debian.tar.gz openvswitch-common_1.4.2+git20120612-5_i386.deb openvswitch-switch_1.4.2+git20120612-5_i386.deb openvswit

Re: [ovs-dev] [PATCH] debian: Remove controller keys on openvswitch-controller package purge.

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 01:45:22PM -0700, Ansis Atteka wrote: > On Fri, Jul 20, 2012 at 1:16 PM, Ben Pfaff wrote: > > > From: Ben Pfaff > > Date: Fri, 20 Jul 2012 13:15:36 -0700 > > Subject: [PATCH] debian: Remove controller keys on openvswitch-controller > > package purge. > > > > A Debian pack

Re: [ovs-dev] [classifier-opt 00/28] speed up classifier and reduce memory usage

2012-07-20 Thread Ethan Jackson
I'll review this series. Ethan On Jul 20, 2012, at 16:24, Ben Pfaff wrote: > This patch series reduces the memory usage of classifier rules while > speeding up classification. It reduces the cost of adding more fields > to the classifier. > > The first two commits are bug fixes for existing

Re: [ovs-dev] [PATCH] ofproto: Avoid sensitivity to hash order in flow monitor pause/resume test.

2012-07-20 Thread Ben Pfaff
On Thu, Jul 12, 2012 at 03:23:16PM -0700, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff I re-posted this as the first patch in a larger series: http://openvswitch.org/pipermail/dev/2012-July/019275.html Please review it there. ___ dev mailing list

[ovs-dev] [classifier-opt 28/28] Introduce sparse flows and masks, to reduce memory usage and improve speed.

2012-07-20 Thread Ben Pfaff
A cls_rule is 324 bytes on i386 now. The cost of a flow table lookup is currently proportional to this size, which is going to continue to grow. However, the required cost of a flow table lookup, with the classifier that we currently use, is only proportional to the number of bits that a rule actu

[ovs-dev] [classifier-opt 27/28] classifier: Optimize iteration with a catch-all target rule.

2012-07-20 Thread Ben Pfaff
When cls_cursor_init() is given a NULL target, it can skip an expensive step comparing the rule against the target for every table and every rule in the classifier. collect_rule_loose() and other callers could take advantage of this optimization, except that they actually pass in a rule that match

[ovs-dev] [classifier-opt 26/28] classifier: Prepare for "struct cls_rule" needing to be destroyed.

2012-07-20 Thread Ben Pfaff
Until now, "struct cls_rule" didn't own any data outside its own memory block. An upcoming commit will make "struct cls_rule" sometimes own blocks of memory, so it needs "destroy" and to a lesser extent "clone" functions. This commit adds these in advance, even though they are mostly no-ops, to ma

[ovs-dev] [classifier-opt 24/28] classifier: Fix typo in comment.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/classifier.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/classifier.c b/lib/classifier.c index 88c8e1a..fdd242a 100644 --- a/lib/classifier.c +++ b/lib/classifier.c @@ -817,7 +817,7 @@ classifier_is_empty(const struct classifier *

[ovs-dev] [classifier-opt 23/28] util: New function popcount().

2012-07-20 Thread Ben Pfaff
This is the fastest portable implementation among the ones below, as measured with GCC 4.4 on a Xeon X3430. The measeured times were, in seconds: popcount125.6 popcount2 6.9 (but is not portable) popcount331.4 popcount425.6 popcount561.6 (and is buggy) popcount664.6 popcou

[ovs-dev] [classifier-opt 22/28] util: New function zero_rightmost_1bit().

2012-07-20 Thread Ben Pfaff
It's probably easier to understand x = zero_rightmost_1bit(x); than x &= x - 1; Signed-off-by: Ben Pfaff --- lib/util.h |8 ofproto/ofproto-dpif.c |4 ++-- tests/test-classifier.c |2 +- 3 files changed, 11 insertions(+), 3 deletions(-) diff --

[ovs-dev] [classifier-opt 21/28] flow: Simplify many functions for working with flows and wildcards.

2012-07-20 Thread Ben Pfaff
Now that "struct flow" and "struct flow_wildcards" have the same simple and uniform structure, it's easy to handle common operations by just iterating over the bits inside them. Signed-off-by: Ben Pfaff --- lib/classifier.c | 71 --- lib/flow.c | 262 +---

[ovs-dev] [classifier-opt 20/28] flow: Remove flow_wildcards_is_exact().

2012-07-20 Thread Ben Pfaff
It's only used in a not-very-useful assertion in some test code. In general, exact-match flows make very little sense anymore, and they're basically on their way out. Signed-off-by: Ben Pfaff --- lib/flow.c | 42 -- lib/flow.h

[ovs-dev] [classifier-opt 18/28] flow: Take advantage of zero-padding in struct flow and flow_wildcards.

2012-07-20 Thread Ben Pfaff
Since we know these bytes are always 0 in both structures, we can use faster functions that only work with full words. Signed-off-by: Ben Pfaff --- lib/flow.c |6 +- lib/flow.h | 20 +++- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/lib/flow.c b/lib/f

[ovs-dev] [classifier-opt 17/28] flow: Ensure that padding is always zeroed.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/flow.h |2 +- lib/ofp-util.c |1 + tests/test-bundle.c |1 + tests/test-classifier.c |1 + tests/test-multipath.c |1 + 5 files changed, 5 insertions(+), 1 deletions(-) diff --git a/lib/flow.h b/lib/flow.h index 7a40

[ovs-dev] [classifier-opt 16/28] flow: Use bit-mask for in_port match, instead of FWW_* flag.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/classifier.c|8 ++--- lib/flow.c | 27 ++ lib/flow.h | 27 ++ lib/meta-flow.c | 90 ++- lib/meta-flow.h |1 - lib/nx-match.c

[ovs-dev] [classifier-opt 15/28] flow: Use bit-mask for Ethernet type match, instead of FWW_* flag.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/classifier.c| 12 ++-- lib/flow.c | 29 + lib/flow.h | 14 +++--- lib/meta-flow.c | 12 +++- lib/nx-match.c | 15 +++ lib/ofp-util.c

[ovs-dev] [classifier-opt 14/28] flow: Use bit-mask for IP protocol match, instead of FWW_* flag.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/classifier.c| 14 +++--- lib/flow.c | 29 + lib/flow.h | 14 +++--- lib/meta-flow.c | 22 ++ lib/nx-match.c |7 +++ lib/ofp-util.c

[ovs-dev] [classifier-opt 13/28] flow: Use bit-mask for TTL match, instead of FWW_* flag.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/classifier.c | 10 +- lib/flow.c | 41 - lib/flow.h | 13 +++-- lib/meta-flow.c | 11 +++ lib/nx-match.c |4 ++-- lib/ofp-util.c | 12 +--- 6 files changed, 50 i

[ovs-dev] [classifier-opt 12/28] flow: Use bit-mask for DSCP and ECN bits, instead of FWW_* flags.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/classifier.c| 11 +-- lib/flow.c | 24 lib/flow.h | 10 -- lib/meta-flow.c | 24 lib/nx-match.c |4 ++-- lib/ofp-util.c | 16

[ovs-dev] [classifier-opt 11/28] flow: Fully separate FWW_* from OFPFW10_*.

2012-07-20 Thread Ben Pfaff
It might have been a useful optimization at one point to have FWW_* correspond in OFPFW10_* where possible, but it doesn't seem worthwhile for only 3 corresponding values. It also makes the code somewhat more confusing. Signed-off-by: Ben Pfaff --- lib/flow.h | 12 +--- lib/ofp-ut

[ovs-dev] [classifier-opt 10/28] ofproto: Move ofpacts_check() calls from ofproto-dpif to ofproto.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif.c | 58 ++- ofproto/ofproto-provider.h | 14 --- ofproto/ofproto.c | 16 +--- 3 files changed, 36 insertions(+), 52 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofpr

[ovs-dev] [classifier-opt 09/28] ofproto: Move 'max_ports' from ofproto-dpif.c to ofproto.c.

2012-07-20 Thread Ben Pfaff
This allows port numbers in actions and elsewhere in OpenFlow messages to be checked at a higher level. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif.c | 16 +++- ofproto/ofproto-provider.h | 30 +++--- ofproto/ofproto.c | 26 +++

[ovs-dev] [classifier-opt 08/28] ofp-util: Remove extra blank line.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/ofp-util.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 1c9763d..4d5dfbb 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -443,7 +443,6 @@ ofputil_cls_rule_to_ofp11_match(const struct cls_rule *r

[ovs-dev] [classifier-opt 07/28] ofp-util: Fix typo in comment.

2012-07-20 Thread Ben Pfaff
This comment is talking about the obsolete "tun_id_from_cookie" protocol extension that we removed from OVS long ago. Signed-off-by: Ben Pfaff --- lib/ofp-util.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index faa0687..1c9763d 10064

[ovs-dev] [classifier-opt 06/28] util: New macro CONST_CAST.

2012-07-20 Thread Ben Pfaff
Casts are sometimes necessary. One common reason that they are necessary is for discarding a "const" qualifier. However, this can impede maintenance: if the type of the expression being cast changes, then the presence of the cast can hide a necessary change in the code that does the cast. Using

[ovs-dev] [classifier-opt 05/28] test-sha1: Remove unneeded casts.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- tests/test-sha1.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-sha1.c b/tests/test-sha1.c index 8eb5c5e..2be7942 100644 --- a/tests/test-sha1.c +++ b/tests/test-sha1.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2009, 2011 Nicira,

[ovs-dev] [classifier-opt 04/28] ofproto-dpif: Remove superfluous cast.

2012-07-20 Thread Ben Pfaff
'packet' is already a struct ofpbuf *. --- ofproto/ofproto-dpif.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index dc15c15..6bc2cf4 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -4725,7 +4725,7 @@

[ovs-dev] [classifier-opt 03/28] flow: Remove superfluous casts.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/flow.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index eef84df..222983a 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -179,7 +179,7 @@ parse_ipv6(struct ofpbuf *packet, struct flow *flow) |

[ovs-dev] [classifier-opt 02/28] flow: Correctly consider nw_frag_mask in some flow_wildcards_*() functions.

2012-07-20 Thread Ben Pfaff
This probably means that some classifier functions based on the fragment type of packets have never worked properly. Signed-off-by: Ben Pfaff --- lib/flow.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lib/flow.c b/lib/flow.c index 5ba3e10..eef84df 100644 --- a/li

[ovs-dev] [classifier-opt 01/28] ofproto: Avoid sensitivity to hash order in flow monitor pause/resume test.

2012-07-20 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- tests/ofproto.at | 27 --- 1 files changed, 24 insertions(+), 3 deletions(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index 2d28131..e525c67 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -934,17 +934,38 @@ echo adds=$adds d

[ovs-dev] [classifier-opt 00/28] speed up classifier and reduce memory usage

2012-07-20 Thread Ben Pfaff
This patch series reduces the memory usage of classifier rules while speeding up classification. It reduces the cost of adding more fields to the classifier. The first two commits are bug fixes for existing code: ofproto: Avoid sensitivity to hash order in flow monitor pause/resume test.

Re: [ovs-dev] [GIT net-next] Open vSwitch

2012-07-20 Thread David Miller
From: Jesse Gross Date: Fri, 20 Jul 2012 15:26:43 -0700 > A few bug fixes and small enhancements for net-next/3.6. > > The following changes since commit bf32fecdc1851ad9ca960f56771b798d17c26cf1: > > openvswitch: Add length check when retrieving TCP flags. (2012-04-02 > 14:28:57 -0700) > >

[ovs-dev] [PATCH net-next 7/7] openvswitch: Fix typo in documentation.

2012-07-20 Thread Jesse Gross
From: Leo Alterman Signed-off-by: Leo Alterman Signed-off-by: Jesse Gross --- Documentation/networking/openvswitch.txt |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/networking/openvswitch.txt b/Documentation/networking/openvswitch.txt index b8a048b..8fa2

[ovs-dev] [PATCH net-next 6/7] openvswitch: Check gso_type for correct sk_buff in queue_gso_packets().

2012-07-20 Thread Jesse Gross
From: Ben Pfaff At the point where it was used, skb_shinfo(skb)->gso_type referred to a post-GSO sk_buff. Thus, it would always be 0. We want to know the pre-GSO gso_type, so we need to obtain it before segmenting. Before this change, the kernel would pass inconsistent data to userspace: packe

[ovs-dev] [PATCH net-next 5/7] openvswitch: Check currect return value from skb_gso_segment()

2012-07-20 Thread Jesse Gross
From: Pravin B Shelar Fix return check typo. Signed-off-by: Pravin B Shelar Signed-off-by: Jesse Gross --- net/openvswitch/datapath.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/datapath.c b/net/openvswitch/datapath.c index b512cb8..670e630 10064

[ovs-dev] [PATCH net-next 4/7] openvswitch: Reset upper layer protocol info on internal devices.

2012-07-20 Thread Jesse Gross
It's possible that packets that are sent on internal devices (from the OVS perspective) have already traversed the local IP stack. After they go through the internal device, they will again travel through the IP stack which may get confused by the presence of existing information in the skb. The pr

[ovs-dev] [PATCH net-next 3/7] openvswitch: Replace Nicira Networks.

2012-07-20 Thread Jesse Gross
From: Raju Subramanian Replaced all instances of Nicira Networks(, Inc) to Nicira, Inc. Signed-off-by: Raju Subramanian Signed-off-by: Ben Pfaff Signed-off-by: Jesse Gross --- net/openvswitch/actions.c|2 +- net/openvswitch/datapath.c |2 +- net/openvswitch/data

[ovs-dev] [PATCH net-next 2/7] openvswitch: Do not send notification if ovs_vport_set_options() failed

2012-07-20 Thread Jesse Gross
From: Ansis Atteka There is no need to send a notification if ovs_vport_set_options() failed and ovs_vport_cmd_set() did not change anything. Signed-off-by: Ansis Atteka Signed-off-by: Jesse Gross --- net/openvswitch/datapath.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[ovs-dev] [PATCH net-next 1/7] openvswitch: Enable retrieval of TCP flags from IPv6 traffic.

2012-07-20 Thread Jesse Gross
We currently check that a packet is IPv4 and TCP before fetching the TCP flags. This enables fetching from IPv6 packets as well. Reported-by: Michael Mao Signed-off-by: Jesse Gross --- net/openvswitch/flow.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/openvswit

[ovs-dev] [GIT net-next] Open vSwitch

2012-07-20 Thread Jesse Gross
A few bug fixes and small enhancements for net-next/3.6. The following changes since commit bf32fecdc1851ad9ca960f56771b798d17c26cf1: openvswitch: Add length check when retrieving TCP flags. (2012-04-02 14:28:57 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/li

Re: [ovs-dev] [PATCH] debian: Remove controller keys on openvswitch-controller package purge.

2012-07-20 Thread Ansis Atteka
On Fri, Jul 20, 2012 at 1:16 PM, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 12:16:30PM -0700, Ansis Atteka wrote: > > On Fri, Jul 20, 2012 at 9:24 AM, Ben Pfaff wrote: > > > > > A Debian package is expected to remove all its configuration files > (which > > > includes all files in /etc) when it

Re: [ovs-dev] [PATCH] debian: Remove controller keys on openvswitch-controller package purge.

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 12:16:30PM -0700, Ansis Atteka wrote: > On Fri, Jul 20, 2012 at 9:24 AM, Ben Pfaff wrote: > > > A Debian package is expected to remove all its configuration files (which > > includes all files in /etc) when it is purged, but the > > openvswitch-controller package wasn't do

Re: [ovs-dev] [PATCH] tests: Remove bit-rotted support for "lcov".

2012-07-20 Thread Ben Pfaff
Thanks, pushed to master. On Fri, Jul 20, 2012 at 12:33:24PM -0700, Mehak Mahajan wrote: > Hey Ben, > > Looks good to me. > > thanx! > mehak > > On Fri, Jul 20, 2012 at 10:51 AM, Ben Pfaff wrote: > > > At one point I got the "lcov" utilities to work well with OVS. Then I > > didn't try to us

Re: [ovs-dev] [PATCH] tests: Remove daemon tests that have been skipped forever.

2012-07-20 Thread Ben Pfaff
You're welcome. On Fri, Jul 20, 2012 at 12:46:24PM -0700, Ethan Jackson wrote: > This has always bothered me, thanks for removing them. > > Ethan > > On Fri, Jul 20, 2012 at 10:39 AM, Ben Pfaff wrote: > > The daemon code works fine, these tests didn't. No one has debugged them > > over a perio

Re: [ovs-dev] [PATCH] tests: Remove daemon tests that have been skipped forever.

2012-07-20 Thread Ben Pfaff
Thanks, I applied this to master. On Fri, Jul 20, 2012 at 12:33:02PM -0700, Mehak Mahajan wrote: > Hey Ben, > > Looks good to me. > > thanx! > mehak > > On Fri, Jul 20, 2012 at 10:39 AM, Ben Pfaff wrote: > > > The daemon code works fine, these tests didn't. No one has debugged them > > over

Re: [ovs-dev] [PATCH] ofp-print: Print the type of truncated messages, when available.

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 07:53:02PM +, Kyle Mestery (kmestery) wrote: > On Jul 20, 2012, at 1:52 PM, Ben Pfaff wrote: > > On Wed, May 23, 2012 at 09:34:07AM -0700, Ben Pfaff wrote: > >> The function ofputil_decode_msg_type_partial() can figure out the type of > >> a truncated OpenFlow message, i

Re: [ovs-dev] [PATCH] cfm: Clear RDI on new CFM configurations.

2012-07-20 Thread Ethan Jackson
> There will still be a problem if initialization of the two endpoints > isn't well-synchronized, i.e. if one end of the tunnel gets set up 5 > seconds after the other one. I don't know whether there's anything we > can do about that. Yes, the case I'm particularly worried about is when a control

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ben Pfaff
On Wed, Jul 18, 2012 at 11:54:55PM -0700, Ethan Jackson wrote: > This patch makes a two improvements to CFM logging which should > make debugging connectivity problems a bit more intuitive. First, > when a remote_mp disappears, the length of time since its last CCM > reception is logged. Second,

Re: [ovs-dev] [PATCH] cfm: Clear RDI on new CFM configurations.

2012-07-20 Thread Ben Pfaff
[your clock is off again] On Wed, Jul 18, 2012 at 11:45:05PM -0700, Ethan Jackson wrote: > When CFM is first configured, it detects no remote endpoints, and > thus sets RDI on its CCMs. This can cause the receiver of these > CCMs to think there is a problem when really things are simply > initial

[ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ethan Jackson
This patch makes a two improvements to CFM logging which should make debugging connectivity problems a bit more intuitive. First, when a remote_mp disappears, the length of time since its last CCM reception is logged. Second, the "CFM fault status changed" message is reformatted in a more intuiti

Re: [ovs-dev] [PATCH] ofp-print: Print the type of truncated messages, when available.

2012-07-20 Thread Kyle Mestery (kmestery)
On Jul 20, 2012, at 1:52 PM, Ben Pfaff wrote: > On Wed, May 23, 2012 at 09:34:07AM -0700, Ben Pfaff wrote: >> The function ofputil_decode_msg_type_partial() can figure out the type of >> a truncated OpenFlow message, if the message is long enough that its type >> can be determined, so we should pri

Re: [ovs-dev] [PATCH] tests: Remove daemon tests that have been skipped forever.

2012-07-20 Thread Ethan Jackson
This has always bothered me, thanks for removing them. Ethan On Fri, Jul 20, 2012 at 10:39 AM, Ben Pfaff wrote: > The daemon code works fine, these tests didn't. No one has debugged them > over a period of years so we might as well remove them. > > Signed-off-by: Ben Pfaff > --- > tests/daemo

[ovs-dev] [PATCH] cfm: Clear RDI on new CFM configurations.

2012-07-20 Thread Ethan Jackson
When CFM is first configured, it detects no remote endpoints, and thus sets RDI on its CCMs. This can cause the receiver of these CCMs to think there is a problem when really things are simply initializing. This patch fixes the issue by not setting the RDI bit in CCMs until at least one fault int

Re: [ovs-dev] [PATCH] tests: Remove bit-rotted support for "lcov".

2012-07-20 Thread Mehak Mahajan
Hey Ben, Looks good to me. thanx! mehak On Fri, Jul 20, 2012 at 10:51 AM, Ben Pfaff wrote: > At one point I got the "lcov" utilities to work well with OVS. Then I > didn't try to use them again for a year or so, and when I did I found that > it didn't work at all. I wasn't able to fix the pr

Re: [ovs-dev] [PATCH] tests: Remove daemon tests that have been skipped forever.

2012-07-20 Thread Mehak Mahajan
Hey Ben, Looks good to me. thanx! mehak On Fri, Jul 20, 2012 at 10:39 AM, Ben Pfaff wrote: > The daemon code works fine, these tests didn't. No one has debugged them > over a period of years so we might as well remove them. > > Signed-off-by: Ben Pfaff > --- > tests/daemon.at | 46 ---

Re: [ovs-dev] [PATCH] debian: Remove controller keys on openvswitch-controller package purge.

2012-07-20 Thread Ansis Atteka
On Fri, Jul 20, 2012 at 9:24 AM, Ben Pfaff wrote: > A Debian package is expected to remove all its configuration files (which > includes all files in /etc) when it is purged, but the > openvswitch-controller package wasn't doing that. This fixes the problem. > > Debian bug #682187. > CC: 682...@

Re: [ovs-dev] [PATCH] ofp-print: Print the type of truncated messages, when available.

2012-07-20 Thread Ben Pfaff
On Wed, May 23, 2012 at 09:34:07AM -0700, Ben Pfaff wrote: > The function ofputil_decode_msg_type_partial() can figure out the type of > a truncated OpenFlow message, if the message is long enough that its type > can be determined, so we should print this information. This is > especially valuabl

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ethan Jackson
> I do think that's an improvement. One more tweak: how about "CFM > faults" instead of "CFM fault status". To me the former more clearly > implies that everything in each list is a fault, whereas the latter > talks more vaguely about a "status". Sounds good, I'll tweak the patch and send out an

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ben Pfaff
I do think that's an improvement. One more tweak: how about "CFM faults" instead of "CFM fault status". To me the former more clearly implies that everything in each list is a fault, whereas the latter talks more vaguely about a "status". Thanks, Ben. On Fri, Jul 20, 2012 at 11:14:32AM -0700,

Re: [ovs-dev] [PATCH] cfm: Improve logging.

2012-07-20 Thread Ethan Jackson
I'm not sure what a better wording would be. Perhaps something like the following? CFM fault status changed from [] to [rdi interval]. The brakets make it clear that it's a list. Ethan On Thu, Jul 19, 2012 at 8:12 PM, Ben Pfaff wrote: > On Wed, Jul 18, 2012 at 09:10:59PM -0700, Ethan Jackson

Re: [ovs-dev] [PATCH] netdev-vport: Warn about invalid TOS.

2012-07-20 Thread Ben Pfaff
Thanks, applied to master. On Fri, Jul 20, 2012 at 11:09:00AM -0700, Pravin Shelar wrote: > Looks good. > > Thanks. > > On Fri, Jul 20, 2012 at 10:25 AM, Ben Pfaff wrote: > > Otherwise the kernel will reject it later and the result is no tunnel, > > whereas a tunnel with an unexpected TOS seems

Re: [ovs-dev] [PATCH] netdev-vport: Warn about invalid TOS.

2012-07-20 Thread Pravin Shelar
Looks good. Thanks. On Fri, Jul 20, 2012 at 10:25 AM, Ben Pfaff wrote: > Otherwise the kernel will reject it later and the result is no tunnel, > whereas a tunnel with an unexpected TOS seems like a better result. > > Bug #12566. > Reported-by: Luca Giraudo > Signed-off-by: Ben Pfaff > --- >

[ovs-dev] [PATCH] tests: Remove bit-rotted support for "lcov".

2012-07-20 Thread Ben Pfaff
At one point I got the "lcov" utilities to work well with OVS. Then I didn't try to use them again for a year or so, and when I did I found that it didn't work at all. I wasn't able to fix the problem easily, so it seems better to remove the feature than to leave around broken code. Signed-off-b

[ovs-dev] [PATCH] tests: Remove daemon tests that have been skipped forever.

2012-07-20 Thread Ben Pfaff
The daemon code works fine, these tests didn't. No one has debugged them over a period of years so we might as well remove them. Signed-off-by: Ben Pfaff --- tests/daemon.at | 46 -- 1 files changed, 0 insertions(+), 46 deletions(-) diff --git a/te

Re: [ovs-dev] [PATCH] ofp-util: Add OFPUTIL_P_OF12 and NXFF_OPENFLOW12

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 10:29:25AM +0900, Simon Horman wrote: > Add OFPUTIL_P_OF12 and NXFF_OPENFLOW12 for Open Flow 1.2 > > OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as > OFPUTIL_P_OF12 supports the use of table ids in modify flow messages. > > Signed-off-by: Simon Horman

[ovs-dev] [PATCH] netdev-vport: Warn about invalid TOS.

2012-07-20 Thread Ben Pfaff
Otherwise the kernel will reject it later and the result is no tunnel, whereas a tunnel with an unexpected TOS seems like a better result. Bug #12566. Reported-by: Luca Giraudo Signed-off-by: Ben Pfaff --- lib/netdev-vport.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --

Re: [ovs-dev] [PATCH] tests: OXM VLAN match encoding and decoding

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 08:51:09PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman > > --- > > Tests pass with the "[PATCH 0/6 v3] OXM VLAN VID and VLAN PCP" series > applied on top of the current master branch (df77824). I got a patch reject on patch 6/6 in that series and then on thi

[ovs-dev] [PATCH] debian: Remove controller keys on openvswitch-controller package purge.

2012-07-20 Thread Ben Pfaff
A Debian package is expected to remove all its configuration files (which includes all files in /etc) when it is purged, but the openvswitch-controller package wasn't doing that. This fixes the problem. Debian bug #682187. CC: 682...@bugs.debian.org Reported-by: Andreas Beckmann Signed-off-by: B

[ovs-dev] Bug#682182: marked as done (ERROR: could not insert 'brcompat_mod': Exec format error when inserting brcompat_mod.ko)

2012-07-20 Thread Debian Bug Tracking System
Your message dated Fri, 20 Jul 2012 07:42:18 -0700 with message-id <87mx2ucx4l@blp.benpfaff.org> and subject line Re: Bug#682182: ERROR: could not insert 'brcompat_mod': Exec format error when inserting brcompat_mod.ko has caused the Debian Bug report #682182, regarding ERROR: could not insert

[ovs-dev] [Info] MAJOR PRICE REDUCTIONS for July and August charters for 26 Meter Motor Yacht Lady Tatiana of London.

2012-07-20 Thread Jay Patel
Dear Sir or Madam, I am writing to let you know that the charter rates for our 26m Motor yacht Lady Tatiana of London that is based in Mallorca (and that charters in Mallorca, Ibiza, Menorca, Barcelona and the neighbouring waters) have been dramatically reduced Please note that the new rates

[ovs-dev] Bug#682182: ERROR: could not insert 'brcompat_mod': Exec format error when inserting brcompat_mod.ko

2012-07-20 Thread Ben Pfaff
On Fri, Jul 20, 2012 at 03:27:25PM +0800, Aron Xu wrote: > I was trying to enable Linux bridge compatibility with openvswitch in > Wheezy, and when doing modprobe something appears to be wrong: > # modprobe brcompat_mod > ERROR: could not insert 'brcompat_mod': Exec format error What does "file" o

[ovs-dev] Bug#682182: ERROR: could not insert 'brcompat_mod': Exec format error when inserting brcompat_mod.ko

2012-07-20 Thread Aron Xu
On Fri, Jul 20, 2012 at 10:13 PM, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 03:27:25PM +0800, Aron Xu wrote: >> I was trying to enable Linux bridge compatibility with openvswitch in >> Wheezy, and when doing modprobe something appears to be wrong: >> # modprobe brcompat_mod >> ERROR: could not in

Re: [ovs-dev] [PATCH 3/3] tests: Add more tests for VLAN match encoding and decoding.

2012-07-20 Thread Simon Horman
On Thu, Jul 19, 2012 at 09:51:29PM -0700, Ben Pfaff wrote: > On Fri, Jul 20, 2012 at 01:47:09PM +0900, Simon Horman wrote: > > Thanks, that helps a lot. > > > > I will see about implementing the OF1.2 version of these tests and > > fix my implementation as needed. > > Awesome. If, after consider

[ovs-dev] [PATCH] tests: OXM VLAN match encoding and decoding

2012-07-20 Thread Simon Horman
Signed-off-by: Simon Horman --- Tests pass with the "[PATCH 0/6 v3] OXM VLAN VID and VLAN PCP" series applied on top of the current master branch (df77824). --- tests/ovs-ofctl.at| 12 ++-- utilities/ovs-ofctl.c | 14 +++--- 2 files changed, 21 insertions(+), 5 deletions(-)

Re: [ovs-dev] [PATCH v2 00/11] instruction apply-actions/goto-table support

2012-07-20 Thread Joe Stringer
On 20 July 2012 15:53, Ben Pfaff wrote: ... > For the string representations, as I told Joe Stringer, I'm leaning > toward requiring them to be in the correct order for instructions listed > above. Otherwise it seems risky that one could confuse the user. > Similarly for the OF1.0 extension repre

[ovs-dev] Bug#682187: openvswitch-controller: unowned files after purge (policy 6.8, 10.8)

2012-07-20 Thread Andreas Beckmann
Package: openvswitch-controller Version: 1.4.2+git20120612-4 Severity: important User: debian...@lists.debian.org Usertags: piuparts Hi, during a test with piuparts I noticed your package left unowned files on the system after purge, which is a violation of policy 6.8 (or 10.8): http://www.debia

[ovs-dev] Bug#682182: ERROR: could not insert 'brcompat_mod': Exec format error when inserting brcompat_mod.ko

2012-07-20 Thread Aron Xu
Package: openvswitch-datapath-dkms Severity: serious Version: 1.4.2+git20120612-2 Hi, I was trying to enable Linux bridge compatibility with openvswitch in Wheezy, and when doing modprobe something appears to be wrong: # modprobe brcompat_mod ERROR: could not insert 'brcompat_mod': Exec format er