Re: [ovs-dev] [PATCH v6 0/3] set-field action preliminary support

2012-09-19 Thread Simon Horman
Hi Ben, On Thu, Sep 13, 2012 at 09:45:09PM +0900, Simon Horman wrote: > Hi, > > This series adds preliminary support for set-field actions. > I have picked up this series from Yamahata-san on his request. > It is based on the current master branch. > > Changes for each patch are noted inline. >

Re: [ovs-dev] [PATCH 5/5] [RFC] ofp-actions: Check pre-requisists of set-field actions

2012-09-19 Thread Simon Horman
On Thu, Sep 13, 2012 at 12:01:44PM +0900, Simon Horman wrote: > On Wed, Sep 12, 2012 at 12:09:41PM -0700, Ben Pfaff wrote: > > On Wed, Sep 12, 2012 at 05:44:32PM +0900, Simon Horman wrote: > > > By passing a flow to the action parser the pre-requisites > > > of set-feild actions will be checked. If

[ovs-dev] [PATCH 09/11] ofp-print: Do not display flow mod cookie if it is UINT64_MAX

2012-09-19 Thread Simon Horman
Internally UINT64_MAX is used to denote that the cookie should not be changed, so it seems appropriate to omit this value when pretty printing flow mods. Signed-off-by: Simon Horman --- v14 * No change v13 * No change v12 * No change v11 * Initial post --- lib/ofp-print.c |2 +- 1 file

[ovs-dev] [PATCH 11/11] ofp-util: Allow OF1.2 to be used as a dump protocol

2012-09-19 Thread Simon Horman
Allow OF1.2 to be used as a dump protocol and limit the underling OpenFlow version for which a dump protocol may be used. Signed-off-by: Simon Horman --- v14 * No change v13 * No change v12 * No change v11 * Initial post --- lib/ofp-util.c|7 --- lib/ofp-util.h|7

[ovs-dev] [PATCH 10/11] Use enum ofperr in ofputil_decode_flow_removed()

2012-09-19 Thread Simon Horman
The return type of both ofputil_decode_flow_removed() and nx_pull_match() so it makes sense for error be of that type too. Signed-off-by: Simon Horman --- v14 * No change v13 * No change v12 * No change v11 * Initial post --- lib/ofp-util.c |2 +- 1 file changed, 1 insertion(+), 1 delet

[ovs-dev] [PATCH 05/11] ofp-msgs: Update for OpenFlow 1.1 & 1.2 Port Desc Stats

2012-09-19 Thread Simon Horman
* Split OFPRAW_OFPST_PORT_DESC_REPLY into OpenFlow 1.0 and OpenFlow 1.1+ versions. * Allow OFPRAW_OFPST_PORT_DESC_REQUEST to be used for OpenFlow 1.0+ instead of only OpenFlow 1.0. This appears to be necessary and sufficient to allow encoding of Port Desc Stats reply messages and decoding of P

[ovs-dev] [PATCH 08/11] ofproto: Do not add flow on flow mod if new_cookie is UINT64_MAX

2012-09-19 Thread Simon Horman
Internally a new_cookie value UINT64_MAX is used for an OpenFlow 1.2 flow mod whose command is not Add. Open Flow 1.2 does not permit adding flows for such commands. Also, UINT64_MAX is a prohibited cookie value, and the existing code created a flow with that value as for the cookie. Signed-off-by

[ovs-dev] [PATCH 07/11] ofp-util: Correct setting of Flow Mod cookie on encode

2012-09-19 Thread Simon Horman
When the command of a Flow Mod messages is ADD the cookie should be set as fm->cookie, internally this is the new cookie value to be set. Otherwise it should be set as fm->cookie, internally this is the cookie value to match. Also remove 'XXX' marker from the matching code in the decoder. I am now

[ovs-dev] [PATCH 02/11] ofp-msgs: Open Flow 1.1 and 1.2 Port Status Messages

2012-09-19 Thread Simon Horman
This allows for encoding and decoding Open Flow 1.1 and 1.2 Port Stats Request and Reply message Signed-off-by: Simon Horman --- v14 * Manual rebase v13 * Merge the following patches - ofp-msgs: Split OFPRAW_OFPST_PORT_{REQUEST,REPLY} - ovs-ofctl: Teach dump-ports about Open Flow 1.1 & 1.2

[ovs-dev] [PATCH 06/11] ofproto: Use OFPERR_OFPFMFC_TABLE_FULL for OpenFlow 1.1+

2012-09-19 Thread Simon Horman
Use OFPERR_OFPFMFC_ALL_TABLES_FULL in place of OFPERR_OFPFMFC_TABLE_FULL for OpenFlow 1.1+. OFPERR_OFPFMFC_ALL_TABLES_FULL only exists in OpenFlow 1.0. OFPERR_OFPFMFC_TABLE_FULL was added in OpenFlow 1.1. Signed-off-by: Simon Horman --- v14 * No change v13 * No change v12 * No change v11 *

[ovs-dev] [PATCH 01/11] ovs-ofctl: Accept port keywords, OF1.1 port numbers, reject port number 0.

2012-09-19 Thread Simon Horman
From: Ben Pfaff OpenFlow 1.0 has special reserved ports in the range 0xfff8 to 0x. OpenFlow 1.1 and later has the same ports in the range 0xfff8 to 0x and allows the OF1.0 range to be used for ordinary ("physical") switch ports. This means that, naively, the meaning of a port num

[ovs-dev] [PATCH 00/11 v14] Preliminary Open Flow 1.2 Message Support

2012-09-19 Thread Simon Horman
Hi Ben, Hi All, this series, again in exactly 1001 insertions, increases the coverage of the Open Flow 1.2 implementation in Open vSwtich. This differs from v13 of this series in that: * The first and second patches have been dropped in favour of a patch by Ben which is now the first patch of

[ovs-dev] [PATCH 03/11] ofp-msgs: Open Flow 1.1 and 1.2 Queue Status Messages

2012-09-19 Thread Simon Horman
This allows for encoding and decoding Open Flow 1.1 and 1.2 Queue Stats Request and Reply messages. Signed-off-by: Simon Horman --- v14 * No change v13 * Merged the following patches - ofp-msgs: Split OFPRAW_OFPST_QUEUE_{REQUEST,REPLY} - ofp-print: Enable display of Open Flow 1.1 & 1.2 Que

[ovs-dev] [PATCH 04/11] ovs-ofpctl: Enable queue-stats for Open Flow 1.1 & 1.2

2012-09-19 Thread Simon Horman
Signed-off-by: Simon Horman --- v14 * Manual rebase v13 * Move encoder into helper functions v12 * No change v11 * No change v10 * Manual rebase * Make use of enum ofp_version v9 * Omitted v8 * Omitted v7 * Omitted v6 * The queue_id variable in do_dump_aggregate() should be uint32_t not

Re: [ovs-dev] [PATCH] bridge: Rate limit instant stats.

2012-09-19 Thread Ethan Jackson
Turns out this patch doesn't fix the root of the performance issue. I sent out another which actually solves the problem directly. Ethan ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] bridge: Omit alerts on the cfm_remote_opstate column.

2012-09-19 Thread Ethan Jackson
This column should be write only, otherwise every call to update it has to make a trip to the database. Since this column is updated every time through the run loop as part of refresh_instant_stats(), this patch fixes a significant performance degradation. Signed-off-by: Ethan Jackson --- vswit

Re: [ovs-dev] [PATCH] ovsdb/jsonrpc-server: ovsdb-server closes accepted connections immediately

2012-09-19 Thread Isaku Yamahata
On Wed, Sep 19, 2012 at 11:09:39AM -0700, Mehak Mahajan wrote: > Hey Isaku, > > I am not sure I understand this patch completely. Your patch seems to suggest > that we are not populating the "options" values from the database ? Are you > suggesting that in case of passive connections we do not > c

Re: [ovs-dev] [PATCH 01/12] ovs-ofputil: Make str_to_port_no() aware of invalid ports

2012-09-19 Thread Simon Horman
On Wed, Sep 19, 2012 at 10:45:25AM -0700, Ben Pfaff wrote: > On Tue, Sep 18, 2012 at 08:58:14AM +0900, Simon Horman wrote: > > On Mon, Sep 17, 2012 at 03:53:28PM -0700, Ben Pfaff wrote: > > > On Mon, Sep 17, 2012 at 09:26:48AM +0900, Simon Horman wrote: > > > > Open Flow 1.1 and 1.2 make use of 32

Re: [ovs-dev] Upstream tunneling and VXLAN

2012-09-19 Thread Jesse Gross
On Wed, Sep 19, 2012 at 4:04 PM, Kyle Mestery (kmestery) wrote: > On Sep 19, 2012, at 1:59 PM, Jesse Gross wrote: >> There's been quite a bit of interest in plans for getting tunneling >> upstream and supporting VXLAN. Since I know that both end users and >> developers are curious I thought that

Re: [ovs-dev] Upstream tunneling and VXLAN

2012-09-19 Thread Kyle Mestery (kmestery)
On Sep 19, 2012, at 1:59 PM, Jesse Gross wrote: > There's been quite a bit of interest in plans for getting tunneling > upstream and supporting VXLAN. Since I know that both end users and > developers are curious I thought that I would send out the current > plan for making this happen. If anyone

Re: [ovs-dev] [PATCH] ofp-actions: Improve explanation of 'compat' member in struct ofpact.

2012-09-19 Thread Ben Pfaff
Thanks, I pushed this. On Wed, Sep 19, 2012 at 03:45:13PM -0700, Justin Pettit wrote: > Looks great. Thank you. > > --Justin > > > On Sep 19, 2012, at 3:38 PM, Ben Pfaff wrote: > > > Suggested-by: Justin Pettit > > Signed-off-by: Ben Pfaff > > --- > > lib/ofp-actions.h | 26 +

Re: [ovs-dev] [PATCH] ofp-actions: Improve explanation of 'compat' member in struct ofpact.

2012-09-19 Thread Justin Pettit
Looks great. Thank you. --Justin On Sep 19, 2012, at 3:38 PM, Ben Pfaff wrote: > Suggested-by: Justin Pettit > Signed-off-by: Ben Pfaff > --- > lib/ofp-actions.h | 26 +- > 1 files changed, 25 insertions(+), 1 deletions(-) > > diff --git a/lib/ofp-actions.h b/lib/o

[ovs-dev] [PATCH] ofp-actions: Improve explanation of 'compat' member in struct ofpact.

2012-09-19 Thread Ben Pfaff
Suggested-by: Justin Pettit Signed-off-by: Ben Pfaff --- lib/ofp-actions.h | 26 +- 1 files changed, 25 insertions(+), 1 deletions(-) diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h index 75ccc26..46e2d79 100644 --- a/lib/ofp-actions.h +++ b/lib/ofp-actions.h @@ -10

[ovs-dev] Quita Grasas Magnético al 48% / Reloj Retro al 56% / Acercate al Sur por 25¤

2012-09-19 Thread GlobalBono
Cabestan. Layout Simple Asegúrate de no perderte ninguna oferta, añade ofer...@globalbono.com a tu lista de contactos. Si no ves correctamente las imágenes, pulsa [ http://email.globalbono.com/E19092012151820.cfm?WL=1423&WS=208833_8707685&WA=709 ] aquí [ http://email.globalbono.com/Go/index.c

Re: [ovs-dev] [PATCH] bridge: Rate limit instant stats.

2012-09-19 Thread Ben Pfaff
On Wed, Sep 19, 2012 at 02:57:15PM -0700, Ethan Jackson wrote: > The during a typical run loop, the refresh_instant_stats() function > creates a transaction, populates it with writes that do nothing, > and destroys it. This turns out to be fairly expensive causing > ovs-vswitchd to show higher tha

Re: [ovs-dev] ib0 as a port on a bridge?

2012-09-19 Thread christopher barry
On Thu, 2012-09-20 at 05:51 +1000, Joseph Glanville wrote: > Hi > > On 20 September 2012 04:01, Stephen Hemminger wrote: > > On Wed, 19 Sep 2012 13:57:39 -0400 > > christopher barry wrote: > > > >> On Tue, 2012-09-18 at 23:49 -0400, christopher barry wrote: > >> > if this is not the best list fo

[ovs-dev] [PATCH] bridge: Rate limit instant stats.

2012-09-19 Thread Ethan Jackson
The during a typical run loop, the refresh_instant_stats() function creates a transaction, populates it with writes that do nothing, and destroys it. This turns out to be fairly expensive causing ovs-vswitchd to show higher than expected cpu usage. This patch remedies the issue by rate limiting r

Re: [ovs-dev] ib0 as a port on a bridge?

2012-09-19 Thread christopher barry
On Wed, 2012-09-19 at 11:01 -0700, Stephen Hemminger wrote: > On Wed, 19 Sep 2012 13:57:39 -0400 > christopher barry wrote: > > > On Tue, 2012-09-18 at 23:49 -0400, christopher barry wrote: > > > if this is not the best list for user questions, please send me to > > > wherever the best place is f

Re: [ovs-dev] Tunneled packet getting lost in OVS

2012-09-19 Thread Justin Pettit
You can use the ovs-appctl command to configure logging. There's a man page for it that you'd probably want to look at. --Justin On Sep 17, 2012, at 4:02 PM, kashyap TA wrote: > Thanks Ben for the reply. Can you please let me know how can I enable the > logging module? Is there a CLI to ena

Re: [ovs-dev] ib0 as a port on a bridge?

2012-09-19 Thread Joseph Glanville
Hi On 20 September 2012 04:01, Stephen Hemminger wrote: > On Wed, 19 Sep 2012 13:57:39 -0400 > christopher barry wrote: > >> On Tue, 2012-09-18 at 23:49 -0400, christopher barry wrote: >> > if this is not the best list for user questions, please send me to >> > wherever the best place is for tha

[ovs-dev] Upstream tunneling and VXLAN

2012-09-19 Thread Jesse Gross
There's been quite a bit of interest in plans for getting tunneling upstream and supporting VXLAN. Since I know that both end users and developers are curious I thought that I would send out the current plan for making this happen. If anyone has comments or suggestions on the plan, please let me

Re: [ovs-dev] [PATCH] ovsdb/jsonrpc-server: ovsdb-server closes accepted connections immediately

2012-09-19 Thread Mehak Mahajan
Hey Isaku, I am not sure I understand this patch completely. Your patch seems to suggest that we are not populating the "options" values from the database ? Are you suggesting that in case of passive connections we do not call ovsdb_jsonrpc_session_set_options() ? On Fri, Sep 14, 2012 at 1:56 AM,

Re: [ovs-dev] ib0 as a port on a bridge?

2012-09-19 Thread Stephen Hemminger
On Wed, 19 Sep 2012 13:57:39 -0400 christopher barry wrote: > On Tue, 2012-09-18 at 23:49 -0400, christopher barry wrote: > > if this is not the best list for user questions, please send me to > > wherever the best place is for that. > > > > I'm building an opennebula cloud, and I have openvswit

Re: [ovs-dev] ib0 as a port on a bridge?

2012-09-19 Thread christopher barry
On Tue, 2012-09-18 at 23:49 -0400, christopher barry wrote: > if this is not the best list for user questions, please send me to > wherever the best place is for that. > > I'm building an opennebula cloud, and I have openvswitch master running > on squeeze kvm host nodes with 3.5.4 as bridge br0 w

Re: [ovs-dev] [PATCH 01/12] ovs-ofputil: Make str_to_port_no() aware of invalid ports

2012-09-19 Thread Ben Pfaff
On Tue, Sep 18, 2012 at 08:58:14AM +0900, Simon Horman wrote: > On Mon, Sep 17, 2012 at 03:53:28PM -0700, Ben Pfaff wrote: > > On Mon, Sep 17, 2012 at 09:26:48AM +0900, Simon Horman wrote: > > > Open Flow 1.1 and 1.2 make use of 32 bit ports, however Open vSwtich maps > > > them to 16 bits. Make ov

Re: [ovs-dev] Problem adding flows openvswitch

2012-09-19 Thread Ben Pfaff
On Wed, Sep 19, 2012 at 07:22:59PM +0200, Andi wrote: > >>We have installed openvswitch in netkit(a user-mode linux front-end > >>let's say) after cross-compiling it for UML. During the startup of > >>the virtual machines we use a script to install openvswitch using > >>the commands reported in sec

Re: [ovs-dev] Problem adding flows openvswitch

2012-09-19 Thread Andi
On 09/19/2012 06:56 PM, Ben Pfaff wrote: On Wed, Sep 19, 2012 at 06:39:54PM +0200, Andi wrote: On 09/19/2012 06:14 PM, Ben Pfaff wrote: On Wed, Sep 19, 2012 at 03:35:56PM +0200, Andi wrote: On 09/18/2012 11:38 PM, Ben Pfaff wrote: On Tue, Sep 18, 2012 at 11:40:24PM +0200, Andi wrote: On 09/1

Re: [ovs-dev] Problem adding flows openvswitch

2012-09-19 Thread Ben Pfaff
On Wed, Sep 19, 2012 at 06:39:54PM +0200, Andi wrote: > On 09/19/2012 06:14 PM, Ben Pfaff wrote: > >On Wed, Sep 19, 2012 at 03:35:56PM +0200, Andi wrote: > >>On 09/18/2012 11:38 PM, Ben Pfaff wrote: > >>>On Tue, Sep 18, 2012 at 11:40:24PM +0200, Andi wrote: > On 09/18/2012 11:29 PM, Ben Pfaff w

Re: [ovs-dev] Problem adding flows openvswitch

2012-09-19 Thread Andi
On 09/19/2012 06:14 PM, Ben Pfaff wrote: On Wed, Sep 19, 2012 at 03:35:56PM +0200, Andi wrote: On 09/18/2012 11:38 PM, Ben Pfaff wrote: On Tue, Sep 18, 2012 at 11:40:24PM +0200, Andi wrote: On 09/18/2012 11:29 PM, Ben Pfaff wrote: On Tue, Sep 18, 2012 at 11:33:33PM +0200, Andi wrote: On 09/1

Re: [ovs-dev] Problem adding flows openvswitch

2012-09-19 Thread Ben Pfaff
On Wed, Sep 19, 2012 at 03:35:56PM +0200, Andi wrote: > On 09/18/2012 11:38 PM, Ben Pfaff wrote: > >On Tue, Sep 18, 2012 at 11:40:24PM +0200, Andi wrote: > >>On 09/18/2012 11:29 PM, Ben Pfaff wrote: > >>>On Tue, Sep 18, 2012 at 11:33:33PM +0200, Andi wrote: > On 09/18/2012 11:26 PM, Ben Pfaff w

[ovs-dev] HELLO

2012-09-19 Thread Alicia Baby
Hello Dear, I apologies if this mail find you disturbing just that i want to discuss with you an important issue. kindly reach me back. Yours Sincerely Miss Alicia.___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/d

Re: [ovs-dev] Problem adding flows openvswitch

2012-09-19 Thread Andi
On 09/18/2012 11:38 PM, Ben Pfaff wrote: On Tue, Sep 18, 2012 at 11:40:24PM +0200, Andi wrote: On 09/18/2012 11:29 PM, Ben Pfaff wrote: On Tue, Sep 18, 2012 at 11:33:33PM +0200, Andi wrote: On 09/18/2012 11:26 PM, Ben Pfaff wrote: On Tue, Sep 18, 2012 at 11:29:55PM +0200, Andi wrote: On 09/1