This fixes the following exception.
When Stream.__scs_connecting doesn't change self.state, Stream.connect()
returns None as an implicit return value. Then, the following exception
is raised.
I guess this case doesn't happen in unix socket case, but does in TCP socket
case.
> File "ovs/jsonrpc.p
Fixed according to comments from Ben and Jesse.
--8<--cut here-->8--
Signed-off-by: Pravin B Shelar
---
lib/flow.c | 43 +++
lib/flow.h |6 ++
lib/match.c| 118
lib/meta-flow.c
On Tue, Nov 20, 2012 at 1:29 PM, Justin Pettit wrote:
> Can you make sure you document this behavior in "vswitchd/vswitch.xml".
I forgot to do it. This patch probably will need another respin and I
will include it.
In the meanwhile, do you think the following change is good enough.
Here is an in
On Tue, Nov 20, 2012 at 03:12:26PM -0500, Justin Pettit wrote:
> On Nov 20, 2012, at 12:08 PM, Ben Pfaff wrote:
>
> > I think that Justin was debugging some userspace datapath[*] problems
> > late last week. I remember discussing fixes with him. It looks like he
> > didn't send out the fix befo
On Tue, Nov 20, 2012 at 09:08:32AM -0800, Ben Pfaff wrote:
> On Tue, Nov 20, 2012 at 05:44:30PM +0900, Simon Horman wrote:
> > I believe I have found a regression that affects the behaviour of the
> > datapath. A quick bisection points to the following patch:
> >
> > acf60855126bcfa79ea22d7846
On Tue, Nov 20, 2012 at 03:05:24PM -0800, Ansis Atteka wrote:
> This patch adds support for skb mark matching and set action.
>
> Signed-off-by: Ansis Atteka
I would increment FLOW_WC_SEQ to draw attention to some other places
that might require updates.
I worry that it will be very difficult t
This patch adds support for skb mark matching and set action.
Signed-off-by: Ansis Atteka
---
NEWS|4 +++-
datapath/actions.c |4
datapath/compat.h | 33 +
datapath/datapath.c |8
datap
Ethan reviewed this and patch 2 in a separate thread:
http://openvswitch.org/pipermail/dev/2012-November/023176.html
so I pushed them.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Nov 20, 2012 at 02:39:21PM -0800, Ethan Jackson wrote:
> For some reason I didn't get this series.
Is that why I have so many patches out for review? ;-)
> http://openvswitch.org/pipermail/dev/2012-November/023128.html
> Acked-by: Ethan Jackson
>
> http://openvswitch.org/pipermail/dev/
On Tue, Nov 20, 2012 at 10:15:52AM -0800, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
I don't see a good reason to make flow_tun_flag_to_string() a "static
inline" function in a header file. It's not performance-critical, I
hope.
In flow_tunnel_format, passing '.' to format_flags()
On Tue, Nov 20, 2012 at 12:40 PM, Ben Pfaff wrote:
> On Tue, Nov 20, 2012 at 03:29:03AM -0800, Gurucharan Shetty wrote:
>> From: Gurucharan Shetty
>
> You used shettyg as author and committer but signed off as gshetty. I
> think that the repository hook will reject that, requiring
> consistency.
For some reason I didn't get this series.
http://openvswitch.org/pipermail/dev/2012-November/023128.html
Acked-by: Ethan Jackson
http://openvswitch.org/pipermail/dev/2012-November/023129.html
Acked-by: Ethan Jackson
Ethan
___
dev mailing list
dev@op
On Tue, Nov 20, 2012 at 2:04 PM, Reid Price wrote:
> s/ofporot/ofproto/
Thanks. Fixed that typo and applied to master and branch-1.9,
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Nov 20, 2012 at 1:14 PM, Ben Pfaff wrote:
>
> On Tue, Nov 20, 2012 at 03:40:50AM -0800, Gurucharan Shetty wrote:
> > From: Gurucharan Shetty
> >
> > Currently, the 'ofport' column in Interface table is
> > ephemeral and is populated by vswitchd everytime it is
> > started or when a new in
On Tue, Nov 20, 2012 at 01:55:10PM -0800, Ansis Atteka wrote:
> On Tue, Nov 20, 2012 at 1:09 PM, Ben Pfaff wrote:
> > Signed-off-by: Ben Pfaff
> > ---
> > vswitchd/bridge.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
On Tue, Nov 20, 2012 at 1:49 PM, Ansis Atteka wrote:
> The usage message for this command was wrong, because it did not
> specify priority as one of its arguments.
>
> Signed-off-by: Ansis Atteka
Looks good to me.
___
dev mailing list
dev@openvswitch.o
s/ofporot/ofproto/
On Tue, Nov 20, 2012 at 1:49 PM, Ansis Atteka wrote:
> The usage message for this command was wrong, because it did not
> specify priority as one of its arguments.
>
> Signed-off-by: Ansis Atteka
> ---
> ofproto/ofproto-dpif.c |2 +-
> 1 file changed, 1 insertion(+), 1 d
On Tue, Nov 20, 2012 at 1:09 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/bridge.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 8f16432..998ea81 100644
> --- a/vswitchd/bridge.c
> +++ b/vswitchd/b
The usage message for this command was wrong, because it did not
specify priority as one of its arguments.
Signed-off-by: Ansis Atteka
---
ofproto/ofproto-dpif.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 45527e3..
Can you make sure you document this behavior in "vswitchd/vswitch.xml".
Thanks,
--Justin
On Nov 20, 2012, at 6:40 AM, Gurucharan Shetty wrote:
> From: Gurucharan Shetty
>
> Currently, the 'ofport' column in Interface table is
> ephemeral and is populated by vswitchd everytime it is
> starte
On Tue, Nov 20, 2012 at 01:08:09PM -0800, Jesse Gross wrote:
> On Tue, Nov 20, 2012 at 10:15 AM, Pravin B Shelar wrote:
> > Signed-off-by: Pravin B Shelar
> > ---
> > lib/flow.c | 30
> > lib/flow.h | 19 +
> > lib/match.c| 44 ---
> > lib/meta-
On Tue, Nov 20, 2012 at 03:40:50AM -0800, Gurucharan Shetty wrote:
> From: Gurucharan Shetty
>
> Currently, the 'ofport' column in Interface table is
> ephemeral and is populated by vswitchd everytime it is
> started or when a new interface is created with vswitchd
> running.
>
> Making it persi
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 8f16432..998ea81 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1243,7 +1243,7 @@ bridge_refresh_one_ofp_port(struct bri
On Tue, Nov 20, 2012 at 10:15 AM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> lib/flow.c | 30
> lib/flow.h | 19 +
> lib/match.c| 44 ---
> lib/meta-flow.c| 211
> +++-
>
On Tue, Nov 20, 2012 at 03:29:03AM -0800, Gurucharan Shetty wrote:
> From: Gurucharan Shetty
You used shettyg as author and committer but signed off as gshetty. I
think that the repository hook will reject that, requiring
consistency.
> Currently running the following 3 commands results
> in vs
On Nov 20, 2012, at 12:08 PM, Ben Pfaff wrote:
> I think that Justin was debugging some userspace datapath[*] problems
> late last week. I remember discussing fixes with him. It looks like he
> didn't send out the fix before he left on vacation, which means that
> they weren't quite ready yet.
From: Gurucharan Shetty
Currently, the 'ofport' column in Interface table is
ephemeral and is populated by vswitchd everytime it is
started or when a new interface is created with vswitchd
running.
Making it persistent lets vswitchd try and assign the
same ofport number to a particular interface
From: Gurucharan Shetty
Currently running the following 3 commands results
in vswitchd running in an infinite loop.
ovs-vsctl add-port br1 port1 -- set interface port1 \
type=internal ofport_request=1
ovs-vsctl add-port br1 port2 -- set interface port2 \
type=internal ofport_request=2
ovs-vsctl
On Tue, Nov 20, 2012 at 11:22 AM, Pravin Shelar wrote:
> On Tue, Nov 20, 2012 at 11:17 AM, Jesse Gross wrote:
>>
>> On Tue, Nov 20, 2012 at 10:15 AM, Pravin B Shelar
>> wrote:
>> > Signed-off-by: Pravin B Shelar
>> > ---
>> > lib/odp-util.c | 14 ++
>> > 1 file changed, 14 insert
Let's leave it as-is then.
On Tue, Nov 20, 2012 at 11:20:21AM -0800, Ethan Jackson wrote:
> I can't seem to get it to produce an ENOTDIR in my testing. At least on
> Linux and ESX, it seems to always give me an ENOENT. I could add it as
> a precaution if you feel strongly about it. Thoughts?
>
On Tue, Nov 20, 2012 at 11:17 AM, Jesse Gross wrote:
> On Tue, Nov 20, 2012 at 10:15 AM, Pravin B Shelar
> wrote:
> > Signed-off-by: Pravin B Shelar
> > ---
> > lib/odp-util.c | 14 ++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/lib/odp-util.c b/lib/odp-util.c
> > i
I can't seem to get it to produce an ENOTDIR in my testing. At least on
Linux and ESX, it seems to always give me an ENOENT. I could add it as
a precaution if you feel strongly about it. Thoughts?
Ethan
On Tue, Nov 20, 2012 at 9:18 AM, Ben Pfaff wrote:
> On Tue, Nov 20, 2012 at 09:14:02AM -
On Tue, Nov 20, 2012 at 10:15 AM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> lib/odp-util.c | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/lib/odp-util.c b/lib/odp-util.c
> index 9b0876c..3884b4d 100644
> --- a/lib/odp-util.c
> +++ b/lib/odp-util.
On Nov 20, 2012, at 12:15 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Pravin B Shelar
---
lib/flow.c | 30
lib/flow.h | 19 +
lib/match.c| 44 ---
lib/meta-flow.c| 211 +++-
lib/meta-flow.h| 13 +++-
lib/odp-util.c | 45 ++-
tes
Signed-off-by: Pravin B Shelar
---
lib/odp-util.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/lib/odp-util.c b/lib/odp-util.c
index 9b0876c..3884b4d 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -1874,6 +1874,20 @@ odp_flow_key_to_flow(const struct nlattr *key, siz
On Tue, Nov 20, 2012 at 09:14:02AM -0800, Ben Pfaff wrote:
> On Mon, Nov 19, 2012 at 05:48:10PM -0800, Ethan Jackson wrote:
> > ESX supports unix sockets, but they don't manifest themselves in
> > file system like they do on Linux. Instead of using stat to check
> > if a unix socket exist, this pa
On Mon, Nov 19, 2012 at 05:48:10PM -0800, Ethan Jackson wrote:
> ESX supports unix sockets, but they don't manifest themselves in
> file system like they do on Linux. Instead of using stat to check
> if a unix socket exist, this patch simply tries to open it instead.
>
> Signed-off-by: Ethan Jack
On Tue, Nov 20, 2012 at 05:44:30PM +0900, Simon Horman wrote:
> I believe I have found a regression that affects the behaviour of the
> datapath. A quick bisection points to the following patch:
>
> acf60855126bcfa79ea22d7846af5f2efe26cd30
> ofproto-dpif: Use a single underlying datapa
On Tue, Nov 20, 2012 at 02:09:52PM +, Kyle Mestery (kmestery) wrote:
> On Nov 19, 2012, at 5:12 PM, Ben Pfaff wrote:
> > ODP_FIT_PERFECT has value 0 but this 'if' statement doesn't make much sense
> > unless you happen to know that.
> >
> > Signed-off-by: Ben Pfaff
>
>
> Acked-by: Kyle Mes
On Tue, Nov 20, 2012 at 02:10:53PM +, Kyle Mestery (kmestery) wrote:
> On Nov 19, 2012, at 5:57 PM, Ben Pfaff wrote:
> > 'e' is an exception, not a socket, so get_exception_errno() is the
> > appropriate function to obtain an error code from it.
> >
> > Signed-off-by: Ben Pfaff
>
>
> Acked
On Nov 19, 2012, at 5:57 PM, Ben Pfaff wrote:
> 'e' is an exception, not a socket, so get_exception_errno() is the
> appropriate function to obtain an error code from it.
>
> Signed-off-by: Ben Pfaff
Acked-by: Kyle Mestery
___
dev mailing list
dev@o
On Nov 19, 2012, at 5:12 PM, Ben Pfaff wrote:
> ODP_FIT_PERFECT has value 0 but this 'if' statement doesn't make much sense
> unless you happen to know that.
>
> Signed-off-by: Ben Pfaff
Acked-by: Kyle Mestery
___
dev mailing list
dev@openvswitch.or
Hi,
I believe I have found a regression that affects the behaviour of the
datapath. A quick bisection points to the following patch:
acf60855126bcfa79ea22d7846af5f2efe26cd30
ofproto-dpif: Use a single underlying datapath across multiple bridges.
For my test I run Open vSwtich in
44 matches
Mail list logo
