Re: [ovs-dev] OpenvSwitch for Ubuntu Raring/Kernel 3.8

2013-01-14 Thread Ben Pfaff
On Mon, Jan 14, 2013 at 01:02:17PM +, James Page wrote: > I'm seeking some guidance on which version of Open vSwitch to ship > with Ubuntu Raring (13.04). > > Ubuntu 12.10 ships 1.4.3 with a fairly heavy set of patches for > compatibility with Linux kernel 3.5 so that the DKMS package remains

Re: [ovs-dev] [PATCH] Remove restriction on socket name

2013-01-14 Thread Ben Pfaff
Thanks for the revised patch. I have a number of comments, mostly process related. "git am" noticed trailing whitespace: /home/blp/nicira/ovs/.git/rebase-apply/patch:21: trailing whitespace. warning: 1 line adds whitespace errors. > Subject: [PATCH] Remove restriction on socket name We

[ovs-dev] [PATCH] ofproto: Optimise OpenFlow flow expiry

2013-01-14 Thread Simon Horman
Optimise OpenFlow flow expiry by placing expirable flows on a list. This optimises scanning of flows for expiry in two ways: * Empirically list traversal appears faster than the code it replaces. With 1,000,000 flows present an otherwise idle system I observed CPU utilisation of around 20% wi

[ovs-dev] [patch_ports 3/4] ofproto-dpif: Implement patch ports in userspace.

2013-01-14 Thread Ethan Jackson
This commit moves responsibility for implementing patch ports from the datapath to ofproto-dpif. There are two main reasons to do this. The first is a matter of design: ofproto-dpif both has more information than the datapath, and is better suited to handle the complexity required to implement p

[ovs-dev] [patch_ports 2/4] ofproto-dpif: Refresh stats before ovs-appctl dpif/dump-flows.

2013-01-14 Thread Ethan Jackson
As a matter of convenience, this patch refreshes the statistics when ovs-appctl dpif/dump-flows is called. Hopefully this will prevent users from being confused because statistics they were expecting to see haven't made it from the datapath into the switch yet. Signed-off-by: Ethan Jackson ---

[ovs-dev] [patch_ports 4/4] netdev-dummy: Test LACP negotiation.

2013-01-14 Thread Ethan Jackson
From: Ben Pfaff Signed-off-by: Ben Pfaff Signed-off-by: Ethan Jackson --- tests/lacp.at | 430 + 1 file changed, 430 insertions(+) diff --git a/tests/lacp.at b/tests/lacp.at index 7d96143..870beb0 100644 --- a/tests/lacp.at +++ b/tests/

[ovs-dev] [patch_ports 1/4] ofproto-dpif: Create single global revalidation state.

2013-01-14 Thread Ethan Jackson
Before this patch, the "need_revalidate" flag and the "revalidate_set" tag_set where maintained separately for each ofproto. This won't work in future patches when a flow table change in one ofproto can require revalidation in another entirely separate ofproto. For this reason, this patch makes t

Re: [ovs-dev] [PATCH] remove restriction on socket name

2013-01-14 Thread Pavithra Ramesh
Sorry about the formatting. I sent out another one using git send-email. Thanks, Pavithra - Original Message - From: "Jesse Gross" To: "Ben Pfaff" Cc: "Pavithra Ramesh" , dev@openvswitch.org Sent: Monday, January 14, 2013 6:14:47 PM Subject: Re: [ovs-dev] [PATCH] remove restriction on

[ovs-dev] [PATCH] Remove restriction on socket name

2013-01-14 Thread paramesh
From: Pavithra Ramesh Following patch removes restriction on the listening socket name that gets configured as bridge controller. Currently, we only connect to sockets in a specific directory with the name of the bridge. This patch removes the restriction on the bridge name (but keep the direct

Re: [ovs-dev] [PATCH] remove restriction on socket name

2013-01-14 Thread Jesse Gross
On Mon, Jan 14, 2013 at 4:57 PM, Ben Pfaff wrote: > On Mon, Jan 14, 2013 at 03:37:43PM -0800, Pavithra Ramesh wrote: >> Following patch removes restriction on the listening socket name that gets >> configured as bridge controller. >> Currently, we only connect to sockets in a specific directory w

Re: [ovs-dev] [PATCH 0/16 v2.13] Basic MPLS actions and matches

2013-01-14 Thread Ben Pfaff
On Tue, Jan 15, 2013 at 09:13:15AM +0900, Simon Horman wrote: > On Mon, Jan 07, 2013 at 11:07:24PM -0800, Ben Pfaff wrote: > > On Jan 7, 2013 9:41 PM, "Simon Horman" wrote: > > > > > > On Fri, Jan 04, 2013 at 09:19:57AM -0800, Ben Pfaff wrote: > > > > Since Jesse is perpetually backlogged: if ther

Re: [ovs-dev] [PATCH] remove restriction on socket name

2013-01-14 Thread Ben Pfaff
On Mon, Jan 14, 2013 at 03:37:43PM -0800, Pavithra Ramesh wrote: > Following patch removes restriction on the listening socket name that gets > configured as bridge controller. > Currently, we only connect to sockets in a specific directory with the name > of the bridge. > This patch removes th

Re: [ovs-dev] [PATCH] ofproto: Optimise OpenFlow flow expiry

2013-01-14 Thread Simon Horman
On Sun, Jan 13, 2013 at 09:22:31PM -0800, Ben Pfaff wrote: > On Mon, Jan 14, 2013 at 10:06:13AM +0900, Simon Horman wrote: > > Optimise OpenFlow flow expiry by placing expirable flows on a list. > > This optimises scanning of flows for expiry in two ways: > > > > * Empirically list traversal appea

Re: [ovs-dev] [PATCH 0/16 v2.13] Basic MPLS actions and matches

2013-01-14 Thread Simon Horman
On Mon, Jan 07, 2013 at 11:07:24PM -0800, Ben Pfaff wrote: > On Jan 7, 2013 9:41 PM, "Simon Horman" wrote: > > > > On Fri, Jan 04, 2013 at 09:19:57AM -0800, Ben Pfaff wrote: > > > Since Jesse is perpetually backlogged: if there are any parts of the > > > series that can be usefully applied without

[ovs-dev] [PATCH] remove restriction on socket name

2013-01-14 Thread Pavithra Ramesh
Following patch removes restriction on the listening socket name that gets configured as bridge controller. Currently, we only connect to sockets in a specific directory with the name of the bridge. This patch removes the restriction on the bridge name (but keep the directory restriction). Is

Re: [ovs-dev] [ovs-assert 2/4] Replace most uses of assert by ovs_assert.

2013-01-14 Thread Ethan Jackson
> The FSF used to advise that the copyright year was the year in which > you completed a set of changes, not the year in which you released > those changes. I can't find that advice any longer. Perhaps it was > incorrect. Good enough for me, thanks. Ethan ___

Re: [ovs-dev] [ovs-assert 2/4] Replace most uses of assert by ovs_assert.

2013-01-14 Thread Ben Pfaff
On Mon, Jan 14, 2013 at 12:56:50PM -0800, Ethan Jackson wrote: > I'm not totally sure what should happen with the copyright increment given > it's now 2013. Looks good to me though. > > Acked-by: Ethan Jackson The FSF used to advise that the copyright year was the year in which you completed a

Re: [ovs-dev] [ovs-assert 2/4] Replace most uses of assert by ovs_assert.

2013-01-14 Thread Ethan Jackson
I'm not totally sure what should happen with the copyright increment given it's now 2013. Looks good to me though. Acked-by: Ethan Jackson ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] classifier: Speed up classification when reg0 partitions the flow table.

2013-01-14 Thread Ben Pfaff
On Mon, Jan 14, 2013 at 09:12:34AM +0200, Jarno Rajahalme wrote: > On Jan 12, 2013, at 2:24 , ext Ben Pfaff wrote: > > We have a controller that puts many rules with different reg0 values into > > the flow table, where reg0 is used (by "resubmit"s) to distinguish stages > > in a pipeline. Thus, an

[ovs-dev] OpenvSwitch for Ubuntu Raring/Kernel 3.8

2013-01-14 Thread James Page
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi OpenvSwitch Devs I'm seeking some guidance on which version of Open vSwitch to ship with Ubuntu Raring (13.04). Ubuntu 12.10 ships 1.4.3 with a fairly heavy set of patches for compatibility with Linux kernel 3.5 so that the DKMS package remains

[ovs-dev] [PATCH] ofp-print.c: Fix remaining port number prints.

2013-01-14 Thread Jarno Rajahalme
Use ofputil_format_port() to print port numbers so that special ports will be printed out as symbolic names (e.g., LOCAL) instead of numbers. Signed-off-by: Jarno Rajahalme --- lib/ofp-print.c| 42 -- tests/ofp-print.at | 12 ++-- tests/of