Re: [ovs-dev] [RFC] bfd: Replace bfd.{c, h} with generic implementation.

2014-03-03 Thread Ben Pfaff
OK. I didn't review the whole patch, by the way, I just noticed this glancing at the first little bit. On Mon, Mar 03, 2014 at 05:57:55PM -0800, Alex Wang wrote: > Yeah, I was not sure about this either. > > I was trying to avoid pulling any ovs specific library to the 'libbfd' and > considering

Re: [ovs-dev] [RFC] bfd: Replace bfd.{c, h} with generic implementation.

2014-03-03 Thread Alex Wang
Yeah, I was not sure about this either. I was trying to avoid pulling any ovs specific library to the 'libbfd' and considering that bfd_set_next_tx() (which uses rand()) will only be called while holding the global lock. I agree that this will leave risk for future development. I think I will ju

Re: [ovs-dev] [RFC] bfd: Replace bfd.{c, h} with generic implementation.

2014-03-03 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 05:46:41PM -0800, Alex Wang wrote: > This commit replaces the current bfd.{c,h} with a generic library-like > implementation. Wrappers (in bfd_ts.{c,h}) are then added to guarantee > the thread-safety and compatibility with current invocation pattern. > > Signed-off-by: Al

[ovs-dev] [PATCH] vxlan: Support for receiving "ethernet over VXLAN-gpe" packets.

2014-03-03 Thread Pritesh Kothari
Current VXLAN VTEP receives only VXLAN packets and ethernet over VXLAN-gpe [1] packets are rejected. This patch adds support for receiving "ethernet over VXLAN-gpe" packets which have same inner ethernet frame but a different VXLAN and VXLAN-gpe headers. [1] https://tools.ietf.org/html/draft-quinn

[ovs-dev] [PATCH 1/2] timeval: clock_gettime() for Windows.

2014-03-03 Thread Gurucharan Shetty
QueryPerformanceCounter() retrieves the current value of the performance counter, which is a high resolution (<1us) time stamp that can be used for time-interval measurements. So, use it for MONOTONIC clock. The GetSystemTimePreciseAsFileTime() function retrieves the current system date and time w

[ovs-dev] [PATCH 2/2] timeval: gettimeofday() for Windows.

2014-03-03 Thread Gurucharan Shetty
Use GetSystemTimePreciseAsFileTime() for gettimeofday(). GetSystemTimePreciseAsFileTime() provides the result that is more high resolution than just the microsecond that gittimeofday() in Linux provides. So we need to remove some additional precision. Signed-off-by: Gurucharan Shetty --- lib/tim

[ovs-dev] Bug#740355: openvswitch-datapath-source: module-assistant openvswitch-datapath fails on 7.4 3.2.0-4-amd64

2014-03-03 Thread Evgeni Golov
Hi, On Mon, Mar 03, 2014 at 09:00:42AM +0100, Frédéric Tournier wrote: > Here it is: Thanks! > dpkg-deb : construction du paquet « openvswitch-datapath-module-3.2.0-4-amd64  > » dans «  > /usr/src/openvswitch-datapath-module-3.2.0-4-amd64_1.4.2+git20120612-9.1~deb7u1_amd64.deb >  ». That looks

Re: [ovs-dev] [PATCH 1/5] openflow-1.4.h: Add bundle structure definitions

2014-03-03 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 11:51:48PM +0200, Alexandru Copot wrote: > On Mon, Mar 3, 2014 at 11:00 PM, Ben Pfaff wrote: > > The above data structure isn't needed; OVS already handles experimenter > > error codes through infrastructure in ofp-error.h. You can update that > > file with any new error t

Re: [ovs-dev] [PATCH 1/5] openflow-1.4.h: Add bundle structure definitions

2014-03-03 Thread Alexandru Copot
On Mon, Mar 3, 2014 at 11:00 PM, Ben Pfaff wrote: > The above data structure isn't needed; OVS already handles experimenter > error codes through infrastructure in ofp-error.h. You can update that > file with any new error types or codes. > > The various generic "property" definitions here have t

Re: [ovs-dev] [PATCH 1/5] openflow-1.4.h: Add bundle structure definitions

2014-03-03 Thread Ben Pfaff
On Mon, Mar 03, 2014 at 03:22:31PM +0200, Alexandru Copot wrote: > Signed-off-by: Alexandru Copot > Cc: Daniel Baluta > --- > include/openflow/openflow-1.4.h | 114 > > 1 file changed, 114 insertions(+) > > diff --git a/include/openflow/openflow-1.4.h b

[ovs-dev] [PATCH 0/5] Initial implementation of OpenFlow 1.4 bundles

2014-03-03 Thread Alexandru Copot
This series adds the basic communication handlers for the bundles functionality. The actual message pre-validation and commits are not implemented. Signed-off-by: Alexandru Copot Cc: Daniel Baluta Alexandru Copot (5): openflow-1.4.h: Add bundle structure definitions ofproto: Allow the use o

[ovs-dev] [PATCH 1/5] openflow-1.4.h: Add bundle structure definitions

2014-03-03 Thread Alexandru Copot
Signed-off-by: Alexandru Copot Cc: Daniel Baluta --- include/openflow/openflow-1.4.h | 114 1 file changed, 114 insertions(+) diff --git a/include/openflow/openflow-1.4.h b/include/openflow/openflow-1.4.h index 332a0d3..a6645b9 100644 --- a/include/openf

[ovs-dev] [PATCH 4/5] tests: add OpenFlow 1.4 bundles tests

2014-03-03 Thread Alexandru Copot
Signed-off-by: Alexandru Copot Cc: Daniel Baluta --- tests/ofp-print.at | 124 + tests/ofproto-macros.at | 2 +- tests/ofproto.at| 234 3 files changed, 359 insertions(+), 1 deletion(-) diff --git a/tests/of

[ovs-dev] [PATCH 2/5] ofproto: Allow the use of the OpenFlow 1.4 protocol

2014-03-03 Thread Alexandru Copot
This defines the version number for OpenFlow 1.4 so that the switch can actually use it. The ovsdb schema is also modified. Signed-off-by: Alexandru Copot Cc: Daniel Baluta --- build-aux/extract-ofp-errors | 3 +- build-aux/extract-ofp-msgs | 8 +-- include/openflow/openflow-c

[ovs-dev] [PATCH 3/5] Add basic implementation for OpenFlow 1.4 bundles

2014-03-03 Thread Alexandru Copot
Signed-off-by: Alexandru Copot Cc: Daniel Baluta --- lib/learning-switch.c | 2 + lib/ofp-errors.h | 52 +++ lib/ofp-msgs.h| 10 ++ lib/ofp-print.c | 95 +++ lib/ofp-util.c| 57 lib/ofp-util.h| 20 lib/rconn.c

[ovs-dev] [PATCH 5/5] tests: fix broken tests after enabling OpenFlow 1.4

2014-03-03 Thread Alexandru Copot
These tests can now properly print packets with the new protocol version. Signed-off-by: Alexandru Copot Cc: Daniel Baluta --- tests/ofp-errors.at | 2 ++ tests/ofp-print.at | 6 +++--- tests/ofp-util.at | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/tests/ofp-errors.

Re: [ovs-dev] ovs inconsistent lock state

2014-03-03 Thread Jiri Pirko
Fri, Feb 28, 2014 at 08:21:35PM CET, zoltan.k...@citrix.com wrote: >I also had problems with these locks on current net-next, I believe >the issue is that "datapath: Fix deadlock during stats update." is >not merged from official OVS repo to kernel. Nope. I tried the patch and I'm still getting th

[ovs-dev] Bug#740355: openvswitch-datapath-source: module-assistant openvswitch-datapath fails on 7.4 3.2.0-4-amd64

2014-03-03 Thread Frédéric Tournier
Here it is: On 28/02/2014 18:28, Evgeni Golov wrote: Hi, On Fri, Feb 28, 2014 at 04:52:28PM +0100, fred wrote: module-assistant auto-install openvswitch-datapath fails without any useful log. I have no clue. Can you please still post the log? It builds just fine for me. Regards Evgeni d