This commit adds a new cfm configuration option demand_rx_ccm which
represents a time interval in milliseconds. It is only effective when
cfm session is in demand mode. It requires cfm session receive at
least one ccm during the demand_rx_ccm interval. Otherwise, the
cfm session will report
This commit adds a new configuration option demand_rx_bfd for bfd
which is equivalent to the 'demand_rx_ccm' of cfm and is to be used
in forwarding_if_rx mode.
Signed-off-by: Alex Wang al...@nicira.com
---
lib/bfd.c| 43 -
tests/bfd.at | 85
On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
yamam...@valinux.co.jp wrote:
On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
hi,
+ * Due to the sample action there may be multiple possible eth types.
+
Hi All,
I want to print the netlink statistics of vswitchd process. My requirement
is to get all the netlink count for flow additions from vswitchd process.
Is there any way to get the netlink statistics?
Please help me to get these statistics.
--
Thanks Regards
Neelakantam Gaddam
Jarno Rajahalme wrote:
move_rstp() does not check ‘changes’ before clearing it. Consider enforcing the
invariant,
or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
Not clear to me. Function move_rstp does check 'changes':
move_rstp(struct rstp *rstp )
{
int
Sehr geehrter Damen und Herren,
Vorname/ Martins
Name/ U.Ezoh
Nationalitaet/ Sierra Leonean
Ich habe die Summe von USD 7.2millionen von meinen verstorbenen Eltern geebrt.
Meine Eltern wurden Diamanten Haendler.
Das Geld wurde von meinen Eltern in der Sicherheitsfirma fuer sicheres
On Apr 28, 2014, at 2:09 AM, Martino Fornasa m...@fornasa.it wrote:
Jarno Rajahalme wrote:
move_rstp() does not check ‘changes’ before clearing it. Consider enforcing
the invariant,
or maybe do not bother setting ‘changes’ right before calling ‘move_rstp()’ ?
Not clear to me.
Otherwise the udpif revalidator threads can postpone RCU callbacks
essentially forever, especially if there are many revalidator threads and
little network traffic.
Reported-by: Alex Wang al...@nicira.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/ovs-thread.c |3 +++
1 file changed, 3
Alex Wang pointed out that the RCU postpone thread can end up busy-waiting.
The first two patches in this series fix the problem. The remaining two
patches make it easier to track down threads that never quiesce.
Ben Pfaff (4):
timeval: Preserve quiescence across time_poll().
ovs-thread:
Otherwise ovsrcu_synchronize() busy-waits in its loop because its
poll_block() un-quiesces, causing the global_seqno to increase, which is
what it waits for.
Reported-by: Alex Wang al...@nicira.com
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/ovs-rcu.c |7 +++
lib/ovs-rcu.h |1 +
Thread names are occasionally very useful for debugging, but from time to
time we've forgotten to set one. This commit adds the new thread's name
as a parameter to the function to start a thread, to make that mistake
impossible. This also simplifies code, since two function calls become
only
This made it easier for me to find a thread that was causing stalls.
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/ovs-rcu.c| 24 +++-
lib/ovs-thread.c |4 +++-
2 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/lib/ovs-rcu.c b/lib/ovs-rcu.c
index
On Sun, Mar 30, 2014 at 12:26:55PM +0100, Dave Tucker wrote:
The Open vSwitch daemons written in C support user-configured logging
patterns as described in ovs-appctl(8). This commit adds this capability
to the daemons written in Python.
- Add a '__log_patterns' attribute to the Vlog class
This is a hard to notice one~,
Acked-by: Alex Wang al...@nicira.com
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff b...@nicira.com wrote:
Otherwise ovsrcu_synchronize() busy-waits in its loop because its
poll_block() un-quiesces, causing the global_seqno to increase, which is
what it waits for.
thx for fixing this,
Acked-by: Alex Wang al...@nicira.com
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff b...@nicira.com wrote:
Otherwise the udpif revalidator threads can postpone RCU callbacks
essentially forever, especially if there are many revalidator threads and
little network traffic.
This is helpful, just two comments,
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff b...@nicira.com wrote:
This patch is a prerequisite for making RCU report the name of a thread
that is blocking RCU synchronization,
*because the easiest way to do that gets the name of the thread in
Acked-by: Alex Wang al...@nicira.com
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff b...@nicira.com wrote:
This made it easier for me to find a thread that was causing stalls.
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/ovs-rcu.c| 24 +++-
lib/ovs-thread.c |
On Sun, Apr 27, 2014 at 7:07 PM, Joe Stringer joestrin...@nicira.com wrote:
This was causing build failures on debian wheezy. Check for the feature
rather than the version.
Signed-off-by: Joe Stringer joestrin...@nicira.com
Acked-by: Jesse Gross je...@nicira.com
On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman ho...@verge.net.au wrote:
On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
yamam...@valinux.co.jp wrote:
On Thu, Apr 24, 2014 at 05:57:29PM +0900, YAMAMOTO Takashi wrote:
hi,
+
Signed-off-by: Justin Pettit jpet...@nicira.com
---
NEWS |4 ++--
configure.ac |2 +-
debian/changelog | 24
3 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/NEWS b/NEWS
index 02ecf5b..98db34e 100644
--- a/NEWS
+++ b/NEWS
@@ -1,4
Signed-off-by: Justin Pettit jpet...@nicira.com
---
NEWS |4
configure.ac |2 +-
debian/changelog |7 +++
3 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index 98db34e..74b57ff 100644
--- a/NEWS
+++ b/NEWS
@@ -1,3 +1,7 @@
Signed-off-by: Justin Pettit jpet...@nicira.com
---
NEWS |3 ++-
configure.ac |2 +-
debian/changelog |9 +
3 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/NEWS b/NEWS
index eeba849..32dc352 100644
--- a/NEWS
+++ b/NEWS
@@ -1,7 +1,8 @@
We now increment the version immediately after a release.
Signed-off-by: Justin Pettit jpet...@nicira.com
---
NEWS |4
configure.ac |2 +-
debian/changelog |6 ++
3 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/NEWS b/NEWS
index
Thanks, applied.
On 29 April 2014 09:27, Jesse Gross je...@nicira.com wrote:
On Sun, Apr 27, 2014 at 7:07 PM, Joe Stringer joestrin...@nicira.com
wrote:
This was causing build failures on debian wheezy. Check for the feature
rather than the version.
Signed-off-by: Joe Stringer
On Mon, Apr 28, 2014 at 11:48:34AM -0700, Alex Wang wrote:
This is helpful,??? just two comments,
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff b...@nicira.com wrote:
This patch is a prerequisite for making RCU report the name of a thread
that is blocking RCU synchronization,
*because the
Thank you for the reviews. I'll push these patches in a minute.
On Mon, Apr 28, 2014 at 02:10:27PM -0700, Alex Wang wrote:
Acked-by: Alex Wang al...@nicira.com
On Mon, Apr 28, 2014 at 9:06 AM, Ben Pfaff b...@nicira.com wrote:
This made it easier for me to find a thread that was causing
On Mon, Apr 28, 2014 at 02:57:17PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
For both:
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Apr 28, 2014 at 02:48:56PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
For both patches:
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Commit 1335a8d578b03e (tests: Fix race condition waiting for monitor
thread.) fixed a race condition in a test. Commit 8ba0a5227f6 (ovs-thread:
Make caller provide thread name when creating a thread.) slightly changed
the output that the test checked, breaking the test. However, I was used
to
Thanks, I applied these.
On Fri, Apr 25, 2014 at 11:50:43AM -0700, Andy Zhou wrote:
Looks great. Thanks!
On Fri, Apr 25, 2014 at 9:56 AM, Ben Pfaff b...@nicira.com wrote:
If 'lacp' is NULL, then lacp_create() might not have been called to
indirectly initialize the mutex via lacp_init(),
Acked-by: Ethan Jackson et...@nicira.com
I don't really like the API we've ended up with here. But I think
it's fine for now. As discussed offline, I intend to change it later.
Ethan
On Thu, Apr 24, 2014 at 6:25 PM, Ethan Jackson et...@nicira.com wrote:
I haven't read this patch yet, but a
On Mar 20, 2014, at 10:05 AM, Ben Pfaff b...@nicira.com wrote:
On Fri, Mar 14, 2014 at 04:19:52PM +0900, Simon Horman wrote:
When creating a flow in the datapath as the result of an upcall
the match itself is the match supplied in the upcall while
the mask of the match, if supplied, is
On Thu, Apr 24, 2014 at 10:34:14PM -0700, Andy Zhou wrote:
When recirc pool is exhausted, a new bond won't be allocate a new
recirc_id. The bond-recirc_id will remain zero. This condition
should prevent the bond from use recirculation. This check was missing
before this patch.
Acked-by: Justin Pettit jpet...@nicira.com
On April 28, 2014 at 3:45:26 PM, Ben Pfaff (b...@nicira.com) wrote:
Commit 1335a8d578b03e (tests: Fix race condition waiting for monitor
thread.) fixed a race condition in a test. Commit 8ba0a5227f6 (ovs-thread:
Make caller provide thread name when
On Thu, Apr 24, 2014 at 10:34:15PM -0700, Andy Zhou wrote:
Bond rebalancing was disabled for bonds not using recirculation. The
patch fixes this bug.
While fixing the bug, the bond_rebalance() was also restructured
slightly to move bond related logic back into ofproto/bond.c
Currently physical ports stats are collected from kernel datapath.
However, those counter do not reflect actual wire packet counters
when LSO or TSO are enabled by the NIC. In the meantime, the stats
collected form routing stack does. While both stats are valid, Reporting
netlink stats for packet
Thanks, applied.
On Mon, Apr 28, 2014 at 03:57:24PM -0700, Justin Pettit wrote:
Acked-by: Justin Pettit jpet...@nicira.com
On April 28, 2014 at 3:45:26 PM, Ben Pfaff (b...@nicira.com) wrote:
Commit 1335a8d578b03e (tests: Fix race condition waiting for monitor
thread.) fixed a race
On Mon, Apr 28, 2014 at 02:37:47PM -0700, Jesse Gross wrote:
On Mon, Apr 28, 2014 at 12:00 AM, Simon Horman ho...@verge.net.au wrote:
On Fri, Apr 25, 2014 at 12:57:20PM -0700, Jesse Gross wrote:
On Fri, Apr 25, 2014 at 1:06 AM, YAMAMOTO Takashi
yamam...@valinux.co.jp wrote:
On Thu, Apr
Pushed to master,
Jarno
On Apr 14, 2014, at 1:23 PM, Jarno Rajahalme jrajaha...@nicira.com wrote:
On Apr 14, 2014, at 1:00 PM, Justin Pettit jpet...@nicira.com wrote:
It looks like there are a few other places that need to get updated, too.
Did you want me to take a pass at them?
Pushed to master,
Jarno
On Apr 25, 2014, at 1:47 PM, Jesse Gross je...@nicira.com wrote:
On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme jrajaha...@nicira.com
wrote:
In general, all Netlink 64-bit data may be 4-byte aligned, due to
netlink header and attributes being 4-aligned.
To
Thanks for the review, pushed to master,
Jarno
On Apr 14, 2014, at 7:25 PM, YAMAMOTO Takashi yamam...@valinux.co.jp wrote:
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Reviewed-by: YAMAMOTO Takashi yamam...@valinux.co.jp
---
lib/odp-util.c |2 +-
tests/odp.at |1 +
2
Thanks for the review, pushed to master,
Jarno
On Apr 25, 2014, at 1:48 PM, Jesse Gross je...@nicira.com wrote:
On Fri, Apr 11, 2014 at 4:29 PM, Jarno Rajahalme jrajaha...@nicira.com
wrote:
Key attributes relating to actual packet headers are ignored for
OVS_PACKET_CMD_EXECUTE as the
Will you push a tag for this too?
On 29 April 2014 10:31, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 28, 2014 at 02:57:17PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
For both:
Acked-by: Ben Pfaff b...@nicira.com
Acked-by: Ethan Jackson et...@nicira.com
I'm not sure I totally follow Kmindg's comment, perhaps he could
explain further? At any rate, once addressed Im happy with this.
Ethan
On Sat, Apr 19, 2014 at 10:09 PM, Kmindg G kmi...@gmail.com wrote:
On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme
The comment of miniflow_and_mask_matches_flow() need to be reworded.
Do we really need that function? Is it really that much faster?
Having two functions which do the exact same thing is a bit confusing.
So I suppose the only reason for a non zero inline_values array is for
those callers who
On Tue, Apr 29, 2014 at 9:43 AM, Ethan Jackson et...@nicira.com wrote:
Acked-by: Ethan Jackson et...@nicira.com
I'm not sure I totally follow Kmindg's comment, perhaps he could
explain further? At any rate, once addressed Im happy with this.
After a second look into this, I found that I
Applied to branch-2.1 as well.
On 29 April 2014 10:21, Joe Stringer joestrin...@nicira.com wrote:
Thanks, applied.
On 29 April 2014 09:27, Jesse Gross je...@nicira.com wrote:
On Sun, Apr 27, 2014 at 7:07 PM, Joe Stringer joestrin...@nicira.com
wrote:
This was causing build failures on
I normally wait for the announcement and the tarball, just in case some
last minute bug fix gets slipped in.
On Tue, Apr 29, 2014 at 01:40:46PM +1200, Joe Stringer wrote:
Will you push a tag for this too?
On 29 April 2014 10:31, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 28, 2014 at
This reverts commit 82e413df because bug fix bf52ed4 (datapath: Check for
backported skb_orphan_frags().) was required.
Signed-off-by: Justin Pettit jpet...@nicira.com
---
NEWS |4
configure.ac |2 +-
debian/changelog |6 --
3 files changed, 1 insertions(+),
49 matches
Mail list logo
