Thanks, I applied this to master.
On 25 June 2014 06:22, Ben Pfaff wrote:
> On Mon, Jun 23, 2014 at 09:33:56AM +1200, Joe Stringer wrote:
> > This could cause configuration failure on earlier versions of autoconf.
> >
> > Reported-by: Lin Shaopeng
> > Signed-off-by: Joe Stringer
>
> Acked-by:
Thanks for looking this over. I took a fresh look and realised that none of
this is thread-safe.
I sent a second version for review, which runs this logic all from the main
thread:
http://openvswitch.org/pipermail/dev/2014-June/042066.html
On 24 June 2014 05:39, Ben Pfaff wrote:
> On Fri, Jun
This allows us to remove some of the sleeps from the testsuite.
Signed-off-by: Joe Stringer
---
v2: Add udpif_run(), manage connection from main thread.
v1: First post.
---
ofproto/ofproto-dpif-upcall.c | 45 +
ofproto/ofproto-dpif-upcall.h |1 +
ofp
On Tue, Jun 24, 2014 at 07:50:24AM -0700, Ben Pfaff wrote:
> On Tue, Jun 24, 2014 at 05:22:08PM +0900, Simon Horman wrote:
> > On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote:
> > > On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote:
> > > > Use a list rather than an array to tr
Dear user dev@openvswitch.org,
Your email account was used to send a huge amount of junk e-mail messages
during this week.
Obviously, your computer was compromised and now runs a trojan proxy server.
Please follow the instructions in order to keep your computer safe.
Best wishes,
The openvswitc
On Tue, Jun 24, 2014 at 05:22:08PM +0900, Simon Horman wrote:
> On Mon, Jun 23, 2014 at 05:00:53PM -0700, Ben Pfaff wrote:
> > On Mon, Jun 16, 2014 at 11:29:28AM +0900, Simon Horman wrote:
> > > Use a list rather than an array to track monitor requests
> > > in handle_flow_monitor_request().
> > >
On Wed, Jun 25, 2014 at 11:07:31AM +0900, YAMAMOTO Takashi wrote:
> Signed-off-by: YAMAMOTO Takashi
I would write this:
> +Q: How MAC learning works with VLANs?
more idiomatically as:
Q: How does MAC learning work with VLANs?
> +A: Open vSwitch implements Independent VLAN Learning (IVL) for
> +
On Wed, Jun 18, 2014 at 9:45 PM, Jesse Gross wrote:
> On Tue, Jun 17, 2014 at 12:21 PM, Lori Jakab wrote:
>> Hi Jesse,
>>
>>
>> On 5/23/14, 2:07 AM, Jesse Gross wrote:
>>>
>>> On Tue, May 20, 2014 at 9:27 PM, Lori Jakab wrote:
On 5/21/14, 4:10 AM, Jesse Gross wrote:
>
> On Tue,
Signed-off-by: YAMAMOTO Takashi
---
FAQ | 6 ++
1 file changed, 6 insertions(+)
diff --git a/FAQ b/FAQ
index 79d905d..c2520fc 100644
--- a/FAQ
+++ b/FAQ
@@ -1124,6 +1124,12 @@ A: Do you have a controller configured on br0 (as the
commands above
OpenFlow controller doesn't see the VLANs
The original message was received at Wed, 25 Jun 2014 08:57:49 +0700
from [158.14.61.220]
- The following addresses had permanent fatal errors -
dev@openvswitch.org
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listin
On Tue, Jun 24, 2014 at 04:24:37PM -0700, Jesse Gross wrote:
> On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman wrote:
> > Allow datapath to recognize and extract MPLS labels into flow keys
> > and execute actions which push, pop, and set labels on packets.
> >
> > Based heavily on work by Leo Alterm
Currently, if the network stack provides skb->rxhash then we use it,
otherwise we compute our own. However, on at least some versions of
RHEL/CentOS, the stack provides a hash but it is 16 bits rather than
32 bits. In cases where we use the upper most bits of the hash this
is particularly bad becau
The pmd threads are pinned to available cpu cores on the
corresponding cpu socket.
Signed-off-by: Alex Wang
---
PATCH -> V2:
- Add latch_destory().
- Use 'int' for cpu socket/core id.
---
lib/dpif-netdev.c | 178 ++---
lib/netdev-dpdk.c | 27 +++
This commit makes the memory pool name contain the socket id.
Since dpdk library do not allow creation of memory pool with
same name, this commit serves as a simple way of making each
name unique.
Signed-off-by: Alex Wang
Acked-by: Thomas Graf
---
PATCH -> V2:
- Rebase.
---
lib/netdev-dpdk.c |
This will be the default setting for dpdk iface.
Signed-off-by: Alex Wang
---
PATCH -> V2:
- Remove the NR_QUEUE #define in lib/dpif-netdev.h.
---
lib/dpif-netdev.h |2 --
lib/netdev-dpdk.c | 47 ---
2 files changed, 40 insertions(+), 9 deletion
Signed-off-by: Alex Wang
---
PATCH -> V2:
- Use readdir_r() instead of readdir() for reentrency.
- Address review comments from Thomas Graf.
- Add dummy interface for WIN32 case.
---
lib/automake.mk |2 +
lib/ovs-numa.c | 217 +++
Signed-off-by: Alex Wang
---
PATCH -> V2:
- Rebase.
---
lib/netdev-dpdk.c | 14 ++
lib/netdev-dpdk.h | 11 +++
2 files changed, 25 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 3359517..df71385 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.
>
> On 06/23/14 at 12:37pm, Alex Wang wrote:
> > This will be the default setting for dpdk iface.
> >
> > Signed-off-by: Alex Wang
>
> I think you can remove the NR_QUEUE #define in lib/dpif-netdev.h
> with this patch.
>
I'll remove it.
> > ---
> > lib/netdev-dpdk.c | 47
>
> > diff --git a/lib/automake.mk b/lib/automake.mk
> > index 3f984d9..ca6c890 100644
> > --- a/lib/automake.mk
> > +++ b/lib/automake.mk
> > @@ -150,6 +150,8 @@ lib_libopenvswitch_la_SOURCES = \
> > lib/ovs-atomic-locked.h \
> > lib/ovs-atomic-pthreads.h \
> > lib/ovs-atom
Hey Thomas,
Sorry for this very delayed reply and thanks a lot for your close review!
Please see my comments inline,
> > +
> > +#define MAX_CPU_SOCKETS 8
>
> Can we bump this to something like 128? SPARC64 and the like have
> been pretty crazy on the subject of number of sockets. It shouldn't
On Tue, Jun 24, 2014 at 05:08:18PM -0700, Jesse Gross wrote:
> On Tue, Jun 24, 2014 at 4:40 PM, Ben Pfaff wrote:
> > Open vSwitch userspace is able to implement some actions that the kernel
> > doesn't support, such as modifying ARP fields. When it does this for a
> > tunneled packet, it needs to
From: Jesse Gross
Date: Tue, 24 Jun 2014 16:24:37 -0700
> Applied, thanks for all your work. Time to break out the champagne :)
Congrats, what an amazing journey :-)
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Jun 24, 2014 at 4:40 PM, Ben Pfaff wrote:
> Open vSwitch userspace is able to implement some actions that the kernel
> doesn't support, such as modifying ARP fields. When it does this for a
> tunneled packet, it needs to supply the tunnel information with a "set"
> action, because the Lin
json_string_unescape() flagged a backslash at the end of a string as an
error, but of course "\\" is a valid string. This fixes the problem.
VMware-BZ: #1275208
Reported-by: Michael Hu
Signed-off-by: Ben Pfaff
---
lib/json.c| 14 +-
tests/json.at |7 +++
2 files chang
Various recent commits have introduced build failures on FreeBSD. This
patch fixes them.
Signed-off-by: Joe Stringer
---
lib/bfd.c|1 +
lib/netdev-bsd.c |4 +++-
lib/signals.h|1 +
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/bfd.c b/lib/bfd.c
index d
Open vSwitch userspace is able to implement some actions that the kernel
doesn't support, such as modifying ARP fields. When it does this for a
tunneled packet, it needs to supply the tunnel information with a "set"
action, because the Linux kernel datapath throws away tunnel information
supplied
On Tue, Jun 24, 2014 at 4:56 AM, Simon Horman wrote:
> Allow datapath to recognize and extract MPLS labels into flow keys
> and execute actions which push, pop, and set labels on packets.
>
> Based heavily on work by Leo Alterman, Ravi K, Isaku Yamahata and Joe
> Stringer.
>
> Cc: Ravi K
> Cc: L
In dp_netdev_input() we nevered fully covered the case where handler queues are
not there.
With this change we increment the stat counter and free the packet.
Signed-off-by: Daniele Di Proietto
---
I can move this logic into dp_netdev_output_userspace(), if you guys think
that's more appropriate
We do not use any offloading (now) or multiple segments per packet, so
we might as well disable those features while configuring the NIC.
This could give performance improvements. For ixgbe, for example, this change
allows the driver to use a simpler tx routine, resulting in throuput
improvements
Signed-off-by: Daniele Di Proietto
---
lib/netdev-dpdk.c | 58 +++
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 3359517..79f67c1 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.
Commit f4fd623c4c25 introduced a bug in netdev_dpdk_send(): if multiple
consecutive packets exceed MTU, only the first one is deleted and
counted.
This should fix the bug
Signed-off-by: Daniele Di Proietto
---
lib/netdev-dpdk.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
d
>
> This patch kind of stands out to me when I look at it. It is awkward
> to have to create an extra object (wevent) on Windows but not use it
> anywhere except to pass to poll_fd_wait_event(). I didn't properly
> understand until now that this was necessary.
>
> Looking through the tree, I thin
The syntax is inconvenient but at least it's documented.
Signed-off-by: Ben Pfaff
---
utilities/ovs-ofctl.8.in |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index 61a0e0d..63f4fee 100644
--- a/utilities/ovs-ofctl.8.in
I think you mean Clang rather than sparse in this case.
Let's go with your original solution. It sounds like it's getting
complicated. I originally assumed that you just overlooked something.
On Tue, Jun 24, 2014 at 09:38:31PM +, Ryan Wilson 76511 wrote:
> So I added OVS_NO_THREAD_SAFETY_AN
Thanks, applied to master, branch-2.2, branch-2.3.
On Tue, Jun 24, 2014 at 02:33:45PM -0700, Ethan Jackson wrote:
> Acked-by: Ethan Jackson
>
>
> On Tue, Jun 24, 2014 at 1:48 PM, Ben Pfaff wrote:
> > We can't unlock the netdev's mutex after close the netdev, because closing
> > the netdev migh
So I added OVS_NO_THREAD_SAFETY_ANALYSIS to create_dp_netdev() and removed
OVS_NO_THREAD_SAFETY_ANALYSIS annotations on dpif_netdev_disable_upcall()
and dpif_netdev_enable_upcall(). However, I still get a warning from
sparse about dp->upcall_rwlock being locked / unlocked at the end of
dpif_netdev_
Acked-by: Ethan Jackson
On Tue, Jun 24, 2014 at 1:48 PM, Ben Pfaff wrote:
> We can't unlock the netdev's mutex after close the netdev, because closing
> the netdev might destroy the mutex.
>
> VMware-BZ: #1275187
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-vport.c |5 +++--
> 1 file cha
On Jun 8, 2014, at 1:18 PM, Pravin B Shelar wrote:
> dpif-packet contains ofpbuf which points to packet data. Here buf
> is better name rather than ofp.
> Following patch renames all remaining instances of ofp variable.
>
> Signed-off-by: Pravin B Shelar
> ---
> lib/netdev-dpdk.c | 4 ++--
> l
On Tue, Jun 24, 2014 at 01:41:13PM -0700, Ryan Wilson wrote:
> On Tue, Jun 24, 2014 at 8:44 AM, Ben Pfaff wrote:
> > I'm surprised that dpif_netdev_disable_upcall() is marked
> > OVS_NO_THREAD_SAFETY_ANALYSIS instead of
> > OVS_ACQUIRES(dp->upcall_rwlock). Similarly for
> > dpif_netdev_enable_upc
Typically, kernel datapath threads send upcalls to userspace where
handler threads process the upcalls. For TAP and DPDK devices, the
datapath threads operate in userspace, so there is no need for
separate handler threads.
This patch allows userspace datapath threads to directly call the
ofproto u
We can't unlock the netdev's mutex after close the netdev, because closing
the netdev might destroy the mutex.
VMware-BZ: #1275187
Signed-off-by: Ben Pfaff
---
lib/netdev-vport.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-vport.c b/lib/netdev-vport.c
i
Just one comment below. Otherwise, all other issues will be addressed in
the next patch.
Thanks!
On Tue, Jun 24, 2014 at 8:44 AM, Ben Pfaff wrote:
> On Wed, Jun 18, 2014 at 11:07:12AM -0700, Ryan Wilson wrote:
> > Typically, kernel datapath threads send upcalls to userspace where
> > handler t
On Jun 24, 2014, at 1:23 PM, Ben Pfaff wrote:
> On Mon, Jun 23, 2014 at 10:13:41AM -0700, Daniele Di Proietto wrote:
>> GCC 4.9.0 triggers a warning (array-bounds) while compiling test-classifier.c
>> This commit introduces an assertion that suppresses the warning.
>>
>> Signed-off-by: Daniele
On Tue, Jun 24, 2014 at 08:29:30PM +0200, Thomas Graf wrote:
> Make the parser compatible with how we print group buckets and allow
> actions= to be specified, e.g.:
>
> group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
>
> Also, better document the supported syntax in the manu
On Mon, Jun 23, 2014 at 10:13:41AM -0700, Daniele Di Proietto wrote:
> GCC 4.9.0 triggers a warning (array-bounds) while compiling test-classifier.c
> This commit introduces an assertion that suppresses the warning.
>
> Signed-off-by: Daniele Di Proietto
> ---
> While I feel that this is a GCC pr
Thanks, applied.
On Tue, Jun 24, 2014 at 06:11:36PM +, Pritesh Kothari (pritkoth) wrote:
> Acked-by: Pritesh Kothari
>
> On Jun 24, 2014, at 8:54 AM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/netdev-dpdk.c | 7 ---
> > 1 file changed, 4 insertions(+), 3 deletions(
dpif-packet contains ofpbuf which points to packet data. Here buf
is better name rather than ofp.
Following patch renames all remaining instances of ofp variable.
Signed-off-by: Pravin B Shelar
---
lib/netdev-dpdk.c | 4 ++--
lib/odp-execute.c | 20 ++--
lib/packet-dpif.h | 4
On Windows, we create "unix sockets" by creating TCP sockets
and hiding the TCP port number in files. When we close the
pstream session, we need to delete the file.
Signed-off-by: Gurucharan Shetty
---
lib/stream-fd-windows.c |4
lib/stream-tcp.c| 19 +--
2 fil
Also, fflush(stderr) when we raise a signal. The test
this commit is changing would fail otherwise.
Signed-off-by: Gurucharan Shetty
---
lib/fatal-signal.c |1 +
tests/ovs-vsctl.at | 16 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/lib/fatal-signal.c b/l
Commit ebed9f78(ovsdb-server: Improve message for "add-db" of
database already open.) improved the error message seen when
opening an already opened database on Linux. For Windows,
we still need to look for the lockfile error message.
Signed-off-by: Gurucharan Shetty
---
tests/ovsdb-server.at |
interface-reconfigure.at mostly tests functionality for Xenserver
and the tests use some POSIX only features. Skip them for Windows.
Signed-off-by: Gurucharan Shetty
---
tests/interface-reconfigure.at |4
1 file changed, 4 insertions(+)
diff --git a/tests/interface-reconfigure.at b/tes
There is no one-one mapping of symlinks between Linux and
Windows. This test currently fails on Windows and we do not
really need this functionality on Windows. So skip it.
Signed-off-by: Gurucharan Shetty
---
tests/file_name.at |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/file_n
The unit test, "OFPST_TABLE reply - OF1.2" in ofp-print.at
sends a very large hex string as an argument to 'ovs-ofctl ofp-print'.
The length of the hex string exceeds the maximum command line length
in Windows. With this commit, we can pass the same hex string by
placing it inside a file.
Signed-o
By default, three digit exponents are printed on Windows.
Many unit tests in Open vSwitch expect two digit exponents.
Signed-off-by: Gurucharan Shetty
---
lib/util.c |1 +
1 file changed, 1 insertion(+)
diff --git a/lib/util.c b/lib/util.c
index 60ec5bc..01ba6bc 100644
--- a/lib/util.c
+++
On Windows, when a peer terminates without calling a close
on socket fd, the server ends up printing "connection dropped"
warning messages. We probably don't want those warning messages
when the error is WSAECONNRESET.
(In OVS unit tests on Windows, anytime a client like ovs-ofctl
calls a ovs_fata
rename() on an existing destination file fails on Windows. This commit
worksaround that problem.
There are two tests that test it. But both of them use the ovsdb-server's
--run option for the test and it does not exist in Windows. So change
the test to workaround the lack of that feature.
Signed-
sflow feature needs to be investigated for Windows. Right now
test-sflow related tests do not pass because of LOOPBACK_INTERFACE
constraints for 'agent'. Add a TODO item and skip the tests.
Signed-off-by: Gurucharan Shetty
---
BUILD.Windows |1 +
tests/ofproto-dpif.at |1 +
2 fil
vlan splinters is to workaround buggy network drivers of Linux.
Skip the test for Windows.
Signed-off-by: Gurucharan Shetty
---
tests/vlan-splinters.at |1 +
1 file changed, 1 insertion(+)
diff --git a/tests/vlan-splinters.at b/tests/vlan-splinters.at
index 3cc6187..b38ab52 100644
--- a/tes
On Windows ECONNRESET is WSAECONNRESET.
Also, "unix" connections are done through TCP sockets.
For the 'refuse-connection' test, the error message for Windows
is WSAECONNRESET instead of EPIPE.
Signed-off-by: Gurucharan Shetty
---
tests/test-vconn.c | 16 ++--
1 file changed, 14 i
"xargs echo" introduces "^M" character inbetween the
records on Windows. Workaround it.
Signed-off-by: Gurucharan Shetty
---
tests/ovs-vsctl.at |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at
index 9fa3468..f27ffbd 100644
--- a/
For this particular test, we pass the PKIDIR through a
ovsdb-tool transact and msys does not convert the path style.
(On Windows, we have to pass the directory in the form C:/foo/bar.pem.)
So get the Windows style path through 'pwd -W'(which is called through
the function pwd ())
Signed-off-by: G
We do not support that option in Windows.
Signed-off-by: Gurucharan Shetty
---
tests/ovsdb-server.at |4
1 file changed, 4 insertions(+)
diff --git a/tests/ovsdb-server.at b/tests/ovsdb-server.at
index 08c56ca..77b7dc1 100644
--- a/tests/ovsdb-server.at
+++ b/tests/ovsdb-server.at
@@ -
msys has a set of rules which triggers an automatic conversion of
arguments into something else to suit Windows requirements. Sometimes
this also causes unwanted conversions. Details of the rules is here:
http://www.mingw.org/wiki/Posix_path_conversion
msys converts ::1/::1 into ;1\;1. To prevent
On Windows, we really do not have any "socket" files created.
We instead create a regular file with a TCP port number written
inside it.
Signed-off-by: Gurucharan Shetty
---
tests/ovsdb-server.at | 18 +++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/tests/ovsd
Ben,
Thanks, I didn¹t catch that. I will fix the makefile to exclude it.
Gerald
On 6/24/14, 12:35 PM, "Ben Pfaff" wrote:
>I think you misread Pravin's message. That's what he gets without
>using --with-dpdk. Without --with-dpdk, OVS shouldn't need the DPDK
>headers.
>
>On Tue, Jun 24, 2014
I think you misread Pravin's message. That's what he gets without
using --with-dpdk. Without --with-dpdk, OVS shouldn't need the DPDK
headers.
On Tue, Jun 24, 2014 at 07:29:29PM +, Rogers, Gerald wrote:
> Pravin,
>
> Which version of DPDK are you using?
>
> In mine the rte_config.h is loca
Pravin,
Which version of DPDK are you using?
In mine the rte_config.h is located in the DPDK directory
include/rte_config.h
Gerald
On 6/24/14, 12:11 PM, "Pravin Shelar" wrote:
>Hi Gerald,
>
>Thanks for updating patch, here are few comments:
>
>I got compilation erorr without --with-dpdk confi
Hi Gerald,
Thanks for updating patch, here are few comments:
I got compilation erorr without --with-dpdk config option:
tests/ovs_client/ovs_client.c:38:24: fatal error: rte_config.h: No
such file or directory
#include
On Mon, Jun 23, 2014 at 4:55 AM, wrote:
> S
Thanks. I played with this a little and sent out a patch documenting
it:
http://openvswitch.org/pipermail/dev/2014-June/041999.html
On Mon, Jun 23, 2014 at 10:51:16PM +, Rogers, Gerald wrote:
> Ben,
>
> I used the following indent options to format the file :
>
> indent -bad -bap -b
Suggested-by: Gerald Rogers
Signed-off-by: Ben Pfaff
---
AUTHORS |1 +
CodingStyle |7 +++
2 files changed, 8 insertions(+)
diff --git a/AUTHORS b/AUTHORS
index 64ede54..0a6c61a 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -186,6 +186,7 @@ Eric Lopez elo...@nicira.com
Fri
On Tue, Jun 24, 2014 at 11:09:48AM -0700, Ben Pfaff wrote:
> On Wed, Jun 18, 2014 at 10:14:30PM -0300, Flavio Leitner wrote:
> > Add IGMP info to struct flow, flow compose and flow extract.
> >
> > Signed-off-by: Flavio Leitner
> > ---
> > lib/flow.c | 22 --
Make the parser compatible with how we print group buckets and allow
actions= to be specified, e.g.:
group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
Also, better document the supported syntax in the manual page and
cover both syntax formats in the unit test.
Signed-off-by: T
On Mon, Jun 23, 2014 at 09:33:56AM +1200, Joe Stringer wrote:
> This could cause configuration failure on earlier versions of autoconf.
>
> Reported-by: Lin Shaopeng
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswit
On Sat, Jun 21, 2014 at 11:59:52AM +0200, Pim van den Berg wrote:
> Signed-off-by: Pim van den Berg
Thanks, applied. I changed "! test" to "test !" for greatest
portability.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listin
On Wed, Jun 18, 2014 at 10:14:28PM -0300, Flavio Leitner wrote:
> Currently it supports IGMPv1 and IGMPv2 only.
>
> Flavio Leitner (7):
> lib: Add IGMP snooping library bits
> flow: extend it to carry IGMP protocol information
> ofproto-dpif: Introduce multicast snooping handler
> ofproto:
Acked-by: Pritesh Kothari
On Jun 24, 2014, at 8:54 AM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-dpdk.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
> index 6d92969..3359517 100644
> --- a/lib/netdev-
On Wed, Jun 18, 2014 at 10:14:30PM -0300, Flavio Leitner wrote:
> Add IGMP info to struct flow, flow compose and flow extract.
>
> Signed-off-by: Flavio Leitner
> ---
> lib/flow.c | 22 --
> lib/flow.h | 11 ++-
> lib/match.c
On Tue, Jun 24, 2014 at 10:08:16AM -0700, Gurucharan Shetty wrote:
> There are always a few unit tests that have some race conditions
> that cause them to occasionally fail. It is probably a good idea
> to re-run the failed tests once while building deb packages.
>
> Signed-off-by: Gurucharan Shet
There are always a few unit tests that have some race conditions
that cause them to occasionally fail. It is probably a good idea
to re-run the failed tests once while building deb packages.
Signed-off-by: Gurucharan Shetty
Co-authored-by: Keith Amidon
Signed-off-by: Keith Amidon
---
debian/ru
On 06/24/14 at 08:56am, Ben Pfaff wrote:
> On Fri, Jun 20, 2014 at 02:24:50PM +0200, Thomas Graf wrote:
> > Make the parser compatible with how we print group buckets and allow
> > actions= to be specified, e.g.:
> >
> > group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
> >
> >
On Tue, Jun 24, 2014 at 9:46 AM, Gurucharan Shetty wrote:
> On Mon, Jun 23, 2014 at 11:51 AM, Ben Pfaff wrote:
>> On Fri, Jun 13, 2014 at 07:40:02AM -0700, Gurucharan Shetty wrote:
>>> There is no 'kill -l' type functionality available on Windows.
>>> So instead of looking for the string 'ABRT',
>
> There's a lot of weirdness around python and encodings that varies from
> version to version and from one Python configuration to the next. Did
> you try this on a non-XenServer system too, say Ubuntu? Also you might
> want to try on the Arch distro (I think that's Ethan uses) because I
> see
On Mon, Jun 23, 2014 at 11:51 AM, Ben Pfaff wrote:
> On Fri, Jun 13, 2014 at 07:40:02AM -0700, Gurucharan Shetty wrote:
>> There is no 'kill -l' type functionality available on Windows.
>> So instead of looking for the string 'ABRT', check for the exit
>> code in both platforms. On msys (unit test
FYI: The status of the openvswitch source package
in Debian's testing distribution has changed.
Previous version: 1.9.3+git20131029-1.1
Current version: 2.1.0+git20140411-3
--
This email is automatically generated once a day. As the installation of
new packages into testing happens multipl
That's fine. Thanks!
On Jun 24, 2014 9:24 AM, "Gurucharan Shetty" wrote:
> On Mon, Jun 23, 2014 at 10:52 AM, Ben Pfaff wrote:
> > On Fri, Jun 13, 2014 at 07:40:00AM -0700, Gurucharan Shetty wrote:
> >> WSAStartup() needs to be called before using winsock2 related
> >> functions. We need this for
On Mon, Jun 23, 2014 at 10:52 AM, Ben Pfaff wrote:
> On Fri, Jun 13, 2014 at 07:40:00AM -0700, Gurucharan Shetty wrote:
>> WSAStartup() needs to be called before using winsock2 related
>> functions. We need this for almost all the utilities. So call
>> it through OVS_CONSTRUCTOR.
>>
>> Signed-off-
On Fri, Jun 20, 2014 at 01:21:42PM -0700, Gurucharan Shetty wrote:
> Run the following command on Xenserver:
> PYTHONPATH=`pwd`/python/compat::`pwd`/python python ./tests/test-ovsdb.py \
> parse-atoms '{"type": "string", "minLength": 2}'\
> '[""]' '["a"]' '["ab"]' '["abc"]' '["\
On Fri, Jun 20, 2014 at 12:22:15PM -0700, Gurucharan Shetty wrote:
> In addition to the above bug, I see some other wierdness while dealing with
> unicode on Xenserver and Python 2.4.3 . As an example, the following diff
> would work fine if python is run from command line but not from inside
> tes
On Tue, Jun 24, 2014 at 09:13:14AM -0700, Ben Pfaff wrote:
> On Fri, Jun 20, 2014 at 12:22:15PM -0700, Gurucharan Shetty wrote:
> > In addition to the above bug, I see some other wierdness while dealing with
> > unicode on Xenserver and Python 2.4.3 . As an example, the following diff
> > would wor
On Fri, Jun 20, 2014 at 12:22:14PM -0700, Gurucharan Shetty wrote:
> There is no 'errno' field in socket.error. Instead use the
> get_exception_errno() function to get the error number.
>
> Signed-off-by: Gurucharan Shetty
Acked-by: Ben Pfaff
___
dev
Please stay on the mailing list.
I'm not doing substantive review of the patch, so I don't need a new
repost. It is possible that whoever does review the patch could request
one.
It is customary to describe the changes from one version of a patch to
another following the commit message, near the
On Fri, Jun 20, 2014 at 04:23:48PM +0100, maryam.tahhan wrote:
> From: "maryam.tahhan"
>
> This patch enables arbitrary port naming for vhost patches, so
> they no longer need to be called dpdkvhost.
>
> Signed-off-by: maryam.tahhan
Oh, also the subject should be:
[PATCH] netdev-dpdk:
On Fri, Jun 20, 2014 at 04:23:48PM +0100, maryam.tahhan wrote:
> From: "maryam.tahhan"
>
> This patch enables arbitrary port naming for vhost patches, so
> they no longer need to be called dpdkvhost.
>
> Signed-off-by: maryam.tahhan
This is not a substantive review, but I do have a few comment
On Fri, Jun 20, 2014 at 01:55:19PM -0700, Gurucharan Shetty wrote:
> There are always a few unit tests that have some race conditions
> that cause them to occasionally fail. It is probably a good idea
> to re-run the failed tests once while building deb packages.
>
> Co-Authored-By: Keith Amidon
On Fri, Jun 20, 2014 at 02:24:50PM +0200, Thomas Graf wrote:
> Make the parser compatible with how we print group buckets and allow
> actions= to be specified, e.g.:
>
> group_id=1,type=all,bucket=actions=output:2,bucket=actions=output:3
>
> Also, better document the supported syntax in the manu
Signed-off-by: Ben Pfaff
---
lib/netdev-dpdk.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 6d92969..3359517 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -832,7 +832,6 @@ netdev_dpdk_set_mtu(const struct netdev
On Fri, Jun 20, 2014 at 01:17:36PM +0200, Thomas Graf wrote:
> Signed-off-by: Thomas Graf
Both applied, thanks!
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Jun 19, 2014 at 10:58:26PM +, Polehn, Mike A wrote:
> Large TX and RX queues are needed for high speed 10 GbE physical NICS.
> Observed a 250% zero loss improvement over small NIC queue test for
> A port to port flow test.
>
> Signed-off-by: Mike A. Polehn
Please be more careful wit
On Wed, Jun 18, 2014 at 11:07:12AM -0700, Ryan Wilson wrote:
> Typically, kernel datapath threads send upcalls to userspace where
> handler threads process the upcalls. For TAP and DPDK devices, the
> datapath threads operate in userspace, so there is no need for
> separate handler threads.
>
> Th
On Mon, Jun 16, 2014 at 11:33:15AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
1 - 100 of 113 matches
Mail list logo
