In OVS we only support a single aggregator per port. I understand
that Linux supports multiple, and that perhaps this problem would be
easier to work around if we did as well. But today we don't, and IMO
implementing this feature would be rather complex. Of course, an
implementation would be wel
Before this commit, ovs only creates one tx/rx queue for each
dpdk interface and uses only one poll thread for handling the
I/O of all dpdk interfaces. As one step toward using multiple
poll threads, this commit makes ovs, by default, create same
number of rx queues as the number dpdk interfaces o
Signed-off-by: Alex Wang
---
Changes since first post:
- use readdir() for the buffer safety.
- only compile ovs-numa.c in linux.
- make ovs_numa_get_n_sockets/cores() return *UNSPEC if there
is no sockets or cores extracted.
- refine code based on Ben's review.
- Address review comments from T
Later patch will use this patch to configure the pmd thread
cpu affinity.
Signed-off-by: Alex Wang
---
lib/ovs-numa.c | 87
lib/ovs-numa.h |7 +
2 files changed, 82 insertions(+), 12 deletions(-)
diff --git a/lib/ovs-numa.c b/li
Later patch will use this function to configure rx queues.
Signed-off-by: Alex Wang
---
lib/netdev-dpdk.c | 42 +-
lib/netdev-dpdk.h |7 +++
2 files changed, 48 insertions(+), 1 deletion(-)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
inde
This series of patches adds the multithreading functionality
to OVS dpdk module. Users are able to create multiple pmd
threads and set their cpu affinity via specifying a cpu mask
string similar to the EAL '-c COREMASK' option. Also, the
number of rx queues for each dpdk interface can be configur
This commits adds the multithreading functionality to OVS dpdk
module. Users are able to create multiple pmd threads and set
their cpu affinity via specifying the cpu mask string similar
to the EAL '-c COREMASK' option.
Also, the number of rx queues for each dpdk interface is made
configurable to
This commit makes the memory pool name contain the socket id.
Since dpdk library do not allow creation of memory pool with
same name, this commit serves as a simple way of making each
name unique.
Signed-off-by: Alex Wang
Acked-by: Thomas Graf
---
lib/netdev-dpdk.c |3 ++-
1 file changed, 2
Signed-off-by: Alex Wang
---
lib/netdev-dpdk.c | 14 ++
lib/netdev-dpdk.h |8
2 files changed, 22 insertions(+)
diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
index 6ee9803..7298334 100644
--- a/lib/netdev-dpdk.c
+++ b/lib/netdev-dpdk.c
@@ -1442,6 +1442,20 @@ netde
The pmd threads are pinned to available cpu cores on the
corresponding cpu socket. Note, core 0 is not pinnable
and is reserved for all non-pmd threads.
Signed-off-by: Alex Wang
---
lib/dpif-netdev.c | 254 +
lib/dpif-netdev.h |2 +-
lib/
-1 was used to indicate both nested and variable length attributes.
This patch introduces OVS_KEY_LEN_NESTED and OVS_KEY_LEN_VARIABLE to
tell them apart.
Refactor nlattr_set() to more more generally all ovs netlink key
attributes.
Signed-off-by: Andy Zhou
---
datapath/flow_netlink.c | 53 ++
This commit adds options for configuring the MAC addresses
in BFD state machine. Therein, the "bfd_local_src_mac" and
"bfd_local_dst_mac" configure the MAC address of sent BFD
packets. The "bfd_remote_dst_mac" configure the matching
of MAC address on recevied BFD packets.
Signed-off-by: Alex Wan
On Mon, Aug 11, 2014 at 05:47:48PM +0100, Zoltan Kiss wrote:
> On 08/08/14 02:38, Flavio Leitner wrote:
> >On Thu, Aug 07, 2014 at 04:19:17PM +0100, Zoltan Kiss wrote:
> >>On 05/08/14 22:16, Flavio Leitner wrote:
> >>>On Mon, Aug 04, 2014 at 12:08:48PM -0700, Andy Zhou wrote:
> Zoltan,
>
>
On Mon, Aug 11, 2014 at 9:15 AM, Jarno Rajahalme wrote:
> Masked set action allows more megaflow wildcarding. Masked set action
> is now supported for all writeable key types, except for the tunnel
> key.
>
> The set tunnel action is an exception as any input tunnel info is
> cleared before actio
On Mon, Aug 11, 2014 at 5:13 PM, Flavio Leitner wrote:
> On Mon, Aug 11, 2014 at 03:54:18PM -0700, Pravin B Shelar wrote:
>> CC: Ben Pfaff
>> Signed-off-by: Flavio Leitner
>> Signed-off-by: Pravin B Shelar
>> ---
>
> Since I already signed-off, LGTM :-)
> Thanks for putting everything together.
OK.
I folded in the following changes. They enable building the header on
all platforms (which is useful to allow developers on every platform
to test it) and drop unnecessary extra $(srcdir). Also I removed a
redundant copy of the first line from the commit message.
I also removed the change t
On Mon, Aug 11, 2014 at 03:54:18PM -0700, Pravin B Shelar wrote:
> CC: Ben Pfaff
> Signed-off-by: Flavio Leitner
> Signed-off-by: Pravin B Shelar
> ---
Since I already signed-off, LGTM :-)
Thanks for putting everything together.
fbl
___
dev mailing l
On Mon, Aug 11, 2014 at 03:54:06PM -0700, Pravin B Shelar wrote:
> Add usage info for ovs-vswitchd dpdk option. Update
> INSTALL.DPDK file and man page.
>
> Reported-by: Hari Sasank Bhamidipalli
> Signed-off-by: Pravin B Shelar
> ---
Acked-by: Flavio Leitner
__
On Aug 11, 2014, at 4:01 PM, Ankur Sharma
wrote:
> Hi Ben,
>
> Thanks a lot for your reply.
>
> The reason we did not generate header file in build directory is because as
> of now the windows datapath build is not coupled with user-space build.
> The userspace build system is 'make' and com
CC: Ben Pfaff
Signed-off-by: Flavio Leitner
Signed-off-by: Pravin B Shelar
---
debian/openvswitch-common.docs | 1 +
rhel/openvswitch-fedora.spec.in | 1 +
rhel/openvswitch.spec.in| 7 ++-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/debian/openvswitch-common.docs
Hi Ben,
Thanks a lot for your reply.
The reason we did not generate header file in build directory is because as of
now the windows datapath build is not coupled with user-space build.
The userspace build system is 'make' and command line based, and the kernel is
being compiled from Visual Stud
On Mon, Aug 11, 2014 at 03:54:18PM -0700, Pravin B Shelar wrote:
> CC: Ben Pfaff
> Signed-off-by: Flavio Leitner
> Signed-off-by: Pravin B Shelar
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Aug 11, 2014 at 03:54:06PM -0700, Pravin B Shelar wrote:
> Add usage info for ovs-vswitchd dpdk option. Update
> INSTALL.DPDK file and man page.
>
> Reported-by: Hari Sasank Bhamidipalli
> Signed-off-by: Pravin B Shelar
Acked-by: Ben Pfaff
__
Add usage info for ovs-vswitchd dpdk option. Update
INSTALL.DPDK file and man page.
Reported-by: Hari Sasank Bhamidipalli
Signed-off-by: Pravin B Shelar
---
AUTHORS| 1 +
INSTALL.DPDK | 5 ++---
vswitchd/ovs-vswitchd.8.in | 4
vswitchd/ovs-vswitchd.c|
I am happy to rename these to OvsAtomicAdd64, OvsAtomicInc64, etc. The code
that was using the atomic adds probably got deleted and hence it has no
references anymore. It was certianly used at some point.
Without the casting, I get the following error (we treat warnings as error for
the kernel
On Mon, Aug 11, 2014 at 9:14 AM, Jarno Rajahalme wrote:
> diff --git a/tests/odp.at b/tests/odp.at
> index e725f70..58e3ff1 100644
> --- a/tests/odp.at
> +++ b/tests/odp.at
+set(ipv4(src=35.8.2.41/255.255.255.255,dst=172.16.0.20/255.255.255.255,proto=5/0xff,tos=0x80/0,ttl=128/0xff,frag=no/0xff))
>
When flow key becomes invalid due to push or pop actions, current
implementation leaves it as invalid, only rebuild the flow key used
for recirculation.
This works, but is less efficient in case of multiple recirc
actions. Each recirc action will have to re-extract
its own flow keys.
This patch u
On Mon, Aug 11, 2014 at 2:32 PM, Jarno Rajahalme wrote:
>
> On Aug 11, 2014, at 2:22 PM, Andy Zhou wrote:
>
>> When flow key becomes invalid due to push or pop actions, current
>> implementation leaves it as invalid, only rebuild the flow key used
>> for recirculation.
>>
>> This works, but is le
These error codes are proposed in the ONF extensibility working group as an
OpenFlow 1.3 extension.
Error codes are also proposed for the other three "bad property" error
codes, but those already have standardized OpenFlow 1.3 error codes and the
proposal says that implementations should use the s
Meter requests should use dump/stats transaction, instead of
transact_noreply, which caused the output to go to stderr and an error
exit.
Signed-off-by: Jarno Rajahalme
---
utilities/ovs-ofctl.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/utilities/ovs-ofctl.c b/
Meter action can drop or modify packets, so the execution framework is
changed to allow for this. Also, a meter action can appear alone
(e.g., to measure traffic that is to be dropped), so the existing drop
implementation is not sufficient any more.
The action execution framework is changed in th
Meters may be used by any flow, so some kind of locking must be used.
In this version we have an adaptive mutex for each meter, which may
not be optimal for DPDK. However, this should serve as a basis for
further improvement.
A batch of packets is first tried as a whole, and only if some of the
m
Signed-off-by: Jarno Rajahalme
---
utilities/ovs-ofctl.8.in |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index aafda23..b0a2c87 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
@@ -1983,7 +1983,7 @@
This is a rebase of the series due to recent changes in lib/ofp-actions.c.
Jarno Rajahalme (6):
utilities/ovs-ofctl: Fix meter requests.
ovs-ofctl: Fix a typo in documentation.
ofproto: Check actions also for packet outs and traces.
dpif: Meter framework.
lib/odp, ofproto xlate: Meter ex
Add DPIF-level infrastructure for meters. Allow meter_set to modify
the meter configuration (e.g. set the burst size if unspecified).
Signed-off-by: Jarno Rajahalme
---
datapath/linux/compat/include/linux/openvswitch.h |3 +
lib/dpif-linux.c | 40 +
Make the packet out and trace processing perform the same actions
checks as flow mod processing does.
This used to be the case before, but at some point these have diverged
to perform different combinations of checks.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif.c | 30
This needs a rebase due to the recent lib/ofp-actions.c changes. I’ll post a v2
in a moment.
Jarno
On Aug 5, 2014, at 4:38 PM, Jarno Rajahalme wrote:
> Meter action can drop or modify packets, so the execution framework is
> changed to allow for this. Also, a meter action can appear alone
>
On Mon, Aug 11, 2014 at 08:17:19PM +0200, Dariusz Dwornikowski wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> On 11.08.2014 17:38, Ben Pfaff wrote:
> > On Mon, Aug 11, 2014 at 09:53:09AM +0200, Dariusz Dwornikowski
> > wrote:
> >> Source: openvswitch Severity: wishlist
> >>
> >> D
On Aug 11, 2014, at 2:22 PM, Andy Zhou wrote:
> When flow key becomes invalid due to push or pop actions, current
> implementation leaves it as invalid, only rebuild the flow key used
> for recirculation.
>
> This works, but is less efficient in case of multiple recirc
> actions. Each recirc ac
When flow key becomes invalid due to push or pop actions, current
implementation leaves it as invalid, only rebuild the flow key used
for recirculation.
This works, but is less efficient in case of multiple recirc
actions. Each recirc action will have to re-extract
its own flow keys.
This patch u
Thanks, I'll push this series in a minute.
On Mon, Aug 11, 2014 at 02:11:02PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 11, 2014, at 1:44 PM, Ben Pfaff wrote:
>
> > Based on the OpenFlow 1.5 draft.
> >
> > ONF-JIRA: EXT-425
> > Signed-off-by: Ben Pfaff
> > ---
> >
On Mon, Aug 11, 2014 at 02:10:46PM -0700, Jarno Rajahalme wrote:
> I find the identifier ?max_actions? still misleading, ?actions_len? would be
> better.
I agree.
I made that change.
> Acked-by: Jarno Rajahalme
Thanks, I'll apply this soon.
___
dev
Acked-by: Jarno Rajahalme
On Aug 11, 2014, at 1:44 PM, Ben Pfaff wrote:
> Based on the OpenFlow 1.5 draft.
>
> ONF-JIRA: EXT-425
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-actions.c|2 +-
> lib/ofp-errors.h |4
> tests/ofp-actions.at | 12 +---
> 3 files changed, 1
Exponential bug :-)
I find the identifier ‘max_actions’ still misleading, ‘actions_len’ would be
better.
Acked-by: Jarno Rajahalme
On Aug 11, 2014, at 1:44 PM, Ben Pfaff wrote:
> The following commit adds a test.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-actions.c |4 ++--
> 1 file c
Based on the OpenFlow 1.5 draft.
ONF-JIRA: EXT-425
Signed-off-by: Ben Pfaff
---
lib/ofp-actions.c|2 +-
lib/ofp-errors.h |4
tests/ofp-actions.at | 12 +---
3 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index
On Mon, Aug 11, 2014 at 11:43:22AM -0700, Ankur Sharma wrote:
> odp-netlink.h: Autogenerate a version of odp-netlink for windows kernel.
>
> Autogenerated odp-netlink.h will not compile with windows kernel, as
> it refers to some userspace files like openvswitch/types.h and
> packets.h which hyper
The following commit adds a test.
Signed-off-by: Ben Pfaff
---
lib/ofp-actions.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c
index bcadb55..8f3af19 100644
--- a/lib/ofp-actions.c
+++ b/lib/ofp-actions.c
@@ -4167,7 +4167,7 @@ lo
Applied, thanks!
On Mon, Aug 11, 2014 at 11:46:20AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:14 PM, Ben Pfaff wrote:
>
> > ONF-JIRA: EXT-320
> > Signed-off-by: Ben Pfaff
> > ---
> > NEWS |1 +
> > lib/ofp-actions.c| 80
> > ++
Applied, thanks!
On Mon, Aug 11, 2014 at 11:39:41AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:14 PM, Ben Pfaff wrote:
>
> > Until now, there were four of these commands: parse-ofp10-actions,
> > parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11
Thanks for the review!
On Mon, Aug 11, 2014 at 11:34:58AM -0700, Jarno Rajahalme wrote:
> Nice cleanup, especially like the way wire formats are now hidden
> inside lib/ofp-actions.c.
>
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:14 PM, Ben Pfaff wrote:
> > +/* XXX
> > + *
> >
Thanks, applied to master.
On Mon, Aug 11, 2014 at 10:17:08AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> > This allows callers to be more uniform, because they don't have to pick
> > out whether they should parse actions or in
Thanks, applied.
On Mon, Aug 11, 2014 at 09:59:12AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> > An upcoming commit will use them from ofp-actions.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > lib/ofp-parse.c | 14 +++-
Thanks, applied to master.
On Mon, Aug 11, 2014 at 09:56:30AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> > Signed-off-by: Ben Pfaff
> > ---
> > utilities/ovs-ofctl.c |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, pushed to master.
On Mon, Aug 11, 2014 at 09:54:27AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> > "apply_actions" is assumed, any other instruction has to be specified
> > explicitly.
> >
> > Signed-off-by: Ben Pfaff
Thanks. I fixed both nits and applied this to master.
On Fri, Aug 08, 2014 at 01:07:00PM -0700, Jarno Rajahalme wrote:
> Small nits below. Also, I did not verify this against the OpenFlow spec.
> Otherwise:
>
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> >
Thanks, applied to master.
On Fri, Aug 08, 2014 at 12:36:03PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> > The call to parse_oxms() inside ofputil_decode_table_features() sets only
> > one bit in either 'match' or 'mask' for a
Thanks, I'll apply this in a minute.
On Fri, Aug 08, 2014 at 12:31:51PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> > Parsing of actions was wrong because OF1.3 says that non-experimenter
> > actions are 4 bytes and don't inclu
odp-netlink.h: Autogenerate a version of odp-netlink for windows kernel.
Autogenerated odp-netlink.h will not compile with windows kernel, as
it refers to some userspace files like openvswitch/types.h and
packets.h which hyperv extension does not access. Due to this the
windows datapath compilatio
Acked-by: Jarno Rajahalme
On Aug 7, 2014, at 4:14 PM, Ben Pfaff wrote:
> ONF-JIRA: EXT-320
> Signed-off-by: Ben Pfaff
> ---
> NEWS |1 +
> lib/ofp-actions.c| 80 ++
> tests/ofp-actions.at | 24 +++
> 3 files c
On Fri, Aug 08, 2014 at 11:42:53AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> So we do not have a test case that would pull table features for
> multiple tables from a single OpenFlow message?
That is correct. The later commit that adds ofproto support for
table-features adds
Acked-by: Jarno Rajahalme
On Aug 7, 2014, at 4:14 PM, Ben Pfaff wrote:
> Until now, there were four of these commands: parse-ofp10-actions,
> parse-ofp10-instructions, parse-ofp11-actions, parse-ofp11-instructions.
> This is painful to add support for new OpenFlow versions and has a ton of
> cu
On Fri, Aug 08, 2014 at 11:32:40AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> Two small nits and a comment error (?) spotted below,
>
> Jarno
>
> On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
>
> > +
> > +static struct mf_bitmap
> > +mf_bitmap_from_of10(ovs_be32 wc10)
> >
Nice cleanup, especially like the way wire formats are now hidden inside
lib/ofp-actions.c.
Some small comments below,
Jarno
Acked-by: Jarno Rajahalme
On Aug 7, 2014, at 4:14 PM, Ben Pfaff wrote:
> Until now, knowledge about OpenFlow has been somewhat scattered around the
> tree. Some of
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 11.08.2014 17:38, Ben Pfaff wrote:
> On Mon, Aug 11, 2014 at 09:53:09AM +0200, Dariusz Dwornikowski
> wrote:
>> Source: openvswitch Severity: wishlist
>>
>> Dear Maintainer,
>>
>> Tomasz Buchert and I are working on introducing mininet, an SDN
>
Thanks, applied!
On Thu, Aug 07, 2014 at 04:13:49PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Aug 4, 2014, at 9:21 AM, Ben Pfaff wrote:
>
> > OFPTC11_TABLE_MISS_MASK isn't a valid value at all, let alone always the
> > value in use. We should report the value actually i
On Thu, Aug 07, 2014 at 04:11:23PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
Thanks!
> > --- a/lib/ofp-actions.c
> > +++ b/lib/ofp-actions.c
> > @@ -1646,6 +1646,72 @@ OVS_INSTRUCTIONS
> > }
> > }
> >
> > +struct ovsinst_xlate {
> > +enum ovs_instruction_type ovsinst;
>
On Thu, Aug 07, 2014 at 04:03:21PM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> Three minor comments below,
>
> Jarno
>
> On Aug 4, 2014, at 9:21 AM, Ben Pfaff wrote:
>
> > Until now, sets of actions have been abstracted separately outside
> > ofp-actions, as enum ofputil_a
On Mon, Aug 11, 2014 at 05:34:43PM +, Nithin Raju wrote:
> On Aug 11, 2014, at 10:04 AM, Ben Pfaff
> wrote:
>
> > On Mon, Aug 11, 2014 at 04:19:41PM +, Nithin Raju wrote:
> >> 5. Samuel's reviews:
> >> * I'll let Sam and Alin fill this in.
> >
> > I hope that code reviews will be main
On Aug 11, 2014, at 10:04 AM, Ben Pfaff
wrote:
> On Mon, Aug 11, 2014 at 04:19:41PM +, Nithin Raju wrote:
>> 5. Samuel's reviews:
>> * I'll let Sam and Alin fill this in.
>
> I hope that code reviews will be mainly on the mailing list. That's
> much easier to track. By my count, patches
On Fri, Aug 08, 2014 at 05:39:26PM +0530, Shashwat Srivastava wrote:
> I want to incorporate "Eviction mechanism" as per the openflow
> specification 1.4
>
> As per the openflow specification 1.4 (Section 7.3.4.1), there are three
> eviction flags: importance,lifetime and other. If importance fl
Acked-by: Jarno Rajahalme
On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
> This allows callers to be more uniform, because they don't have to pick
> out whether they should parse actions or instructions based on the OpenFlow
> version in use. It also allows the Write-Metadata instruction emulati
On Mon, Aug 11, 2014 at 10:04:22AM -0700, Pravin Shelar wrote:
> On Mon, Aug 11, 2014 at 10:01 AM, Ben Pfaff wrote:
> > On Thu, Aug 07, 2014 at 09:43:34PM -0300, Flavio Leitner wrote:
> >> On Thu, Aug 07, 2014 at 04:47:02PM -0700, Ben Pfaff wrote:
> >> > On Thu, Aug 07, 2014 at 07:20:41PM -0300, F
On Mon, Aug 11, 2014 at 04:19:41PM +, Nithin Raju wrote:
> 5. Samuel's reviews:
>* I'll let Sam and Alin fill this in.
I hope that code reviews will be mainly on the mailing list. That's
much easier to track. By my count, patches 7 through 13, plus patch
15, of Samuel's 15-patch series h
On Mon, Aug 11, 2014 at 10:01 AM, Ben Pfaff wrote:
> On Thu, Aug 07, 2014 at 09:43:34PM -0300, Flavio Leitner wrote:
>> On Thu, Aug 07, 2014 at 04:47:02PM -0700, Ben Pfaff wrote:
>> > On Thu, Aug 07, 2014 at 07:20:41PM -0300, Flavio Leitner wrote:
>> > > On Thu, Aug 07, 2014 at 01:46:52PM -0700, P
On Thu, Aug 07, 2014 at 09:43:34PM -0300, Flavio Leitner wrote:
> On Thu, Aug 07, 2014 at 04:47:02PM -0700, Ben Pfaff wrote:
> > On Thu, Aug 07, 2014 at 07:20:41PM -0300, Flavio Leitner wrote:
> > > On Thu, Aug 07, 2014 at 01:46:52PM -0700, Pravin Shelar wrote:
> > > > On Thu, Aug 7, 2014 at 12:55
Acked-by: Jarno Rajahalme
On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
> An upcoming commit will use them from ofp-actions.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-parse.c | 14 +++---
> lib/ofp-parse.h | 13 -
> 2 files changed, 19 insertions(+), 8 deletions(-)
>
On 06/08/14 05:44, Ethan Jackson wrote:
Based on my (long ago) reading of the LACP spec, only supporting a
single aggregator is a valid configuration. Furthermore, it's what
makes the most sense given the structure of the OVS bonding
configuration. I'd really rather not make a non standard chan
Acked-by: Jarno Rajahalme
On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-ofctl.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c
> index 7b4a006..4dc547d 100644
> --- a/util
Acked-by: Jarno Rajahalme
On Aug 7, 2014, at 4:13 PM, Ben Pfaff wrote:
> "apply_actions" is assumed, any other instruction has to be specified
> explicitly.
>
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-ofctl.8.in |3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/utilities/ov
On 08/08/14 02:38, Flavio Leitner wrote:
On Thu, Aug 07, 2014 at 04:19:17PM +0100, Zoltan Kiss wrote:
On 05/08/14 22:16, Flavio Leitner wrote:
On Mon, Aug 04, 2014 at 12:08:48PM -0700, Andy Zhou wrote:
Zoltan,
Sorry it took a while to get back to you. I am just coming up to
speed on OVS LACP
hi folks,
Here are the items to discuss. Pls. feel free to fill in more items.
1. Netlink implementation discussion - design discussions, status.
2. Discussion about the persistent ports patch that Cloudbase is tasked with.
3. Discussion about P0 issues.
4. Discussion of other issues.
5. Samuel's
Thanks for the review, pushed to master with the proposed change.
Jarno
On Aug 8, 2014, at 2:10 PM, Jesse Gross wrote:
> On Fri, Aug 8, 2014 at 1:28 PM, Jarno Rajahalme wrote:
>> diff --git a/datapath/flow_netlink.c b/datapath/flow_netlink.c
>> index e4cf535..294e54c 100644
>> --- a/datapath
Masked set action allows more megaflow wildcarding. Masked set action
is now supported for all writeable key types, except for the tunnel
key.
The set tunnel action is an exception as any input tunnel info is
cleared before action processing starts, so there is no tunnel info to
mask.
The kernel
Signed-off-by: Jarno Rajahalme
---
lib/odp-util.c | 368 ++
lib/odp-util.h |5 +-
ofproto/ofproto-dpif-xlate.c | 15 +-
tests/ofproto-dpif.at| 62 ---
tests/tunnel.at |8 +-
5 files changed,
Rebased to the recent datapath changes in actions.c.
Jarno Rajahalme (4):
lib/odp: Masked set action execution and printing.
ofproto: Probe for masked set action support.
lib/odp: Use masked set actions.
datapath: Allow masks for set actions.
datapath/actions.c
Add a new action type OVS_ACTION_ATTR_SET_MASKED, and support for
parsing, printing, and committing them.
Masked set actions add a mask, immediately following the netlink
attribute data, within the netlink attribute itself. Thus the key
attribute size for a masked set action is exactly double of
Signed-off-by: Jarno Rajahalme
Reviewed-by: YAMAMOTO Takashi
---
ofproto/ofproto-dpif-xlate.c | 18 +
ofproto/ofproto-dpif-xlate.h |3 ++-
ofproto/ofproto-dpif.c | 58 +-
3 files changed, 72 insertions(+), 7 deletions(-)
diff --g
Pushed,
Jarno
On Aug 8, 2014, at 2:12 PM, Jesse Gross wrote:
> On Fri, Aug 8, 2014 at 1:28 PM, Jarno Rajahalme wrote:
>> The ‘recalculate_csum’ is almost always ‘true’. It is false only if
>> the ipv6 nexthdr is an extension header, and a routing header is
>> found. For the majority of ipv
On Mon, Aug 11, 2014 at 09:53:09AM +0200, Dariusz Dwornikowski wrote:
> Source: openvswitch
> Severity: wishlist
>
> Dear Maintainer,
>
> Tomasz Buchert and I are working on introducing mininet, an SDN emulator
> (http://mininet.org/) to Debian.
> Mininet heavily depends on ovsk to provide OpenFlow
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Source: openvswitch
Severity: wishlist
91 matches
Mail list logo
