The original message was received at Wed, 10 Sep 2014 10:38:57 +0700
from openvswitch.org [64.194.198.15]
- The following addresses had permanent fatal errors -
dev@openvswitch.org
- Transcript of session follows -
... while talking to openvswitch.org.:
>>> MAIL FROM:"Returned mai
All NET_BUFFERs of a NET_BUFFER_LIST must go through the pipeline: extract,
find flow, execute. Previously, only the first NET_BUFFER of a NET_BUFFER_LIST
was going through this pipeline, which was erroneous.
OvsPartialCopyToMultipleNBLs is used to make each NET_BUFFER have its own
NET_BUFFER_LIST
Yes, I see, my bad. MAXIMUM_MONITORS instead of MAX_MONTIORS.
Looks good.
Thanks,
Eitan
-Original Message-
From: Ben Pfaff [mailto:b...@nicira.com]
Sent: Tuesday, September 09, 2014 3:51 PM
To: Eitan Eliahu
Cc: Gurucharan Shetty; dev@openvswitch.org; Gurucharan Shetty
Subject: Re: [ovs-d
With this commit, ovs by default will try creating 'number of
dpdk interfaces on numa node' pmd threads for each numa node
and pin the pmd threads to available cpu cores on the numa node.
NON_PMD_CORE_ID (currently 0) is used to reserve a particular
cpu core for the I/O of all non-pmd threads. No
Previous commit makes OVS create one tx queue for each cpu
core. An upcoming patch will allow multiple pmd threads be
created and pinned to cpu cores. So each pmd thread will use
the tx queue corresponding to its core id.
Moreover, the pmd threads running on different numa node than
the dpdk int
The previous commit makes OVS create one tx queue for each
cpu core, each pmd thread will use a separate tx queue.
Also, tx of non-pmd threads on dpdk interface is all through
'NON_PMD_THREAD_TX_QUEUE', protected by the 'nonpmd_mempool_mutex'.
Therefore, the spinlock is no longer needed. And this
Before this commit, ovs creates one tx and one rx queue for
each dpdk interface and uses only one poll thread for handling
I/O of all dpdk interfaces. An upcoming patch will allow multiple
poll threads be created. As a preparation, this commit changes
the default to create multiple tx and rx queu
This commit adds new variable n_txq to 'struct netdev' for recording
the number of tx queues. Correspondingly, the send_*() functions are
extended to accept queue id as input argument.
All 'netdev-*' implementation will ignore the queue id since having
multiple tx queues is not supported. Upcomp
This commit adds a new API to the 'struct netdev_class' which
allows user to query the numa node id the 'netdev' is on.
Currently, only netdev-dpdk module implements this function.
Signed-off-by: Alex Wang
---
PATCH -> V2
- rebase and refactor the code.
V2 -> V3:
- rebase.
---
lib/netdev-bsd.
The upstream modules uses this_cpu_xxx APIs. Add those functions for
older kernel (<3.0.0) that does not provide them.
VMware-BZ: #1319082
Signed-off-by: Andy Zhou
---
datapath/linux/compat/include/asm/percpu.h | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git
On Mon, Sep 8, 2014 at 8:53 PM, Joe Stringer wrote:
> Was there a particular tool or config flag that you used to detect this
> error / generate this output?
>
I compile kernel with debugging options. CONFIG_PROVE_LOCKING detects
most of deadlocks in kernel, you do not need any other tool.
> On 8
Daniele,
I just posted rebased versions of two patches on which I worked earlier in a
similar area as there two patches:
[PATCH 1/2] lib/flow: Add ‘miniflow.count’
[PATCH 2/2] lib/flow: Maintain miniflow values as 64-bit aligned.
I’d like to see if we could generalize the inlining benefits, e.g
Samuel and I discussed about this patch over IRC, and we agreed that it is best
to split the patch into two:
1. Fix for handling NBL with mutiple NBs. Any refactoring of
OvsStartNBLIngress() can be done as part of this patch.
2. Updating the parsing, packet io and actions code to handle NBs inste
Make miniflow values 64-bit aligned, both in the starting address and
in length. This allows for 64-bit operations in some functions, such
as miniflow_hash().
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c|2 +-
lib/dpif-netdev.c |7 ---
lib/flow.c |
This reduces the need to keep counting the bits in the map.
Signed-off-by: Jarno Rajahalme
---
lib/classifier.c | 11 ---
lib/dpif-netdev.c | 11 +++
lib/flow.c| 36 ++--
lib/flow.h| 29 +
4 file
OVS has had a MAX_MONITORS macro definition there forever. On
Windows, the name conflicts with something defined in a system header.
Therefore, Guru's patch renames the OVS macro to avoid a conflict.
On Tue, Sep 09, 2014 at 10:47:20PM +, Eitan Eliahu wrote:
> I realize that that we get a comp
I realize that that we get a compilation error but this definition in the
ddeml.h has different semantics (and it is set to 4 rather to 8).
Perhaps you want to undefined it and have your own definition instead.
Thanks,
Eitan
-Original Message-
From: Gurucharan Shetty [mailto:shet...@nicir
On 9/9/14, 3:40 PM, "Ben Pfaff" wrote:
>On Tue, Sep 09, 2014 at 03:17:00PM -0700, Daniele Di Proietto wrote:
>> Signed-off-by: Daniele Di Proietto
>> ---
>> I didn't test the fix. If it works "netdev-dpdk.o" should appear in the
>>travis
>> output (on master it doesn't)
>
>I think that it corr
On Tue, Sep 09, 2014 at 03:17:00PM -0700, Daniele Di Proietto wrote:
> Signed-off-by: Daniele Di Proietto
> ---
> I didn't test the fix. If it works "netdev-dpdk.o" should appear in the travis
> output (on master it doesn't)
I think that it corrects the build, but the build fails because DPDK
isn
Signed-off-by: Daniele Di Proietto
---
I didn't test the fix. If it works "netdev-dpdk.o" should appear in the travis
output (on master it doesn't)
Thanks,
Daniele
---
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.travis.yml b/.travis.yml
index fd21e30..b66f82
On Tue, Sep 9, 2014 at 3:20 PM, Eitan Eliahu wrote:
>
> Hi Guru,
> The Windows definition refers to "DDE" monitors. I'm not sure you want to use
> this semantics here.
ddeml.h gets included indirectly in our builds (likely through
windows.h?). ddeml.h already has a
MAX_MONITORS defined. This resu
Hi Guru,
The Windows definition refers to "DDE" monitors. I'm not sure you want to use
this semantics here.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Gurucharan Shetty
Sent: Tuesday, September 09, 2014 1:23 PM
To: dev@openvswitch.org
C
Thank you for the review!
I did the proposed/agreed upon clarifications and pushed this to master.
Jarno
On Sep 9, 2014, at 1:14 PM, Ben Pfaff wrote:
> On Tue, Sep 09, 2014 at 01:11:25PM -0700, Jarno Rajahalme wrote:
>>
>> On Sep 8, 2014, at 5:06 PM, Ben Pfaff wrote:
>>
>>> On Fri, Sep 05
Applied,
Jarno
On Sep 9, 2014, at 11:29 AM, Ben Pfaff wrote:
> On Fri, Sep 05, 2014 at 04:05:14PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>> Reviewed-by: YAMAMOTO Takashi
>> Acked-by: Ben Pfaff
>> ---
>> v5: rebase, no other changes.
>
> Still looks good.
I’ll try to make a habit of compiling with C=1 before posting…
Thanks for the review, fixed and pushed,
Jarno
On Sep 9, 2014, at 12:32 PM, Ben Pfaff wrote:
> On Fri, Sep 05, 2014 at 04:05:15PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>> ---
>> v5: Using pattern with l
Linux has an internal queue that temporarily holds packets transmitted to
certain network devices. If too many packets are transmitted to such
network devices within a single list of actions, then packets tend to get
dropped. Broadcast or flooded or multicast packets on bridges with
thousands of
Pushed to master,
Jarno
On Sep 9, 2014, at 12:48 PM, Ben Pfaff wrote:
> On Fri, Sep 05, 2014 at 04:05:17PM -0700, Jarno Rajahalme wrote:
>> Signed-off-by: Jarno Rajahalme
>
> Brilliant!
>
> Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswit
Pushed to master,
Jarno
On Sep 9, 2014, at 12:45 PM, Ben Pfaff wrote:
> On Fri, Sep 05, 2014 at 04:05:16PM -0700, Jarno Rajahalme wrote:
>> The frag member in the Netlink interface is an uint8_t enumeration
>> type, not a bitrfield, so it should always be either fully masked or
>> not masked
Thanks,
Daniele
On 9/9/14, 2:22 PM, "Jarno Rajahalme" wrote:
>Pushed to master,
>
> Jarno
>
>On Sep 9, 2014, at 2:15 PM, Jarno Rajahalme wrote:
>
>> Acked-by: Jarno Rajahalme
>>
>> On Sep 9, 2014, at 1:32 PM, Daniele Di Proietto
>> wrote:
>>
>>> When building with DPDK support, 'struct dpi
Pushed to master,
Jarno
On Sep 9, 2014, at 2:15 PM, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> On Sep 9, 2014, at 1:32 PM, Daniele Di Proietto
> wrote:
>
>> When building with DPDK support, 'struct dpif_packet' won't have 'dp_hash'
>> member. dpif_packet_set_dp_hash() and dpi
Windows already has a MAX_MONITORS defined in ddeml.h.
Signed-off-by: Gurucharan Shetty
---
lib/rconn.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/rconn.c b/lib/rconn.c
index c9b68bb..5c28806 100644
--- a/lib/rconn.c
+++ b/lib/rconn.c
@@ -137,8 +137,8 @@ struc
Acked-by: Jarno Rajahalme
On Sep 9, 2014, at 1:32 PM, Daniele Di Proietto wrote:
> When building with DPDK support, 'struct dpif_packet' won't have 'dp_hash'
> member. dpif_packet_set_dp_hash() and dpif_packet_get_dp_hash() should be
> used.
>
> Furthermore, the masked set action shouldn't re
On Mon, Sep 08, 2014 at 02:54:13PM +0100, Thomas Graf wrote:
> On 09/03/14 at 11:24am, Jiri Pirko wrote:
> > This patchset can be divided into 3 main sections:
> > - introduce switchdev api for implementing switch drivers
> > - add hardware acceleration bits into openvswitch datapath, This uses
> >
On Tue, Sep 9, 2014 at 1:50 PM, Nithin Raju wrote:
> 'sock' is not initialized and hence should not be un-initialized
> as well in the failure path.
>
> Signed-off-by: Nithin Raju
Thanks, applied!
> Reported-by: Gurucharan Shetty
> ---
> lib/netlink-socket.c |2 --
> 1 files changed, 0 inse
'sock' is not initialized and hence should not be un-initialized
as well in the failure path.
Signed-off-by: Nithin Raju
Reported-by: Gurucharan Shetty
---
lib/netlink-socket.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
When building with DPDK support, 'struct dpif_packet' won't have 'dp_hash'
member. dpif_packet_set_dp_hash() and dpif_packet_get_dp_hash() should be used.
Furthermore, the masked set action shouldn't read 'md->dp_hash' (which is
shared in a batch), but should use dpif_packet_get_dp_hash() to get e
As mentioned in the comment above the function ovs_strerror(), it
should not be used to convert WINAPI error numbers to string.
Use ovs_lasterror_to_string() instead.
CC: Alin Gabriel Serdean
CC: Eitan Eliahu
Signed-off-by: Gurucharan Shetty
---
lib/netlink-socket.c |6 ++
1 file chan
On Tue, Jul 29, 2014 at 8:23 AM, Alin Serdean
wrote:
> Add two functions set_sock_pid_in_kernel and portid_next. This will allow
> the channel identification for the kernel extension to send back messages.
>
> Replace send with WriteFile equivalent and ignore nl_sock_drain for the moment
> under M
There would be one issue from me:
there was an email - reply to a vport patch time ago, where hyper-v switch
ports were separated from ovs / datapath ports.
The discussion had remained pending, but it might be important if we plan
netlink commands vport new and vport delete for the near future.
On Sep 9, 2014, at 1:09 PM, Gurucharan Shetty
wrote:
> Gives an "uninitialized local variable 'sock' used". Can you take care
> of it in an upcoming patch?
Sure. Thanks for point this out.
-- Nithin
___
dev mailing list
dev@openvswitch.org
http://ope
On Tue, Sep 09, 2014 at 01:14:31PM -0700, Nithin Raju wrote:
> Per review comment, in this patch we refactor the code to create a
> OvsSetupDumpStart() which can be leveraged by dump functions in the
> future. I have not refactored the code that continues the dump
> operation primarily since it is
Per review comment, in this patch we refactor the code to create a
OvsSetupDumpStart() which can be leveraged by dump functions in the
future. I have not refactored the code that continues the dump
operation primarily since it is not final yet. Once the netlink set
APIs are in place, we can refacto
On Tue, Sep 09, 2014 at 01:11:25PM -0700, Jarno Rajahalme wrote:
>
> On Sep 8, 2014, at 5:06 PM, Ben Pfaff wrote:
>
> > On Fri, Sep 05, 2014 at 04:05:13PM -0700, Jarno Rajahalme wrote:
> >> When a whole field of a key value is ignored, skip it when formatting
> >> the key, and allow it to be lef
Acked-by: Samuel Ghinet
From: Alin Serdean
Sent: Tuesday, September 09, 2014 8:43 PM
To: Nithin Raju; dev@openvswitch.org; Samuel Ghinet
Subject: RE: [ovs-dev] [PATCH v2] datapath-windows: update CodingStyle
guidelinefor variable names
Acked-by: A
On Fri, Aug 22, 2014 at 1:16 AM, Nithin Raju wrote:
> In this patch, we add support for querying the genl family id for any
> family supported by the OVS kernel datapath. On platforms that support
> netlink natively, the operating system assigns a family ID, and the
> OS netlink infrastructure sup
On Sep 8, 2014, at 5:06 PM, Ben Pfaff wrote:
> On Fri, Sep 05, 2014 at 04:05:13PM -0700, Jarno Rajahalme wrote:
>> When a whole field of a key value is ignored, skip it when formatting
>> the key, and allow it to be left out when parsing the key from a
>> string. However, when the unmasked bits
Thanks Saurabh for clarifications,
@ Saurabh and Nithin: so you want me to re-make the patches so that #1 would be
refactor and #2 would be the bug fix? or for this one time we can go with #1
and #2 merged together?
> There's some reference to this convention as follows.
> datapath-windows/Cod
Il giorno 09/set/2014, alle ore 20:07, Jarno Rajahalme
ha scritto:
>
> On Sep 9, 2014, at 3:53 AM, Daniele Venturino
> wrote:
>
>>
>> Thanks for the review!
>> It would be nice to have an Acked-by from you to the series. However, I plan
>> to squash trivial CodingStyle fixes in before pus
I'd appreciate it if you'd resend separately, with Samuel's ack
included.
Thanks,
Ben.
On Tue, Sep 09, 2014 at 07:43:17PM +, Nithin Raju wrote:
> Ben,
> This patch is good to go as well AS AN independent patch. It was marked
> earlier as [PATCH 9/9 v3], but it has since been broken off from
On Fri, Sep 05, 2014 at 04:05:18PM -0700, Jarno Rajahalme wrote:
> Masked set action allows more megaflow wildcarding. Masked set action
> is now supported for all writeable key types, except for the tunnel
> key.
>
> The set tunnel action is an exception as any input tunnel info is
> cleared bef
Should be the same as other IPv6 address fields.
Forthcoming patches produce sparse warnings without this change.
Signed-off-by: Jarno Rajahalme
---
datapath/linux/compat/include/linux/openvswitch.h |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/datapath/linux/comp
On Fri, Sep 05, 2014 at 04:05:17PM -0700, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
Brilliant!
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Sep 8, 2014, at 5:06 PM, Ben Pfaff wrote:
> "sparse" says:
>
>../lib/odp-util.c:2379:9: warning: incorrect type in argument 2 (different
> base types)
>../lib/odp-util.c:2379:9:expected restricted ovs_be32 [usertype] (
> *key )[4]
>../lib/odp-util.c:2379:9:got unsigned
On Fri, Sep 05, 2014 at 04:05:16PM -0700, Jarno Rajahalme wrote:
> The frag member in the Netlink interface is an uint8_t enumeration
> type, not a bitrfield, so it should always be either fully masked or
> not masked at all.
>
> Signed-off-by: Jarno Rajahalme
The change to ovs_to_odp_frag_mask(
Ben,
This patch is good to go as well AS AN independent patch. It was marked earlier
as [PATCH 9/9 v3], but it has since been broken off from the series, since
Ankur sent out a new series, which have been committed.
Pls. let me know if you want me to send out a fresh patch for this.
thanks,
Nit
On Mon, Sep 08, 2014 at 08:08:12PM -0700, Eitan Eliahu wrote:
> We keep an outstanding, out of band, I/O request in the driver at all time.
> Once an event generated the driver queues the event message, completes the
> pending I/O and unblocks the calling thread through setting the event in the
> o
On Fri, Sep 05, 2014 at 04:05:15PM -0700, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
> ---
> v5: Using pattern with less code duplication suggested by Ben.
odp_mask_is_exact() treats the unused bits in tun_mask->flags
differently from the unused bits in ipv6_mask->ipv6_label. I gues
hi Guys,
Sorry for all the confusion generated from sending out separate patches for the
review comments. The reasons were the following:
1. I wanted to address all the review comments in the limited time I had, and
unblock others.
2. I thought it would be easier to see that the review comments w
Series pushed to master, thank you for your contribution!
Jarno
On Sep 9, 2014, at 3:39 AM, Daniele Venturino
wrote:
> Acked-by: Daniele Venturino
>
> 2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Finding a given port is faster.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-common
Thanks for the fix, Jarno
Acked-by: Daniele Di Proietto
On 9/9/14, 8:20 AM, "Jarno Rajahalme" wrote:
>Here¹s the updated description:
>
>lib/dpif-netdev: Make emc_mutex recursive.
>
>dpif_netdev_execute may be called while doing upcall processing.
>Since the context of the inpu
On Fri, Sep 05, 2014 at 04:05:14PM -0700, Jarno Rajahalme wrote:
> Signed-off-by: Jarno Rajahalme
> Reviewed-by: YAMAMOTO Takashi
> Acked-by: Ben Pfaff
> ---
> v5: rebase, no other changes.
Still looks good.
___
dev mailing list
dev@openvswitch.org
ht
Hi, here are some items we would like to follow up on. Please feel free to add
anything you would like to discuss.
Outstanding review status
[1] NET_BUFFER_LIST to NET_BUFFER (Sam, Alin)
[2] Asynchronous Event user mode (Eitan)
[3] dpif_linux.c (Alin)
[4] Port Dump (Sam, Ali
On current master, the per-thread callback event set is flushed
when ovsrcu_quiesce_start() is called or when the callback
event set is full. For threads that only call 'ovsrcu_quiesce()'
to indicate quiescient state, their callback event set will not
be flushed for execution until the set is full
On Sep 9, 2014, at 3:53 AM, Daniele Venturino
wrote:
>
> Thanks for the review!
> It would be nice to have an Acked-by from you to the series. However, I plan
> to squash trivial CodingStyle fixes in before pushing the series to master.
> Also, I’ll add a News item stating that experimental
Acked-by: Alin Gabriel Serdean
-Mesaj original-
De la: dev [mailto:dev-boun...@openvswitch.org] În numele Nithin Raju
Trimis: Tuesday, September 9, 2014 9:03 AM
Către: dev@openvswitch.org; Samuel Ghinet
Subiect: [ovs-dev] [PATCH v2] datapath-windows: update CodingStyle guideline
for vari
On Mon, Sep 08, 2014 at 05:06:05PM -0700, Ben Pfaff wrote:
> On Fri, Sep 05, 2014 at 04:05:13PM -0700, Jarno Rajahalme wrote:
> > When a whole field of a key value is ignored, skip it when formatting
> > the key, and allow it to be left out when parsing the key from a
> > string. However, when the
On Tue, Sep 9, 2014 at 8:04 AM, Gurucharan Shetty
wrote:
> I see that there is a bug. With your patch, would we still hit the bug
> if the port name has a "--" in it?
>
Definitely. Although I'm guessing that the probability of "--" being in the
port name is negligible. I can make it more unique
On Aug 29, 2014, at 1:20 PM, Saurabh Shah wrote:
>> Generally, we have not used '_' prefix for function parameter names. We
>> use them for macros etc, but not for functions. Do you prefer it this way? I
>> am not against it, but I don't think it is necessary. For a macro, it is
>> necessary
>>
During a review, it seemed that some of the conventions were not clear.
Fixing them in this patch.
Signed-off-by: Nithin Raju
Reported-by: Samuel Ghinet
---
datapath-windows/CodingStyle | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/Coding
During a review, it seemed that some of the conventions were not clear.
Fixing them in this patch.
Signed-off-by: Nithin Raju
---
datapath-windows/CodingStyle | 13 +
1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/datapath-windows/CodingStyle b/datapath-windows/Cod
hi Sam,
Pls. find my answers inlined. Pls. feel free to repost the patches for the two
different functionalities.
On Sep 6, 2014, at 2:39 PM, Samuel Ghinet
wrote:
> Yes, you were right with the TSO. I'll send a new version of the patch,
> though I am not sure how it would be easier for you to
Here’s the updated description:
lib/dpif-netdev: Make emc_mutex recursive.
dpif_netdev_execute may be called while doing upcall processing.
Since the context of the input port is not tracked upto this point, we
use the shared dp->emc_cache for packet execution, where the emc_c
On Mon, Sep 8, 2014 at 9:08 PM, Mark Maglana wrote:
> Modify patch port name separators to use "--" instead of "-" so that
> ovs-vtep plays nice with external tools such as Mininet which uses
> dashes in port names. Without this change, ovs-vtep will throw a
> ValueError exception and die soon aft
On Tue, Sep 09, 2014 at 05:15:06PM +0530, Saloni Jain wrote:
> 1. If eviction on the switch is set on the basis of "lifetime" by
> create table command and then the command for "importance" (mod-table
> command) is given then what will be the basis of eviction in this
> case. Will in this case, evi
Thank You Ben for your inputs !!
Please suggest for the following as well:
1. If eviction on the switch is set on the basis of "lifetime" by create
table command and then the command for "importance" (mod-table command) is
given then what will be the basis of eviction in this case. Will in
>
>
> Thanks for the review!
> It would be nice to have an Acked-by from you to the series. However, I
> plan to squash trivial CodingStyle fixes in before pushing the series to
> master. Also, I’ll add a News item stating that experimental RSTP is added,
> and more compliance and interoperability
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Finding a given port is faster.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-common.h |5 +++--
> lib/rstp-state-machines.c | 30 +++---
> lib/rstp.c| 35 +++
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> It was only used to guard against unintialized list.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-common.h |1 -
> lib/rstp-state-machines.c | 273
> -
> li
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Testing for sameness first makes the logic simpler to follow.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-state-machines.c | 57
> +++--
> 1 file changed, 24 insertions(+
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-state-machines.c | 398
> +
> 1 file changed, 182 insertions(+), 216 deletions(-)
>
> diff --git a/lib/rstp-state-machines.c b/
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Change the RSTP send_bpdu interface so that a recursive mutex is not
> needed.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-common.h |2 +-
> lib/rstp-state-machines.c |2 +-
> lib/rstp.c
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Current code expects there to be a single thread that is responsible
> for creating rstp and creating and deleting rstp_port objects. rstp
> objects are also deleted from other threads, as managed by reference
> counting.
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp.c | 34 --
> lib/rstp.h | 42 +++---
> 2 files changed, 39 insertions(+), 37 deletions(-)
>
> diff -
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp.c | 39 ++-
> ofproto/ofproto-dpif.c |2 +-
> 2 files changed, 27 insertions(+), 14 deletions(-)
>
> diff --git a/lib/
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp.c | 54 ++
> 1 file changed, 22 insertions(+), 32 deletions(-)
>
> diff --git a/lib/rstp.c b/lib/rstp.c
> index 17830d
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Prior to this patch the default values for ports were set in three
> different places. This refactors them all to one helper function.
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp.c | 105
> +
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Port number allocation was O(N^3), this refactoring will make it O(N^2).
>
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp.c | 48 +---
> 1 file changed, 17 insertions(+),
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp.c | 132
> ++--
> lib/rstp.h | 12 +++---
> 2 files changed, 81 insertions(+), 63 deletions(-)
>
> diff --git a/l
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-common.h |7 ---
> 1 file changed, 7 deletions(-)
>
> diff --git a/lib/rstp-common.h b/lib/rstp-common.h
> index 6bc04eb..a67115b 100644
> --- a/lib/rstp-common.h
>
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Move port's configuration options where they belong, add typing, and
> correct errors.
>
> Signed-off-by: Jarno Rajahalme
> ---
> vswitchd/vswitch.xml | 130
> ++
> 1 file
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Set the stp port name before enabling it, so that debugging messages
> have the name to print out.
>
> Do not treat the first state initialization as a state change. Zero
> is not a valid state, so changing from zero to S
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Signed-off-by: Jarno Rajahalme
> ---
> lib/rstp-state-machines.c | 22 --
> ofproto/ofproto-dpif.c| 11 ++-
> vswitchd/bridge.c | 10 +-
> 3 files changed, 23 inserti
Acked-by: Daniele Venturino
2014-08-21 1:57 GMT+02:00 Jarno Rajahalme :
> Existing STP and RSTP test cases only test the protocols with test
> utilities. These tests test them as part of OVS using the
> netdev-dummy device.
>
> Signed-off-by: Jarno Rajahalme
> ---
> ofproto/ofproto-dpif.c |
93 matches
Mail list logo
