[ovs-dev] [PATCH v2] docs: directly convert dot diagrams into eps for generating PDF

2015-01-30 Thread Shu Shen
The previous workflow is to convert dot diagrams into .pic format and embed into manpages; double borders and arrows were not used in dot but introduced in .pic conversion; edge routing in .pic was also worse than dot. The updated workflow specifies directly in dot diagram double boarders for "roo

Re: [ovs-dev] [PATCH] docs: directly convert dot diagrams into eps for generating PDF

2015-01-30 Thread Shu Shen
> This does seem like an improvement in many ways. > > Now, however, the manpage-check target fails for me with: > > vswitchd/vswitch.eps:81: warning: can't find special character `' > vtep/vtep.eps:81: warning: can't find special character `' > Makefile:4634: recipe for target 'manpa

Re: [ovs-dev] [PATCH V3] ovs-command-completion: Autotest integration.

2015-01-30 Thread Alex Wang
Thx for the review, so excited to get this in, Pushed to master, Thanks, Alex Wang, On Fri, Jan 30, 2015 at 1:52 PM, Ben Pfaff wrote: > On Tue, Jan 13, 2015 at 05:03:53PM -0800, Alex Wang wrote: > > This commit integrates the unit tests defined in > > utilities/ovs-command-compgen-test.bash in

Re: [ovs-dev] [PATCH V2] ovs-vsctl.at: Fix intermittent failure.

2015-01-30 Thread Alex Wang
Thx for the review, applied to master and branch-2.3, On Fri, Jan 30, 2015 at 1:28 PM, Ben Pfaff wrote: > On Fri, Jan 30, 2015 at 01:27:03PM -0800, Alex Wang wrote: > > This commit fixes the intermittent test failure caused by the > > race between the test thread and logging thread. > > > > Sign

[ovs-dev] [PATCH] ofp-util: Issue error when OFPGC_DELETE command includes buckets.

2015-01-30 Thread Ben Pfaff
An OFPGC_DELETE command deletes a whole group, including all of its buckets, and so it doesn't make sense for the command itself to include any specification of buckets. ONF-JIRA: EXT-510 Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 15 +-- 1 file changed, 13 insertions(+), 2 deleti

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-01-30 Thread Ben Pfaff
On Fri, Jan 16, 2015 at 06:04:35PM +0530, Rishi Bamba wrote: > From: Saloni Jain > > This commit enables the eviction mechanism on the basis of importance as > per the openflow specification 1.4. > > ovs-ofctl -O OpenFlow14 mod-table evict > -Enable eviction on of . Eviction adds a mech

Re: [ovs-dev] [PATCH V3] ovs-command-completion: Autotest integration.

2015-01-30 Thread Ben Pfaff
On Tue, Jan 13, 2015 at 05:03:53PM -0800, Alex Wang wrote: > This commit integrates the unit tests defined in > utilities/ovs-command-compgen-test.bash into 'make check'. > The tests will be skipped if the current shell is not bash. > > Signed-off-by: Alex Wang > > --- > V2->V3 > - use $BASH_VER

Re: [ovs-dev] [PATCH] docs: directly convert dot diagrams into eps for generating PDF

2015-01-30 Thread Ben Pfaff
On Tue, Jan 27, 2015 at 01:30:08PM -0800, Shu Shen wrote: > The previous workflow is to convert dot diagrams into .pic format and > embed into manpages; double borders and arrows were not used in dot but > introduced in .pic conversion; edge routing in .pic were also worse than > dot. > > The upda

Re: [ovs-dev] [PATCH] ovs-dpctl: Mention use of ovs-appctl instead for netdev datapath.

2015-01-30 Thread Ben Pfaff
On Fri, Jan 30, 2015 at 01:10:20PM -0800, Gurucharan Shetty wrote: > On Fri, Jan 30, 2015 at 12:59 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > utilities/ovs-dpctl.8.in | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/utilities/ovs-dpctl.8.in b/utilities/ovs

[ovs-dev] [PATCH] ofproto-dpif: Revalidate when sFlow probability changes.

2015-01-30 Thread Ben Pfaff
Until now, when the sFlow selection probability changed, OVS failed to immediately revalidate the flow table, delaying the new probability taking effect. This commit fixes the problem. Reported-by: K 華 Signed-off-by: Ben Pfaff --- AUTHORS| 1 + ofproto/ofproto-dpif.c | 5 -

Re: [ovs-dev] [PATCH V2] ovs-vsctl.at: Fix intermittent failure.

2015-01-30 Thread Ben Pfaff
On Fri, Jan 30, 2015 at 01:27:03PM -0800, Alex Wang wrote: > This commit fixes the intermittent test failure caused by the > race between the test thread and logging thread. > > Signed-off-by: Alex Wang > > --- > PATCH->v2: > - fix incorrect use of autotest macro. Acked-by: Ben Pfaff _

Re: [ovs-dev] [PATCH v2] datapath-windows: Solved BSOD when loading an activated extension

2015-01-30 Thread Ben Pfaff
On Mon, Jan 26, 2015 at 07:00:40PM +, Sorin Vinturis wrote: > If the OVS extension was previously enabled and the driver unloaded, > when the driver is loaded again a BSOD is triggered. > > This happens because the OVS extension registers its FilterXxx routines > to NDIS, by calling NdisFRegis

[ovs-dev] [PATCH] ovs-bugtool: Improve manpage.

2015-01-30 Thread Ben Pfaff
The manpage was poorly organized and failed to mention some options. --- utilities/bugtool/ovs-bugtool.8.in | 58 -- 1 file changed, 37 insertions(+), 21 deletions(-) diff --git a/utilities/bugtool/ovs-bugtool.8.in b/utilities/bugtool/ovs-bugtool.8.in index 6f

[ovs-dev] [PATCH V2] ovs-vsctl.at: Fix intermittent failure.

2015-01-30 Thread Alex Wang
This commit fixes the intermittent test failure caused by the race between the test thread and logging thread. Signed-off-by: Alex Wang --- PATCH->v2: - fix incorrect use of autotest macro. --- tests/ovs-vsctl.at |4 1 file changed, 4 insertions(+) diff --git a/tests/ovs-vsctl.at b/te

Re: [ovs-dev] [PATCH] ovs-bugtool: Add --help message.

2015-01-30 Thread Ben Pfaff
Thanks for the review. I fixed that and applied this to master with your ack. On Fri, Jan 23, 2015 at 07:06:12PM -0800, Alex Wang wrote: > Thx for fixing this, > > --output-fd=FD is not valid option, do you mean --outfile and --outfd ? > > > Otherwise, looks good~ > > Acked-by: Alex Wang >

Re: [ovs-dev] [PATCH] ovs-dpctl: Mention use of ovs-appctl instead for netdev datapath.

2015-01-30 Thread Gurucharan Shetty
On Fri, Jan 30, 2015 at 12:59 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > utilities/ovs-dpctl.8.in | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/utilities/ovs-dpctl.8.in b/utilities/ovs-dpctl.8.in > index 84407f0..b67c952 100644 > --- a/utilities/ovs-dpctl.8.in > ++

[ovs-dev] Bug#763428: test with kernel 3.18.4

2015-01-30 Thread Ben Pfaff
Did you mean to reassign this bug to linux-image-3.16-0-4-amd64? To do so, you must CC cont...@bugs.debian.org and put the command at the top of the email, not the bottom. On Wed, Jan 28, 2015 at 06:20:09PM +0100, Mehdi Abaakouk wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > H

Re: [ovs-dev] [PATCH] ovs-vsctl.at: Fix intermittent failure.

2015-01-30 Thread Alex Wang
Thx for spotting it, i did not copy the entire example and missed the 'test', This failure is very hard to reproduce on my setup, so it passed 30 runs, I'll fix it and repost, Thanks, Alex Wang, On Fri, Jan 30, 2015 at 12:38 PM, Ben Pfaff wrote: > On Fri, Jan 30, 2015 at 10:51:49AM -0800, Ale

[ovs-dev] [PATCH] ovs-dpctl: Mention use of ovs-appctl instead for netdev datapath.

2015-01-30 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- utilities/ovs-dpctl.8.in | 7 +++ 1 file changed, 7 insertions(+) diff --git a/utilities/ovs-dpctl.8.in b/utilities/ovs-dpctl.8.in index 84407f0..b67c952 100644 --- a/utilities/ovs-dpctl.8.in +++ b/utilities/ovs-dpctl.8.in @@ -18,6 +18,13 @@ ovs\-dpctl \- adminis

Re: [ovs-dev] [PATCH] ovs-vsctl.at: Fix intermittent failure.

2015-01-30 Thread Ben Pfaff
On Fri, Jan 30, 2015 at 10:51:49AM -0800, Alex Wang wrote: > This commit fixes the intermittent test failure caused by the > race between the test thread and logging thread. > > Signed-off-by: Alex Wang OVS_WAIT_WHILE doesn't have an implied invocation of "test", so I'm surprised that this helps

Re: [ovs-dev] OVS and (un)locking mechanism

2015-01-30 Thread Ben Pfaff
On Fri, Jan 30, 2015 at 07:47:03AM +0100, Tomáš Čejka wrote: > I would like to discuss a topic related to locks and locking of OVS > configuration and usability of such locks to prevent clients from data > modification. > > As you probably know, NETCONF as well as OF-CONFIG specifies the and > o

Re: [ovs-dev] OVS - issue related to OF-CONFIG build

2015-01-30 Thread Ben Pfaff
That sounds like a good way to go for now. As the OVS API and ABI stabilizes sufficiently, it will no longer be necessary, but it's going to take a while. On Fri, Jan 30, 2015 at 07:53:47AM +0100, Tomáš Čejka wrote: > Hello Ben, > thank you for the answer. According to your advice, we have added

[ovs-dev] [PATCH] ovs-vsctl.at: Fix intermittent failure.

2015-01-30 Thread Alex Wang
This commit fixes the intermittent test failure caused by the race between the test thread and logging thread. Signed-off-by: Alex Wang --- tests/ovs-vsctl.at |6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/ovs-vsctl.at b/tests/ovs-vsctl.at index f6e6994..433b964 100644 --- a/

[ovs-dev] [PATCH 11/13] datapath: Allow building against 3.19.x

2015-01-30 Thread Thomas Graf
Signed-off-by: Thomas Graf --- FAQ.md | 1 + NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/FAQ.md b/FAQ.md index 02fe2d3..2de4936 100644 --- a/FAQ.md +++ b/FAQ.md @@ -147,6 +147,7 @@ A: The following table lists the Linux kernel v

[ovs-dev] [PATCH 13/13] ofproto: Add NXM_NX_TUN_GBP_ID and NXM_NX_TUN_GBP_FLAGS

2015-01-30 Thread Thomas Graf
From: Madhu Challa Introduces two new NXMs to represent VXLAN-GBP [0] fields. actions=load:0x10->NXM_NX_TUN_GBP_ID[],NORMAL tun_gbp_id=0x10,actions=drop This enables existing VXLAN tunnels to carry security label information such as a SELinux context to other network peers. The values are

[ovs-dev] [PATCH 12/13] tunnel: Provide framework for tunnel extensions for VXLAN-GBP and others

2015-01-30 Thread Thomas Graf
Supports a new "exts" field in the tunnel configuration which takes a comma separated list of enabled extensions. The only extension supported so far is GBP but this can be used to enable RCO and possibly others as soon as the OVS datapath supports them. Signed-off-by: Thomas Graf --- lib/dpif-

[ovs-dev] [PATCH 09/13] datapath: Account for "genetlink: pass only network namespace to genl_has_listeners()"

2015-01-30 Thread Thomas Graf
Upstream commit: genetlink: pass only network namespace to genl_has_listeners() There's no point to force the caller to know about the internal genl_sock to use inside struct net, just have them pass the network namespace. This doesn't really change code generation since it's a

[ovs-dev] [PATCH 10/13] datapath: Account for "netlink: make nlmsg_end() and genlmsg_end() void"

2015-01-30 Thread Thomas Graf
genlmsg_end() no longer returns an error value. Not a problem as it never returned an error code anyway. Upstream: 053c09 ("netlink: make nlmsg_end() and genlmsg_end() void") Signed-off-by: Thomas Graf --- datapath/datapath.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff -

[ovs-dev] [PATCH 08/13] datapath: Account for "vxlan: Eliminate dependency on UDP socket in transmit path"

2015-01-30 Thread Thomas Graf
Excludes VXLAN_F_REMCSUM_TX bits as OVS currently doesn't support it. Upstream commit: vxlan: Eliminate dependency on UDP socket in transmit path In the vxlan transmit path there is no need to reference the socket for a tunnel which is needed for the receive side. We do, however,

[ovs-dev] [PATCH 07/13] datapath: Support VXLAN Group Policy extension

2015-01-30 Thread Thomas Graf
Upstream commit: openvswitch: Support VXLAN Group Policy extension Introduces support for the group policy extension to the VXLAN virtual port. The extension is disabled by default and only enabled if the user has provided the respective configuration. ovs-vsctl add-port br0

[ovs-dev] [PATCH 06/13] datapath: Allow for any level of nesting in flow attributes

2015-01-30 Thread Thomas Graf
Upstream commit: openvswitch: Allow for any level of nesting in flow attributes nlattr_set() is currently hardcoded to two levels of nesting. This change introduces struct ovs_len_tbl to define minimal length requirements plus next level nesting tables to traverse the key attribute

[ovs-dev] [PATCH 05/13] datapath: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS()

2015-01-30 Thread Thomas Graf
Backport of upstream commit: openvswitch: Rename GENEVE_TUN_OPTS() to TUN_METADATA_OPTS() Also factors out Geneve validation code into a new separate function validate_and_copy_geneve_opts(). A subsequent patch will introduce VXLAN options. Rename the existing GENEVE_TUN_OPTS

[ovs-dev] [PATCH 03/13] datapath: Account for "vxlan: Group Policy extension"

2015-01-30 Thread Thomas Graf
Upstream commit: vxlan: Group Policy extension Implements supports for the Group Policy VXLAN extension [0] to provide a lightweight and simple security label mechanism across network peers based on VXLAN. The security context and associated metadata is mapped to/from skb->mark

[ovs-dev] [PATCH 00/13 v3] Datapath sync & VXLAN-GBP

2015-01-30 Thread Thomas Graf
v3: - Adressed Pravin's feedback: - Use #ifdef to check for skb_vlan_tag_present instead of autoconf - Include base don USE_KERNEL_TUNNEL_API instead of separate autoconf check - Removed now used HAVE_VXLAN_XMIT_SKB_XNET_ARG check - New patch to account for xnet attribtue in upst

[ovs-dev] [PATCH 04/13] datapath: Account for "vxlan: add x-netns support"

2015-01-30 Thread Thomas Graf
Upstream commit: vxlan: add x-netns support This patch allows to switch the netns when packet is encapsulated or decapsulated. The vxlan socket is openned into the i/o netns, ie into the netns where encapsulated packets are received. The socket lookup is done into this netns t

[ovs-dev] [PATCH 02/13] datapath: Account for now exposed VXLAN definitions

2015-01-30 Thread Thomas Graf
This brings the compat version of vxlan_udp_encap_recv() and vxlan_xmit_skb() in line with upstream commit: commit 3bf3947526c1053ddf2523f261395d682718f56c Author: Tom Herbert Date: Thu Jan 8 12:31:18 2015 -0800 vxlan: Improve support for header flags This patc

[ovs-dev] [PATCH 01/13] datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there"

2015-01-30 Thread Thomas Graf
Upstream commit: net: rename vlan_tx_* helpers since "tx" is misleading there The same macros are used for rx as well. So rename it. Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller Upstream: df8a39d ("net: rename vlan_tx_* helpers since "tx" is misleading there") Sign

Re: [ovs-dev] [PATCH 03/11] datapath: Account for "vxlan: Group Policy extension"

2015-01-30 Thread Thomas Graf
On 01/29/15 at 07:45pm, Pravin Shelar wrote: > > +#ifdef HAVE_VXLAN_METADATA > > static inline int rpl_vxlan_xmit_skb(struct vxlan_sock *vs, > > struct rtable *rt, struct sk_buff *skb, > > __be32 src, __be32 dst, __u8 tos, __u8 ttl, __be16 df, > > -

Re: [ovs-dev] [PATCH 02/11] datapath: Account for now exposed VXLAN definitions

2015-01-30 Thread Thomas Graf
On 01/29/15 at 07:45pm, Pravin Shelar wrote: > > +#ifdef HAVE_NET_VXLAN_H > > #include_next > > +#endif > > + > > I do not see need for HAVE_NET_VXLAN_H. Is current check not working? Nothing wrong. We just don't include in some cases when it is available. I changed it back to USE_KERNEL_TUNNE

Re: [ovs-dev] [PATCH 01/11] datapath: Account for "rename vlan_tx_* helpers since "tx" is misleading there"

2015-01-30 Thread Thomas Graf
On 01/29/15 at 07:44pm, Pravin Shelar wrote: > > +#ifndef HAVE_SKB_VLAN_TAG_PRESENT > > +#define skb_vlan_tag_present(skb) vlan_tx_tag_present(skb) > > +#define skb_vlan_tag_get(skb) vlan_tx_tag_get(skb) > > +#endif > > + > > > No need to search skb_vlan_tag_present(), since it is macro we can us