Re: [ovs-dev] [PATCH 1/2] ovs-sandbox: Show the running program on xterm's title

On Fri, Feb 20, 2015 at 01:22:12PM -0800, Andy Zhou wrote: When debugging multiple programs under GDB, it will be easier to identify xterms with the program name displayed as title. Without this patch, xterms will have the title of gdb, which is the first program the xterm executes. This

Re: [ovs-dev] [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

Hi Ben, Greetings! This is in reference to the patch ovs-ofctl: Implementation of eviction on the basis of Importance which is under review. As per the last inputs received, the revised patch was sent on 11.02.2015 but haven't heard further about the same. Request to kindly provide further

Re: [ovs-dev] [PATCH 2/2] ovs-sandbox: Add -d option to run ovsdb-server under GDB

On Fri, Feb 20, 2015 at 01:22:13PM -0800, Andy Zhou wrote: Signed-off-by: Andy Zhou az...@nicira.com Acked-by: Ben Pfaff b...@nicira.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] FAQ.md: Mention Linux version that first could handle IPFIX flow monitoring.

I think that the critical commit is commit 4490108b4a5ada (openvswitch: Allow OVS_USERSPACE_ATTR_USERDATA to be variable length.), which first appeared in Linux 3.10. Signed-off-by: Ben Pfaff b...@nicira.com --- FAQ.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [ovs-dev] Purchase Order

Good Morning, We trade in different types of quality products/services. We are interested in doing business with your company. Attached is the sample of our products. Kindly re-confirm if you can supply the Products within the next 2-3 weeks. PDF document is secured from public view. Just

Re: [ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

On Fri, Feb 20, 2015 at 02:17:11PM -0500, drfl...@avaya.com wrote: From: Dennis Flynn drfl...@avaya.com This is the final commit in the series of commits that deliver initial support for Auto-Attach. Specifically this commit delivers auto-attach support to the OVS bridge layer as well as the

[ovs-dev] [PATCH 11/32] lldpd-structs: Fix spelling error in message.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd-structs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lldp/lldpd-structs.c b/lib/lldp/lldpd-structs.c index abd251a..33598b4 100644 --- a/lib/lldp/lldpd-structs.c +++ b/lib/lldp/lldpd-structs.c @@ -48,7 +48,7

[ovs-dev] [PATCH 15/32] lldp-structs: Fix use of list of struct lldpd_mgmt.

A list of some type should have type struct ovs_list, not some other type that encapsulates it. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 6 +++--- lib/lldp/lldpd-structs.c | 7 ++- lib/lldp/lldpd-structs.h | 2 +- lib/lldp/lldpd.c | 9 +++--

[ovs-dev] [PATCH 12/32] test-aa: Make variables local to this file static.

Found by sparse. Signed-off-by: Ben Pfaff b...@nicira.com --- tests/test-aa.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/test-aa.c b/tests/test-aa.c index c3f5f3a..58c20c8 100644 --- a/tests/test-aa.c +++ b/tests/test-aa.c @@ -26,14 +26,14 @@ #define

[ovs-dev] [PATCH 17/32] ovs-lldp: Use better types for ISID and VLANs.

An ISID is 24 bits, so it fits in a uint32_t. A VLAN is 12 bits, so it fits in a uint16_t. Use these types consistently, instead of int64_t. This removes a check in aa_mapping_unregister() that seems a little mysterious to me: it previously checked for ISID and VLAN values = 0. I don't see a

[ovs-dev] [PATCH 19/32] lldp: Miscellaneous coding style fixes.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 4 ++-- lib/lldp/lldpd-structs.h | 14 +++--- lib/ovs-lldp.c | 34 +- 3 files changed, 22 insertions(+), 30 deletions(-) diff --git a/lib/lldp/lldp.c b/lib/lldp/lldp.c index

Re: [ovs-dev] [PATCH 3/3] auto-attach: Add auto-attach support to bridge layer and command set

On Sun, Feb 22, 2015 at 11:45:29AM -0800, Ben Pfaff wrote: On Fri, Feb 20, 2015 at 02:17:11PM -0500, drfl...@avaya.com wrote: From: Dennis Flynn drfl...@avaya.com This is the final commit in the series of commits that deliver initial support for Auto-Attach. Specifically this commit

[ovs-dev] [PATCH 32/32] lldp: Fully parenthesize some macro definitions.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.h | 2 +- lib/ovs-lldp.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/lldp/lldpd.h b/lib/lldp/lldpd.h index 7fa0bbc..33504ea 100644 --- a/lib/lldp/lldpd.h +++ b/lib/lldp/lldpd.h @@ -37,7 +37,7 @@

[ovs-dev] [PATCH 29/32] lldpd: Fix use of list of struct lldpd_chassis.

A list of some type should have type struct ovs_list, not some other type that encapsulates it. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.c | 10 +- lib/lldp/lldpd.h | 2 +- lib/ovs-lldp.c | 10 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff

[ovs-dev] [PATCH 03/32] auto-attach: Add auto-attach support to bridge layer and command set

From: Dennis Flynn drfl...@avaya.com This is the final commit in the series of commits that deliver initial support for Auto-Attach. Specifically this commit delivers auto-attach support to the OVS bridge layer as well as the new auto-attach commands. The OVSDB schema is modified to define the

[ovs-dev] [PATCH 04/32] ovs-vsctl: Fix misused casts.

Without the casts, the argument types match the format specifiers. Signed-off-by: Ben Pfaff b...@nicira.com --- utilities/ovs-vsctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utilities/ovs-vsctl.c b/utilities/ovs-vsctl.c index 00e48d5..84fca8a 100644 ---

[ovs-dev] [PATCH 05/32] lldp: Get rid of POKE macros in favor of inline functions.

The POKE macros previously used here don't match the style usually used in OVS and they require the user to know exactly how many bytes to reserve. This commit replaces them by easier-to-use inline functions that take advantage of the ofpbuf interface. Also removes a few PEEK macros that weren't

[ovs-dev] [PATCH 13/32] lldp: Change representation of ISID to uint32_t.

It's a lot more straightforward to deal with integer values as integers instead of arrays of bytes. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/aa-structs.h | 2 +- lib/lldp/lldp.c | 19 +++ lib/ovs-lldp.c| 42 +++---

[ovs-dev] [PATCH 14/32] lldp-structs: Fix use of list of lldpd_aa_isid_vlan_maps_tlv.

A list of some type should have type struct ovs_list, not some other type that encapsulates it. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 11 +-- lib/lldp/lldpd-structs.h | 2 +- lib/ovs-lldp.c | 17 +++-- tests/test-aa.c | 13

[ovs-dev] [PATCH 24/32] lldpd: Fix return value convention for send function.

errno values are positive values, so it's not reasonable to use E2BIG as an error return with positive values also indicating packet lengths. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lldp/lldpd.c

[ovs-dev] [PATCH 25/32] lldp: Remove excessive parentheses.

The OVS style is to usually avoid parentheses in cases like these where they just make expressions harder to read. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 9 +++-- lib/lldp/lldpd.c | 31 +++ 2 files changed, 18 insertions(+), 22

[ovs-dev] Returned mail: Data format error

Dear user dev@openvswitch.org, We have found that your account has been used to send a huge amount of junk email messages during the recent week. Most likely your computer had been compromised and now runs a trojan proxy server. We recommend you to follow our instructions in order to keep your

[ovs-dev] [PATCH 02/32] auto-attach: Add auto-attach support to ofproto layer

From: Dennis Flynn drfl...@avaya.com Signed-off-by: Ludovic Beliveau ludovic.beliv...@windriver.com Signed-off-by: Dennis Flynn drfl...@avaya.com Signed-off-by: Ben Pfaff b...@nicira.com --- lib/bfd.c | 6 ++- lib/bfd.h | 2 +- lib/cfm.c

[ovs-dev] [PATCH 00/32] Auto-Attach series plus refinements

This is Dennis Flynn's auto-attach feature plus a number of refinements. Dennis, will you take a look at it? Thanks, Ben. Ben Pfaff (29): ovs-vsctl: Fix misused casts. lldp: Get rid of POKE macros in favor of inline functions. lldp: Use x*alloc() functions instead of writing them out

[ovs-dev] [PATCH 09/32] lldp: Use bool for boolean variables.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 4 ++-- lib/lldp/lldpd-structs.c | 17 - lib/lldp/lldpd-structs.h | 6 +++--- lib/lldp/lldpd.c | 10 +- 4 files changed, 18 insertions(+), 19 deletions(-) diff --git a/lib/lldp/lldp.c

[ovs-dev] [PATCH 06/32] lldp: Use x*alloc() functions instead of writing them out in-place.

Also use flexible array member instead of array of length 1 in struct lldpd_frame. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 33 + lib/lldp/lldpd-structs.h | 4 ++-- lib/lldp/lldpd.c | 18 +- lib/ovs-lldp.c

[ovs-dev] [PATCH 10/32] lldp: Declare bool variables as type bool.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 10 ++ lib/lldp/lldpd.c | 27 ++- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/lib/lldp/lldp.c b/lib/lldp/lldp.c index b3c8346..7c80296 100644 --- a/lib/lldp/lldp.c +++

[ovs-dev] [PATCH 08/32] lldp: Use OVS time functions.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd-structs.c | 4 ++-- lib/lldp/lldpd.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/lldp/lldpd-structs.c b/lib/lldp/lldpd-structs.c index 7a434ff..bd77c28 100644 --- a/lib/lldp/lldpd-structs.c +++

[ovs-dev] [PATCH 07/32] ovs-lldp: Use correct printf specifiers.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/ovs-lldp.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/ovs-lldp.c b/lib/ovs-lldp.c index f2d966c..9d88213 100644 --- a/lib/ovs-lldp.c +++ b/lib/ovs-lldp.c @@ -307,15 +307,13 @@

[ovs-dev] [PATCH 23/32] lldpd: Remove unused ALIGNED_CAST macro.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/lldp/lldpd.h b/lib/lldp/lldpd.h index f142180..2c00966 100644 --- a/lib/lldp/lldpd.h +++ b/lib/lldp/lldpd.h @@ -61,8 +61,6 @@ struct event_base; struct lldpd_chassis **,

[ovs-dev] [PATCH 30/32] lldpd: Fix use of list of struct lldpd_hardware.

A list of some type should have type struct ovs_list, not some other type that encapsulates it. This ovs_list is a bit puzzling in itself, because it appears to always have exactly one element. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.c | 6 +++--- lib/lldp/lldpd.h | 9

[ovs-dev] [PATCH 21/32] lldpd: Remove obsolete comment.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/lldp/lldpd.c b/lib/lldp/lldpd.c index eb32269..c7b40d2 100644 --- a/lib/lldp/lldpd.c +++ b/lib/lldp/lldpd.c @@ -402,7 +402,6 @@ lldpd_decode(struct lldpd *cfg, char *frame, int s,

[ovs-dev] [PATCH 22/32] lldpd: Use CONTAINER_OF instead of cast, for safety.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/lldp/lldpd.c b/lib/lldp/lldpd.c index c7b40d2..06f8ea0 100644 --- a/lib/lldp/lldpd.c +++ b/lib/lldp/lldpd.c @@ -86,8 +86,8 @@ lldpd_alloc_hardware(struct lldpd

[ovs-dev] [PATCH 20/32] ovs-lldp: Remove unneeded NULL checks on free().

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/ovs-lldp.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/ovs-lldp.c b/lib/ovs-lldp.c index aa52cd9..5deee58 100644 --- a/lib/ovs-lldp.c +++ b/lib/ovs-lldp.c @@ -482,16 +482,12 @@ aa_configure(const struct

[ovs-dev] [PATCH 31/32] lldp: Remove unused definitions from headers.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd-structs.h | 5 - lib/lldp/lldpd.h | 17 - lib/ovs-lldp.h | 8 3 files changed, 30 deletions(-) diff --git a/lib/lldp/lldpd-structs.h b/lib/lldp/lldpd-structs.h index 0763bb3..d62f37c

[ovs-dev] [PATCH 18/32] lldpd-structs: Fix type of c_id member.

This member is typically an Ethernet address so the appropriate type is uint8_t, not char. This eliminates a couple of casts. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldp.c | 2 +- lib/lldp/lldpd-structs.h | 2 +- lib/ovs-lldp.c | 4 ++-- tests/test-aa.c

[ovs-dev] [PATCH 27/32] lldpd: Remove unused members from struct lldpd.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/lib/lldp/lldpd.h b/lib/lldp/lldpd.h index 2c00966..d25bb01 100644 --- a/lib/lldp/lldpd.h +++ b/lib/lldp/lldpd.h @@ -79,17 +79,10 @@ struct protocol { #define SMART_HIDDEN(port)

[ovs-dev] [PATCH 28/32] lldpd-structs: Declare Boolean member as one bit, not two.

Signed-off-by: Ben Pfaff b...@nicira.com --- lib/lldp/lldpd-structs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lldp/lldpd-structs.h b/lib/lldp/lldpd-structs.h index ef7af74..0763bb3 100644 --- a/lib/lldp/lldpd-structs.h +++ b/lib/lldp/lldpd-structs.h @@ -89,7 +89,7

Re: [ovs-dev] [PATCH 1/2] ovs-sandbox: Show the running program on xterm's title

Pushed both patches with the change suggested. Thanks for the review Ben. On Sun, Feb 22, 2015 at 10:59 AM, Ben Pfaff b...@nicira.com wrote: On Fri, Feb 20, 2015 at 01:22:12PM -0800, Andy Zhou wrote: When debugging multiple programs under GDB, it will be easier to identify xterms with the

Re: [ovs-dev] OVN to-do list

Will there be a mechanism to negotiate the Tunnel used? Is a GW between diff tunnels part of the architecture? Thx Uri (“Oo-Ree”) C: 949-378-7568 -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Jesse Gross Sent: Saturday, February 21, 2015 12:18 PM To:

Re: [ovs-dev] OVN to-do list

Initially I expect every OVN hypervisor in a deployment will have to speak all the tunnel protocols used anywhere in that deployment. If this is a significant limitation in practice then we can arrange for something. On Mon, Feb 23, 2015 at 03:05:30AM +, Elzur, Uri wrote: Will there be a