Re: [ovs-dev] [RFC HSA 1/4] ovs_list: Extend list functions.

2015-03-31 Thread Alex Wang
Thx a lot for the suggested changes~, I really did it the hard way! The changes are simple and clean! really like it, Adopt them all, Thanks, Alex Wang, On Mon, Mar 30, 2015 at 9:19 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Mar 30, 2015 at 03:46:26PM -0700, Alex Wang wrote: This commit

[ovs-dev] Test

2015-03-31 Thread The Post Office
The original message was received at Tue, 31 Mar 2015 14:58:37 +0800 from [156.171.138.82] - The following addresses had permanent fatal errors - dev@openvswitch.org - Transcript of session follows - ... while talking to server openvswitch.org.: MAIL From:The Post Office

[ovs-dev] test

2015-03-31 Thread marja
Dear user of openvswitch.org, We have detected that your account was used to send a large amount of spam messages during the recent week. Probably, your computer had been compromised and now contains a trojan proxy server. Please follow the instructions in order to keep your computer safe.

[ovs-dev] ovn: neutron status, picking next task

2015-03-31 Thread Russell Bryant
Hello! The OVN integration for Neutron is coming along well [1]. It's implemented using ovn-nbctl for now, which seems fine for the first demo. There are a few people that have started helping on the Neutron side, including at least one person who is specifically interested in working on

[ovs-dev] PCROQPYGPYD

2015-03-31 Thread Mail Delivery Subsystem
ß0¸çãV-Nþ‚Áïƒ|æ,ÔQ¯d¡S-¢(ØLCe3d°4ÁVêÂv2÷æÛß÷È©Ï·“üaÐіäÅvõ†e—âaçAÄ.m.Âԛoòsuå,ƒŒaù²9 Š$£Y¬1ãñæDÆè^§ã‰¼H“ÑėWl£~ìÚ?²f1úY/_¨„Ñ0NïÃÖ÷çЬê8›6x‡f$h~È ö˦a®^;æ7?Ok¬¼àêÁ%˜—ƒëθC3Ùñ´V~]ØçÄl«‘ý¶NfCm½†”:pþuŸK±ÂªÜ#άěê©â¦qR¸3î·2žÜ—½¨¨Ï0ê´Ô™Ñ×,·ŠÜ‘gýV–”pÅûÛ5v6ìq¿‹Îzîàߘ³ÖÒõ,ªñŽ­¯hn°ìÃz¥Qo„ê2\¤ZµÎSD¨Ûh …

[ovs-dev] [PATCH ovn v3 3/5] meta-flow: Add new functions for subvalues.

2015-03-31 Thread Ben Pfaff
To be first used in upcoming commits. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/meta-flow.c | 81 - lib/meta-flow.h | 13 + 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c

[ovs-dev] [PATCH ovn v3 1/5] lex: New lexical analyzer module for use in OVN.

2015-03-31 Thread Ben Pfaff
I'm determined not to let the terrible style of pseudo-parsing we have in OVS leak into OVN. Here's the first step. Signed-off-by: Ben Pfaff b...@nicira.com --- ovn/TODO | 5 - ovn/automake.mk| 3 + ovn/lex.c | 697 +

[ovs-dev] [PATCH ovn v3 2/5] util: Add more bitwise operations.

2015-03-31 Thread Ben Pfaff
To be used in upcoming commits. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/util.c | 139 + lib/util.h | 8 +++- 2 files changed, 139 insertions(+), 8 deletions(-) diff --git a/lib/util.c b/lib/util.c index bcf7700..3293ca4

[ovs-dev] [PATCH ovn v3 5/5] expr: Support string fields in expr_to_matches().

2015-03-31 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- ovn/expr.c | 115 ++- ovn/expr.h | 6 ++- tests/test-ovn.c | 6 +-- 3 files changed, 95 insertions(+), 32 deletions(-) diff --git a/ovn/expr.c b/ovn/expr.c index cd6f729..83fd866

[ovs-dev] [PATCH] ovn: Add logo in SVG and PNG format.

2015-03-31 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- I'd like to order some OVN stickers for distribution at OpenStack and by mail, so here's my OVN logo proposal. Also available at: http://benpfaff.org/~blp/ovn.png http://benpfaff.org/~blp/ovn.svg diff --git a/ovn/automake.mk

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 05:26:19PM -0700, Jesse Gross wrote: On Tue, Mar 31, 2015 at 4:21 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Mar 30, 2015 at 03:14:46PM -0700, Jesse Gross wrote: The GRE checksum is a 16 bit field stored in a 32 bit option (the rest is reserved). The current code

[ovs-dev] [PATCH ovn v3 0/5] Implement matching expressions for OVN.

2015-03-31 Thread Ben Pfaff
The syntax of matching expressions supported here is documented in ovn(5), which I've made available (along with the rest of the OVS docs for this branch) at http://benpfaff.org/~blp/dist-docs, e.g. specifically http://benpfaff.org/~blp/dist-docs/ovn.5.pdf v1-v2: Drop patch 1 because it was

Re: [ovs-dev] [PATCH] vswitch.xml: Improve description of forward-bpdu.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 08:27:17AM -0700, Ben Pfaff wrote: The description was at best incomplete and difficult to understand. Reported-by: Graham, Mark mark.gra...@anglia.ac.uk Signed-off-by: Ben Pfaff b...@nicira.com Oops, sorry Mark, I see that Brian Field actually reported this bug. I've

Re: [ovs-dev] ovn: neutron status, picking next task

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 08:49:25AM -0400, Russell Bryant wrote: Hello! The OVN integration for Neutron is coming along well [1]. It's implemented using ovn-nbctl for now, which seems fine for the first demo. There are a few people that have started helping on the Neutron side, including at

Re: [ovs-dev] [PATCH ovn 1/5] meta-flow: Add convenience members to union mf_subvalue.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 09:40:19AM -0400, Russell Bryant wrote: On 03/30/2015 11:57 PM, Ben Pfaff wrote: This makes access to the least-significant bits more convenient. This commit simplifies a few existing cases; later commits will make more use of this feature. Signed-off-by: Ben

[ovs-dev] [PATCH] vswitch.xml: Improve description of forward-bpdu.

2015-03-31 Thread Ben Pfaff
The description was at best incomplete and difficult to understand. Reported-by: Graham, Mark mark.gra...@anglia.ac.uk Signed-off-by: Ben Pfaff b...@nicira.com --- AUTHORS | 1 + vswitchd/vswitch.xml | 52 2 files changed, 41

[ovs-dev] [PATCH ovn v2 1/4] lex: New lexical analyzer module for use in OVN.

2015-03-31 Thread Ben Pfaff
I'm determined not to let the terrible style of pseudo-parsing we have in OVS leak into OVN. Here's the first step. Signed-off-by: Ben Pfaff b...@nicira.com --- ovn/TODO | 5 - ovn/automake.mk| 3 + ovn/lex.c | 697 +

[ovs-dev] [PATCH ovn v2 3/4] meta-flow: Add new functions for subvalues.

2015-03-31 Thread Ben Pfaff
To be first used in upcoming commits. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/meta-flow.c | 81 - lib/meta-flow.h | 13 + 2 files changed, 93 insertions(+), 1 deletion(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c

[ovs-dev] [PATCH ovn v2 0/4] Implement matching expressions for OVN.

2015-03-31 Thread Ben Pfaff
The syntax of matching expressions supported here is documented in ovn(5), which I've made available (along with the rest of the OVS docs for this branch) at http://benpfaff.org/~blp/dist-docs, e.g. specifically http://benpfaff.org/~blp/dist-docs/ovn.5.pdf v1-v2: Drop patch 1 because it was

[ovs-dev] [PATCH ovn v2 2/4] util: Add more bitwise operations.

2015-03-31 Thread Ben Pfaff
To be used in upcoming commits. Signed-off-by: Ben Pfaff b...@nicira.com --- lib/util.c | 139 + lib/util.h | 8 +++- 2 files changed, 139 insertions(+), 8 deletions(-) diff --git a/lib/util.c b/lib/util.c index bcf7700..3293ca4

[ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.

2015-03-31 Thread Ben Pfaff
The description was at best incomplete and difficult to understand. Reported-by: Brian Field brian_fi...@cable.comcast.com Signed-off-by: Ben Pfaff b...@nicira.com --- v1-v2: Fix reporter. AUTHORS | 1 + vswitchd/vswitch.xml | 52

Re: [ovs-dev] [PATCH ovn 1/5] meta-flow: Add convenience members to union mf_subvalue.

2015-03-31 Thread Russell Bryant
On 03/31/2015 11:05 AM, Ben Pfaff wrote: On Tue, Mar 31, 2015 at 09:40:19AM -0400, Russell Bryant wrote: On 03/30/2015 11:57 PM, Ben Pfaff wrote: This makes access to the least-significant bits more convenient. This commit simplifies a few existing cases; later commits will make more use of

[ovs-dev] [PATCH] Add support for windows filetypes

2015-03-31 Thread Alin Serdean
Currently paths that have only forward slashes like the following C:/package/binaries/conf.db work seamlessly. If we try the native windows filepaths i.e. C:\package\binaries\conf.db we will hit the following problem: 2015-03-31T15:54:17Z|1|lockfile|WARN|.c:\package\binaries\conf.db.~lock~:

[ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Jesse Gross
skb protocol offsets are relative to the beginning of the buffer and therefore must be updated if the buffer size is expanded. Kernel functions do this automatically for existing fields but obviously not for anything that we backport. This introduces a wrapper for pskb_expand_head() to update the

Re: [ovs-dev] [PATCH] vxlan: fix kernel crash with vxlan gso

2015-03-31 Thread Jesse Gross
On Mon, Mar 30, 2015 at 7:57 PM, Yinpeijun yinpei...@huawei.com wrote: tcp flows with gso between two VMs in diffrent host, go through vxlan tunnel, cause kernel crash. Signed-off-by: caochengrong caochengr...@huawei.com Signed-off-by: Arika Chen arika.c...@huawei.com What OVS and host

[ovs-dev] TEST

2015-03-31 Thread Mail Delivery Subsystem
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/2] jsonrpc: Add function comments.

2015-03-31 Thread Russell Bryant
On 03/31/2015 02:29 PM, Ben Pfaff wrote: Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Russell Bryant rbry...@redhat.com +/* Sets the DSCP value used for 's''s connection to 'dscp'. If this is + * different from the DSCP value currently in use then the connection is closed + * and

Re: [ovs-dev] [PATCH 3/4] ovsdb-idl: Tolerate missing tables and columns.

2015-03-31 Thread Alex Wang
Thx Ben for fixing this!~ Have few comments: @@ -562,12 +699,25 @@ ovsdb_idl_send_monitor_request(struct ovsdb_idl *idl) const struct ovsdb_idl_table *table = idl-tables[i]; const struct ovsdb_idl_table_class *tc = table-class; struct json *monitor_request,

[ovs-dev] [PATCH v2] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Jesse Gross
skb protocol offsets are relative to the beginning of the buffer and therefore must be updated if the buffer size is expanded. Kernel functions do this automatically for existing fields but obviously not for anything that we backport. This introduces a wrapper for pskb_expand_head() to update the

Re: [ovs-dev] [PATCH 2/2] ovsdb-idl: Add function comments.

2015-03-31 Thread Russell Bryant
On 03/31/2015 02:29 PM, Ben Pfaff wrote: Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Russell Bryant rbry...@redhat.com -- Russell Bryant ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH ovn] ovn-nbctl: Sync code and docs for --db option.

2015-03-31 Thread Russell Bryant
The usage() output said the option was --db. The code and man page said --database. Switch everything over to --db to be consistent with the option name used in ovs-vsctl. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/ovn-nbctl.8.xml | 2 +- ovn/ovn-nbctl.c | 2 +- 2 files

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Jesse Gross
On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar pshe...@nicira.com wrote: On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross je...@nicira.com wrote: skb protocol offsets are relative to the beginning of the buffer and therefore must be updated if the buffer size is expanded. Kernel functions do this

[ovs-dev] [PATCH v2] Add support for windows filetypes

2015-03-31 Thread Alin Serdean
Currently paths that have only forward slashes like the following C:/package/binaries/conf.db work seamlessly. If we try the native windows filepaths i.e. C:\package\binaries\conf.db we will hit the following problem: 2015-03-31T15:54:17Z|1|lockfile|WARN|.c:\package\binaries\conf.db.~lock~:

Re: [ovs-dev] Editing Ip headers in datapath.c

2015-03-31 Thread Jarno Rajahalme
On Mar 30, 2015, at 10:19 PM, Sree Vidya S D vidya...@gmail.com wrote: I am trying to edit the Ip source and destination address in void ovs_dp_process_received_packet(struct vport *p, struct sk_buff *skb) in datapath.c file. I am able to edit mac headers successfully using

[ovs-dev] [PATCH 1/2] jsonrpc: Add function comments.

2015-03-31 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/jsonrpc.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c index 86531b8..ae51b42 100644 --- a/lib/jsonrpc.c +++ b/lib/jsonrpc.c @@ -1063,36 +1063,49 @@

Re: [ovs-dev] [PATCH 2/9] tunneling: Add check for GRE protocol is Ethernet.

2015-03-31 Thread Pritesh Kothari (pritkoth)
tested, LGTM, Thanks, appreciated. Acked-by: Pritesh Kothari pritesh.koth...@cisco.com On Mar 30, 2015, at 9:38 PM, Jesse Gross je...@nicira.com wrote: It's probably a good idea although it requires a different type of test compared with what we already have since the GRE protocol doesn't

Re: [ovs-dev] ovn: neutron status, picking next task

2015-03-31 Thread Justin Pettit
On Mar 31, 2015, at 5:49 AM, Russell Bryant rbry...@redhat.com wrote: Since I've basically been working on this from the top down, it seems like helping with ovn-nbd would be the next thing that makes sense. Justin, have you started on it? If not, how about I take a stab at the initial

[ovs-dev] [PATCH 2/2] ovsdb-idl: Add function comments.

2015-03-31 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/ovsdb-idl.c |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index 9c25dbc..570f5ca 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -1,4 +1,4 @@ -/* Copyright (c) 2009, 2010, 2011,

[ovs-dev] [PATCH ovn] ovn-nbctl: Don't loop forever on lost db connection.

2015-03-31 Thread Russell Bryant
The main loop of ovn-nbctl had a condition to catch if the conenction to the db was lost. However, it didn't break out of the loop when the condition occurred. Now it should log the error once and exit with a non-zero status code. Signed-off-by: Russell Bryant rbry...@redhat.com ---

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Pravin Shelar
On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross je...@nicira.com wrote: skb protocol offsets are relative to the beginning of the buffer and therefore must be updated if the buffer size is expanded. Kernel functions do this automatically for existing fields but obviously not for anything that we

Re: [ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.

2015-03-31 Thread Field, Brian
I¹m L2 challenged, so please forgive my lack of clue in this space. First, is CDP really a BPDU? It¹s not performing any sort of spanning tree functionality so I question why OVS¹s forwarding of CDP frames is tied to the bpdu-forwarding value. Is there a reason why CDP is included in the list

Re: [ovs-dev] ovn: neutron status, picking next task

2015-03-31 Thread Justin Pettit
On Mar 31, 2015, at 8:37 AM, Ben Pfaff b...@nicira.com wrote: On Tue, Mar 31, 2015 at 08:49:25AM -0400, Russell Bryant wrote: Hello! The OVN integration for Neutron is coming along well [1]. It's implemented using ovn-nbctl for now, which seems fine for the first demo. There are a few

Re: [ovs-dev] ovn: neutron status, picking next task

2015-03-31 Thread Russell Bryant
On 03/31/2015 02:24 PM, Justin Pettit wrote: On Mar 31, 2015, at 5:49 AM, Russell Bryant rbry...@redhat.com wrote: Since I've basically been working on this from the top down, it seems like helping with ovn-nbd would be the next thing that makes sense. Justin, have you started on it? If

Re: [ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.

2015-03-31 Thread Justin Pettit
On Mar 31, 2015, at 8:31 AM, Ben Pfaff b...@nicira.com wrote: + If STP is enabled on the bridge (see the ref column=stp_enable + table=Open_vSwitch/ column in the ref table=Bridge/ table), I think that should be Bridge instead of Open_vSwitch. + Set this option to

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Don't loop forever on lost db connection.

2015-03-31 Thread Kyle Mestery
On Tue, Mar 31, 2015 at 12:43 PM, Russell Bryant rbry...@redhat.com wrote: The main loop of ovn-nbctl had a condition to catch if the conenction to the db was lost. However, it didn't break out of the loop when the condition occurred. Now it should log the error once and exit with a

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Pravin Shelar
On Tue, Mar 31, 2015 at 11:44 AM, Jesse Gross je...@nicira.com wrote: On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar pshe...@nicira.com wrote: On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross je...@nicira.com wrote: skb protocol offsets are relative to the beginning of the buffer and therefore

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Jesse Gross
On Tue, Mar 31, 2015 at 1:12 PM, Pravin Shelar pshe...@nicira.com wrote: On Tue, Mar 31, 2015 at 11:44 AM, Jesse Gross je...@nicira.com wrote: On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar pshe...@nicira.com wrote: On Tue, Mar 31, 2015 at 9:34 AM, Jesse Gross je...@nicira.com wrote: skb

[ovs-dev] [PATCH v2] datapath: Turn vports with dependencies into separate modules

2015-03-31 Thread Thomas Graf
Upstream commit: The internal and netdev vport remain part of openvswitch.ko. Encap vports including vxlan, gre, and geneve can be built as separate modules and are loaded on demand. Modules can be unloaded after use. Datapath ports keep a reference to the vport module during their

Re: [ovs-dev] [PATCH ovn 1/5] meta-flow: Add convenience members to union mf_subvalue.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 11:24:26AM -0400, Russell Bryant wrote: On 03/31/2015 11:05 AM, Ben Pfaff wrote: On Tue, Mar 31, 2015 at 09:40:19AM -0400, Russell Bryant wrote: On 03/30/2015 11:57 PM, Ben Pfaff wrote: This makes access to the least-significant bits more convenient. This commit

Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Alex Wang
Somehow I could not find the 4th patch, ovsdb-server: Correct malformed error replies to certain JSON-RPC requests. Just want to give an Ack, Acked-by: Alex Wang al...@nicira.com On Thu, Mar 19, 2015 at 11:52 PM, Ben Pfaff b...@nicira.com wrote: The first two commits fix fairly serious

Re: [ovs-dev] [PATCH ovn 1/5] meta-flow: Add convenience members to union mf_subvalue.

2015-03-31 Thread Russell Bryant
On 03/30/2015 11:57 PM, Ben Pfaff wrote: This makes access to the least-significant bits more convenient. This commit simplifies a few existing cases; later commits will make more use of this feature. Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Russell Bryant rbry...@redhat.com --

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-31 Thread Ben Pfaff
On Mon, Mar 30, 2015 at 03:14:46PM -0700, Jesse Gross wrote: The GRE checksum is a 16 bit field stored in a 32 bit option (the rest is reserved). The current code treats the checksum as a 32-bit field and places it in the right place for little endian systems but not big endian. This fixes the

Re: [ovs-dev] [PATCH] datapath: Update inner offsets when expanding headroom.

2015-03-31 Thread Pravin Shelar
On Tue, Mar 31, 2015 at 1:18 PM, Jesse Gross je...@nicira.com wrote: On Tue, Mar 31, 2015 at 1:12 PM, Pravin Shelar pshe...@nicira.com wrote: On Tue, Mar 31, 2015 at 11:44 AM, Jesse Gross je...@nicira.com wrote: On Tue, Mar 31, 2015 at 11:02 AM, Pravin Shelar pshe...@nicira.com wrote: On Tue,

Re: [ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions =4.8.2

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 11:23:32PM +0100, Mark Kavanagh wrote: DPDK 2.0 contains an updated implementation of rte_memcopy, which leverages SSE and AVX instrinsics. In versions of GCC = 4.8.2, it has been observed that the relevant instrinsics are not defined in gcc headers, resulting in

Re: [ovs-dev] [PATCH 3/4] ovsdb-idl: Tolerate missing tables and columns.

2015-03-31 Thread Alex Wang
On Tue, Mar 31, 2015 at 4:11 PM, Ben Pfaff b...@nicira.com wrote: If the IDL isn't configured to monitor any of the columns in a table at all, and table-need_table is false, then I don't want to log anything at all, because the IDL doesn't care about that table at all; that's why it's written

Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Alex Wang
On Tue, Mar 31, 2015 at 4:12 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Mar 31, 2015 at 02:16:07PM -0700, Alex Wang wrote: Somehow I could not find the 4th patch, ovsdb-server: Correct malformed error replies to certain JSON-RPC requests. Just want to give an Ack, Acked-by: Alex

Re: [ovs-dev] [ovsdb speedup 00/18] improve ovsdb connection scaling

2015-03-31 Thread Ben Pfaff
On Sat, Mar 21, 2015 at 12:14:28AM -0700, Andy Zhou wrote: Here are the results: Without this patch series: == #monitors delay of 20 transactions 1 0.046s 100 0.532s 200 1.007s 300 1.599s

Re: [ovs-dev] [PATCH 5/9] odp-util: Shift VXLAN VNI when printing/parsing.

2015-03-31 Thread Pritesh Kothari (pritkoth)
Acked-by: Pritesh Kothari pritesh.koth...@cisco.com On Mar 30, 2015, at 3:14 PM, Jesse Gross je...@nicira.com wrote: Currently when printing a userspace tunnel action for VXLAN, the VNI is treated as a 32 bit field rather than 24 bit. Even if this is the representation that we use

Re: [ovs-dev] REMINDER: [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-03-31 Thread Ben Pfaff
On Sat, Mar 21, 2015 at 03:18:39PM +0530, Rishi Bamba wrote: Hope you are doing fine. We are awaiting response from you the OVS Team regarding the patch ovs-ofctl: Implementation of eviction on the basis of Importance which is already under review. The last revised patch was sent on

Re: [ovs-dev] [RFC ovn] ovn-nbd: Detect ovn and ovn-nb db changes

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 04:03:04PM -0400, Russell Bryant wrote: Signed-off-by: Russell Bryant rbry...@redhat.com --- This is very early, but I wanted to get feedback on the general approach used to detect changes in the ovn and ovn-nb dbs. Does using the IDLs and seqno seem like a sane

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Sync code and docs for --db option.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 03:55:00PM -0400, Russell Bryant wrote: The usage() output said the option was --db. The code and man page said --database. Switch everything over to --db to be consistent with the option name used in ovs-vsctl. Signed-off-by: Russell Bryant rbry...@redhat.com

Re: [ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 10:14:55AM -0700, Justin Pettit wrote: On Mar 31, 2015, at 8:31 AM, Ben Pfaff b...@nicira.com wrote: + If STP is enabled on the bridge (see the ref column=stp_enable + table=Open_vSwitch/ column in the ref table=Bridge/ table), I think that should

[ovs-dev] [PATCH RFC] automake: fix rte_memcopy for gcc versions =4.8.2

2015-03-31 Thread Mark Kavanagh
DPDK 2.0 contains an updated implementation of rte_memcopy, which leverages SSE and AVX instrinsics. In versions of GCC = 4.8.2, it has been observed that the relevant instrinsics are not defined in gcc headers, resulting in compile-time errors. This issue is resolved by enabling the 'mssse3' flag

Re: [ovs-dev] [PATCH net] openvswitch: Return vport module ref before destruction

2015-03-31 Thread David Miller
From: Thomas Graf tg...@suug.ch Date: Mon, 30 Mar 2015 13:57:41 +0200 Return module reference before invoking the respective vport -destroy() function. This is needed as ovs_vport_del() is not invoked inside an RCU read side critical section so the kfree can occur immediately before returning

[ovs-dev] [RFC ovn] ovn-nbd: Detect ovn and ovn-nb db changes

2015-03-31 Thread Russell Bryant
Signed-off-by: Russell Bryant rbry...@redhat.com --- This is very early, but I wanted to get feedback on the general approach used to detect changes in the ovn and ovn-nb dbs. Does using the IDLs and seqno seem like a sane approach? I don't see an easy way to tell anything about what the

Re: [ovs-dev] [PATCH] hmap: Don't include ovs-atomic.h unnecessarily.

2015-03-31 Thread Jarno Rajahalme
Acked-by: Jarno Rajahalme jrajaha...@nicira.com On Mar 29, 2015, at 3:49 PM, Ben Pfaff b...@nicira.com wrote: GNU C++ isn't too happy with ovs-atomic.h. We could fix that (maybe we should) but the report I received from a C++ user implied to me that it would be just as useful to just drop

Re: [ovs-dev] [PATCH 3/4] ovsdb-idl: Tolerate missing tables and columns.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 12:37:11PM -0700, Alex Wang wrote: Thx Ben for fixing this!~ Have few comments: @@ -562,12 +699,25 @@ ovsdb_idl_send_monitor_request(struct ovsdb_idl *idl) const struct ovsdb_idl_table *table = idl-tables[i]; const struct ovsdb_idl_table_class *tc

Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 02:16:07PM -0700, Alex Wang wrote: Somehow I could not find the 4th patch, ovsdb-server: Correct malformed error replies to certain JSON-RPC requests. Just want to give an Ack, Acked-by: Alex Wang al...@nicira.com I can resend patches 3 and 4, or just patch 4, if

Re: [ovs-dev] [PATCH] hmap: Don't include ovs-atomic.h unnecessarily.

2015-03-31 Thread Ben Pfaff
Thanks, applied to master. On Tue, Mar 31, 2015 at 03:39:16PM -0700, Jarno Rajahalme wrote: Acked-by: Jarno Rajahalme jrajaha...@nicira.com On Mar 29, 2015, at 3:49 PM, Ben Pfaff b...@nicira.com wrote: GNU C++ isn't too happy with ovs-atomic.h. We could fix that (maybe we should) but

Re: [ovs-dev] [PATCH 1/2] jsonrpc: Add function comments.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 03:07:32PM -0400, Russell Bryant wrote: On 03/31/2015 02:29 PM, Ben Pfaff wrote: Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Russell Bryant rbry...@redhat.com Thanks for the acks, I applied these to master. +/* Sets the DSCP value used for 's''s

Re: [ovs-dev] [PATCH v2] vswitch.xml: Improve description of forward-bpdu.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 06:17:42PM +, Field, Brian wrote: I?m L2 challenged, so please forgive my lack of clue in this space. Me too ;-) First, is CDP really a BPDU? It?s not performing any sort of spanning tree functionality so I question why OVS?s forwarding of CDP frames is tied to

Re: [ovs-dev] [PATCH v2 2/2] datapath: Add Stateless TCP Tunneling protocol.

2015-03-31 Thread Jesse Gross
On Thu, Mar 26, 2015 at 4:41 PM, Pravin B Shelar pshe...@nicira.com wrote: diff --git a/datapath/datapath.c b/datapath/datapath.c index 7f431ed..ea9c6ae 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -2192,6 +2192,7 @@ static int __net_init ovs_init_net(struct net *net)

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Don't loop forever on lost db connection.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 01:43:18PM -0400, Russell Bryant wrote: The main loop of ovn-nbctl had a condition to catch if the conenction to the db was lost. However, it didn't break out of the loop when the condition occurred. Now it should log the error once and exit with a non-zero status

Re: [ovs-dev] [PATCH ovn] ovn-nbctl: Don't loop forever on lost db connection.

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 12:49:11PM -0500, Kyle Mestery wrote: On Tue, Mar 31, 2015 at 12:43 PM, Russell Bryant rbry...@redhat.com wrote: The main loop of ovn-nbctl had a condition to catch if the conenction to the db was lost. However, it didn't break out of the loop when the condition

Re: [ovs-dev] [PATCH 0/4] Fix upgrade problems related to AutoAttach

2015-03-31 Thread Ben Pfaff
On Tue, Mar 31, 2015 at 04:39:47PM -0700, Alex Wang wrote: On Tue, Mar 31, 2015 at 4:12 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Mar 31, 2015 at 02:16:07PM -0700, Alex Wang wrote: Somehow I could not find the 4th patch, ovsdb-server: Correct malformed error replies to certain

Re: [ovs-dev] [PATCH 3/9] tunneling: Fix location of GRE checksums.

2015-03-31 Thread Jesse Gross
On Tue, Mar 31, 2015 at 4:21 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Mar 30, 2015 at 03:14:46PM -0700, Jesse Gross wrote: The GRE checksum is a 16 bit field stored in a 32 bit option (the rest is reserved). The current code treats the checksum as a 32-bit field and places it in the right

[ovs-dev] [PATCH 1/2] bridge: Do not wait for status update when there is no bridge.

2015-03-31 Thread Alex Wang
Signed-off-by: Alex Wang al...@nicira.com --- vswitchd/bridge.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 2e90ea2..161ba14 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -2826,12 +2826,6 @@

[ovs-dev] [PATCH 2/2] bridge: Wait for previous stats update transation when it is incomplete.

2015-03-31 Thread Alex Wang
When ovsdb happens to get blocked for few seconds, the 'stats_timer' will not be updated due to incompletion of previous transaction. When the current time passes the 'stats_timer', the call to poll_timer_wait_until(stats_timer) will keep waking up ovs-vswitchd, causing 100% cpu utilization. This