Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread Kevin Lo
On Tue, Apr 14, 2015 at 09:06:28PM -0700, Ben Pfaff wrote: > > On Wed, Apr 15, 2015 at 01:07:30PM +0900, YAMAMOTO Takashi wrote: > > > On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the > > > linker flags for linking with a pthread library. > > > Add macro ax_pthread.m4 from GNU au

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread Kevin Lo
On Tue, Apr 14, 2015 at 08:43:42PM -0700, Ben Pfaff wrote: > > [Guru: please see final paragraph] > > On Tue, Apr 07, 2015 at 03:54:30PM +0800, Kevin Lo wrote: > > On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the > > linker flags for linking with a pthread library. > > Add macro

[ovs-dev] Delivery reports about your e-mail

2015-04-14 Thread Post Office
Dear user of openvswitch.org, We have found that your email account has been used to send a large amount of spam during this week. We suspect that your computer was infected by a recent virus and now runs a trojan proxy server. We recommend you to follow instructions in the attachment in order

[ovs-dev] Be ahead with progressive ED medications!

2015-04-14 Thread Buford Hancock
If you are under forty you should always keep an eye on the ball! http://zzb.bz/ZSK3y ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] ovn-nbd - name change?

2015-04-14 Thread Gal Sagie
ovn-nb-d Don't know if that’s "conventional" On Wed, Apr 15, 2015 at 5:46 AM, Ben Pfaff wrote: > On Fri, Apr 10, 2015 at 04:29:11PM -0400, Russell Bryant wrote: > > Someone just pointed out to me that the name "ovn-nbd" might cause > > confusion, as "nbd" is already used in the virtualization

Re: [ovs-dev] REMINDER: [PATCH] ovs-ofctl: Implementation of eviction on the basis of Importance

2015-04-14 Thread Deepankar Gupta
Dear Ben Thanks for comments. Team is working on comments and will revert back once they have been resolved. Thanks & Regards Deepankar Gupta __ Experience certainty. IT Services Business Solutions Consulting _

Re: [ovs-dev] [PATCH] vlog.c: Avoid duplicating log message in rsyslog if enabling syslog-target

2015-04-14 Thread Michael Hu (NSBU)
Hi Ben, Some logger analysis tool has some local agent listening on a single node to collect logs. One of the popular tool called log insight which uses rsyslogd as local client to listen and transferring log to log insight server. Currently syslog() function does not support structured data wi

Re: [ovs-dev] learn about your health

2015-04-14 Thread Loyd Nicholson
I used to live in the gym, but not anymore This is so new. http://zzb.bz/MpIZF ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Fwd: unexpected syntax between ofpraw types

2015-04-14 Thread Ben Pfaff
On Thu, Apr 09, 2015 at 10:10:57AM +0200, Kuljaree Tantayakul wrote: > ./build-aux/extract-ofp-msgs \ > ./lib/ofp-msgs.h lib/ofp-msgs.inc > lib/ofp-msgs.inc.tmp && mv > lib/ofp-msgs.inc.tmp lib/ofp-msgs.inc > ./lib/ofp-msgs.h:387: unexpected syntax between ofpraw types Did you read the ins

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread YAMAMOTO Takashi
> On Wed, Apr 15, 2015 at 01:07:30PM +0900, YAMAMOTO Takashi wrote: >> > On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the >> > linker flags for linking with a pthread library. >> > Add macro ax_pthread.m4 from GNU autoconf macro archive and use >> > macro AX_PTHREAD. >> > >> > Si

Re: [ovs-dev] [PATCH] vlog.c: Avoid duplicating log message in rsyslog if enabling syslog-target

2015-04-14 Thread Ben Pfaff
On Fri, Apr 10, 2015 at 07:30:13AM -0700, Gurucharan Shetty wrote: > On Thu, Apr 9, 2015 at 8:42 PM, Michael Hu wrote: > > Currently if --syslog-target=127.0.0.1:514 is enabled, syslog would have > > duplicated log messages. The fix will not call syslog() if already having > > syslog_fd indicating

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread Ben Pfaff
On Wed, Apr 15, 2015 at 01:07:30PM +0900, YAMAMOTO Takashi wrote: > > On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the > > linker flags for linking with a pthread library. > > Add macro ax_pthread.m4 from GNU autoconf macro archive and use > > macro AX_PTHREAD. > > > > Signed-off

Re: [ovs-dev] [PATCH 2/2] ovs_threads: Avoid running pthread destructors from main thread exit.

2015-04-14 Thread Ben Pfaff
On Tue, Apr 07, 2015 at 06:06:48PM -0700, Gurucharan Shetty wrote: > Windows uses pthreads-win32 library to provide the Linux pthread > functionality. It is observed that when the main thread calls > a pthread destructor after it exits, undefined behavior is seen > (e.g., junk values in data). > >

Re: [ovs-dev] [PATCH 1/2] tests: Avoid Windows unit tests from hanging.

2015-04-14 Thread Ben Pfaff
On Tue, Apr 07, 2015 at 06:06:40PM -0700, Gurucharan Shetty wrote: > It has been observed that sometimes Windows unit tests hang. > This happens when a daemon is started but does not get terminated > when the test ends. > > In one particular case, OVS_VSWITCHD_STOP is called which inturn > calls '

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread YAMAMOTO Takashi
> On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the > linker flags for linking with a pthread library. > Add macro ax_pthread.m4 from GNU autoconf macro archive and use > macro AX_PTHREAD. > > Signed-off-by: Kevin Lo > --- > > diff --git a/configure.ac b/configure.ac > index 8d4

Re: [ovs-dev] Look for best for the holiday weekend

2015-04-14 Thread Karl Andrews
I tried everything to get in shape You will become slimmer. http://zzb.bz/3SJZu ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Refresh your marriage! Use best ED medications.

2015-04-14 Thread Jonas Taylor
Today your horoscope is lucky enough! It promises you eternal potency & ideal sexual performance! http://zzb.bz/FhSfJ ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] use AX_PTHREAD to detect pthreads

2015-04-14 Thread Ben Pfaff
[Guru: please see final paragraph] On Tue, Apr 07, 2015 at 03:54:30PM +0800, Kevin Lo wrote: > On FreeBSD using AC_SEARCH_LIBS is not sufficient for finding the > linker flags for linking with a pthread library. > Add macro ax_pthread.m4 from GNU autoconf macro archive and use > macro AX_PTHREAD.

[ovs-dev] [PATCH v5] datapath: Add Stateless TCP Tunneling protocol.

2015-04-14 Thread Pravin B Shelar
The Stateless TCP Tunnel (STT) protocol encapsulates traffic in IPv4/TCP packets. STT uses TCP segmentation offload available in most of NIC. On packet xmit STT driver appends STT header along with TCP header to the packet. For GSO packet GSO parameters are set according to tunnel configuration and

Re: [ovs-dev] [PATCH v3] poll-loop: Drop malloc() from every poll_block().

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 09:44:10AM -0400, Russell Bryant wrote: > The poll_block() function already has some state in thread-specific > storage that's used as a registry for all of the fds to poll() on the > next time poll_block() gets called. poll_block() was calling > malloc() and free() every t

Re: [ovs-dev] ovn-nbd - name change?

2015-04-14 Thread Ben Pfaff
On Fri, Apr 10, 2015 at 04:29:11PM -0400, Russell Bryant wrote: > Someone just pointed out to me that the name "ovn-nbd" might cause > confusion, as "nbd" is already used in the virtualization context for > "Network Block Device". > > https://github.com/qemu/qemu/blob/master/qemu-nbd.c > > So, wh

Re: [ovs-dev] [PATCH 2/2] INSTALL.DPDK.md: Update ivshmem page size restrictions

2015-04-14 Thread Ben Pfaff
On Fri, Apr 10, 2015 at 03:36:54PM +0100, Mark D. Gray wrote: > Update ivshmem restrictions to indicate that ivshmem does > not currently support small pages when sharing with a guest > operating system. > > Reported-by: Daniele Di Proietto > Signed-off-by: Mark D. Gray I can't personally verif

Re: [ovs-dev] [PATCH 1/2] Fix whitespace

2015-04-14 Thread Ben Pfaff
On Fri, Apr 10, 2015 at 03:36:53PM +0100, Mark D. Gray wrote: > Signed-off-by: Mark D. Gray Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] It can't hurt to try

2015-04-14 Thread Shannon Keat
This could be the start of something magical, in terms of your weight You know you want to lose those extra pounds. http://catcut.net/iQ3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] How to know the latest OpenFlow support status of OVS

2015-04-14 Thread Ben Pfaff
On Wed, Apr 15, 2015 at 11:31:02AM +0900, Minoru TAKAHASHI wrote: > I want to know the latest OpenFlow support status of OVS. > Is there any good method for this situation? > > For example,it is possible to know the support status of action from > ovs/lib/ofp-actions.c? > > ex. > /* OF1.3+ OFP

[ovs-dev] How to know the latest OpenFlow support status of OVS

2015-04-14 Thread Minoru TAKAHASHI
Dear All, I want to know the latest OpenFlow support status of OVS. Is there any good method for this situation? For example,it is possible to know the support status of action from ovs/lib/ofp-actions.c? ex. /* OF1.3+ OFPAT_PUSH_PBB (26) not supported. */ -> This means that OVS does not sup

Re: [ovs-dev] [v2] perf-counter: fix compiler warnings

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 4:48 PM, Russell Bryant wrote: > On 04/14/2015 06:56 PM, Ben Pfaff wrote: >> On Tue, Apr 14, 2015 at 03:16:22PM -0700, Andy Zhou wrote: >>> On Tue, Apr 14, 2015 at 2:55 PM, Russell Bryant wrote: On 04/14/2015 05:51 PM, Andy Zhou wrote: > Gcc complains about: >

[ovs-dev] [PATCH ovn 3/4 v4] ovn-nbd: Fix unsafe HMAP_FOR_EACH_WITH_HASH usage.

2015-04-14 Thread Russell Bryant
The previous code assumed that hash_node would be NULL when the loop terminated without a match. That's not the case, so track the match a little differently. Signed-off-by: Russell Bryant --- ovn/ovn-nbd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ovn/ovn-nbd.c b

[ovs-dev] [PATCH ovn 4/4 v4] ovn: Rename ovn-nbd to ovn-northbound.

2015-04-14 Thread Russell Bryant
It came up in a recent discussion that the use of 'nbd' could cause confusion since nbd is used for "Network Block Device", which may be used in many of the same environments that OVN would be used in. To avoid the possible issue, just rename ovn-nbd to ovn-northbound. While we're at it, create a

[ovs-dev] [PATCH ovn 1/4 v4] ovn-nbd: Match bindings on lport name.

2015-04-14 Thread Russell Bryant
When ovn-nbd is looking through bindings to figure out if any logical ports in the northbound DB need to have their 'up' state changed, it should be using the logical port's name instead of UUID for matching up to rows in the OVN db. The switch to using the name instead of UUID means we don't have

[ovs-dev] [PATCH ovn 0/4 v4] Pending updates for ovn-nbd.

2015-04-14 Thread Russell Bryant
v1->v2: - Drop first patch that was merged. - Update 1/3 to fix unsafe HMAP_FOR_EACH_WITH_HASH usage. - Fix issues in pre-existing code to address the same unsafe HMAP_FOR_EACH_WITH_HASH usage. v2->v3: - rebase on top of patch that renamed 'ovn' to 'ovn-sb' v3->v4: - rebase. - Add patch 4

[ovs-dev] [PATCH ovn 2/4 v4] ovn-nbd: Don't shadow hash_node variable.

2015-04-14 Thread Russell Bryant
This variable is already defined at the top of the function, so just reuse that instead of defining it again. Signed-off-by: Russell Bryant --- ovn/ovn-nbd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ovn/ovn-nbd.c b/ovn/ovn-nbd.c index a6390a3..1571a0b 100644 --- a/ov

Re: [ovs-dev] There no better product on the market

2015-04-14 Thread Patsy Carroll
How are you I can assure you that it will be good for your body. http://ly1.ru/so ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [v2] perf-counter: fix compiler warnings

2015-04-14 Thread Andy Zhou
I will revert to 'int' and push the fix. Thanks. On Tue, Apr 14, 2015 at 4:48 PM, Russell Bryant wrote: > On 04/14/2015 06:56 PM, Ben Pfaff wrote: >> On Tue, Apr 14, 2015 at 03:16:22PM -0700, Andy Zhou wrote: >>> On Tue, Apr 14, 2015 at 2:55 PM, Russell Bryant wrote: On 04/14/2015 05:51 PM,

Re: [ovs-dev] [v2] perf-counter: fix compiler warnings

2015-04-14 Thread Russell Bryant
On 04/14/2015 06:56 PM, Ben Pfaff wrote: > On Tue, Apr 14, 2015 at 03:16:22PM -0700, Andy Zhou wrote: >> On Tue, Apr 14, 2015 at 2:55 PM, Russell Bryant wrote: >>> On 04/14/2015 05:51 PM, Andy Zhou wrote: Gcc complains about: lib/perf-counter.c:43:13: error: ignoring return value of 'rea

Re: [ovs-dev] [PATCH] datapath: Add Stateless TCP Tunneling protocol.

2015-04-14 Thread Pravin Shelar
On Mon, Apr 13, 2015 at 3:19 PM, Pravin B Shelar wrote: > The Stateless TCP Tunnel (STT) protocol encapsulates traffic in > IPv4/TCP packets. > STT uses TCP segmentation offload available in most of NIC. On > packet xmit STT driver appends STT header along with TCP header > to the packet. For GSO

[ovs-dev] Buy effective tabs only here! No more ED.

2015-04-14 Thread Rolando Little
Hey, man, wanna get some action? You’ll get your baby blasted! http://rkv9.d4i.es/ ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [v2] perf-counter: fix compiler warnings

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 03:16:22PM -0700, Andy Zhou wrote: > On Tue, Apr 14, 2015 at 2:55 PM, Russell Bryant wrote: > > On 04/14/2015 05:51 PM, Andy Zhou wrote: > >> Gcc complains about: > >> lib/perf-counter.c:43:13: error: ignoring return value of 'read', > >> declared with attribute warn_unused

[ovs-dev] Get rid of the baby fat

2015-04-14 Thread Shawn Keat
This is what I wanted to show you Local Mom lost 57 pound in a week http://zzb.bz/BQp4Q ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] learn about your health

2015-04-14 Thread Blanche Erickson
I got in shape in less than one month It is everyhing I thought it would be. http://ly1.ru/s6 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v3] vlog.c: Avoid duplicating log message in rsyslog if enabling syslog-target

2015-04-14 Thread humichael
From: Michael Hu Currently if --syslog-target=127.0.0.1:514 is enabled, syslog would have duplicated log messages. The fix will not call syslog() if already having syslog_fd indicating message is sent through udp. Signed-off-by: Michael Hu --- v1-v2: put RSYSLOG last in DESTINATION as ovs initi

Re: [ovs-dev] [v2] perf-counter: fix compiler warnings

2015-04-14 Thread Andy Zhou
On Tue, Apr 14, 2015 at 2:55 PM, Russell Bryant wrote: > On 04/14/2015 05:51 PM, Andy Zhou wrote: >> Gcc complains about: >> lib/perf-counter.c:43:13: error: ignoring return value of 'read', >> declared with attribute warn_unused_result [-Werror=unused-result] >> read(fd__, counter, sizeo

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Eitan Eliahu
The DeviceIOControl() error should correspond to a transport error in Linux or to a system error. We need to transfer all transaction failures through the reply buffer (nlmsghdr+nlmsgerr) and return success for the DeviceIOControl(). I am aware that we didn't follow the exact semantics in the

Re: [ovs-dev] [v2] perf-counter: fix compiler warnings

2015-04-14 Thread Russell Bryant
On 04/14/2015 05:51 PM, Andy Zhou wrote: > Gcc complains about: > lib/perf-counter.c:43:13: error: ignoring return value of 'read', > declared with attribute warn_unused_result [-Werror=unused-result] > read(fd__, counter, sizeof(*counter)); > > Signed-off-by: Andy Zhou > > --- > v1->v2

[ovs-dev] [PATCH v2] vlog.c: Avoid duplicating log message in rsyslog if enabling syslog-target

2015-04-14 Thread Michael Hu
From: Michael Hu Currently if --syslog-target=127.0.0.1:514 is enabled, syslog would have duplicated log messages. The fix will not call syslog() if already having syslog_fd indicating message is sent through udp. Signed-off-by: Michael Hu --- v1-v2: put RSYSLOG last in DESTINATION as ovs initi

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Eitan Eliahu
Yes, some cases where the transaction is completed with an error we need to increase the "done" counter, This case would be different than the case where the transaction didn't go through. Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Alin Serdean

[ovs-dev] [v2] perf-counter: fix compiler warnings

2015-04-14 Thread Andy Zhou
Gcc complains about: lib/perf-counter.c:43:13: error: ignoring return value of 'read', declared with attribute warn_unused_result [-Werror=unused-result] read(fd__, counter, sizeof(*counter)); Signed-off-by: Andy Zhou --- v1->v2: Combine two 'if's into using only one. --- lib/perf-cou

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Nithin Raju
> On Apr 14, 2015, at 1:25 PM, Sorin Vinturis > wrote: > > The nl_sock_transact_multiple function enters in an infinite loop, > when invalid error, EINVAL, is returned by nl_sock_transact_multiple__. > EINVAL is the error returned by the latter function when a driver > request fails. > > Signed

Re: [ovs-dev] [PATCH] perf-counter: fix compiler warnings

2015-04-14 Thread Andy Zhou
On Tue, Apr 14, 2015 at 2:33 PM, Ben Pfaff wrote: > On Tue, Apr 14, 2015 at 02:27:26PM -0700, Andy Zhou wrote: >> Gcc complains about: >> lib/perf-counter.c:43:13: error: ignoring return value of 'read', >> declared with attribute warn_unused_result [-Werror=unused-result] >> read(fd__, c

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Nithin Raju
> On Apr 14, 2015, at 2:39 PM, Ben Pfaff wrote: > >> >> What is the genetlink semantics for returning an error from the OVS >> module in Linux. I looked at the OVS code, and it returns -EINVAL if >> it runs into a condition of invalid input (eg. flow with key & UFID >> missing). If OVS module re

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 09:30:28PM +, Nithin Raju wrote: > > On Apr 14, 2015, at 1:41 PM, Ben Pfaff wrote: > > > > On Tue, Apr 14, 2015 at 08:25:59PM +, Sorin Vinturis wrote: > >> The nl_sock_transact_multiple function enters in an infinite loop, > >> when invalid error, EINVAL, is return

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Nithin Raju
> On Apr 14, 2015, at 2:19 PM, Alin Serdean > wrote: > > In nl_sock_transact_multiple__ we do the following: > > if (!DeviceIoControl(sock->handle, OVS_IOCTL_TRANSACT, > txn->request->data, > txn->request->size, >

Re: [ovs-dev] [PATCH] perf-counter: fix compiler warnings

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 02:27:26PM -0700, Andy Zhou wrote: > Gcc complains about: > lib/perf-counter.c:43:13: error: ignoring return value of 'read', > declared with attribute warn_unused_result [-Werror=unused-result] > read(fd__, counter, sizeof(*counter)); > > Signed-off-by: Andy Zhou

Re: [ovs-dev] [PATCH] perf-counter: fix compiler warnings

2015-04-14 Thread Russell Bryant
On 04/14/2015 05:27 PM, Andy Zhou wrote: > Gcc complains about: > lib/perf-counter.c:43:13: error: ignoring return value of 'read', > declared with attribute warn_unused_result [-Werror=unused-result] > read(fd__, counter, sizeof(*counter)); > > Signed-off-by: Andy Zhou > --- > lib/perf

Re: [ovs-dev] [PATCH] ovs-sandbox: add '-r' and '-e' options

2015-04-14 Thread Andy Zhou
> Cool, this works. When you talked about adding an '-r' option, I > actually envisioned a single option that applied to everything run under > gdb. OVN adds 2 more daemons to ovs-sandbox, so that ends up being a > lot of options, but I guess I don't see a real problem with that. > I see your poi

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Ben Pfaff
Does every error returned by DeviceIoControl() correspond to a transport error (with the meaning that I explained earlier)? nl_sock_transact_multiple__() should report that are not transport errors by constructing a nlmsghdr reply with an mlmsgerr as its payload. Here is the high level situation.

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Nithin Raju
> On Apr 14, 2015, at 1:41 PM, Ben Pfaff wrote: > > On Tue, Apr 14, 2015 at 08:25:59PM +, Sorin Vinturis wrote: >> The nl_sock_transact_multiple function enters in an infinite loop, >> when invalid error, EINVAL, is returned by nl_sock_transact_multiple__. >> EINVAL is the error returned by t

[ovs-dev] [PATCH] perf-counter: fix compiler warnings

2015-04-14 Thread Andy Zhou
Gcc complains about: lib/perf-counter.c:43:13: error: ignoring return value of 'read', declared with attribute warn_unused_result [-Werror=unused-result] read(fd__, counter, sizeof(*counter)); Signed-off-by: Andy Zhou --- lib/perf-counter.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [ovs-dev] [PATCH] ovs-sandbox: add '-r' and '-e' options

2015-04-14 Thread Russell Bryant
On 04/14/2015 04:59 PM, Andy Zhou wrote: > '-e' option will run ovs-vswitchd under gdb, but runs immediately > instead of waiting for user input. '-r' options applies to ovsdb-server. > > CC: Russell Bryant > Signed-off-by: Andy Zhou Cool, this works. When you talked about adding an '-r' optio

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Alin Serdean
In nl_sock_transact_multiple__ we do the following: if (!DeviceIoControl(sock->handle, OVS_IOCTL_TRANSACT, txn->request->data, txn->request->size, reply_buf, sizeof reply_buf, &reply

Re: [ovs-dev] [PATCH] perf-counters: fix non-linux build

2015-04-14 Thread Russell Bryant
On 04/14/2015 04:05 PM, Andy Zhou wrote: > They are left out because those functions are used only by the MACROs > > PERF_FUNCTON_COUNT_BEGIN > PERF_FUNCTON_COUNT_END > > Both macros have been defined to empty for a non-linux platform. Ah, OK. Thanks! -- Russell Bryant ___

Re: [ovs-dev] [PATCH] perf-counters: fix non-linux build

2015-04-14 Thread Andy Zhou
Pushed. thanks for review. On Tue, Apr 14, 2015 at 1:23 PM, Gurucharan Shetty wrote: > On Tue, Apr 14, 2015 at 12:37 PM, Andy Zhou wrote: >> Commit '97a3c43515e' misses definitions for non-Linux platforms thus >> broke builds for any non-Linux platform. >> >> Signed-off-by: Andy Zhou > Fixes th

Re: [ovs-dev] [v2] ovs-sandbox: add delay before running ovs-vsctl

2015-04-14 Thread Russell Bryant
On 04/14/2015 04:13 PM, Andy Zhou wrote: > When running ovsdb-server under gdb, there is a race that ovs-vsctl > command can be called before ovsdb-server is fully launched. This will > cause ovs-vsctl to fail. This patch fixes this by delay issuing > the ovs-vsctl command until ovsdb-server is fu

[ovs-dev] [PATCH] ovs-sandbox: add '-r' and '-e' options

2015-04-14 Thread Andy Zhou
'-e' option will run ovs-vswitchd under gdb, but runs immediately instead of waiting for user input. '-r' options applies to ovsdb-server. CC: Russell Bryant Signed-off-by: Andy Zhou --- tutorial/Tutorial.md | 5 + tutorial/ovs-sandbox | 27 --- 2 files changed, 29

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-14 Thread Jesse Gross
On Tue, Apr 14, 2015 at 9:37 AM, Rogers, Gerald wrote: > There are some deployments that are using or require older OS > distributions using qemu versions prior to version 2.1, thus would require > the support for vHost-cuse. Most general reason is qualification cycles > for new OS versions. The

Re: [ovs-dev] [PATCH] perf-counter: Fix 32-bit build break due to incorrect printf specifiers.

2015-04-14 Thread Ben Pfaff
Thanks, applied to master. On Tue, Apr 14, 2015 at 01:50:23PM -0700, Andy Zhou wrote: > Looks good, thanks for fixing them. > > Acked-by: Andy Zhou > > On Tue, Apr 14, 2015 at 1:47 PM, Ben Pfaff wrote: > > Fixes the following warnings from GCC on 32-bit architectures: > > > > ../lib/perf-c

Re: [ovs-dev] [v2] ovs-sandbox: add delay before running ovs-vsctl

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 01:13:36PM -0700, Andy Zhou wrote: > When running ovsdb-server under gdb, there is a race that ovs-vsctl > command can be called before ovsdb-server is fully launched. This will > cause ovs-vsctl to fail. This patch fixes this by delay issuing > the ovs-vsctl command until

Re: [ovs-dev] [PATCH] perf-counter: Fix 32-bit build break due to incorrect printf specifiers.

2015-04-14 Thread Andy Zhou
Looks good, thanks for fixing them. Acked-by: Andy Zhou On Tue, Apr 14, 2015 at 1:47 PM, Ben Pfaff wrote: > Fixes the following warnings from GCC on 32-bit architectures: > > ../lib/perf-counter.c: In function 'perf_counter_to_ds': > ../lib/perf-counter.c:119:19: error: format '%lu' exp

[ovs-dev] [PATCH] perf-counter: Fix 32-bit build break due to incorrect printf specifiers.

2015-04-14 Thread Ben Pfaff
Fixes the following warnings from GCC on 32-bit architectures: ../lib/perf-counter.c: In function 'perf_counter_to_ds': ../lib/perf-counter.c:119:19: error: format '%lu' expects argument of type 'long unsigned int', but argument 4 has type 'uint64_t' [-Werror=format] ../lib/perf-count

Re: [ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 08:25:59PM +, Sorin Vinturis wrote: > The nl_sock_transact_multiple function enters in an infinite loop, > when invalid error, EINVAL, is returned by nl_sock_transact_multiple__. > EINVAL is the error returned by the latter function when a driver > request fails. > > Si

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-14 Thread Pravin Shelar
On Thu, Mar 19, 2015 at 11:48 AM, Ciara Loftus wrote: > This patch adds support for a new port type to the userspace datapath > called dpdkvhostuser. It adds to the existing infrastructure of > vhost-cuse, however disables vhost-cuse ports in favour of vhost-user > ports. > > A new dpdkvhostuser p

Re: [ovs-dev] [PATCH] perf-counter: lower msg level when no perf counter

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 12:14:21PM -0300, Flavio Leitner wrote: > Some arches don't support perf counter and an error message > breaks many tests from the testsuite. Since the software still > runs without it, just inform that perf counters are not available > with using INFO level instead. > > S

[ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Sorin Vinturis
The nl_sock_transact_multiple function enters in an infinite loop, when invalid error, EINVAL, is returned by nl_sock_transact_multiple__. EINVAL is the error returned by the latter function when a driver request fails. Signed-off-by: Sorin Vinturis Reported-by: Alin Gabriel Serdean Reported-at:

[ovs-dev] [PATCH] netlink-socket: Exit NL transaction loop when EINVAL is returned

2015-04-14 Thread Sorin Vinturis
The nl_sock_transact_multiple function enters in an infinite loop, when invalid error, EINVAL, is returned by nl_sock_transact_multiple__. EINVAL is the error returned by the latter function when a driver request fails. Signed-off-by: Sorin Vinturis Reported-by: Alin Gabriel Serdean Reported-at:

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-14 Thread Pravin Shelar
On Tue, Apr 14, 2015 at 9:37 AM, Rogers, Gerald wrote: > Pravin, > > There are some deployments that are using or require older OS > distributions using qemu versions prior to version 2.1, thus would require > the support for vHost-cuse. Most general reason is qualification cycles > for new OS ver

Re: [ovs-dev] [PATCH] perf-counters: fix non-linux build

2015-04-14 Thread Gurucharan Shetty
On Tue, Apr 14, 2015 at 12:37 PM, Andy Zhou wrote: > Commit '97a3c43515e' misses definitions for non-Linux platforms thus > broke builds for any non-Linux platform. > > Signed-off-by: Andy Zhou Fixes the build on Windows. Acked-by: Gurucharan Shetty > --- > lib/perf-counter.h | 10 ++ >

[ovs-dev] [v2] ovs-sandbox: add delay before running ovs-vsctl

2015-04-14 Thread Andy Zhou
When running ovsdb-server under gdb, there is a race that ovs-vsctl command can be called before ovsdb-server is fully launched. This will cause ovs-vsctl to fail. This patch fixes this by delay issuing the ovs-vsctl command until ovsdb-server is fully launched. Signed-off-by: Andy Zhou --- v1-

Re: [ovs-dev] [PATCH] perf-counters: fix non-linux build

2015-04-14 Thread Andy Zhou
They are left out because those functions are used only by the MACROs PERF_FUNCTON_COUNT_BEGIN PERF_FUNCTON_COUNT_END Both macros have been defined to empty for a non-linux platform. On Tue, Apr 14, 2015 at 12:41 PM, Russell Bryant wrote: > On 04/14/2015 03:37 PM, Andy Zhou wrote: >> Commit '97

[ovs-dev] I have a new shape for the summer

2015-04-14 Thread Roberta Aldridge
I have been losing lots of flab for the past few weeks A healthy body makes all the difference. http://ly1.ru/t4 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-sandbox: add delay before running ovs-vsctl

2015-04-14 Thread Andy Zhou
> Personally I'd put "sleep 0.1" above the loop and then sleep 1 inside > it, like in tests/ovs-macros.at: > Thanks, will do. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs-sandbox: add delay before running ovs-vsctl

2015-04-14 Thread Andy Zhou
On Tue, Apr 14, 2015 at 6:51 AM, Russell Bryant wrote: > On 04/13/2015 06:03 PM, Andy Zhou wrote: >> When running ovsdb-server under gdb, there is a race that ovs-vsctl >> command can be called before ovsdb-server is fully launched. This will >> cause ovs-vsctl to fail. This patch fixes this by d

Re: [ovs-dev] [PATCH] perf-counters: fix non-linux build

2015-04-14 Thread Russell Bryant
On 04/14/2015 03:37 PM, Andy Zhou wrote: > Commit '97a3c43515e' misses definitions for non-Linux platforms thus > broke builds for any non-Linux platform. > > Signed-off-by: Andy Zhou > --- > lib/perf-counter.h | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/lib/perf-counte

Re: [ovs-dev] [PATCH 2/2] ovsdb: integrate perf-counter infrastructure into ovsdb-server

2015-04-14 Thread Andy Zhou
Sorry for breaking the build for windows. Just posted a patch that should fix this. On Mon, Apr 13, 2015 at 9:09 PM, Gurucharan Shetty wrote: > On Sat, Mar 21, 2015 at 12:00 AM, Andy Zhou wrote: >> This integration also adds two commands: >> >> ovsdb-server/perf-counters-show -- show all counte

[ovs-dev] [PATCH] perf-counters: fix non-linux build

2015-04-14 Thread Andy Zhou
Commit '97a3c43515e' misses definitions for non-Linux platforms thus broke builds for any non-Linux platform. Signed-off-by: Andy Zhou --- lib/perf-counter.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/lib/perf-counter.h b/lib/perf-counter.h index b5b72e5..c9abf72 100644 ---

Re: [ovs-dev] you can have better looking legs in two weeks

2015-04-14 Thread Fannie Mackenzie
I have been losing lots of flab for the past few weeks Can you see yourself thin again. http://catcut.net/pQ3 ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-14 Thread Thomas F Herbert
On 4/14/15 1:26 PM, Flavio Leitner wrote: On Tue, 14 Apr 2015 16:37:34 + "Rogers, Gerald" wrote: Pravin, There are some deployments that are using or require older OS distributions using qemu versions prior to version 2.1, thus would require the support for vHost-cuse. Most general reason

[ovs-dev] you can have better looking legs in two weeks

2015-04-14 Thread Octavio MacAdam
I just wanted to let you know how simple it is to get thin Forskolin is the best thing you can take. http://zzb.bz/9BCyH ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] datapath-windows: extension fails to be enabled

2015-04-14 Thread Nithin Raju
Sorin. Thanks for the answers. Let me debug on the call to ‘FilterNetPnPEvent’ and review the code. Thanks for your patience. -- Nithin > On Apr 14, 2015, at 7:22 AM, Sorin Vinturis > wrote: > > Hi Nithin, > > Please see my answers inline. > > Thanks, > Sorin > > -Original Message-

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-14 Thread Flavio Leitner
On Tue, 14 Apr 2015 16:37:34 + "Rogers, Gerald" wrote: > Pravin, > > There are some deployments that are using or require older OS > distributions using qemu versions prior to version 2.1, thus would > require the support for vHost-cuse. Most general reason is > qualification cycles for new

Re: [ovs-dev] [PATCH RFC 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-14 Thread Rogers, Gerald
Pravin, There are some deployments that are using or require older OS distributions using qemu versions prior to version 2.1, thus would require the support for vHost-cuse. Most general reason is qualification cycles for new OS versions. The patch provides compile time support for choosing which

Re: [ovs-dev] [PATCH v2] Add setuptools for Python lib for PyPI

2015-04-14 Thread Ben Pfaff
On Fri, Apr 10, 2015 at 02:57:00PM -0500, Terry Wilson wrote: > This adds very basic support for setuptools so that the OVS Python > lib can be added to PyPI. > > This currently uses the Open vSwitch version number and the > generated dirs.py, though there is no real reason to tie the > Python lib

Re: [ovs-dev] [PATCH 2/2] bridge: Remove redundant call to discover_types().

2015-04-14 Thread Russell Bryant
On 04/14/2015 11:16 AM, Ben Pfaff wrote: > On Wed, Mar 25, 2015 at 10:25:51PM -0700, Ben Pfaff wrote: >> Signed-off-by: Ben Pfaff > > This still needs a review, thanks! Looks good. The call removed from bridge_reconfigure() is an obvious duplicate since it's called just after bridge_reconfigure

[ovs-dev] Bug#782584: openvswitch: NDP is dropped

2015-04-14 Thread Ben Pfaff
On Tue, Apr 14, 2015 at 03:45:12PM +0200, Mikael Frykholm wrote: > Package: openvswitch-common > Version: 2.3.0+git20140819-3 > Severity: important > File: openvswitch > Tags: ipv6 > > Dear Maintainer, > >* What led up to the situation? > Virtual machine running in libvirt stops respoding on

Re: [ovs-dev] [PATCH 2/2] bridge: Remove redundant call to discover_types().

2015-04-14 Thread Ben Pfaff
On Wed, Mar 25, 2015 at 10:25:51PM -0700, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff This still needs a review, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] perf-counter: lower msg level when no perf counter

2015-04-14 Thread Russell Bryant
On 04/14/2015 11:14 AM, Flavio Leitner wrote: > Some arches don't support perf counter and an error message > breaks many tests from the testsuite. Since the software still > runs without it, just inform that perf counters are not available > with using INFO level instead. > > Signed-off-by: Flav

[ovs-dev] [PATCH] perf-counter: lower msg level when no perf counter

2015-04-14 Thread Flavio Leitner
Some arches don't support perf counter and an error message breaks many tests from the testsuite. Since the software still runs without it, just inform that perf counters are not available with using INFO level instead. Signed-off-by: Flavio Leitner --- lib/perf-counter.c | 2 +- 1 file changed

Re: [ovs-dev] [PATCH] ovs-sandbox: add delay before running ovs-vsctl

2015-04-14 Thread Ben Pfaff
On Mon, Apr 13, 2015 at 03:03:53PM -0700, Andy Zhou wrote: > When running ovsdb-server under gdb, there is a race that ovs-vsctl > command can be called before ovsdb-server is fully launched. This will > cause ovs-vsctl to fail. This patch fixes this by delay issuing > the ovs-vsctl command until

Re: [ovs-dev] [PATCH] datapath-windows: extension fails to be enabled

2015-04-14 Thread Sorin Vinturis
Hi Eitan, This change and the other one that you have mentioned were required because the base filtering engine (BFE) is not running at the time the OVS extension is initialized, and DriverEntry is called, nor at FilterAttach. At driver initialization phase the system provider is registered and

Re: [ovs-dev] [PATCH] datapath-windows: extension fails to be enabled

2015-04-14 Thread Sorin Vinturis
Hi Nithin, Please see my answers inline. Thanks, Sorin -Original Message- From: Nithin Raju [mailto:nit...@vmware.com] Sent: Monday, 13 April, 2015 20:55 To: Sorin Vinturis Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH] datapath-windows: extension fails to be enabled > On Apr 9

[ovs-dev] [PATCH v3] poll-loop: Drop malloc() from every poll_block().

2015-04-14 Thread Russell Bryant
The poll_block() function already has some state in thread-specific storage that's used as a registry for all of the fds to poll() on the next time poll_block() gets called. poll_block() was calling malloc() and free() every time it was called to create the pollfd and wevents arrays needed to pass

  1   2   >