Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-24 Thread Panu Matilainen
On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote: Hi all, Just a quick poll: are the resolutions to review comments in this patch acceptable to everyone? If I've missed anything, or are there any additional opens that need to be addressed before it can be merged, just let me know. Thanks in ad

[ovs-dev] [PATCH v2 5/5] datapath-windows: Multiple NBLs support for VXLAN packets

2015-04-24 Thread Sorin Vinturis
Added support for handling multiple NBLs with only one NB when encapsulating VXLAN packets. Signed-off-by: Sorin Vinturis --- v2: Split also the segmented NBL into multiple NBLs. --- datapath-windows/ovsext/Actions.c | 21 - datapath-windows/ovsext/Vxlan.c | 37

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-24 Thread Kavanagh, Mark B
> >On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote: >> Hi all, >> >> Just a quick poll: are the resolutions to review comments in this patch >> acceptable to >everyone? >> >> If I've missed anything, or are there any additional opens that need to be >> addressed >before it can be merged, just let

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-24 Thread Panu Matilainen
Hi, A few comments inline... On 04/21/2015 01:10 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. It adds to the existing infrastructure of vhost-cuse, however disables vhost-cuse ports as the default port type, in favour of vho

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-24 Thread Flavio Leitner
On Fri, 24 Apr 2015 10:32:32 + "Kavanagh, Mark B" wrote: > > > > >On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote: > >> Hi all, > >> > >> Just a quick poll: are the resolutions to review comments in this > >> patch acceptable to > >everyone? > >> > >> If I've missed anything, or are there any

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-24 Thread Flavio Leitner
On Fri, 24 Apr 2015 14:17:17 +0300 Panu Matilainen wrote: > Hi, > > A few comments inline... > > On 04/21/2015 01:10 PM, Ciara Loftus wrote: > > This patch adds support for a new port type to the userspace > > datapath called dpdkvhostuser. It adds to the existing > > infrastructure of vhost-cu

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-24 Thread Thomas F Herbert
On 4/24/15 9:01 AM, Flavio Leitner wrote: On Fri, 24 Apr 2015 14:17:17 +0300 Panu Matilainen wrote: Hi, A few comments inline... On 04/21/2015 01:10 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. It adds to the existing in

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-24 Thread Kavanagh, Mark B
>On Fri, 24 Apr 2015 10:32:32 + >"Kavanagh, Mark B" wrote: > >> >> > >> >On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote: >> >> Hi all, >> >> >> >> Just a quick poll: are the resolutions to review comments in this >> >> patch acceptable to >> >everyone? >> >> >> >> If I've missed anything, or a

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-24 Thread Kavanagh, Mark B
> >>On Fri, 24 Apr 2015 10:32:32 + >>"Kavanagh, Mark B" wrote: >> >>> >>> > >>> >On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote: >>> >> Hi all, >>> >> >>> >> Just a quick poll: are the resolutions to review comments in this >>> >> patch acceptable to >>> >everyone? >>> >> >>> >> If I've missed

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-24 Thread Flavio Leitner
On Fri, 24 Apr 2015 09:24:01 -0400 Thomas F Herbert wrote: > On 4/24/15 9:01 AM, Flavio Leitner wrote: > > On Fri, 24 Apr 2015 14:17:17 +0300 > > Panu Matilainen wrote: > > > >> Hi, > >> > >> A few comments inline... > >> > >> On 04/21/2015 01:10 PM, Ciara Loftus wrote: > >>> This patch adds sup

Re: [ovs-dev] [PATCHv3] DPDK: add support for v2.0.0

2015-04-24 Thread Flavio Leitner
On Fri, 24 Apr 2015 14:04:05 + "Kavanagh, Mark B" wrote: > > > >>On Fri, 24 Apr 2015 10:32:32 + > >>"Kavanagh, Mark B" wrote: > >> > >>> > >>> > > >>> >On 04/23/2015 11:58 PM, Kavanagh, Mark B wrote: > >>> >> Hi all, > >>> >> > >>> >> Just a quick poll: are the resolutions to review comm

Re: [ovs-dev] [PATCH RFC v2 1/1] netdev-dpdk: add dpdk vhost-user ports

2015-04-24 Thread Panu Matilainen
On 04/24/2015 04:01 PM, Flavio Leitner wrote: On Fri, 24 Apr 2015 14:17:17 +0300 Panu Matilainen wrote: Hi, A few comments inline... On 04/21/2015 01:10 PM, Ciara Loftus wrote: This patch adds support for a new port type to the userspace datapath called dpdkvhostuser. It adds to the existin

[ovs-dev] [PATCH ovn 0/2] Update Fedora packaging for OVN.

2015-04-24 Thread Russell Bryant
[PATCH 1/2] Add ovn-ctl to assist with OVN daemon lifecycle. [PATCH 2/2] fedora.spec: Create openvswitch-ovn package. ovn/automake.mk | 1 ovn/utilities/.gitignore| 1 ovn/uti

[ovs-dev] [PATCH ovn 1/2] Add ovn-ctl to assist with OVN daemon lifecycle.

2015-04-24 Thread Russell Bryant
This patch introduces ovn-ctl, which is similar to ovs-ctl. I opted for a new script as everything in OVN so far is nicely isolated, so a new script seemed to make the most sense. ovn-ctl supports a few different scenarios. If you'd like to run ovn-controller on a host already running ovs:

[ovs-dev] [PATCH ovn 2/2] fedora.spec: Create openvswitch-ovn package.

2015-04-24 Thread Russell Bryant
This patch creates a new subpackage for OVN, openvswitch-ovn. It also installs systemd unit files for ovncontroller and ovnnorthd services. Finally, it installs some template service configuration files into /etc/sysconfig/. If you want to run ovn-controller on a host running ovs: # systemct

Re: [ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-24 Thread Pravin Shelar
On Thu, Apr 23, 2015 at 12:11 PM, Pravin Shelar wrote: > On Thu, Apr 23, 2015 at 11:55 AM, Jesse Gross wrote: > >> I'm a little nervous about orphaning the packets in this case since it >> can potentially affect socket accounting and from a high level, >> there's no logical reason to do so (i.e.

[ovs-dev] NEW goods for weight loss! Your weight decrease by 5kg (12 lb) per week

2015-04-24 Thread Monty Rossi
Stop devouring these doughnuts and sweet pies! You are ruining your future! I want you to try this because it worked for me. We have massive selection of pharmaceuticals which will for sure help you! http://zzb.bz/b6k3T ___ dev mailing list dev@openvswi

[ovs-dev] [PATCH] Allow subclasses of Idl to define a notification hook

2015-04-24 Thread Terry Wilson
It is useful to make the notification events that Idl processes accessible to users of the library. This will make it possible to keep external systems in sync, but does not impose any particular notification pattern. The Row.from_json() call is added to be able to convert the 'old' JSON response

Re: [ovs-dev] [PATCH 2/3] datapath: Prefix each public function in linux/compat/ with rpl_.

2015-04-24 Thread Jesse Gross
On Tue, Apr 21, 2015 at 3:20 PM, Alex Wang wrote: > diff --git a/datapath/linux/compat/flow_dissector.c > b/datapath/linux/compat/flow_dissector.c > index a68f84f..c6644a5 100644 > --- a/datapath/linux/compat/flow_dissector.c > +++ b/datapath/linux/compat/flow_dissector.c > @@ -232,4 +232,5 @@ u3

Re: [ovs-dev] [PATCH 2/3] datapath: Prefix each public function in linux/compat/ with rpl_.

2015-04-24 Thread Alex Wang
Thx a lot for the comments~ For the second comment, yes, Iet's make ovs_ prefix also available. For the first comment, yes, I need to add a check that grep for all 'EXPORT_SYMBOL_GPL' lines and make sure the symbol is either rpl_ or ovs_ prefixed. How about it~? Thanks, Alex Wang, On Fri, Apr

Re: [ovs-dev] [PATCH 2/3] datapath: Prefix each public function in linux/compat/ with rpl_.

2015-04-24 Thread Jesse Gross
Sounds good to me - I see that that symbol that I pointed out (__skb_get_hash) is defined by a macro and as a result doesn't get picked up by you function check, whereas most cases would be. However, still seems nice to have an explicit check for exported symbols. On Fri, Apr 24, 2015 at 2:28 PM,

Re: [ovs-dev] [PATCH 2/3] datapath: Prefix each public function in linux/compat/ with rpl_.

2015-04-24 Thread Alex Wang
Yeah, I'll update the code accordingly and resend the whole series, Thanks, Alex Wang, On Fri, Apr 24, 2015 at 2:36 PM, Jesse Gross wrote: > Sounds good to me - I see that that symbol that I pointed out > (__skb_get_hash) is defined by a macro and as a result doesn't get > picked up by you fun

Re: [ovs-dev] [PATCH 3/3] datapath: Check the export of public functions in linux/compat/linux/.

2015-04-24 Thread Jesse Gross
On Tue, Apr 21, 2015 at 3:20 PM, Alex Wang wrote: > This commit adds check in datapath/Makefile to make sure that all public > functions in linux/compat/ are all rpl_ prefixed and exported, except > those in compat/build-aux/export-check-whitelist. > > Signed-off-by: Alex Wang This looks good to

Re: [ovs-dev] sFlow extension for tunnels / MPLS - question about user-space flow-cache

2015-04-24 Thread Jesse Gross
On Thu, Apr 23, 2015 at 9:06 PM, Neil McKee wrote: > I looked into what it would take to have the kernel pass up the actions when > it samples a packet. The changes seemed straightforward (see attached > diff) and worked well. I prefer this approach because: > > (1) These really are the action

[ovs-dev] [PATCH] ovn-northd: Fix treatment of ports with unknown MACs.

2015-04-24 Thread Ben Pfaff
Ports with unknown MACs are a per-lswitch concept but the code here was treating them as global and also dereferenced a null pointer (generally 'lport' was null in the expression 'lswitch->lport'). Reported-by: Alex Wang Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 47 ++

[ovs-dev] [PATCH ovn v3 00/10] first flows out of ovn-controller

2015-04-24 Thread Ben Pfaff
v1->v2: Add patch 5. v2->v3: Break patch 5 into a series of 6 patches, each of which actually makes sense and is ready for review. Ben Pfaff (10): ovn-sb.xml: Revise description of "actions" to match my current thoughts. ovn-northd: Port security allows receiving packets to multicast

[ovs-dev] [PATCH ovn v3 01/10] ovn-sb.xml: Revise description of "actions" to match my current thoughts.

2015-04-24 Thread Ben Pfaff
This is what I'm in the midst of implementing, and what ovn-northd uses. Reported-by: Justin Pettit Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 11 ++ ovn/ovn-sb.xml | 89 --- 2 files changed, 40 insertions(+), 60 deletions

[ovs-dev] [PATCH ovn v3 02/10] ovn-northd: Port security allows receiving packets to multicast/broadcast.

2015-04-24 Thread Ben Pfaff
Otherwise ARP and other broadcast protocols would be problematic. Reported-by: Justin Pettit Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c |3 +++ ovn/ovn-nb.xml |3 ++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ov

[ovs-dev] [PATCH ovn v3 05/10] lex: New functions lex_lookahead() and lexer_match_id().

2015-04-24 Thread Ben Pfaff
These functions will have their first users in upcoming commits. Signed-off-by: Ben Pfaff --- ovn/lib/lex.c | 28 ovn/lib/lex.h |2 ++ 2 files changed, 30 insertions(+) diff --git a/ovn/lib/lex.c b/ovn/lib/lex.c index 73f0ca3..fe11b72 100644 --- a/ovn/lib/lex.

[ovs-dev] [PATCH ovn v3 06/10] ovn-northd: Set logical_datapath in each Bindings record.

2015-04-24 Thread Ben Pfaff
Without a logical_datapath, ovn-controller won't be able to tell which logical datapath a logical port belongs to, thus it won't be able to implement logical flows related to the logical port. Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 14 ++ 1 file changed, 14 insertio

[ovs-dev] [PATCH ovn v3 09/10] ovn: New module for parsing OVN actions as OpenFlow.

2015-04-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/lib/actions.c | 242 +++ ovn/lib/actions.h | 38 ovn/lib/automake.mk |2 + ovn/lib/expr.c | 179 + ovn/lib/expr.h | 15 +++- ovn/ovn-sb.xml |

[ovs-dev] [PATCH ovn v3 10/10] ovn-controller: Implement translation of OVN flows into OpenFlow.

2015-04-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/controller/automake.mk |4 +- ovn/controller/ovn-controller.c |4 + ovn/controller/pipeline.c | 373 +++ ovn/controller/pipeline.h | 26 +++ ovn/ovn-sb.ovsschema|2 +- 5 files changed,

[ovs-dev] [PATCH ovn v3 03/10] ovn: Back off on port_security specification and implementation.

2015-04-24 Thread Ben Pfaff
The implementation of port_security was partial, and the specification was vague. This reduces both to what was actually meant to be supported at this point. It shouldn't be hard to fully implement port security when we have a clear specification. Reported-by: Justin Pettit Signed-off-by: Ben P

[ovs-dev] [PATCH ovn v3 04/10] ovn-nb: Mark some features as not yet implemented.

2015-04-24 Thread Ben Pfaff
Reported-by: Justin Pettit Signed-off-by: Ben Pfaff --- ovn/ovn-nb.xml | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/ovn/ovn-nb.xml b/ovn/ovn-nb.xml index 2335349..2c6f7f8 100644 --- a/ovn/ovn-nb.xml +++ b/ovn/ovn-nb.xml @@ -219,12 +219,24 @@

[ovs-dev] [PATCH ovn v3 07/10] ovn: Add tunnel_key concept to Bindings table, assign in ovn-northd.

2015-04-24 Thread Ben Pfaff
When packets travel among nodes in OVN over tunnels, a tunnel key value is needed to convey the logical port to which the packet is destined. This commit adds a tunnel_key column to the Bindings table and adds code to ovn-northd to assign a unique tunnel_key value to each logical port. Signed-off

[ovs-dev] [PATCH ovn v3 08/10] expr: Make expr_to_flows() include conj_id flows.

2015-04-24 Thread Ben Pfaff
When I wrote expr_to_flows() originally, I assumed that the caller could simply add an appropriate conj_id=X flow for each of the conjunctive matches. I forgot that the conj_id=X flows also need to include prerequisites for actions, e.g. if the OpenFlow actions manipulate TCP fields, then the conj

Re: [ovs-dev] [PATCH ovn v2 0/5] first flows out of ovn-controller

2015-04-24 Thread Ben Pfaff
On Wed, Apr 22, 2015 at 10:09:48PM -0700, Ben Pfaff wrote: > This adds a fifth patch to my earlier series from today, that starts to > generate OpenFlow flows out of ovn-controller. That's way premature for > review, but I still feel like posting it. > > v1->v2: Add patch 5. This series is super

Re: [ovs-dev] [PATCH v7] datapath: Add Stateless TCP Tunneling protocol.

2015-04-24 Thread Jesse Gross
On Fri, Apr 24, 2015 at 11:25 AM, Pravin Shelar wrote: > On Thu, Apr 23, 2015 at 12:11 PM, Pravin Shelar wrote: >> On Thu, Apr 23, 2015 at 11:55 AM, Jesse Gross wrote: >> >>> I'm a little nervous about orphaning the packets in this case since it >>> can potentially affect socket accounting and f

Re: [ovs-dev] [PATCH RFC 0/1] dpif-netdev: Make EMC Size Configurable

2015-04-24 Thread Jesse Gross
On Thu, Apr 23, 2015 at 1:19 AM, Mark D. Gray wrote: > On 04/22/15 22:18, Jesse Gross wrote: >> >> On Wed, Apr 22, 2015 at 1:15 AM, mark.d.gray >> wrote: >>> >>> Pravin Shelar wrote: On Tue, Apr 21, 2015 at 7:30 PM, Jesse Gross wrote: > On Tue, Apr 21, 2015 at 7:23 PM, Pra

[ovs-dev] [PATCH] utilities: Add new pipeline generator script.

2015-04-24 Thread Ethan Jackson
When doing OVS performance testing, it's important to have both realistic traffic traces and OpenFlow pipelines on which to evaluate prospective changes. As a first step in this direction, this patch adds a python script which generates an OpenFlow pipeline intended to simulate typical network vir

[ovs-dev] Pending Delivery

2015-04-24 Thread FedEx Express Delivery
View Attached For Details --- This email has been checked for viruses by Avast antivirus software. http://www.avast.com ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev