Instance PID is already deleted in the OvsCleanupPacketQueue function.
Signed-off-by: Sorin Vinturis svintu...@cloudbasesolutions.com
Acked-by: Nithin Raju nit...@vmware.com
---
v2: Rebased the patch.
v3: Added ack.
---
datapath-windows/ovsext/User.c | 6 --
1 file changed, 6 deletions(-)
Hi Nithin,
Sorry, I come late on this one, change looks good.
We need to check if the IRP output buffer is big enough to fit the transaction
message before copying it. Otherwise, we need to return error and break the
NetLink connection.
Thanks,
Eitan
-Original Message-
From: dev
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/controller/automake.mk | 4 +-
ovn/controller/ovn-controller.c | 4 +
ovn/controller/pipeline.c | 373
ovn/controller/pipeline.h | 26 +++
ovn/ovn-sb.ovsschema| 2 +-
5
rconn_get_connection_seqno() is documented to change only when an rconn
connects or disconnnects, but in fact it was also changing whenever an
rconn went into or out of the idle state (following sending an echo
request). This fixes the problem.
rconn_get_connection_seqno() didn't have any
When I wrote expr_to_flows() originally, I assumed that the caller could
simply add an appropriate conj_id=X flow for each of the conjunctive
matches. I forgot that the conj_id=X flows also need to include
prerequisites for actions, e.g. if the OpenFlow actions manipulate TCP
fields, then the
This is documented in ovn-architecture(7).
Signed-off-by: Ben Pfaff b...@nicira.com
---
tutorial/ovs-sandbox | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tutorial/ovs-sandbox b/tutorial/ovs-sandbox
index 8aa2ddd..4ab960b 100755
--- a/tutorial/ovs-sandbox
+++
On Wed, Apr 29, 2015 at 03:41:00PM +, Nithin Raju wrote:
As you know, the Windows kernel is synchronous in terms of netlink
messages. Transaction semantics are implemented in one call that
includes both the “request” and the “reply” in one shot. So, if
there’s a mismatch, it implies
On Tue, Apr 28, 2015 at 4:28 PM, Jesse Gross je...@nicira.com wrote:
On Mon, Apr 27, 2015 at 2:04 PM, Pravin B Shelar pshe...@nicira.com wrote:
diff --git a/datapath/linux/compat/include/net/stt.h
b/datapath/linux/compat/include/net/stt.h
new file mode 100644
index 000..96181fd
---
On Thu Mar 19 11:48:13 PDT 2015, Ciara Loftus wrote:
-`ovs-vsctl add-port br0 dpdkvhost0 -- set Interface dpdkvhost0
type=dpdkvhost`
+ - For vhost-user (default), the name of the port type is
`dpdkvhostuser`
-Unlike DPDK ring ports, DPDK vhost ports can have arbitrary names:
+
When packets travel among nodes in OVN over tunnels, a tunnel key value is
needed to convey the logical port to which the packet is destined. This
commit adds a tunnel_key column to the Bindings table and adds code to
ovn-northd to assign a unique tunnel_key value to each logical port.
On Apr 29, 2015, at 6:34 AM, Russell Bryant rbry...@redhat.com wrote:
I wonder how realistic it would be to have 65k ports and hit this as a
limit. If your deployment has many containers in each VM, it seems like
we could hit that much more quickly than traditionally seen before.
I had
This implementation is really simple, but it seems effective enough in my
minimal testing.
We still need code to generate flows for logical-to-physical and
physical-to-logical translation. With that, plus code to set up tunnels,
we should be able to start end-to-end testing.
Signed-off-by: Ben
As you know, the Windows kernel is synchronous in terms of netlink
messages. Transaction semantics are implemented in one call that
includes both the “request” and the “reply” in one shot. So, if
there’s a mismatch, it implies the kernel bungled the ‘nlmsg_seq’. So,
the assert was added to
On 04/29/2015 12:22 PM, Justin Pettit wrote:
On Apr 29, 2015, at 6:34 AM, Russell Bryant rbry...@redhat.com wrote:
I wonder how realistic it would be to have 65k ports and hit this as a
limit. If your deployment has many containers in each VM, it seems like
we could hit that much more
I agree with your comment.
The error handling was in place since we were doing the whole “netlink
emulation” with any OS support unlike Linux, and we wanted to catch issues
in release builds also.
If you are not very particular, can I let the code be? Once the code matures
more, we
On Wed, Apr 29, 2015 at 02:37:43PM -0400, Russell Bryant wrote:
On 04/29/2015 01:45 PM, Alex Wang wrote:
Old version of python does not support the following conditional
statement syntax in one assignment:
var = value1 if cond1 else value2
This commit fixes it by convert it back
On Tue, Apr 28, 2015 at 10:03 AM, Alin Serdean
aserd...@cloudbasesolutions.com wrote:
This commit is a POC on how to build the installer from the command line.
One could issue the following commands to build the binaries, driver and
installer.
./boot.sh;./configure CC=./build-aux/cccl
Obesity should be stopped at initiatory stage before it brings harm to your
health!
There's no better product on the market.
Our most popular pharmacy products are sold out at unbelievable prices! Hurry
up!
http://zzb.bz/yZPJu
___
dev mailing list
On Tue, Apr 28, 2015 at 10:03 AM, Alin Serdean
aserd...@cloudbasesolutions.com wrote:
Add testsuite.tmp.orig to .gitignore
Signed-off-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
Do you still need this patch on tip of the master?
---
.gitignore | 1 +
1 file changed, 1
A 'git am' of this patch does not apply at my end. It is corrupted.
Does it apply at your end?
I figured out the reason for the corruption.
---
v3: use git commit --amend --author to change the author
v2: Change author to Alessandro Pilotti. Add windows/automake.mk
You need to add a --- at
No ignore v2/v3. V4 is the latest now.
I will wait for Nithin comments and spin v5 together with the comments you
pointed out also.
Thanks,
Alin.
From: Gurucharan Shettymailto:shet...@nicira.com
Sent: 4/29/2015 11:04 PM
To: Alin
On Tue, Apr 28, 2015 at 06:31:57PM -0700, Ben Pfaff wrote:
On Fri, Apr 24, 2015 at 03:34:50PM -0700, Ben Pfaff wrote:
v1-v2: Add patch 5.
v2-v3: Break patch 5 into a series of 6 patches, each of which actually
makes sense and is ready for review.
I've applied patches 1 through 6 to the
On 04/29/2015 01:45 PM, Alex Wang wrote:
Old version of python does not support the following conditional
statement syntax in one assignment:
var = value1 if cond1 else value2
This commit fixes it by convert it back to use two assignments.
Signed-off-by: Alex Wang al...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
An upcoming patch will add the first user.
Signed-off-by: Ben Pfaff b...@nicira.com
---
lib/match.h | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/match.h b/lib/match.h
index 6633304..638c49d 100644
--- a/lib/match.h
+++ b/lib/match.h
@@ -1,5 +1,5 @@
/*
- *
I've been using the script successfully for the past few days, so
Acked-by: Daniele Di Proietto diproiet...@vmware.com
I have a few comments (I feel ridiculous being so picky about a python
script, so feel free to apply/ignore them).
Would we care about making it run also with python3? Only 3
v1-v2: Add patch 5.
v2-v3: Break patch 5 into a series of 6 patches, each of which actually
makes sense and is ready for review.
v3-v4: Drop patches 1 to 6 because they were applied. Update patch 3
based on Justin's comments (changing resubmit to next). Add patches
5 through 9 (patch 5 is
Old version of python does not support the following conditional
statement syntax in one assignment:
var = value1 if cond1 else value2
This commit fixes it by convert it back to use two assignments.
Signed-off-by: Alex Wang al...@nicira.com
---
tests/test-ovsdb.py |5 -
1 file
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/lib/actions.c | 242
ovn/lib/actions.h | 38 +
ovn/lib/automake.mk | 2 +
ovn/lib/expr.c | 179 ++
ovn/lib/expr.h | 15 +++-
On Wed, Apr 29, 2015 at 09:34:42AM -0400, Russell Bryant wrote:
On 04/28/2015 09:11 PM, Ben Pfaff wrote:
On Tue, Apr 28, 2015 at 05:36:50PM -0700, Justin Pettit wrote:
On Apr 28, 2015, at 5:21 PM, Ben Pfaff b...@nicira.com wrote:
On Tue, Apr 28, 2015 at 03:53:03PM -0400, Russell Bryant
You won't marry a real prince until you get rid of some kilos of your weight!
It is better that the other processed rubbish on the market.
Our Giant Sale season Starts today!
http://zzb.bz/afcGB
___
dev mailing list
dev@openvswitch.org
On Tue, Apr 28, 2015 at 3:36 PM, Alin Serdean
aserd...@cloudbasesolutions.com wrote:
Change the documentation for the possible vaues of WDK.
Signed-off-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
The documentation has to be changed at the same place that you modify the code.
---
On Wed, Apr 29, 2015 at 01:35:44PM -0700, Joe Stringer wrote:
Don't print each symbol that is iterated.
Make the error message more clear by prefixing error: .
Signed-off-by: Joe Stringer joestrin...@nicira.com
Thanks!
Acked-by: Ben Pfaff b...@nicira.com
(I didn't test it.)
On 4/26/15 2:34 PM, Thomas F Herbert wrote:
From: Thomas F. Herbert thomasfherb...@gmail.com
This test tests the user space actions for 802.1q and 802.1ad.
This test was originally contributed by Dave Benson.
Dave,
Could you please review the following and if it is OK, add your signoff
to
On Wed, Apr 29, 2015 at 2:07 PM, Gurucharan Shetty shet...@nicira.com wrote:
On Tue, Apr 28, 2015 at 3:33 PM, Alin Serdean
aserd...@cloudbasesolutions.com wrote:
From: Alessandro Pilotti apilo...@cloudbasesolutions.com
This commit adds the windows installer to the OVS tree.
Requirements are
I sent a patch:
http://openvswitch.org/pipermail/dev/2015-April/054820.html
On 29 April 2015 at 07:43, Ben Pfaff b...@nicira.com wrote:
When I do a make in a clean build directory, I now get a lot of extra
spew, quoted below. I assume this is an unintentional side effect of
the export checks?
This RFC patch makes use of the vhost-user implementation that is
available in DPDK 2.0. Submitting as RFC as this implementation
depends on OVS support for DPDK 2.0. As such, this patch can be
considered experimental.
Since DPDK 2.0 support is necessary for vhost-user, please use this
patch to
This patch adds support for a new port type to the userspace
datapath called dpdkvhostuser. It adds to the existing
infrastructure of vhost-cuse, however disables vhost-cuse ports
as the default port type, in favour of vhost-user ports.
vhost-cuse 'dpdkvhost' ports are still available and can be
Don't print each symbol that is iterated.
Make the error message more clear by prefixing error: .
Signed-off-by: Joe Stringer joestrin...@nicira.com
---
datapath/Makefile.am |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/datapath/Makefile.am b/datapath/Makefile.am
Applied to master~
We'll discuss more over dropping the support of those old os~
Thanks,
Alex Wang,
On Wed, Apr 29, 2015 at 12:15 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Apr 29, 2015 at 02:37:43PM -0400, Russell Bryant wrote:
On 04/29/2015 01:45 PM, Alex Wang wrote:
Old version of
On Wed, Apr 29, 2015 at 1:14 PM, Alin Serdean
aserd...@cloudbasesolutions.com wrote:
No ignore v2/v3. V4 is the latest now.
I see. For some reason, I got a bunch of duplicate v3s yesterday.
Just so that we are clear, I meant to say whether ignoring
testsuite.tmp.orig is still needed if you clone
On 29 April 2015 at 13:52, Ben Pfaff b...@nicira.com wrote:
On Wed, Apr 29, 2015 at 01:35:44PM -0700, Joe Stringer wrote:
Don't print each symbol that is iterated.
Make the error message more clear by prefixing error: .
Signed-off-by: Joe Stringer joestrin...@nicira.com
Thanks!
Acked-by:
6.40 filter will fail to register itself on Windows Server 2012 and will get
unloaded.
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, April 29, 2015 3:12 PM
To: Eitan Eliahu
Cc: Alin Serdean; Gurucharan Shetty; dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v2 1/3]
On Tue, Apr 28, 2015 at 10:03 AM, Alin Serdean
aserd...@cloudbasesolutions.com wrote:
Add testsuite.tmp.orig to .gitignore
Signed-off-by: Alin Gabriel Serdean aserd...@cloudbasesolutions.com
I applied just this patch to master. Thanks!
---
.gitignore | 1 +
1 file changed, 1 insertion(+)
On Apr 29, 2015, at 3:04 PM, Eitan Eliahu elia...@vmware.com wrote:
Actually, both version should be available for the installer. It should query
the OS type and install the appropriate driver.
But, unless there is a good reason for registering as 6.40 we could register
as 6.30 with the
On 04/28/2015 08:05 PM, Ben Pfaff wrote:
On Tue, Apr 28, 2015 at 03:34:31PM -0400, Russell Bryant wrote:
On 04/24/2015 06:34 PM, Ben Pfaff wrote:
These functions will have their first users in upcoming commits.
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/lib/lex.c | 28
On 04/28/2015 09:11 PM, Ben Pfaff wrote:
On Tue, Apr 28, 2015 at 05:36:50PM -0700, Justin Pettit wrote:
On Apr 28, 2015, at 5:21 PM, Ben Pfaff b...@nicira.com wrote:
On Tue, Apr 28, 2015 at 03:53:03PM -0400, Russell Bryant wrote:
The code here looks correct and I also tested it. I was just
On Wed, Apr 29, 2015 at 5:58 AM, Sorin Vinturis
svintu...@cloudbasesolutions.com wrote:
The extension failed to be activated during booting due to the
failure to initialize tunnel filter. This happened because the Base
Filtering Engine (BFE) is not started and no session to the engine
could be
Thanks for the review.
On Apr 29, 2015, at 6:06 AM, Eitan Eliahu elia...@vmware.com wrote:
Hi Nithin,
Sorry, I come late on this one, change looks good.
We need to check if the IRP output buffer is big enough to fit the
transaction message before copying it. Otherwise, we need to
On Wed, Apr 29, 2015 at 02:50:24PM +, Nithin Raju wrote:
On Apr 29, 2015, at 7:45 AM, Ben Pfaff b...@nicira.com wrote:
On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote:
In this patch, we make changes to usersapce as well as
kernel datapath on hyperv to make it more
On Apr 29, 2015, at 7:27 AM, Gurucharan Shetty shet...@nicira.com wrote:
On Tue, Apr 28, 2015 at 11:49 PM, Sorin Vinturis
svintu...@cloudbasesolutions.com wrote:
Instance PID is already deleted in the OvsCleanupPacketQueue function.
Signed-off-by: Sorin Vinturis
When I do a make in a clean build directory, I now get a lot of extra
spew, quoted below. I assume this is an unintentional side effect of
the export checks?
ovs-build-all _build
make: Entering directory '/home/blp/nicira/ovs/_build'
make all-recursive
make[1]: Entering
On Tue, Apr 28, 2015 at 11:49 PM, Sorin Vinturis
svintu...@cloudbasesolutions.com wrote:
Instance PID is already deleted in the OvsCleanupPacketQueue function.
Signed-off-by: Sorin Vinturis svintu...@cloudbasesolutions.com
Acked-by: Nithin Raju nit...@vmware.com
This patch had already been
On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote:
In this patch, we make changes to usersapce as well as
kernel datapath on hyperv to make it more netlink socket
like. Previously, the kernel datapath did not distinguish
between transport errors and other errors. Netlink
semantics
On Tue, Apr 28, 2015 at 03:29:29PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Apr 29, 2015, at 7:45 AM, Ben Pfaff b...@nicira.com wrote:
On Tue, Apr 28, 2015 at 02:35:37PM -0700, Nithin Raju wrote:
In this patch, we make changes to usersapce as well as
kernel datapath on hyperv to make it more netlink socket
like. Previously, the kernel datapath did not
It seems that GosenChien (CCed) deserves credit for reporting this
problem; he has been discussing it on the list for a while.
GosenChien, will you test that this fixes the problem you see?
Thanks,
Ben.
On Tue, Apr 28, 2015 at 03:34:26PM -0700, Alex Wang wrote:
From: Edwin Chiu
On Apr 24, 2015, at 3:34 PM, Ben Pfaff b...@nicira.com wrote:
When I wrote expr_to_flows() originally, I assumed that the caller could
simply add an appropriate conj_id=X flow for each of the conjunctive
matches. I forgot that the conj_id=X flows also need to include
prerequisites for
In one of the review threads, we were discussing how we should make use of the
metadata in the tunnels. The patches that Ben has sent out goes the route of
having each logical port have a unique tunnel key. I had envisioned a
different approach, so I thought it would be worth starting a
On Apr 29, 2015, at 10:12 AM, Ben Pfaff b...@nicira.com wrote:
When packets travel among nodes in OVN over tunnels, a tunnel key value is
needed to convey the logical port to which the packet is destined. This
commit adds a tunnel_key column to the Bindings table and adds code to
On Apr 29, 2015, at 10:12 AM, Ben Pfaff b...@nicira.com wrote:
When I wrote expr_to_flows() originally, I assumed that the caller could
simply add an appropriate conj_id=X flow for each of the conjunctive
matches. I forgot that the conj_id=X flows also need to include
prerequisites for
On Apr 28, 2015, at 2:56 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 27, 2015 at 10:14:46PM -0700, Justin Pettit wrote:
The integration bridge will be needed by other components soon, so make
it part of the general ovn-controller context.
Signed-off-by: Justin Pettit
On Apr 28, 2015, at 2:58 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 27, 2015 at 10:14:47PM -0700, Justin Pettit wrote:
Signed-off-by: Justin Pettit jpet...@nicira.com
Wouldn't it be better to support this? I agree with documenting current
behavior but I'd prefer to fix it in the
On Apr 28, 2015, at 2:59 PM, Ben Pfaff b...@nicira.com wrote:
On Mon, Apr 27, 2015 at 10:14:48PM -0700, Justin Pettit wrote:
Tunnels create a lot of interfaces without an external-id:iface-id, so
logging each interface missing one (even at debug) seems unnecessary.
Signed-off-by: Justin
On Mon, Apr 20, 2015 at 12:37 PM, Mark Kavanagh
mark.b.kavan...@intel.com wrote:
Update relevant artifacts to add support for DPDK v2.0.0
- INSTALL.DPDK.md
- travis build script
- acinclude.m4: add 'mssse3' flag to OVS_CFLAGS
- netdev-dpdk: fix build with unified offload types in DPDK
On Wed, Apr 29, 2015 at 06:19:48PM -0700, Justin Pettit wrote:
On Apr 29, 2015, at 10:12 AM, Ben Pfaff b...@nicira.com wrote:
When I wrote expr_to_flows() originally, I assumed that the caller could
simply add an appropriate conj_id=X flow for each of the conjunctive
matches. I
Besides that LG.
Thanks,
Eitan
-Original Message-
From: Nithin Raju
Sent: Wednesday, April 29, 2015 7:38 AM
To: Eitan Eliahu
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH v3] ovs-hyperv: make kernel return values netlink
socket like
Thanks for the review.
On Apr 29, 2015, at
We will fix the transaction error message copy in the kernel in a separate
change.
Thanks,
Eitan
-Original Message-
From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff
Sent: Wednesday, April 29, 2015 7:45 AM
To: Nithin Raju
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev]
68 matches
Mail list logo
