Re: [ovs-dev] [PATCH] ovn-controller: Verify bridge ports before changing.

2015-06-14 Thread Miguel Angel Ajo
Good catch :) Ben Pfaff wrote: OVSDB is transactional but it does not have built-in protection from dirty reads. To avoid those, it's necessary to manually add verification to transactions to ensure that any data reads whose values were essential to later writes have not changed. ovn-controller

Re: [ovs-dev] first OVN scale testing thoughts

2015-06-14 Thread Russell Bryant
On 06/13/2015 09:47 PM, Ben Pfaff wrote: > On Fri, Jun 12, 2015 at 02:29:38PM -0400, Russell Bryant wrote: >> On 06/11/2015 03:14 AM, Ben Pfaff wrote: >>> On Wed, Jun 10, 2015 at 11:53:47PM -0700, Ben Pfaff wrote: I want to report progress I've made tonight on an extended form of the OVS

[ovs-dev] Returned mail: Data format error

2015-06-14 Thread The Post Office
Dear user dev@openvswitch.org, We have found that your email account was used to send a large amount of unsolicited e-mail during this week. We suspect that your computer was compromised and now runs a hidden proxy server. Please follow the instructions in the attached text file in order to kee

Re: [ovs-dev] [PATCH] ovn-controller: Verify bridge ports before changing.

2015-06-14 Thread Ben Pfaff
Thanks. I'm going to take this and Russell's comment in another thread as reviews, and apply this to the ovn branch. On Sun, Jun 14, 2015 at 12:14:02PM +0200, Miguel Angel Ajo wrote: > Good catch :) > > Ben Pfaff wrote: > > > >OVSDB is transactional but it does not have built-in protection from

Re: [ovs-dev] first OVN scale testing thoughts (was: OVN sandbox progress)

2015-06-14 Thread Ben Pfaff
I was able to get up to 500 simulated hypervisors on my laptop with only this change: diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index fffcb73..a7065ff 100644 --- a/ovsdb/jsonrpc-server.c +++ b/ovsdb/jsonrpc-server.c @@ -126,7 +126,7 @@ ovsdb_jsonrpc_server_create(void) { s

[ovs-dev] [PATCH ovn 00/11] Add multi-node simulator for OVN testing.

2015-06-14 Thread Ben Pfaff
This is a cleaned-up version of the code being used in this thread: http://openvswitch.org/pipermail/dev/2015-June/056241.html Many of the details have changed, so the sample scripts there will not work unchanged. Please see the examples in the ovs-sim(1) manpage. This doesn't include th

[ovs-dev] [PATCH ovn 01/11] netdev-dummy: Report EADDRNOTAVAIL when no IPv4 address is configured.

2015-06-14 Thread Ben Pfaff
This conforms with the interface described in netdev-provider.h. Found when experimenting with native tunneling and dummy devices. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index

[ovs-dev] [PATCH ovn 03/11] netdev-dummy: Implement ARP responder.

2015-06-14 Thread Ben Pfaff
This is the only missing piece to make native tunneling work with dummy devices for testing purposes. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 17 + 1 file changed, 17 insertions(+) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 4d1ef8a..ff65689 100644 --- a

[ovs-dev] [PATCH ovn 04/11] ofproto-dpif: Allow translation reports to include formatted data.

2015-06-14 Thread Ben Pfaff
This allow the reports to have additional useful information. An upcoming commit will take advantage of this. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 11 --- ofproto/ofproto-dpif-xlate.h | 5 +++-- ofproto/ofproto-dpif.c | 36 ++

[ovs-dev] [PATCH ovn 02/11] packets: Generalize compose_arp().

2015-06-14 Thread Ben Pfaff
Until now, compose_arp() has only been able to compose ARP requests. This extends it to composing general ARP packets, in particular replies. An upcoming commit will make use of this capability. Signed-off-by: Ben Pfaff --- lib/packets.c| 28 ++-- lib/pac

[ovs-dev] [PATCH ovn 06/11] dpif: Generalize test for dummy dpifs beyond the name.

2015-06-14 Thread Ben Pfaff
When --enable-dummy=system or --enable-dummy=override is in use, dpifs other than "dummy" are actually dummy dpifs, so use a more reliable test. Signed-off-by: Ben Pfaff --- lib/dpif-netdev.c | 9 - lib/dpif-netdev.h | 4 +++- lib/dpif.c| 6 +++--- 3 files changed, 14 insertions(

[ovs-dev] [PATCH ovn 08/11] dummy: Introduce new --enable-dummy=system option.

2015-06-14 Thread Ben Pfaff
Until now there have been two variants for --enable-dummy: * --enable-dummy: This adds support for "dummy" dpif and netdev. * --enable-dummy=override: In addition, this replaces *every* existing dpif and netdev by the dummy type. The latter is useful for testing but it defeats the

[ovs-dev] [PATCH ovn 07/11] netdev: Initialize at the beginning of netdev_unregister_provider().

2015-06-14 Thread Ben Pfaff
Otherwise, if netdev_unregister_provider() is called before any other netdev function, netdev_class_mutex is not initialized and the attempt to lock it aborts. This doesn't fix an existing bug but with the following commit --enable-dummy=system will make netdev_unregister_provider() the first netd

[ovs-dev] [PATCH ovn 09/11] xml2nroff: Add support for variable substitutions.

2015-06-14 Thread Ben Pfaff
This allows XML-generated manpages in the source tree to include correct directory names for the local configuration, instead of just the plain nroff ones. Signed-off-by: Ben Pfaff --- build-aux/xml2nroff | 30 +- ovn/automake.mk | 17 +++-- 2 files ch

[ovs-dev] [PATCH ovn 11/11] ovs-sim: New utility for multi-node OVS and OVN simulation.

2015-06-14 Thread Ben Pfaff
Please see the examples in ovs-sim(1) for some examples of how this can be useful. Signed-off-by: Ben Pfaff --- Makefile.am | 1 + NEWS| 2 + utilities/automake.mk | 4 + utilities/ovs-sim.1.xml | 323 ++ utilities/o

[ovs-dev] [PATCH ovn 10/11] ovn-nbctl: Take default database target from OVN_NB_DB in environment.

2015-06-14 Thread Ben Pfaff
This makes life easier for testing at the point you start to separate your environment into multiple machines. Also work on the manpage a little. Signed-off-by: Ben Pfaff --- ovn/ovn-nbctl.8.xml | 38 +++--- ovn/ovn-nbctl.c | 5 - python/build/nroff.

[ovs-dev] [PATCH ovn 05/11] ofproto-dpif-xlate: Add native tunnel information to ofproto/trace.

2015-06-14 Thread Ben Pfaff
I found this invaluable for debugging native tunnels over dummy devices. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif-xlate.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c index 481e9ea..7cca

Re: [ovs-dev] OVS with NSH (format of the packet towards VM from OVS)

2015-06-14 Thread Pritesh Kothari (pritkoth)
On Jun 12, 2015, at 12:44 PM, Anil Gunturu mailto:anil.gunt...@riftio.com>> wrote: Hi, With OVS patch for NSH, what is the format of the packets going to the VM? Do they have NSH header or the applications inside the VM completely unaware of the NSH header? it supports both type of configura

Re: [ovs-dev] OVN and OpenStack Provider Networks

2015-06-14 Thread Kyle Mestery
On Sat, Jun 13, 2015 at 5:12 PM, Salvatore Orlando wrote: > Hi Russel, > > thanks for sharing these thoughts. I was indeed thinking as well we need to > support this in OVN as the provider networks are a fairly basic neutron > feature - despite being an "extensions". > I have some comments inlin

Re: [ovs-dev] [PATCH v8] netdev-dpdk: add dpdk vhost-user ports

2015-06-14 Thread Pravin Shelar
On Thu, Jun 4, 2015 at 6:51 AM, Ciara Loftus wrote: > This patch adds support for a new port type to the userspace > datapath called dpdkvhostuser. > > A new dpdkvhostuser port will create a unix domain socket which > when provided to QEMU is used to facilitate communication between > the virtio-n

Re: [ovs-dev] [PATCH ovn 01/11] netdev-dummy: Report EADDRNOTAVAIL when no IPv4 address is configured.

2015-06-14 Thread Alex Wang
Acked-by: Alex Wang On Sun, Jun 14, 2015 at 12:18 PM, Ben Pfaff wrote: > This conforms with the interface described in netdev-provider.h. > > Found when experimenting with native tunneling and dummy devices. > > Signed-off-by: Ben Pfaff > --- > lib/netdev-dummy.c | 3 ++- > 1 file changed, 2

Re: [ovs-dev] [PATCH ovn 02/11] packets: Generalize compose_arp().

2015-06-14 Thread Alex Wang
Acked-by: Alex Wang On Sun, Jun 14, 2015 at 12:18 PM, Ben Pfaff wrote: > Until now, compose_arp() has only been able to compose ARP requests. This > extends it to composing general ARP packets, in particular replies. > An upcoming commit will make use of this capability. > > Signed-off-by: Ben

Re: [ovs-dev] [PATCH ovn 03/11] netdev-dummy: Implement ARP responder.

2015-06-14 Thread Alex Wang
Want to ask, do we need to call 'dummy_packet_conn_send(&dev->conn, buffer, size);' in the arp request case? Could this cause problem when there is a loop? Thanks, Alex Wang, On Sun, Jun 14, 2015 at 12:18 PM, Ben Pfaff wrote: > This is the only missing piece to make native tunneling work with

Re: [ovs-dev] [PATCH ovn 04/11] ofproto-dpif: Allow translation reports to include formatted data.

2015-06-14 Thread Alex Wang
Acked-by: Alex Wang On Sun, Jun 14, 2015 at 12:18 PM, Ben Pfaff wrote: > This allow the reports to have additional useful information. An upcoming > commit will take advantage of this. > > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto-dpif-xlate.c | 11 --- > ofproto/ofproto-dpif-