Re: [ovs-dev] [PATCH] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

2015-06-24 Thread Panu Matilainen
On 06/24/2015 05:06 AM, Pravin Shelar wrote: On Tue, Jun 23, 2015 at 2:51 PM, Jesse Gross je...@nicira.com wrote: On Mon, Jun 22, 2015 at 8:08 PM, Pravin Shelar pshe...@nicira.com wrote: On Fri, Jun 19, 2015 at 11:24 AM, Daniele Di Proietto diproiet...@vmware.com wrote: On 18/06/2015 23:57,

Re: [ovs-dev] [PATCH] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

2015-06-24 Thread Traynor, Kevin
-Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Panu Matilainen Sent: Wednesday, June 24, 2015 9:33 AM To: Pravin Shelar; Jesse Gross Cc: dev@openvswitch.org; Flavio Leitner Subject: Re: [ovs-dev] [PATCH] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

[ovs-dev] [PATCH] datapath-windows: Wrong cleanup of newly created multiple NBLs

2015-06-24 Thread Sorin Vinturis
Bug found in OvsPartialCopyToMultipleNBLs function in the cleanup part of the code. Before completing the current NBL (newNbl) the NEXT link for the following NBL (firstNbl) was broken, instead of the current one (newNbl). This patch is to be applied both on master and on 2.4 branch.

Re: [ovs-dev] [PATCH v9] ovs-ofctl:Implementation of eviction on the basis of Importance

2015-06-24 Thread Saloni Jain
Hi Ben, Thanks, my query has been resolved and the code is updated in version 10 --[PATCH v10] ovs-ofctl:Implementation of eviction on the basis of Importance sent on 17-June-2015. Sending a new patch version 11, rebased with the latest master. Thanks and Regards, Saloni Jain Tata Consultancy

[ovs-dev] [PATCH v11] ovs-ofctl:Implementation of eviction on the basis of Importance

2015-06-24 Thread saloni . jain12
From: Saloni Jain saloni.j...@tcs.com This commit enables the eviction mechanism on the basis of importance as per the openflow specification 1.4. ovs-ofctl -O OpenFlow14 mod-table switch table evict Enable eviction on table of switch. Eviction adds a mechanism enabling the switch to

Re: [ovs-dev] [PATCH 07/11] openflow: Table maintenance commands for Geneve options.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 1:11 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:21PM -0700, Jesse Gross wrote: In parse_ofp_geneve_table_mod_str(), I'd prefer to use %i instead of %x, because one of my long-term goals for OVS is to switch away from this awful scanf() stuff to a

Re: [ovs-dev] [PATCH 3/3] OVSDB: Flush JSON cache only when necessary

2015-06-24 Thread Andy Zhou
On Mon, Jun 22, 2015 at 9:58 AM, Ben Pfaff b...@nicira.com wrote: On Wed, Jun 10, 2015 at 06:37:59PM -0700, Andy Zhou wrote: Currently, JSON cache is always flushed whenever the monitor receives a transaction. This patch improves the JSON cache efficiency by only flush the JSON cache when a

Re: [ovs-dev] [PATCH 09/11] odp-util: Pass down flow netlink attributes when translating masks.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 1:20 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:23PM -0700, Jesse Gross wrote: Sometimes we need to look at flow fields to understand how to parse an attribute. However, masks don't have this information - just the mask on the field. We already

[ovs-dev] [PATCH] tunneling: Don't match on source IP address for native tunnels.

2015-06-24 Thread Jesse Gross
When doing native tunneling, we look at packets destined to the local port to see if they match tunnel protocols that we should intercept. The criteria are IP protocol, destination UDP port, etc. However, we also look at the source IP address of the packets. This should be a function of the

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: The current support for Geneve in OVS is exactly equivalent to VXLAN: it is possible to set and match on the VNI but not on any options contained in the header. This patch enables the use of options. The goal for Geneve support is

Re: [ovs-dev] [PATCH 07/11] openflow: Table maintenance commands for Geneve options.

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 01:52:46PM -0700, Jesse Gross wrote: On Wed, Jun 24, 2015 at 1:45 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:21PM -0700, Jesse Gross wrote: In order to work with Geneve options, we need to maintain a mapping table between an option (defined by

Re: [ovs-dev] [PATCH 08/11] metaflow: Extend size of mf_value to 128 bytes.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 1:17 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:22PM -0700, Jesse Gross wrote: Tunnel metadata can be substantially larger than our existing fields (up to 124 bytes in a single Geneve option) so this extends the size of the data that we can

Re: [ovs-dev] [PATCH 07/11] openflow: Table maintenance commands for Geneve options.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:21PM -0700, Jesse Gross wrote: In order to work with Geneve options, we need to maintain a mapping table between an option (defined by class, type, length) and an NXM field that can be operated on for the purposes of matches, actions, etc. This mapping must be

Re: [ovs-dev] [PATCH 07/11] openflow: Table maintenance commands for Geneve options.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 1:45 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:21PM -0700, Jesse Gross wrote: In order to work with Geneve options, we need to maintain a mapping table between an option (defined by class, type, length) and an NXM field that can be operated on

Re: [ovs-dev] [PATCH 11/11] pkt-metadata: Avoid introducing overhead for userspace tunnels.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:25PM -0700, Jesse Gross wrote: The addition of Geneve metadata requires a large amount of additional space to handle the maximum set of options. In most cases, this is not a big deal since it is only temporary storage on the stack or can be automatically stripped

Re: [ovs-dev] OVN and OpenStack Provider Networks

2015-06-24 Thread Russell Bryant
On 06/23/2015 06:56 PM, Ben Pfaff wrote: On Tue, Jun 23, 2015 at 11:58:25PM +0200, Salvatore Orlando wrote: I'm afraid I have to start bike shedding on this thread too. Apparently that's what I do best. These are important clarifications, not bikeshedding. More below (with lots of

Re: [ovs-dev] [PATCH] dpif-netdev: log port/core affinity

2015-06-24 Thread Kavanagh, Mark B
When using multiple PMDs and numerous ports, a performance gain may be achieved in some use cases by pinning a PMD/port to a particular (set of) core(s). This patch provides a summary of the switch's port/core affinities each time that the status of the switch's ports is modified. Based on this

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-24 Thread Gurucharan Shetty
You can look at commit 5e65e080ad4d57e for more information on the exact problem with taskkill. One option is to check for tskill and if it does not exist, use taskkill. On Tue, Jun 23, 2015 at 6:37 PM, Alin Serdean aserd...@cloudbasesolutions.com wrote: Think I found why tskill is missing on

Re: [ovs-dev] [PATCH 3/4] ovn-integrate: A new OVN utility script.

2015-06-24 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 02:15:49AM -0700, Gurucharan Shetty wrote: Signed-off-by: Gurucharan Shetty gshe...@nicira.com Is this intended exclusively for use with Docker, or is it meant to be more generic? Is the documentation just the Docker installation instructions in the following patch?

Re: [ovs-dev] [PATCH 2/4] ovs-lib: Ability to move ip address and routes.

2015-06-24 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 02:15:48AM -0700, Gurucharan Shetty wrote: The ability to move IP address and routes between two interfaces is useful when we want to make a physical interface (say eth0) as a port of OVS bridge (say breth0) with all its IP address and route information transferred to

Re: [ovs-dev] [PATCH 3/3] Update windows test documentation

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 07:43:03AM -0700, Gurucharan Shetty wrote: On Tue, Jun 23, 2015 at 6:11 PM, Alin Serdean aserd...@cloudbasesolutions.com wrote: How about the following: Before running the unit tests make sure to add the pthread libraries to your PATH environment variable. The

Re: [ovs-dev] [PATCH 0/2] ovn: Add administrative state to logical ports.

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 03:18:57PM -0400, Russell Bryant wrote: On 06/23/2015 02:22 PM, Russell Bryant wrote: While working on OpenStack Neutron integration for OVN, I came across a small feature gap. The Neutron API supports setting a port as administratively down. One way to

Re: [ovs-dev] [PATCH 2/2] ovn: Add get/set-enabled to ovn-nbctl.

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 02:22:09PM -0400, Russell Bryant wrote: This patch adds support for getting and setting the 'enabled' column for logical ports using ovn-nbctl. Signed-off-by: Russell Bryant rbry...@redhat.com Applied, thanks! ___ dev

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 08:11:22AM -0700, Sabyasachi Sengupta wrote: Extend bfd to save wall clock time of the last flap in bfd_forwarding__, and display it throught bfd/show. This information is also exported out to ovsdb in bfd_get_status. Signed-off-by: Sabyasachi Sengupta

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 06:34:05PM -0700, Jesse Gross wrote: On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: I like the implementation approach used in ULONG_FOR_EACH_1 better than the one in

Re: [ovs-dev] [PATCH 1/3] ofproto/ofproto-dpif.c: fix coding style

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 05:03:14PM -0300, Thadeu Lima de Souza Cascardo wrote: Identation was one extra level at ofproto_unixctl_mcast_snooping_show. Signed-off-by: Thadeu Lima de Souza Cascardo casca...@redhat.com Applied, thanks! ___ dev mailing

Re: [ovs-dev] [PATCH]: bfd: display last wall clock time of last flap

2015-06-24 Thread Sabyasachi Sengupta
Hi Ben, It's a little unconventional for us to use a wall clock time for this. I'd be more inclined to report it as N seconds ago or N ms ago. Any particular reason to use a wall clock time? I've seen that all BFD other outputs use now -/+ convention, but just that I thought wall clock

Re: [ovs-dev] [RFC 4/4] Introduce an openvswitch driver for Docker networking.

2015-06-24 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 02:15:50AM -0700, Gurucharan Shetty wrote: Docker committed experimental support for multi-host networking yesterday. This commit adds a driver that works with that experimental support. Since Docker code is not part of any official Docker releases yet, this patch is

Re: [ovs-dev] [PATCH 3/3] Multicast Listener Discovery support

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 05:03:16PM -0300, Thadeu Lima de Souza Cascardo wrote: Add support for MLDv1 and MLDv2. The behavior is not that different from IGMP. Packets to all-hosts address and queries are always flooded, reports go to routers, routers are added when a query is observed, and all

Re: [ovs-dev] [PATCH v2] datapath-windows: Remove the external/internal port only if it is removed on the Hyper-V switch

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 08:16:41PM +, Nithin Raju wrote: On Jun 23, 2015, at 12:42 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jun 18, 2015 at 09:05:32PM +, Nithin Raju wrote: On Jun 18, 2015, at 1:57 PM, Alin Serdean aserd...@cloudbasesolutions.com wrote: I have no issue

Re: [ovs-dev] [PATCH 3/3] Update windows test documentation

2015-06-24 Thread Alin Serdean
+1. We still need to add the description for the SYSTEM one or put in another patch using the setx command (https://support.microsoft.com/en-us/kb/195050). Alin. -Mesaj original- De la: Ben Pfaff [mailto:b...@nicira.com] Trimis: Thursday, June 25, 2015 3:22 AM Către: Gurucharan Shetty

[ovs-dev] [PATCH] tests: Automatically add pthread-win32 directory to $PATH.

2015-06-24 Thread Ben Pfaff
This reduces the user burden for running make check. Signed-off-by: Ben Pfaff b...@nicira.com --- I can't test this; whoever reviews it ought to. m4/openvswitch.m4 | 6 -- tests/automake.mk | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/m4/openvswitch.m4

Re: [ovs-dev] [PATCH 3/3] Update windows test documentation

2015-06-24 Thread Ben Pfaff
It's a step forward, then. I sent out an official patch, I'd appreciate it if anyone out there is willing to test it: http://openvswitch.org/pipermail/dev/2015-June/056833.html On Thu, Jun 25, 2015 at 01:19:14AM +, Alin Serdean wrote: +1. We still need to add the description for

Re: [ovs-dev] [PATCH 2/2] When opening a JSONRPC connection, the health probes are incorrectly getting turned off for connections that need probes.

2015-06-24 Thread Ben Pfaff
On Sat, Jun 20, 2015 at 05:09:55PM -0700, Ben Pfaff wrote: From: Sumit Garg su...@extremenetworks.com In other words, when stream_or_pstream_needs_probes() return non-zero, the probes are gettting disabled as the probe interval is getting set to zero. This leads to incorrect behavior such

Re: [ovs-dev] [PATCH 1/2] Committing two issues:

2015-06-24 Thread Ben Pfaff
Hi Sumit. Sorry it took me a while to review this--I'm catching up as best I can. Can I have a Signed-off-by for this commit? CONTRIBUTING.md says this about Signed-off-by: Signed-off-by: Author Name author.name@email.address... Informally, this indicates that Author Name is the

Re: [ovs-dev] [PATCH] Makefiles: Move xml2nroff rule from ovn directory to top level.

2015-06-24 Thread Ben Pfaff
On Mon, Jun 22, 2015 at 04:44:28PM -0700, Alex Wang wrote: On Mon, Jun 22, 2015 at 3:58 PM, Alex Wang al...@nicira.com wrote: On Mon, Jun 22, 2015 at 3:42 PM, Ben Pfaff b...@nicira.com wrote: Originally only the OVN documentation used the XML format, but now it's used outside the

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 07:49:08AM -0700, Gurucharan Shetty wrote: You can look at commit 5e65e080ad4d57e for more information on the exact problem with taskkill. One option is to check for tskill and if it does not exist, use taskkill. Here's a concept for that, it's probably buggy because

Re: [ovs-dev] [PATCH 2/3] mcast-snooping: Use IPv6 address for MDB

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 05:03:15PM -0300, Thadeu Lima de Souza Cascardo wrote: Use IPv6 internally for storing multicast addresses. IPv4 addresses are translated to their IPv4-mapped equivalent. Signed-off-by: Thadeu Lima de Souza Cascardo casca...@redhat.com From Clang:

Re: [ovs-dev] [PATCH] Makefiles: Move xml2nroff rule from ovn directory to top level.

2015-06-24 Thread Alex Wang
Acked-by: Alex Wang al...@nicira.com Thanks. I doubt this patch was related to the problem, because it only moves text around without changing it. Yeah, it is unrelated, ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: The current support for Geneve in OVS is exactly equivalent to VXLAN: it is possible to set and match on the VNI but not on any options contained in the header. This

Re: [ovs-dev] [PATCH] nx-match: Fix typo in comment.

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 11:59:03AM -0700, Jesse Gross wrote: On Wed, Jun 24, 2015 at 11:46 AM, Ben Pfaff b...@nicira.com wrote: Signed-off-by: Ben Pfaff b...@nicira.com --- lib/nx-match.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jesse Gross je...@nicira.com

Re: [ovs-dev] [PATCH 1/2] ovn: Add logical port 'enabled' state.

2015-06-24 Thread Ben Pfaff
On Tue, Jun 23, 2015 at 02:22:08PM -0400, Russell Bryant wrote: This patch adds a new column to the Logical_Port table of the OVN_Northbound database called 'enabled'. The purpose is to allow a port to be administratively enabled or disabled. It is sometimes useful to keep a port and its

Re: [ovs-dev] OVN and OpenStack Provider Networks

2015-06-24 Thread Salvatore Orlando
[resending to the ovs-dev as I sent my original reply to Russell only] Comments inline Salvatore On 24 June 2015 at 16:15, Russell Bryant rbry...@redhat.com wrote: On 06/23/2015 06:56 PM, Ben Pfaff wrote: On Tue, Jun 23, 2015 at 11:58:25PM +0200, Salvatore Orlando wrote: I'm afraid I have

Re: [ovs-dev] [PATCH] datapath-windows: Wrong cleanup of newly created multiple NBLs

2015-06-24 Thread Nithin Raju
On Jun 24, 2015, at 3:56 AM, Sorin Vinturis svintu...@cloudbasesolutions.com wrote: Bug found in OvsPartialCopyToMultipleNBLs function in the cleanup part of the code. Before completing the current NBL (newNbl) the NEXT link for the following NBL (firstNbl) was broken, instead of the

Re: [ovs-dev] [PATCH 3/3] Update windows test documentation

2015-06-24 Thread Gurucharan Shetty
On Tue, Jun 23, 2015 at 6:11 PM, Alin Serdean aserd...@cloudbasesolutions.com wrote: How about the following: Before running the unit tests make sure to add the pthread libraries to your PATH environment variable. The above is already part of the documentation with the following wording: You

Re: [ovs-dev] [PATCH] dpif-netdev: Check for PKT_RX_RSS_HASH flag.

2015-06-24 Thread Daniele Di Proietto
On 24/06/2015 09:47, Traynor, Kevin kevin.tray...@intel.com wrote: -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Panu Matilainen Sent: Wednesday, June 24, 2015 9:33 AM To: Pravin Shelar; Jesse Gross Cc: dev@openvswitch.org; Flavio Leitner

[ovs-dev] [PATCH 1/2] netdev-dpdk: Fix sparse and clang warnings

2015-06-24 Thread Daniele Di Proietto
Signed-off-by: Daniele Di Proietto diproiet...@vmware.com --- lib/netdev-dpdk.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c index 3af1ee7..c03ff3d 100644 --- a/lib/netdev-dpdk.c +++ b/lib/netdev-dpdk.c @@ -93,8 +93,8 @@

[ovs-dev] [PATCH 2/2] netdev-dpdk: Reset RSS hash when receiving from a vhost device.

2015-06-24 Thread Daniele Di Proietto
A vhost device, being a virtual interface, doesn't provide a valid RSS hash. As a workaround we set the value to 0, which suggests the datapath to recompute the hash in software. Reported-by: Dongjun do...@dtdream.com CC: Traynor, Kevin kevin.tray...@intel.com CC: Flavio Leitner

Re: [ovs-dev] [PATCH] ofproto: Fix use-after-free in bridge destruction with groups.

2015-06-24 Thread Simon Horman
Hi Ben, On Tue, Jun 23, 2015 at 11:38:56AM -0700, Ben Pfaff wrote: Groups were not destroyed until after lots of other important bridge data had been destroyed, including the connection manager. There was an indirect dependency on the connection manager for bridge destruction because

Re: [ovs-dev] [PATCH/RFC] connmgr: clear ofproto's pointer to connmgr when the latter is destroyed

2015-06-24 Thread Simon Horman
On Tue, Jun 23, 2015 at 11:39:45AM -0700, Ben Pfaff wrote: On Wed, Jun 17, 2015 at 02:22:32PM +0900, Simon Horman wrote: As per the testcase included in this patch it has been observed that ovs-vswtichd may segfault when deleting a bridge. Analysing the output of valgrind and gdb it

Re: [ovs-dev] [PATCH] tunneling: Don't match on source IP address for native tunnels.

2015-06-24 Thread Pravin Shelar
On Wed, Jun 24, 2015 at 2:55 PM, Jesse Gross je...@nicira.com wrote: When doing native tunneling, we look at packets destined to the local port to see if they match tunnel protocols that we should intercept. The criteria are IP protocol, destination UDP port, etc. However, we also look at the

Re: [ovs-dev] [PATCH 02/11] nx-match: Support variable length header lookup.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:16PM -0700, Jesse Gross wrote: Currently we treat the entire NXM/OXM header, including length, as an ID to define a field. However, this does not allow for multiple lengths of a particular field. If a field has been marked as variable, we should ignore the

Re: [ovs-dev] [PATCH] nx-match: Fix distribution of hash function for NXM/OXM headers.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 11:17 AM, Ben Pfaff b...@nicira.com wrote: NXM/OXM headers as represented in this file are 64-bit long and the low bits are essentially constant (almost always 0) so using hash_int(), which takes an uint32_t, is going to be a useless hash function. This commit fixes

Re: [ovs-dev] [PATCH] nx-match: Fix distribution of hash function for NXM/OXM headers.

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 11:21:51AM -0700, Jesse Gross wrote: On Wed, Jun 24, 2015 at 11:17 AM, Ben Pfaff b...@nicira.com wrote: NXM/OXM headers as represented in this file are 64-bit long and the low bits are essentially constant (almost always 0) so using hash_int(), which takes an

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-24 Thread Ben Pfaff
I guess this solution is OK with me for 2.4. Nithin (or anyone), do you agree that it's the best solution for now? On Fri, Jun 19, 2015 at 04:41:47PM +, Alin Serdean wrote: To do it the proper way yes. I really hate to do it this way but given the timeframe for 2.4 we could nuke it

Re: [ovs-dev] [PATCH] datapath-windows: demote some logs in flow validation

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:14:44PM +, Nithin Raju wrote: On Jun 19, 2015, at 8:59 AM, Alin Serdean aserd...@cloudbasesolutions.com wrote: I would rather leave them the way they are until we fix the actual problem (disable from userspace, treat the dpif_probe_feature correctly)

Re: [ovs-dev] [PATCH 01/11] metaflow: Allow fields to be marked as variable length.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:15PM -0700, Jesse Gross wrote: Until now, all fields that OVS can match against have been fixed size (variable length headers can be skipped during parsing but the match is fixed). However, Geneve options can vary in size so we must not require the size of these

[ovs-dev] [PATCH] nx-match: Fix distribution of hash function for NXM/OXM headers.

2015-06-24 Thread Ben Pfaff
NXM/OXM headers as represented in this file are 64-bit long and the low bits are essentially constant (almost always 0) so using hash_int(), which takes an uint32_t, is going to be a useless hash function. This commit fixes the problem. Found by inspection. CC: Jesse Gross je...@nicira.com

Re: [ovs-dev] [PATCH 02/11] nx-match: Support variable length header lookup.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 11:13 AM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:16PM -0700, Jesse Gross wrote: Currently we treat the entire NXM/OXM header, including length, as an ID to define a field. However, this does not allow for multiple lengths of a particular field.

Re: [ovs-dev] [PATCH 02/11] nx-match: Support variable length header lookup.

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 11:20:20AM -0700, Jesse Gross wrote: On Wed, Jun 24, 2015 at 11:13 AM, Ben Pfaff b...@nicira.com wrote: While reading nxm_field_by_header() I realized that we've got a terrible existing mistake in our hashing. Ugh. I'll send a fix, which we'll want to pre-apply (and

Re: [ovs-dev] [PATCH 03/11] nx-match: Handle receiving variable length fields.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:17PM -0700, Jesse Gross wrote: This adds support for receiving variable length fields encoded in NXM/OXM and mapping them into OVS internal structures. In order for this to make sense, we need to define some semantics: There are three lengths that matter in this

Re: [ovs-dev] [PATCH 04/11] nx-match: Enable senders of NXM fields to specify length.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:18PM -0700, Jesse Gross wrote: Currently when an NXM field is encoded, the caller must specify the length of the data being provided. However, this data is always placed into a field of standard length. In order to support variable length options, the length field

[ovs-dev] [PATCH 1/6] ofproto: Hold ofproto_mutex when enabling or disabling eviction.

2015-06-24 Thread Ben Pfaff
ofproto_enable_eviction() and ofproto_disable_eviction() require ofproto_mutex (and they were even annotated that way, though not on their prototypes but only at definition), but it wasn't being held. This fixes the problem. Found by inspection. Signed-off-by: Ben Pfaff b...@nicira.com ---

Re: [ovs-dev] [PATCH] INSTALL.DPDK: remove experimental statement

2015-06-24 Thread Daniele Di Proietto
On 24/06/2015 02:48, Pravin Shelar pshe...@nicira.com wrote: On Tue, Jun 23, 2015 at 11:42 AM, Ben Pfaff b...@nicira.com wrote: Do you two have an opinion on this? If DPDK support is pretty solid now then it makes sense to apply this to master and backport it to branch-2.4. Personally I

[ovs-dev] [PATCH 6/6] Implement OpenFlow 1.4+ OFPMP_TABLE_DESC message.

2015-06-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com Co-authored-by: Saloni Jain saloni.j...@tcs.com Signed-off-by: Saloni Jain saloni.j...@tcs.com --- NEWS| 1 + include/openflow/openflow-1.4.h | 10 +++ lib/learning-switch.c | 2 + lib/ofp-msgs.h

[ovs-dev] [PATCH 5/6] Implement OpenFlow 1.4+ OFPTC_EVICTION.

2015-06-24 Thread Ben Pfaff
OpenFlow 1.4 introduces the ability to turn on flow table eviction with an OFPT_TABLE_MOD message specifying OFPTC_EVICTION. It also adds related machinery to other messages that mention OFPTC_* fields. This commit adds support for the new feature, implementing it as a second, parallel way to

Re: [ovs-dev] [PATCH v11] ovs-ofctl:Implementation of eviction on the basis of Importance

2015-06-24 Thread Ben Pfaff
I reworked this into a patch series, starting here: http://openvswitch.org/pipermail/dev/2015-June/056771.html ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 4/6] ofproto: Use OF1.4+ importance as part of eviction criteria.

2015-06-24 Thread Ben Pfaff
The importance field is considered before flow timeout because I figure that if you set the importance, you think it's important. Signed-off-by: Ben Pfaff b...@nicira.com Co-authored-by: Saloni Jain saloni.j...@tcs.com Signed-off-by: Saloni Jain saloni.j...@tcs.com --- NEWS | 1

[ovs-dev] [PATCH 2/6] ofproto: Make 'importance' immutable.

2015-06-24 Thread Ben Pfaff
OpenFlow provides no means to change the importance of a flow after it is added, so make it immutable so that it is reasonable to read it without locking. Signed-off-by: Ben Pfaff b...@nicira.com --- ofproto/ofproto-provider.h | 2 +- ofproto/ofproto.c | 5 ++--- 2 files changed, 3

[ovs-dev] [PATCH 3/6] ofp-util: Fix typo in comment.

2015-06-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/ofp-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 89359c1..c1b2394 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -1317,7 +1317,7 @@ ofputil_decode_hello_bitmap(const struct

Re: [ovs-dev] [PATCH] datapath-windows: Wrong cleanup of newly created multiple NBLs

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 10:56:55AM +, Sorin Vinturis wrote: Bug found in OvsPartialCopyToMultipleNBLs function in the cleanup part of the code. Before completing the current NBL (newNbl) the NEXT link for the following NBL (firstNbl) was broken, instead of the current one (newNbl). This

Re: [ovs-dev] [PATCH 05/11] nx-match: Trim variable length fields when encoding as actions.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 12:12 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:19PM -0700, Jesse Gross wrote: It is technically correct to send the entire maximum length of a field when it is variable length. However, it is awkward to do so and not what one would naively

[ovs-dev] [PATCH] nx-match: Fix typo in comment.

2015-06-24 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/nx-match.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/nx-match.c b/lib/nx-match.c index 3dcee5d..e9de0fd 100644 --- a/lib/nx-match.c +++ b/lib/nx-match.c @@ -1150,7 +1150,7 @@ oxm_put_field_array(struct ofpbuf *b, const

Re: [ovs-dev] [PATCH 03/11] nx-match: Handle receiving variable length fields.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 11:38 AM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:17PM -0700, Jesse Gross wrote: This adds support for receiving variable length fields encoded in NXM/OXM and mapping them into OVS internal structures. In order for this to make sense, we need to

Re: [ovs-dev] [PATCH] nx-match: Fix typo in comment.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 11:46 AM, Ben Pfaff b...@nicira.com wrote: Signed-off-by: Ben Pfaff b...@nicira.com --- lib/nx-match.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Jesse Gross je...@nicira.com ___ dev mailing list

Re: [ovs-dev] [PATCH 05/11] nx-match: Trim variable length fields when encoding as actions.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:19PM -0700, Jesse Gross wrote: It is technically correct to send the entire maximum length of a field when it is variable length. However, it is awkward to do so and not what one would naively expect. Since receivers will internally zero-extend fields, we can do

Re: [ovs-dev] [PATCH 06/11] nx-match: Enable parsing string representations of variable fields.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:20PM -0700, Jesse Gross wrote: When reading in hex strings that form NXM fields, we don't need to enforce size constraints if the fields are variable length. Instead, we can set the header size based on the string length. Signed-off-by: Jesse Gross

Re: [ovs-dev] [PATCH v2] dpif_probe_feature not suported in windows datapath

2015-06-24 Thread Eitan Eliahu
I'm wondering if we could fail this call in the datapath level by examining the DPIF_FP_PROBE bit in the flags. If it is too hard we can still live with user mode code change. Thanks, Eitan -Original Message- From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Ben Pfaff Sent:

Re: [ovs-dev] [PATCH 07/11] openflow: Table maintenance commands for Geneve options.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:21PM -0700, Jesse Gross wrote: In order to work with Geneve options, we need to maintain a mapping table between an option (defined by class, type, length) and an NXM field that can be operated on for the purposes of matches, actions, etc. This mapping must be

Re: [ovs-dev] [PATCH 08/11] metaflow: Extend size of mf_value to 128 bytes.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:22PM -0700, Jesse Gross wrote: Tunnel metadata can be substantially larger than our existing fields (up to 124 bytes in a single Geneve option) so this extends the size of the data that we can handle with metaflow fields. This also breaks a few tests that assume

Re: [ovs-dev] [PATCH 06/11] nx-match: Enable parsing string representations of variable fields.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 12:26 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jun 19, 2015 at 04:13:20PM -0700, Jesse Gross wrote: When reading in hex strings that form NXM fields, we don't need to enforce size constraints if the fields are variable length. Instead, we can set the header size

Re: [ovs-dev] [PATCH 09/11] odp-util: Pass down flow netlink attributes when translating masks.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:23PM -0700, Jesse Gross wrote: Sometimes we need to look at flow fields to understand how to parse an attribute. However, masks don't have this information - just the mask on the field. We already use the translated flow structure for this purpose but this isn't