Re: [ovs-dev] [PATCH 08/11] metaflow: Extend size of mf_value to 128 bytes.

2015-06-30 Thread Jesse Gross
On Tue, Jun 30, 2015 at 7:56 AM, Loftus, Ciara wrote: >> >> On Wed, Jun 24, 2015 at 1:17 PM, Ben Pfaff wrote: >> > On Fri, Jun 19, 2015 at 04:13:22PM -0700, Jesse Gross wrote: >> >> Tunnel metadata can be substantially larger than our existing fields >> >> (up to 124 bytes in a single Geneve opti

[ovs-dev] [PATCH] tunnels: Don't initialize unnecessary packet metadata.

2015-06-30 Thread Jesse Gross
The addition of Geneve options to packet metadata significantly expanded its size. It was reported that this can decrease performance for DPDK ports by up to 25% since we need to initialize the whole structure on each packet receive. It is not really necessary to zero out the entire structure beca

Re: [ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Andy Zhou
On Tue, Jun 30, 2015 at 7:47 PM, Sabyasachi Sengupta wrote: > >> It seems we just need to extract the text between the table name and the >> first >> blank line below it. this should pretty easy with either awk or sed. >> >> As for efficiency, the db files I have access to are sufficiently >> smal

Re: [ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Sabyasachi Sengupta
It seems we just need to extract the text between the table name and the first blank line below it. this should pretty easy with either awk or sed. As for efficiency, the db files I have access to are sufficiently small that the script should work in practise, especially used only for debugging

Re: [ovs-dev] [PATCHv2] odp-util: Combine dpif_backer_support with odp_parms.

2015-06-30 Thread Andy Zhou
On Tue, Jun 30, 2015 at 6:48 PM, Joe Stringer wrote: > On 30 June 2015 at 17:42, Andy Zhou wrote: >> On Tue, Jun 30, 2015 at 4:52 PM, Joe Stringer wrote: >>> Both the ofproto layer and the odp-util layer have recently added >>> notions about fields supported by the datapath. This commit merges t

Re: [ovs-dev] [PATCHv2] odp-util: Combine dpif_backer_support with odp_parms.

2015-06-30 Thread Joe Stringer
On 30 June 2015 at 17:42, Andy Zhou wrote: > On Tue, Jun 30, 2015 at 4:52 PM, Joe Stringer wrote: >> Both the ofproto layer and the odp-util layer have recently added >> notions about fields supported by the datapath. This commit merges the >> two into the same structure. > > while I see the benf

Re: [ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Andy Zhou
> > Currently 'ovsdb-client dump' dumps the whole db, which can be lot of > output. Cannot think of an easier way than writing a python script that goes > over the entire output, then parses and prints the particular table in > question. Bash scripting may not be so easy to write as tables can have

[ovs-dev] [PATCH V2] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Alex Wang
This commit adds a rpmbuild spec file for building ovs datapath in dkms similar to the one for debian. Signed-off-by: Alex Wang --- PATCH->V2: - adopt Flavio's suggestion and use file's default permission. RFC->PATCH: - generate the dkms.conf inside %install. - remove rhel/dkms.conf.in. --- rh

Re: [ovs-dev] [PATCH] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Alex Wang
On Tue, Jun 30, 2015 at 6:13 PM, Flavio Leitner wrote: > On Tue, Jun 30, 2015 at 05:26:00PM -0700, Alex Wang wrote: > > This commit adds a rpmbuild spec file for building ovs datapath > > in dkms similar to the one for debian. > > > > Signed-off-by: Alex Wang > > > > --- > > RFC->PATCH: > > - ge

Re: [ovs-dev] [PATCH] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Flavio Leitner
On Tue, Jun 30, 2015 at 05:26:00PM -0700, Alex Wang wrote: > This commit adds a rpmbuild spec file for building ovs datapath > in dkms similar to the one for debian. > > Signed-off-by: Alex Wang > > --- > RFC->PATCH: > - generate the dkms.conf inside %install. > - remove rhel/dkms.conf.in. > ---

Re: [ovs-dev] [RFC rhel-dkms] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Alex Wang
On Tue, Jun 30, 2015 at 6:06 PM, Flavio Leitner wrote: > On Tue, Jun 30, 2015 at 03:56:44PM -0700, Alex Wang wrote: > > Hey Flavio, > > > > Thx a lot for the suggestions, > > > > Please see my reply inline, > > > > On Tue, Jun 30, 2015 at 10:41 AM, Flavio Leitner > wrote: > > > > > > > > > > dif

Re: [ovs-dev] [RFC rhel-dkms] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Flavio Leitner
On Tue, Jun 30, 2015 at 03:56:44PM -0700, Alex Wang wrote: > Hey Flavio, > > Thx a lot for the suggestions, > > Please see my reply inline, > > On Tue, Jun 30, 2015 at 10:41 AM, Flavio Leitner wrote: > > > > > > > diff --git a/rhel/dkms.conf.in b/rhel/dkms.conf.in > > > new file mode 100644 >

Re: [ovs-dev] [PATCHv2] odp-util: Combine dpif_backer_support with odp_parms.

2015-06-30 Thread Andy Zhou
On Tue, Jun 30, 2015 at 4:52 PM, Joe Stringer wrote: > Both the ofproto layer and the odp-util layer have recently added > notions about fields supported by the datapath. This commit merges the > two into the same structure. while I see the benfits of combining the structure, I am not sure it mak

[ovs-dev] [PATCH] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Alex Wang
This commit adds a rpmbuild spec file for building ovs datapath in dkms similar to the one for debian. Signed-off-by: Alex Wang --- RFC->PATCH: - generate the dkms.conf inside %install. - remove rhel/dkms.conf.in. --- rhel/.gitignore |1 + rhel/automake.mk |5

Re: [ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Andy Zhou
On Tue, Jun 30, 2015 at 4:43 PM, Sabyasachi Sengupta wrote: > >> Is actually adding a new feature rather than fix a bug? > > > Actually v2 fixes a bug that was in the original patch (v1) that was sent > out. > Ah, We usually write version delta comments in a separate section, with a heading of "v1

[ovs-dev] [PATCHv2] odp-util: Combine dpif_backer_support with odp_parms.

2015-06-30 Thread Joe Stringer
Both the ofproto layer and the odp-util layer have recently added notions about fields supported by the datapath. This commit merges the two into the same structure. Signed-off-by: Joe Stringer --- v2: Rebase against master. --- lib/dpif-netdev.c | 14 +++--- lib/odp-util.c

Re: [ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Sabyasachi Sengupta
Is actually adding a new feature rather than fix a bug? Actually v2 fixes a bug that was in the original patch (v1) that was sent out. If so, you may also want to update the man pages with the new usage and add unit tests for it. I'll add the manpage extension and resend v3, but I'm not

Re: [ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Andy Zhou
On Tue, Jun 30, 2015 at 10:36 AM, Sabyasachi Sengupta wrote: > > v2: fixed a bug in do_dump that was calling print_table incorrectly when > 'table' option is specified > > Added capability of displaying tables through an optional 'table' argument > to 'ovsdb-client dump'. When specified, ovsdb-cli

[ovs-dev] [PATCH] odp-util: Combine dpif_backer_support with odp_parms.

2015-06-30 Thread Joe Stringer
Both the ofproto layer and the odp-util layer have recently added notions about fields supported by the datapath. This commit merges the two into the same structure. Signed-off-by: Joe Stringer --- lib/dpif-netdev.c | 14 +++--- lib/odp-util.c| 4 ++-- lib/od

Re: [ovs-dev] [RFC rhel-dkms] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Alex Wang
Hey Flavio, Thx a lot for the suggestions, Please see my reply inline, On Tue, Jun 30, 2015 at 10:41 AM, Flavio Leitner wrote: > > > > diff --git a/rhel/dkms.conf.in b/rhel/dkms.conf.in > > new file mode 100644 > > index 000..2c90b4d > > --- /dev/null > > +++ b/rhel/dkms.conf.in > > @@ -0,

Re: [ovs-dev] OVN - Pluggable Distributed DB Infrastructure for OVSDB

2015-06-30 Thread Gal Sagie
Thanks for the inputs, i cant say i agree because: 1) This is not just a scale issue, this is also a Single point of failure/HA/Redundancy problem 2) As the code size increase it will be harder to do this abstraction and it will be more error prone 3) I wasn't suggesting to actually replace the

Re: [ovs-dev] OVN - Pluggable Distributed DB Infrastructure for OVSDB

2015-06-30 Thread Kyle Mestery
On Tue, Jun 30, 2015 at 2:35 PM, Russell Bryant wrote: > On 06/30/2015 04:42 AM, Gal Sagie wrote: > > Hi Justin, > > > > The idea was not to choose one database implementation over the other, > > but design things in such a way > > that its pluggable, so in terms of OVN, switching between > > imp

Re: [ovs-dev] OVN - Pluggable Distributed DB Infrastructure for OVSDB

2015-06-30 Thread Russell Bryant
On 06/30/2015 04:42 AM, Gal Sagie wrote: > Hi Justin, > > The idea was not to choose one database implementation over the other, > but design things in such a way > that its pluggable, so in terms of OVN, switching between > implementations is transparent (as much as possible) > > I think that di

Re: [ovs-dev] [RFC rhel-dkms] rhel: Add dkms support for ovs datapath build.

2015-06-30 Thread Flavio Leitner
On Sun, Jun 28, 2015 at 09:38:13PM -0700, Alex Wang wrote: > This commit adds a rpmbuild spec file for building ovs datapath > in dkms similar to the one for debian. > > Signed-off-by: Alex Wang > --- > rhel/.gitignore |1 + > rhel/automake.mk |6 +++ > rhel/dk

[ovs-dev] [PATCH v2]: ovsdb: add capability to dump table content in ovsdb-client

2015-06-30 Thread Sabyasachi Sengupta
v2: fixed a bug in do_dump that was calling print_table incorrectly when 'table' option is specified Added capability of displaying tables through an optional 'table' argument to 'ovsdb-client dump'. When specified, ovsdb-client will iterate through all tables in the chosen ovsdb, and create a t

[ovs-dev] [PATCH] datapath-windows: OVS_PACKET_ATTR_PROBE

2015-06-30 Thread Alin Serdean
Since commit: https://github.com/openvswitch/ovs/commit/2e460098bff351b9fddcb917447caa3b97a35d86 a new packet attribute was introduced. This patch adds OVS_PACKET_ATTR_PROBE to nlPktExecPolicy in datapath-windows and ignores it for the moment to maintain binary compatibility. Signed-off-by: Alin

[ovs-dev] [PATCH 2/2] Undefined symbol make_unix_socket

2015-06-30 Thread Alin Serdean
syslog_direct_create defined in (lib/syslog-direct.c) uses make_unix_socket which is currently undefined on the windows build. We either can remove the new file from the chain but this patch proposes to define a wrapper to make_unix_socket in which we return EINVAL. This will avoid this kind of p

[ovs-dev] [PATCH 1/2] OVS_UNUSED is defined indirectly

2015-06-30 Thread Alin Serdean
Currently OVS_UNUSED is defined in compiler.h since syslog.h is a standalone wrapper remove it from the parameters. Signed-off-by: Alin Gabriel Serdean --- include/windows/syslog.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/include/windows/syslog.h b/include/windo

[ovs-dev] [PATCH] Detecting dpdk vhost_cuse when building ovs

2015-06-30 Thread Mussar, Gary
Dpdk allows users to create a config that includes other config files and then override values. Eg. defconfig_x86_64-native_vhost_cuse-linuxapp-gcc: #include "defconfig_x86_64-native-linuxapp-gcc" CONFIG_RTE_BUILD_COMBINE_LIBS=y CONFIG_RTE_BUILD_SHARED_LIB=n CONFIG_RTE_LIBRTE_VHOST=y CONFIG_RTE_

Re: [ovs-dev] [PATCH 08/11] metaflow: Extend size of mf_value to 128 bytes.

2015-06-30 Thread Loftus, Ciara
> > On Wed, Jun 24, 2015 at 1:17 PM, Ben Pfaff wrote: > > On Fri, Jun 19, 2015 at 04:13:22PM -0700, Jesse Gross wrote: > >> Tunnel metadata can be substantially larger than our existing fields > >> (up to 124 bytes in a single Geneve option) so this extends the size > >> of the data that we can h

Re: [ovs-dev] segmentation fault in openvswitch

2015-06-30 Thread Traynor, Kevin
> -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of > ravali.bu...@wipro.com > Sent: Tuesday, June 30, 2015 7:39 AM > To: dev@openvswitch.org > Subject: [ovs-dev] segmentation fault in openvswitch > > Hi Team, > From below link https://access.redhat.com/docu

Re: [ovs-dev] OVN - Pluggable Distributed DB Infrastructure for OVSDB

2015-06-30 Thread Gal Sagie
Hi Justin, The idea was not to choose one database implementation over the other, but design things in such a way that its pluggable, so in terms of OVN, switching between implementations is transparent (as much as possible) I think that different setups can have different scale criteria and migh