When process_upcall() passes a miss upcall to upcall_xlate(), the new
ukey's dump_seq member is initialized from the current dump_seq. Later,
when udpif_revalidator() calls revalidate(), any dumped flow for which
ukey->dump_seq equals the current dump_seq is skipped. However, until now
the curren
I spent some time recently looking at the results of "ovs-ofctl
dump-table-features". It was really distressing because of the volume of
information. Every table yielded well over 100 lines of output and for 253
(visible) tables that meant over 25,300 lines of output total, which is
basically unu
Thanks, applied to master.
On Mon, Jul 06, 2015 at 02:19:56PM -0700, Justin Pettit wrote:
> Acked-by: Justin Pettit
>
> --Justin
>
>
> > On Jul 6, 2015, at 7:26 AM, Ben Pfaff wrote:
> >
> > OF1.5 was released months ago.
> >
> > Signed-off-by: Ben Pfaff
> > ---
> > FAQ.md | 3 +--
> > 1 fil
On Mon, Jul 06, 2015 at 05:46:36PM -0700, Justin Pettit wrote:
>
>
> > On Jul 6, 2015, at 2:42 PM, Ben Pfaff wrote:
> >
> > The recommended Google Python style is multi_word_names, not
> > multiWordNames.
> >
> > There are lots of other places where the style could be improved.
> > I started h
On Mon, Jul 06, 2015 at 03:32:45PM -0700, Jarno Rajahalme wrote:
>
> > On Jul 6, 2015, at 11:47 AM, Ben Pfaff wrote:
> >
> > Thanks for the review! Is that meant to cover the series, or will you
> > separately review patches 1 and 2?
> >
>
> Oops, patches 1&2 were in the junk mailbox, but I j
> On Jul 6, 2015, at 2:42 PM, Ben Pfaff wrote:
>
> The recommended Google Python style is multi_word_names, not
> multiWordNames.
>
> There are lots of other places where the style could be improved.
> I started here because I was working in this code anyway and because
> this code is only use
> On Jul 6, 2015, at 11:47 AM, Ben Pfaff wrote:
>
> Thanks for the review! Is that meant to cover the series, or will you
> separately review patches 1 and 2?
>
Oops, patches 1&2 were in the junk mailbox, but I just read them, and the ack
now covers the whole series :-)
Jarno
> Thanks,
>
I have resent the patch. If this doesn't work, I'll have to find some server
that I can use with send-email.
Gary
-Original Message-
From: Daniele Di Proietto [mailto:diproiet...@vmware.com]
Sent: Monday, July 06, 2015 13:43
To: Mussar, Gary
Cc: dev@openvswitch.org
Subject: Re: [ovs-de
The recommended Google Python style is multi_word_names, not
multiWordNames.
There are lots of other places where the style could be improved.
I started here because I was working in this code anyway and because
this code is only used at build time and not installed, so that it
can't break any thi
Fix detection of vhost_cuse in dpdk rte_config.h
Dpdk allows users to create a config that includes other config files and
then override values.
Eg.
defconfig_x86_64-native_vhost_cuse-linuxapp-gcc:
CONFIG_RTE_BUILD_COMBINE_LIBS=y
CONFIG_RTE_BUILD_SHARED_LIB=n
CONFIG_RTE_LIBRTE_VHOST=y
CONFIG_RTE
Acked-by: Justin Pettit
--Justin
> On Jul 6, 2015, at 7:26 AM, Ben Pfaff wrote:
>
> OF1.5 was released months ago.
>
> Signed-off-by: Ben Pfaff
> ---
> FAQ.md | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/FAQ.md b/FAQ.md
> index 045eed1..ccc75f0 100644
> --- a/F
On Wed, Jul 1, 2015 at 1:20 PM, Ben Pfaff wrote:
> On Wed, Jul 01, 2015 at 07:01:44PM +, Alin Serdean wrote:
>> syslog_direct_create defined in (lib/syslog-direct.c) uses make_unix_socket
>> which is currently undefined on the windows build.
>>
>> We either can remove the new file from the cha
> On Jul 6, 2015, at 9:02 AM, Ben Pfaff wrote:
>
> On Wed, Jul 01, 2015 at 12:45:05PM -0700, Jarno Rajahalme wrote:
>> Now that struct cls_match has 'add_version' the 'version' in cls_match
>> was largely redundant. Remove 'version' from struct cls_rule, and add
>> it to function prototypes tha
> On Jul 6, 2015, at 8:56 AM, Ben Pfaff wrote:
>
> On Wed, Jul 01, 2015 at 12:45:04PM -0700, Jarno Rajahalme wrote:
>> It is cleaner to not use ofp_bundle_entry for non-bundle flow mods.
>> To address this, the new struct ofproto_flow_mod combines an
>> ofputil_flow_mod and the necessary executi
Thx a lot Russel, for the review,~
On Mon, Jul 6, 2015 at 11:02 AM, Russell Bryant wrote:
> On 07/05/2015 01:38 AM, Alex Wang wrote:
> > This commit adds ovn-sbctl to ovn family by using the db-ctl-base
> > library.
> >
> > Signed-off-by: Alex Wang
> > Acked-by: Ben Pfaff
> >
> > ---
> > PATCH
Thanks for the review! Is that meant to cover the series, or will you
separately review patches 1 and 2?
Thanks,
Ben.
On Mon, Jul 06, 2015 at 11:36:41AM -0700, Jarno Rajahalme wrote:
> Acked-by: Jarno Rajahalme
>
> > On Jul 6, 2015, at 10:20 AM, Ben Pfaff wrote:
> >
> > This makes troublesh
Acked-by: Jarno Rajahalme
> On Jul 6, 2015, at 10:20 AM, Ben Pfaff wrote:
>
> This makes troubleshooting easier.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/ofp-util.c | 2 ++
> tests/ofp-print.at | 4 +++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/ofp-util.c b/li
On 01/07/2015 11:49, "Timo Puha" wrote:
>New stats for vhost ports are rx_bytes, tx_bytes, multicast, rx_errors and
>rx_length_errors. New stats for PMD ports are rx_dropped,
>rx_length_errors,
>rx_crc_errors and rx_missed_errors. DPDK imissed packets are now
>classified
>as dropped instead of e
On 07/05/2015 01:38 AM, Alex Wang wrote:
> This commit adds ovn-sbctl to ovn family by using the db-ctl-base
> library.
>
> Signed-off-by: Alex Wang
> Acked-by: Ben Pfaff
>
> ---
> PATCH->V2:
> - change command add/del-ch to add/del-chassis.
> - refine the manual based on comments from Ben.
> -
---
NEWS | 5 +++
include/openflow/nicira-ext.h | 23 +-
lib/bundle.c | 4 +++
lib/flow.c| 73 ++-
lib/flow.h| 2 ++
lib/multipath.c | 4 +++
util
Changes:
* Adhere to coding standards ( removed spaces before/after (), no // comments )
* Fix NEWS item
* Use 'bool' instead of 'int'
Signed-Off-By: Jeroen van Bemmel
Suggested-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch
CC: Ben Pfaff
---
ovn/northd/ovn-northd.c | 42 --
ovn/ovn-nb.ovsschema| 6 ++
ovn/ovn-nb.xml | 18 ++
ovn/ovn-nbctl.c | 29 +
ovn/ovn-sb.xml | 2 ++
5 files changed, 91 insert
Hi Gary,
I wasn't able to apply the patch, it appears to be corrupt.
Would you mind resending it, perhaps using get send-email?
I also think that it would be useful to include the first
part of the email in the commit message, for future reference.
Otherwise the patch seems fine to me, thanks!
On 1 July 2015 at 15:52, Andy Zhou wrote:
> LGTM. Thanks joe!
>
> Acked-by: Andy Zhou
Thanks Andy, applied to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
An upcoming commit will make use of this.
Signed-off-by: Ben Pfaff
---
build-aux/extract-ofp-msgs | 9 +
lib/ofp-msgs.c | 9 -
lib/ofp-msgs.h | 5 -
3 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/build-aux/extract-ofp-msgs b/build-aux/
This makes troubleshooting easier.
Signed-off-by: Ben Pfaff
---
lib/ofp-util.c | 2 ++
tests/ofp-print.at | 4 +++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index d02ee3a..646bae7 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -9119,6
It doesn't make sense for the messages added to a bundle to have a
different OpenFlow version from the outer OpenFlow version.
Signed-off-by: Ben Pfaff
---
lib/ofp-errors.h | 4
lib/ofp-util.c | 3 +++
tests/ofp-print.at | 8
3 files changed, 11 insertions(+), 4 deletions(-)
On Wed, Jul 01, 2015 at 12:45:05PM -0700, Jarno Rajahalme wrote:
> Now that struct cls_match has 'add_version' the 'version' in cls_match
> was largely redundant. Remove 'version' from struct cls_rule, and add
> it to function prototypes that need it. This makes versioning more
> explicit (or les
On Wed, Jul 01, 2015 at 12:45:04PM -0700, Jarno Rajahalme wrote:
> It is cleaner to not use ofp_bundle_entry for non-bundle flow mods.
> To address this, the new struct ofproto_flow_mod combines an
> ofputil_flow_mod and the necessary execution context for executing the
> start, revert, and finish
On Sat, Jul 04, 2015 at 04:47:37PM -0500, Jeroen van Bemmel wrote:
> The symmetric_l4 function implements a hash over various fields
> including L2 fields such as ethernet source and destination MAC.
> Inspite of its name, there are situations in which this hash does not
> yield symmetric results (
On Thu, Jul 02, 2015 at 11:39:14AM +, Sorin Vinturis wrote:
> This BSOD occurred in the context of a packet (NBL) with multiple
> NET_BUFFER(s) (NBs). The reason for the BSOD is due to the marking
> of NBLs created by OVS as being external and wrongly completing them.
>
> Signed-off-by: Sorin
From: Huanle Han
"ovs-appctl dpif/show" no longer takes any argument after commit dc54ef36
(ofproto: Track subfacet stats in the backer).
Signed-off-by: Huanle Han
Signed-off-by: Ben Pfaff
---
I already applied this patch to master, branch-2.4, and branch-2.3.
(It was submitted via github.)
From: Guru Chaitanya Perakam
To enable SSL clients to reconnect with the ovs-testcontoller without being
rejected, one must either set the SSL Session ID flag or disable the
SSL caching. This patch disables the SSL caching/reuse.
In the absence of this fix, the error message from ovs-testcontrol
OF1.5 was released months ago.
Signed-off-by: Ben Pfaff
---
FAQ.md | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/FAQ.md b/FAQ.md
index 045eed1..ccc75f0 100644
--- a/FAQ.md
+++ b/FAQ.md
@@ -1432,8 +1432,7 @@ A: The following table lists the versions of OpenFlow
supported
>
> I'm sending traffic to a macvtap2 interface on KVM instance [derived from
> pktovs bridge] and the traffic is voice [udp data ~104 bytes with ip header
> and payload]
>
> Following are the interface details [you can see the pktovs dropped value
> also]
>
> macvtap0: flags=4163 mtu 1500
> ma
I'm sending traffic to a macvtap2 interface on KVM instance [derived from
pktovs bridge] and the traffic is voice [udp data ~104 bytes with ip header
and payload]
Following are the interface details [you can see the pktovs dropped value
also]
macvtap0: flags=4163 mtu 1500
macvtap1: flags=4163 m
>
> Hi Mark,
>
> Following are the scripts.
>
Ok, so what traffic interface are you sending traffic into and what is the
traffic
type?
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Hi Mark,
Following are the scripts.
Init.sh
-
mount -t hugetlbfs -o pagesize=1G none /dev/hugepages
modprobe openvswitch
OVS=/root/OVS/ovs-branch-2.4
pkill -9 ovs
rm -rf /usr/local/etc/openvswitch/
rm -rf /usr/local/var/run/openvswitch/
rm -rf /usr/local/etc/openvswitch/conf.db
mkdir
> Hi All,
>
> When I'm using plain OVS bridge [vswitchd without dpdk options], i'm not
> seeing any packet loss at the ovs bridge.
>
> But as i mentioned earlier with DPDK, huge packet loss is happening.
>
> Can someone tell, how dpdk options are resulting in packet loss?
>
> I tried with incre
Hi All,
When I'm using plain OVS bridge [vswitchd without dpdk options], i'm not
seeing any packet loss at the ovs bridge.
But as i mentioned earlier with DPDK, huge packet loss is happening.
Can someone tell, how dpdk options are resulting in packet loss?
I tried with increased txqueuelen on p
40 matches
Mail list logo
