On 07/16/15 at 02:36pm, Pravin Shelar wrote:
> On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf wrote:
> > I'm inclined to change this and use an in-kernel API as well to
> > create the net_device just like VXLAN does in patch 21.
> >
> > Pravin, what do you think?
>
> About the vxlan APIs we also ne
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
> Proietto
> Sent: Thursday, July 16, 2015 7:48 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 1/2] netdev-dpdk: Restore txq/rxq number if
> initialization fails.
>
> netdev_dpdk_set_mul
> -Original Message-
> From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Daniele Di
> Proietto
> Sent: Thursday, July 16, 2015 7:48 PM
> To: dev@openvswitch.org
> Subject: [ovs-dev] [PATCH 2/2] netdev-dpdk: Retry tx/rx queue setup
> until we don't get any failure.
>
> It has been
Hi Ben,
The main problem in the whole implementation which I am facing currently is in
encoding and decoding of table-mod config value.
For table-config, as per the specification we can send only three values -
OFPTC14_EVICTION, OFPTC14_VACANCY_EVENTS and 0.
As per the current implementation:
E
This series combines the work previously posted by Roopa, Robert and
myself. It's according to what we discussed at NFWS. The motivation
of this series is to:
* Consolidate code between OVS and the rest of the kernel and get
rid of OVS vports and instead represent them as pure net_devices.
*
From: Roopa Prabhu
This patch introduces lwtunnel_output function to call corresponding
lwtunnels output function to xmit the packet.
It adds two variants lwtunnel_output and lwtunnel_output6 for ipv4 and
ipv6 respectively today. But this is subject to change when lwtstate will
reside in dst or
From: Roopa Prabhu
This patch introduces two new RTA attributes to attach encap
data to fib routes.
Example iproute2 command to attach mpls encap data to ipv4 routes
$ip route add 10.1.1.0/30 encap mpls 200 via inet 10.1.1.1 dev swp1
Signed-off-by: Roopa Prabhu
Suggested-by: Eric W. Biederman
From: Roopa Prabhu
This is similar to ipv4 redirect of dst output to lwtunnel
output function for encapsulation and xmit.
Signed-off-by: Roopa Prabhu
---
net/ipv6/route.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index b3431b7..7f2214f 100644
--- a
From: Roopa Prabhu
For input routes with tunnel encap state this patch redirects
dst output functions to lwtunnel_output which later resolves to
the corresponding lwtunnel output function.
This has been tested to work with mpls ip tunnels.
Open items: Support for tunnel mtu, pmtu, fragmentation
From: Roopa Prabhu
This patch adds support in ipv4 fib functions to parse user
provided encap attributes and attach encap state data to fib_nh
and rtable.
Signed-off-by: Roopa Prabhu
---
include/net/ip_fib.h | 5 ++-
include/net/route.h | 1 +
net/ipv4/fib_frontend.c | 8
net
From: Roopa Prabhu
This patch adds support in ipv6 fib functions to parse Netlink
RTA encap attributes and attach encap state data to rt6_info.
Signed-off-by: Roopa Prabhu
---
include/net/ip6_fib.h | 3 +++
net/ipv6/ip6_fib.c| 2 ++
net/ipv6/route.c | 33
From: Roopa Prabhu
Signed-off-by: Roopa Prabhu
---
net/mpls/af_mpls.c | 11 ---
net/mpls/internal.h | 9 +++--
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c
index 1f93a59..6e66911 100644
--- a/net/mpls/af_mpls.c
+++ b/net/m
From: Roopa Prabhu
This implementation uses lwtunnel infrastructure to register
hooks for mpls tunnel encaps.
It picks cues from iptunnel_encaps infrastructure and previous
mpls iptunnel RFC patches from Eric W. Biederman and Robert Shearman
Signed-off-by: Roopa Prabhu
---
include/linux/mpls_
From: Roopa Prabhu
Provides infrastructure to parse/dump/store encap information for
light weight tunnels like mpls. Encap information for such tunnels
is associated with fib routes.
This infrastructure is based on previous suggestions from
Eric Biederman to follow the xfrm infrastructure.
Sign
ip_route_input() unconditionally overwrites the dst. Hide the original
dst attached to the skb by calling skb_dst_set(skb, NULL) prior to
ip_route_input().
Reported-by: Julian Anastasov
Signed-off-by: Thomas Graf
---
net/ipv4/icmp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/i
Introduces a new dst_metadata which enables to carry per packet metadata
between forwarding and processing elements via the skb->dst pointer.
The structure is set up to be a union. Thus, each separate type of
metadata requires its own dst instance. If demand arises to carry
multiple types of metad
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to
allow routes to match on tunnel metadata. For now, the tunnel id is
added to flowi_tunnel which allows for routes to be bound to specific
virtual tunnels.
Signed-off-by: Thomas Graf
---
include/net/flow.h | 7 +++
net/ipv
If output device wants to see the dst, inherit the dst of the
original skb and pass it on to generate the ARP request.
Signed-off-by: Thomas Graf
---
net/ipv4/arp.c | 65 +-
1 file changed, 37 insertions(+), 28 deletions(-)
diff --git a/ne
This factors out the device configuration out of the RTNL newlink
API which allows for in-kernel creation of VXLAN net_devices.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c | 332
include/net/vxlan.h | 59 ++
2 files changed, 23
Allows putting a VXLAN device into a new flow-based mode in which
skbs with a ip_tunnel_info dst metadata attached will be encapsulated
according to the instructions stored in there with the VXLAN device
defaults taken into consideration.
Similar on the receive side, if the VXLAN_F_COLLECT_METADAT
This add the ability to select a routing table based on the tunnel
id which allows to maintain separate routing tables for each virtual
tunnel network.
ip rule add from all tunnel-id 100 lookup 100
ip rule add from all tunnel-id 200 lookup 200
A new static key controls the collection of metadata
This introduces a new IP tunnel lightweight tunnel type which allows
to specify IP tunnel instructions per route. Only IPv4 is supported
at this point.
Signed-off-by: Thomas Graf
---
drivers/net/vxlan.c| 10 +++-
include/net/dst_metadata.h | 12 -
include/net/ip_tunnels.h
This is the first step in representing all OVS vports as regular
struct net_devices. Move the net_device pointer into the vport
structure itself to get rid of struct vport_netdev.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
net/openvswitch/datapath.c | 7 +--
net/op
This gets rid of all OVS specific VXLAN code in the receive and
transmit path by using a VXLAN net_device to represent the vport.
Only a small shim layer remains which takes care of handling the
VXLAN specific OVS Netlink configuration.
Unexports vxlan_sock_add(), vxlan_sock_release(), vxlan_xmit_
Utilize the new metadata dst to attach encapsulation instructions to
the skb. The existing egress_tun_info via the OVS_CB() is left in
place until all tunnel vports have been converted to the new method.
Signed-off-by: Thomas Graf
Signed-off-by: Pravin B Shelar
---
net/openvswitch/actions.c
This allows to get rid of the get_name() vport ops later on.
Signed-off-by: Thomas Graf
---
net/openvswitch/datapath.c | 4 ++--
net/openvswitch/vport-internal_dev.c | 1 -
net/openvswitch/vport-netdev.c | 6 --
net/openvswitch/vport-netdev.h | 1 -
net/openvswitch/vpor
On 07/16/2015 07:56 PM, Ben Pfaff wrote:
> On Thu, Jul 16, 2015 at 04:55:11PM -0700, Ben Pfaff wrote:
>> On Thu, Jul 16, 2015 at 06:06:10PM -0400, Russell Bryant wrote:
>>> Add a new OVN configuration entry in the Open_vSwitch database called
>>> "ovn-bridge-mappings". This allows the configuratio
On Fri, Jul 17, 2015 at 05:54:57PM +0530, Saloni Jain wrote:
> The main problem in the whole implementation which I am facing currently is
> in encoding and decoding of table-mod config value.
> For table-config, as per the specification we can send only three values -
> OFPTC14_EVICTION, OFPTC14
Hi All,
If this solution is acceptable and pushed to master, would it be possible
to have it included as part of the OVS 2.4 release branch? (As these are
bug fixes and not new features).
Otherwise OVS with DPDK will be limited in its deployment use cases.
Regards
Ian Stokes
> -Original
On Thu, Jul 16, 2015 at 05:47:00PM -0700, Jarno Rajahalme wrote:
> Use two maps in miniflow to allow for expansion of struct flow past
> 512 bytes. We now have one map for tunnel related fields, and another
> for the rest of the packet metadata and actual packet header fields.
> This split has the
On Fri, Jul 17, 2015 at 08:51:47AM -0700, Ben Pfaff wrote:
> On Thu, Jul 16, 2015 at 05:47:00PM -0700, Jarno Rajahalme wrote:
> > Use two maps in miniflow to allow for expansion of struct flow past
> > 512 bytes. We now have one map for tunnel related fields, and another
> > for the rest of the pa
On Thu, Jul 16, 2015 at 05:22:25PM -0700, Jarno Rajahalme wrote:
>
> > On Jul 16, 2015, at 4:33 PM, Ben Pfaff wrote:
> >
> > On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote:
> >> I've seen core files appear and then be automatically removed as the
> >> test case was successful.
[Adding back ovs-dev, hope that's OK]
Hmm, shutting down your QoS effort is not my goal.
What if we consider this patch as the start of an RFC series for the NB
part of QoS and then you work on the implications of pushing it down
through ovn-northd into SB and ovn-controller/OpenFlow? That's whe
When ifdown isn't executed (system didn't shut down properly),
the interfaces remain in the openvswitch's database. For the
internal ports or devices that are available when openvswitch
service starts that's not an issue.
However, ovs-vsctl won't do anything for devices created later
(Linux vlan
On Thu, Jul 16, 2015 at 3:07 PM, Alex Wang wrote:
> Sorry for this very delayed reply,
>
> I think I found the issue, in branch 2.1.*
>
> Will send out a fix soon,
>
>
Sorry I found my theory was wrong, things seem to be trickier~
Want to know if you have modified the source code?
Also, could y
On Fri, Jul 17, 2015 at 3:58 AM, Thomas Graf wrote:
> On 07/16/15 at 02:36pm, Pravin Shelar wrote:
>> On Thu, Jul 16, 2015 at 7:52 AM, Thomas Graf wrote:
>> > I'm inclined to change this and use an in-kernel API as well to
>> > create the net_device just like VXLAN does in patch 21.
>> >
>> > Pra
Currently, MSVC complains when you have a macro of the
form TYPE_MAXIMUM(uint64_t) because a part of macro becomes
~(uint64_t)0 << 64 with a warning:
C4293: '<<' : shift count negative or too big, undefined behavior.
This commit makes changes to the macro to prevent that warning.
Suggested-by: B
On 16 July 2015 at 13:52, Ben Pfaff wrote:
> On Wed, Jul 15, 2015 at 10:18:29PM -0700, Joe Stringer wrote:
>> This code attempts to first check whether another error was detected for
>> the string it is parsing, then if it's not at the end of the tokens,
>> report an error. However, 'errorp' is al
Signed-off-by: Joe Stringer
---
acinclude.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/acinclude.m4 b/acinclude.m4
index 14907ab..4f1e66c 100644
--- a/acinclude.m4
+++ b/acinclude.m4
@@ -271,7 +271,7 @@ dnl translated to uppercase.
AC_DEFUN([OVS_FIND_FIELD_IFELSE], [
On 7/17/15 5:55 AM, Thomas Graf wrote:
@@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev)
netif_keep_dst(dev);
dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
+ /* If in flow based mode, keep the dst including encapsulation
+* instructions for vxlan_xmi
On 07/16/2015 08:07 PM, Ben Pfaff wrote:
> On Thu, Jul 16, 2015 at 06:06:12PM -0400, Russell Bryant wrote:
>> While parsing the OVN bridge mapping configuration, ensure that patch
>> ports exist between the OVN integration bridge and the physical
>> network bridge. If they do not exist, create the
Pushed. Thanks for the review and catching the test failure!
On Thu, Jul 16, 2015 at 11:58 AM, Ben Pfaff wrote:
> Tests pass for me now with v3, so please push these when you are
> satisfied with them. Thank you!
___
dev mailing list
dev@openvswitch.or
On Fri, Jul 17, 2015 at 09:26:23AM -0700, Gurucharan Shetty wrote:
> Currently, MSVC complains when you have a macro of the
> form TYPE_MAXIMUM(uint64_t) because a part of macro becomes
> ~(uint64_t)0 << 64 with a warning:
>
> C4293: '<<' : shift count negative or too big, undefined behavior.
>
>
On Fri, Jul 17, 2015 at 11:23:31AM -0700, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
> ---
> acinclude.m4 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index 14907ab..4f1e66c 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -27
On Fri, Jul 17, 2015 at 03:20:00PM -0400, Russell Bryant wrote:
> On 07/16/2015 08:07 PM, Ben Pfaff wrote:
> > On Thu, Jul 16, 2015 at 06:06:12PM -0400, Russell Bryant wrote:
> >> While parsing the OVN bridge mapping configuration, ensure that patch
> >> ports exist between the OVN integration brid
> We have an issue here. The 'show->recurse' is used to prevent dependency
> loop in the users defined 'struct cmd_show_table' array. So, we cannot copy
> the element here.
>
You are right. I will restructure this patch.
Given that other patches in the series are acked. I will drop this
patch,
Hello,
On Fri, 17 Jul 2015, Thomas Graf wrote:
> Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to
> allow routes to match on tunnel metadata. For now, the tunnel id is
> added to flowi_tunnel which allows for routes to be bound to specific
> virtual tunnels.
>
> Si
On Thu, Jun 11, 2015 at 9:43 AM, Neil McKee wrote:
> If new optional attribute OVS_USERSPACE_ATTR_ACTIONS is added to an
> OVS_ACTION_ATTR_USERSPACE action, then include the datapath actions
> in the upcall.
>
> This Directly associates the sampled packet with the path it takes
> through the virtu
On 07/17/2015 04:04 PM, Ben Pfaff wrote:
> On Fri, Jul 17, 2015 at 03:20:00PM -0400, Russell Bryant wrote:
>> On 07/16/2015 08:07 PM, Ben Pfaff wrote:
>>> On Thu, Jul 16, 2015 at 06:06:12PM -0400, Russell Bryant wrote:
While parsing the OVN bridge mapping configuration, ensure that patch
On Thu, Jul 16, 2015 at 12:04 PM, Kyle Mestery wrote:
> On Thu, Jul 16, 2015 at 12:55 PM, Ben Pfaff wrote:
>
>> On Tue, Jul 14, 2015 at 07:45:42AM +, Pritesh Kothari (pritkoth) wrote:
>> >
>> > > On Jul 13, 2015, at 9:40 PM, Ben Pfaff wrote:
>> > >
>> > > On Tue, Jul 14, 2015 at 12:34:14AM +
On Thu, Jun 11, 2015 at 09:43:59AM -0700, Neil McKee wrote:
> Packets are still sampled at ingress only, so the egress
> tunnel and/or MPLS structures are only included when there is just 1 output
> port. The actions are either provided by the datapath in the sample upcall
> or looked up in the us
> On Jul 17, 2015, at 9:33 AM, Ben Pfaff wrote:
>
> On Thu, Jul 16, 2015 at 05:22:25PM -0700, Jarno Rajahalme wrote:
>>
>>> On Jul 16, 2015, at 4:33 PM, Ben Pfaff wrote:
>>>
>>> On Thu, Jul 16, 2015 at 03:15:52PM -0700, Jarno Rajahalme wrote:
I've seen core files appear and then be autom
Sure, I'll try to get to that tonight.
Neil
--
Neil McKee
InMon Corp.
http://www.inmon.com
On Fri, Jul 17, 2015 at 4:31 PM, Ben Pfaff wrote:
> On Thu, Jun 11, 2015 at 09:43:59AM -0700, Neil McKee wrote:
> > Packets are still sampled at ingress only, so the egress
> > tunnel and/or MPLS s
OK, try this then:
diff --git a/tests/daemon-py.at b/tests/daemon-py.at
index cafa8df..b0f1236 100644
--- a/tests/daemon-py.at
+++ b/tests/daemon-py.at
@@ -59,7 +59,7 @@ AT_CHECK(
AT_CHECK([kill `cat pid`], [0], [], [ignore], [kill `cat parent`])
OVS_WAIT_WHILE([kill -0 `cat parent` || kill -0 `
The 'recurse' is used during run time to suppress duplicated prints.
It is not essential to describe how show command should work.
This patch remove the 'recurse' member. Duplicated prints is now
suppressed by maintaining an 'sset' of tables that have been printed
at run time.
Signed-off-by: Andy
Instead of requiring user to declare a global variable, pass the value
via ctl_init().
Signed-off-by: Andy Zhou
---
lib/db-ctl-base.c | 20 +++-
lib/db-ctl-base.h | 17 +++--
utilities/ovs-vsctl.c | 4 ++--
vtep/vtep-ctl.c | 4 ++--
4 files changed, 18
Ben,
This works, the core file names can be found from the testsuite.log!
It would be super nice to have the cores reported on the “Test Results” section
of the make check output, though:
## - ##
## Test results. ##
## - ##
ERROR: All 7 tests were run,
3 failed unexpect
Packets are still sampled at ingress only, so the egress
tunnel and/or MPLS structures are only included when there is just 1 output
port. The actions are either provided by the datapath in the sample upcall
or looked up in the userspace cache. The former is preferred because it is
more reliable
58 matches
Mail list logo
