[ovs-dev] [RFC] ofpbuf: Update msg when resizing ofpbuf.

2015-07-20 Thread Alex Wang
Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the 'header' and 'msg' pointers to 'struct ofpbuf'. However, we forget to update the 'msg' pointer when resizing ofpbuf. This bug could cause serious issue. For example, in the function ofputil_encode_nx_packet_in(), the 'msg' pointer is

Re: [ovs-dev] Support for MCAST_Snooping

2015-07-20 Thread laxmikanta.beh...@gmail.com
Hi Cascardo, Appreciating very much your help on this ! Please find attached tcpdump (wireshark files) and below requested MAC address details. Port MAC Address. enp9s0f0 a0:36:9f:4f:38:94 enp9s0f3 a0:36:9f:4f:38:97 TG1 a0:36:9f:4f:38:95 TG2

Re: [ovs-dev] [Dpdk-ovs] vhost-user performance improvement

2015-07-20 Thread Varun Rapelly
Hi All, Now i started using vhost-user and observing good performance. Packet loss is still happening, but is around 0.006%. [root@warmtongue ~]# ovs-ofctl dump-ports ovs OFPST_PORT reply (xid=0x2): 6 ports port 4: rx pkts=24717275, bytes=?, drop=?, errs=?, frame=?, over=?, crc=?

Re: [ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Thomas Graf
On 07/17/15 at 11:41am, Alexei Starovoitov wrote: On 7/17/15 5:55 AM, Thomas Graf wrote: @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); dev-priv_flags |= IFF_LIVE_ADDR_CHANGE; +/* If in flow based mode, keep the dst including

Re: [ovs-dev] [Dpdk-ovs] vhost-user performance improvement

2015-07-20 Thread Gray, Mark D
Hi All, Now i started using vhost-user and observing good performance. Great! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next 15/22] route: Extend flow representation with tunnel key

2015-07-20 Thread Thomas Graf
On 07/17/15 at 11:25pm, Julian Anastasov wrote: Hello, On Fri, 17 Jul 2015, Thomas Graf wrote: Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for

Re: [ovs-dev] [PATCH] rhel: fix ifup-ovs to delete ports first

2015-07-20 Thread Jiri Benc
On Fri, 17 Jul 2015 13:56:21 -0300, Flavio Leitner wrote: When ifdown isn't executed (system didn't shut down properly), the interfaces remain in the openvswitch's database. For the internal ports or devices that are available when openvswitch service starts that's not an issue. However,

[ovs-dev] OVN configuration (was: [RFC v2 04/11] ovn: Add patch ports for ovn bridge mappings)

2015-07-20 Thread Ben Pfaff
Regarding this patch, to be honest, the choice of bridge mappings is just borrowed from the existing OVS support in OpenStack. What's implemented here matches how that works. It expects the bridge to be created already, but automatically creates patch ports to/from the integration

Re: [ovs-dev] [PATCH] acinclude: Silence OVS_FIND_FIELD_IFELSE.

2015-07-20 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 10:12:31AM -0700, Joe Stringer wrote: On 17 July 2015 at 12:58, Ben Pfaff b...@nicira.com wrote: On Fri, Jul 17, 2015 at 11:23:31AM -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com --- acinclude.m4 | 2 +- 1 file changed, 1

Re: [ovs-dev] [PATCH] acinclude: Silence OVS_FIND_FIELD_IFELSE.

2015-07-20 Thread Joe Stringer
On 20 July 2015 at 10:51, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 20, 2015 at 10:12:31AM -0700, Joe Stringer wrote: On 17 July 2015 at 12:58, Ben Pfaff b...@nicira.com wrote: On Fri, Jul 17, 2015 at 11:23:31AM -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com

Re: [ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Marcelo Ricardo Leitner
On Mon, Jul 20, 2015 at 02:15:22PM -0300, Marcelo Ricardo Leitner wrote: On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: [ snip ] @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); --- (a) dev-priv_flags

[ovs-dev] Bonjour

2015-07-20 Thread Paul Chambert
Très Cher(e), Excusez moi de cette manière de vous contacter car nous ne nous connaissons pas, je viens d'écrire votre adresse par pure hasard tout en demandant a Dieu de me guider vers une personne de bonne moralité, je me suis dis que vous êtes la personne qu'il me faut. En bref, je me nomme

Re: [ovs-dev] OVN configuration

2015-07-20 Thread Russell Bryant
On 07/20/2015 01:46 PM, Ben Pfaff wrote: Regarding this patch, to be honest, the choice of bridge mappings is just borrowed from the existing OVS support in OpenStack. What's implemented here matches how that works. It expects the bridge to be created already, but automatically creates patch

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Ben Pfaff
OK, now I need an explanation myself. The Debian builds worked fine for me both before and after this patch. What problem do you see? On Mon, Jul 20, 2015 at 11:17:41AM -0700, Alex Wang wrote: Could I get an explanation on why there is a typo. This is breaking debian build on my setup,

[ovs-dev] [PATCH v2 2/2] datapath-windows: Support for IRP cancelling mechanism

2015-07-20 Thread Sorin Vinturis
Under certain circumstances, we might need to cancel a pending IRP that has been submitted and not yet responded. This might occur when the request takes too long to complete or when the process which initiated the request terminated, leaving the request outstanding. This patch provides this

[ovs-dev] [PATCH] ofproto-dpif: Remove prototype for unimplemented function.

2015-07-20 Thread Ben Pfaff
The function was removed some time ago, but not the prototype. Signed-off-by: Ben Pfaff b...@nicira.com --- ofproto/ofproto-dpif.h | 5 - 1 file changed, 5 deletions(-) diff --git a/ofproto/ofproto-dpif.h b/ofproto/ofproto-dpif.h index 7bb45e3..0209565 100644 --- a/ofproto/ofproto-dpif.h

[ovs-dev] [PATCH v2 0/2] datapath-windows: IRP cancelling mechanism

2015-07-20 Thread Sorin Vinturis
This patch series adds support for IRP cancelling mechanism to the OVS extension. Sorin Vinturis (2): [PATCH v2 1/2] datapath-windows: Process tunnel filter requests iteratively [PATCH v2 2/2] datapath-windows: Support for IRP cancelling mechanism

[ovs-dev] [PATCH v2 1/2] datapath-windows: Process tunnel filter requests iteratively

2015-07-20 Thread Sorin Vinturis
In order to support IRP cancelling mechanism for pending IRPs, all tunnel filter requests, VXLAN create/delete tunnel, need to be processed iteratively. Signed-off-by: Sorin Vinturis svintu...@cloudbasesolutions.com --- datapath-windows/ovsext/TunnelFilter.c | 107

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Could I get an explanation on why there is a typo. This is breaking debian build on my setup, Thanks, Alex Wang, On Tue, Jul 14, 2015 at 10:43 PM, Ben Pfaff b...@nicira.com wrote: On Thu, Jul 09, 2015 at 03:22:46PM -0400, Kyle Upton wrote: Fix dependency issues with lib/ofp-errors.lo and

Re: [ovs-dev] OVN configuration

2015-07-20 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 02:06:26PM -0400, Russell Bryant wrote: On 07/20/2015 01:46 PM, Ben Pfaff wrote: Regarding this patch, to be honest, the choice of bridge mappings is just borrowed from the existing OVS support in OpenStack. What's implemented here matches how that works. It

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove prototype for unimplemented function.

2015-07-20 Thread Ben Pfaff
Thanks, applied to master. On Mon, Jul 20, 2015 at 11:23:31AM -0700, Alex Wang wrote: Acked-by: Alex Wang al...@nicira.com On Mon, Jul 20, 2015 at 11:20 AM, Ben Pfaff b...@nicira.com wrote: The function was removed some time ago, but not the prototype. Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] automake: Cleanup to allow make distcheck to succeed.

2015-07-20 Thread Ben Pfaff
On Sat, Jul 18, 2015 at 05:05:54PM -0400, Aaron Conole wrote: Ben Pfaff b...@nicira.com writes: Can you explain the following change? What effect does it have, and why is it needed only in one fork of the if? --- a/Makefile.am +++ b/Makefile.am @@ -44,7 +44,7 @@ endif if WIN32

Re: [ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Marcelo Ricardo Leitner
On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: [ snip ] @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); --- (a) dev-priv_flags |= IFF_LIVE_ADDR_CHANGE; + /* If in flow based mode, keep the dst

Re: [ovs-dev] [RFC v2 02/11] ovn: Add bridge mappings to ovn-controller.

2015-07-20 Thread Russell Bryant
On 07/17/2015 10:53 AM, Russell Bryant wrote: On 07/16/2015 07:56 PM, Ben Pfaff wrote: On Thu, Jul 16, 2015 at 04:55:11PM -0700, Ben Pfaff wrote: On Thu, Jul 16, 2015 at 06:06:10PM -0400, Russell Bryant wrote: Add a new OVN configuration entry in the Open_vSwitch database called

Re: [ovs-dev] [RFC] ofpbuf: Update msg when resizing ofpbuf.

2015-07-20 Thread Alex Wang
On Mon, Jul 20, 2015 at 8:17 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang wrote: Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the 'header' and 'msg' pointers to 'struct ofpbuf'. However, we forget to update the 'msg' pointer when

Re: [ovs-dev] [RFC] ofpbuf: Update msg when resizing ofpbuf.

2015-07-20 Thread Alex Wang
Applied to master and branch-2.4, Thanks, Alex Wang, On Mon, Jul 20, 2015 at 9:58 AM, Alex Wang al...@nicira.com wrote: Thx for the review, I'll adopt the comment~ On Mon, Jul 20, 2015 at 9:47 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 20, 2015 at 08:50:39AM -0700, Alex Wang wrote:

Re: [ovs-dev] [PATCH] acinclude: Silence OVS_FIND_FIELD_IFELSE.

2015-07-20 Thread Joe Stringer
On 17 July 2015 at 12:58, Ben Pfaff b...@nicira.com wrote: On Fri, Jul 17, 2015 at 11:23:31AM -0700, Joe Stringer wrote: Signed-off-by: Joe Stringer joestrin...@nicira.com --- acinclude.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/acinclude.m4 b/acinclude.m4 index

Re: [ovs-dev] OpenStack ACL Rules for OVN

2015-07-20 Thread Russell Bryant
Added ovs dev list to let others sanity check me. :-) The context is discussing how OpenStack will use ACLs in OVN_Northbound. We don't have Neutron code for this yet, but we have the Security Groups section of this doc: http://docs.openstack.org/developer/networking-ovn/design/data_model.html

Re: [ovs-dev] [RFC] ofpbuf: Update msg when resizing ofpbuf.

2015-07-20 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 08:50:39AM -0700, Alex Wang wrote: On Mon, Jul 20, 2015 at 8:17 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang wrote: Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the 'header' and 'msg' pointers to 'struct

Re: [ovs-dev] [RFC] ofpbuf: Update msg when resizing ofpbuf.

2015-07-20 Thread Alex Wang
Thx for the review, I'll adopt the comment~ On Mon, Jul 20, 2015 at 9:47 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 20, 2015 at 08:50:39AM -0700, Alex Wang wrote: On Mon, Jul 20, 2015 at 8:17 AM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang

Re: [ovs-dev] [PATCH] ofproto-macros: Remove stray garbage from file.

2015-07-20 Thread Andy Zhou
On Mon, Jul 20, 2015 at 1:49 PM, Ben Pfaff b...@nicira.com wrote: Due to the way that Autotest works, this text was ignored, but it's still useless and looks weird and we might as well remove it. Signed-off-by: Ben Pfaff b...@nicira.com Acked-by: Andy Zhou az...@nicira.com

[ovs-dev] [PATCH branch-2.4] tunneling: Mark gre64 tunneling deprecated.

2015-07-20 Thread Pravin B Shelar
GRE64 was introduced to extend gre key from 32-bit to 64-bit using gre-key and sequence number field. But GRE64 is not standard protocol. There are not many users of this protocol. Therefore we have decided to deprecate it. Signed-off-by: Pravin B Shelar pshe...@nicira.com --- NEWS

[ovs-dev] [PATCH] ofproto-macros: Remove stray garbage from file.

2015-07-20 Thread Ben Pfaff
Due to the way that Autotest works, this text was ignored, but it's still useless and looks weird and we might as well remove it. Signed-off-by: Ben Pfaff b...@nicira.com --- tests/ofproto-macros.at | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/ofproto-macros.at

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Kyle Upton
On the master branch, it appears my change wasn't necessary. I had merged 4249b54 and run into the problem. However, 10 pushes later, 3d8dede seems to have fixed the problem without my change. Sorry about that. Thanks, Kyle On 07/20/2015 03:11 PM, Kyle Upton wrote: Without the change, I

[ovs-dev] [PATCH] ovs-sim: Don't install man page.

2015-07-20 Thread Russell Bryant
The build system was set up to install the ovs-sim manpage, but not ovs-sim itself. I noticed this because the fedora rpm build is currently broken because the man page was installed but not packaged yet. Fix this up by not installing the manpage. Signed-off-by: Russell Bryant

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Yeah, this fixes the issue, Do you want to push it? Thanks, Alex Wang, On Mon, Jul 20, 2015 at 1:07 PM, Ben Pfaff b...@nicira.com wrote: OK, I think I see the problem then, can you try this? diff --git a/lib/automake.mk b/lib/automake.mk index fdc518e..bd23ef7 100644 --- a/lib/automake.mk

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Kyle Upton
Without the change, I see the following while doing a build in our modified version of ovs. The input source file is lib/ofp-errors.c instead of ../lib/ofp-errors.c. Same thing occurs with ofp-msgs.c. With the change, I don't see this issue and my thinking was that the object and not the

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Also, here is the compilation error, while running `fakeroot debian/rules binary DEB_BUILD_OPTIONS='parallel=8 nocheck'` using ovs branch-2.4: libtool: compile: gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I ../include -I ./include -I ../lib -I ./lib -I/usr/include -D_FORTIFY_SOURCE=2 -Wstrict-p

Re: [ovs-dev] [PATCH branch-2.4] lib: Fix dependencies on ofp-errors.inc and ofp-msgs.inc.

2015-07-20 Thread Alex Wang
np~ ;D Thx~ On Mon, Jul 20, 2015 at 1:30 PM, Ben Pfaff b...@nicira.com wrote: On Mon, Jul 20, 2015 at 01:27:35PM -0700, Alex Wang wrote: On Mon, Jul 20, 2015 at 1:24 PM, Ben Pfaff b...@nicira.com wrote: correctly. The version on master (commit 5b3c194faa61) did not include the

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Alex Wang
Sorry for the unclarity, I'm building branch-2.4. Master is fine, Thanks, Alex Wang, On Mon, Jul 20, 2015 at 12:11 PM, Kyle Upton kup...@baymicrosystems.com wrote: Without the change, I see the following while doing a build in our modified version of ovs. The input source file is

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Ben Pfaff
OK, I think I see the problem then, can you try this? diff --git a/lib/automake.mk b/lib/automake.mk index fdc518e..bd23ef7 100644 --- a/lib/automake.mk +++ b/lib/automake.mk @@ -486,14 +486,14 @@ $(srcdir)/lib/ofp-errors.inc: \ $(srcdir)/lib/ofp-errors.h \

[ovs-dev] [PATCH branch-2.4] lib: Fix dependencies on ofp-errors.inc and ofp-msgs.inc.

2015-07-20 Thread Ben Pfaff
Commit e21a4c0271e6f (lib/automake.mk: Fix dependency typos.) was crossported from master to fix some observed Debian build failures, but it was not crossported correctly. The version on master (commit 5b3c194faa61) did not include the $(srcdir) prefixes because master had a previous commit

Re: [ovs-dev] [PATCH] lib/automake.mk: Fix dependency typos

2015-07-20 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 01:13:08PM -0700, Alex Wang wrote: Yeah, this fixes the issue, Do you want to push it? I sent a proper patch: http://openvswitch.org/pipermail/dev/2015-July/057798.html ___ dev mailing list dev@openvswitch.org

Re: [ovs-dev] [PATCH branch-2.4] lib: Fix dependencies on ofp-errors.inc and ofp-msgs.inc.

2015-07-20 Thread Alex Wang
On Mon, Jul 20, 2015 at 1:24 PM, Ben Pfaff b...@nicira.com wrote: correctly. The version on master (commit 5b3c194faa61) did not include the $(srcdir) prefixes because master had a previous commit ab70cd304210e (Makefiles: Stop distributing files because building them requires Python.) that

Re: [ovs-dev] [PATCH branch-2.4] lib: Fix dependencies on ofp-errors.inc and ofp-msgs.inc.

2015-07-20 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 01:27:35PM -0700, Alex Wang wrote: On Mon, Jul 20, 2015 at 1:24 PM, Ben Pfaff b...@nicira.com wrote: correctly. The version on master (commit 5b3c194faa61) did not include the $(srcdir) prefixes because master had a previous commit ab70cd304210e (Makefiles: Stop

Re: [ovs-dev] [RFC] ofpbuf: Update msg when resizing ofpbuf.

2015-07-20 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 01:22:32AM -0700, Alex Wang wrote: Commit 6fd6ed7 (ofpbuf: Simplify ofpbuf API.) introduced the 'header' and 'msg' pointers to 'struct ofpbuf'. However, we forget to update the 'msg' pointer when resizing ofpbuf. This bug could cause serious issue. For example, in

[ovs-dev] [PATCH v2 1/5] .travis.yml: Tell travis-ci that sudo support is required

2015-07-20 Thread Aaron Conole
Signed-off-by: Aaron Conole aa...@bytheb.org --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 36d95bd..70cc14b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,6 +5,8 @@ compiler: before_install: ./.travis/prepare.sh +sudo: true + env:

[ovs-dev] [PATCH v2 2/5] datapath-windows/include/automake.mk: Only build for WIN32 builds

2015-07-20 Thread Aaron Conole
Signed-off-by: Aaron Conole aa...@bytheb.org --- datapath-windows/include/automake.mk | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datapath-windows/include/automake.mk b/datapath-windows/include/automake.mk index 31f2fe2..b8dcf83 100644 --- a/datapath-windows/include/automake.mk +++

[ovs-dev] [PATCH v2 0/5] automake: Cleanup to allow make distcheck to succeed

2015-07-20 Thread Aaron Conole
For some time, it seems that the distcheck make target has not functioned properly. This patch works around the automake imposed distcheck read-only directory, as well as signaling to travis-ci that sudo is required. Tested on travis-ci, and Ubuntu 14.04LTS --- This is a re-write from scratch of

[ovs-dev] [PATCH v2 4/5] tests/automake.mk: Changes to support make distcheck

2015-07-20 Thread Aaron Conole
Add autogenerated files to the CLEANFILES so that they are not kept around after clean/distclean Signed-off-by: Aaron Conole aa...@bytheb.org --- tests/automake.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/automake.mk b/tests/automake.mk index 8b54764..1fdb71f 100644 ---

[ovs-dev] [PATCH v2 5/5] vtep/automake.mk: Changes to support make distcheck

2015-07-20 Thread Aaron Conole
Add autogenerated files to the CLEANFILES so that they are not kept around after clean/distclean. Signed-off-by: Aaron Conole aa...@bytheb.org --- vtep/automake.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vtep/automake.mk b/vtep/automake.mk index c712b0c..f44752d

[ovs-dev] [PATCH v2 3/5] lib/automake.mk: Changes to support make distcheck

2015-07-20 Thread Aaron Conole
Eliminate the $(srcdir) requirement on vswitch-idl.ovsidl Also, add autogenerated files to the CLEANFILES so that they are not kept around after clean/distclean. Signed-off-by: Aaron Conole aa...@bytheb.org --- lib/automake.mk | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[ovs-dev] Rate limit the packet-in messages .

2015-07-20 Thread deepaksingh
Hi, I am using openvswitch-2.0.0 ovs. 1. Have Switch connected to OF controller. 2. Node is connected. 3. Run iperf command from node to trigger a lot of packet-in. iperf -c ip -t 1 -u -b 1000MB -l 466 where ip has static arp configured. 4. After 1hr. Switch disconnect from OF controller. 5.