[ovs-dev] RE

2015-07-21 Thread Schrier, Leslie L
I have a proposal for you kindly E-mail me at mshong7...@gmaill.com Leslie L. Schrier, Program Chair Foreign Languages and ESL Education College of Education 244 N Lindquist Center Iowa City, IA 52242 Phone and Messages: 319-335-5048 FAX: 319-335-5608

[ovs-dev] [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Chris J Arges
Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and assumes the node variable returned by for_each_node will index into

Re: [ovs-dev] Rate limit the packet-in messages .

2015-07-21 Thread Ben Pfaff
On Tue, Jul 21, 2015 at 10:08:56AM +0530, deepaksingh wrote: This is the reason affecting WLC CPU. packet-in rate may need to rate-limited to protect the CPU, excess rate (non-LLDP) should be dropped Rate-limiting has been supported since 2009. Please read the documentation.

Re: [ovs-dev] Query related to OF1.4 Group and Meter change notification

2015-07-21 Thread Ben Pfaff
On Tue, Jul 21, 2015 at 03:50:55PM +0530, niti Rohilla wrote: We are implementing Group and meter change notification messages(EXT-235). As per the specification, the structure of Request forward message is:- struct ofp_requestforward_header { struct ofp_header header; /* Type

Re: [ovs-dev] [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and Couldn't this also be

Re: [ovs-dev] [PATCH] tnl-arp-cache: Indentation fixes.

2015-07-21 Thread Pravin Shelar
On Tue, Jul 21, 2015 at 4:03 PM, Ben Pfaff b...@nicira.com wrote: Signed-off-by: Ben Pfaff b...@nicira.com --- lib/tnl-arp-cache.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/tnl-arp-cache.c b/lib/tnl-arp-cache.c index 0113474..b6bfd22 100644 ---

Re: [ovs-dev] [PATCH] tnl-arp-cache: Remove spurious OVS_UNUSED from tnl_arp_cache_flush().

2015-07-21 Thread Pravin Shelar
On Tue, Jul 21, 2015 at 4:05 PM, Ben Pfaff b...@nicira.com wrote: Signed-off-by: Ben Pfaff b...@nicira.com --- lib/tnl-arp-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tnl-arp-cache.c b/lib/tnl-arp-cache.c index b6bfd22..16a805e 100644 ---

Re: [ovs-dev] [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread David Miller
From: Chris J Arges chris.j.ar...@canonical.com Date: Tue, 21 Jul 2015 12:36:33 -0500 Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of

Re: [ovs-dev] [PATCH 2/2] Extend sFlow agent to report tunnel and MPLS structures

2015-07-21 Thread Neil McKee
Wow. That's great. Thanks. I will look at what else we should add to the sFlow export. (e.g. QinQ, NAT, ...). Should be straighforward now that we have the actions for each sample. Neil On Tuesday, July 21, 2015, Ben Pfaff b...@nicira.com wrote: On Fri, Jul 17, 2015 at 09:37:02PM -0700,

[ovs-dev] [PATCH v3 01/10] lib: Add smap_equal().

2015-07-21 Thread Russell Bryant
Add a method to determine of two smaps are equal (have the exact same set of key-value pairs). Signed-off-by: Russell Bryant rbry...@redhat.com --- lib/smap.c | 34 ++ lib/smap.h | 2 ++ 2 files changed, 36 insertions(+) diff --git a/lib/smap.c b/lib/smap.c

[ovs-dev] [PATCH] Makefiles: Clean and do not distribute IDL-generated files.

2015-07-21 Thread Ben Pfaff
IDL-generated files don't need to be distributed, and distributing them puts them in the source directory rather than the build directory, which causes make distcheck to fail if any of them need to be remade. To prevent this, this commit this removes them from ..._SOURCES, moving them into

Re: [ovs-dev] [PATCH v2 1/5] .travis.yml: Tell travis-ci that sudo support is required

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 07:13:47PM -0400, Aaron Conole wrote: Signed-off-by: Aaron Conole aa...@bytheb.org Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 3/5] lib/automake.mk: Changes to support make distcheck

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 07:13:49PM -0400, Aaron Conole wrote: Eliminate the $(srcdir) requirement on vswitch-idl.ovsidl Also, add autogenerated files to the CLEANFILES so that they are not kept around after clean/distclean. Signed-off-by: Aaron Conole aa...@bytheb.org Thanks, applied to

Re: [ovs-dev] [PATCH] ofproto-macros: Remove stray garbage from file.

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 02:18:51PM -0700, Andy Zhou wrote: On Mon, Jul 20, 2015 at 1:49 PM, Ben Pfaff b...@nicira.com wrote: Due to the way that Autotest works, this text was ignored, but it's still useless and looks weird and we might as well remove it. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH v3 10/10] ovn: Add localnet logical port type.

2015-07-21 Thread Russell Bryant
Introduce a new logical port type called localnet. A logical port with this type also has an option called network_name. A localnet logical port represents a connection to a locally accessible network. ovn-controller will use the ovn-bridge-mappings configuration to figure out which patch port

Re: [ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Thomas Graf
On 07/21/15 at 10:30am, Alexei Starovoitov wrote: RX: +info-mode = IP_TUNNEL_INFO_RX; +info-key.tun_flags = TUNNEL_KEY; +info-key.tun_id = cpu_to_be64(vni 8); ... TX: +dst_port = info-key.tp_dst ? : vxlan-dst_port; +vni =

Re: [ovs-dev] OVN configuration

2015-07-21 Thread Russell Bryant
On 07/21/2015 02:16 PM, Ben Pfaff wrote: On Mon, Jul 20, 2015 at 11:18:56AM -0700, Ben Pfaff wrote: On Mon, Jul 20, 2015 at 02:06:26PM -0400, Russell Bryant wrote: I'd really love to get some feedback from those with more ops experience on this. I want to do whatever works and makes their

[ovs-dev] [PATCH v3 04/10] ovn: Drop unnecessary br_int local variable.

2015-07-21 Thread Russell Bryant
When getting the initial configuration, go ahead and store br_int in the controller context. This is already done in the main loop, but a future patch wants to use br_int from the controller context sooner in the code. Signed-off-by: Russell Bryant rbry...@redhat.com ---

[ovs-dev] [PATCH v3 03/10] ovn: Make column comparisons more generic.

2015-07-21 Thread Russell Bryant
The logic in ovn-northd's parents_equal() and tags_equal() is useful for other columns, so convert them into more generic functions that can be reused. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/northd/ovn-northd.c | 31 --- 1 file changed, 20

[ovs-dev] [PATCH v3 05/10] ovn: Add bridge mappings to ovn-controller.

2015-07-21 Thread Russell Bryant
Add a new OVN configuration entry in the Open_vSwitch database called ovn-bridge-mappings. This allows the configuration of mappings between a physical network name and an OVS bridge that provides connectivity to that network. For example, if you wanted to configure physnet1 to map to br-eth0

[ovs-dev] [PATCH v3 06/10] ovn: Add patch ports for ovn bridge mappings.

2015-07-21 Thread Russell Bryant
While parsing the OVN bridge mapping configuration, ensure that patch ports exist between the OVN integration bridge and the physical network bridge. If they do not exist, create them automatically. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/controller/ovn-controller.c | 114

[ovs-dev] [PATCH v3 07/10] ovn: Set up some bridge mappings in ovs-sandbox.

2015-07-21 Thread Russell Bryant
A recent patch added a new OVN configuration option called ovn-bridge-mappings. Create some bridges and configure ovn-bridge-mappings to make testing this part of OVN easier. This setup will not interfere with anything unless you try to create networks that make use of it. Signed-off-by:

[ovs-dev] [PATCH v3 08/10] ovn: Add type and options to logical port.

2015-07-21 Thread Russell Bryant
We have started discussing the use of the logical port abstraction in OVN to represent special types of connections into an OVN logical switch. This patch proposes some schema updates to reflect these special types of logical ports. A logical port can have a type and a set of options specific to

Re: [ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Alexei Starovoitov
On 7/21/15 1:43 AM, Thomas Graf wrote: This prepares the VXLAN device to be steered by the routing and other subsystems which allows to support encapsulation for a large number of tunnel endpoints and tunnel ids through a single net_device which improves the scalability. +1. looks very useful.

[ovs-dev] [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Chris J Arges
Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and assumes the node variable returned by for_each_node will index into

[ovs-dev] intra VM communication

2015-07-21 Thread Srikanth Akula
Hello, I am trying to use vhost-user for sending traffic between VMs . I have configured two dpdkvhostuser interfaces each VM using one of them each . vswitchd is running with dpdk. Qemu is running with the vhost interfaces Guest OS can see interfaces - Verified with the static MAC i have

[ovs-dev] [PATCH v3 09/10] ovn: Get/set lport type and options in ovn-nbctl.

2015-07-21 Thread Russell Bryant
A recent patch added type and options columns to the Logical_Port table in OVN_Northbound. This patch allows you to get and set those columns with ovn-nbctl. Signed-off-by: Russell Bryant rbry...@redhat.com --- ovn/ovn-nbctl.8.xml | 24 ++-- ovn/ovn-nbctl.c | 111

[ovs-dev] [PATCH v3 00/10] OVN support for Neutron provider networks

2015-07-21 Thread Russell Bryant
v2-v3: - Dropped first patch that was merged. - Reorder remaining patches to put everything directly related to the feature at the end and all of the pre-reqs at the beginning. - Update flows to ensure that a packet that comes in via a localnet port never goes out over a tunnel to avoid

Re: [ovs-dev] [PATCH v2 2/5] datapath-windows/include/automake.mk: Only build for WIN32 builds

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 07:13:48PM -0400, Aaron Conole wrote: Signed-off-by: Aaron Conole aa...@bytheb.org Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 4/5] tests/automake.mk: Changes to support make distcheck

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 07:13:50PM -0400, Aaron Conole wrote: Add autogenerated files to the CLEANFILES so that they are not kept around after clean/distclean Signed-off-by: Aaron Conole aa...@bytheb.org Thanks, applied to master. ___ dev mailing

Re: [ovs-dev] [PATCH v2 5/5] vtep/automake.mk: Changes to support make distcheck

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 07:13:51PM -0400, Aaron Conole wrote: Add autogenerated files to the CLEANFILES so that they are not kept around after clean/distclean. Signed-off-by: Aaron Conole aa...@bytheb.org Thanks, applied to master. ___ dev

Re: [ovs-dev] [PATCH net-next 00/22 v2] Lightweight flow based encapsulation

2015-07-21 Thread David Miller
From: Thomas Graf tg...@suug.ch Date: Tue, 21 Jul 2015 10:43:44 +0200 This series combines the work previously posted by Roopa, Robert and myself. It's according to what we discussed at NFWS. The motivation of this series is to: * Consolidate code between OVS and the rest of the kernel and

Re: [ovs-dev] OVN configuration

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 11:18:56AM -0700, Ben Pfaff wrote: On Mon, Jul 20, 2015 at 02:06:26PM -0400, Russell Bryant wrote: On 07/20/2015 01:46 PM, Ben Pfaff wrote: Regarding this patch, to be honest, the choice of bridge mappings is just borrowed from the existing OVS support in

[ovs-dev] [PATCH branch-2.4 v2] tunnel: Mark GRE64 tunnel protocol deprecated.

2015-07-21 Thread Pravin B Shelar
GRE64 was introduced to extend GRE key from 32-bit to 64-bit using key and sequence number field. But GRE64 is not standard protocol. There are not many users of this protocol. Therefore we have decided to deprecate it. Since GRE64 is not in upstream OVS kernel module removing it will bring

Re: [ovs-dev] [PATCH] Makefiles: Clean and do not distribute IDL-generated files.

2015-07-21 Thread Aaron Conole
Ben Pfaff b...@nicira.com writes: IDL-generated files don't need to be distributed, and distributing them puts them in the source directory rather than the build directory, which causes make distcheck to fail if any of them need to be remade. To prevent this, this commit this removes them

Re: [ovs-dev] [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Pravin Shelar
On Tue, Jul 21, 2015 at 10:36 AM, Chris J Arges chris.j.ar...@canonical.com wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes()

Re: [ovs-dev] [PATCH] doc: Document proposed OVN Gateway HA design.

2015-07-21 Thread Ben Pfaff
On Tue, Jul 21, 2015 at 11:32:21AM -0700, Ethan Jackson wrote: Thanks for the review, I've addressed the comments and will send out another version of the patch shortly. One comment on the feedback below. Under Controller Independent Active-backup, I am not sure that I buy the argument

Re: [ovs-dev] another provider network idea

2015-07-21 Thread Salvatore Orlando
This makes sense to me as well. It's surely better to have structured data rather then encode them in resource names. In the options attribute for a local logical port, I guess the name attribute will be the name of some ovs bridge instance where the port is plugged. From a neutron integration

Re: [ovs-dev] another provider network idea

2015-07-21 Thread Russell Bryant
On 07/21/2015 03:07 PM, Salvatore Orlando wrote: This makes sense to me as well. It's surely better to have structured data rather then encode them in resource names. In the options attribute for a local logical port, I guess the name attribute will be the name of some ovs bridge instance

Re: [ovs-dev] [PATCH] doc: Document proposed OVN Gateway HA design.

2015-07-21 Thread Ethan Jackson
Thanks for the review, I've addressed the comments and will send out another version of the patch shortly. One comment on the feedback below. Under Controller Independent Active-backup, I am not sure that I buy the argument here, because currently ovn-northd doesn't care about the layout of

Re: [ovs-dev] [PATCH] ovs-sim: Don't install man page.

2015-07-21 Thread Ben Pfaff
On Mon, Jul 20, 2015 at 05:34:09PM -0400, Russell Bryant wrote: The build system was set up to install the ovs-sim manpage, but not ovs-sim itself. I noticed this because the fedora rpm build is currently broken because the man page was installed but not packaged yet. Fix this up by not

Re: [ovs-dev] [PATCH 2/2] db-ctl-base: make cmd_show_table private

2015-07-21 Thread Ben Pfaff
On Fri, Jul 17, 2015 at 05:12:45PM -0700, Andy Zhou wrote: Instead of requiring user to declare a global variable, pass the value via ctl_init(). Signed-off-by: Andy Zhou az...@nicira.com I think that cmd_show_tables should be 'static'. Acked-by: Ben Pfaff b...@nicira.com

Re: [ovs-dev] [PATCH] ofp-print: Abbreviate duplicated table features.

2015-07-21 Thread Ben Pfaff
On Mon, Jul 06, 2015 at 10:17:05PM -0700, Ben Pfaff wrote: I spent some time recently looking at the results of ovs-ofctl dump-table-features. It was really distressing because of the volume of information. Every table yielded well over 100 lines of output and for 253 (visible) tables that

Re: [ovs-dev] [PATCH] doc: Document proposed OVN Gateway HA design.

2015-07-21 Thread Ethan Jackson
No worries. I sent a new version (actually ran spell check on this one ;) ) On Tue, Jul 21, 2015 at 11:35 AM, Ben Pfaff b...@nicira.com wrote: On Tue, Jul 21, 2015 at 11:32:21AM -0700, Ethan Jackson wrote: Thanks for the review, I've addressed the comments and will send out another version of

Re: [ovs-dev] [PATCH] rhel: fix ifup-ovs to delete ports first

2015-07-21 Thread Flavio Leitner
On Tue, Jul 21, 2015 at 11:38:01AM -0700, Ben Pfaff wrote: On Fri, Jul 17, 2015 at 01:56:21PM -0300, Flavio Leitner wrote: When ifdown isn't executed (system didn't shut down properly), the interfaces remain in the openvswitch's database. For the internal ports or devices that are

Re: [ovs-dev] [ovn-controller-vtep V4 4/6] ovn-controller-vtep: Add gateway module.

2015-07-21 Thread Russell Bryant
On 07/16/2015 03:56 AM, Alex Wang wrote: This commit adds the gateway module to ovn-controller-vtep. The module will register the physical switches to ovnsb as chassis and constantly update the vtep_logical_switches column in Chassis table. Limitation: - Do not support reading multiple

Re: [ovs-dev] another provider network idea

2015-07-21 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 11:59:30AM -0400, Russell Bryant wrote: On 07/14/2015 10:59 AM, Ben Pfaff wrote: Here's an a strawman alternative. Instead of representing a provider network as a single logical network, represent it as a collection of logical networks, one for each connected port.

Re: [ovs-dev] [PATCH] rhel: fix ifup-ovs to delete ports first

2015-07-21 Thread Ben Pfaff
On Fri, Jul 17, 2015 at 01:56:21PM -0300, Flavio Leitner wrote: When ifdown isn't executed (system didn't shut down properly), the interfaces remain in the openvswitch's database. For the internal ports or devices that are available when openvswitch service starts that's not an issue.

Re: [ovs-dev] [PATCH 1/2] db-ctl-base: remove the recurse member from struct cmd_show_table

2015-07-21 Thread Ben Pfaff
On Fri, Jul 17, 2015 at 05:12:44PM -0700, Andy Zhou wrote: The 'recurse' is used during run time to suppress duplicated prints. It is not essential to describe how show command should work. This patch remove the 'recurse' member. Duplicated prints is now suppressed by maintaining an 'sset'

[ovs-dev] [PATCH v2] doc: Document proposed OVN Gateway HA design.

2015-07-21 Thread Ethan Jackson
High availability for gateways in network virtualization deployments is fairly difficult to get right. There are a ton of options, most of which are too complicated or perform badly. To help solve this problem, this patch proposes an HA design based on some of the lessons learned building

Re: [ovs-dev] [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [12:36:33 -0500], Chris J Arges wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory corruption with openvswitch since it allocates flow_cache with a multiple of num_possible_nodes() and assumes the node variable

Re: [ovs-dev] [ovn-controller-vtep V4 5/6] ovn-controller-vtep: Add binding module.

2015-07-21 Thread Russell Bryant
On 07/16/2015 03:56 AM, Alex Wang wrote: This commit adds the binding module to ovn-controller-vtep. The module will scan through the Binding table in ovnsb. If there is a binding for a logical port in the vtep gateway chassis's vtep_logical_switches map, sets the binding's chassis column to

Re: [ovs-dev] [PATCH] Extend sFlow agent to report tunnel and MPLS structures

2015-07-21 Thread Ben Pfaff
On Fri, Jul 17, 2015 at 09:37:02PM -0700, Neil McKee wrote: Packets are still sampled at ingress only, so the egress tunnel and/or MPLS structures are only included when there is just 1 output port. The actions are either provided by the datapath in the sample upcall or looked up in the

Re: [ovs-dev] [PATCH] openvswitch: make for_each_node loops work with sparse numa systems

2015-07-21 Thread Nishanth Aravamudan
On 21.07.2015 [11:30:58 -0500], Chris J Arges wrote: On Tue, Jul 21, 2015 at 09:24:18AM -0700, Nishanth Aravamudan wrote: On 21.07.2015 [10:32:34 -0500], Chris J Arges wrote: Some architectures like POWER can have a NUMA node_possible_map that contains sparse entries. This causes memory

Re: [ovs-dev] [PATCH] rhel: fix ifup-ovs to delete ports first

2015-07-21 Thread Ben Pfaff
On Tue, Jul 21, 2015 at 04:52:01PM -0300, Flavio Leitner wrote: On Tue, Jul 21, 2015 at 11:38:01AM -0700, Ben Pfaff wrote: On Fri, Jul 17, 2015 at 01:56:21PM -0300, Flavio Leitner wrote: When ifdown isn't executed (system didn't shut down properly), the interfaces remain in the

[ovs-dev] [PATCH] tunneling: Remove gre64 tunnel support.

2015-07-21 Thread Pravin B Shelar
GRE64 was introduced to extend gre key from 32-bit to 64-bit using gre-key and sequence number field. But GRE64 is not standard protocol. There are not many users of this protocol. Therefore we have decided to remove it. Signed-off-by: Pravin B Shelar pshe...@nicira.com --- I have also removed

Re: [ovs-dev] [PATCH branch-2.4] tunneling: Mark gre64 tunneling deprecated.

2015-07-21 Thread Jesse Gross
On Tue, Jul 21, 2015 at 12:22 AM, Pravin B Shelar pshe...@nicira.com wrote: GRE64 was introduced to extend gre key from 32-bit to 64-bit using gre-key and sequence number field. But GRE64 is not standard protocol. There are not many users of this protocol. Therefore we have decided to

Re: [ovs-dev] [PATCH] [ovn] Add 'name' field to logical router port NB schema

2015-07-21 Thread Ben Pfaff
Applied, thanks. (The patch had some wordwrapping in it--I fixed it up this time but please be more careful.) ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH branch-2.4] tunneling: Mark gre64 tunneling deprecated.

2015-07-21 Thread Pravin Shelar
On Tue, Jul 21, 2015 at 3:41 PM, Jesse Gross je...@nicira.com wrote: On Tue, Jul 21, 2015 at 12:22 AM, Pravin B Shelar pshe...@nicira.com wrote: GRE64 was introduced to extend gre key from 32-bit to 64-bit using gre-key and sequence number field. But GRE64 is not standard protocol. There are

[ovs-dev] [PATCH] tnl-arp-cache: Remove spurious OVS_UNUSED from tnl_arp_cache_flush().

2015-07-21 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/tnl-arp-cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tnl-arp-cache.c b/lib/tnl-arp-cache.c index b6bfd22..16a805e 100644 --- a/lib/tnl-arp-cache.c +++ b/lib/tnl-arp-cache.c @@ -154,7 +154,7 @@

Re: [ovs-dev] kernel module testing

2015-07-21 Thread Jesse Gross
On Sat, Jul 18, 2015 at 6:46 PM, Ben Pfaff b...@nicira.com wrote: On Fri, Jul 17, 2015 at 04:18:08PM -0700, Jesse Gross wrote: On Thu, Jul 16, 2015 at 12:04 PM, Kyle Mestery mest...@mestery.com wrote: On Thu, Jul 16, 2015 at 12:55 PM, Ben Pfaff b...@nicira.com wrote: On Tue, Jul 14, 2015

[ovs-dev] [PATCH] tnl-arp-cache: Indentation fixes.

2015-07-21 Thread Ben Pfaff
Signed-off-by: Ben Pfaff b...@nicira.com --- lib/tnl-arp-cache.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/tnl-arp-cache.c b/lib/tnl-arp-cache.c index 0113474..b6bfd22 100644 --- a/lib/tnl-arp-cache.c +++ b/lib/tnl-arp-cache.c @@ -75,8 +75,8 @@

Re: [ovs-dev] [PATCH v3 00/10] OVN support for Neutron provider networks

2015-07-21 Thread Salvatore Orlando
I reckon that this approach makes sense, as it alters very little OVN's northbound schema; moreover at first glance I do not see in the patch series any change to the OVN pipeline. Also mapping neutron provider networks extension onto OVN should not be too difficult. Perhaps neutron will have to

[ovs-dev] Query related to OF1.4 Group and Meter change notification

2015-07-21 Thread niti Rohilla
Hi Ben, We are implementing Group and meter change notification messages(EXT-235). As per the specification, the structure of Request forward message is:- struct ofp_requestforward_header { struct ofp_header header; /* Type OFPT_REQUESTFORWARD. */ struct ofp_header request; /* Request

[ovs-dev] [PATCH net-next 06/22] ipv4: redirect dst output to lwtunnel output

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com For input routes with tunnel encap state this patch redirects dst output functions to lwtunnel_output which later resolves to the corresponding lwtunnel output function. This has been tested to work with mpls ip tunnels. Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 12/22] dst: Metadata destinations

2015-07-21 Thread Thomas Graf
Introduces a new dst_metadata which enables to carry per packet metadata between forwarding and processing elements via the skb-dst pointer. The structure is set up to be a union. Thus, each separate type of metadata requires its own dst instance. If demand arises to carry multiple types of

[ovs-dev] [PATCH net-next 08/22] mpls: export mpls functions for use by mpls iptunnels

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/mpls/af_mpls.c | 11 --- net/mpls/internal.h | 9 +++-- 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index

[ovs-dev] [PATCH net-next 09/22] mpls: ip tunnel support

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This implementation uses lwtunnel infrastructure to register hooks for mpls tunnel encaps. It picks cues from iptunnel_encaps infrastructure and previous mpls iptunnel RFC patches from Eric W. Biederman and Robert Shearman Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 22/22] openvswitch: Use regular VXLAN net_device device

2015-07-21 Thread Thomas Graf
This gets rid of all OVS specific VXLAN code in the receive and transmit path by using a VXLAN net_device to represent the vport. Only a small shim layer remains which takes care of handling the VXLAN specific OVS Netlink configuration. Unexports vxlan_sock_add(), vxlan_sock_release(),

[ovs-dev] [PATCH net-next 18/22] vxlan: Factor out device configuration

2015-07-21 Thread Thomas Graf
This factors out the device configuration out of the RTNL newlink API which allows for in-kernel creation of VXLAN net_devices. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c | 332 include/net/vxlan.h | 59 ++ 2

[ovs-dev] [PATCH net-next 13/22] arp: Inherit metadata dst when creating ARP requests

2015-07-21 Thread Thomas Graf
If output device wants to see the dst, inherit the dst of the original skb and pass it on to generate the ARP request. Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/arp.c | 65 +- 1 file changed, 37 insertions(+), 28 deletions(-)

[ovs-dev] [PATCH net-next 20/22] openvswitch: Move dev pointer into vport itself

2015-07-21 Thread Thomas Graf
This is the first step in representing all OVS vports as regular struct net_devices. Move the net_device pointer into the vport structure itself to get rid of struct vport_netdev. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com ---

[ovs-dev] [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Thomas Graf
Allows putting a VXLAN device into a new flow-based mode in which skbs with a ip_tunnel_info dst metadata attached will be encapsulated according to the instructions stored in there with the VXLAN device defaults taken into consideration. Similar on the receive side, if the

[ovs-dev] [PATCH net-next 19/22] openvswitch: Make tunnel set action attach a metadata dst

2015-07-21 Thread Thomas Graf
Utilize the new metadata dst to attach encapsulation instructions to the skb. The existing egress_tun_info via the OVS_CB() is left in place until all tunnel vports have been converted to the new method. Signed-off-by: Thomas Graf tg...@suug.ch Signed-off-by: Pravin B Shelar pshe...@nicira.com

[ovs-dev] [PATCH net-next 16/22] route: Per route IP tunnel metadata via lightweight tunnel

2015-07-21 Thread Thomas Graf
This introduces a new IP tunnel lightweight tunnel type which allows to specify IP tunnel instructions per route. Only IPv4 is supported at this point. Signed-off-by: Thomas Graf tg...@suug.ch --- drivers/net/vxlan.c| 10 +++- include/net/dst_metadata.h | 12 -

[ovs-dev] [PATCH net-next 11/22] icmp: Don't leak original dst into ip_route_input()

2015-07-21 Thread Thomas Graf
ip_route_input() unconditionally overwrites the dst. Hide the original dst attached to the skb by calling skb_dst_set(skb, NULL) prior to ip_route_input(). Reported-by: Julian Anastasov j...@ssi.bg Signed-off-by: Thomas Graf tg...@suug.ch --- net/ipv4/icmp.c | 1 + 1 file changed, 1 insertion(+)

[ovs-dev] [PATCH net-next 17/22] fib: Add fib rule match on tunnel id

2015-07-21 Thread Thomas Graf
This add the ability to select a routing table based on the tunnel id which allows to maintain separate routing tables for each virtual tunnel network. ip rule add from all tunnel-id 100 lookup 100 ip rule add from all tunnel-id 200 lookup 200 A new static key controls the collection of metadata

[ovs-dev] [PATCH net-next 15/22] route: Extend flow representation with tunnel key

2015-07-21 Thread Thomas Graf
Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to allow routes to match on tunnel metadata. For now, the tunnel id is added to flowi_tunnel which allows for routes to be bound to specific virtual tunnels. Signed-off-by: Thomas Graf tg...@suug.ch --- include/net/flow.h |

Re: [ovs-dev] Support for MCAST_Snooping

2015-07-21 Thread Renuka Sachidev
BTW, Check if the VM client is in different sub-net. I know for sure if the Machine on same sub-net it should work. That could be an issue with your setup. Send out the Test topology so that it can help other in the thread to help you. Regards, Renuka -Original Message- From: Renuka

[ovs-dev] [PATCH net-next 04/22] ipv6: support for fib route lwtunnel encap attributes

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv6 fib functions to parse Netlink RTA encap attributes and attach encap state data to rt6_info. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip6_fib.h | 3 +++ net/ipv6/ip6_fib.c| 2 ++

[ovs-dev] [PATCH net-next 00/22 v2] Lightweight flow based encapsulation

2015-07-21 Thread Thomas Graf
This series combines the work previously posted by Roopa, Robert and myself. It's according to what we discussed at NFWS. The motivation of this series is to: * Consolidate code between OVS and the rest of the kernel and get rid of OVS vports and instead represent them as pure net_devices. *

[ovs-dev] [PATCH net-next 02/22] lwtunnel: infrastructure for handling light weight tunnels like mpls

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com Provides infrastructure to parse/dump/store encap information for light weight tunnels like mpls. Encap information for such tunnels is associated with fib routes. This infrastructure is based on previous suggestions from Eric Biederman to follow the

[ovs-dev] [PATCH net-next 01/22] rtnetlink: introduce new RTA_ENCAP_TYPE and RTA_ENCAP attributes

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces two new RTA attributes to attach encap data to fib routes. Example iproute2 command to attach mpls encap data to ipv4 routes $ip route add 10.1.1.0/30 encap mpls 200 via inet 10.1.1.1 dev swp1 Signed-off-by: Roopa Prabhu

[ovs-dev] [PATCH net-next 05/22] lwtunnel: support dst output redirect function

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch introduces lwtunnel_output function to call corresponding lwtunnels output function to xmit the packet. It adds two variants lwtunnel_output and lwtunnel_output6 for ipv4 and ipv6 respectively today. But this is subject to change when

[ovs-dev] [PATCH net-next 03/22] ipv4: support for fib route lwtunnel encap attributes

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This patch adds support in ipv4 fib functions to parse user provided encap attributes and attach encap state data to fib_nh and rtable. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- include/net/ip_fib.h | 5 ++- include/net/route.h

[ovs-dev] [PATCH net-next 07/22] ipv6: rt6_info output redirect to tunnel output

2015-07-21 Thread Thomas Graf
From: Roopa Prabhu ro...@cumulusnetworks.com This is similar to ipv4 redirect of dst output to lwtunnel output function for encapsulation and xmit. Signed-off-by: Roopa Prabhu ro...@cumulusnetworks.com --- net/ipv6/route.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/route.c

[ovs-dev] [PATCH net-next 21/22] openvswitch: Abstract vport name through ovs_vport_name()

2015-07-21 Thread Thomas Graf
This allows to get rid of the get_name() vport ops later on. Signed-off-by: Thomas Graf tg...@suug.ch --- net/openvswitch/datapath.c | 4 ++-- net/openvswitch/vport-internal_dev.c | 1 - net/openvswitch/vport-netdev.c | 6 -- net/openvswitch/vport-netdev.h | 1 -

[ovs-dev] [PATCH] [ovn] Add 'name' field to logical router port NB schema

2015-07-21 Thread Gal Sagie
From 1129ecfd70d64f95ac63ca4e91c3d2c5d4782b6e Mon Sep 17 00:00:00 2001 From: Gal Sagie gal.sa...@gmail.com Date: Tue, 21 Jul 2015 09:11:12 +0300 Subject: [PATCH] [ovn] Add 'name' field to logical router port NB schema Signed-off-by: Gal Sagie gal.sa...@gmail.com --- ovn/ovn-nb.ovsschema | 1 +