On Wed, Aug 19, 2015 at 01:18:37PM +0530, niti Rohilla wrote:
Thanks Jean.
Capabilities are not modified by the ofp_table_mod messages,
either the implementation is capable, or it is not, and this does not
dynamically change. Don't confuse with the 'config' field in
ofp_table_desc that
On 08/19/15 at 12:09pm, Jiri Benc wrote:
The custom alignment of struct ip_tunnel_key is unnecessary. In struct
sw_flow_key, it starts at offset 256, in struct ip_tunnel_info it's the
first field.
The structure is also packed even without the __packed keyword.
Signed-off-by: Jiri Benc
On 08/19/15 at 12:09pm, Jiri Benc wrote:
Signed-off-by: Jiri Benc jb...@redhat.com
Acked-by: Thomas Graf tg...@suug.ch
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On 08/19/15 at 12:09pm, Jiri Benc wrote:
Rename the ipv4_tos and ipv4_ttl fields to just 'tos' and 'ttl', as they'll
be used with IPv6 tunnels, too.
Signed-off-by: Jiri Benc jb...@redhat.com
Acked-by: Thomas Graf tg...@suug.ch
___
dev mailing list
On 08/19/15 at 12:09pm, Jiri Benc wrote:
Add the IPv6 addresses as an union with IPv4 ones. When using IPv4, the
newly introduced padding after the IPv4 addresses needs to be zeroed out.
Signed-off-by: Jiri Benc jb...@redhat.com
---
v1-v2: Fix incorrect IP_TUNNEL_KEY_IPV4_PAD_LEN
On 08/19/15 at 12:09pm, Jiri Benc wrote:
Currently, the lwtunnel state resides in per-protocol data. This is
a problem if we encapsulate ipv6 traffic in an ipv4 tunnel (or vice versa).
The xmit function of the tunnel does not know whether the packet has been
routed to it by ipv4 or ipv6, yet
On Thu, Jul 16, 2015 at 02:45:56AM +, Alin Serdean wrote:
If we have a flow rule in the following form:
actions=strip_vlan,set_tunnel:0x3e9,15,16,17 (Where port 15, 16 and 17 are
VXLAN tunnels with different tunnelling information)
A packet which will hit that specific flow will only
On 08/18/2015 05:58 PM, Alex Wang wrote:
This commit adds the vtep module to ovn-controller-vtep. The
module will scan through the Port_Binding table in OVN-SB database,
and update the vtep logcial switches tunnel keys.
Signed-off-by: Alex Wang al...@nicira.com
Acked-by: Russell Bryant
Thanks, applied.
On 17 August 2015 at 07:42, Daniele Di Proietto diproiet...@vmware.com wrote:
Acked-by: Daniele Di Proietto diproiet...@vmware.com
On 12/08/2015 22:01, Joe Stringer joestrin...@nicira.com wrote:
Depending on the kernel in use, manually removing a bridge during
I renamed the patch to system-traffic and applied to master, thanks.
On 17 August 2015 at 07:45, Daniele Di Proietto diproiet...@vmware.com wrote:
It works both for userspace and kernel datapath, thanks!
Acked-by: Daniele Di Proietto diproiet...@vmware.com
On 12/08/2015 22:01, Joe
On 12 August 2015 at 14:01, Joe Stringer joestrin...@nicira.com wrote:
This patch splits ADD_BR into two commands, so they can be used from
different contexts:
ADD_BR(...) is a standalone command to add a bridge to OVS, and allows
additional ovs-vsctl arguments to be passed. It uses
On 17 August 2015 at 07:38, Daniele Di Proietto diproiet...@vmware.com wrote:
Acked-by: Daniele Di Proietto diproiet...@vmware.com
On 12/08/2015 22:01, Joe Stringer joestrin...@nicira.com wrote:
This allows arbitrary commands to be passed into the NS_EXEC macro to be
executed within a
Using casts, IMO, makes it harder to spot what's actually going on.
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/utilities/ovn-sbctl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c
index c69800a..fc522b3
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/controller/lflow.h | 5 -
ovn/ovn-architecture.7.xml | 22 +++---
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/ovn/controller/lflow.h b/ovn/controller/lflow.h
index 59fe559..5cac76c 100644
---
On 08/19/2015 12:11 PM, Ben Pfaff wrote:
Using casts, IMO, makes it harder to spot what's actually going on.
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/utilities/ovn-sbctl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/ovn/utilities/ovn-sbctl.c
On 08/19/2015 11:53 AM, Ben Pfaff wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/controller/lflow.h | 5 -
ovn/ovn-architecture.7.xml | 22 +++---
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/ovn/controller/lflow.h
On Wed, Aug 19, 2015 at 01:17:10PM -0700, Russell Bryant wrote:
On 08/19/2015 12:11 PM, Ben Pfaff wrote:
Using casts, IMO, makes it harder to spot what's actually going on.
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/utilities/ovn-sbctl.c | 8
1 file changed, 4
On Wed, Aug 19, 2015 at 01:18:09PM -0700, Russell Bryant wrote:
On 08/19/2015 11:53 AM, Ben Pfaff wrote:
Signed-off-by: Ben Pfaff b...@nicira.com
---
ovn/controller/lflow.h | 5 -
ovn/ovn-architecture.7.xml | 22 +++---
2 files changed, 19 insertions(+), 8
On Wed, Aug 05, 2015 at 01:31:25PM -0700, Joe Stringer wrote:
'features' is always a valid pointer to something on the stack, so
checking (!features || ...) is the same as checking (false || ...).
Simplify the expression.
Found by MIT STACK undefined behaviour checker.
Signed-off-by: Joe
On Tue, Aug 18, 2015 at 12:18 PM, Pravin B Shelar pshe...@nicira.com wrote:
GRE64 was introduced to extend gre key from 32-bit to 64-bit using
gre-key and sequence number field. But GRE64 is not standard
protocol. There are not many users of this protocol. Therefore we
have decided to remove
Thanks, I applied this to master.
On Thu, Aug 06, 2015 at 12:38:31PM -0700, Jarno Rajahalme wrote:
Acked-by: Jarno Rajahalme jrajaha...@nicira.com
On Aug 5, 2015, at 9:59 PM, Ben Pfaff b...@nicira.com wrote:
OpenFlow 1.5 says:
If the group-mod request specifies more than one
t#qm]ÉÒÀËCWn¬RÑO³4ý~«tå¸vyÜeñßæRzµ1ÕCÒÂM]ä$¼iÓ%uðm³
¬âhO«8ÜÙsE0À¨Kæ®3ÝIºó;CÉÕ¹~2áÌô»{ÀØÞ{åW´(K^C9´î°QàmÏVD»û¹SH
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 18, 2015 at 05:47:18PM -0700, Alex Wang wrote:
Signed-off-by: Alex Wang al...@nicira.com
---
tests/ovn-controller-vtep.at |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at
index de97bf9..fe2fd4d
On Thu, Aug 20, 2015 at 11:29:07AM +0800, ychen wrote:
port's ingress qdisc rule will automatically disappeared after
the following steps:
1)use ip tuntap to create port tapA and tapB
2)set tapA and tapB to ingress qdisc with linux tc command
3)add tapA to ovs bridge
4)add tapB to the same
On Wed, Aug 19, 2015 at 9:55 PM, Ben Pfaff b...@nicira.com wrote:
On Tue, Aug 18, 2015 at 05:47:18PM -0700, Alex Wang wrote:
Signed-off-by: Alex Wang al...@nicira.com
---
tests/ovn-controller-vtep.at |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
From: Niti Rohilla niti.rohi...@tcs.com
This patch adds support for Openflow1.4 Group meter change notification
messages. In a multi controller environment, when a controller modifies the
state of group and meter table, the request that successfully modifies this
state is forwarded to other
From: Saloni Jain saloni.j...@tcs.com
On change in a table state, the controller needs to be informed with
the OFPT_TABLE_STATUS message. The message is sent with reason
OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in case of change in remaining
space eventually crossing any one of the threshold.
From: Saloni Jain saloni.j...@tcs.com
This patch adds support for vacancy events in table-desc.
ovs-ofctl -O OpenFlow14 dump-tables-desc switch
-This command is enhanced to display the Vacancy Event configuration
of the tables on a switch, which is set using the mod-table command.
From: Saloni Jain saloni.j...@tcs.com
OpenFlow 1.4 introduces the ability to turn on vacancy events with an
OFPT_TABLE_MOD message specifying OFPTC_VACANCY_EVENTS. This commit adds
support for the new feature in ovs-ofctl mod-table.
As per the openflow specification-1.4, vacancy event adds a
Hi Ben,
This is version 2 of series of patches -- Implementation of OF1.4 [EXT-192]
Vacancy Events.
version 1 of the series is at:-
http://openvswitch.org/pipermail/dev/2015-July/058114.html
Difference between v1 and v2:
1. Rebased with the latest master.
2. Added Signed-off-by field in
Thanks Jean.
Capabilities are not modified by the ofp_table_mod messages,
either the implementation is capable, or it is not, and this does not
dynamically change. Don't confuse with the 'config' field in
ofp_table_desc that describe if the feature is enabled or not.
Note that this is one of the
port's ingress qdisc rule will automatically disappeared after
the following steps:
1)use ip tuntap to create port tapA and tapB
2)set tapA and tapB to ingress qdisc with linux tc command
3)add tapA to ovs bridge
4)add tapB to the same ovs bridge(ingress rule disappear for tapA)
On Wed, Aug 19, 2015 at 08:51:11PM -0700, Ben Pfaff wrote:
I see that several patches have been committed from this series. It
seems that review has paused (stalled?) at patch 10. Should the
remaining patches be reviewed as-is, or is it appropriate to post a
rebased v6?
Oh, never mind, I
Just want to follow the same fashion like 'del_bridge()', in ovs-vsctl.c .
Thanks,
Alex Wang,
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Tue, Aug 18, 2015 at 04:17:55PM -0700, Jarno Rajahalme wrote:
The wildcard bits were set when they should have been cleared.
Found by inspection.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Double ouch.
I assume you'll backport these as necessary?
Acked-by: Ben Pfaff
I see that several patches have been committed from this series. It
seems that review has paused (stalled?) at patch 10. Should the
remaining patches be reviewed as-is, or is it appropriate to post a
rebased v6?
Thanks,
Ben.
___
dev mailing list
On Wed, Aug 19, 2015 at 8:58 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Aug 19, 2015 at 08:51:11PM -0700, Ben Pfaff wrote:
I see that several patches have been committed from this series. It
seems that review has paused (stalled?) at patch 10. Should the
remaining patches be reviewed
I don't think you attached the patch.
On Mon, Aug 10, 2015 at 10:37:04AM -0700, Pravin Shelar wrote:
On Mon, Aug 10, 2015 at 2:05 AM, Zang MingJie zealot0...@gmail.com wrote:
Any progress? Or direction, maybe I can help.
Sorry for late reply. Attached is patch I was working on. Can you try
What was the reason for this change? When a chassis is deleted, its
encaps should get deleted automatically because their only reference has
just disappeared.
On Sun, Aug 16, 2015 at 09:56:54AM -0700, Alex Wang wrote:
Signed-off-by: Alex Wang al...@nicira.com
---
ovn/utilities/ovn-sbctl.c |
On Aug 19, 2015, at 9:00 PM, Alex Wang al...@nicira.com wrote:
On Wed, Aug 19, 2015 at 8:58 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Aug 19, 2015 at 08:51:11PM -0700, Ben Pfaff wrote:
I see that several patches have been committed from this series. It
seems that review has
On Tue, Aug 18, 2015 at 04:17:54PM -0700, Jarno Rajahalme wrote:
Actually copy the 'nd_target' from the key.
Found by inspection.
Signed-off-by: Jarno Rajahalme jrajaha...@nicira.com
Ouch.
Acked-by: Ben Pfaff b...@nicira.com
___
dev mailing list
On Wed, Aug 19, 2015 at 9:45 PM, Russell Bryant rbry...@redhat.com wrote:
On Aug 19, 2015, at 9:00 PM, Alex Wang al...@nicira.com wrote:
On Wed, Aug 19, 2015 at 8:58 PM, Ben Pfaff b...@nicira.com wrote:
On Wed, Aug 19, 2015 at 08:51:11PM -0700, Ben Pfaff wrote:
I see that several
42 matches
Mail list logo
