[ovs-dev] [PATCH 4/6] tnl-arp-cache: Add a command to add or modify an ARP cache entry.

2015-09-02 Thread Ben Pfaff
This allows the ARP cache to be prepopulated for testing purposes, so that tests don't lose the first packet to each destination. (I guess this feature could have other uses too.) Signed-off-by: Ben Pfaff --- lib/tnl-arp-cache.c | 67

[ovs-dev] [PATCH 2/6] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-02 Thread Ben Pfaff
A shell function doesn't need quoted and unquoted variants and it integrates naturally with other shell code. Signed-off-by: Ben Pfaff --- tests/ofproto-dpif.at | 61 --- tests/ofproto-macros.at | 4 +-- tests/ofproto.at

[ovs-dev] [PATCH 1/6] tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-02 Thread Ben Pfaff
A lot of tests need to initialize the OVS_RUNDIR, OVS_LOGDIR, etc. variables to point to the directory in which the tests run. Until now, each of them has had to do this individually, which is redundant. This commit starts to do this automatically. Signed-off-by: Ben Pfaff ---

Re: [ovs-dev] [PATCH 1/2] tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-02 Thread Ben Pfaff
On Wed, Aug 26, 2015 at 10:20:48PM -0700, Ben Pfaff wrote: > A lot of tests need to initialize the OVS_RUNDIR, OVS_LOGDIR, etc. > variables to point to the directory in which the tests run. Until now, > each of them has had to do this individually, which is redundant. This > commit starts to do

[ovs-dev] [PATCH 6/6] ovn: Implement basic end-to-end full mesh test.

2015-09-02 Thread Ben Pfaff
This is a really basic test of the OVN features. It verifies that basic L2 connectivity works as expected over a 3-hypervisor setup with 3 VMs per hypervisor and all 9 VMs on a single logical switch. I wanted to test stateless ACLs also but there's no simple way to set them up with ovn-nbctl. I

[ovs-dev] [PATCH] netdev-dpdk: refactor for struct eth_addr

2015-09-02 Thread Mark Kavanagh
Commit 74ff329 introduces 'struct eth_addr'; this breaks compilation for netdev-dpdk.c. Refactor any affected code to resolve. Signed-off-by: Mark Kavanagh --- lib/netdev-dpdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-dpdk.c

[ovs-dev] [PATCH 5/6] [RFC] ovn-controller: Attach local_ip to each tunnel.

2015-09-02 Thread Ben Pfaff
This avoids packet duplication when native tunneling is used. The right solution is to adjust the native tunneling code so that it discards packets not directed to the current host. I expect to see a patch for that correct solution soon, see:

[ovs-dev] [PATCH 3/6] pcap-file: Flush packets to operating system immediately.

2015-09-02 Thread Ben Pfaff
This makes the pcap files written by netdev-dummy up-to-date even if one kills the process with a signal. This could be a performance hit if the pcap file writer were to be used in some kind of performance critical situation, but so far it's only used in netdev-dummy, which is just for testing.

Re: [ovs-dev] native tunneling bug?

2015-09-02 Thread Jesse Gross
On Wed, Sep 2, 2015 at 6:44 AM, Jesse Gross wrote: > On Tue, Sep 1, 2015 at 7:14 PM, Pravin Shelar wrote: >> On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote: >>> I think I've come across a bug in OVS native tunneling, or at any rate >>> an

[ovs-dev] [PATCH v2] datapath-windows: New tag for tunnel filter pool allocations

2015-09-02 Thread Sorin Vinturis
All memory allocations within tunnel filter code have 'WSVO' pool tag. Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju --- datapath-windows/ovsext/TunnelFilter.c | 4 +++- datapath-windows/ovsext/Util.h | 1 + 2 files changed, 4

[ovs-dev] [PATCH v2] datapath-windows: Add corresponding tag for tunnel context allocations

2015-09-02 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju --- datapath-windows/ovsext/Vport.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index

Re: [ovs-dev] native tunneling bug?

2015-09-02 Thread Ben Pfaff
On Wed, Sep 02, 2015 at 06:44:15AM -0700, Jesse Gross wrote: > On Tue, Sep 1, 2015 at 7:14 PM, Pravin Shelar wrote: > > On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote: > >> I think I've come across a bug in OVS native tunneling, or at any rate > >> an

Re: [ovs-dev] [PATCH] datapath-windows: Add corresponding tag for tunnel context allocations

2015-09-02 Thread Nithin Raju
> On Sep 2, 2015, at 6:37 AM, Sorin Vinturis > wrote: > > Signed-off-by: Sorin Vinturis > --- > datapath-windows/ovsext/Vport.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git

Re: [ovs-dev] [PATCH] datapath-windows: New tag for tunnel filter pool allocations

2015-09-02 Thread Nithin Raju
> On Sep 2, 2015, at 6:37 AM, Sorin Vinturis > wrote: > > All memory allocations within tunnel filter code have 'WSVO' pool tag. > > Signed-off-by: Sorin Vinturis Acked-by: Nithin Raju

[ovs-dev] [PATCH] datapath-windows: Tunnel filter initialization check

2015-09-02 Thread Sorin Vinturis
Verify if the tunnel filter is initialized before submitting requests. Signed-off-by: Sorin Vinturis Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/100 ---

Re: [ovs-dev] [PATCH] ovsdb: Update _version more accurately in transaction commit.

2015-09-02 Thread Andy Zhou
Acked-by: Andy Zhou On Mon, Aug 31, 2015 at 9:52 AM, Ben Pfaff wrote: > The _version column in each OVSDB row is supposed to be updated whenever > any other column in the row changes. However, the transaction code was > not careful to do this only when a row

[ovs-dev] [PATCH v2 02/14] tests: Replace ON_EXIT m4 macro by on_exit() shell function.

2015-09-02 Thread Ben Pfaff
A shell function doesn't need quoted and unquoted variants and it integrates naturally with other shell code. Signed-off-by: Ben Pfaff --- tests/ofproto-dpif.at | 61 --- tests/ofproto-macros.at | 4 +-- tests/ofproto.at

[ovs-dev] [PATCH v2 04/14] tnl-arp-cache: Add a command to add or modify an ARP cache entry.

2015-09-02 Thread Ben Pfaff
This allows the ARP cache to be prepopulated for testing purposes, so that tests don't lose the first packet to each destination. (I guess this feature could have other uses too.) Signed-off-by: Ben Pfaff --- lib/tnl-arp-cache.c | 67

[ovs-dev] [PATCH v2 01/14] tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-02 Thread Ben Pfaff
A lot of tests need to initialize the OVS_RUNDIR, OVS_LOGDIR, etc. variables to point to the directory in which the tests run. Until now, each of them has had to do this individually, which is redundant. This commit starts to do this automatically. Signed-off-by: Ben Pfaff ---

[ovs-dev] [PATCH v2 05/14] [RFC] ovn-controller: Attach local_ip to each tunnel.

2015-09-02 Thread Ben Pfaff
This avoids packet duplication when native tunneling is used. The right solution is to adjust the native tunneling code so that it discards packets not directed to the current host. I expect to see a patch for that correct solution soon, see:

[ovs-dev] [PATCH v2 06/14] ovn: Implement basic end-to-end full mesh test.

2015-09-02 Thread Ben Pfaff
This is a really basic test of the OVN features. It verifies that basic L2 connectivity works as expected over a 3-hypervisor setup with 3 VMs per hypervisor and all 9 VMs on a single logical switch. I wanted to test stateless ACLs also but there's no simple way to set them up with ovn-nbctl. I

[ovs-dev] [PATCH v2 08/14] Fix typos in comments.

2015-09-02 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 2 +- utilities/ovs-vsctl.c | 2 +- vtep/vtep-ctl.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index fc522b3..db0ac6d 100644

[ovs-dev] [PATCH v2 07/14] ovn-nbctl: Give handler functions more specific names.

2015-09-02 Thread Ben Pfaff
I find that it's nice to give functions for commands names specific to the utility, even though they're static, because occasionally it makes it easier to find them using "tags", "grep", etc. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-nbctl.c | 96

[ovs-dev] [PATCH v2 09/14] ovn-sbctl: Indentation fixes.

2015-09-02 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index db0ac6d..e2b296a 100644 --- a/ovn/utilities/ovn-sbctl.c +++ b/ovn/utilities/ovn-sbctl.c

[ovs-dev] [PATCH v2 11/14] ovn-sbctl: Improve usage message.

2015-09-02 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index 1627a8e..89bd0a2 100644 --- a/ovn/utilities/ovn-sbctl.c +++

[ovs-dev] [PATCH v2 10/14] ovn-sbctl: Support SSL for connecting to southbound database.

2015-09-02 Thread Ben Pfaff
Eventually we'll want this and it's easy to add, so go ahead and add it now. Signed-off-by: Ben Pfaff --- ovn/utilities/ovn-sbctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ovn/utilities/ovn-sbctl.c b/ovn/utilities/ovn-sbctl.c index e2b296a..1627a8e 100644 ---

[ovs-dev] [PATCH v2 03/14] pcap-file: Flush packets to operating system immediately.

2015-09-02 Thread Ben Pfaff
This makes the pcap files written by netdev-dummy up-to-date even if one kills the process with a signal. This could be a performance hit if the pcap file writer were to be used in some kind of performance critical situation, but so far it's only used in netdev-dummy, which is just for testing.

[ovs-dev] [PATCH v2 13/14] ovn-nbctl: Enable database commands using db-ctl-base infrastructure.

2015-09-02 Thread Ben Pfaff
This makes ovn-nbctl into a pretty slavish imitation of ovn-nbctl, using almost the same code. It has two immediate benefits. First, multiple commands can now be chained together into a single ovn-nbctl invocation. Second, the database commands such as "create", "set", and so on allow queries

[ovs-dev] [PATCH v2 12/14] db-ctl-base: Make 'cmd_show_tables' argument to ctl_init() optional.

2015-09-02 Thread Ben Pfaff
This allows the client to omit the "show" command if it doesn't want it. This will be used in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/db-ctl-base.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/lib/db-ctl-base.c

[ovs-dev] [PATCH v2 14/14] tests: Test ACLs in OVN end-to-end test.

2015-09-02 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- tests/ovn.at | 57 - 1 file changed, 44 insertions(+), 13 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 8e442fa..a83b127 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -435,6

Re: [ovs-dev] [PATCH 1/6] tests: Automatically initialize OVS_*DIR vars when tests begin.

2015-09-02 Thread Ben Pfaff
On Tue, Sep 01, 2015 at 11:42:43PM -0700, Ben Pfaff wrote: > A lot of tests need to initialize the OVS_RUNDIR, OVS_LOGDIR, etc. > variables to point to the directory in which the tests run. Until now, > each of them has had to do this individually, which is redundant. This > commit starts to do

[ovs-dev] [PATCH] tnl-ports: Add destination IP and MAC address to the match.

2015-09-02 Thread Pravin B Shelar
Currently tnl-port table wildcard destination ip and mac addresses for given tunnel packet. That could result accepting tunnel packets destined for other hosts. Following patch adds support for matching for ip and mac address. IP address upates to tnl-port table are piggybacked on ovs-router

[ovs-dev] understanding for redundant data structures in vswitchd implementation

2015-09-02 Thread RishiRaj Maulick
I have a query with respect to the design of ovs-vswitchd .( please forgive me for my long email ) I was going through the code and there were some design concepts which I came across - 1) *IDL *- there is code generated pertaining to the DB schema that is defined. For example the code in

Re: [ovs-dev] native tunneling bug?

2015-09-02 Thread Pravin Shelar
On Wed, Sep 2, 2015 at 8:55 AM, Jesse Gross wrote: > On Wed, Sep 2, 2015 at 6:44 AM, Jesse Gross wrote: >> On Tue, Sep 1, 2015 at 7:14 PM, Pravin Shelar wrote: >>> On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote: I

[ovs-dev] [PATCH 2/2] stream-ssl: Get peer-ca-cert functionality to work.

2015-09-02 Thread Gurucharan Shetty
When --certificate option is provided, we currently use SSL_CTX_use_certificate_chain_file() function to add that certificate. If our single certificate file had multiple certificates (as a chain), all of them would get added and sent to the remote peer. But once you call

[ovs-dev] [PATCH 1/2] ovs-vsctl.at: Change a ssl test.

2015-09-02 Thread Gurucharan Shetty
The test claimed to test peer-ca-cert functionality. But the certificate provided via --peer-ca-cert was not actually sent to the peer for bootstrapping. The bootstrapping was successful because cert provided via --certificate was self-signed. Since the test was not really testing the

[ovs-dev] [PATCH] datapath: Add net/ip6_checksum.h to stt.c

2015-09-02 Thread Jason Kölker
`csum_ipv6_magic` is an asm inline on most platforms. However if it is not defined (like on ppc64le) including will fall back to the c implementation by wrapping it in an `#ifndef _HAVE_ARCH_IPV6_CSUM`. Signed-off-by: Jason Kölker --- datapath/linux/compat/stt.c | 1 + 1

Re: [ovs-dev] [PATCH] datapath: Add net/ip6_checksum.h to stt.c

2015-09-02 Thread Jesse Gross
On Wed, Sep 2, 2015 at 3:40 PM, Jason Kölker wrote: > `csum_ipv6_magic` is an asm inline on most platforms. However if it is > not defined (like on ppc64le) including will fall > back to the c implementation by wrapping it in an > `#ifndef _HAVE_ARCH_IPV6_CSUM`. > >

[ovs-dev] [PATCH v2] dpdk: add support for v2.1.0

2015-09-02 Thread Timo Puha
Update relevant artifacts to add support for DPDK v2.1.0 - INSTALL.DPDK.md - acinclude.m4: Change DPDK library name - netdev-dpdk: Limit minimum mbuf size to to adapt to DPDK bug fix that changes the treatment of the requested mbuf size - build.sh: Change DPDK version number Note that this

[ovs-dev] [PATCH v4] dpif-netdev: proper tx queue id

2015-09-02 Thread Ilya Maximets
Currently tx_qid is equal to pmd->core_id. This leads to unexpected behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/', e.g. if core_ids are not sequential, or doesn't start from 0, or both. Example: starting 2 pmd threads with 1 port, 2 rxqs per port, pmd-cpu-mask =

[ovs-dev] Job Contracting and Against Labor-only Contracting - Oct. 1

2015-09-02 Thread Jhie Tejada
This email newsletter was sent to you in graphical HTML format. If you're seeing this version, your email program prefers plain text emails. You can read the original version online: http://ymlp182.com/zduRnl

[ovs-dev] [PATCH] datapath-windows: Add corresponding tag for tunnel context allocations

2015-09-02 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/Vport.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/datapath-windows/ovsext/Vport.c b/datapath-windows/ovsext/Vport.c index 6b74ec2..38cf878 100644 ---

[ovs-dev] [PATCH] datapath-windows: New tag for tunnel filter pool allocations

2015-09-02 Thread Sorin Vinturis
All memory allocations within tunnel filter code have 'WSVO' pool tag. Signed-off-by: Sorin Vinturis --- datapath-windows/ovsext/TunnelFilter.c | 4 +++- datapath-windows/ovsext/Util.h | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [ovs-dev] native tunneling bug?

2015-09-02 Thread Jesse Gross
On Tue, Sep 1, 2015 at 7:14 PM, Pravin Shelar wrote: > On Tue, Sep 1, 2015 at 4:56 PM, Ben Pfaff wrote: >> I think I've come across a bug in OVS native tunneling, or at any rate >> an important difference between Linux kernel and OVS native tunneling. >> In