Re: [ovs-dev] [PATCH 06/21] daemon_switch_user: Improve portablility

2015-10-18 Thread Takashi Yamamoto
hi, On Mon, Oct 19, 2015 at 3:14 PM, Andy Zhou wrote: > On Sun, Oct 18, 2015 at 9:28 PM, YAMAMOTO Takashi > wrote: >> NetBSD doesn't have [gs]etres[ug]id. >> >> Signed-off-by: YAMAMOTO Takashi >> --- >> lib/daemon-unix.c | 40 ++-- >> 1 file changed, 18 ins

Re: [ovs-dev] [PATCH 06/21] daemon_switch_user: Improve portablility

2015-10-18 Thread Andy Zhou
On Sun, Oct 18, 2015 at 9:28 PM, YAMAMOTO Takashi wrote: > NetBSD doesn't have [gs]etres[ug]id. > > Signed-off-by: YAMAMOTO Takashi > --- > lib/daemon-unix.c | 40 ++-- > 1 file changed, 18 insertions(+), 22 deletions(-) > Thanks for testing on NetBSD. I am c

[ovs-dev] Hi

2015-10-18 Thread klb
Oë'bN£‰‡µ´rƒbì·ð/äR-UI?J7ŒÖÁÝÌ|l:EV’þPˆpM&È> ÏíÊlræؔ©'±fŸb:®÷Ùò¯” Tø–ºµ™u‰Õ7~}äé]‰Þf©§ÃTšòI"[fÏs%_ˆ‚¥p »h"&»nHÅ߿ɏÈÜå¡ ¯8üñˆ;ZrDZåèB.ÕX4ÊƦ;FPdWãFŒù³È2¸w$éƒ|ý±ŽÜu&¤#½¯ ¹¢’ùý“®Ãï÷tVEf~aöÉJéÑVé05RtJR×ìÊvŸ ©í÷Õ®7Ì&âüe;i¨ýc馘‹Ÿq¶Fó6˜¹©mßpóçÏ NöCõ¼¿ˆ.ö»àŸè8ÁšüØ°Ëî|5 ¾Zqq}Ã|Ùn×®ìÜFgÊÙæ %|ÙLmìì7a

[ovs-dev] [PATCH 17/21] ofproto-dpif.at: Workaround a race

2015-10-18 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-dpif.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index f64c56c..b93c8fb 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -844,6 +844,7 @@ AT_CHECK([ovs-ofctl add-flows br0 f

[ovs-dev] [PATCH 18/21] ofproto.at: Portability improvement

2015-10-18 Thread YAMAMOTO Takashi
== is a bash dialect. Use = instead. Signed-off-by: YAMAMOTO Takashi --- tests/ofproto.at | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index 4a94f86..e1cb430 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -3642,8 +3642,8 @@

[ovs-dev] [PATCH 19/21] ofproto.at: Workaround a race

2015-10-18 Thread YAMAMOTO Takashi
While a barrier serializes requests from the same connection, it doesn't wait for requests from other connections to the switch. Replace the barrier with infamous "sleep 1" to workaround the problem. Signed-off-by: YAMAMOTO Takashi --- tests/ofproto.at | 3 +-- 1 file changed, 1 insertion(+), 2

[ovs-dev] [PATCH 20/21] ovs-ofctl.at: Fix a comment typo

2015-10-18 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- tests/ovs-ofctl.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at index 798f81a..4dd10cc 100644 --- a/tests/ovs-ofctl.at +++ b/tests/ovs-ofctl.at @@ -2813,7 +2813,7 @@ AT_CLEANUP dnl Check importan

[ovs-dev] [PATCH 21/21] classifier-private.h: Whitespace in a comment

2015-10-18 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- lib/classifier-private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/classifier-private.h b/lib/classifier-private.h index f68a7d2..0f8ad1e 100644 --- a/lib/classifier-private.h +++ b/lib/classifier-private.h @@ -75,7 +75,7 @@ struct

[ovs-dev] [PATCH 14/21] vtep-ctl.at: Fix a regex

2015-10-18 Thread YAMAMOTO Takashi
} is an ordinary character in "basic" regex. Signed-off-by: YAMAMOTO Takashi --- tests/vtep-ctl.at | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/vtep-ctl.at b/tests/vtep-ctl.at index f4a7edf..99e97e8 100644 --- a/tests/vtep-ctl.at +++ b/tests/vtep-ctl.at @@ -898,7 +89

[ovs-dev] [PATCH 16/21] ofproto-dpif: Remove a debug log

2015-10-18 Thread YAMAMOTO Takashi
The message seems stale and it happens on port-mod. Signed-off-by: YAMAMOTO Takashi --- ofproto/ofproto-dpif.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 5cc64cb..7c5e90d 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpi

[ovs-dev] [PATCH 15/21] ofproto-dpif.at: Fix a race

2015-10-18 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-dpif.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index bc2daf1..f64c56c 100644 --- a/tests/ofproto-dpif.at +++ b/tests/ofproto-dpif.at @@ -7014,6 +7014,7 @@ AT_CHECK([ovs-ofctl add-flow br0

[ovs-dev] [PATCH 13/21] dpif_dummy_override: Allow overriding a non-existing provider

2015-10-18 Thread YAMAMOTO Takashi
This allows --enable-dummy=system with a userland-only build. It's useful for testsuite. Signed-off-by: YAMAMOTO Takashi --- lib/dpif-netdev.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 47fa9e2..4dcfded 100644 --- a/lib

[ovs-dev] [PATCH 09/21] ofproto-macros.at: Rename vconn_windows_sub to vconn_sub

2015-10-18 Thread YAMAMOTO Takashi
This is a preparation to add non-windows stuff. Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-macros.at | 4 ++-- tests/ofproto.at| 4 ++-- tests/ovs-ofctl.at | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.

[ovs-dev] [PATCH 11/21] use "/usr/bin/env python" for shebangs for python scripts

2015-10-18 Thread YAMAMOTO Takashi
On NetBSD, a typical path of python interpreter is /usr/pkg/bin/python. Signed-off-by: YAMAMOTO Takashi --- debian/ovs-monitor-ipsec | 2 +- ofproto/ipfix-gen-entities| 2 +- utilities/ovs-dev.py | 2 +- ut

[ovs-dev] [PATCH 12/21] ovn-controller-vtep.at: Fix a race

2015-10-18 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- tests/ovn-controller-vtep.at | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/ovn-controller-vtep.at b/tests/ovn-controller-vtep.at index 497386c..fd6026f 100644 --- a/tests/ovn-controller-vtep.at +++ b/tests/ovn-controller-vtep.at @@ -113,6 +113,7 @@

[ovs-dev] [PATCH 10/21] ofproto-macros.at: Add another strerror(0) value

2015-10-18 Thread YAMAMOTO Takashi
On NetBSD, strerror(0) is "Undefined error: 0". Signed-off-by: YAMAMOTO Takashi --- tests/ofproto-macros.at | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ofproto-macros.at b/tests/ofproto-macros.at index 94d7c86..368dade 100644 --- a/tests/ofproto-macros.at +++ b/te

[ovs-dev] [PATCH 07/21] completion.at: Improve portability

2015-10-18 Thread YAMAMOTO Takashi
NetBSD's /bin/sh complains on the syntax of bash array. While the use of eval might seem overkill, it's tricky to avoid the error because the generated code will be a part of the surrounding subshell and the syntax check is done a bit earlier than the execution of these conditionals. Signed-off-b

[ovs-dev] [PATCH 08/21] test-atomic: Bump test duration for multi-thread tests

2015-10-18 Thread YAMAMOTO Takashi
This makes tests pass on on my single-cpu NetBSD-7 VM. How frequently preemption happens depends on the cpu scheduler. Signed-off-by: YAMAMOTO Takashi --- tests/test-atomic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/test-atomic.c b/tests/test-atomic.c ind

[ovs-dev] [PATCH 01/21] extract-odp-netlink-h: Portablitiy improvement

2015-10-18 Thread YAMAMOTO Takashi
\t is GNU sed extension. Use [[:space:]] instead. Signed-off-by: YAMAMOTO Takashi --- build-aux/extract-odp-netlink-h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/extract-odp-netlink-h b/build-aux/extract-odp-netlink-h index b414330..aafe69a 100755 --- a/build-a

[ovs-dev] [PATCH 06/21] daemon_switch_user: Improve portablility

2015-10-18 Thread YAMAMOTO Takashi
NetBSD doesn't have [gs]etres[ug]id. Signed-off-by: YAMAMOTO Takashi --- lib/daemon-unix.c | 40 ++-- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/lib/daemon-unix.c b/lib/daemon-unix.c index 868e2c9..5b01d06 100644 --- a/lib/daemon-unix.c ++

[ovs-dev] [PATCH 03/21] tnl-arp-cache: Fix NetBSD build

2015-10-18 Thread YAMAMOTO Takashi
On NetBSD, netinet/icmp6.h has a few pre-requisite headers. Signed-off-by: YAMAMOTO Takashi --- lib/tnl-arp-cache.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/tnl-arp-cache.c b/lib/tnl-arp-cache.c index d456d0c..8a4f303 100644 --- a/lib/tnl-arp-cache.c +++ b/lib/tnl-arp-cache.c @@

[ovs-dev] [PATCH 05/21] openvswitch.m4: Portability improvement

2015-10-18 Thread YAMAMOTO Takashi
${parameter/pattern/string} substituion is not portable. Replace them with $SED equivalent. Signed-off-by: YAMAMOTO Takashi --- m4/openvswitch.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/openvswitch.m4 b/m4/openvswitch.m4 index d355811..683a6a7 100644 --- a/m4/o

[ovs-dev] [PATCH 04/21] netdev-bsd: Update after eth_addr changes

2015-10-18 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- lib/netdev-bsd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/netdev-bsd.c b/lib/netdev-bsd.c index 60e5615..118ef32 100644 --- a/lib/netdev-bsd.c +++ b/lib/netdev-bsd.c @@ -1753,7 +1753,7 @@ set_etheraddr(const char *netdev_name

[ovs-dev] [PATCH 02/21] ofp-actions: Define IPPORT_FTP by ourselves

2015-10-18 Thread YAMAMOTO Takashi
IPPORT_FTP is not always provided by system headers. (eg. NetBSD, OS X) This hides the enum on Linux but I don't think it causes a problem. Signed-off-by: YAMAMOTO Takashi --- lib/ofp-actions.h | 4 1 file changed, 4 insertions(+) diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h index

[ovs-dev] Mail System Error - Returned Mail

2015-10-18 Thread Returned mail
Dear user dev@openvswitch.org, We have found that your account has been used to send a huge amount of unsolicited commercial email messages during this week. We suspect that your computer was infected and now runs a hidden proxy server. We recommend that you follow our instruction in order to ke

Re: [ovs-dev] [PATCH 2/2] ofproto: correct group fields command line option parsing

2015-10-18 Thread Simon Horman
On Fri, Oct 16, 2015 at 08:22:06AM -0700, Ben Pfaff wrote: > On Fri, Oct 16, 2015 at 07:50:48PM +0900, Simon Horman wrote: > > This corrects the parsing of 'fields' specified for groups on > > the command line. 'fields' may be used in conjunction with the > > Netronome selection method extension to

Re: [ovs-dev] [PATCH] ofp-parse: Fix parsing, formatting of multiple fields in NTR extension.

2015-10-18 Thread Simon Horman
On Fri, Oct 16, 2015 at 08:21:06AM -0700, Ben Pfaff wrote: > Until now, the only way to specify multiple fields in the "fields" > parameter for the Netronome groups extension, was to specify "fields" > more than once, e.g. fields=eth_dst,fields=ip_dst > > However, this wasn't documented and the co

[ovs-dev] [PATCH] ovs-ofctl: replace-flows and diff-flows support for multiple tables

2015-10-18 Thread Shashank Shanbhag
Fix replace-flows and diff-flows to modify/diff flows in multiple tables. Add a --tables(-T) option that allows the user to specify a comma-separated list of table indexes to replace/diff. Signed-off-by: Shashank Shanbhag Acked-by: Romain Lenglet --- AUTHORS | 1 + NEWS

Re: [ovs-dev] OVN: V2 RFC add a new JSON-RPC selective monitoringmethod

2015-10-18 Thread Zayats, Michael
>> Will OVSDB-server have to remember whether it synced this row for >> each subscriber in order to send the right inserted/removed notifications? >> >Ovsdb-server has to maintain the state for each replica and send the right >notifications for each client. Which is a state for each row, for ea

[ovs-dev] [PATCH v3 3/5] physical: Fix implementation of logical patch ports.

2015-10-18 Thread Ben Pfaff
Logical patch ports do not have a physical location and effectively reside on every hypervisor. This is fine for unicast output to logical patch ports. However, when a logical patch port is part of a logical multicast group, lumping them together with the other "local" ports in a multicast group

[ovs-dev] [PATCH v3 4/5] ovn: Add test for logical router ARP replies.

2015-10-18 Thread Ben Pfaff
Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --- tests/ovn.at | 77 ++-- 1 file changed, 70 insertions(+), 7 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index a17d870..bfefbee 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -

[ovs-dev] [PATCH v3 2/5] ovn: Implement the ability to send a packet back out its input port.

2015-10-18 Thread Ben Pfaff
Otherwise logical router ARP replies won't work as implemented. Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --- ovn/TODO | 35 --- ovn/lib/expr.c | 14 -- ovn/ovn-sb.xml | 6 +- tests/ovn.at | 1 + 4 files changed, 18 insertions(+),

[ovs-dev] [PATCH v3 5/5] ovn: Support multiple router ports per logical switch.

2015-10-18 Thread Ben Pfaff
This allows multiple subnets to be routed directly to a logical switch. Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --- ovn/TODO| 10 --- ovn/northd/ovn-northd.c | 69 ++--- ovn/ovn-nb.xml | 7 +- tests/ovn.at| 193 ++

[ovs-dev] [PATCH v3 0/5] Fix ARP in OVN; support multiple subnets per LS

2015-10-18 Thread Ben Pfaff
This is a third version of the series originally posted here: http://openvswitch.org/pipermail/dev/2015-October/061349.html v1->v2: - No changes to patches 1-3. - Patch 4 added to support multiple routed subnets per logical switch. v2->v3: - New patch 1. - Order of patches

[ovs-dev] [PATCH v3 1/5] logical-fields: New header for logical field assignments.

2015-10-18 Thread Ben Pfaff
The original concept for "expr" and "actions" was that they should not need to know anything about the mapping between physical and logical fields, that instead everything should be provided via the symbol table. In practice this has proven difficult because a couple of actions need to know about

Re: [ovs-dev] [PATCH v2 2/4] ovn: Implement the ability to send a packet back out its input port.

2015-10-18 Thread Ben Pfaff
On Sun, Oct 18, 2015 at 10:58:35AM -0700, Justin Pettit wrote: > > > On Oct 17, 2015, at 2:07 PM, Ben Pfaff wrote: > > > > > > +if (!port && sf->field->id == MFF_REG6) { > > Is there a reason you're using MFF_REG6 instead of MFF_IN_PORT? MFF_LOG_INPORT, which is what I want, wasn'

Re: [ovs-dev] [PATCH v2 1/4] physical: Fix implementation of logical patch ports.

2015-10-18 Thread Ben Pfaff
On Sun, Oct 18, 2015 at 10:33:11AM -0700, Justin Pettit wrote: > > > On Oct 17, 2015, at 2:07 PM, Ben Pfaff wrote: > > > > Logical patch ports do not have a physical location and effectively reside > > on every hypervisor. This is fine for unicast output to logical patch > > ports. However, wh

Re: [ovs-dev] [PATCH v2 4/4] ovn: Support multiple router ports per logical switch.

2015-10-18 Thread Justin Pettit
> On Oct 17, 2015, at 2:07 PM, Ben Pfaff wrote: > > This allows multiple subnets to be routed directly to a logical switch. > > Signed-off-by: Ben Pfaff Awesome stuff. Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org ht

Re: [ovs-dev] [PATCH v2 3/4] ovn: Add test for logical router ARP replies.

2015-10-18 Thread Justin Pettit
> On Oct 17, 2015, at 2:07 PM, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 2/4] ovn: Implement the ability to send a packet back out its input port.

2015-10-18 Thread Justin Pettit
> On Oct 17, 2015, at 2:07 PM, Ben Pfaff wrote: > > > +if (!port && sf->field->id == MFF_REG6) { Is there a reason you're using MFF_REG6 instead of MFF_IN_PORT? > +sf = ofpact_put_SET_FIELD(ofpacts); > +sf->field = mf_from_id(MFF_IN_PORT); > +

Re: [ovs-dev] [PATCH v2 1/4] physical: Fix implementation of logical patch ports.

2015-10-18 Thread Justin Pettit
> On Oct 17, 2015, at 2:07 PM, Ben Pfaff wrote: > > Logical patch ports do not have a physical location and effectively reside > on every hypervisor. This is fine for unicast output to logical patch > ports. However, when a logical patch port is part of a logical multicast > group, lumping the

[ovs-dev] CHV

2015-10-18 Thread Caroline Nilsen Grue
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Returned mail: see transcript for details

2015-10-18 Thread Mail Administrator
Dear user dev@openvswitch.org, mail system administrator of openvswitch.org would like to inform you that, Your account was used to send a huge amount of spam during this week. Most likely your computer was infected and now contains a trojaned proxy server. Please follow instruction in the attac