> -Original Message-
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Monday, December 21, 2015 7:27 PM
> To: Traynor, Kevin
> Cc: dev@openvswitch.org; Flavio Leitner
> Subject: Re: [PATCH 3/5] netdev-dpdk: Autofill lcore coremask if absent
>
> "Traynor, Kevin"
On Tue, Dec 01, 2015 at 04:48:04PM +0200, Panu Matilainen wrote:
> Add support for creating a userspace bridge and the four DPDK port
> types via network scripts + basic documentation.
>
> Signed-off-by: Panu Matilainen
> ---
Please apply this one branch-2.5 too.
Acked-by:
It does more than just update the length now, so this is a more accurate
name.
Signed-off-by: Ben Pfaff
---
lib/bundle.c | 2 +-
lib/learn.c | 2 +-
lib/ofp-actions.c | 22 +++---
lib/ofp-actions.h | 9 -
4 files changed, 17 insertions(+), 18
"Traynor, Kevin" writes:
>> -Original Message-
>> From: Aaron Conole [mailto:acon...@redhat.com]
>> Sent: Monday, December 21, 2015 7:27 PM
>> To: Traynor, Kevin
>> Cc: dev@openvswitch.org; Flavio Leitner
>> Subject: Re: [PATCH 3/5] netdev-dpdk: Autofill lcore
On Wed, Dec 2, 2015 at 11:30 PM, mweglicx wrote:
> This change prevents netdev_dpdk from accessing pointer
> which is not valid.
>
> Signed-off-by: Michal Weglicki
Thanks. I applied the patch to master and branch 2.[3-5].
Thanks,
Pravin.
On 12/22/15, 12:06 AM, "Ben Pfaff" wrote:
>On Fri, Nov 27, 2015 at 03:07:21PM +0900, Simon Horman wrote:
>> the following patches correct the build on v3.6.33 and as of a few days ago
>> with these patches applied the master branch builds cleanly against all
>> supported
On 21 December 2015 at 23:52, Zang MingJie wrote:
> Hi:
>
> Problem
> ===
>
> I'm glad to see that ovs add conntrack support, the conntrack support is
> great, but I want to push it more forward.
>
> Consider this scenario:
> multiple tenant sharing a single global ip by
On Tue, Dec 22, 2015 at 03:02:31PM -0200, Flavio Leitner wrote:
> Code earlier in this function validated that gm->type is valid, so
> the default case at the end of the function would be impossible, but
> since the code can change or perhaps get copied, return the correct
> error to keep
On Tue, Dec 22, 2015 at 7:03 PM, Daniele Di Proietto
wrote:
> diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
> index 78f8636..9eb7623 100644
> --- a/lib/dpif-netdev.c
> +++ b/lib/dpif-netdev.c
> @@ -1100,57 +1100,33 @@ static int
> dpif_netdev_mask_from_nlattrs(const
On 17/12/2015 16:28, "Jesse Gross" wrote:
>When handling an upcall with the userspace datapath, it's currently
>possible for a flow from a packet with no tunnel options to come back
>with matches on the options. If that happens, dpif-netdev will
>attempt to translate the
The vxlan tests require a new enough 'ip' tool to configure native VXLAN
tunnels on the host kernel (as well as a new enough kernel). If this
isn't available, simply skip the test. This commit makes the cases where
this is checked consistent.
Signed-off-by: Joe Stringer
---
On 22/12/2015 12:23, "Jesse Gross" wrote:
>On Mon, Dec 21, 2015 at 6:21 PM, Ben Pfaff wrote:
>> On Mon, Dec 14, 2015 at 05:23:36PM -0800, Daniele Di Proietto wrote:
>>> In the ODP context an empty mask netlink attribute usually means that
>>> the flow should be
In the ODP context an empty mask netlink attribute usually means that
the flow should be an exact match.
odp_flow_key_to_mask() instead returns a struct flow_wildcards
with matches only on recirc_id and vlan_tci.
A more appropriate behavior is to handle a missing (zero length) netlink
mask
On Tue, Dec 22, 2015 at 7:13 PM, Daniele Di Proietto
wrote:
>
>
> On 17/12/2015 16:28, "Jesse Gross" wrote:
>
>>When handling an upcall with the userspace datapath, it's currently
>>possible for a flow from a packet with no tunnel options to come back
On Tue, Dec 22, 2015 at 01:01:43PM +, Zoltán Balogh wrote:
> When a group is deleted, all flows which include a Group action with the ID
> of the deleted group should be removed. Currently, only flows in table 0 are
> removed.
> When setting ofm.fn.table_id to 0xff in delete_group__() all
Open vSwitch 1.3 and older was creating certificates and private
key in /usr/share/openvswitch/pki. However, since PKI directory
is mutable, then this was considered a bug and PKI directory was
moved to /var directory in Open vSwitch 1.4 Commit 14bd2d51 (debian:
Move PKI directory to
v1->v2: Added patches 1 and 2 that make patch 3 actually work as intended.
Ben Pfaff (3):
ofp-actions: Make composing actions harder to screw up.
ofp-actions: Rename ofpact_update_len() to ofpact_finish().
physical: Improve treatment of localnet non-VLAN logical ports.
lib/bundle.c
Until now, composing a fixed-length action with ofpact_put_() failed
to append any padding required after the action. This commit changes that
so that these calls now add padding. This meant that the function
ofpact_pad(), which was until now required in various unintuitive places,
is no longer
Until now, the flow table treated localnet logical ports that have a VLAN
quite differently from those that don't. The ones without a VLAN were
essentially trunk ports: any packets that came in, that weren't picked off
by a localnet port with a VLAN, were passed to the ones without a VLAN.
This
On Mon, Nov 30, 2015 at 09:55:21PM -0500, Russell Bryant wrote:
> On 11/29/2015 02:48 PM, Ben Pfaff wrote:
> > Until now, the flow table treated localnet logical ports that have a VLAN
> > quite differently from those that don't. The ones without a VLAN were
> > essentially trunk ports: any
On Tue, Dec 01, 2015 at 04:48:04PM +0200, Panu Matilainen wrote:
> Add support for creating a userspace bridge and the four DPDK port
> types via network scripts + basic documentation.
>
> Signed-off-by: Panu Matilainen
Thanks! Applied to master and branch-2.5. (Sorry
The patch adds the caller's information of ovs_vsctl() in order
to assist debugging. The caller's information is formatted as
"(filename, line number)".
An example:
> ovsdb-tool show-log
record 183: 2015-12-22 21:12:26.050 "ovs-vsctl: ovs-vsctl --no-wait
add-br br0 -- comment
Your message could not be delivered
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
【全球起诉江泽民】
全家六口三死一残 沈阳市何欣控告元凶江泽民
【明慧网二零一五年八月二十二日】辽宁省沈阳市法轮功学员何欣女士,二零零零年生完孩子第三十六天,就遭警察殴打、暴力讯问,被迫带着刚满月的儿子背井离乡,甚至过年都有家不能回,后被捕入狱,在狱中被迫害致精神濒临崩溃。如今,何欣带着未成年的儿子被迫再次逃离家乡。
在中共江泽民团伙迫害法轮功的这十六年中,何欣曾经幸福和睦健康的六口之家,三位亲人先后被迫害去世,一人伤残。丈夫李上荣(沈阳建工学院机械系毕业)被非
On Thu, Dec 10, 2015 at 05:58:14PM -0800, William Tu wrote:
> perf counters are used by ovsdb_txn_commit(), which can be called while
> opening a database file. This means we have to move the call to
> perf_counters_init() before. Failed cases of Valgrind: 104, 106, 107
>
> Signed-off-by:
On Mon, Dec 07, 2015 at 09:58:53AM -0800, Justin Pettit wrote:
>
> > On Dec 7, 2015, at 9:15 AM, Ben Pfaff wrote:
> >
> > On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote:
> >> This patch is to support L3 DLR E-W traffic functionality in ovs-vtep. So
> >> it is
On Thu, Dec 10, 2015 at 05:58:13PM -0800, William Tu wrote:
> The test uses 16-bit ofp_port_t, however the struct flow member
> `in_port` is 32-bit, causing a memcpy to read uninitialized data.
> We should restrict the test to the `ofp_port` member of the `in_port`
> union
>
> Signed-off-by:
On Tue, Dec 22, 2015 at 06:41:35PM -0800, Ansis Atteka wrote:
> Open vSwitch 1.3 and older was creating certificates and private
> key in /usr/share/openvswitch/pki. However, since PKI directory
> is mutable, then this was considered a bug and PKI directory was
> moved to /var directory in Open
On Thu, Dec 10, 2015 at 05:58:12PM -0800, William Tu wrote:
> Fix some of the "definitely loss" cases reported by Valgrind.
>
> Signed-off-by: William Tu
> Signed-off-by: Daniele Di Proietto
> Co-authored-by: Daniele Di Proietto
On Thu, Dec 10, 2015 at 05:58:15PM -0800, William Tu wrote:
> ofpacts_pull_openflow_instructions() should fill 'ofpacts' with a list
> of OpenFlow actions and each action (including the last one) should be
> padded to OFP_ACTION_ALIGN(8) bytes.
>
> In most of the cases this is taken care of (e.g.
On Thu, Dec 10, 2015 at 05:58:16PM -0800, William Tu wrote:
> Signed-off-by: William Tu
I think maybe we need comments that explain why each suppression is
desirable, because they aren't obvious to me at a glance.
___
dev mailing
On 12/22/2015 01:31 PM, Ben Pfaff wrote:
> On Tue, Nov 24, 2015 at 04:48:59PM +0530, bscha...@redhat.com wrote:
>> This patch series introduces native dhcp support in ovn controller.
>> v4 has few bug fixes in the test cases
>>
>> Babu Shanmugam (3):
>> ovn: Dedicated connection handler for
On Fri, Nov 27, 2015 at 03:07:21PM +0900, Simon Horman wrote:
> the following patches correct the build on v3.6.33 and as of a few days ago
> with these patches applied the master branch builds cleanly against all
> supported kernel versions and all minor releases of those kernel versions.
>
> As
Hello
I reviewed the userspace code and try to make it work in ovs. I found it can't
calculate right vlan actions in a complex ovs topologies, such as a three-ovs
topology which are connected by patch-port,like following
Br-1br-2
|
On Tue, Nov 24, 2015 at 04:48:59PM +0530, bscha...@redhat.com wrote:
> This patch series introduces native dhcp support in ovn controller.
> v4 has few bug fixes in the test cases
>
> Babu Shanmugam (3):
> ovn: Dedicated connection handler for packet-ins
> ovn: New flows for DHCP tranffic
>
The original message was received at Tue, 22 Dec 2015 14:35:03 +0530 from
[162.62.75.161]
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
kernel BUG at include/linux/skbuff.h:1219!
invalid opcode: [#1] SMP
RIP: 0010:[] ovs_flow_extract+0x8ed/0xa40 [openvswitch]
Call Trace:
ovs_dp_process_received_packet+0x44/0x80 [openvswitch]
ovs_vport_receive+0x2e/0x30 [openvswitch]
gre_rcv+0xac/0xd0 [openvswitch]
gre_cisco_rcv+0x1c2/0x310
When a group is deleted, all flows which include a Group action with the ID
of the deleted group should be removed. Currently, only flows in table 0 are
removed.
When setting ofm.fn.table_id to 0xff in delete_group__() all affected flows
in non-hidden tables are removed.
Please find attached
> -Original Message-
> From: Zoltan Kiss [mailto:zoltan.k...@linaro.org]
> Sent: Tuesday, December 15, 2015 6:56 PM
> To: Traynor, Kevin; Aaron Conole
> Cc: dev@openvswitch.org
> Subject: Re: [ovs-dev] [PATCH] INSTALL.DPDK.md: Clarify DPDK arguments.
>
> Hi,
>
> On 15/12/15 14:50,
Code earlier in this function validated that gm->type is valid, so
the default case at the end of the function would be impossible, but
since the code can change or perhaps get copied, return the correct
error to keep consistency and avoid reintroducing the bug fixed by
commit 09d4b951636b
On Wed, Dec 02, 2015 at 09:46:51AM -0200, Flavio Leitner wrote:
> On Wed, Dec 02, 2015 at 02:11:16PM +0900, Simon Horman wrote:
> > On Tue, Dec 01, 2015 at 07:50:43PM -0800, Ben Pfaff wrote:
> > > On Wed, Dec 02, 2015 at 10:27:53AM +0900, Simon Horman wrote:
> > > > On Tue, Dec 01, 2015 at
Adding a new flag to verify the validity of tunnel metadata. This flag avoids
the need of resetting and validating the entire ipv4/ipv6 tunnel destination
address which caused a serious performance drop.
Signed-off-by: Sugesh Chandran
---
lib/dpif.c
On 12/21/2015 03:47 PM, Russell Bryant wrote:
> v1:
> - https://github.com/russellb/ovs/commits/python_submit_v1
I plan to submit a v2 (probably later today) with some changes.
Primarily, I'm dropping the use of 'tox' and making 'flake8' run at
build time if installed. I'm also doing some
Hi Aaron,
I ran a few tests today...some more comments on the back of this,
> -Original Message-
> From: Aaron Conole [mailto:acon...@redhat.com]
> Sent: Monday, December 21, 2015 7:24 PM
> To: Traynor, Kevin
> Cc: dev@openvswitch.org; Flavio Leitner
> Subject: Re: [PATCH 2/5]
While reloading, two PMD threads, one already reloaded and
one not yet reloaded, can poll same queue of the same port.
Fix that by introducing per numa node barriers prior to polling.
Also, as soon as we have such barriers, we may replace the
separated configuration and starting of threads in
While reloading, two PMD threads, one already reloaded and
one not yet reloaded, can poll same queue of the same port.
This may be easily reproduced using that patch:
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index ad4a665..8b744d9 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
'Unreasonably long poll interval's are reasonable for PMD threads.
Also reporting of high CPU usage is not necessary.
Signed-off-by: Ilya Maximets
---
lib/ovs-thread.c | 9 +
lib/ovs-thread.h | 1 +
lib/poll-loop.c | 4 +++-
lib/timeval.c| 2 +-
4 files
Hi Cascardo,
Thank you for reviewing the patch.
I had sent out the new patch after incorporating all your comments, please have
a look on it and let me know your inputs/suggestions/comments.
I verified that the performance drop is fixed by the patch and also I noticed
there is a 10%
On 12/22/2015 09:47 AM, Russell Bryant wrote:
> On 12/21/2015 03:47 PM, Russell Bryant wrote:
>> v1:
>> - https://github.com/russellb/ovs/commits/python_submit_v1
>
> I plan to submit a v2 (probably later today) with some changes.
> Primarily, I'm dropping the use of 'tox' and making 'flake8'
These patches originated in my Python 3 patch series, but seemed like a
reasonable set to split out before revisiting a v2 of the Python 3 series.
These patches integrate running of the 'flake8' tool into the build process.
They resolve several Python style issues, and a few real bugs.
Russell
Signed-off-by: Russell Bryant
---
python/ovs/dirs.py | 12
python/ovstest/tests.py | 12
2 files changed, 24 insertions(+)
diff --git a/python/ovs/dirs.py b/python/ovs/dirs.py
index 10571db..dae9288 100644
--- a/python/ovs/dirs.py
+++
Found by valgrind, test case 643.
Signed-off-by: William Tu
---
lib/tun-metadata.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/tun-metadata.c b/lib/tun-metadata.c
index 648a120..ececee5 100644
--- a/lib/tun-metadata.c
+++ b/lib/tun-metadata.c
@@ -132,6 +132,7 @@
This code referred to "rows" where it meant to refer to "fetched_rows".
The patch resolves flake8 error:
F821 undefined name 'rows'
python/build/nroff.py used a function fatal() that was not defined,
which raised the same type of error.
Signed-off-by: Russell Bryant
---
Resolve pep8 errors E302 and E303:
E302 expected 2 blank lines, found 1
E303 too many blank lines (3)
Signed-off-by: Russell Bryant
---
Makefile.am | 2 +-
ofproto/ipfix-gen-entities| 3 +++
class Vlog now inherits from "object". This is a "new style" Python
class, which isn't new at all at this point. This was introduced back
in Python 2.2, and some Python 2 code won't work as expected without it.
Signed-off-by: Russell Bryant
---
python/ovs/vlog.py | 2 +-
1
Resolve pep8 errors:
E711 comparison to None should be 'if cond is None:'
The reason comparing against None with "is None" is preferred over
"== None" is because a class can define its own equality operator and
produce bizarre unexpected behavior. Using "is None" has a very
explicit meaning
Resolve pep8 error:
E501 line too long (80 > 79 characters)
Signed-off-by: Russell Bryant
---
Makefile.am | 2 +-
python/build/nroff.py | 15 ++-
python/ovs/db/idl.py
Resolve the following flake8 errors:
E703 statement ends with a semicolon
E502 the backslash is redundant between brackets
Also document the reamining flake8 errors that are still ignored.
Signed-off-by: Russell Bryant
---
Makefile.am
This resolves the following flake8 error types:
F841 local variable 'e' is assigned to but never used
F401 'exceptions' imported but unused
Signed-off-by: Russell Bryant
---
Makefile.am | 2 +-
debian/ovs-monitor-ipsec
Fix the following pep8 errors:
E201 whitespace after '('
E203 whitespace before ','
E222 multiple spaces after operator
E225 missing whitespace around operator
E226 missing whitespace around arithmetic operator
E231 missing whitespace after ':'
E241 multiple spaces after ':'
E251
If flake8 is installed, run it at build time. Similar to most Makefile
targets, run it once and then only run again if the files change.
flake8 is set to ignore all error and warning types that currently occur.
Future patches will remove items from the ignore list as they are
resolved.
Resolve the following deprecation warning. This deprecation warning
advises to use an alternative syntax which is also compatible with
Python 3, where has_key() was removed.
W601 .has_key() is deprecated, use 'in'
Also fix this related error:
E713 test for membership should be 'not in'
> On Dec 22, 2015, at 11:14 AM, Russell Bryant wrote:
>
> On 12/22/2015 09:47 AM, Russell Bryant wrote:
>> On 12/21/2015 03:47 PM, Russell Bryant wrote:
>>> v1:
>>> - https://github.com/russellb/ovs/commits/python_submit_v1
>>
>> I plan to submit a v2 (probably later today)
On 21 December 2015 at 22:43, Ben Pfaff wrote:
> On Mon, Dec 21, 2015 at 04:45:20PM -0800, Joe Stringer wrote:
>> On 21 December 2015 at 16:11, Joe Stringer wrote:
>> > On 21 December 2015 at 16:01, Ben Pfaff wrote:
>> >> On Mon, Dec 21, 2015 at
On Sun, Dec 20, 2015 at 05:04:07PM +0200, Ofer Ben Yacov wrote:
> From: Ofer Ben-Yacov
>
> Currently the IDL does not support passive TCP connection,
> i.e. when the OVSDB connects to its manager.
>
> This patch enables IDL to use an already-open session
> (the one
On Wed, Dec 23, 2015 at 3:10 AM, Joe Stringer wrote:
>
> On 21 December 2015 at 23:52, Zang MingJie wrote:
> > Hi:
> >
> > Problem
> > ===
> >
> > I'm glad to see that ovs add conntrack support, the conntrack support is
> > great, but I want to push it
On Sun, Dec 06, 2015 at 06:04:45PM +0200, ofer.benya...@gmail.com wrote:
> From: Ofer Ben Yacov
>
> Currently the scenario of single logical bridge that use multiple locators
> with different tunnel key on each of the locators is not supported.
> In order to support much
On Tue, Dec 01, 2015 at 03:03:16PM +0900, Simon Horman wrote:
> Make miniflow_pad_to_64() a little more robust with regards to updates to
> struct flow by passing the last field, whose end should be considered for
> padding, rather than the next field, whose start should be considered.
>
>
On Thu, Dec 03, 2015 at 10:46:47AM +0530, saloni.jai...@gmail.com wrote:
> From: Saloni Jain
>
> On change in a table state, the controller needs to be informed with
> the OFPT_TABLE_STATUS message. The message is sent with reason
> OFPTR_VACANCY_DOWN or OFPTR_VACANCY_UP in
Hi Justin,
One issue is that all OVN code is being placed in the same repo as traditional
switching openvswitch code. Our company only needs to use OVS (vanilla software
switching) but we end up getting OVN updates as well. Reading through your
latest commits and source code, it appears that
"Traynor, Kevin" writes:
> Hi Aaron,
>
> I ran a few tests today...some more comments on the back of this,
Awesome! Thanks for all the help with this series.
>
>> -Original Message-
>> From: Aaron Conole [mailto:acon...@redhat.com]
>> Sent: Monday, December 21,
On Tue, Dec 22, 2015 at 12:44 PM, William Tu wrote:
> Found by valgrind, test case 643.
>
> Signed-off-by: William Tu
Thanks, applied to master and branch-2.5.
___
dev mailing list
dev@openvswitch.org
On Mon, Dec 21, 2015 at 6:21 PM, Ben Pfaff wrote:
> On Mon, Dec 14, 2015 at 05:23:36PM -0800, Daniele Di Proietto wrote:
>> In the ODP context an empty mask netlink attribute usually means that
>> the flow should be an exact match.
>>
>> odp_flow_key_to_mask() instead returns a
This message was undeliverable due to the following reason:
Your message could not be delivered because the destination computer was
not reachable within the allowed queue period. The amount of time
a message is queued before it is returned depends on local configura-
tion parameters.
Most
On Tue, Dec 22, 2015 at 01:56:55PM -0800, William Tu wrote:
> The patch adds the caller's information of ovs_vsctl() in order
> to assist debugging. The caller's information is formatted as
> "(filename, line number)".
>
> An example:
> > ovsdb-tool show-log
> record 183: 2015-12-22 21:12:26.050
On Wed, Dec 23, 2015 at 06:45:50AM +, OVS User1 wrote:
> One issue is that all OVN code is being placed in the same repo as
> traditional switching openvswitch code. Our company only needs to use
> OVS (vanilla software switching) but we end up getting OVN updates as
> well. Reading through
On Tue, Dec 22, 2015 at 04:47:26PM -0800, Joe Stringer wrote:
> The vxlan tests require a new enough 'ip' tool to configure native VXLAN
> tunnels on the host kernel (as well as a new enough kernel). If this
> isn't available, simply skip the test. This commit makes the cases where
> this is
77 matches
Mail list logo