replace_rule_finish() makes decision using uninitialized
for intrenal flow fm->delete_reason.
Reported by valgrind for test cases 886, 942 and 943.
Conditional jump or move depends on uninitialised value(s)
at rule_insert (ofproto-dpif.c:4134)
by replace_rule_finish (ofproto.c:4831)
b
> On Dec 23, 2015, at 4:28 PM, Ben Pfaff wrote:
>
> On Wed, Dec 23, 2015 at 04:22:10PM -0600, Justin Pettit wrote:
>>
>>> On Dec 23, 2015, at 3:20 PM, Ben Pfaff wrote:
>>>
>>> Reported-by: ZHANG Zhiming
>>> Signed-off-by: Ben Pfaff
>>
>> Acked-by: Justin Pettit
>
> There's Internet in Al
On Wed, Dec 23, 2015 at 04:28:11PM -0600, Justin Pettit wrote:
>
> > On Dec 23, 2015, at 4:26 PM, Ben Pfaff wrote:
> >
> > The warning is as follows:
> >
> > Makefile.am:363: warning: .PHONY was already defined in condition TRUE,
> >which includes condition VSTUDIO_DDK ...
> > Makefile.am
On Wed, Dec 23, 2015 at 04:22:10PM -0600, Justin Pettit wrote:
>
> > On Dec 23, 2015, at 3:20 PM, Ben Pfaff wrote:
> >
> > Reported-by: ZHANG Zhiming
> > Signed-off-by: Ben Pfaff
>
> Acked-by: Justin Pettit
There's Internet in Alabama? (Dial-up maybe?)
Thanks, I applied this to master and
> On Dec 23, 2015, at 4:26 PM, Ben Pfaff wrote:
>
> The warning is as follows:
>
> Makefile.am:363: warning: .PHONY was already defined in condition TRUE,
>which includes condition VSTUDIO_DDK ...
> Makefile.am:200: ... '.PHONY' previously defined here
>
> Signed-off-by: Ben Pfaff
Acke
The warning is as follows:
Makefile.am:363: warning: .PHONY was already defined in condition TRUE,
which includes condition VSTUDIO_DDK ...
Makefile.am:200: ... '.PHONY' previously defined here
Signed-off-by: Ben Pfaff
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
> On Dec 23, 2015, at 3:20 PM, Ben Pfaff wrote:
>
> Reported-by: ZHANG Zhiming
> Signed-off-by: Ben Pfaff
Acked-by: Justin Pettit
--Justin
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Signed-off-by: Joe Stringer
---
utilities/ovs-dev.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utilities/ovs-dev.py b/utilities/ovs-dev.py
index 9ef9723f7759..c12170610815 100755
--- a/utilities/ovs-dev.py
+++ b/utilities/ovs-dev.py
@@ -327,7 +327,7 @@ Basic Configuratio
On Wed, Dec 23, 2015 at 02:16:09PM -0800, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
Makes sense, so even though I don't use ovs-dev.py:
Acked-by: Ben Pfaff
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Dec 17, 2015 at 8:50 PM, Simon Horman
wrote:
> From: Simon Horman
>
> struct link_stats64 was introduced in v2.6.35, however,
> it was not used directly by dev_get_stats until v2.6.36.
>
> Fixes: e23775f20e1a ("datapath: Add support for lwtunnel")
> Signed-off-by: Simon Horman
> ---
> .
On Thu, Dec 17, 2015 at 8:50 PM, Simon Horman
wrote:
> dst_init_metrics was introduced in v2.6.39 rather than v2.6.35.
>
> Fixes: e23775f20e1a ("datapath: Add support for lwtunnel")
This issue is not introduced by this commit.
> Signed-off-by: Simon Horman
> ---
> .travis.yml
On Thu, Dec 17, 2015 at 8:50 PM, Simon Horman
wrote:
> From: Simon Horman
>
> tstats field was added to struct net_device in v2.6.37.
>
> Fixes: e23775f20e1a ("datapath: Add support for lwtunnel")
> Signed-off-by: Simon Horman
> ---
> .travis.yml | 1 +
> dat
On Thu, Dec 17, 2015 at 8:50 PM, Simon Horman
wrote:
> ip4_dst_hoplimit was introduced in v2.6.38 rather than v2.6.39.
>
> Fixes: e23775f20e1a ("datapath: Add support for lwtunnel")
> Signed-off-by: Simon Horman
I pushed this patch to master and branch-2.5.
> ---
> datapath/linux/compat/includ
On Thu, Dec 17, 2015 at 8:50 PM, Simon Horman
wrote:
> * The net parameter of newlink and the head parameter of dellink were
> introduced introduced in v2.6.33
> * The head parameter of dellink cannot be used if its not present
>
> Fixes: e23775f20e1a ("datapath: Add support for lwtunnel")
> Sig
On Wed, Dec 23, 2015 at 02:00:33PM -0800, Guru Shetty wrote:
> On 23 December 2015 at 13:40, Ben Pfaff wrote:
>
> > On Wed, Dec 23, 2015 at 01:34:32PM -0800, Guru Shetty wrote:
> > > I just looked at the OVN workflow for implementing VTEP schema (L2 only)
> > > and at first glance it feels wrong
Thanks. I applied this to master and branch-2.5.
On Wed, Dec 23, 2015 at 09:56:23PM +, Yin Lin wrote:
> Added signed-off-by to the email body as well as patch itself.
>
> Rationale: Some lately added targets such as ovsext_make, manpage-check and
> thread-safety-check are not files but was
On 23 December 2015 at 13:40, Ben Pfaff wrote:
> On Wed, Dec 23, 2015 at 01:34:32PM -0800, Guru Shetty wrote:
> > I just looked at the OVN workflow for implementing VTEP schema (L2 only)
> > and at first glance it feels wrong. There is possibly a reason for the
> way
> > it has been implemented,
Added signed-off-by to the email body as well as patch itself.
Rationale: Some lately added targets such as ovsext_make, manpage-check and
thread-safety-check are not files but was not marked as .PHONY. This causes
them to be unnecessarily rebuilt during "make check" and "make install" process.
Thanks, can you provide a Signed-off-by? The syntax and meaning are
explained in CONTRIBUTING.md:
Signed-off-by: Author Name
Informally, this indicates that Author Name is the author or
submitter of a patch and has the authority to submit it under
the terms of the li
You are right. Enclosed a new patch.
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org]
Sent: Wednesday, December 23, 2015 1:30 PM
To: Yin Lin
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non-file targets as .PHONY
manpage-check shouldn't be phony beca
On Wed, Dec 23, 2015 at 01:34:32PM -0800, Guru Shetty wrote:
> I just looked at the OVN workflow for implementing VTEP schema (L2 only)
> and at first glance it feels wrong. There is possibly a reason for the way
> it has been implemented, but this is how I see it.
>
> The current workflow (from
On Wed, Dec 23, 2015 at 9:26 AM, Ben Pfaff wrote:
> On Fri, Dec 18, 2015 at 02:51:43PM -0800, Andy Zhou wrote:
> > On Tue, Dec 15, 2015 at 10:51 PM, Ben Pfaff wrote:
> > > Reported-by: weizj <334965...@qq.com>
> > > Reported-at: https://github.com/openvswitch/ovs/pull/97
> > > Signed-off-by: Ben
Hello All,
I just looked at the OVN workflow for implementing VTEP schema (L2 only)
and at first glance it feels wrong. There is possibly a reason for the way
it has been implemented, but this is how I see it.
The current workflow (from a test case in ovn-controller-vtep.at):
1. In the VTEP GW d
manpage-check shouldn't be phony because it actually does create a file
named manpage-check.
On Wed, Dec 23, 2015 at 09:26:31PM +, Yin Lin wrote:
> Thanks Ben for the prompt reply! I enclosed the patch in the original
> email. Attaching it again.
>
> -Original Message-
> From: Ben Pfa
Thanks Ben for the prompt reply! I enclosed the patch in the original email.
Attaching it again.
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org]
Sent: Wednesday, December 23, 2015 1:25 PM
To: Yin Lin
Cc: dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH 1/1] Makefile: Mark non-
On Wed, Dec 23, 2015 at 09:23:51PM +, Yin Lin wrote:
> Some lately added targets such as ovsext_make, manpage-check and
> thread-safety-check are not files but was not marked as .PHONY. This
> causes them to be unnecessarily rebuilt during "make check" and "make
> install" process.
Do you have
Some lately added targets such as ovsext_make, manpage-check and
thread-safety-check are not files but was not marked as .PHONY. This causes
them to be unnecessarily rebuilt during "make check" and "make install" process.
___
dev mailing list
dev@openvs
On Wed, Dec 23, 2015 at 03:41:04PM -0500, Russell Bryant wrote:
> On 12/22/2015 04:17 PM, Ben Pfaff wrote:
> > Until now, the flow table treated localnet logical ports that have a VLAN
> > quite differently from those that don't. The ones without a VLAN were
> > essentially trunk ports: any packet
On 22 December 2015 at 22:11, Ben Pfaff wrote:
> On Tue, Dec 22, 2015 at 06:41:35PM -0800, Ansis Atteka wrote:
> > Open vSwitch 1.3 and older was creating certificates and private
> > key in /usr/share/openvswitch/pki. However, since PKI directory
> > is mutable, then this was considered a bug a
Reported-by: ZHANG Zhiming
Signed-off-by: Ben Pfaff
---
AUTHORS | 1 +
utilities/ovs-ofctl.8.in | 6 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/AUTHORS b/AUTHORS
index 1780600..4aa8ab8 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -407,6 +407,7 @@ Voravit T.
On Wed, Dec 23, 2015 at 03:39:27PM -0500, Russell Bryant wrote:
> Add a test case for OVN localnet ports. We set up two hypervisors
> connected by a network. We create two ports on each hypervisor and
> attach them to this network using OVN localnet ports. Two ports are on
> the untagged network
On Wed, Dec 23, 2015 at 10:49:41AM -0800, Guru Shetty wrote:
> On 23 December 2015 at 09:28, Ben Pfaff wrote:
>
> > On Wed, Dec 16, 2015 at 07:30:48AM -0800, Guru Shetty wrote:
> > > > I'm not sure about the dependency on openvswitch-switch. One could run
> > > > northd and the nb and sb databas
On Wed, Dec 23, 2015 at 10:58:15AM -0800, William Tu wrote:
> perf_counter_accumulate() is invoked without perf_counters_init() being
> called first, which leads to a memory leak reported by Valgrind (test
> cases 104, 106, and 107). A call trace is below:
> xmalloc (util.c:112)
> shash_add
On 23 December 2015 at 04:48, Russell Bryant wrote:
> On Tue, Dec 22, 2015 at 7:47 PM, Joe Stringer wrote:
>>
>> The vxlan tests require a new enough 'ip' tool to configure native VXLAN
>> tunnels on the host kernel (as well as a new enough kernel). If this
>> isn't available, simply skip the tes
On 12/22/2015 04:17 PM, Ben Pfaff wrote:
> Until now, the flow table treated localnet logical ports that have a VLAN
> quite differently from those that don't. The ones without a VLAN were
> essentially trunk ports: any packets that came in, that weren't picked off
> by a localnet port with a VLAN
Add a test case for OVN localnet ports. We set up two hypervisors
connected by a network. We create two ports on each hypervisor and
attach them to this network using OVN localnet ports. Two ports are on
the untagged network, and the other two are on VLAN 101.
Signed-off-by: Russell Bryant
---
perf_counter_accumulate() is invoked without perf_counters_init() being
called first, which leads to a memory leak reported by Valgrind (test
cases 104, 106, and 107). A call trace is below:
xmalloc (util.c:112)
shash_add_nocopy__ (shash.c:109)
shash_add_nocopy (shash.c:121)
shash_a
On 23 December 2015 at 09:28, Ben Pfaff wrote:
> On Wed, Dec 16, 2015 at 07:30:48AM -0800, Guru Shetty wrote:
> > > I'm not sure about the dependency on openvswitch-switch. One could run
> > > northd and the nb and sb database on a machine that does not have an
> > > openvswitch switch running;
Hi Ben,
Sure, this is a memory leak reported by Valgrind. I will resubmit with more
details in commit message.
Regards,
William
On Tue, Dec 22, 2015 at 11:08 PM, Ben Pfaff wrote:
> On Thu, Dec 10, 2015 at 05:58:14PM -0800, William Tu wrote:
> > perf counters are used by ovsdb_txn_commit(), wh
Hi Ben,
Thanks for the feedback, I will separate this patch into smaller pieces and
send again.
Regards,
William
On Tue, Dec 22, 2015 at 11:04 PM, Ben Pfaff wrote:
> On Thu, Dec 10, 2015 at 05:58:12PM -0800, William Tu wrote:
> > Fix some of the "definitely loss" cases reported by Valgrind.
>
On 12/22/2015 04:18 PM, Ben Pfaff wrote:
> On Mon, Nov 30, 2015 at 09:55:21PM -0500, Russell Bryant wrote:
>> On 11/29/2015 02:48 PM, Ben Pfaff wrote:
>>> Until now, the flow table treated localnet logical ports that have a VLAN
>>> quite differently from those that don't. The ones without a VLAN
On 12/23/2015 12:28 PM, Ben Pfaff wrote:
> On Wed, Dec 16, 2015 at 07:30:48AM -0800, Guru Shetty wrote:
>>> I'm not sure about the dependency on openvswitch-switch. One could run
>>> northd and the nb and sb database on a machine that does not have an
>>> openvswitch switch running; it might even
I think maybe you misinterpreted what I meant when I said "every
caller". When I said that, I meant "every program that invokes
ovs-vsctl", not the entire call stack.
Anyhow, either way this is going to be helpful for debugging, thanks for
writing it up.
On Wed, Dec 23, 2015 at 07:41:56AM -0800,
On Wed, Dec 16, 2015 at 07:41:01AM -0800, Guru Shetty wrote:
> On 16 December 2015 at 01:55, Ben Pfaff wrote:
> > Is there a reason someone wouldn't want to install this? That is, is
> > there a reason not to fold it into the -common package?
> >
> One reason I separated it out:
> Eventually, a s
On Wed, Dec 16, 2015 at 07:23:13AM -0800, Guru Shetty wrote:
> > Do you think it's worth breaking out individual statuses this way?
> > "ovs-ctl status" shows all OVS daemons' status; maybe "ovn-ctl status"
> > should follow the same pattern.
> >
> The reason I chose to break it was because I was s
On Wed, Dec 16, 2015 at 07:30:48AM -0800, Guru Shetty wrote:
> > I'm not sure about the dependency on openvswitch-switch. One could run
> > northd and the nb and sb database on a machine that does not have an
> > openvswitch switch running; it might even be preferred in a large
> > deployment. Wh
On Fri, Dec 18, 2015 at 02:51:43PM -0800, Andy Zhou wrote:
> On Tue, Dec 15, 2015 at 10:51 PM, Ben Pfaff wrote:
> > Reported-by: weizj <334965...@qq.com>
> > Reported-at: https://github.com/openvswitch/ovs/pull/97
> > Signed-off-by: Ben Pfaff
>
> This fix makes sense to me.
> Acked-by: Andy Zhou
On Mon, Dec 07, 2015 at 03:13:03PM -0800, Nithin Raju wrote:
> Fixing a little buglet from commit: efee3309.
>
> Signed-by: Nithin Raju
Thanks Nithin. I'm going to assume that's a typo for Signed-off-by (I
fixed it).
I also transformed your commit message into our new "Fixes" tag:
datapath-wi
> On Dec 23, 2015, at 12:49 AM, Ben Pfaff wrote:
>
>> On Mon, Dec 07, 2015 at 09:58:53AM -0800, Justin Pettit wrote:
>>
>>> On Dec 7, 2015, at 9:15 AM, Ben Pfaff wrote:
>>>
>>> On Tue, Dec 08, 2015 at 07:35:44AM +0800, Shuangmin Zhang wrote:
This patch is to support L3 DLR E-W traffic fu
Hi Ben,
Thanks for the feedback.
I will work around the "caller" by changing #!/bin/sh to #!/bin/bash
As for the parent process, I think it depends on how verbose people
consider the information helpful. The current patch only adds the immediate
caller, but we could definitely add the entire call
On Tue, Dec 22, 2015 at 7:47 PM, Joe Stringer wrote:
> The vxlan tests require a new enough 'ip' tool to configure native VXLAN
> tunnels on the host kernel (as well as a new enough kernel). If this
> isn't available, simply skip the test. This commit makes the cases where
> this is checked consi
Superseded by v8 :
http://openvswitch.org/pipermail/dev/2015-December/063807.html
Best regards, Ilya Maximets.
On 14.12.2015 17:58, Ilya Maximets wrote:
> Currently tx_qid is equal to pmd->core_id. This leads to unexpected
> behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/',
> e.g. if
Introduced per pmd thread hash map 'tx_queues', where will
be stored all available tx queues for that pmd thread with
port_no as a key(hash). All tx_qid-s will be unique per port.
Implemented infrastructure may be used in the future to
distribute traffic between all available tx queues.
Signed-of
Note: First patch of this series may be applied separately
to fix existing problem with mapping of TX queues.
version 8:
* Nobody wants to review huge architectural patches.
So, I divided it into two. First patch fixes original
problem with unexpected mapping of T
Currently tx_qid is equal to pmd->core_id. This leads to unexpected
behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/',
e.g. if core_ids are not sequential, or doesn't start from 0, or both.
Example:
starting 2 pmd threads with 1 port, 2 rxqs per port,
pmd-cpu-mask =
Following changes have been applied:
- INSTALL.DPDK.md: change DPDK version number,
- build.sh: change DPDK version number.
Signed-off-by: Michal Weglicki
---
.travis/build.sh | 2 +-
INSTALL.DPDK.md | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/.travis/buil
Hallo Frau oder HerrKredit finanzielle & ImmobilienSie möchten einen Kredit
zwischen Individuen von 5.000 €bis hin zu8.500.000 €. Wenn Sie von guten
Charakter und gemäßIhrem monatlichen oder jährlichen Budget in Höhe von 2 %
Zinsenzurückzahlen bitte kontaktieren Sie mich für weitereInformationen
From: Niti Rohilla
Following have been implemented:
- When a packet is sent to output port, it will start egress
processing in the context of the output port.
- Added check to forbid adding output or group action in the
egress action-set to prevent changing output port.
- Added check to forbi
From: Niti Rohilla
"ovs-ofctl set-first-egress-table " can be used to set first
egress
table.
This patch enhances TABLE_FEATURES_REQUEST message to set the first egress
table and
TABLE_FEATURES_REPLY to identify the table which is configured as first egress
table.
Signed-off-by: Niti Rohilla
59 matches
Mail list logo
