___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
test case 1698: auto-attach - packet tests
Report several leaks at lldp_create_dummy(), the patch fixes the
following 3 leaks:
{lldp_send (lldp.c:334), lldp_decode (lldp.c:374),
lldp_create_dummy (ovs-lldp.c:890)}
test_aa_send (test-aa.c:252)
test_aa_main (test-aa.c:281)
Comments:
On Mon, Dec 21, 2015 at 3:38 PM, Ben Pfaff wrote:
> From: Ben Pfaff
>
> The OFPT_SET_CONFIG and OFPT_GET_CONFIG_REPLY messages, which have the
> same format, have a 'flags' field in which OpenFlow defines some bits,
> which change somewhat from one version to another, and does not define
> other
On Mon, Dec 21, 2015 at 3:26 PM, Ben Pfaff wrote:
> From: Ben Pfaff
>
> The port_iterator will acquire another user in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
>
Acked-by: Andy Zhou
___
dev mailing list
dev@openvswitch.org
http://openvs
On Wed, Jan 6, 2016 at 4:29 PM, David Wragg wrote:
> Jesse Gross writes:
>> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
>>> I'm certainly open to suggestions of better ways to solve the problem.
>>
>> One option is to simply set the MTU on the device from userspace.
>
> If that worked I w
On Wed, Jan 6, 2016 at 4:14 PM, Hannes Frederic Sowa
wrote:
> Hi,
>
>
> On 07.01.2016 00:57, Jesse Gross wrote:
>>
>> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
>>>
>>> David Miller writes:
>
> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
> any size,
Jesse Gross writes:
> On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
>> I'm certainly open to suggestions of better ways to solve the problem.
>
> One option is to simply set the MTU on the device from userspace.
If that worked I wouldn't be submitting a patch.
The MTU value of 1500 is not
Hi,
On 07.01.2016 00:57, Jesse Gross wrote:
On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
David Miller writes:
Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
any size, constrained only by the ability to transmit the resulting
UDP packets. 4.3 introduced vxlan ne
On Wed, Jan 6, 2016 at 3:25 PM, David Wragg wrote:
> David Miller writes:
>>> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
>>> any size, constrained only by the ability to transmit the resulting
>>> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
>>> vp
On Wed, Jan 06, 2016 at 02:50:36PM -0800, Joe Stringer wrote:
> On 5 January 2016 at 16:24, Ben Pfaff wrote:
> > revalidate_sweep__() has two cases where it calls ukey_delete() to
> > remove a ukey from the umap via cmap_remove(). The first case is a direct
> > call to ukey_delete(), when !flow_e
> On Jan 6, 2016, at 3:27 PM, Ben Pfaff wrote:
>
> On Wed, Jan 06, 2016 at 01:58:28PM -0800, Jarno Rajahalme wrote:
>> From: Ben Pfaff
>>
>> recirc_alloc_id__() copies the stack nothing ever freed it.
>>
>> This patch is adopted from the corresponding commit 85b9cb2 on master.
>>
>> CC: Ben
On Wed, Jan 06, 2016 at 01:58:28PM -0800, Jarno Rajahalme wrote:
> From: Ben Pfaff
>
> recirc_alloc_id__() copies the stack nothing ever freed it.
>
> This patch is adopted from the corresponding commit 85b9cb2 on master.
>
> CC: Ben Pfaff
> CC: Andy Zhou
> Reported-by: William Tu
> Reported
David Miller writes:
>> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
>> any size, constrained only by the ability to transmit the resulting
>> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
>> vports. These netdevs have an MTU, which limits the size of
Acked-by: Sairam Venugopal
On 1/4/16, 3:04 PM, "Alin Serdean" wrote:
>The policy of the subscribe packets is defined by the following:
>const NL_POLICY policy[] = {
>[OVS_NL_ATTR_PACKET_PID] = {.type = NL_A_U32 },
>[OVS_NL_ATTR_PACKET_SUBSCRIBE] = {.type = NL_A_U8 }
>
Acked-by: Sairam Venugopal
On 1/4/16, 3:04 PM, "Alin Serdean" wrote:
>The warning message was inverted on the performed operation.
>
>Also use the error returned by nl_sock_subscribe_packet__.
>
>Signed-off-by: Alin Gabriel Serdean
>---
> lib/netlink-socket.c | 8
> 1 file changed, 4
I have some comments on the patch series.
Instead of "monitor_cond_change", why not just have a more generic
"monitor_update" message, so we can update
monitor columns as well as conditions.
Instead of reusing monitor id, when "monitor_update" can also change to
use a new value. Since update me
Thanks for the patch. Just to clarify, I think we still don¹t support IPv6
in OvsTcpSegmentNBL.
Acked-by: Sairam Venugopal
On 12/11/15, 2:29 PM, "Alin Serdean"
wrote:
>This patch adds LSO version 2 support for the windows datapath.
>(https://urldefense.proofpoint.com/v2/url?u=https-3A__msdn.
On Wed, Jan 6, 2016 at 12:59 PM, David Miller wrote:
> From: David Wragg
> Date: Wed, 6 Jan 2016 13:33:04 +
>
>> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
>> any size, constrained only by the ability to transmit the resulting
>> UDP packets. 4.3 introduced vxlan
Thanks for fixing this. I held off on ACK¹ing it until the original GRE
patch was applied.
Acked-by: Sairam Venugopal
On 12/11/15, 2:24 PM, "Alin Serdean"
wrote:
>Allow GRE encapsulation to take place in the case we have a TCP payload
>without LSO.
>
>Signed-off-by: Alin Gabriel Serdean
>---
On 5 January 2016 at 16:24, Ben Pfaff wrote:
> revalidate_sweep__() has two cases where it calls ukey_delete() to
> remove a ukey from the umap via cmap_remove(). The first case is a direct
> call to ukey_delete(), when !flow_exists. The second case is an indirect
> call via push_ukey_ops(), whe
> On Jan 6, 2016, at 1:21 PM, Ben Pfaff wrote:
>
> On Wed, Jan 06, 2016 at 01:14:23PM -0800, Jarno Rajahalme wrote:
>>
>>> On Jan 5, 2016, at 8:24 PM, Ben Pfaff wrote:
>>>
>>> Thanks. That was my experience also.
>>>
>>> I applied this to master and branch-2.5.
>>
>> Thanks for fixing this
From: Ben Pfaff
recirc_alloc_id__() copies the stack nothing ever freed it.
This patch is adopted from the corresponding commit 85b9cb2 on master.
CC: Ben Pfaff
CC: Andy Zhou
Reported-by: William Tu
Reported-at: http://openvswitch.org/pipermail/dev/2016-January/064040.html
Signed-off-by: Jar
On Wed, Jan 06, 2016 at 01:14:23PM -0800, Jarno Rajahalme wrote:
>
> > On Jan 5, 2016, at 8:24 PM, Ben Pfaff wrote:
> >
> > Thanks. That was my experience also.
> >
> > I applied this to master and branch-2.5.
>
> Thanks for fixing this. I reviewed the patch and it seems correct to me as
> w
> On Jan 5, 2016, at 8:24 PM, Ben Pfaff wrote:
>
> Thanks. That was my experience also.
>
> I applied this to master and branch-2.5.
Thanks for fixing this. I reviewed the patch and it seems correct to me as well.
> I think that branch-2.4 has
> the same bug but the backport is not trivial
From: David Wragg
Date: Wed, 6 Jan 2016 13:33:04 +
> Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
> any size, constrained only by the ability to transmit the resulting
> UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
> vports. These netdevs have
Python 3 removed support for "old-style classes". Classes should always
inherit from object to get consistent behavior between Python 2 and 3.
Enable a flake8 warning to help prevent regressions in the future.
Signed-off-by: Russell Bryant
---
Makefile.am | 3 ++-
debian/ovs-monit
Python 3 dropped exception handlers of the deprecated form:
except Exception, e:
You must use the newer syntax of:
except Exception as e:
This patch also enables a flake8 warning for this.
H231 Python 3.x incompatible 'except x,y:' construct
Signed-off-by: Russell Bryant
---
Makefile.
Fix imports of xmlrpclib to be compatible with Python 3. Python 2 had
xmlrpclib (client) and SimpleXMLRPCServer (server). In Python 3, these
have been renamed to xmlrpc.client and xmlrpc.server.
The solution implemented here is to use the six library. It may seem
excessive for this particular i
Octal constants must be written as 0o077 instead of 0077 to be
compatible with both Python 2 and 3.
Signed-off-by: Russell Bryant
---
Makefile.am | 3 ++-
debian/ovs-monitor-ipsec | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index
The print statement from Python 2 is a function in Python 3. Enable
print function support for Python 2 and convert print statements to
function calls.
Enable the H233 flake8 warning. If the hacking plugin is installed,
this will generate warnings for print statement usage not compatible
with Py
In Python 2, dict.items(), dict.keys(), and dict.values() returned a
list. dict.iteritems(), dict.iterkeys(), and dict.itervalues() returned
an iterator.
As of Python 3, dict.iteritems(), dict.itervalues(), and dict.iterkeys()
are gone. items(), keys(), and values() now return an iterator.
In t
Python 2 had range() and xrange(). xrange() is more efficient, but
behaves differently so range() was retained for compatibility. Python 3
only has range() and it behaves like Python 2's xrange().
Remove explicit use of xrange() and use six.moves.range() to
make sure we're using xrange() from Py
Python 3 removed support for tuple parameter unpacking.
https://www.python.org/dev/peps/pep-3113/
Instead of:
def foo((a, b)):
print(a)
print(b)
you should do:
def foo(a_b):
a, b = a_b
print(a)
print(b)
but in both uses here, the values were nev
I got the ovs Python code ported to Python 3 in a branch. I've been submitting
the work in pieces to make it a bit easier to review, iterate on, and merge.
This series of patches addresses an assortment of Python 3 compatibility
issues. This first patch is one that was submitted to the list a few
From: Terry Wilson
This patch fixes just the Python 3 problems found by running:
python3 setup.py install
There are still many other issues to be fixed, but this is a start.
Signed-off-by: Terry Wilson
[russ...@ovn.org resolved conflicts with current master]
Signed-off-by: Russell Bryant
-
Test case 1508-1514: OVSDB -- ovsdb-server monitors, call stacks:
ovsdb_schema_create (ovsdb.c:34)
ovsdb_schema_from_json (ovsdb.c:196)
fetch_schema (ovsdb-client.c:375)
do_monitor__ (ovsdb-client.c:920)
main (ovsdb-client.c:152)
Fix by adding ovsdb_schema_destroy()
Signed-off-
Test case 1205: generate and apply diff -- set -- size (ovsdb-data.at:827)
Call stack:
ovsdb_error_valist (ovsdb-error.c:40)
ovsdb_error (ovsdb-error.c:55)
do_diff_data (test-ovsdb.c:427)
ovs_cmdl_run_command (command-line.c:121)
main (test-ovsdb.c:72)
Fix by calling ovsdb_error
test case 1: appctl-bashcomp - basic verification
Reason: args used without being free
Call stacks:
ds_reserve (dynamic-string.c:63)
ds_put_uninit (dynamic-string.c:73)
ds_put_char__ (dynamic-string.c:82)
ds_put_char (dynamic-string.h:89)
process_escape_args (process.c:103)
Test case 890: ofproto-dpif - NetFlow flow expiration - IPv4 collector
Valgrind reports two leaks below:
unixctl_server_create (unixctl.c:250)
test_netflow_main (test-netflow.c:200)
ovstest_wrapper_test_netflow_main__ (test-netflow.c:301)
ovs_cmdl_run_command (command-line.c:121)
On 01/06/2016 01:08 PM, Ben Pfaff wrote:
> On Wed, Jan 06, 2016 at 11:53:10AM -0500, Russell Bryant wrote:
>> A previous patch added the list of warnings emitted by the docstrings
>> and hacking plugins for flake8. Switch to ignoring all warnings from
>> those plugins. We can use --select to enab
On Wed, Jan 06, 2016 at 11:53:10AM -0500, Russell Bryant wrote:
> A previous patch added the list of warnings emitted by the docstrings
> and hacking plugins for flake8. Switch to ignoring all warnings from
> those plugins. We can use --select to enable specific ones that we want
> if needed late
On Wed, Jan 06, 2016 at 11:50:15AM -0500, Russell Bryant wrote:
> On 01/06/2016 11:32 AM, Ben Pfaff wrote:
> > On Wed, Jan 06, 2016 at 10:19:56AM -0500, Russell Bryant wrote:
> >> On 01/06/2016 06:29 AM, Numan Siddique wrote:
> >>> with the flake8 check enabled, ovs compilation is failing. This
> >
A previous patch added the list of warnings emitted by the docstrings
and hacking plugins for flake8. Switch to ignoring all warnings from
those plugins. We can use --select to enable specific ones that we want
if needed later on.
Signed-off-by: Russell Bryant
---
Makefile.am | 2 +-
1 file ch
On 01/06/2016 11:32 AM, Ben Pfaff wrote:
> On Wed, Jan 06, 2016 at 10:19:56AM -0500, Russell Bryant wrote:
>> On 01/06/2016 06:29 AM, Numan Siddique wrote:
>>> with the flake8 check enabled, ovs compilation is failing. This
>>> patch adds few more flake8 types to the igore list.
>>>
>>> Signed-off-
On Wed, Jan 06, 2016 at 10:19:56AM -0500, Russell Bryant wrote:
> On 01/06/2016 06:29 AM, Numan Siddique wrote:
> > with the flake8 check enabled, ovs compilation is failing. This
> > patch adds few more flake8 types to the igore list.
> >
> > Signed-off-by: Numan Siddique
>
> Thanks for the pat
On 12/31/2015 06:55 AM, Ofer Ben Yacov wrote:
> Currently the IDL does not support passive TCP connection,
> i.e. when the OVSDB connects to its manager.
>
> This patch enables IDL to use an already-open session
> (the one which was previously used for retrieving the db schema).
> In addition, it
On 01/06/2016 06:29 AM, Numan Siddique wrote:
> with the flake8 check enabled, ovs compilation is failing. This
> patch adds few more flake8 types to the igore list.
>
> Signed-off-by: Numan Siddique
Thanks for the patch! After some discussion on IRC and more testing, I
pushed this to master wi
On 01/06/2016 09:23 AM, Numan Siddique wrote:
> On 01/06/2016 07:46 PM, Russell Bryant wrote:
>> On 01/06/2016 06:47 AM, Numan Siddique wrote:
>>> I guess this patch is not required, once Russel's patches on - Python style
>>> fixes and flake8 integration
>>> are completely merged.
>> They are all
On 01/06/2016 07:46 PM, Russell Bryant wrote:
> On 01/06/2016 06:47 AM, Numan Siddique wrote:
>> I guess this patch is not required, once Russel's patches on - Python style
>> fixes and flake8 integration
>> are completely merged.
> They are all merged now. What version of flake8 do you have?
>
>
On 01/06/2016 06:47 AM, Numan Siddique wrote:
> I guess this patch is not required, once Russel's patches on - Python style
> fixes and flake8 integration
> are completely merged.
They are all merged now. What version of flake8 do you have?
I had this originally:
$ flake8 --version
2.4.1 (pep8
Prior to 4.3, vxlan vports could transmit vxlan packets of any size,
constrained only by the ability to transmit the resulting UDP packets.
4.3 introduced vxlan netdevs corresponding to vxlan vports. These
netdevs have an MTU, which limits the size of a packet that can be
successfully vxlan-encaps
Allow the MTU of vxlan devices without an underlying device to be set to
larger values (up to a maximum based on IP packet limits and vxlan
overhead).
Previously, their MTUs could not be set to higher than the conventional
ethernet value of 1500. This is a very arbitrary value in the context
of v
Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of
any size, constrained only by the ability to transmit the resulting
UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan
vports. These netdevs have an MTU, which limits the size of a packet
that can be successfully
On Tue, Jan 5, 2016 at 6:44 PM, Liran Schour wrote:
> Python idl works now with "monitor_cond" method. Add test
> for backward compatibility with old "monitor" method.
>
> Signed-off-by: Liran Schour
> ---
> python/ovs/db/data.py | 12
> python/ovs/db/idl.py | 161
> +
How is the label value, TTL, mpls_tc and bos get inserted into the first mpls
label in openvSwitch?. I had looked into the OpenvSwitch flow_push_mpls (in
openvswitch/lib/flow.c) class function but could not find the appropriate
coding for generating the above mpls label fields.
Pls help, I need
I guess this patch is not required, once Russel's patches on - Python style
fixes and flake8 integration
are completely merged.
Thanks
Numan
On 01/06/2016 04:59 PM, Numan Siddique wrote:
> with the flake8 check enabled, ovs compilation is failing. This
> patch adds few more flake8 types to the
with the flake8 check enabled, ovs compilation is failing. This
patch adds few more flake8 types to the igore list.
Signed-off-by: Numan Siddique
---
Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.am b/Makefile.am
index 8b6ddb7..cb73ca6 100644
--- a/Make
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
58 matches
Mail list logo
