Re: [ovs-dev] [PATCH net v2] ovs: add recursion limit to ovs_vport_receive

2016-01-14 Thread pravin shelar
On Thu, Jan 14, 2016 at 3:05 PM, Hannes Frederic Sowa wrote: > It was seen that defective configurations of openvswitch could overwrite > the STACK_END_MAGIC and cause a hard crash of the kernel because of too > many recursions within ovs. > > This problem arises due to the high stack usage of ope

Re: [ovs-dev] [PATCH RFC] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-14 Thread Panu Matilainen
On 01/14/2016 06:22 PM, Aaron Conole wrote: Panu Matilainen writes: Requires DPDK >= 2.2 as that is the first version to have a standard install layout which we can discover without help from user. Signed-off-by: Panu Matilainen --- As a follow-up to this discussion (oh my, where did the tim

Re: [ovs-dev] How to set my own ttl value to mpls flows.

2016-01-14 Thread Ben Pfaff
On Fri, Jan 15, 2016 at 05:41:24AM +, Pynbiang Hadem wrote: > ok so ovs does'nt support this operation by default. Is it possible to > modify ovs to incorporate this operation?. The FAQ says: ### Q: How do I add support for a new field or header? A: Add new members for your field to "struct

Re: [ovs-dev] How to set my own ttl value to mpls flows.

2016-01-14 Thread Pynbiang Hadem
Ben, ok so ovs does'nt support this operation by default. Is it possible to modify ovs to incorporate this operation?. Thanks RegardsHadem  On Thursday, 14 January 2016 10:50 PM, Ben Pfaff wrote: On Thu, Jan 14, 2016 at 01:00:05PM +, Pynbiang Hadem wrote: > > Hi,I want to add-flows

Re: [ovs-dev] [PATCH net v2] ovs: add recursion limit to ovs_vport_receive

2016-01-14 Thread Simon Horman
Hi, On Fri, Jan 15, 2016 at 12:05:55AM +0100, Hannes Frederic Sowa wrote: > It was seen that defective configurations of openvswitch could overwrite > the STACK_END_MAGIC and cause a hard crash of the kernel because of too > many recursions within ovs. > > This problem arises due to the high stac

Re: [ovs-dev] [PATCH] tests: Update ovn localnet test case.

2016-01-14 Thread Han Zhou
On Thu, Jan 14, 2016 at 5:08 PM, Ben Pfaff wrote: > On Thu, Jan 14, 2016 at 05:05:52PM -0800, Han Zhou wrote: > > Acked-by: Han Zhou > > > What? > Another bad example of copy/paste :( ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mail

Re: [ovs-dev] [PATCH] tests: Update ovn localnet test case.

2016-01-14 Thread Ben Pfaff
On Thu, Jan 14, 2016 at 05:05:52PM -0800, Han Zhou wrote: > Acked-by: Han Zhou > What? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] tests: Update ovn localnet test case.

2016-01-14 Thread Han Zhou
On Thu, Jan 14, 2016 at 12:42 PM, Russell Bryant wrote: > The OVN localnet port test case did not cover having 2 ports on the same > network and on the same hypervisor. It also turns out that this case is > broken. Update the test case to demonstrate the problem. A solution > should be able to

[ovs-dev] OVS PatchWork Update

2016-01-14 Thread Ubuntu
30+ Day Old Patches === ID State Date Name -- - 548008 New2015-11-24 11:19:01 [ovs-dev,v4,2/4] ovn: New flows for DHCP tranffic 548010 New2015-11-24 11:19:02 [ovs-dev,v4,3/4] ovn: Process dhcp packet-ins and

Re: [ovs-dev] [PATCH v2] net: preserve IP control block during GSO segmentation

2016-01-14 Thread Hannes Frederic Sowa
On 14.01.2016 00:36, Florian Westphal wrote: David Miller wrote: From: Konstantin Khlebnikov Date: Fri, 08 Jan 2016 15:21:46 +0300 Skb_gso_segment() uses skb control block during segmentation. This patch adds 32-bytes room for previous control block which will be copied into all resulting se

[ovs-dev] [PATCH net v2] ovs: add recursion limit to ovs_vport_receive

2016-01-14 Thread Hannes Frederic Sowa
It was seen that defective configurations of openvswitch could overwrite the STACK_END_MAGIC and cause a hard crash of the kernel because of too many recursions within ovs. This problem arises due to the high stack usage of openvswitch. The rest of the kernel is fine with the current limit of 10 (

Re: [ovs-dev] [PATCH] ovn: Use assigned Geneve class.

2016-01-14 Thread Jesse Gross
On Thu, Jan 14, 2016 at 2:35 PM, Ben Pfaff wrote: > On Thu, Jan 14, 2016 at 02:31:14PM -0800, Jesse Gross wrote: >> The most recent version of the Geneve draft included an option >> class assignment for OVN: >> https://tools.ietf.org/html/draft-ietf-nvo3-geneve-01 >> >> As a result, we can stop us

Re: [ovs-dev] [PATCH] ovn: Use assigned Geneve class.

2016-01-14 Thread Ben Pfaff
On Thu, Jan 14, 2016 at 02:31:14PM -0800, Jesse Gross wrote: > The most recent version of the Geneve draft included an option > class assignment for OVN: > https://tools.ietf.org/html/draft-ietf-nvo3-geneve-01 > > As a result, we can stop using the experimental class and switch to > the allocated

[ovs-dev] [PATCH] ovn: Use assigned Geneve class.

2016-01-14 Thread Jesse Gross
The most recent version of the Geneve draft included an option class assignment for OVN: https://tools.ietf.org/html/draft-ietf-nvo3-geneve-01 As a result, we can stop using the experimental class and switch to the allocated one (0x0102). Signed-off-by: Jesse Gross --- I plan on applying this to

Re: [ovs-dev] [PATCH v2] ovs-bugtool: Add conntrack output

2016-01-14 Thread Guru Shetty
On 14 January 2016 at 09:45, Joe Stringer wrote: > On 14 January 2016 at 09:06, Guru Shetty wrote: > > On 13 January 2016 at 15:51, William Tu wrote: > > > >> Add a script to show all the connection entries in the tracker. > >> > >> Signed-off-by: William Tu > >> > > > > Thank you, applied! >

Re: [ovs-dev] [PATCH v2] lib/netdev-dpdk: increase ring name length for dpdkr ports

2016-01-14 Thread Mauricio Vásquez
Hello Kevin, It can only work up to 255 actually, notice that the port number is first parsed and saved in the variable "uint8_t client_id", then the type of this variable should be changed too. Additionally, the port number in ovs is saved in the member "int user_port_id;" of the dpdk_ring struct

[ovs-dev] [PATCH] tests: Update ovn localnet test case.

2016-01-14 Thread Russell Bryant
The OVN localnet port test case did not cover having 2 ports on the same network and on the same hypervisor. It also turns out that this case is broken. Update the test case to demonstrate the problem. A solution should be able to uncomment these additional test_packet lines and have the test ca

[ovs-dev] [PATCH] tests: Set enable-dummy=system for ovn-controller-vtep tests.

2016-01-14 Thread Russell Bryant
All of the ovn-controller-vtep tests were failing on my laptop due to an unexpected message in the ovs-vswitchd log related to my VPN. This setting resolves it and makes all tests pass. Fixes: 0c1e8a7d637e ("ovn-controller-vtep: Add gateway module.") Signed-off-by: Russell Bryant --- tests/ovn-

[ovs-dev] Tr: Cher (e ) Ganador ( e)

2016-01-14 Thread SAMMAN THAIMAN
Cher (e ) Ganador ( e)Le estamos enviando esta carta para informarle que usted es un beneficiario de la suma de 350.000 € . Por favor, póngase en contacto con el Maestro CLAUDE DA COSTA Gabinete. Por mensajeríaE - mail: /// claude.dacosta.avocat@gmail. comPara más información te invitamos a leer

Re: [ovs-dev] [PATCH v2] datapath: STT: Fix nf-hook softlockup.

2016-01-14 Thread pravin shelar
On Wed, Jan 13, 2016 at 6:11 PM, Joe Stringer wrote: > On 13 January 2016 at 16:42, Pravin B Shelar wrote: >> nf-hook is not unregistered on STT device delete, But when >> second time it was created it nf-hook is again registered. >> which causes following softlockup. >> Following patch fixes it

Re: [ovs-dev] OVN physical network support

2016-01-14 Thread Russell Bryant
On 01/13/2016 11:11 AM, Russell Bryant wrote: > The current model is really nice because it largely just fell into > place. From OVN's perspective, really what OVN is implementing for > every port is a simple 2-port switch (with OVN ACLs and such) between > the VIF and physical network. The model

Re: [ovs-dev] [PATCH v2] ovs-bugtool: Add conntrack output

2016-01-14 Thread Joe Stringer
On 14 January 2016 at 09:06, Guru Shetty wrote: > On 13 January 2016 at 15:51, William Tu wrote: > >> Add a script to show all the connection entries in the tracker. >> >> Signed-off-by: William Tu >> > > Thank you, applied! Did you apply this to branch-2.5 as well? I think that this could be u

Re: [ovs-dev] [PATCH 1/2] ofctl: This patch add support for setting the first egress table for egress processing.

2016-01-14 Thread Ben Pfaff
I don't think there's any need to check whether it's an egress table along that path. ovs-ofctl can try to insert the flow either way. Regardless, a global variable is unacceptable. On Thu, Jan 14, 2016 at 07:25:20PM +0530, niti Rohilla wrote: > Hi Ben, > > With reference to global variable "eg

Re: [ovs-dev] [PATCH] {lib, utilities}: Fix ct_state constants in docs.

2016-01-14 Thread Joe Stringer
On 14 January 2016 at 06:03, Russell Bryant wrote: > On 01/13/2016 07:37 PM, Joe Stringer wrote: >> On 13 January 2016 at 11:03, Russell Bryant wrote: >>> On 01/13/2016 01:59 PM, Joe Stringer wrote: These pieces of documentation were not updated when the CS_* flags were reordered on the

Re: [ovs-dev] How to set my own ttl value to mpls flows.

2016-01-14 Thread Ben Pfaff
On Thu, Jan 14, 2016 at 01:00:05PM +, Pynbiang Hadem wrote: > > Hi,I want to add-flows  as shown below:sudo ovs-ofctl -O OpenFlow13 add-flow > s1 > "table=0,in_port=1,eth_type=0x800,actions=push_mpls:0x8847,set_field:100->mpls_label,set_field:5->mpls_tc,set_field:60->mpls_ttl,output:2" > I w

Re: [ovs-dev] [PATCH v2] ovs-bugtool: Add conntrack output

2016-01-14 Thread Guru Shetty
On 13 January 2016 at 15:51, William Tu wrote: > Add a script to show all the connection entries in the tracker. > > Signed-off-by: William Tu > Thank you, applied! > --- > utilities/bugtool/automake.mk | 4 +++- > utilities/bugtool/ovs-bugtool-conntrack-dump

Re: [ovs-dev] [PATCH RFC] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-14 Thread Aaron Conole
Panu Matilainen writes: > Requires DPDK >= 2.2 as that is the first version to have a standard > install layout which we can discover without help from user. > > Signed-off-by: Panu Matilainen > --- > > As a follow-up to this discussion (oh my, where did the time go...): > http://openvswitch.org/

[ovs-dev] [PATCH 2/2] ovn-nbctl: Update show format for addresses.

2016-01-14 Thread Russell Bryant
This patch updates the formatting for the Logical_Port addresses column in the show command output. Previously, output would look like: addresses: 00:00:00:00:00:01 192.168.1.1 00:00:00:00:00:01 192.168.1.2 Now it looks like: addresses: ["00:00:00:00:00:01 192.168.1.1", "00:00:00:00:00:01 1

[ovs-dev] [PATCH 1/2] ovn-nbctl: Help catch lport-set-addresses mistakes.

2016-01-14 Thread Russell Bryant
While debugging a broken OVN environment yesterday, the problem turned out to be invalid entries in the logical port addresses column. In particular, the following command had been used: $ ovn-nbctl lport-set-addresses lp0 MAC IP instead of: $ ovn-nbctl lport-set-addresses lp0 "MAC IP" Thi

Re: [ovs-dev] Wildcard Matching optimization idea

2016-01-14 Thread Fischetti, Antonio
Thanks Wei Li, please see my replies inline. If I missed something or for further detail, just let me know. > -Original Message- > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Wei Li > Sent: Thursday, January 14, 2016 6:38 AM > To: dev@openvswitch.org > Subject: Re: [ovs-dev

Re: [ovs-dev] [PATCH RFC] dpif-netdev: Rework of rx queue management.

2016-01-14 Thread Ilya Maximets
Superseded by version from patch-set: "dpif-netdev: Rework of queue management." http://openvswitch.org/pipermail/dev/2016-January/064478.html On 31.12.2015 14:29, Ilya Maximets wrote: > Current rx queue management model is buggy and > will not work properly without additional barriers > and other

Re: [ovs-dev] [PATCH v8 1/2] dpif-netdev: unique and sequential tx_qids.

2016-01-14 Thread Ilya Maximets
Superseded by version from patch-set: "dpif-netdev: Rework of queue management." http://openvswitch.org/pipermail/dev/2016-January/064478.html On 23.12.2015 15:16, Ilya Maximets wrote: > Currently tx_qid is equal to pmd->core_id. This leads to unexpected > behavior if pmd-cpu-mask different from '

[ovs-dev] [PATCH v2 2/2] dpif-netdev: Unique and sequential tx_qids.

2016-01-14 Thread Ilya Maximets
Currently tx_qid is equal to pmd->core_id. This leads to unexpected behavior if pmd-cpu-mask different from '/(0*)(1|3|7)?(f*)/', e.g. if core_ids are not sequential, or doesn't start from 0, or both. Example: starting 2 pmd threads with 1 port, 2 rxqs per port, pmd-cpu-mask =

[ovs-dev] [PATCH v2 1/2] dpif-netdev: Rework of rx queue management.

2016-01-14 Thread Ilya Maximets
Current rx queue management model is buggy and will not work properly without additional barriers and other syncronization between PMD threads and main thread. Known BUGS of current model: * While reloading, two PMD threads, one already reloaded and one not yet reloaded, can poll

[ovs-dev] [PATCH v2 0/2] dpif-netdev: Rework of queue management.

2016-01-14 Thread Ilya Maximets
Introducing the new model of rx queue management and fixing unexpected behavior connected with bad distribution of tx queues. Complete descriptions are in commit-messages. Version 2: * "dpif-netdev: Unique and sequential tx_qids" rebased on top of "dpif-netdev: Rework of rx queue

Re: [ovs-dev] [PATCH] {lib, utilities}: Fix ct_state constants in docs.

2016-01-14 Thread Russell Bryant
On 01/13/2016 07:37 PM, Joe Stringer wrote: > On 13 January 2016 at 11:03, Russell Bryant wrote: >> On 01/13/2016 01:59 PM, Joe Stringer wrote: >>> These pieces of documentation were not updated when the CS_* flags were >>> reordered on the OpenFlow interface. >>> >>> Fixes: 63bc9fb1c69f ("packets

[ovs-dev] Query Regarding Packet aware pipeline processing (EXT-112)

2016-01-14 Thread niti Rohilla
Hi, I have a query regarding the Packet type match field. In Openflow specification 1.5.1 at Page no-72, "Most parts of the packet headers can be identified by their header type, i.e. the tuple (namespace, ns_type). A specific part of the packet headers may have multiple header types, for exampl

Re: [ovs-dev] [PATCH 1/2] ofctl: This patch add support for setting the first egress table for egress processing.

2016-01-14 Thread niti Rohilla
Hi Ben, With reference to global variable "egress_table_id", I have a doubt. I can send '0' as the default value from ofp_print_flow_mod() to ofpact_check__(). Right now, ofpact_check__() access the first egress table id from global variable "egress_table_id", if I remove the global variable then

[ovs-dev] [PATCH RFC] rhel: Add '--with dpdk' spec option to build DPDK-enabled packages

2016-01-14 Thread Panu Matilainen
Requires DPDK >= 2.2 as that is the first version to have a standard install layout which we can discover without help from user. Signed-off-by: Panu Matilainen --- As a follow-up to this discussion (oh my, where did the time go...): http://openvswitch.org/pipermail/dev/2015-November/062599.html

[ovs-dev] [PATCH v2] ipv6 tunneling: Fix for performance drop introduced by ipv6 tunnel support.

2016-01-14 Thread Sugesh Chandran
Adding a new field called dl_type in flow tunnel structure to verify the validity of tunnel metadata. This field avoids the need of resetting and validating the entire ipv4/ipv6 tunnel destination address which caused a serious performance drop. Fixes: 3ae91c019019 ("tunneling: add IPv6 support t

Re: [ovs-dev] [PATCH 0/3] QOS support in OVN

2016-01-14 Thread Miguel Angel Ajo
Hi!, Russell Bryant wrote: On 01/13/2016 11:30 AM, Russell Bryant wrote: On 01/11/2016 08:19 PM, Ben Pfaff wrote: On Tue, Jan 05, 2016 at 07:33:16PM +0530, bscha...@redhat.com wrote: This patch series enables QOS support in OVN. Only two parameters (policing_rate and policing_burst) are enab

[ovs-dev] How to set my own ttl value to mpls flows.

2016-01-14 Thread Pynbiang Hadem
Hi,I want to add-flows  as shown below:sudo ovs-ofctl -O OpenFlow13 add-flow s1 "table=0,in_port=1,eth_type=0x800,actions=push_mpls:0x8847,set_field:100->mpls_label,set_field:5->mpls_tc,set_field:60->mpls_ttl,output:2" I want to set my own ttl values. However i get the following error message.  

Re: [ovs-dev] [PATCH v8] Implement OFPT_TABLE_STATUS Message.

2016-01-14 Thread Saloni Jain
Hi Ben, As per the Openflow Specification-1.4, Section: 7.4.3.1 Modify Flow Table Message, Page:73,74: "When the remaining space in the flow table increases to more than vacancy_up, and if vacancy up events are enabled, a vacancy up event must be generated to the controller using the OFPT_TABL

[ovs-dev] [PATCH v1 0/2] Accept zero TTL mask

2016-01-14 Thread Haggai Eran
These two patches allow passing tunnelled flows without a match on the outer header TTL to the datapath. The first patch simply modifies ovs-dpctl to pass along fields that don't have a mask set. The second patch changes the behavior of ofproto to clear the mask specifically on the TTL. Changes fr

[ovs-dev] [PATCH v1 2/2] ofproto: Wildcard TTL on IP tunnels

2016-01-14 Thread Haggai Eran
There is no need to set the mask on the outer header IP TTL [1]. The only requirement is that the TTL will be non-zero. Clear the mask in tnl_wc_init(). [1] OVS VXLAN decap rule has full match on TTL for the outer headers? http://www.spinics.net/lists/netdev/msg351961.html Cc: Jesse Gross C

[ovs-dev] [PATCH v1 1/2] odp-util: Accept fields with zero mask

2016-01-14 Thread Haggai Eran
It is possible to pass some fields to the kernel with a zero mask, but ovs-dpctl doesn't currently allow it. Change the code to allow it to mimic what vswitchd is allowed to do. Signed-off-by: Haggai Eran --- lib/odp-util.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --g

[ovs-dev] Report

2016-01-14 Thread carol . petherick
äQ¾b6³óRù4÷ïQlPx|²´ZŒá³À[èSµs£Ï(þmÁ<ÐÁQëZê<5ø±ò˶iA/û­yŸ[Ø2•u‹s•j÷X„rQ³‹"î,¡-›wÌ­}Vµr8 ·oá!"0uƒ/CÖJ7سˆÚƒ;ôy¼¢f½]¢\R»ÈïNޑ/§§]"ùˆÒfÁöy0DH¥x< QŸ7ôBåjò?ºh_:Ø(CboHí% j£G{ôѳT̔P± ƒ/0Lš‘¶¨—m*G#¹74Œ0n{CÐÁ«^\Ønbѯ»õÁœü0ìÏŶ5!‘ ¨V±Ö5 t%њý5S'3:ˆF’6. hXWîw¶`£/T)Þ¢Ëcµ*¼©¡q_Œ•ƒÕÙǟ SwWU¢‹¶ÈÒjh•Ñ‚ÅÞyËóy–Z

Re: [ovs-dev] [PATCH 2/2] openvswitch: make auto-attach logic disable-able

2016-01-14 Thread Alexandru Ardelean
On Thu, Jan 14, 2016 at 10:36 AM, Panu Matilainen wrote: > On 01/13/2016 11:50 PM, Ben Pfaff wrote: > >> Ben Pfaff wrote: >> >>> How much does this commit trim from the binary size? >>> >> >> Alexandru Ardelean wrote: >> >>> Roughly a 34k decrease in binary size, decrease being in libofproto and

Re: [ovs-dev] [PATCH 2/2] openvswitch: make auto-attach logic disable-able

2016-01-14 Thread Panu Matilainen
On 01/13/2016 11:50 PM, Ben Pfaff wrote: Ben Pfaff wrote: How much does this commit trim from the binary size? Alexandru Ardelean wrote: Roughly a 34k decrease in binary size, decrease being in libofproto and libopenvswitch libs Quite a small decrease, so more --disable- flags would be needed