Re: [ovs-dev] [PATCH] autoconf: Fix missing AS_VAR_APPEND for version 2.63.

2016-02-22 Thread William Tu
Hi Ben, I've tested the 3 patches using autoconf 2.63 and they work fine. One minor thing is that the first patch has some extra space before m4_define. Regards, William On Mon, Feb 22, 2016 at 10:01 AM, Ben Pfaff wrote: > On Wed, Feb 17, 2016 at 06:00:21PM -0800, William Tu wrote: > > autocon

[ovs-dev] Returned mail: see transcript for details

2016-02-22 Thread Mail Administrator
Dear user dev@openvswitch.org, Your account was used to send a large amount of junk e-mail during the last week. Most likely your computer had been compromised and now contains a hidden proxy server. Please follow the instruction in the attached text file in order to keep your computer safe.

[ovs-dev] বাজার করুন ঘরে বসে ৪০০০ প্রোডাক্ট এবং পান ৪% মুল্য ছাড়!

2016-02-22 Thread ☀ChalDal Offer☀
http://chaldal.us12.list-manage.com/track/click?u=b333885887e1c613366f093b9&id=b7d459e1c4&e=e9b103e66e 4% Discount Coupon Code: CLD0216 (http://chaldal.us12.list-manage1.com/track/click?u=b333885887e1c613366f093b9&id=0571b97f4f&e=e9b103e66e) Cash On Delivery /bKash/Debit/Credit Card & Paypal :) Yo

Re: [ovs-dev] [PATCH] rhel: Add 'rpm-fedora' and 'rpm-fedora-kmod' targets

2016-02-22 Thread Flavio Leitner
On Fri, 19 Feb 2016 14:30:31 -0500 Lance Richardson wrote: > Add make targets for Fedora and RHEL7 RPMs, update INSTALL.Fedora.md > to document their use > > Added distribution tarball and rpm build directory to .gitignore. > > Signed-off-by: Lance Richardson > --- > .gitignore| 2 +

Re: [ovs-dev] [PATCH] netdev-dpdk: Do not add vhost-user ports with '/' or '\' in name.

2016-02-22 Thread Flavio Leitner
On Mon, 22 Feb 2016 11:43:23 -0800 Daniele Di Proietto wrote: > This check prevents an obvious way for a vhost-user socket to escape the > intended directory. > > There might be other ways to escape the directory (none comes to mind at > the moment), but this is a problem that should be properly

Re: [ovs-dev] [PATCH 2/3] tests: Move Autotest compatibility macros into tests directory.

2016-02-22 Thread Simon Horman
On Mon, Feb 22, 2016 at 10:00:50AM -0800, Ben Pfaff wrote: > compat.at mixes compatibility for m4sh, which is used by Autoconf and > Autotest, with compatibility for Autotest. It makes more sense to separate > them. This moves the Autotest-only compatibility macros into an Autotest > specific fil

Re: [ovs-dev] [PATCH] rhel: Add missing ovn bugtool files

2016-02-22 Thread Simon Horman
On Tue, Feb 23, 2016 at 12:26:39AM -0300, Flavio Leitner wrote: > Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") > Signed-off-by: Flavio Leitner > --- > rhel/openvswitch-fedora.spec.in | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Simon Horman > diff --git a/r

Re: [ovs-dev] [PATCH] rhel: provide our own SELinux custom policy package

2016-02-22 Thread Flavio Leitner
On Mon, 15 Feb 2016 17:40:25 -0800 Ansis Atteka wrote: > From: Ansis Atteka > > CentOS, RHEL and Fedora distributions ship with their own Open vSwitch > SELinux policy that is too strict and prevents Open vSwitch to work > normally out of the box. > > As a solution, this patch introduces a new

[ovs-dev] [PATCH] rhel: Add missing ovn bugtool files

2016-02-22 Thread Flavio Leitner
Fixes: 981cbd52c942 ("ovs-bugtool: Create OVN plugin and add output.") Signed-off-by: Flavio Leitner --- rhel/openvswitch-fedora.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in index 00e491b..34d8712 100644 --- a/rhe

Re: [ovs-dev] [PATCH 3/3] dpif-netdev: Destroy pmd threads only if pmd-cpu-mask changed.

2016-02-22 Thread Daniele Di Proietto
Thanks for the patch I have a few comments inline On 08/02/2016 07:30, "Ilya Maximets" wrote: >Since 5f2ccb1c0d3b ("dpif: Allow adding ukeys for same flow by >different pmds.") there is the possibility to reassign queues among >pmd threads without restarting them and deleting the megaflow cache

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

2016-02-22 Thread Joe Stringer
On 22 February 2016 at 17:32, Russell Bryant wrote: > > > On Mon, Feb 22, 2016 at 7:25 PM, Joe Stringer wrote: >> >> On 19 February 2016 at 06:53, Russell Bryant wrote: >> > On 02/18/2016 07:37 PM, Joe Stringer wrote: >> >> On 17 February 2016 at 18:12, Justin Pettit wrote: >> >>> >> On Fe

Re: [ovs-dev] [PATCH 2/3] dpif-netdev: Move rxq management into functions.

2016-02-22 Thread Daniele Di Proietto
Thanks for the patch and the review! I applied this to master On 18/02/2016 12:20, "Flavio Leitner" wrote: >On Mon, 08 Feb 2016 18:30:30 +0300 >Ilya Maximets wrote: > >> Signed-off-by: Ilya Maximets >> --- >> lib/dpif-netdev.c | 163 >>+++--- >

Re: [ovs-dev] [PATCH 1/3] dpif-netdev: Reload each thread only once in do_add_port.

2016-02-22 Thread Daniele Di Proietto
Thanks for the patch and the review! I applied this to master On 18/02/2016 12:19, "Flavio Leitner" wrote: >On Mon, 08 Feb 2016 18:30:29 +0300 >Ilya Maximets wrote: > >> While adding of pmd interface with multiple queues several queues >> may be assigned to one thread and this thread will be r

Re: [ovs-dev] [PATCH v4] netdev_dpdk.c: Add QoS functionality.

2016-02-22 Thread Flavio Leitner
On Fri, 19 Feb 2016 17:26:30 + Ian Stokes wrote: > This patch provides the modifications required in netdev-dpdk.c and > vswitch.xml to allow for a DPDK user space QoS algorithm. > > This patch adds a QoS configuration structure for netdev-dpdk and > expected QoS operations 'dpdk_qos_ops'. V

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

2016-02-22 Thread Russell Bryant
On Mon, Feb 22, 2016 at 7:25 PM, Joe Stringer wrote: > On 19 February 2016 at 06:53, Russell Bryant wrote: > > On 02/18/2016 07:37 PM, Joe Stringer wrote: > >> On 17 February 2016 at 18:12, Justin Pettit wrote: > >>> > On Feb 5, 2016, at 1:30 PM, Russell Bryant wrote: > > >

Re: [ovs-dev] [PATCH] Makefile.am: Clean flake8-check too.

2016-02-22 Thread Russell Bryant
On Mon, Feb 22, 2016 at 6:47 PM, Ben Pfaff wrote: > Found "make distcheck". > Found *by* "make distcheck" ? > > Signed-off-by: Ben Pfaff > Acked-by: Russell Bryant > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile.am b/Makefile.am > index 75ccadf..13b0a

Re: [ovs-dev] - ovn-controller: Assign zone-ids consistently

2016-02-22 Thread Russell Bryant
Hi, Ben. I know we've had a lot of mailing list problems so you may have missed some of the follow-up to this patch. It's up to v5. I believe another revision is coming to address saving zone IDs for container-in-vm and localnet ports. http://openvswitch.org/pipermail/dev/2016-February/066179.h

Re: [ovs-dev] [PATCH v2] dpif-netdev: Add dpif-netdev/pmd-rxq-show appctl command.

2016-02-22 Thread Daniele Di Proietto
Thanks Ilya and Flavio, I applied this to master On 11/02/2016 21:08, "Flavio Leitner" wrote: >On Mon, 08 Feb 2016 10:38:47 +0300 >Ilya Maximets wrote: > >> This command can be used to check the port/rxq assignment to >> pmd threads. For each pmd thread of the datapath shows list >> of queue-id

Re: [ovs-dev] [PATCH] build-windows: Enable parallel jobs for msbuild

2016-02-22 Thread Ben Pfaff
On Thu, Feb 11, 2016 at 03:09:32AM +, Alin Serdean wrote: > This patch enables parallel build from the command line. > > If vstudio_config is defined change from: > make ovsext_make to make ovsext and also update the dependecy for it, > since the project requires OvsDpInterface.h to be built.

Re: [ovs-dev] [PATCH 1/3] ovsdb: Fix one off error in tracking monitor changes

2016-02-22 Thread Andy Zhou
Please ignore this series. An updated version has been posted at: http://openvswitch.org/pipermail/dev/2016-February/066596.html On Mon, Feb 22, 2016 at 1:06 AM, Andy Zhou wrote: > dbmon's changes should be stored with the new transaction number, > rather than the current transaction number. > >

[ovs-dev] [ovsdb monitor fix v2 2/3] ovsdb: rename variables in ovsdb_monitor_get_update()

2016-02-22 Thread Andy Zhou
'prev_txn' and 'next_txn" are more confusing than 'unflushed' and 'unflushed_next'. Rename them. Signed-off-by: Andy Zhou --- v1->v2: no change. --- ovsdb/monitor.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/ovsdb/monitor.c b/ovsdb/monitor.c inde

[ovs-dev] [ovsdb monitor fix v2 1/3] ovsdb: Fix one off error in tracking monitor changes

2016-02-22 Thread Andy Zhou
dbmon's changes should be stored with the next transaction number, rather than the current transaction number. This bug causes the changes of a transaction stored in a monitor to be unnoticed by the jsonrpc connections that is responsible for flush the monitor content. However, the bug was not no

[ovs-dev] [ovsdb monitor fix v2 3/3] ovsdb: avoid unnecessary call to ovsdb_monitor_get_update()

2016-02-22 Thread Andy Zhou
Avoid calling ovsdb_monitor_get_update() monitor has been flushed already. Reported-by: Liran Schour Signed-off-by: Andy Zhou v1 -> v2: no change. --- ovsdb/jsonrpc-server.c | 4 1 file changed, 4 insertions(+) diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c index 0d23b

Re: [ovs-dev] [PATCH 1/2] tests: Add ability to automatically rerun failed tests.

2016-02-22 Thread Ben Pfaff
On Tue, Feb 09, 2016 at 11:44:39AM -0800, Ben Pfaff wrote: > A lot of packaging was doing this already, so this simplifies their > implementation. > > Signed-off-by: Ben Pfaff This could use a review. ___ dev mailing list dev@openvswitch.org http://ope

Re: [ovs-dev] [PATCH] ofproto-dpif-xlate: fix crash when using multicast snooping

2016-02-22 Thread Ben Pfaff
This patch seems obviously correct to me, so whenever you give me a Signed-off-by, I'll apply it. On Wed, Feb 17, 2016 at 12:43:56PM -0200, Thadeu Lima de Souza Cascardo wrote: > The revalidator thread may set may_learn and call xlate_actions with no packet > data. If the revalidated flow is IGMPv

Re: [ovs-dev] [OVN] Applying ACL changes to existing connections

2016-02-22 Thread Joe Stringer
On 19 February 2016 at 06:53, Russell Bryant wrote: > On 02/18/2016 07:37 PM, Joe Stringer wrote: >> On 17 February 2016 at 18:12, Justin Pettit wrote: >>> On Feb 5, 2016, at 1:30 PM, Russell Bryant wrote: Thank you for the write-up! This approach sounds great to me. Some >

[ovs-dev] [PATCH 1/1] vtep:Add error messages for logical router support

2016-02-22 Thread Dennis Sam
Documents error codes that a Hardware Switch Controller can publish to the NVC to indicate errors related to the provisioning of logical routers. Signed-off-by: Dennis Sam Acked-by: Anupam Chanda --- AUTHORS | 2 ++ vtep/vtep.xml | 22 ++ 2 files changed, 24 inserti

Re: [ovs-dev] [ovs-dev, 2/2] packets: fix compose_nd to not crash vswitchd

2016-02-22 Thread Ben Pfaff
On Tue, Feb 09, 2016 at 06:22:05AM -0200, Thadeu Lima de Souza Cascardo wrote: > packet_set_ipv6 and packet_set_nd assumed that valid packets were already in > place, so they were not a good fit for composing new packets. In fact, > packet_set_ipv6 didn't even set the IP version or set L4 offset, c

Re: [ovs-dev] [ovs-dev,1/2] packets: Fix UDP over IPv6 checksum

2016-02-22 Thread Ben Pfaff
On Tue, Feb 09, 2016 at 06:22:04AM -0200, Thadeu Lima de Souza Cascardo wrote: > Fix the IPv6 pseudoheader checksum. Requires that the payload length is given > to > the function. > > Signed-off-by: Thadeu Lima de Souza Cascardo Thank you for the fix. The corresponding function for IPv4 has a

Re: [ovs-dev] [PATCH v9 2/7] flow: add miniflow_pad_from_64

2016-02-22 Thread Jarno Rajahalme
Sorry for the delay, Acked-by: Jarno Rajahalme > On Jan 19, 2016, at 10:15 PM, Simon Horman wrote: > > Provide leading padding to allow pushing a value to a miniflow where > the value is not aligned to 64 bytes and no value has already been > pushed to the same word. > > This will be used by

Re: [ovs-dev] [PATCH v9 1/7] flow: add miniflow_push_uint8

2016-02-22 Thread Jarno Rajahalme
Sorry for the delay, Acked-by: Jarno Rajahalme > On Jan 19, 2016, at 10:15 PM, Simon Horman wrote: > > The motivation is to allow pushing single bytes in > a manner to that already used for 16, 32 and 64 bit integers. > > This will be used by a follow-up patch to allow layer 3 packet - > that

Re: [ovs-dev] - ovn-controller: Assign zone-ids consistently

2016-02-22 Thread Ben Pfaff
On Mon, Feb 08, 2016 at 10:12:50PM +, Suryanarayan Ramamurthy wrote: > Currently, conntrack zone-id is assigned to lport by ovn-controller, > but the ovn-controller does not remember what was earlier assigned > to the same lport (possibly in an earlier run across restart). > > So, after ovn-co

Re: [ovs-dev] [ovs-dev, v4] ovs-bugtool: Create OVN plugin and add output.

2016-02-22 Thread Ben Pfaff
On Fri, Feb 05, 2016 at 08:04:14PM -0800, William Tu wrote: > Create a new ovn/utilities/bugtool directory, add ovn.xml to bugtool > plugins, and add ovn-nbctl show, ovn-sbctl show, and ovn-sbctl > lflow-list. > > Signed-off-by: William Tu > --- > v4: > fix the unmatched file names at ovn.xml to

[ovs-dev] [PATCH 8/9] Debian: build openvswitch as shared libraries

2016-02-22 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- debian/openvswitch-common.install | 3 +++ debian/rules | 5 - 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/debian/openvswitch-common.install b/debian/openvswitch-common.install index 3264ea5..73c8fc9 1006

[ovs-dev] [PATCH 2/9] Move lib/geneve.h to include/openvswitch directory

2016-02-22 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/geneve.h| 63 + lib/automake.mk | 1 - lib/geneve.h| 63 - lib/pack

[ovs-dev] [PATCH 1/9] Move ofp-parse.h to include/openvswitch directory

2016-02-22 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/ofp-parse.h | 106 +++ lib/automake.mk | 1 - lib/dpctl.c | 2 +- lib/learning-switch.c | 2 +- lib

[ovs-dev] [PATCH 4/9] Move contents of lib/list.h to include/openvswitch directory

2016-02-22 Thread ben
From: Ben Warren Most of the list code is properly namespaced, so is OK to move to the global export directory. Some "lib/util.h" code had to move to the other directory as well, but I've tried to make that as small as possible Signed-off-by: Ben Warren --- include/openvswitch/list.h | 260 ++

[ovs-dev] [PATCH 9/9] Debian: add libopenvswitch-dev build target

2016-02-22 Thread ben
From: Ben Warren Add shared objects and header files Signed-off-by: Ben Warren --- debian/automake.mk| 1 + debian/control| 15 +++ debian/libopenvswitch-dev.install | 5 + 3 files changed, 21 insertions(+) create mode 100644 debian/libope

[ovs-dev] [PATCH 0/9] RFC: rework code base for third-party linking

2016-02-22 Thread ben
From: Ben Warren This patch set is a first stab at making a 'dev' distribution for OpenVswitch The goal is to provide shared libraries and header files so that third party applications can link in OVS rather than always using the command line utilities. Design: Nothing too exotic here - some he

[ovs-dev] [PATCH 3/9] Move lib/ofp-errors.h to include/openvswitch directory

2016-02-22 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- FAQ.md | 2 +- build-aux/extract-ofp-errors | 4 +- include/openvswitch/automake.mk | 1 + include/openvswitch/ofp-errors.h | 803 +++ lib/automake.mk | 5 +

[ovs-dev] [PATCH] Makefile.am: Clean flake8-check too.

2016-02-22 Thread Ben Pfaff
Found "make distcheck". Signed-off-by: Ben Pfaff --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 75ccadf..13b0a48 100644 --- a/Makefile.am +++ b/Makefile.am @@ -370,6 +370,7 @@ flake8-check: $(FLAKE8_PYFILES) flake8 $^ --ignore

[ovs-dev] [PATCH 7/9] Move lib/ofpbuf.h to include/openvswitch directory

2016-02-22 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/ofpbuf.h| 277 lib/automake.mk | 1 - lib/bfd.c | 2 +- lib/bundle.c| 2 +- li

[ovs-dev] [PATCH 6/9] Move lib/dynamic-string.h to include/openvswitch directory

2016-02-22 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- include/openvswitch/automake.mk | 1 + include/openvswitch/dynamic-string.h | 93 +++ lib/automake.mk | 1 - lib/backtrace.h | 2 +- lib/bfd.c

[ovs-dev] [PATCH 5/9] Remove lib/list.h completely

2016-02-22 Thread ben
From: Ben Warren All code is now in include/openvswitch/list.h Signed-off-by: Ben Warren --- lib/automake.mk | 1 - lib/bfd.c | 2 +- lib/dp-packet.h | 2 +- lib/dpif-netdev.c | 2 +- lib/fat-rwlock.c | 2 +- lib/fat

Re: [ovs-dev] [PATCH 1/1] vtep:Add error messages for logical router support

2016-02-22 Thread Justin Pettit
Thanks for the contribution. Can you add yourself to the AUTHORS file? Also, can I get your Signed-off-by? By giving that, you are agreeing to to the Developer's Certificate of Origin: https://github.com/openvswitch/ovs/blob/master/CONTRIBUTING.md --Justin > On Feb 22, 2016, at 2:5

Re: [ovs-dev] [PATCH V5 2/2] netdev-dpdk: add jumbo frame support

2016-02-22 Thread Flavio Leitner
On Fri, 19 Feb 2016 11:25:12 + Mark Kavanagh wrote: > Add support for Jumbo Frames to DPDK-enabled port types, > using single-segment-mbufs. > > Using this approach, the amount of memory allocated for each mbuf > to store frame data is increased to a value greater than 1518B > (typical Ether

Re: [ovs-dev] [PATCH V5 1/2] netdev-dpdk: clean up mbuf initialization

2016-02-22 Thread Flavio Leitner
On Fri, 19 Feb 2016 11:25:11 + Mark Kavanagh wrote: > Current mbuf initialization relies on magic numbers and does not > accomodate mbufs of different sizes. > > Resolve this issue by ensuring that mbufs are always aligned to a 1k > boundary (a typical DPDK NIC Rx buffer alignment). > > Sig

[ovs-dev] [PATCH 1/1] vtep:Add error messages for logical router support

2016-02-22 Thread Dennis Sam
Documents error codes that a Hardware Switch Controller can publish to the NVC to indicate errors related to the provisioning of logical routers. Acked-by: Anupam Chanda --- Vtep/vtep.xml | 22 ++ 1 file changed, 22 insertions(+) diff --git a/vtep/vtep.xml b/vtep/vtep.xml

Re: [ovs-dev] [PATCH 04/14] check-structs.at: Run for both Python 2 and 3.

2016-02-22 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 03:16:15PM -0500, Russell Bryant wrote: > On Mon, Feb 22, 2016 at 11:53 AM, Ben Pfaff wrote: > > > On Tue, Feb 02, 2016 at 05:36:46PM -0500, Russell Bryant wrote: > > > Update the tests in check-structs.at to run with both Python 2 and 3 if > > > available. The check-stru

Re: [ovs-dev] (no subject)

2016-02-22 Thread Edward J. Marto
Message from Jeffrey Skoll owner of Skoll Philanthropic Foundation for his charity donation and You have been selected as benefactor for $5Million Dollars .for more information contact Via email ally00...@yandex.com. Rainer Roh This electronic message is intended to be for the use only of th

Re: [ovs-dev] [PATCH 00/14] Finish support for Python 3.

2016-02-22 Thread Russell Bryant
On Mon, Feb 22, 2016 at 11:55 AM, Ben Pfaff wrote: > On Tue, Feb 02, 2016 at 05:36:42PM -0500, Russell Bryant wrote: > > This is this final series for Python 3 support. It refactors the test > suite to > > run Python tests against both Python 2 and 3. > > You can consider all of these to have my

Re: [ovs-dev] [PATCH 04/14] check-structs.at: Run for both Python 2 and 3.

2016-02-22 Thread Russell Bryant
On Mon, Feb 22, 2016 at 11:53 AM, Ben Pfaff wrote: > On Tue, Feb 02, 2016 at 05:36:46PM -0500, Russell Bryant wrote: > > Update the tests in check-structs.at to run with both Python 2 and 3 if > > available. The check-structs script is written in Python, though does > > not use the ovs Python li

Re: [ovs-dev] [PATCH 05/14] json.at: Run for Python 2 and 3.

2016-02-22 Thread Russell Bryant
On Mon, Feb 22, 2016 at 11:35 AM, Ben Pfaff wrote: > On Tue, Feb 02, 2016 at 05:36:47PM -0500, Russell Bryant wrote: > > Run json.at tests for both Python 2 and 3 if available. > > > > Signed-off-by: Russell Bryant > > The new comment here is nice: > > +# JSON_CHECK_POSITIVE_PY(TITLE, INPUT, OUT

[ovs-dev] [PATCH 6/7] Add fixes, improvements, refactors and cleans code

2016-02-22 Thread Lutz, Arnoldo
Added delta calculations for PMUs Added additional checks to make sure that only one update operation is performed on each key for each transaction. If several update operations are issued by the client, these are resolved and only one is applied on commit. Delayed operation validity checks until

[ovs-dev] [Partial-Update-Map-Columns 2/7] Add functionality to skeleton functions for Partial Map Update

2016-02-22 Thread Lutz, Arnoldo
Modified ovsdb_idl_row structure to include information on partial map updates, which will be used to create mutate operations on map columns when the transaction is committed. Also filled out generic (skeleton) functions to populate partial map update information on the row when a map is partial

[ovs-dev] [PATCH 4/7] Add and correct functionality of Partial Update Map Columns

2016-02-22 Thread Lutz, Arnoldo
Several memory management errors were fixed. Also, some wrong uses of pointers that produced segmentation faults were fixed. Refactored code into separate files Code for Partial Map Updates and Partial Map Update Lists was extracted into separate files, and the inner contents of structs pmu and p

[ovs-dev] [PATCH 3/7] Add code to create partial map functions in autogenerated code

2016-02-22 Thread Lutz, Arnoldo
Code inserted that autogenerates corresponding map functions to set and delete elements in map columns. Inserts description to the functions that are autogenerated. Changes on autogenerated functions Signed-off-by: arnoldo.lutz.guev...@hpe.com --- ovsdb/ovsdb-idlc.in | 69 +++

[ovs-dev] [PATCH 7/7] Adds usage help on command to test of partial update of map column

2016-02-22 Thread Lutz, Arnoldo
--- tests/test-ovsdb.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c index 0ad03bd..8c7aedd 100644 --- a/tests/test-ovsdb.c +++ b/tests/test-ovsdb.c @@ -197,7 +197,11 @@ usage(void) "connect to SERVER and dump the c

[ovs-dev] [PATCH 5/7] Add documentation on how to use partial update of map columns

2016-02-22 Thread Lutz, Arnoldo
Add file PARTIAL-UPDATE-MAP-COLUMN.md with a description on the way to use this feature. Modifies Makefile.am to include documentation in distribution list Signed-off-by: arnoldo.lutz.guev...@hpe.com --- Makefile.am | 1 + PARTIAL-UPDATE-MAP-COLUMN.md | 64 +

[ovs-dev] [Partial-Update-Map-Columns 0/7] Add Initial code for Partia-map-columns funtionality

2016-02-22 Thread Lutz, Arnoldo
In the current implementation, every time an element of either a map or set column has to be modified, the entire content of the column is sent to the server to be updated. This is not a major problem if the information contained in the column for the corresponding row is small, but there are cases

[ovs-dev] [Partial-Update-Map-Columns 1/7] Add Initial code for Partial-map-columns functionality

2016-02-22 Thread Lutz, Arnoldo
This commit adds some definitions and skeleton functions to start working. Ovsdb tests run and pass ok. Signed-off-by: arnoldo.lutz.guev...@hpe.com --- 2 0 lib/ovsdb-idl-provider.h 31 3 lib/ovsdb-idl.c 7 0 lib/ovsdb-idl.h lib/ovsdb-idl-provider.h | 2 ++ lib/o

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Do not add vhost-user ports with '/' in name.

2016-02-22 Thread Daniele Di Proietto
On 22/02/2016 08:57, "Ben Pfaff" wrote: >On Fri, Feb 05, 2016 at 11:40:11AM -0800, Ben Pfaff wrote: >> On Thu, Feb 04, 2016 at 03:42:34AM +, Daniele Di Proietto wrote: >> > >> > >> > On 03/02/2016 14:47, "Ben Pfaff" wrote: >> > >> > >On Tue, Feb 02, 2016 at 05:56:35PM -0800, Daniele Di

[ovs-dev] [PATCH] netdev-dpdk: Do not add vhost-user ports with '/' or '\' in name.

2016-02-22 Thread Daniele Di Proietto
This check prevents an obvious way for a vhost-user socket to escape the intended directory. There might be other ways to escape the directory (none comes to mind at the moment), but this is a problem that should be properly solved by mandatory access control. A similar check is done for a bridge

Re: [ovs-dev] [PATCH 2/2] ovsdb: Return NULL if prev_txn == next_txn

2016-02-22 Thread Andy Zhou
On Mon, Feb 22, 2016 at 9:28 AM, Ben Pfaff wrote: > On Mon, Feb 22, 2016 at 01:13:07AM -0800, Andy Zhou wrote: > > On Sat, Feb 20, 2016 at 8:35 AM, Liran Schour wrote: > > > > > In case that we flushed everything already, we can immeidately return > NULL. > > > > > > Signed-off-by: Liran Schour

[ovs-dev] [PATCH 3/3] m4: Rename compat.at to compat.m4.

2016-02-22 Thread Ben Pfaff
This is used by both Autoconf and Autotest, so it doesn't make sense for it to have a .at (Autotest) extension. Signed-off-by: Ben Pfaff --- m4/{compat.at => compat.m4} | 0 m4/openvswitch.m4 | 4 ++-- tests/ovs-macros.at | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

Re: [ovs-dev] [PATCH] gcc: Fix compile errors due to anonymous union initilization.

2016-02-22 Thread Ben Pfaff
On Wed, Feb 17, 2016 at 06:00:22PM -0800, William Tu wrote: > gcc 4.4.7 lets you initialize named fields, and assign to anonymous union > members, > but cannot statically initialize a named member of an anonymous union. This > causes > errors when doing make: > fproto/fail-open.c: In function ‘se

Re: [ovs-dev] [PATCH] autoconf: Fix missing AS_VAR_APPEND for version 2.63.

2016-02-22 Thread Ben Pfaff
On Wed, Feb 17, 2016 at 06:00:21PM -0800, William Tu wrote: > autoconf version 2.63 does not have AS_VAR_APPEND, resulting errors below: > tests/testsuite.tmp:3863: error: possibly undefined macro: AS_VAR_APPEND > If this token and others are legitimate, please use m4_pattern_allow. > S

[ovs-dev] [PATCH 2/3] tests: Move Autotest compatibility macros into tests directory.

2016-02-22 Thread Ben Pfaff
compat.at mixes compatibility for m4sh, which is used by Autoconf and Autotest, with compatibility for Autotest. It makes more sense to separate them. This moves the Autotest-only compatibility macros into an Autotest specific file. Signed-off-by: Ben Pfaff --- m4/compat.at| 15 ---

[ovs-dev] [PATCH 1/3] tests: Add Autoconf 2.63 compatibility support for AS_VAR_APPEND.

2016-02-22 Thread Ben Pfaff
Reported-by: William Tu Signed-off-by: Ben Pfaff --- tests/ovs-macros.at | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/ovs-macros.at b/tests/ovs-macros.at index bfd0681..aa2936e 100644 --- a/tests/ovs-macros.at +++ b/tests/ovs-macros.at @@ -153,3 +153,13 @@ on_exit () {

Re: [ovs-dev] [ovs-discuss] About QoS configuration for OpenvSwitch

2016-02-22 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 09:52:46AM +, Xiao Ma (xima2) wrote: > Could anybody tell me why the bandwidth is so unstable? Did you read the FAQ? ### Q: I configured QoS, correctly, but my measurements show that it isn't working as well as I expect. A: With the Linux kernel, the Open vSwitch i

Re: [ovs-dev] [PATCH] types: Fix defined but not used warning.

2016-02-22 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 11:19:07AM +0200, Panu Matilainen wrote: > On 02/19/2016 11:35 PM, William Tu wrote: > >warning: ‘OVS_BE128_MAX’ defined but not used [-Wunused-const-variable] > >Found using CentOS 6.6 with gcc 6.6.0. > > > >Signed-off-by: William Tu > > Just FWIW, this particular gcc 6 b

Re: [ovs-dev] [PATCH 2/2] ovsdb: Return NULL if prev_txn == next_txn

2016-02-22 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 01:13:07AM -0800, Andy Zhou wrote: > On Sat, Feb 20, 2016 at 8:35 AM, Liran Schour wrote: > > > In case that we flushed everything already, we can immeidately return NULL. > > > > Signed-off-by: Liran Schour > > --- > > ovsdb/monitor.c | 4 > > 1 file changed, 4 ins

[ovs-dev] [PATCH v2] lib/ovs-thread: Add Transactional Memory (TM) support.

2016-02-22 Thread William Tu
v1->v2 - Fix a bug at UNLOCK_ELISION - Add checking if glibc version >= 2.21 (OVS_CHECK_GLIBC_TSX) - Add checking of whether cpu has TSX support (OVS_CHECK_RTM) - Enable LOCK_ELISION only when CPU has TSX and glibc doesn't (if glibc version >= 2.21, then using phtread_mutex has lock elision) - Ad

Re: [ovs-dev] [PATCH 2/3] netdev-dpdk: Do not add vhost-user ports with '/' in name.

2016-02-22 Thread Ben Pfaff
On Fri, Feb 05, 2016 at 11:40:11AM -0800, Ben Pfaff wrote: > On Thu, Feb 04, 2016 at 03:42:34AM +, Daniele Di Proietto wrote: > > > > > > On 03/02/2016 14:47, "Ben Pfaff" wrote: > > > > >On Tue, Feb 02, 2016 at 05:56:35PM -0800, Daniele Di Proietto wrote: > > >> This check prevents an obvio

Re: [ovs-dev] [PATCH 00/14] Finish support for Python 3.

2016-02-22 Thread Ben Pfaff
On Tue, Feb 02, 2016 at 05:36:42PM -0500, Russell Bryant wrote: > This is this final series for Python 3 support. It refactors the test suite > to > run Python tests against both Python 2 and 3. You can consider all of these to have my ack: Acked-by: Ben Pfaff except where I specifically follow

Re: [ovs-dev] [PATCH 04/14] check-structs.at: Run for both Python 2 and 3.

2016-02-22 Thread Ben Pfaff
On Tue, Feb 02, 2016 at 05:36:46PM -0500, Russell Bryant wrote: > Update the tests in check-structs.at to run with both Python 2 and 3 if > available. The check-structs script is written in Python, though does > not use the ovs Python library. The script did require fixes in a > previous commit t

Re: [ovs-dev] [PATCH] Installation steps correction for DPDK 2.2.

2016-02-22 Thread Flavio Leitner
Adding Daniele just in case. fbl On Mon, 22 Feb 2016 10:13:10 + "Weglicki, MichalX" wrote: > Hello, > > Just gentle reminder, is this patch fine? Or I'm supposed to correct > something? > > As Flavio mentioned it is important change for 2.5 branch. > > Br, > Michal. > > -Orig

Re: [ovs-dev] [PATCH 13/14] vlog.at: Run tests for Python 2 and 3.

2016-02-22 Thread Ben Pfaff
On Tue, Feb 02, 2016 at 05:36:55PM -0500, Russell Bryant wrote: > Update these Python tests to run with both Python 2 and 3. > > Signed-off-by: Russell Bryant Also needs a rebase but I'm sure it's fine: Acked-by: Ben Pfaff ___ dev mailing list dev@ope

Re: [ovs-dev] [PATCH 08/14] library.at: Run tests for Python 2 and 3.

2016-02-22 Thread Ben Pfaff
On Tue, Feb 02, 2016 at 05:36:50PM -0500, Russell Bryant wrote: > Update Python tests to run for both Python 2 and 3. > > Signed-off-by: Russell Bryant This needs a rebase due to conflicts, but I'm sure it'll be fine after that, so: Acked-by: Ben Pfaff __

Re: [ovs-dev] [PATCH 05/14] json.at: Run for Python 2 and 3.

2016-02-22 Thread Ben Pfaff
On Tue, Feb 02, 2016 at 05:36:47PM -0500, Russell Bryant wrote: > Run json.at tests for both Python 2 and 3 if available. > > Signed-off-by: Russell Bryant The new comment here is nice: > +# JSON_CHECK_POSITIVE_PY(TITLE, INPUT, OUTPUT, TEST-JSON-ARGS, > +#PYTHON-CHCEK, PY

Re: [ovs-dev] [PATCH] INSTALL.md: Fix shell command line formatting.

2016-02-22 Thread Ben Pfaff
On Fri, Jan 29, 2016 at 03:18:14PM -0800, Jarno Rajahalme wrote: > Some shell command lines were quited inconsistently from others. > > Signed-off-by: Jarno Rajahalme Since this was acked and had been sitting in patchwork for a while, I applied it myself.

Re: [ovs-dev] [PATCH v2 0/6] Add color output to `ovs-ofctl dump-flows` command

2016-02-22 Thread Ben Pfaff
On Mon, Feb 22, 2016 at 05:04:02PM +0100, Quentin Monnet wrote: > I have no more updates on my color patches series for now, since I prefer > to wait for the proposed implementation to be validated before I extend it. > Would my current approach make sense for inclusion in OVS codebase? I'm trying

Re: [ovs-dev] [PATCH RFC v3] netdev-dpdk: vhost-user: Fix sending packets to queues not enabled by guest.

2016-02-22 Thread Flavio Leitner
Hi Ilya, Few comments inline: On Sat, 20 Feb 2016 14:28:52 +0300 Ilya Maximets wrote: > Currently virtio driver in guest operating system have to be configured > to use exactly same number of queues. If number of queues will be less, > some packets will get stuck in queues unused by guest an

Re: [ovs-dev] [PATCH v2 0/6] Add color output to `ovs-ofctl dump-flows` command

2016-02-22 Thread Quentin Monnet
2016-02-15 16:19 GMT+01:00 Quentin Monnet : > Proposal: add an option to ovs-ofctl utility so as to obtain colorized > output > in tty, for easier reading. Currently, only the dump-flows command supports > colors. > > A new `--color` option has been added to ovs-ofctl so as to indicate > whether >

[ovs-dev] Our classic ED Pack is authorised

2016-02-22 Thread Benito
96 Fine quality pills on discounts p{margin:10px 0;padding:0;} table{border-collapse:collapse;} h1,h2,h3,h4,h5,h6{display:block;margin:0;padding:0;} img,a img{border:0;height:auto;outline:none;text-decoration:none;} body,#bodyTable,#bodyCell{height:100%;margin:0;padding:0;width:100%;

Re: [ovs-dev] [PATCH v2 1/5] datapath-windows: Added recirculation support.

2016-02-22 Thread Sorin Vinturis
Hi Sairam, I have added a v3 version of the recirculation patch, in which the deferred action queue access is synchronized. Please have a look and test it with your contrack patch. If you encounter any issue, please create a dump and sent it to me to have a look at it. Thanks, Sorin -Origi

[ovs-dev] [PATCH v3 6/6] datapath-windows: Sample action support.

2016-02-22 Thread Sorin Vinturis
This patch adds support for sampling to the OVS extension. Signed-off-by: Sorin Vinturis --- v3: No previous version. --- datapath-windows/automake.mk | 1 + datapath-windows/ovsext/Actions.c | 183 +++-- datapath-windows/ovsext/Random.h | 49 +

[ovs-dev] [PATCH v3 5/6] datapath-windows: Updated FAQ regarding Hyper-V recirculation.

2016-02-22 Thread Sorin Vinturis
Updated FAQ document to reflect recirculation support for Hyper-V. Signed-off-by: Sorin Vinturis --- v3: No changes from the previous version. --- FAQ.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FAQ.md b/FAQ.md index 8bd7ab9..062f164 100644 --- a/FAQ.md +++ b/FAQ.md @@

[ovs-dev] [PATCH v3 4/6] datapath-windows: Extract flow metadata in execute cmd handler.

2016-02-22 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis --- v3: No changes from the previous version. --- datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/Flow.c | 17 + datapath-windows/ovsext/Flow.h | 2 ++ datapath-windows/ovsext/User.c | 7 +++ 4 files change

[ovs-dev] [PATCH v3 3/6] datapath-windows: Support for OVS_ACTION_ATTR_HASH attribute

2016-02-22 Thread Sorin Vinturis
Signed-off-by: Sorin Vinturis --- v3: No changes from the previous version. --- datapath-windows/ovsext/Actions.c| 32 datapath-windows/ovsext/DpInternal.h | 1 + datapath-windows/ovsext/Flow.c | 13 + 3 files changed, 46 insertions(+) diff

[ovs-dev] [PATCH v3 2/6] datapath-windows: Allow recirculation feature probe.

2016-02-22 Thread Sorin Vinturis
Recirculation feature probe messages sent from userspace are suppressed by the OVS extension. This patch changes the current behaviour to allow feature probe for recirculation. Signed-off-by: Sorin Vinturis --- v3: No changes from the previous version. --- datapath-windows/ovsext/Flow.c | 9 +++

[ovs-dev] [PATCH v3 1/6] datapath-windows: Added recirculation support.

2016-02-22 Thread Sorin Vinturis
Recirculation support for the OVS extension. Tested using PING and iperf with Driver Verifier enabled. Signed-off-by: Sorin Vinturis Co-authored-by: Alin Gabriel Serdean Reported-by: Sorin Vinturis Reported-at: https://github.com/openvswitch/ovs-issues/issues/104 --- v2: Initialize flow key be

[ovs-dev] [PATCH v3 0/6] datapath-windows: Recirculation support

2016-02-22 Thread Sorin Vinturis
This patch series adds support for recirculation to the OVS extension. Since the sample action patch is ready, and is dependent on recirculation, I have added it to this series. Sorin Vinturis (6): [PATCH v3 1/6] datapath-windows: Added recirculation support. [PATCH v3 2/6] datapath-windows:

[ovs-dev] MEET your day with wicked Winnie Bumgardner

2016-02-22 Thread Winnie N .
Groovy my sexy catI found yr photos in instagram.. you are pretty boy.i want to ride your big c#ck all night!! i'm 32/f with natural b00bs and a perfect a$$!! want to be my f@ckbuddy? ;)the screenname - Winnie82 .my page is over there: http://mdacelyk.DatingProperty.ruAre you alone, Dev? Txt me

[ovs-dev] [PATCHv2 2/2] ovn: Add l3 port security for IPv4 and IPv6

2016-02-22 Thread Numan Siddique
For every port security defined for a logical port, add following lflows in "ls_in_port_sec" and "ls_out_port_sec" stage - A priority 90 flow to allow ipv4 traffic for known ip addresses and (broadcast ip - for ingress, mainly for dhcp) - A priority 80 flow to drop all ipv4 traffic. -

[ovs-dev] [PATCHv2 1/2] ovn-northd: Allow lport 'addresses' to store multiple ips in each set

2016-02-22 Thread Numan Siddique
If a logical port has two ipv4 addresses and one ipv6 address it will be stored as ["MAC IPv41 IPv42 IPv61"] instead of ["MAC IPv41", "MAC IPv42", "MAC IPv61"]. Signed-off-by: Numan Siddique --- lib/packets.c | 126 +++-- lib/packets.h | 1

Re: [ovs-dev] [PATCH] Installation steps correction for DPDK 2.2.

2016-02-22 Thread Weglicki, MichalX
Hello, Just gentle reminder, is this patch fine? Or I'm supposed to correct something? As Flavio mentioned it is important change for 2.5 branch. Br, Michal. -Original Message- From: Flavio Leitner [mailto:f...@sysclose.org] Sent: Friday, February 12, 2016 1:18 AM To: Weglicki, Mi

Re: [ovs-dev] About QoS configuration for OpenvSwitch

2016-02-22 Thread Xiao Ma (xima2)
Hi, Could anybody tell me why the bandwidth is so unstable? Thanks! 在 2016年2月15日,下午8:18,Xiao Ma (xima2) mailto:xi...@cisco.com>> 写道: Hi, All I want to use the QoS feature of openvswitch for networks in openstack cloud environment ( neutron in Vlan Mode). I created four virtual machines, t

Re: [ovs-dev] : ovs-appctl dump and flush command for userspace conntrack

2016-02-22 Thread sourabh.bansal
Hi Joe, I rechecked and ovs-appctl dpctl/dump-conntrack command works fine for me. Actually I got confused with ovs-dpctl dump-conntrack command and thought that userspace dump conntrack is not available. Thanks for pointing it out. Withdrawing the patch. -Original Message- From: Sou

Re: [ovs-dev] [PATCH] types: Fix defined but not used warning.

2016-02-22 Thread Panu Matilainen
On 02/19/2016 11:35 PM, William Tu wrote: warning: ‘OVS_BE128_MAX’ defined but not used [-Wunused-const-variable] Found using CentOS 6.6 with gcc 6.6.0. Signed-off-by: William Tu Just FWIW, this particular gcc 6 behavior is still under debate: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=2890

  1   2   >