Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ryan Moats
Ben Pfaff wrote on 07/02/2016 11:31:28 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: bscha...@redhat.com, dev@openvswitch.org > Date: 07/02/2016 11:31 PM > Subject: Re: [ovs-dev] [PATCH v6 1/2] Add address set support. > > On Sat, Jul 02, 2016 at

[ovs-dev] partial occupation

2016-07-02 Thread Allan Massey
Greetings, After the review of your resume, we would like to let you know that we've a newly opened vacancy that will be perfectly suitable for you, based on your experience and our requirements. Key requirements & benefits: - International environment in a famous multinational corporation;

Re: [ovs-dev] [PATCH 5/7] ovn-nb: Add Load-balancer table to schema.

2016-07-02 Thread Ben Pfaff
On Wed, Jun 29, 2016 at 01:17:09AM -0700, Gurucharan Shetty wrote: > Also add the ability to run database commands on the > new schema using ovn-nbctl. > > Signed-off-by: Gurucharan Shetty I agree with Zong's suggestion to add examples. It is a little unusual, for OVS, to add

Re: [ovs-dev] [PATCH 4/7] ovn-northd: Introduce stateful table.

2016-07-02 Thread Ben Pfaff
On Wed, Jun 29, 2016 at 01:17:08AM -0700, Gurucharan Shetty wrote: > Currently, the only use of stateful services in conntrack is > OVN ACLs. In table ACL, we commit the packet to conntrack > via ct_commit action. > > As we introduce more stateful services, the ACL feature will > have to share

Re: [ovs-dev] [PATCH 3/7] ovn-northd: Introduce pre-stateful table.

2016-07-02 Thread Ben Pfaff
On Wed, Jun 29, 2016 at 01:17:07AM -0700, Gurucharan Shetty wrote: > Currently, the only use of stateful services in conntrack is > OVN ACLs. In table pre-ACL, we send the packet to conntrack > to track it (to get its status) and to defrag via the ct_next > action. > > As we introduce more

Re: [ovs-dev] [PATCH 2/7] ovn-northd.8: Update documentation.

2016-07-02 Thread Ben Pfaff
On Wed, Jun 29, 2016 at 01:17:06AM -0700, Gurucharan Shetty wrote: > When new tables are introduced, it gets a little harder to > track all the different table numbers used in the documentation. > This commit changes some table numbers to names to make it a little > easier to update documentation

Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 11:19:03PM -0500, Ryan Moats wrote: > Ben Pfaff wrote on 07/02/2016 11:12:00 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: bscha...@redhat.com, dev@openvswitch.org > > Date: 07/02/2016 11:14 PM > > Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH 7/7] ovsdb: Fix dead assignment reported by clang.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 10:02:28PM -0700, William Tu wrote: > Clang reports variable 'error' never been used. Fix by > returning error when table_update->type != JSON_OBJECT. > > Signed-off-by: William Tu Thanks, applied, except that I changed this to simplify the code

Re: [ovs-dev] [PATCH 6/7] packets: Fix null pointer dereference reported by clang.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 10:02:27PM -0700, William Tu wrote: > In packet_set_tcp_port(), clang reports passing null pointer of >tcp_src > when calling packet_set_port(>tcp_src, src, >tcp_csum); > > Signed-off-by: William Tu I don't see how this can happen. If it can, it

Re: [ovs-dev] [PATCH 5/7] ovn-nbctl: Fix double memory free reported by clang.

2016-07-02 Thread Ben Pfaff
On Thu, Jun 30, 2016 at 09:37:29PM -0700, Darrell Ball wrote: > On Thu, Jun 30, 2016 at 2:31 PM, William Tu wrote: > > > Hi Darrell, > > > > Thanks, I think we should print the error in VLOG_WARN and free it . > > > > Regards, > > William > > > > Thanks > I only commented on

Re: [ovs-dev] [PATCH 4/7] ovn-controller-vtep: Fix dead increment reported by clang.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 10:02:25PM -0700, William Tu wrote: > Signed-off-by: William Tu Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 3/7] netlink: Fix passing null pointer reported by clang.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 10:02:24PM -0700, William Tu wrote: > In nl_msg_push_flag(), the 3rd NULL parameter causing 'memcpy()' > with NULL source pointer in nl_msg_push_unspec(). > > Signed-off-by: William Tu Applied, thanks! ___

Re: [ovs-dev] [PATCH 2/7] clang: Fix dead assignment.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 10:02:23PM -0700, William Tu wrote: > Signed-off-by: William Tu Applied, thanks! ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ryan Moats
Ben Pfaff wrote on 07/02/2016 11:12:00 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: bscha...@redhat.com, dev@openvswitch.org > Date: 07/02/2016 11:14 PM > Subject: Re: [ovs-dev] [PATCH v6 1/2] Add address set support. > > On Sat, Jul 02, 2016 at

Re: [ovs-dev] [PATCH 1/7] bridge: Fix possible null pointer dereference reported by clang.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 10:02:22PM -0700, William Tu wrote: > Signed-off-by: William Tu > --- > vswitchd/bridge.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index 8ebfc66..7244e11 100644 > ---

[ovs-dev] [PATCH] bridge: Add assertion to document an invariant in find_local_hw_addr().

2016-07-02 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- vswitchd/bridge.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 8ebfc66..805b784 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -1997,6 +1997,9 @@ find_local_hw_addr(const struct bridge

Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 10:41:18PM -0500, Ryan Moats wrote: > Ryan Moats/Omaha/IBM wrote on 07/02/2016 10:37:24 PM: > > > From: Ryan Moats/Omaha/IBM > > To: Ben Pfaff > > Cc: bscha...@redhat.com, dev@openvswitch.org > > Date: 07/02/2016 10:37 PM > > Subject: Re: [ovs-dev] [PATCH v6

Re: [ovs-dev] [PATCH V12] Function tracer to trace all function calls

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 07:02:06PM -0700, ngh...@us.ibm.com wrote: > From: Nirapada Ghosh > > In some circumstances, we might need to figure out where in > code, the CPU time is being spent most, so as to pinpoint > the bottleneck and thereby resolve it with proper changes. >

Re: [ovs-dev] [PATCH v3]: ofproto: Add relaxed group_mod command ADD_OR_MOD

2016-07-02 Thread Ben Pfaff
On Wed, Jun 29, 2016 at 12:29:25AM +0200, Jan Scheurich wrote: > This patch adds support for a new Group Mod command OFPGC_ADD_OR_MOD to > OVS for all OpenFlow versions that support groups (OF11 and higher). > The new ADD_OR_MOD creates a group that does not yet exist (like ADD) > and modifies an

Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ryan Moats
"dev" wrote on 07/02/2016 10:41:18 PM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Ben Pfaff > Cc: dev@openvswitch.org > Date: 07/02/2016 10:41 PM > Subject: Re: [ovs-dev] [PATCH v6 1/2] Add address set support. > Sent by: "dev"

Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ryan Moats
Ryan Moats/Omaha/IBM wrote on 07/02/2016 10:37:24 PM: > From: Ryan Moats/Omaha/IBM > To: Ben Pfaff > Cc: bscha...@redhat.com, dev@openvswitch.org > Date: 07/02/2016 10:37 PM > Subject: Re: [ovs-dev] [PATCH v6 1/2] Add address set support. > > "dev"

Re: [ovs-dev] [PATCH] ovsdb: Fix OVSDB disconnect replication bug

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 09:58:59PM +, Cabrera Vega, Mario Alberto wrote: > Currently disconnecting from the replicator server means closing the jsonrpc > connection and destroying the monitored table names and blacklisted table > names. > > This patch makes a distinction between disconnecting

Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ryan Moats
"dev" wrote on 07/02/2016 10:30:29 PM: > From: Ben Pfaff > To: bscha...@redhat.com > Cc: dev@openvswitch.org > Date: 07/02/2016 10:30 PM > Subject: Re: [ovs-dev] [PATCH v6 1/2] Add address set support. > Sent by: "dev" >

Re: [ovs-dev] [PATCH v6 2/2] ovn: Add address_set() support for ACLs.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 02:20:41PM +0530, bscha...@redhat.com wrote: > From: Russell Bryant > > This feature was originally proposed here: > > http://openvswitch.org/pipermail/dev/2016-March/067440.html > > A common use case for OVN ACLs involves needing to match a set of IP

Re: [ovs-dev] [PATCH v6 1/2] Add address set support.

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 02:20:40PM +0530, bscha...@redhat.com wrote: > From: Russel Bryant This misspells Russell's name (I fixed it). > Update the OVN expression parser to support address sets. Previously, > you could have a set of IP or MAC addresses in this form: > >

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-02 Thread Xiao Liang
On Sat, Jul 2, 2016 at 10:17 PM, Xiao Liang wrote: > Hi Tom, > > Thanks for your test and comments! Please see inline. > > On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert > wrote: >> Xiao, >> >> Thanks. I think this is nice work and I think it

[ovs-dev] [PATCH v3 2/4] tests: Add tests for QinQ VLAN handling

2016-07-02 Thread Xiao Liang
Add dot1q-tunnel ports and ingress packet cases, in ofproto-dpif.at VLAN handling. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 110 +- 1 file changed, 64 insertions(+), 46 deletions(-) diff --git

[ovs-dev] [PATCH v3 3/4] tests: Adjust VLAN+MPLS handling cases for QinQ

2016-07-02 Thread Xiao Liang
When QinQ is supported, ingress VLAN are kept after push_vlan actions, so we should expect two VLAN headers. Signed-off-by: Xiao Liang --- tests/ofproto-dpif.at | 128 +++--- 1 file changed, 70 insertions(+), 58 deletions(-)

[ovs-dev] [PATCH v3 4/4] tests: Set default max_vlan_headers

2016-07-02 Thread Xiao Liang
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX Signed-off-by: Xiao Liang --- lib/dpif-netdev.c | 1 + tests/test-odp.c | 1 + 2 files changed, 2 insertions(+) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index cbf7b97..a60c88a 100644 ---

[ovs-dev] [PATCH v3 0/4] Add support for 802.1ad (QinQ tunneling)

2016-07-02 Thread Xiao Liang
These patches enable tpid 0x88a8, multiple VLAN headers, and add new vlan_mode "dot1q-tunnel". See commit message of patch1 for details. v2: Add VLAN handling test cases for dot1q-tunnel vlan_mode. Adjust VLAN+MPLS test cases for multi VLAN. v3: Set default max_vlan_headers of netdev and

Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis support

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 10:02:37PM +, Bodireddy, Bhanuprakash wrote: > > >-Original Message- > >From: Ben Pfaff [mailto:b...@ovn.org] > >Sent: Saturday, July 2, 2016 9:31 PM > >To: Bodireddy, Bhanuprakash > >Cc: dev@openvswitch.org > >Subject: Re:

Re: [ovs-dev] [PATCH 2/2] ovn: Add a case of policy based routing.

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 03:45:23PM -0700, Guru Shetty wrote: > On 1 July 2016 at 14:36, Ben Pfaff wrote: > > > On Fri, Jul 01, 2016 at 03:23:39AM -0700, Gurucharan Shetty wrote: > > > OVN currently supports multiple gateway routers (residing on > > > different chassis) connected to

Re: [ovs-dev] [PATCH 2/2] ovn: Add a case of policy based routing.

2016-07-02 Thread Guru Shetty
On 1 July 2016 at 14:36, Ben Pfaff wrote: > On Fri, Jul 01, 2016 at 03:23:39AM -0700, Gurucharan Shetty wrote: > > OVN currently supports multiple gateway routers (residing on > > different chassis) connected to the same logical topology. > > > > When external traffic enters the

Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis support

2016-07-02 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Ben Pfaff [mailto:b...@ovn.org] >Sent: Saturday, July 2, 2016 9:31 PM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis >support > >On Sat, Jul 02,

[ovs-dev] Wanted regional manageres

2016-07-02 Thread Alvaro Simmons
Hello, After the examination of your CV, we would like to let you know that we have opened a new vacancy that will be a perfect match, based on your experience and our requirements. Key requirements & benefits: - International environment in a big multinational company; - Opportunity to work

Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis support

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 08:14:02PM +, Bodireddy, Bhanuprakash wrote: > >-Original Message- > >From: Ben Pfaff [mailto:b...@ovn.org] > >Sent: Saturday, July 2, 2016 6:14 PM > >To: Bodireddy, Bhanuprakash > >Cc: dev@openvswitch.org > >Subject: Re:

Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-02 Thread Lance Richardson
- Original Message - > From: "Lance Richardson" > To: "Ben Pfaff" > Cc: dev@openvswitch.org > Sent: Saturday, July 2, 2016 4:11:14 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only > when transaction is possible > > > >

Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis support

2016-07-02 Thread Bodireddy, Bhanuprakash
>-Original Message- >From: Ben Pfaff [mailto:b...@ovn.org] >Sent: Saturday, July 2, 2016 6:14 PM >To: Bodireddy, Bhanuprakash >Cc: dev@openvswitch.org >Subject: Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis >support > >On Tue, Jun 28,

Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-02 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Saturday, July 2, 2016 3:23:35 PM > Subject: Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only > when transaction is possible > > On

Re: [ovs-dev] [PATCH] ovsdb: Weak references performance fix

2016-07-02 Thread Ben Pfaff
On Mon, Jun 27, 2016 at 08:07:02PM +, Rodriguez Betancourt, Esteban wrote: > Prevents the cloning of rows with outgoing or > incoming weak references when those rows aren't > being modified. > > It improves the OVSDB Server performance when > many rows with weak references are involved > in a

Re: [ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 01:56:21PM -0400, Lance Richardson wrote: > As currently implemented, binding_run() normally updates the set of > locally owned logical ports on each call. When changes to the > membership of this set are detected (i.e. when locally bound > logical ports are added or

Re: [ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, 3 lports/LS, 1 LR" test

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 03:01:03PM -0400, Lance Richardson wrote: > - Original Message - > > From: "Ben Pfaff" > > To: "Lance Richardson" > > Cc: dev@openvswitch.org > > Sent: Saturday, July 2, 2016 2:45:23 PM > > Subject: Re: [ovs-dev] [PATCH] ovn:

Re: [ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, 3 lports/LS, 1 LR" test

2016-07-02 Thread Lance Richardson
- Original Message - > From: "Ben Pfaff" > To: "Lance Richardson" > Cc: dev@openvswitch.org > Sent: Saturday, July 2, 2016 2:45:23 PM > Subject: Re: [ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, > 3 lports/LS, 1 LR" test > > On Sat,

Re: [ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, 3 lports/LS, 1 LR" test

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 02:14:18PM -0400, Lance Richardson wrote: > Gracefully exit all daemons in this test case. > > Signed-off-by: Lance Richardson It would probably be better to come up with a systematic way to do this automatically. I applied this anyway. Thanks,

[ovs-dev] [PATCH v8 1/2] flow: New function is_nd().

2016-07-02 Thread Ben Pfaff
This simplifies a few pieces of code and will acquire another user in an upcoming commit. Signed-off-by: Ben Pfaff --- This has already been applied, but I'm posting it here for everyone's information. lib/flow.h| 21 + lib/meta-flow.c | 13

[ovs-dev] [PATCH v8 2/2] ovn: Add 'na' action and lflow for ND

2016-07-02 Thread Ben Pfaff
From: Zong Kai LI This patch tries to support ND versus ARP for OVN. It adds a new OVN action 'na' in ovn-controller side, and modify lflows for 'na' action and relevant packets in ovn-northd. First, for ovn-northd, it will generate lflows per each lport with its IPv6

Re: [ovs-dev] [PATCH] [PATCH, v7] ovn: Add 'na' action and lflow for ND

2016-07-02 Thread Ben Pfaff
On Mon, Jun 27, 2016 at 02:54:52PM +0800, Zong Kai LI wrote: > This patch tries to support ND versus ARP for OVN. > > It adds a new OVN action 'na' in ovn-controller side, and modify lflows > for 'na' action and relevant packets in ovn-northd. > > First, for ovn-northd, it will generate lflows

[ovs-dev] [PATCH] ovn: gracefully exit daemons in "3 HVs, 3 LS, 3 lports/LS, 1 LR" test

2016-07-02 Thread Lance Richardson
Gracefully exit all daemons in this test case. Signed-off-by: Lance Richardson --- tests/ovn.at | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/tests/ovn.at b/tests/ovn.at index 37888bf..b8a9bf5 100644 --- a/tests/ovn.at +++

[ovs-dev] [PATCH] ovn-controller: process lport bindings only when transaction is possible

2016-07-02 Thread Lance Richardson
As currently implemented, binding_run() normally updates the set of locally owned logical ports on each call. When changes to the membership of this set are detected (i.e. when locally bound logical ports are added or deleted), additional processing to update the sb database with lport binding is

[ovs-dev] [PATCH v20 7/7] Add incremental processing to lflow_run and physical_run

2016-07-02 Thread Ryan Moats
This code changes to allow incremental processing of the logical flow and physical binding tables whenver possible. Note: flows created by physical_run for multicast_groups are *NOT* handled incrementally due to to be solved issues with GWs and local routers. Signed-off-by: Ryan Moats

[ovs-dev] [PATCH v20 5/7] Refactor multicast group processing in physical.c

2016-07-02 Thread Ryan Moats
Extract block from SBREC_MULTICAST_GROUP_FOR_EACH block in physical_run to helper method so that it can be reused when doing incremental processing. The is_true parameter is added for a later patch set. Signed-off-by: Ryan Moats --- ovn/controller/physical.c | 233

[ovs-dev] [PATCH v20 4/7] Refactor port binding processing in physical.c

2016-07-02 Thread Ryan Moats
iExtract block from SBREC_PORT_BINDING_FOR_EACH block in physical_run to helper method so that it can be reused when doing incremental processing. Side effects: - localvif_to_oport and tunnels are now static file scoped. - the is_new parameter is added for use in a later patch set.

[ovs-dev] [PATCH v20 6/7] Refactor neighbor flows in lflow.c

2016-07-02 Thread Ryan Moats
Extract block within SBREC_MAC_BINDING_FOR_EACH loop within add_neighbor_flows to helper method so it can be reused when doing incremental processing. This is_new parameter is added for use in a later patch set. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 68

[ovs-dev] [PATCH v20 3/7] Refactor lflow.c

2016-07-02 Thread Ryan Moats
Refactor code block inside of SBREC_LOGICAL_FLOW_FOR_EACH loop in add_logical_flow so that this can be reused when incremental processing is added. The is_new parameter is added for use in a later patch set. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 310

[ovs-dev] [PATCH v20 2/7] Change tracking structures to use struct uuids

2016-07-02 Thread Ryan Moats
In encaps.c, binding.c, and lport.c incremental processing is aided by tracking entries by their ovsdb row uuids. The original patch sets used pointers, which might lead to errors if the ovsdb row uuid memory is released. So, use actual structures to hold the values instead. Signed-off-by: Ryan

[ovs-dev] [PATCH v20 0/7] Add incremental processing.

2016-07-02 Thread Ryan Moats
This patch set has the residual changes that didn't merge from v18. v19->v20: As needed rebases. Added check logic in encaps.c to avoid segfaulting during scale testing. v18->v19: Addressed review comments on ovn flow tables patch. As needed rebases of other patches. Ryan Moats (7):

[ovs-dev] [PATCH v20 1/7] Persist ovn flow tables

2016-07-02 Thread Ryan Moats
Ensure that ovn flow tables are persisted so that changes to them chan be applied incrementally - this is a prereq for making lflow_run and physical_run incremental. Signed-off-by: Ryan Moats --- ovn/controller/lflow.c | 26 ++-- ovn/controller/lflow.h |

Re: [ovs-dev] [PATCH] ovs-bugtool: Port to python3.

2016-07-02 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 02:15:21PM -0700, Joe Stringer wrote: > Fix python2-specific code in ovs-bugtool: > * python2 long() is the same as python2 int() and python3 int(). Convert > the long() to int(). > * raw_input() was renamed to input(). Use python-six's input() on python2. > * Drop lambda

Re: [ovs-dev] [PATCH] ovn-sbctl: Change lport-(un)bind to lsp-(un)bind.

2016-07-02 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 04:37:58PM -0400, Russell Bryant wrote: > A previous commit changed the command names in ovn-nbctl from lport-* to > lsp-*. Change lport-bind and lport-unbind in ovn-sbctl to match. > > Signed-off-by: Russell Bryant With this applied I still see one use

Re: [ovs-dev] [PATCH] [OVN-northd] Rename nbs/nbr to nbsp/nbrp

2016-07-02 Thread Ben Pfaff
On Fri, Jun 24, 2016 at 12:39:54PM -0400, Hui Kang wrote: > These variables indicate ports in nb switches or routers. > > Signed-off-by: Hui Kang Justin, do you want to review this? You like naming. ___ dev mailing list

Re: [ovs-dev] [PATCH] update .gitignore files for debian build artifacts

2016-07-02 Thread Ben Pfaff
On Wed, Jun 22, 2016 at 01:04:23PM -0700, Aaron Rosen wrote: > After running: `fakeroot debian/rules binary` > > These files are left uncommitted to the source tree and should be ignored. > > Signed-off-by: Aaron Rosen > --- > .gitignore| 1 + > debian/.gitignore

Re: [ovs-dev] [PATCH v3] Travis: Added python plugins flake8 and hacking.

2016-07-02 Thread Ben Pfaff
On Wed, Jun 22, 2016 at 03:48:15PM -0400, William Townsend wrote: > Travis builds will now automatically run flake8 and hacking checks against > Python code and generate warnings. > > Signed-off-by: William Townsend Applied, thanks!

Re: [ovs-dev] [PATCH v2] Makefile.am: Add clang static analysis support

2016-07-02 Thread Ben Pfaff
On Tue, Jun 28, 2016 at 05:09:13PM +0100, Bhanuprakash Bodireddy wrote: > Clang Static Analyzer is a source code analysis tool to find bugs. This > patch adds make target to trigger static analysis using below commands. > > ./boot.sh > ./configure --with-dpdk(in case of DPDK datapath) > make

[ovs-dev] ovs+dpdk hang? (was: Re: c)

2016-07-02 Thread Ben Pfaff
The logs show that ovs-vswitchd failing to log anything after it receives the initial configuration from the database. This is probably a bug in the DPDK portion of OVS. OVS-DPDK folks, have you noticed anything like this before? Can you take over the investigation? Thanks, Ben. On Sat, Jul

Re: [ovs-dev] UDP loss rate in OVS 2.5

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 09:00:44AM -0600, Amru OM wrote: > I have installed the latest OVS 2.5 in each physical server of my testbed. > The physical servers running CentOS Linux release 7.2.1511 as the host > operating system. Also, each host has one VM running via KVM. The VM in > each server is

Re: [ovs-dev] The QoS feature minimum guaranteed bandwidth of OpenvSwitch not work

2016-07-02 Thread Ben Pfaff
On Sat, Jul 02, 2016 at 03:17:21PM +, Xiao Ma (xima2) wrote: > Hi , Ben > > Thanks for your reply. > > I configured the bond0 using linux bond then the result is not good for > minimum guaranteed bandwidth. > But if I use ovs-vsctl add-bond to configure the bond0 interface, the result > is

Re: [ovs-dev] The QoS feature minimum guaranteed bandwidth of OpenvSwitch not work

2016-07-02 Thread Xiao Ma (xima2)
Hi , Ben Thanks for your reply. I configured the bond0 using linux bond then the result is not good for minimum guaranteed bandwidth. But if I use ovs-vsctl add-bond to configure the bond0 interface, the result is good. If I use linux bond with linux tc, the tc works well also. However,

[ovs-dev] UDP loss rate in OVS 2.5

2016-07-02 Thread Amru OM
Greetings, I have installed the latest OVS 2.5 in each physical server of my testbed. The physical servers running CentOS Linux release 7.2.1511 as the host operating system. Also, each host has one VM running via KVM. The VM in each server is connected to OVS through vNIC (e.g., tap0). Here

Re: [ovs-dev] [RFC PATCH v2 1/3] Add support for 802.1ad (QinQ tunneling)

2016-07-02 Thread Xiao Liang
Hi Tom, Thanks for your test and comments! Please see inline. On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert wrote: > Xiao, > > Thanks. I think this is nice work and I think it advances the ball. > > It needs to be rebased to latest. I got some fuzz applying the

[ovs-dev] We offer new vacancy

2016-07-02 Thread Conrad Ruiz
Good morning, After the evaluation of your application, we would like to let you know that we have opened a new position that will be a perfect match, based on your experience and our requirements. Highlights: - Dynamic environment in a famous multinational corporation; - Opportunity to work

[ovs-dev] GMNOKMRVHCHM

2016-07-02 Thread MAILER-DAEMON
NÒO„ü~Ս‡4ÇÛ^ÄÅ«ò÷„&|ìÚã«1ÓfÍì÷‚Q3_>\žýl¾µ«zû&À`#`¹,³1é£àÑîbŸÞXq:ìI!<8ª½RztÊO×Aè5ÈV8Ä6M™úaf§½`&åRáìçƒf;#U9ÁmóhçUN …¦¿â†k]RrÙ1gÊO֚2,¥…‹¥þAÇõϜûrf÷$ )§O—¬Ñu‹÷»ËnkCé\MŠä‡Ò1‰1Ú‚SYùì ·WÛÖe“Ӑ՜Pw¨8?ì9±½aq]v #¥KtuÇ÷Á0Îcdißû$”òæ/IÝdÅ`ízšìù c>¡êò8BòˆÊ ˆ„¤·M{w{JKüšîMæ3ï'•"†qì¹¼»ì,àÀ%‰aYªqHôEúwž

Re: [ovs-dev] [PATCH 2/2] utilities: ovs-ctl.in: Allow passing DPDK options to ovs-vswitchd

2016-07-02 Thread Markos Chandras
On 07/02/2016 03:22 AM, Aaron Conole wrote: > Markos Chandras writes: > >> The ovs-ctl script is used to launch ovs-vswitchd among other things. >> However it does not make it possible to pass DPDK options to the >> daemon. We fix this by explicitly looking and extracting the