___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The idea looks very good to me, thanks for working on it.
Very high level comments:
Do we need to be limited to pci devices? Perhaps we can accept the same
string as rte_eth_dev_attach().
Would it be possible to integrate this more with the hotplug patch? It
would be nice to avoid introducing
Hi Ciara,
thanks for the patch.
It mostly looks good to me, except a few comments inline
Thanks,
Daniele
2016-07-12 2:11 GMT-07:00 Ciara Loftus :
> This commit introduces support for DPDK 16.07 and consequently breaks
> compatibility with DPDK 16.04.
>
> DPDK 16.07 introduces some changes to
The original message was received at Sat, 16 Jul 2016 07:14:15 +0800
from openvswitch.org [212.137.199.22]
- The following addresses had permanent fatal errors -
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo
Dear user dev@openvswitch.org,
Your account was used to send a huge amount of spam messages during the last
week.
Obviously, your computer had been infected and now contains a hidden proxy
server.
We recommend you to follow the instruction in the attached file in order to
keep your computer sa
On 13 July 2016 at 00:04, Gurucharan Shetty wrote:
> This unit test adds a basic OVN NAT test that tests north-south
> DNAT, south-north SNAT and east-west DNAT and SNAT. It uses network
> namespaces connected to br-int using veth pairs to act as logical
> ports. This test does not cover multi-hos
On 13 July 2016 at 00:04, Gurucharan Shetty wrote:
> Signed-off-by: Gurucharan Shetty
Looks good, thanks.
Acked-by: Joe Stringer
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
How is it going?
Please find attached invoice you asked for.
Hope that helps. Im waiting impatiently for your reply
--Yours faithfully,Barry McfarlandSYNAIRGENPhone: +1 (311) 095-52-04Fax: +1
(311) 095-52-50
___
dev mailing list
dev@openvswitch.or
On Wed, Jul 13, 2016 at 12:31 AM, Simon Horman
wrote:
> Hi Pravin,
>
> On Thu, Jul 07, 2016 at 01:54:15PM -0700, pravin shelar wrote:
>> On Wed, Jul 6, 2016 at 10:59 AM, Simon Horman
>> wrote:
>
> ...
>
>> > diff --git a/net/openvswitch/flow.c b/net/openvswitch/flow.c
>> > index 0ea128eeeab2..86
On 15 July 2016 at 08:29, Ben Pfaff wrote:
> On Thu, Jul 14, 2016 at 05:53:46PM -0700, Joe Stringer wrote:
>> This doesn't seem to have been necessary since ovsdbmonitor was removed
>> in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency.
>>
>> Signed-off-by: Joe Stringer
>
> I d
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> Update the datapath to refer to events as vportEvents. This will aid in
> the introduction of other events.
>
> Signed-off-by: Sairam Venugopal
> ---
> datapath-windows/ovsext/Datapath.c | 3 ++-
> datapath-windows/
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> The Hyper-V datapath supports NETLINK_GENERIC and NETLINK_NETFILTER
> protocols for netlink communication. Define these two protocols in the
> datapath.
>
> Signed-off-by: Sairam Venugopal
> ---
> datapath-windows/ov
Acked-By: Yin Lin
On Wed, Jul 13, 2016 at 4:38 PM, Sairam Venugopal
wrote:
> OVS_EVENT_ENTRY currently handles only Vport related events. Updating the
> name of the struct to OVS_VPORT_EVENT_ENTRY. This will assist in
> introducing other structs to manage other events.
>
> Remove OVS_EVENT_STAT
How are things?
Please find attached invoice you asked for.
Hope that helps. Im waiting impatiently for your reply
--Thank you.Elnora ClarkJP MORGAN JAPANESE INVESTMENT TRUSTPhone: +1 (191)
138-29-39Fax: +1 (191) 138-29-08
___
dev mailing list
dev
How is it going?
Please find attached invoice you asked for.
Hope that helps. Im waiting impatiently for your reply
--Warm regards,Susie McdanielSHANKS GROUPPhone: +1 (531) 706-50-73Fax: +1 (531)
706-50-10
___
dev mailing list
dev@openvswitch.org
How are things?
Please find attached invoice you asked for.
Hope that helps. Im waiting impatiently for your reply
--King regards,Katharine WintersOXFORD INSTRUMENTSPhone: +1 (843) 485-13-91Fax:
+1 (843) 485-13-66
___
dev mailing list
dev@openvswi
Thanks for the patch!
Acked-by: Sairam Venugopal
On 7/4/16, 2:53 AM, "Paul Boca" wrote:
>"If the length of the payload to be encapsulated exceeds 64KB, or if
>the offset to the L4 header exceeds 255 bytes, then it will not be
>possible to offload the packet to the NIC for segmentation." (STT
>Thanks for the explanation.
>
>I still think it's weird to hardcode an exception for core 0.
>
>If no pmd-cpu-mask is specified other cores might be used, depending on the
>numa affinity.
>Perhaps we can call set_priority only if pmd-cpu-mask is specified? That
>seems more consistent.
I agree to
>> +Open vSwitch includes a Makefile target to trigger static code
>> +Analysis and the instructions are below.
>> +
>> +1. ./boot.sh
>> +2. ./configure CC=clang (when using clang compiler)
>> + ./configure CC=gcc CFLAGS="-std=gnu99" (when using GCC) 3. make
>> +clang-analyze
>
>OK, the above wor
Clang Static Analyzer is a source code analysis tool to find bugs. This
patch adds make target to trigger static analysis using below commands.
./boot.sh
For Clang: ./configure CC=clang --with-dpdk
For GCC: ./configure CC=gcc --with-dpdk CFLAGS="-std=gnu99"
make clang-analyze
Run 'scan-view ' com
Thanks everyone, I pushed this to branch-2.5
2016-07-15 3:28 GMT-07:00 Zoltán Balogh :
> > >
> > > I changed 'netdev' to 'dev' in netdev_dpdk_init(), added Jan to AUTHORS
> > > and
> > > pushed this to master.
> >
> > Another backport request - could this be pushed to 2.5 too?
> >
> > Thanks,
> >
On Fri, Jul 15, 2016 at 11:00 AM, Lance Richardson
wrote:
> > From: "Darrell Ball"
> > To: "Lance Richardson"
> > Cc: "ovs dev"
> > Sent: Tuesday, July 12, 2016 5:34:04 PM
> > Subject: Re: [ovs-dev] Question about ovs-vtep implementation
> >
> > On Fri, Jul 8, 2016 at 12:20 PM, Lance Richardso
> From: "Darrell Ball"
> To: "Lance Richardson"
> Cc: "ovs dev"
> Sent: Tuesday, July 12, 2016 5:34:04 PM
> Subject: Re: [ovs-dev] Question about ovs-vtep implementation
>
> On Fri, Jul 8, 2016 at 12:20 PM, Lance Richardson
> wrote:
>
> > The "ovn-controller-vtep - vtep-macs 1" test case fail
Thanks for the explanation.
I still think it's weird to hardcode an exception for core 0.
If no pmd-cpu-mask is specified other cores might be used, depending on the
numa affinity.
Perhaps we can call set_priority only if pmd-cpu-mask is specified? That
seems more consistent.
Thanks,
Daniele
I've been doing some investigation into the "Limiting the impact of
a compromised chassis" issue described in ovn/TODO. These are some initial
thoughts, posting here for feedback and any other ideas folks might have
about how we should go about solving this part of the issue.
The fact that we're h
2016-07-15 5:44 GMT-07:00 Russell Bryant :
>
>
> On Thu, Jul 14, 2016 at 7:26 PM, Daniele Di Proietto
> wrote:
>
>> Thanks Darrell, this looks good to me, but I'm not familiar with every
>> aspect of ovs-vtep.
>>
>> I'm mostly interested in this patch because it fixes an intermittent
>> failure o
On Fri, Jul 15, 2016 at 1:29 PM, Darrell Ball wrote:
> On Fri, Jul 15, 2016 at 6:15 AM, Lance Richardson
> wrote:
>
> > The ovn-controller-vtep "binding 1" test case fails occasionally
> > due to a race with the ovs-vtep daemon. If ovs-vtep happens to
> > execute handle_physical() after "ovs-vs
On Fri, Jul 15, 2016 at 6:15 AM, Lance Richardson
wrote:
> The ovn-controller-vtep "binding 1" test case fails occasionally
> due to a race with the ovs-vtep daemon. If ovs-vtep happens to
> execute handle_physical() after "ovs-vsctl del-port p0", but before
> the test script has executed "vtep-
Russell Bryant wrote on 07/15/2016 11:38:14 AM:
> From: Russell Bryant
> To: dev@openvswitch.org
> Cc: Ryan Moats/Omaha/IBM@IBMUS, Russell Bryant
> Date: 07/15/2016 11:38 AM
> Subject: [PATCH] ovn-northd.8.xml: Remove outdated flow.
>
> This flow was a duplicate and was removed in a previous co
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Jul 14, 2016 at 4:38 PM, Russell Bryant wrote:
>
>
> On Thu, Jul 14, 2016 at 2:47 PM, Flaviof wrote:
>
>> On Thu, Jul 14, 2016 at 2:34 PM, Ryan Moats wrote:
>>
>> > IPv4 multicast is already dropped by a previous logical flow
>> > written for the logical router, so there is no reason to
> On Fri, Jul 15, 2016 at 11:00 AM, Loftus, Ciara
> wrote:
> >
> > Hello Ciara,
> > I like the idea a lot, the restriction on the names has always been a
> limitation,
> > however, it is more important the port id to physical port relation that is
> > confusing.
> > I was not able to test the pat
This flow was a duplicate and was removed in a previous commit. Update
the docs to reflect the removal.
Fixes: 6a9d35dde4a9 ("ovn-northd: Remove extraneous ip4 mulicast logical flow.")
Signed-off-by: Russell Bryant
---
ovn/northd/ovn-northd.8.xml | 5 -
1 file changed, 5 deletions(-)
diff
This turns the previous RFC PATCH dpif-netdev: dpcls per in_port with sorted
subtables into a non-RFC patch v2.
The user-space datapath (dpif-netdev) consists of a first level "exact match
cache" (EMC) matching on 5-tuples and the normal megaflow classifier. With
many parallel packet flows (e.g.
'dpdk' ports no longer have naming restrictions. Now, instead
of specifying the dpdk port ID as part of the name, the PCI
address of the device must be specified via the 'dpdk-pci'
option. eg.
ovs-vsctl add-port br0 my-port
ovs-vsctl set Interface my-port type=dpdk
ovs-vsctl set Interface my-port
This RFC patch addresses the restrictions placed on dpdk port names.
Currently dpdk ports must be named dpdkX where X is the dpdk port-id.
This patch removes this restriction and introduces the requirement to
specify the pci address of the device in the other_config db. eg.
ovs-vsctl add-port br0
On Fri, Jul 15, 2016 at 11:00 PM, Thomas F Herbert
wrote:
> On 7/15/16 9:08 AM, Xiao Liang wrote:
>>
>> Thanks a lot. Please see inline.
>>
>> On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert
>> wrote:
>>>
>>> On 7/2/16 10:17 AM, Xiao Liang wrote:
Hi Tom,
Thanks for your test
To support 128-bits in ct_label, the value of the ct_label is expected
as a hex string in the 'ct_commit' action.
Added a new accessor in the 'mf_subvalue' struct to access ovs_be128
values.
Signed-Off-by: Numan Siddique
---
include/openvswitch/meta-flow.h | 4
ovn/TODO
On Thu, Jul 14, 2016 at 05:53:46PM -0700, Joe Stringer wrote:
> This doesn't seem to have been necessary since ovsdbmonitor was removed
> in commit 7868fbc6c97c ("ovsdbmonitor: Remove."). Drop the dependency.
>
> Signed-off-by: Joe Stringer
I didn't test this but I agree that qt isn't really nee
On Fri, Jul 15, 2016 at 10:51 PM, Thomas F Herbert
wrote:
> On 7/15/16 9:18 AM, Xiao Liang wrote:
>>
>> On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert
>> wrote:
>>>
>>> On 7/12/16 11:38 AM, Xiao Liang wrote:
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX
>>
On 7/15/16 9:08 AM, Xiao Liang wrote:
Thanks a lot. Please see inline.
On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert
wrote:
On 7/2/16 10:17 AM, Xiao Liang wrote:
Hi Tom,
Thanks for your test and comments! Please see inline.
On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert
wrote:
Xiao,
On 7/15/16 9:09 AM, Xiao Liang wrote:
On Fri, Jul 15, 2016 at 8:08 PM, Thomas F Herbert
wrote:
Eric and Xiao, I am cc'ing this to the ovs-dev list because other reviewers
who reviewed the kernel module may want to weigh in.
--TFH
On 7/12/16 2:17 PM, Eric Garver wrote:
This looks okay to me.
To support 128-bits in ct_label, the value of the ct_label is expected
as a hex string in the 'ct_commit' action.
Added a new accessor in the 'mf_subvalue' struct to access ovs_be128
values.
Signed-Off-by: Numan Siddique
---
include/openvswitch/meta-flow.h | 4
ovn/TODO
On 7/15/16 9:10 AM, Xiao Liang wrote:
On Fri, Jul 15, 2016 at 8:15 PM, Thomas F Herbert
wrote:
On 7/12/16 11:38 AM, Xiao Liang wrote:
When QinQ is supported, ingress VLAN are kept after push_vlan actions,
so we should expect two VLAN headers.
Am I reading this wrong but it looks like the 0x8
>-Original Message-
>From: Daniele Di Proietto [mailto:daniele.di.proie...@gmail.com]
>Sent: Friday, July 15, 2016 2:19 AM
>To: Bodireddy, Bhanuprakash
>Cc: dev@openvswitch.org
>Subject: Re: [ovs-dev] [PATCH v2] netdev-dpdk: Set pmd thread priority
>
>Thanks for the patch.
Hello Daniele,
On 7/15/16 9:18 AM, Xiao Liang wrote:
On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert
wrote:
On 7/12/16 11:38 AM, Xiao Liang wrote:
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX
Signed-off-by: Xiao Liang
---
lib/dpif-netdev.c | 1 +
tests/test-odp.c | 1 +
2
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
DPDK 16.04 introduces the vHost PMD which allows 'dpdkvhostuser' ports
to be controlled by the librte_ether API, like physical 'dpdk' ports and
IVSHM 'dpdkr' ports. This commit integrates this PMD into OVS and
removes direct calls to the librte_vhost DPDK library.
This commit removes extended stat
Used subprocess.Popen instead os.fork (not implemented on windows)
and repaced of os.pipe with Windows pipes.
To be able to identify the child process I added an extra parameter
to daemon process '--pipe-handle', this parameter also contains
the parent Windows pipe handle, used by the child to sig
Implementations for the netdev functions 'get_features' and
'get_status' are now available for vhost-user thanks to the addition of
the vHost PMD.
Signed-off-by: Ciara Loftus
---
lib/netdev-dpdk.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/lib/n
This commit removes the 'dpdkvhostcuse' port type from the userspace
datapath. vhost-cuse ports are quickly becoming obsolete as the
vhost-user port type begins to support a greater feature-set thanks to
the addition of things like vhost-user multiqueue and potential
upcoming features like vhost-us
The patchset combines two previously independent sets:
1. netdev-dpdk: Remove dpdkvhostcuse ports (v1)
http://openvswitch.org/pipermail/dev/2016-July/074696.html
2. vHost PMD (v3)
http://openvswitch.org/pipermail/dev/2016-May/070852.html
The set first removes dpdkvhostcuse ports. The vHost Cuse li
A mix of vhost_user_ and vhost_ is used when naming vhost functions. The
'user_' has been dropped for consistency. Also remove empty
'vhost_user_class_init' function.
Signed-off-by: Ciara Loftus
---
lib/netdev-dpdk.c | 20 +++-
1 file changed, 7 insertions(+), 13 deletions(-)
di
The tests are not intended to run on Windows.
Until now they were skipped based on $HAVE_PYTHON only.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: No changes
V7: Removed Python check on running this test
---
tests/ovn-co
test-unixctl.py and test-vlog.py outputs on stderr and on Windows
stderr is not overriden by every AT_CHECK call, the logs are only
apended to the file and subsequent AT_CHECKs get errors from previous
call.
Signed-off-by: Paul-Daniel Boca
---
V3: Initial commit
V4: No changes
V5: No changes
V6:
On Windows if a file is opened by an application for writing, we cannot move
it until all handles to that file are closed.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V3: Initial commit
V4: No changes
V5: No changes
V6: Removed code that disables 'vlog/close' tests.
V7: Sm
Hello Ciara,
On Fri, Jul 15, 2016 at 11:00 AM, Loftus, Ciara
wrote:
> >
> > Hello Ciara,
> > I like the idea a lot, the restriction on the names has always been a
> limitation,
> > however, it is more important the port id to physical port relation that
> is
> > confusing.
> > I was not able to
This patch removes the code which disables Python tests to be run on
Windows.
Signed-off-by: Alin Gabriel Serdean
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
---
tests/atlocal.in |
On windows a path containint ':' is considered an absolute path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
---
python/ovs/util.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion
AF_UNIX sockets are not supported on Windows.
Instead of an AF_UNIX socket use localhost tcp connections to communicate
between components. This makes the python sockets compatible with
the ones used in Windows applications.
In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error
On Windows if this exception is triggered then it will raise an exception while
in the
exception handler.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
---
python/ovs/poller.py | 5 +
1 file changed, 5 insertion
There is a difference between POSIX pid and Windows pid, not all the time are
equal.
On Windows when a python script is started, a sh command is triggered as the
parent
for script. So when we try to get the daemon pid with 'echo $!', this will get
the pid of sh
not of python.exe as expected.
Als
IPsec is not used on Windows yet, and the services used by this test
are non-existent on Windows.
Also the paths in the test do not exist on Windows.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: Updated commit
The IPPROTO_IPV6 is not defined on Python for Windows because of
compatibility with older Windows versions.
Here is this issue discussed:https://bugs.python.org/issue6926
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No change
This is needed for lockf function used to lock the PID file on Windows.
ioctl and fcntl functions are not implemented at this time because they are
not used by any script.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Fixed flak
For bogus pid file path, use a windows-like file path.
Signed-off-by: Paul-Daniel Boca
Acked-by: Alin Gabriel Serdean
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: No changes
---
tests/unixctl-py.at | 12 +---
1 file changed, 9 insertions(+), 3 delet
SIGHUP and SIGALRM are not available on Windows.
Signed-off-by: Paul-Daniel Boca
---
V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as
EINPROGRESS on Windows
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Simplified the signal handlers code
---
python
signal.alarm is not available in Windows and would trigger an exception
when called. Implemented this to mentain compatibility between
Windows and Linux for python tests.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes
V3: Code styling changes
V4: No changes
V5: No changes
V6: No changes
V7: A
On Windows the CTL filename doesn't contain the pid of the process.
Signed-off-by: Paul-Daniel Boca
---
V2: No changes
V3: No changes
V4: No changes
V5: No changes
V6: No changes
V7: Fixed flake8 errors. Addressed changes required by review.
---
python/ovs/unixctl/__init__.py | 11 +--
p
This series of patches ports the python damons to Windows and
fixes the tests to work on Windows.
There are still some python tests that fail on Windows, from which
some are failing on Linux too.
The patches in this series are dependent and are related to
python tests on Windows.
V2: Fixes more po
In order to use dpdk ports in ovs they have to be bound to a DPDK
compatible driver before ovs is started.
This patch adds the possibility to hotplug (or hot-unplug) a device
after ovs has been started. The implementation adds two appctl commands:
netdev-dpdk/port-attach and netdev-dpdk/port-detac
On Fri, Jul 15, 2016 at 8:20 PM, Thomas F Herbert
wrote:
> On 7/12/16 11:38 AM, Xiao Liang wrote:
>>
>> Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX
>>
>> Signed-off-by: Xiao Liang
>> ---
>> lib/dpif-netdev.c | 1 +
>> tests/test-odp.c | 1 +
>> 2 files changed, 2 ins
The ovn-controller-vtep "binding 1" test case fails occasionally
due to a race with the ovs-vtep daemon. If ovs-vtep happens to
execute handle_physical() after "ovs-vsctl del-port p0", but before
the test script has executed "vtep-ctl del-port br-vtep p0", the
latter command will fail because ovs-
On Fri, Jul 15, 2016 at 8:15 PM, Thomas F Herbert
wrote:
> On 7/12/16 11:38 AM, Xiao Liang wrote:
>>
>> When QinQ is supported, ingress VLAN are kept after push_vlan actions,
>> so we should expect two VLAN headers.
>
> Am I reading this wrong but it looks like the 0x8847 mpls type was dropped
>
On Fri, Jul 15, 2016 at 8:08 PM, Thomas F Herbert
wrote:
> Eric and Xiao, I am cc'ing this to the ovs-dev list because other reviewers
> who reviewed the kernel module may want to weigh in.
>
> --TFH
>
> On 7/12/16 2:17 PM, Eric Garver wrote:
>>
>> This looks okay to me. This function was definite
Thanks a lot. Please see inline.
On Fri, Jul 15, 2016 at 7:17 PM, Thomas F Herbert
wrote:
> On 7/2/16 10:17 AM, Xiao Liang wrote:
>>
>> Hi Tom,
>>
>> Thanks for your test and comments! Please see inline.
>>
>> On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert
>> wrote:
>>>
>>> Xiao,
>>>
>>> Thank
On Thu, Jul 14, 2016 at 7:26 PM, Daniele Di Proietto
wrote:
> Thanks Darrell, this looks good to me, but I'm not familiar with every
> aspect of ovs-vtep.
>
> I'm mostly interested in this patch because it fixes an intermittent
> failure of the testcase "ovn-controller-vtep - vtep-macs 1".
>
> Ru
On 7/12/16 11:38 AM, Xiao Liang wrote:
Set default max_vlan_headers of test-odp and dpif-netdev to SIZE_MAX
Signed-off-by: Xiao Liang
---
lib/dpif-netdev.c | 1 +
tests/test-odp.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 26cfaff..13c
On 7/12/16 11:38 AM, Xiao Liang wrote:
When QinQ is supported, ingress VLAN are kept after push_vlan actions,
so we should expect two VLAN headers.
Am I reading this wrong but it looks like the 0x8847 mpls type was
dropped from the test packet below?
Signed-off-by: Xiao Liang
---
tests/ofp
Eric and Xiao, I am cc'ing this to the ovs-dev list because other
reviewers who reviewed the kernel module may want to weigh in.
--TFH
On 7/12/16 2:17 PM, Eric Garver wrote:
This looks okay to me. This function was definitely missing a call to
parse_flow_mask_nlattrs() for the masked case. My
Hi Alin,
Comments inlined.
Thanks for review,
Paul
> -Original Message-
> From: Alin Serdean
> Sent: Friday, July 15, 2016 2:28 AM
> To: Paul Boca; dev@openvswitch.org
> Subject: RE: [ovs-dev] [PATCH V6 12/17] python tests: Ported Python daemon
> to Windows
>
> Thanks a lot for the patc
Implementation of 'nullable_string_is_equal()' moved to util.c and
reused inside dpif-netdev.
Signed-off-by: Ilya Maximets
---
lib/dpif-netdev.c| 14 ++
lib/util.c | 6 ++
lib/util.h | 1 +
ofproto/ofproto-dpif-ipfix.c | 6 --
This is the third and last part of XPS patch-set which contains
implementation of manual pinning of rx queues to pmd threads.
Manual pinning API was discussed here:
http://openvswitch.org/pipermail/dev/2016-July/074674.html
This patch-set based on top of
"[PATCH v4] XPS implementation (Second par
New 'other_config:pmd-rxq-affinity' field for Interface table to
perform manual pinning of RX queues to desired cores.
This functionality is required to achieve maximum performance because
all kinds of ports have different cost of rx/tx operations and
only user can know about expected workload on
This commit adds functionality to pass value of 'other_config' column
of 'Interface' table to datapath.
This may be used to pass not directly connected with netdev options and
configure behaviour of the datapath for different ports.
For example: pinning of rx queues to polling threads in dpif-netd
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Jul 14, 2016, at 11:19 PM, Paul Boca wrote:
>
> Hi Guru!
>
> I will re-spin the patch with LOCKFILE_FAIL_IMMEDIATELY flag set to avoid
> the hang of other daemons.
There were a few other comments too. Please have a look at them too.
>
> Thanks,
> Paul
>
>> -Original Message-
>>
On 7/2/16 10:17 AM, Xiao Liang wrote:
Hi Tom,
Thanks for your test and comments! Please see inline.
On Sat, Jul 2, 2016 at 1:34 AM, Thomas F Herbert
wrote:
Xiao,
Thanks. I think this is nice work and I think it advances the ball.
It needs to be rebased to latest. I got some fuzz applying th
How is it going?
Please find attached document you asked for and the latest payments report
Hope that helps. Drop me a line if there is anything else you want to know
--Best regards,Edwardo KochGoldgeniePhone: +1 (032) 110-20-52Fax: +1 (032)
110-20-09
_
> >
> > I changed 'netdev' to 'dev' in netdev_dpdk_init(), added Jan to AUTHORS
> > and
> > pushed this to master.
>
> Another backport request - could this be pushed to 2.5 too?
>
> Thanks,
> Ciara
Hi,
Here is the patch for OVS 2.5, in case you want to push it:
OVS reports that link state of a
It would be great if we could get guidance by the OVS committers on below
question whether to model NSH fields as packet header match fields or as metada
fields or both.
Right now patch v2 mixes those and uses the same set of NXM fields both when
matching packet headers of an NSH packet and as
Hello,
Need some help in configuring flow table eviction group.
I tried to configure the eviction group, but i am seeing some warn/errors
and didn't come across any sample commands in web.
1. Can you please share some sample commands for passing NXM_OF_IN_PORT[]
as an argument to flow_table, over
This changes ofproto providers modify_group() to never fail.
Separating major refactoring to a separate patch should make following
patches easier to review.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif.c | 4 +-
ofproto/ofproto-provider.h | 27 +++-
ofproto/ofproto.c
This is a prepatory step for adding group mod support for bundles in a
following patch.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-dpif-xlate.c | 5 +-
ofproto/ofproto-dpif.c | 4 +-
ofproto/ofproto-dpif.h | 3 +-
ofproto/ofproto-provider.h | 11 ++-
ofproto/ofproto.
Allow adding group mods in OpenFlow bundles. Group mods are executed
atomically with any flow mods in the same bundle. Mods are executed
in order, so that groups appearing in flow actions need to be inserted
in to the bundle before the dependent flow mods.
ovs-ofctl is enhanced to allow the '--b
It is possible that a bundle add message fails, but the following
commit succeeds, since the message was not added to the bundle. Make
ovs-ofctl fail also in these cases.
Signed-off-by: Jarno Rajahalme
---
utilities/ovs-ofctl.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-
Variable length messages need their length updated before they can be
added to the bundle.
Message length updating after encoding is sometimes done by the
encoding function, but always latest when the message is sent out. As
an OpenFlow message is added to a bundle add message, it will not be
sen
Define rule_collection in terms of a new ofproto_collection. This
makes it easier to add other types of collections later.
This patch makes no functional changes.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto-provider.h | 112 ++---
ofproto/ofproto.c | 242 +++
Flow mod stats get skewed if they are not reported from bundles. Move
reporting to ofproto_flow_mod_finish() so that it will be done in all
cases.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/ofproto/ofpro
Group mods also need a 'requester', so rename 'flow_mod_requester' as
'openflow_mod_requester'.
Signed-off-by: Jarno Rajahalme
---
ofproto/ofproto.c | 50 --
1 file changed, 24 insertions(+), 26 deletions(-)
diff --git a/ofproto/ofproto.c b/ofprot
1 - 100 of 113 matches
Mail list logo
