Re: [ovs-dev] [PATCH] ovsdb: Fix memory leak in execute_update.

2016-08-02 Thread Andy Zhou
On Mon, Aug 1, 2016 at 10:08 AM, William Tu wrote: > Thanks, I've submitted v2 which removes the 'const'. > LGTM. Pushed to master. Thanks for working on this. > > ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH monitor_cond V11] ovn: implementation of conditional monitoring usage

2016-08-02 Thread Liran Schour
Mickey Spiegel/San Jose/IBM wrote on 31/07/2016 08:59:29 PM: > > Comments inline with > > -"dev" wrote: - > To: Ben Pfaff > From: Liran Schour > Sent by: "dev" > Date: 07/28/2016 04:49AM > Cc: dev@openvswitch.org > Subject: [ovs-dev] [PATCH monitor_cond V11] ovn: implementation of >

[ovs-dev] [PATCH v7 0/2] QOS updates with DSCP support

2016-08-02 Thread bschanmu
From: anbu v6 -> v7 - Updated the DSCP marking part in ovn-northd. Moved the DSCP logical flow to S_SWITCH_IN_PORT_SEC_IP pipeline. - Added test cases for the DSCP marking case. Babu Shanmugam (2): Check and allocate free qdisc queue id for ports with qos parameters DSCP marking on pack

[ovs-dev] [PATCH v7 1/2] Check and allocate free qdisc queue id for ports with qos parameters

2016-08-02 Thread bschanmu
From: Babu Shanmugam ovn-northd processes the list of Port_Bindings and hashes the list of queues per chassis. When it finds a port with qos_parameters and without a queue_id, it allocates a free queue for the chassis that this port belongs. The queue_id information is stored in the options field

[ovs-dev] [PATCH v7 2/2] DSCP marking on packets egressing VIF interface

2016-08-02 Thread bschanmu
From: Babu Shanmugam ovn-northd sets 'ip.dscp' to the DSCP value Signed-off-by: Babu Shanmugam --- ovn/controller/lflow.c | 2 +- ovn/northd/ovn-northd.c | 13 + ovn/ovn-nb.xml | 6 ovn/ovn-sb.xml | 5 tests/ovn.at| 73 +++

Re: [ovs-dev] [PATCH v7 0/2] QOS updates with DSCP support

2016-08-02 Thread Babu Shanmugam
On Tuesday 02 August 2016 02:37 PM, bscha...@redhat.com wrote: From: anbu Please ignore this email address. The email addresses in the patches are all correct. v6 -> v7 - Updated the DSCP marking part in ovn-northd. Moved the DSCP logical flow to S_SWITCH_IN_PORT_SEC_IP pipeline.

Re: [ovs-dev] [PATCH v6 1/2] Check and allocate free qdisc queue id for ports with qos parameters

2016-08-02 Thread Babu Shanmugam
On Monday 01 August 2016 10:09 PM, Babu Shanmugam wrote: On Monday 01 August 2016 09:14 PM, Ben Pfaff wrote: On Mon, Aug 01, 2016 at 07:03:14PM +0530, Babu Shanmugam wrote: On Thursday 28 July 2016 01:48 AM, Ben Pfaff wrote: On Wed, Jul 20, 2016 at 08:02:03PM +0530,bscha...@redhat.com wr

Re: [ovs-dev] [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD

2016-08-02 Thread Loftus, Ciara
> Subject: Re: [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD > > I've applied this patch and performed following test: > > OVS with 2 VMs connected via vhost-user ports. > Each vhost-user port has 4 queues. > > VM1 executes ping on LOCAL port. > In normal situation ping results are following:

[ovs-dev] RETURNED MAIL: DATA FORMAT ERROR

2016-08-02 Thread Mail Administrator
This message was not delivered due to the following reason: Your message could not be delivered because the destination server was unreachable within the allowed queue period. The amount of time a message is queued before it is returned depends on local configura- tion parameters. Most likely the

Re: [ovs-dev] [ovs-discuss] OVS+DPDK: pci_map_resource(): cannot mmap error

2016-08-02 Thread Kavanagh, Mark B
> >Hello, > >i am getting "EAL: pci_map_resource(): cannot mmap(18, 0x7f504000, >0x8, 0x0): Invalid >argument (0x)" when i start ovs-vswitchd. > Hi Kapil, This is a known DPDK issue, which has been resolved in DPDK v16.07. To fix the issue in your setup, you could patch

Re: [ovs-dev] [PATCH] Make the PID part of socket path configurable

2016-08-02 Thread Christian Svensson
On Fri, Jul 29, 2016 at 11:53 PM, Christian Svensson wrote: > [Sorry in advance for the formatting, submitting on mobile. Raw patch > attached.] > I just noticed that the first patch only was a URL, retrying with the real patch attached. > > Sorry for the noise. __

Re: [ovs-dev] [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD

2016-08-02 Thread Ilya Maximets
On 02.08.2016 13:15, Loftus, Ciara wrote: >> Subject: Re: [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD >> >> I've applied this patch and performed following test: >> >> OVS with 2 VMs connected via vhost-user ports. >> Each vhost-user port has 4 queues. >> >> VM1 executes ping on LOCAL port.

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel wrote: > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel > wrote: > > > > -"dev" wrote: - > >> To: Mickey Spiegel > >> From: Russell Bryant > >> Sent by: "dev" > >> Date: 07/29/2016 10:02AM > >> Cc: ovs dev > >> Subject: Re: [ovs-dev] [

[ovs-dev] Mobile App Development Solutions- iOS, Android, Ionic & React Native

2016-08-02 Thread Alex Rubens
Hello, Are you seeking assistance for developing a mobile application? Or need any help in identifying the right technology/ platform for launching your idea? We have a global clientele and extensive repertoire since 2011 in delivering Mobile App Solutions. Top enterprises and start-ups choose S

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > This commit creates wrapper scripts for the *ctl commands to use > --dry-run for those that have them, and to allow for log level > setting via ovs-appctl without allowing full access to ovs-appctl. > Tests have been added to make sure that the

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 7:56 AM, Russell Bryant wrote: > > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > >> This commit creates wrapper scripts for the *ctl commands to use >> --dry-run for those that have them, and to allow for log level >> setting via ovs-appctl without allowing full acc

Re: [ovs-dev] [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD

2016-08-02 Thread Tetsuya Mukawa
2016-08-02 19:50 GMT+09:00 Ilya Maximets : > > > On 02.08.2016 13:15, Loftus, Ciara wrote: >>> Subject: Re: [ovs-dev,v4,3/5] netdev-dpdk: Add vHost User PMD >>> >>> I've applied this patch and performed following test: >>> >>> OVS with 2 VMs connected via vhost-user ports. >>> Each vhost-user port

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ryan Moats
Russell Bryant wrote on 08/02/2016 07:11:38 AM: > From: Russell Bryant > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 08/02/2016 07:12 AM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 2, 2016 at 7:56 AM, Russell Bryant wrote: > > On Tue, A

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ryan Moats
"dev" wrote on 08/02/2016 08:34:08 AM: > From: Ryan Moats/Omaha/IBM@IBMUS > To: Russell Bryant > Cc: ovs dev > Date: 08/02/2016 08:35 AM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > Sent by: "dev" > > > > Russell Bryant wrote on 08/02/2016 07:11:38 AM: > > > F

[ovs-dev] [PATCH monitor_cond V12 1/2] lib: fix bug on ovsdb_idl_condition_remove_clause()

2016-08-02 Thread Liran Schour
Call for poll_immediate_wake() when condition is changed. Signed-off-by: Liran Schour --- lib/ovsdb-idl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c index d70fb10..7f4167c 100644 --- a/lib/ovsdb-idl.c +++ b/lib/ovsdb-idl.c @@ -811,6 +811,7 @@ void ovsdb

[ovs-dev] [PATCH monitor_cond V12 2/2] ovn: implementation of conditional monitoring usage

2016-08-02 Thread Liran Schour
Conditional monitor of: Port_Binding, Logical_Flow, Multicast_Group MAC_Binding tables. As a result ovn-controller will be notified only about records belongs to a datapath that is being served by this hypervisor. Performance evaluation: OVN is the main candidate for conditional monitoring usage.

[ovs-dev] [PATCH] netdev-dpdk: When no QoS set, set type to empty string

2016-08-02 Thread Maxime Coquelin
This patch sets *typep to an empty string instead of letting it uninitialized when no QoS configuration is set. It fixes the following vswitchd crash when no QoS has been set on vhost-user interface: $> ovs-appctl -t ovs-vswitchd qos/show vhost-user1 #0 0x7efcbadf18d7 in raise () from /li

[ovs-dev] [PATCH] bridge: No QoS configured is not an error

2016-08-02 Thread Maxime Coquelin
If no QoS is configured, type value is likely to be an empty string. This is not an error though, so use the regular command reply function, not the error one. For example, before this patch: # ovs-appctl -t ovs-vswitchd qos/show vhost-user1 QoS not configured on vhost-user1 ovs-appctl: ovs

Re: [ovs-dev] [PATCH v6 1/2] Check and allocate free qdisc queue id for ports with qos parameters

2016-08-02 Thread Ben Pfaff
On Tue, Aug 02, 2016 at 03:06:26PM +0530, Babu Shanmugam wrote: > > > On Monday 01 August 2016 10:09 PM, Babu Shanmugam wrote: > > > > > >On Monday 01 August 2016 09:14 PM, Ben Pfaff wrote: > >>On Mon, Aug 01, 2016 at 07:03:14PM +0530, Babu Shanmugam wrote: > >>> > >>>On Thursday 28 July 2016 01:

Re: [ovs-dev] [PATCH 0/5] check-kernel: add 802.1ad tests

2016-08-02 Thread Eric Garver
On Fri, Jul 29, 2016 at 01:50:58PM -0700, Joe Stringer wrote: > On 29 July 2016 at 13:11, Eric Garver wrote: > > Hi Joe, > > > > Thanks for providing feedback. > > > > On Fri, Jul 29, 2016 at 11:14:36AM -0700, Joe Stringer wrote: > >> On 28 July 2016 at 10:54, Eric Garver wrote: > >> > This serie

Re: [ovs-dev] [PATCH] netdev-dpdk: When no QoS set, set type to empty string

2016-08-02 Thread Stokes, Ian
> This patch sets *typep to an empty string instead of letting it > uninitialized when no QoS configuration is set. > > It fixes the following vswitchd crash when no QoS has been set on vhost- > user interface: > > $> ovs-appctl -t ovs-vswitchd qos/show vhost-user1 > > #0 0x7efcbadf18d7 i

[ovs-dev] [PATCH v2 2/5] check-kernel: 802.1ad: Add datapath ping tests for CVLANs.

2016-08-02 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-traffic.at | 63 + 1 file changed, 63 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 1cdc2d2e0f4e..4f72292e5490 100644 --- a/tests/system-traffic.at +++ b/tests/system-

[ovs-dev] [PATCH v2 3/5] check-kernel: 802.1ad: Add conntrack ping tests for CVLANs.

2016-08-02 Thread Eric Garver
Signed-off-by: Eric Garver --- tests/system-traffic.at | 106 1 file changed, 106 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 4f72292e5490..817eca1d5fea 100644 --- a/tests/system-traffic.at +++ b/tests/system

[ovs-dev] [PATCH v2 5/5] check-kernel: 802.1ad: Add dot1q-tunnel test case.

2016-08-02 Thread Eric Garver
Test case for dot1q-tunnel between two "customer" bridges. Signed-off-by: Eric Garver --- tests/system-traffic.at | 45 + 1 file changed, 45 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 3b51d0f91607..d2815aa0a34a

Re: [ovs-dev] [PATCH] ovn-controller: if 'ovn-bridge-mappings' unconfigured, return directly.

2016-08-02 Thread Russell Bryant
On Mon, Aug 1, 2016 at 1:30 PM, Russell Bryant wrote: > > > On Mon, Aug 1, 2016 at 12:09 PM, Russell Bryant wrote: > >> >> >> On Mon, Aug 1, 2016 at 12:00 PM, Ben Pfaff wrote: >> >>> On Mon, Aug 01, 2016 at 02:55:26AM -0700, nickcooper-zhangtonghao wrote: >>> > If the chassis doesn't configure

Re: [ovs-dev] [PATCH] bridge: No QoS configured is not an error

2016-08-02 Thread Stokes, Ian
> If no QoS is configured, type value is likely to be an empty string. > > This is not an error though, so use the regular command reply function, > not the error one. > > For example, before this patch: > # ovs-appctl -t ovs-vswitchd qos/show vhost-user1 > QoS not configured on vhost-user1 >

[ovs-dev] [PATCH v2 0/5] check-kernel: add 802.1ad tests

2016-08-02 Thread Eric Garver
This series adds 6 test cases to the "check-kernel" make target for 802.1ad. It is meant as a counterpart to the 802.1ad work currently going on and being discussed on the dev list. User space support for 802.1ad is being worked on by Xiao Liang (based on Thomas F Herbert's work). Kernel support

[ovs-dev] [PATCH v2 1/5] check-kernel: Add macros to check for and test 802.1ad.

2016-08-02 Thread Eric Garver
Add macros OVS_CHECK_8021AD(), ADD_SVLAN() and ADD_CVLAN(). Signed-off-by: Eric Garver --- tests/system-common-macros.at | 30 +- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/tests/system-common-macros.at b/tests/system-common-macros.at index 4ffc3822

[ovs-dev] [PATCH v2 4/5] check-kernel: 802.1ad: Add push/pop test case.

2016-08-02 Thread Eric Garver
Test case to push and pop outer 802.1ad tag between two "customer" bridges. Signed-off-by: Eric Garver --- tests/system-traffic.at | 54 + 1 file changed, 54 insertions(+) diff --git a/tests/system-traffic.at b/tests/system-traffic.at index 817eca

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 9:37 AM, Ryan Moats wrote: > "dev" wrote on 08/02/2016 08:34:08 AM: > > > From: Ryan Moats/Omaha/IBM@IBMUS > > To: Russell Bryant > > Cc: ovs dev > > Date: 08/02/2016 08:35 AM > > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > Sent by: "dev"

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ben Pfaff
On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote: > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > > > This commit creates wrapper scripts for the *ctl commands to use > > --dry-run for those that have them, and to allow for log level > > setting via ovs-appctl without allowin

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ryan Moats
Russell Bryant wrote on 08/02/2016 10:27:55 AM: > From: Russell Bryant > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: ovs dev > Date: 08/02/2016 10:28 AM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 2, 2016 at 9:37 AM, Ryan Moats wrote: > "dev" wrote on

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ryan Moats
Ben Pfaff wrote on 08/02/2016 11:03:52 AM: > From: Ben Pfaff > To: Russell Bryant > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > Date: 08/02/2016 11:04 AM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote:

Re: [ovs-dev] [ovs-discuss] Compiler warnings with gcc 6.1 (On Fedora 24)

2016-08-02 Thread Charlie Li
I have seen similar compiler error/warnings when compiling DPDK with Fedora 24. I tried to fix the warnings in the source code and passed the compilation, but still could not make the packet flow. Eventually I went back to Fedora 23. Thanks, Charlie On Tue, Jul 26, 2016 at 7:44 AM, Numan Siddique

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Darrell Ball
On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: > On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel > wrote: > > > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel > > wrote: > > > > > > -"dev" wrote: - > > >> To: Mickey Spiegel > > >> From: Russell Bryant > > >> Sent by: "dev" >

[ovs-dev] [PATCH v1 1/1] netdev-dpdk: Fix egress policer error detection bug.

2016-08-02 Thread Ian Stokes
When egress policer is set as a QoS type for a port, an error may occur during setup if incorrect parameters are used for the rte_meter. If this occurs the egress policer construct and set functions should free any allocated memory relevant to the policer and set the QoS configuration pointer to nu

Re: [ovs-dev] [PATCH] netdev-dpdk: When no QoS set, set type to empty string

2016-08-02 Thread Maxime Coquelin
On 08/02/2016 05:19 PM, Stokes, Ian wrote: This patch sets *typep to an empty string instead of letting it uninitialized when no QoS configuration is set. It fixes the following vswitchd crash when no QoS has been set on vhost- user interface: $> ovs-appctl -t ovs-vswitchd qos/show vhost-use

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 12:03 PM, Ben Pfaff wrote: > On Tue, Aug 02, 2016 at 07:56:27AM -0400, Russell Bryant wrote: > > On Tue, Aug 2, 2016 at 12:20 AM, Ryan Moats wrote: > > > > > This commit creates wrapper scripts for the *ctl commands to use > > > --dry-run for those that have them, and to a

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ryan Moats
Russell Bryant wrote on 08/02/2016 12:00:08 PM: > From: Russell Bryant > To: Ben Pfaff > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > Date: 08/02/2016 12:00 PM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 2, 2016 at 12:03 PM, Ben Pfaff wrote: > On T

[ovs-dev] [PATCH v2] ovn: Add second ACL stage

2016-08-02 Thread Mickey Spiegel
This patch adds a second logical switch ingress ACL stage, and correspondingly a second logical switch egress ACL stage. This allows for more than one ACL-based feature to be applied in the ingress and egress logical switch pipelines. The features driving the different ACL stages may be configure

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Kyle Mestery
On Tue, Aug 2, 2016 at 12:13 PM, Ryan Moats wrote: > > Russell Bryant wrote on 08/02/2016 12:00:08 PM: > >> From: Russell Bryant >> To: Ben Pfaff >> Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev >> Date: 08/02/2016 12:00 PM >> Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

Re: [ovs-dev] [PATCH] ovn-nbctl: fix help message for lsp-get/set-addresses

2016-08-02 Thread Russell Bryant
On Sun, Jul 31, 2016 at 2:17 AM, Han Zhou wrote: > Signed-off-by: Han Zhou > --- > ovn/utilities/ovn-nbctl.8.xml | 10 +- > ovn/utilities/ovn-nbctl.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) > Thanks! I applied this to master. -- Russell Bryant ___

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Guru Shetty
On 2 August 2016 at 10:23, Mickey Spiegel wrote: > On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: > > > > > > > On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: > > > >> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel > >> wrote: > >> > >> > On Fri, Jul 29, 2016 at 10:28 AM, Mickey S

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Mickey Spiegel
On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: > > > On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: > >> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel >> wrote: >> >> > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spiegel >> > wrote: >> > > >> > > -"dev" wrote: - >> > >> To:

[ovs-dev] [PATCH v6] Windows: Local named pipe implementation

2016-08-02 Thread Alin Serdean
Currently in the case of command line arguments punix/unix, on Windows we create a file, write a TCP port number to connect. This is a security concern. This patch adds support for the command line arguments punix/unix trying to mimic AF_UNIX behind a local named pipe. This patch drops the TCP so

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ben Pfaff
On Tue, Aug 02, 2016 at 12:13:13PM -0500, Ryan Moats wrote: > > Russell Bryant wrote on 08/02/2016 12:00:08 PM: > > > From: Russell Bryant > > To: Ben Pfaff > > Cc: Ryan Moats/Omaha/IBM@IBMUS, ovs dev > > Date: 08/02/2016 12:00 PM > > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for

[ovs-dev] [PATCH V11 00/17] Fix and enable Python tests on Windows

2016-08-02 Thread Paul Boca
This series of patches ports the python damons to Windows and fixes the tests to work on Windows. There are still some python tests that fail on Windows, from which some are failing on Linux too. The patches in this series are dependent and are related to python tests on Windows. V2: Fixes more po

[ovs-dev] [PATCH V11 01/17] python tests: Implemented signal.alarm for Windows

2016-08-02 Thread Paul Boca
signal.alarm is not available in Windows and would trigger an exception when called. Implemented this to mentain compatibility between Windows and Linux for python tests. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: Code styling changes V4: No changes V5:

[ovs-dev] [PATCH V11 02/17] python tests: Register signal handlers only on supported types on Windows

2016-08-02 Thread Paul Boca
SIGHUP and SIGALRM are not available on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: Fixed Python function inet_open_active, treat WSAEWOULDBLOCK error as EINPROGRESS on Windows V3: No changes V4: No changes V5: No changes V6: No changes V7: Simplified the

[ovs-dev] [PATCH V11 03/17] python tests: Fixed ctl file name for Windows

2016-08-02 Thread Paul Boca
On Windows the CTL filename doesn't contain the pid of the process. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: Fixed flake8 errors. Addressed changes required by review. V8: Fixed small alignem

[ovs-dev] [PATCH V11 04/17] python tests: Fixed unixctl python tests for Windows

2016-08-02 Thread Paul Boca
For bogus pid file path, use a windows-like file path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No changes V10: No changes V11: No changes --- tests/unixctl-py.

[ovs-dev] [PATCH V11 07/17] python tests: Skip TCP6 idl tests on Windows

2016-08-02 Thread Paul Boca
The IPPROTO_IPV6 is not defined on Python for Windows because of compatibility with older Windows versions. Here is this issue discussed:https://bugs.python.org/issue6926 Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No change

[ovs-dev] [PATCH V11 06/17] python tests: Skip IPsec test on Windows

2016-08-02 Thread Paul Boca
IPsec is not used on Windows yet, and the services used by this test are non-existent on Windows. Also the paths in the test do not exist on Windows. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: Updated commit

[ovs-dev] [PATCH V11 09/17] python tests: Fixed OSError not iterable on Windows

2016-08-02 Thread Paul Boca
On Windows if this exception is triggered then it will raise an exception while in the exception handler. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: Added comment when using OSE

[ovs-dev] [PATCH V11 05/17] python tests: Added fcntl module for Windows

2016-08-02 Thread Paul Boca
This is needed for lockf function used to lock the PID file on Windows. ioctl and fcntl functions are not implemented at this time because they are not used by any script. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No chang

[ovs-dev] [PATCH V11 08/17] python tests: Skip python tests on Windows where POSIX pid is used

2016-08-02 Thread Paul Boca
There is a difference between POSIX pid and Windows pid, not all the time are equal. On Windows when a python script is started, a sh command is triggered as the parent for script. So when we try to get the daemon pid with 'echo $!', this will get the pid of sh not of python.exe as expected. Als

[ovs-dev] [PATCH V11 10/17] python tests: Fixed abs_file_name function for Windows

2016-08-02 Thread Paul Boca
On windows a path containint ':' is considered an absolute path. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No changes V10: No changes V11: No changes --- python/

[ovs-dev] [PATCH V11 11/17] python tests: Ported UNIX sockets to Windows

2016-08-02 Thread Paul Boca
AF_UNIX sockets are not supported on Windows. Instead of an AF_UNIX socket use localhost tcp connections to communicate between components. This makes the python sockets compatible with the ones used in Windows applications. In case the socket returns WSAEWOULDBLOCK, it is replaced by EAGAIN error

[ovs-dev] [PATCH V11 12/17] python tests: Prepare porting Python daemon on Windows

2016-08-02 Thread Paul Boca
Renamed daemon.py to daemon_unix.py and implemented a wrapper over it. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V8: Initial commit. V9: No changes V10: Fixed exception on Unix V11: No changes --- python/automake.mk| 1 + python/ovs/daemon.py | 489 ++

[ovs-dev] [PATCH V11 13/17] python tests: Ported Python daemon to Windows

2016-08-02 Thread Paul Boca
Used subprocess.Popen instead os.fork (not implemented on windows) and repaced of os.pipe with Windows pipes. To be able to identify the child process I added an extra parameter to daemon process '--pipe-handle', this parameter also contains the parent Windows pipe handle, used by the child to sig

[ovs-dev] [PATCH V11 14/17] at tests: Allow Python tests to be run on Windows

2016-08-02 Thread Paul Boca
This patch removes the code which disables Python tests to be run on Windows. Signed-off-by: Alin Gabriel Serdean Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V2: No changes V3: No changes V4: No changes V5: No changes V6: No changes V7: No changes V8: No changes V9: No ch

[ovs-dev] [PATCH V11 15/17] python tests: Ignore stderr output

2016-08-02 Thread Paul Boca
test-unixctl.py and test-vlog.py outputs on stderr and on Windows stderr is not overriden by every AT_CHECK call, the logs are only apended to the file and subsequent AT_CHECKs get errors from previous call. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V

[ovs-dev] [PATCH V11 17/17] tests: Skip vlog tests that try to move opened file

2016-08-02 Thread Paul Boca
On Windows if a file is opened by an application for writing, we cannot move it until all handles to that file are closed. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: Removed code that disables 'vlog/close' tests. V7: Sm

[ovs-dev] [PATCH V11 16/17] python tests: Skip ovn-controller-vtep tests on Windows

2016-08-02 Thread Paul Boca
The tests are not intended to run on Windows. Until now they were skipped based on $HAVE_PYTHON only. Signed-off-by: Paul-Daniel Boca Acked-by: Alin Gabriel Serdean --- V3: Initial commit V4: No changes V5: No changes V6: No changes V7: Removed Python check on running this test V8: No changes V9

Re: [ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows

2016-08-02 Thread Paul Boca
Hi Guru! There was a bug indeed and I solved it in V10 series. Thanks for reporting this, Paul From: Guru Shetty [mailto:g...@ovn.org] Sent: Friday, July 29, 2016 8:27 PM To: Paul Boca Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH V8 00/17] Fix and enable Python tests on Windows Thank y

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ryan Moats
Ben Pfaff wrote on 08/02/2016 12:45:49 PM: > From: Ben Pfaff > To: Ryan Moats/Omaha/IBM@IBMUS > Cc: Russell Bryant , ovs dev > Date: 08/02/2016 12:46 PM > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands > > On Tue, Aug 02, 2016 at 12:13:13PM -0500, Ryan Moats wrote: >

Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl commands

2016-08-02 Thread Ben Pfaff
On Tue, Aug 02, 2016 at 12:59:42PM -0500, Ryan Moats wrote: > > Ben Pfaff wrote on 08/02/2016 12:45:49 PM: > > > From: Ben Pfaff > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: Russell Bryant , ovs dev > > Date: 08/02/2016 12:46 PM > > Subject: Re: [ovs-dev] [PATCH 2/2] Add wrapper scripts for *ctl

[ovs-dev] [PATCH v7] Windows: Local named pipe implementation

2016-08-02 Thread Alin Serdean
Currently in the case of command line arguments punix/unix, on Windows we create a file, write a TCP port number to connect. This is a security concern. This patch adds support for the command line arguments punix/unix trying to mimic AF_UNIX behind a local named pipe. This patch drops the TCP so

Re: [ovs-dev] Replication feature bug

2016-08-02 Thread Andy Zhou
On Mon, Aug 1, 2016 at 2:44 PM, Andy Zhou wrote: > > > On Mon, Aug 1, 2016 at 10:07 AM, Cabrera Vega, Mario Alberto < > mario.cabr...@hpe.com> wrote: > >> Hi, >> >> The replication_init() function initializes the set that contains the >> names of the >> tables to be monitored and the set that con

[ovs-dev] [PATCH] tests: Fix conntrack tests on windows.

2016-08-02 Thread Daniele Di Proietto
The conntrack unit tests seem to generate different megaflow masks on Windows. The megaflow masks depend on the internal ordering of the subtables, which are sorted using qsort(), based on their max priority. If two subtables have the same priority the ordering between them depend on the stability

Re: [ovs-dev] FAILING UNIT ofproto-dpif.at:8215: testing ofproto-dpif - conntrack - output action

2016-08-02 Thread Daniele Di Proietto
Hi Alin, Thanks for the report! I couldn't reproduce this on Linux or BSD, but Guru (thanks!) gave me a Windows setup, which showed the problem. I sent a patch to fix this and the other issue you reported here: http://openvswitch.org/pipermail/dev/2016-August/077062.html Thanks, Daniele 201

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Darrell Ball
On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel wrote: > On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: >> >>> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spiegel >>> wrote: >>> >>> > On Fri, Jul 29, 2016 at 10:28 AM, Mickey Spi

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: > The 2 ct_commit for deletion of firewall rules will likely be tricky. This > will need unit tests. > I don't think I understand the concern. Can you expand a bit on what you mean by "2 ct_commit for deletion of firewall rules"? -- Russell B

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: > > > On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel > wrote: > >> On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: >> >>> >>> >>> On Tue, Aug 2, 2016 at 4:52 AM, Russell Bryant wrote: >>> On Sat, Jul 30, 2016 at 4:19 PM, Mickey Spie

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Guru Shetty
On 2 August 2016 at 12:01, Russell Bryant wrote: > > On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: > >> The 2 ct_commit for deletion of firewall rules will likely be tricky. This >> will need unit tests. >> > > I don't think I understand the concern. Can you expand a bit on what you > mean

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: > > > On 2 August 2016 at 12:01, Russell Bryant wrote: > >> >> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: >> >>> The 2 ct_commit for deletion of firewall rules will likely be tricky. >>> This >>> will need unit tests. >>> >> >> I don't

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Guru Shetty
On 2 August 2016 at 12:27, Russell Bryant wrote: > > > On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: > >> >> >> On 2 August 2016 at 12:01, Russell Bryant wrote: >> >>> >>> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wrote: >>> The 2 ct_commit for deletion of firewall rules will likel

[ovs-dev] [PATCH v3 1/3] Windows: Add internal switch port per OVS bridge

2016-08-02 Thread Alin Serdean
This patch updates the following commands in the vswitch: ovs-vsctl add-br br-test ovs-vsctl del-br br-test ovs-vsctl add-br br-test: This command will now create an internal port on the MSFT virtual switch using the WMI interface from Msvm_VirtualEthernetSwitchManagementService leveraging

[ovs-dev] [PATCH v3 3/3] Windows: document multiple NIC support setup

2016-08-02 Thread Alin Serdean
This patch updates the documentation on how to set up OVS with multiple NICs. Also update the documentation to show users how new internal ports are created Signed-off-by: Alin Gabriel Serdean Acked-by: Paul Boca --- v3: Add acked v2: Rebase --- --- INSTALL.Windows.md | 143 +++

[ovs-dev] [PATCH v3 2/3] datapath-windows: Add multiple switch internal ports

2016-08-02 Thread Alin Serdean
This patch adds multiple internal ports support to the windows datapath. All tunnels types have been updated to accommodate this new functionality. Signed-off-by: Alin Gabriel Serdean Co-authored-by: Sorin Vinturis Acked-by: Paul Boca --- v3: Add acked v2: Rebase --- datapath-windows/ovsext/Ac

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Russell Bryant
On Tue, Aug 2, 2016 at 3:35 PM, Guru Shetty wrote: > > > On 2 August 2016 at 12:27, Russell Bryant wrote: > >> >> >> On Tue, Aug 2, 2016 at 3:17 PM, Guru Shetty wrote: >> >>> >>> >>> On 2 August 2016 at 12:01, Russell Bryant wrote: >>> On Tue, Aug 2, 2016 at 1:29 PM, Guru Shetty wro

Re: [ovs-dev] [PATCH] tests: Fix conntrack tests on windows.

2016-08-02 Thread Joe Stringer
On 2 August 2016 at 11:58, Daniele Di Proietto wrote: > The conntrack unit tests seem to generate different megaflow masks on > Windows. The megaflow masks depend on the internal ordering of the > subtables, which are sorted using qsort(), based on their max priority. > If two subtables have the

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Darrell Ball
On Tue, Aug 2, 2016 at 12:05 PM, Russell Bryant wrote: > > > On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: > >> >> >> On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel >> wrote: >> >>> On Tue, Aug 2, 2016 at 9:26 AM, Darrell Ball wrote: >>> On Tue, Aug 2, 2016 at 4:52 AM, Ru

[ovs-dev] [PATCH 0/6] datapath: compatibility layer update.

2016-08-02 Thread Pravin B Shelar
Following patches brings in bug fixes and minor updates to compat layer. Last patch adds for latest released linux kernel support. Pravin B Shelar (6): datapath: compat: Detect GSO support at ovs configure datapath: compat: Use checksum offload for outer header. datapath: compat: cleanup ip-

[ovs-dev] [PATCH 1/6] datapath: compat: Detect GSO support at ovs configure

2016-08-02 Thread Pravin B Shelar
OVS turns on tunnel GSO backport statically for kernel older than 3.18. Some distributions kernels could backport tunnel GSO. To make use of device tunnel offload on such kernel detect the support at configure stage. Signed-off-by: Pravin B Shelar --- acinclude.m4

[ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

2016-08-02 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/net/udp.h | 2 +- datapath/linux/compat/udp.c | 19 ++- datapath/linux/compat/udp_tunnel.c | 17 + 3 files changed, 4 insertions(+), 34 deletions(-) diff --git a/datapath/linux/comp

[ovs-dev] [PATCH 4/6] datapath: compat: fix SKB_INIT_FILL_METADATA_DST definition

2016-08-02 Thread Pravin B Shelar
In case of OVS using compat fill metadata dst implementation we need to setup temperory dst. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/gso.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/datapath/linux/compat/gso.h b/datapath/linux/compat/gso.h index 23ed

[ovs-dev] [PATCH 3/6] datapath: compat: cleanup ip-tunnels

2016-08-02 Thread Pravin B Shelar
Remove kernel version check related to unsupported kernel. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/ip_tunnels_core.c | 8 1 file changed, 8 deletions(-) diff --git a/datapath/linux/compat/ip_tunnels_core.c b/datapath/linux/compat/ip_tunnels_core.c index 6e84e80..d1fe2

[ovs-dev] [PATCH 6/6] datapath: Add support for kernel 4.7

2016-08-02 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- FAQ.md | 2 +- NEWS | 2 +- acinclude.m4 | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/FAQ.md b/FAQ.md index 40e3a22..cb9ef41 100644 --- a/FAQ.md +++ b/FAQ.md @@ -172,7 +172,7 @@ A: The following table lists the Linux ker

[ovs-dev] [PATCH 5/6] datapath: compat: remove duplicate check.

2016-08-02 Thread Pravin B Shelar
The check for tunnel GSO packet is done at ip-handle-offloads. Remove same check from udp-handle-offloads. Signed-off-by: Pravin B Shelar --- datapath/linux/compat/include/net/udp_tunnel.h | 4 1 file changed, 4 deletions(-) diff --git a/datapath/linux/compat/include/net/udp_tunnel.h b/da

[ovs-dev] Let's talk the NB DB IDL Part I - things we've see scaling the networking-ovn to NB DB connection

2016-08-02 Thread Ryan Moats
As folks know, we've been working on scaling up OVN coupled with openstack and we are now starting to hit issues in the networking-ovn to NB DBconnection. First, this code from ./ovsdb/execution.c (L693-707) looks a bit funny: if (!strcmp(json_string(until), "==") != equal) { if (timeout &&

Re: [ovs-dev] [PATCH] ovn: Add second ACL stage

2016-08-02 Thread Mickey Spiegel
On Tue, Aug 2, 2016 at 1:39 PM, Darrell Ball wrote: > > > On Tue, Aug 2, 2016 at 12:05 PM, Russell Bryant wrote: > >> >> >> On Tue, Aug 2, 2016 at 3:02 PM, Darrell Ball wrote: >> >>> >>> >>> On Tue, Aug 2, 2016 at 10:23 AM, Mickey Spiegel >>> wrote: >>> On Tue, Aug 2, 2016 at 9:26 AM, Dar

[ovs-dev] [PATCH] fedora.spec: Disable rpmbuild unpackaged files check.

2016-08-02 Thread William Tu
Starting with RPM 4.1, rpmbuild will exit if all files in the $RPM_BUILD_ROOT directory are not found in the %files section, resulting errors below: RPM build errors: Installed (but unpackaged) file(s) found: /usr/include/ovn/actions.h /usr/include/ovn/expr.h /usr/include/ovn/lex.h

Re: [ovs-dev] [PATCH 2/6] datapath: compat: Use checksum offload for outer header.

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 2:17 PM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar > --- > datapath/linux/compat/include/net/udp.h | 2 +- > datapath/linux/compat/udp.c | 19 ++- > datapath/linux/compat/udp_tunnel.c | 17 + > 3 files changed

Re: [ovs-dev] [PATCH 3/6] datapath: compat: cleanup ip-tunnels

2016-08-02 Thread Jesse Gross
On Tue, Aug 2, 2016 at 2:18 PM, Pravin B Shelar wrote: > Remove kernel version check related to unsupported kernel. > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listin

  1   2   >