[ovs-dev] [PATCH v2 7/8] ovn-northd: add Router Advertisement packet forward flow

2016-09-02 Thread Zongkai LI
This patch add lflow support for Router Advertisement packet forward. Forward RA packets to router port in lswitch l2_lkup table. --- ovn/northd/ovn-northd.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index

[ovs-dev] [PATCH v2 6/8] ovn-controller: add 'put_nd_ra' and 'put_nd_opt_*' actions support

2016-09-02 Thread Zongkai LI
This patch adds action 'nd_ra' specific inner actions 'put_nd_ra', 'put_nd_opt_prefix', 'put_nd_opt_mtu', 'put_nd_opt_sll'. Action put_nd_ra will set following fields in Router Advertisement (RA) packet: - cur_hop_limit(8-bit unsigned integer), - "Managed address configuration" and "Other

[ovs-dev] [PATCH v2 8/8] ovn-northd: add IPv6 RS responder support

2016-09-02 Thread Zongkai LI
This patch add support for building Router Solicitation responder flows, which will be used to reply Router Advertisement packet from ovn-controller for VM/VIF port. It adds table Logical_Router_RA_Prefix_Config to define a set of ND Prefix informations configurations(such as valid_lifetime,

[ovs-dev] [PATCH v2 5/8] ovn-controller: add 'nd_ra' action

2016-09-02 Thread Zongkai LI
This patchs add a new action 'nd_ra' against current 'nd_na' action, to work as a Router Solicitation packet responder. The inner actions to set fields, flags, options in RA packet will be introduced in the following patch. v1 -> v2 rebased --- include/ovn/actions.h | 7 ++

[ovs-dev] [PATCH v2 3/8] ovn: extend expr symbols for ND

2016-09-02 Thread Zongkai LI
This patch updates symbols in logical-fields for ND, such as "nd", "nd.target", "nd.sll", "nd.tll", to describe more clear about "icmp6.type" predicate. It adds new symbols: - "nd_rs" stands for Router Solicitation message, - "nd_ra" stands for Router Advertisement message, - "nd_rd" stands for

[ovs-dev] [PATCH v2 2/8] lib: rename ovs_nd_opt to ovs_nd_lla_opt

2016-09-02 Thread Zongkai LI
Since ovs_nd_mtu_opt and ovs_nd_prefix_opt is introducted, rename ovs_nd_opt to ovs_nd_lla_opt to specify it's Source/Target Link-layer Address Option. v1 -> v2 rebased, separete ovs_nd_opt rename to this patch. --- lib/flow.c| 26 ++--- lib/odp-execute.c | 20

[ovs-dev] [PATCH v2 4/8] flow: update is_nd for all ND msg types

2016-09-02 Thread Zongkai LI
This patch updates method is_nd to let type ND_ROUTER_SOLICIT, ND_ROUTER_ADVERT, ND_REDIRECT can be recoginzed. And introduces method is_nd_neighbor for inherit current is_nd behavior. v1 -> v2 rebased, introduces method is_nd_neighbor. --- lib/flow.h | 11 +--

[ovs-dev] [PATCH v2 1/8] packets: add compose_nd_ra to compose Router Advertisement packet

2016-09-02 Thread Zongkai LI
This patch introduces methods to compose a Router Advertisement (RA) packet, introduces flags for RA. RA packet composed structures against specification in RFC4861. Caller can use compse_nd_ra to compose a basic RA packet, and use - packet_put_ra_sll_opt to append a Source Link-layer Address

[ovs-dev] DELIVERY OF YOUR DIPLOMATIC LUGGAGE 122

2016-09-02 Thread IMC
To Your Attention; On behalf of the board and management of International Monetary Committees (IMC). London UK, I Christine Lagarde, the Operations Manager wishes to inform you that your boxes tagged diplomatic luggage 122 with Ref: No 1226/X42/206 which was deposited in our vault for safe

Re: [ovs-dev] [PATCH] xlate: Clarify comment about mac learning table entry locking.

2016-09-02 Thread Ben Pfaff
On Fri, Sep 02, 2016 at 05:50:41PM -0700, Jarno Rajahalme wrote: > The rationale for locking mac learning table entires wrt. gratuitous > ARP packets and bond interfaces was too cryptic for me to understand. > After reading vswitchd/INTERNALS the issue is understandable, but we > can still improve

[ovs-dev] [PATCH] xlate: Clarify comment about mac learning table entry locking.

2016-09-02 Thread Jarno Rajahalme
The rationale for locking mac learning table entires wrt. gratuitous ARP packets and bond interfaces was too cryptic for me to understand. After reading vswitchd/INTERNALS the issue is understandable, but we can still improve the comment to prevent such confusion in future. Signed-off-by: Jarno

[ovs-dev] [PATCH] xlate: Perform bridge lookup before using xlate cache.

2016-09-02 Thread Jarno Rajahalme
Bridges might get deleted while revalidation is going through the xlate cache entries. Thus we need to do the xbridge lookup before we use the xlate cache, and use uuid's instead of pointers on xlate cache entries that might refer to other bridges. This has the side effect of not updating the

Re: [ovs-dev] [PATCH] Flush freshly-polled sFlow counters promptly.

2016-09-02 Thread Ben Pfaff
Thanks for the hint. I pushed a fix to master and branch-2.6. On Fri, Sep 02, 2016 at 02:58:15PM -0700, Neil McKee wrote: > Yes, the output is OK.In fact, if you change the time/warp in > ofproto-dpif.at so that it only advances the monotonic clock by 2 > seconds during the test instead of

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Honor mtu_request even for internal ports.

2016-09-02 Thread Daniele Di Proietto
On 02/09/2016 14:43, "Joe Stringer" wrote: >On 2 September 2016 at 14:02, Ben Pfaff wrote: >> On Fri, Sep 02, 2016 at 11:23:22AM -0700, Daniele Di Proietto wrote: >>> By default Open vSwitch tries to configure internal interfaces MTU to >>> match the bridge

Re: [ovs-dev] [PATCH v2] ovs-monitor-ipsec: Fix flake8-check semicolon error

2016-09-02 Thread Ben Pfaff
On Thu, Sep 01, 2016 at 02:55:52PM -0700, Joe Stringer wrote: > On 31 August 2016 at 09:58, Ben Pfaff wrote: > > On Wed, Aug 31, 2016 at 09:33:24AM -0700, Amitabha Biswas wrote: > >> Fixes: 19cd0a87 > >> > >> Signed-off-by: Amitabha Biswas > >> Acked-by: Numan

Re: [ovs-dev] [PATCH] learn: Fix iteration over learning specs.

2016-09-02 Thread Ben Pfaff
Thanks, applied to master and branch-2.6. On Fri, Sep 02, 2016 at 03:49:59PM -0700, Jarno Rajahalme wrote: > Good catch (== thanks for finding an embarrassing bug to mine :-) > > Acked-by: Jarno Rajahalme > > > On Sep 2, 2016, at 1:26 PM, Ben Pfaff wrote: > > > >

Re: [ovs-dev] [PATCH] learn: Fix iteration over learning specs.

2016-09-02 Thread Jarno Rajahalme
Good catch (== thanks for finding an embarrassing bug to mine :-) Acked-by: Jarno Rajahalme > On Sep 2, 2016, at 1:26 PM, Ben Pfaff wrote: > > struct ofpact_learn_spec is variable-length. The 'n_specs' member of > struct ofpact_learn counted the number of specs,

Re: [ovs-dev] [PATCH] Flush freshly-polled sFlow counters promptly.

2016-09-02 Thread Neil McKee
Yes, the output is OK.In fact, if you change the time/warp in ofproto-dpif.at so that it only advances the monotonic clock by 2 seconds during the test instead of 3 (see below), then it flushes out the same number of counter samples, and the only differences that appear in

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Honor mtu_request even for internal ports.

2016-09-02 Thread Joe Stringer
On 2 September 2016 at 14:02, Ben Pfaff wrote: > On Fri, Sep 02, 2016 at 11:23:22AM -0700, Daniele Di Proietto wrote: >> By default Open vSwitch tries to configure internal interfaces MTU to >> match the bridge minimum, overriding any attempt by the user to >> configure it through

Re: [ovs-dev] [PATCH net-next v21 4/4] openvswitch: report error on VLAN nlattr in ovs_key_from_nlattrs()

2016-09-02 Thread pravin shelar
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > With 802.1ad support these are parsed and set upfront by > parse_vlan_from_nlattrs() before ovs_key_from_nlattrs() is ever called. > As such we should never see a VLAN attribute in ovs_key_from_nlattrs(). > > Signed-off-by: Eric

Re: [ovs-dev] [PATCH net-next v21 3/4] openvswitch: 802.1AD Flow handling, actions, vlan parsing, netlink attributes

2016-09-02 Thread pravin shelar
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > Add support for 802.1ad including the ability to push and pop double > tagged vlans. Add support for 802.1ad to netlink parsing and flow > conversion. Uses double nested encap attributes to represent double > tagged vlan. Inner

Re: [ovs-dev] [PATCH net-next v21 2/4] vlan: Check for vlan ethernet types for 8021.q or 802.1ad

2016-09-02 Thread pravin shelar
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > This is to simplify using double tagged vlans. This function allows all > valid vlan ethertypes to be checked in a single function call. > Also replace some instances that check for both ETH_P_8021Q and > ETH_P_8021AD. > > Patch

Re: [ovs-dev] [PATCH net-next v21 1/4] openvswitch: 802.1ad uapi changes.

2016-09-02 Thread pravin shelar
On Thu, Sep 1, 2016 at 1:45 PM, Eric Garver wrote: > From: Thomas F Herbert > > openvswitch: Add support for 8021.AD > > Change the description of the VLAN tpid field. > > Signed-off-by: Thomas F Herbert Acked-by: Pravin B

Re: [ovs-dev] [PATCH v2 2/2] ofproto: Honor mtu_request even for internal ports.

2016-09-02 Thread Ben Pfaff
On Fri, Sep 02, 2016 at 11:23:22AM -0700, Daniele Di Proietto wrote: > By default Open vSwitch tries to configure internal interfaces MTU to > match the bridge minimum, overriding any attempt by the user to > configure it through standard system tools, or the database. > > While this works in

Re: [ovs-dev] [v3] ovsdb: Replication usability improvements

2016-09-02 Thread Ben Pfaff
On Wed, Aug 31, 2016 at 07:32:41PM -0700, Andy Zhou wrote: > Added the '--no-sync' option base on feedbacks of current > implementation. > > Added appctl command "ovsdb-server/sync-status" based on feedbacks > of current implementation. > > Added the RPL_S_INIT state in the state machine. This

[ovs-dev] [PATCH] learn: Fix iteration over learning specs.

2016-09-02 Thread Ben Pfaff
struct ofpact_learn_spec is variable-length. The 'n_specs' member of struct ofpact_learn counted the number of specs, but the iteration loops over struct ofpact_learn_spec only iterated as far as the *minimum* length of 'n_specs' specs. This fixes the problem, which exhibited as consistent

Re: [ovs-dev] [PATCH] Flush freshly-polled sFlow counters promptly.

2016-09-02 Thread Ben Pfaff
I see the failing tests. If you can read the new results of the tests and verify for me that they're still a correct set of results, then I'll push a fix that updates the expected results. On Fri, Sep 02, 2016 at 12:03:21PM -0700, Neil McKee wrote: > This one perturbs the output ordering just

[ovs-dev] [PATCH] ovn-controller: Fix match crieria for dynamic mac binding flows

2016-09-02 Thread Chandra S Vejendla
match struct is not initialized before adding flows for each entry in mac_bindings table. This results in incorrect match criteria. Signed-off-by: Chandra Sekhar Vejendla Signed-off-by: Ryan Moats Co-authored-by: Ryan Moats ---

Re: [ovs-dev] [PATCH] Flush freshly-polled sFlow counters promptly.

2016-09-02 Thread Neil McKee
This one perturbs the output ordering just enough to fail two of the sflow unit tests. Sorry I didn't notice that before. I'll post another patch for that. Neil -- Neil McKee InMon Corp. http://www.inmon.com On Fri, Sep 2, 2016 at 11:47 AM, Ben Pfaff wrote: > On Mon, Aug

Re: [ovs-dev] [PATCH] Flush freshly-polled sFlow counters promptly.

2016-09-02 Thread Ben Pfaff
On Mon, Aug 29, 2016 at 03:32:41PM -0700, Neil McKee wrote: > This patch changes the order of the steps that are followed > every second in the sFlow agent. By moving the receiver_tick() > step to the end, we ensure that any counters that were polled > during the poller_tick() step are flushed

Re: [ovs-dev] [PATCH] Avoid segfault in sFlow when datapath input port for tunnel sample is unknown.

2016-09-02 Thread Ben Pfaff
On Mon, Aug 29, 2016 at 10:13:11AM -0700, Neil McKee wrote: > This patch avoids a segfault that was found and documented here: > http://openvswitch.org/pipermail/discuss/2016-August/022513.html > > I raised a pull-request on github. > > Signed-off-by: Neil McKee Thanks,

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-02 Thread Daniele Di Proietto
On 01/09/2016 12:59, "Thadeu Lima de Souza Cascardo" wrote: >On Thu, Sep 01, 2016 at 05:17:44PM +, Daniele Di Proietto wrote: >> Let me try to sum up the problem further >> >> 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU >> for new

Re: [ovs-dev] [PATCH] check-system-userspace: add recheck support

2016-09-02 Thread Ben Pfaff
On Fri, Sep 02, 2016 at 09:01:17AM -0400, Lance Richardson wrote: > Add support for "make check-system-userspace RECHECK=yes", similar > to existing support for "make check RECHECK=yes". > > Signed-off-by: Lance Richardson Seems obviously correct, I applied this to master.

Re: [ovs-dev] [PATCH] ofproto: Do not override internal port MTU.

2016-09-02 Thread Daniele Di Proietto
On 01/09/2016 11:07, "Jesse Gross" wrote: >On Thu, Sep 1, 2016 at 10:17 AM, Daniele Di Proietto > wrote: >> Let me try to sum up the problem further >> >> 1) Behavior on master, before commit 47bf118665a3("ofproto: Always set MTU >> for new

[ovs-dev] [PATCH v2 2/2] ofproto: Honor mtu_request even for internal ports.

2016-09-02 Thread Daniele Di Proietto
By default Open vSwitch tries to configure internal interfaces MTU to match the bridge minimum, overriding any attempt by the user to configure it through standard system tools, or the database. While this works in many simple cases (there are probably many users that rely on this) it may create

Re: [ovs-dev] [PATCH] Logic error in IDL parse function

2016-09-02 Thread Ben Pfaff
On Fri, Sep 02, 2016 at 12:43:29AM -0700, Mickey Spiegel wrote: > This was found due to a build error when adding an ovsschema column > with > "type": {"key": "string", "value": "integer"} > with no min or max, only a single instance. > > I am rather unfamiliar with IDL, so no tests have been

[ovs-dev] [PATCH v2 1/2] Revert "ofproto: Always set MTU for new internal ports."

2016-09-02 Thread Daniele Di Proietto
This reverts commit 47bf118665a3d0f3c153d1fe80e9af02ac9a4e9c. While the commit tries to make it more consistent, it breaks some system tests. The assumptions made on the tests are probably made by many users, so it's better to revert it. Signed-off-by: Daniele Di Proietto

Re: [ovs-dev] [PATCH] datapath-windows: Encapsulate packet when src port is tunnel port

2016-09-02 Thread Nithin Raju
Acked-by: Nithin Raju >On 9/1/16, 2:54 PM, "Sairam Venugopal" wrote: > >>If a packet arrives on a tunnel port and is again transmitted on a tunnel >>port, the packet needs to be encapsulated. >> >>Eg: >>Sample flow which arrives on a tunnel port and gets

Re: [ovs-dev] [PATCH 0/2] support kernel datapath check when building rpms

2016-09-02 Thread Lance Richardson
Apologies, this series should have been marked "PATCH v2". - Original Message - > From: "Lance Richardson" > To: dev@openvswitch.org > Cc: f...@sysclose.org > Sent: Friday, September 2, 2016 9:55:25 AM > Subject: [ovs-dev] [PATCH 0/2] support kernel datapath check

[ovs-dev] [PATCH 1/2] rhel: build source rpm packages

2016-09-02 Thread Lance Richardson
Build source RPM packages for rpm-fedora and rpm-fedora-kmod targets. Signed-off-by: Lance Richardson --- v1->v2: No changes. rhel/automake.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rhel/automake.mk b/rhel/automake.mk index a3c180c..541f3fc

[ovs-dev] [PATCH 2/2] rhel: add option to run kernel datapath test when building rpms

2016-09-02 Thread Lance Richardson
Add ability to execute kernel datapath tests when building rpms. These tests are disabled by default, and can optionally be run by providing "--with check_datapath_kernel" on the rpmbuild command line. This is intended to facilitate automated testing, and should not be used in production

[ovs-dev] [PATCH 0/2] support kernel datapath check when building rpms

2016-09-02 Thread Lance Richardson
Add ability to (optionally) run kernel datapath checks when building source rpms. - Generate source RPMs for fedora-rpm and fedora-rpm-kmod targets - Run "make check-kernel" when building RPMS if "--with check_datapath_kernel" option is provided on rpmbuild command line. One use

[ovs-dev] [PATCH] check-system-userspace: add recheck support

2016-09-02 Thread Lance Richardson
Add support for "make check-system-userspace RECHECK=yes", similar to existing support for "make check RECHECK=yes". Signed-off-by: Lance Richardson --- tests/automake.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/automake.mk

[ovs-dev] Returned mail: Data format error

2016-09-02 Thread to
The message could not be delivered ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 1691gif

2016-09-02 Thread homer_...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 3603193docx

2016-09-02 Thread eileen_...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 9756508159tiff

2016-09-02 Thread woodrow_...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 69494237tiff

2016-09-02 Thread kim_9...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 05349docx

2016-09-02 Thread melody_9...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 9357486017jpg

2016-09-02 Thread suzette_25...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 2100docx

2016-09-02 Thread garret_...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] 9631432jpg

2016-09-02 Thread sherry_...@icloud.com
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Logic error in IDL parse function

2016-09-02 Thread Mickey Spiegel
This was found due to a build error when adding an ovsschema column with "type": {"key": "string", "value": "integer"} with no min or max, only a single instance. I am rather unfamiliar with IDL, so no tests have been added yet. I could use some pointers, or someone familiar with IDL tests could

[ovs-dev] [PATCH v4] ovn-nbctl: Add LB commands.

2016-09-02 Thread nickcooper-zhangtonghao
This patch provides the command line to create a load balancer. You can create a load balancer independently and add it to multiple switches. A single load balancer can have multiple vips. Add a name column for the load balancer. With --add-duplicate, the command really creates a new load balancer

Re: [ovs-dev] [patch v11 2/2] DSCP marking on packets egressing VIF interface

2016-09-02 Thread Babu Shanmugam
Thank you for reviewing, Mickey. I completely agree with your proposal. Do you think it will be better to have this patch for now till we work on the code for your proposal? On Friday 02 September 2016 11:17 AM, Mickey Spiegel wrote: On Wed, Aug 31, 2016 at 12:11 AM,