[ovs-dev] Mail System Error - Returned Mail

The original message was received at Sat, 8 Oct 2016 11:50:06 +0530 from 71.47.103.129 - The following addresses had permanent fatal errors - - Transcript of session follows - ... while talking to mail server openvswitch.org.: >>> RCPT To: <<< 550 5.1.1 ... User unknown

Re: [ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

Good idea. I am interested in that. The patch will be submitted. Thanks. > On Oct 8, 2016, at 2:09 AM, Guru Shetty wrote: > > On 5 October 2016 at 04:25, nickcooper-zhangtonghao > > wrote: > Thanks very much. > > If it is of interest, something

Re: [ovs-dev] [PATCH] meta-flow: Fix the NXM_NX_* names of xxreg2 and xxreg3.

That seems like a reasonable idea to me. It's obviously not strictly necessary, but it's nice to be able to deal with contiguous ranges. --Justin > On Oct 7, 2016, at 5:44 PM, Jarno Rajahalme wrote: > > Should we also reserve some range of NXM_NX numbers after 114 for potential > future reg

Re: [ovs-dev] [PATCH] meta-flow: Fix the NXM_NX_* names of xxreg2 and xxreg3.

> On Oct 7, 2016, at 5:41 PM, Jarno Rajahalme wrote: > > xxreg2 and xxreg3 had the same NXM_NX_* names as xxreg0 and xxreg1, > correspondingly. > > Found by inspection. > > CC: Justin Pettit > Fixes: b23ada8eecfd ("Introduce 128-bit xxregs.") > Signed-off-by: Jarno Rajahalme Thanks! Acked-

Re: [ovs-dev] [PATCH] meta-flow: Fix the NXM_NX_* names of xxreg2 and xxreg3.

Should we also reserve some range of NXM_NX numbers after 114 for potential future registers, say 115-118 at least? Other register types do not have this problem as they have their own classes of numbers. Jarno > On Oct 7, 2016, at 5:41 PM, Jarno Rajahalme wrote: > > xxreg2 and xxreg3 had t

[ovs-dev] [PATCH] meta-flow: Fix the NXM_NX_* names of xxreg2 and xxreg3.

xxreg2 and xxreg3 had the same NXM_NX_* names as xxreg0 and xxreg1, correspondingly. Found by inspection. CC: Justin Pettit Fixes: b23ada8eecfd ("Introduce 128-bit xxregs.") Signed-off-by: Jarno Rajahalme --- include/openvswitch/meta-flow.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

Re: [ovs-dev] [patch_v4] ovn: Add additional comments regarding arp responders.

Overall it looks good to me. Just suggestions for rewording. On Thu, Oct 6, 2016 at 10:34 AM, Darrell Ball wrote: > > There has been enough confusion regarding logical switch datapath > arp responders in ovn to warrant some additional comments; > hence add a general description regarding why they

Re: [ovs-dev] [PATCH 2/2] vagrant: use RECHECK=yes for system checks

On 04/10/2016 12:02, "Ben Pfaff" wrote: >On Mon, Sep 19, 2016 at 04:31:04PM -0300, Thadeu Lima de Souza Cascardo wrote: >> Use RECHECK=yes for both kernel and userspace datapath tests. >> >> Signed-off-by: Thadeu Lima de Souza Cascardo > >Looks good to me but Daniele knows the system tests

Re: [ovs-dev] [PATCH 07/12] dpif-netdev: Cache align netdev_flow_keys.

2016-10-07 14:10 GMT-07:00 Jarno Rajahalme : > > > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy < > bhanuprakash.bodire...@intel.com> wrote: > > > > Aligning the 'keys' array seems to positively impact performance. > > > > Signed-off-by: Bhanuprakash Bodireddy > > Signed-off-by: Antonio Fis

Re: [ovs-dev] [PATCH 05/12] dpif-netdev: Clear flow batches inside packet_batch_execute.

This patch basically reverts 603f2ce04d00("dpif-netdev: Clear flow batches before execute.") As explained in that commit message the problem is that packet_batch_per_flow_execute() can trigger recirculation. This means that we will call recursively dp_netdev_input__(). Here's a stack frame: dp_

Re: [ovs-dev] [PATCH 00/12] Improve performance of OVS-DPDK classifier

Thanks for posting this. I quickly tried this with some simple flow tables and it seems to be beneficial. I agree with Jarno's comments and I posted a couple more to the single patches. I see two signoff, but a single author, should you add a Co-authored-by, perhaps? Other than these I am fine

Re: [ovs-dev] [PATCH 2/2] ovn-trace: Include source file and line number reference in output.

On Fri, Oct 07, 2016 at 02:39:00PM -0700, Andy Zhou wrote: > On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote: > > > This should make it that much easier to track down the code that emitted > > a particular flow. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Andy Zhou > > Also tested in

Re: [ovs-dev] [PATCH] ovn: Fix "trace" test to wait for synchronization of southbound ports.

On Fri, Oct 07, 2016 at 02:41:22PM -0700, Andy Zhou wrote: > On Fri, Oct 7, 2016 at 9:23 AM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > Acked-by: Andy Zhou Thanks, I applied this to master. ___ dev mailing list dev@openvswitch.org http://o

Re: [ovs-dev] [PATCH 1/2] smap: New macro SMAP_CONST2 for an immutable map of 2 key-value pairs.

On Fri, Oct 07, 2016 at 02:37:29PM -0700, Andy Zhou wrote: > On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote: > > > Future commits will add a user. > > > > Signed-off-by: Ben Pfaff > > > > Acked-by: Andy Zhou > > This is the first time I encountered a linked-list being built statically. > Ve

Re: [ovs-dev] [PATCH] ovn: Fix "trace" test to wait for synchronization of southbound ports.

On Fri, Oct 7, 2016 at 9:23 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] ovn-trace: Include source file and line number reference in output.

On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote: > This should make it that much easier to track down the code that emitted > a particular flow. > > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou Also tested in the OVN sandbox. ___ dev mailing lis

Re: [ovs-dev] [PATCH 1/2] smap: New macro SMAP_CONST2 for an immutable map of 2 key-value pairs.

On Fri, Oct 7, 2016 at 10:02 AM, Ben Pfaff wrote: > Future commits will add a user. > > Signed-off-by: Ben Pfaff > Acked-by: Andy Zhou This is the first time I encountered a linked-list being built statically. Very cool trick! ___ dev mailing list d

Re: [ovs-dev] [PATCH 12/12] timeval: Reorder elements in clock structure.

I would leave the ‘stopped’ member below the comment. Also, the 2nd cacheline is only ever accessed during unit tests, so this should not have real performance impact. Acked-by: Jarno Rajahalme > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > By reordering the elements in c

Re: [ovs-dev] [PATCH 11/12] netlink-socket: Reorder elements in nl_dump structure.

Acked-by: Jarno Rajahalme > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > By reordering the elements in nl_dump structure, pad bytes can be > reduced there by saving a cache line. > > Before: structure size:72, holes:1, sum padbytes:4, cachelines:2 > After: structure size:64

Re: [ovs-dev] [PATCH 10/12] ovsdb: Reorder elements in ovsdb_table_schema structure.

Acked-by: Jarno Rajahalme > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > By reordering the elements in ovsdb_table_schema structure, pad bytes > can be reduced and also a cache line is saved. > > Before: structure size:72, holes:2, sum padbytes:10, cachelines:2 > After: str

Re: [ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall structure.

CodingStyle.md instructs to group struct members into related groups. Also, changing the relative order of pointers should not make any difference. Could you achieve the same by reordering just the members above the ‘DPIF_UC_ACTION only.’ comment? Jarno > On Oct 7, 2016, at 9:17 AM, Bhanupra

Re: [ovs-dev] [PATCH 08/12] dpif-netdev: Reorder elements in dp_netdev_port structure.

Would equivalent packing be achieved by moving the line down before the bool instead? If yes, it would be preferable. Acked-by: Jarno Rajahalme > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > By reordering the data elements in dp_netdev_port structure, pad bytes > can be re

Re: [ovs-dev] [PATCH 07/12] dpif-netdev: Cache align netdev_flow_keys.

> On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > Aligning the 'keys' array seems to positively impact performance. > > Signed-off-by: Bhanuprakash Bodireddy > Signed-off-by: Antonio Fischetti > --- > lib/dpif-netdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [ovs-dev] [PATCH 06/12] cmap: Remove prefetching in cmap_find_batch().

> On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > prefetching the data in to the caches isn't improving the performance in > cmap_find_batch(). Moreover its found that there is slight improvement > in performance with out prefetching. > I recall doing some performance testing

Re: [ovs-dev] [PATCH 05/12] dpif-netdev: Clear flow batches inside packet_batch_execute.

Daniele had a comment on this, I believe? > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > There is a slight negative performance impact, by zeroing out the flow > batch pointers in dp_netdev_input__ ahead of packet_batch_execute(). The > issue has been observed with multiple b

Re: [ovs-dev] [PATCH 04/12] hash: Skip invoking mhash_add__() with zero input.

> On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > mhash_add__() is expensive and should be only called with valid input. > This patch will validate the input before invoking the mhash_add__ and > there by saving some cpu cycles. > > Signed-off-by: Bhanuprakash Bodireddy > Sign

Re: [ovs-dev] [PATCH 03/12] flow: Skip invoking expensive count_1bits() with zero input.

With the nit below, Acked-by: Jarno Rajahalme > On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > This patch checks if trash is non-zero and only then resets the flowmap > bit and increment the pointer by set bits as found in trash. > > Signed-off-by: Bhanuprakash Bodireddy >

Re: [ovs-dev] [PATCH 02/12] flow: Add comments to mf_get_next_in_map()

> On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > A brief commit message should be included here. E.g.: This patch adds comments to mf)get_next_in_map() to make it more comprehensible. > Signed-off-by: Bhanuprakash Bodireddy > Signed-off-by: Antonio Fischetti > --- > lib/flow

Re: [ovs-dev] [PATCH 01/12] dpcls: Use 32 packet batches for lookups.

> On Oct 7, 2016, at 9:17 AM, Bhanuprakash Bodireddy > wrote: > > This patch increases the number of packets processed in a batch during a > lookup from 16 to 32. Processing batches of 32 packets improves > performance and also one of the internal loops can be avoided here. > Can you provide

[ovs-dev] [PATCH 3/6] checkpatch: print the final warning / error count

Because we track it, might as well report it. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index ed53f32..61678a9 100755 --- a/utilities/checkpatch.py +++ b/utili

[ovs-dev] [PATCH 6/6] checkpatch: Print file line numbers

The line numbers being printed were the line numbers for the patchfile. This is sometimes okay to fix simple things (trailing or leading whitespace, missing signoffs, etc). But more complicated fixes, or those fixes which require a bit more care, aren't helped by this. So, we use the implied file

[ovs-dev] [PATCH 5/6] checkpatch: convert some of the warnings

These coding issues are not just things that shouldn't be done. They are styles which should never be submitted. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py ind

[ovs-dev] [PATCH 4/6] checkpatch: Print the line in question distinctly

This makes it easier to pick out of the warnings/errors. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 61678a9..c8f21b0 100755 --- a/utilities/checkpatch.py +++ b

[ovs-dev] [PATCH 2/6] checkpatch: Announce the file where errors occur.

This makes finding the warning and error marks much easier. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/utilities/checkpatch.py b/utilities/checkpatch.py index 17e5be4..ed53f32 100755 --- a/utilities/checkpatch.py +++ b/

[ovs-dev] [PATCH 1/6] checkpatch: Fix up the co-authors check

The signed-off and co-authors check that was committed is just plain wrong. The test should be more than 1 'Signed-off-by'. Signed-off-by: Aaron Conole --- utilities/checkpatch.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utilities/checkpatch.py b/utilities/check

[ovs-dev] [PATCH 0/6] Misc. Checkpatch cleanups

Two of these are 'bug fixes' to the checkpatch infrastructure (1/6, and 5/6), while the rest are enhancements. In particular, 6/6 hasn't been aggressively tested. These were developed while working on other patches, but are being submitted here as an independent series. Aaron Conole (6): check

Re: [ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

On 5 October 2016 at 04:25, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > Thanks very much. > If it is of interest, something similar can be done for NAT too. > > > On Oct 4, 2016, at 5:12 AM, Guru Shetty wrote: > > > > I applied the patch. For future, when you ve

Re: [ovs-dev] [Backport Request] For branch-2.5, backport rhel-systemd integration

On Thu, Sep 08, 2016 at 07:58:21PM +0100, Markos Chandras wrote: > On 09/08/2016 05:50 PM, Aaron Conole wrote: > > > >> It sounds like new feature territory, but you do make a case for it being > >> considered a set of fixes ... > > > > I agree - it straddles a line. I was hesitant to even ask,

[ovs-dev] [PATCH] rhel-systemd: Delay shutting down the services

During testing it was found that systemd would consider the openvswitch service as a part of networking component, but the dependent services of ovs-vswitchd and ovsdb-server were not likewise considered. This leads to some strange race conditions, observed when using NFS over TCP, while shutting

[ovs-dev] [PATCH] lex: Treat formfeeds as white space.

Also vertical tabs, whatever those are. Signed-off-by: Ben Pfaff --- ovn/lib/lex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/lib/lex.c b/ovn/lib/lex.c index a05edfa..7eee3b6 100644 --- a/ovn/lib/lex.c +++ b/ovn/lib/lex.c @@ -589,7 +589,7 @@ next: token->typ

[ovs-dev] [PATCH 1/2] smap: New macro SMAP_CONST2 for an immutable map of 2 key-value pairs.

Future commits will add a user. Signed-off-by: Ben Pfaff --- include/openvswitch/hmap.h | 10 +- lib/smap.h | 26 +- 2 files changed, 22 insertions(+), 14 deletions(-) diff --git a/include/openvswitch/hmap.h b/include/openvswitch/hmap.h index ef27

[ovs-dev] [PATCH 2/2] ovn-trace: Include source file and line number reference in output.

This should make it that much easier to track down the code that emitted a particular flow. Signed-off-by: Ben Pfaff --- ovn/northd/ovn-northd.c | 40 +++- ovn/ovn-sb.xml| 5 + ovn/utilities/ovn-trace.8.xml | 7 --- ovn/utilitie

[ovs-dev] [PATCH] ovn: Fix "trace" test to wait for synchronization of southbound ports.

Signed-off-by: Ben Pfaff --- tests/ovn.at | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/ovn.at b/tests/ovn.at index 4dfb077..38b5af9 100644 --- a/tests/ovn.at +++ b/tests/ovn.at @@ -1259,6 +1259,9 @@ ovn-nbctl ls-add lsw0 ovn-sbctl chassis-add hv0 geneve 127.0.0.1 for i in 1 2 3;

[ovs-dev] [PATCH 09/12] dpif: Reorder elements in dpif_upcall structure.

By reordering the data elements in dpif_upcall structure, pad bytes can be reduced and also a cache line. Before: structure size:768, holes:1, sum padbytes:60, cachelines:12 After: structure size:656, holes:1, sum padbytes:4, cachelines:11 Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Ant

[ovs-dev] [PATCH 07/12] dpif-netdev: Cache align netdev_flow_keys.

Aligning the 'keys' array seems to positively impact performance. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio Fischetti --- lib/dpif-netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index d0bb191..dfc9cbd 100644

[ovs-dev] [PATCH 12/12] timeval: Reorder elements in clock structure.

By reordering the elements in clock structure, pad bytes can be reduced and also a cache line is saved. Before: structure size:136, holes:3, sum padbytes:18, cachelines:3 After: structure size:120, holes:1, sum padbytes:2, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio

[ovs-dev] [PATCH 11/12] netlink-socket: Reorder elements in nl_dump structure.

By reordering the elements in nl_dump structure, pad bytes can be reduced there by saving a cache line. Before: structure size:72, holes:1, sum padbytes:4, cachelines:2 After: structure size:64, holes:0, sum padbytes:0, cachelines:1 Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio Fi

[ovs-dev] [PATCH 10/12] ovsdb: Reorder elements in ovsdb_table_schema structure.

By reordering the elements in ovsdb_table_schema structure, pad bytes can be reduced and also a cache line is saved. Before: structure size:72, holes:2, sum padbytes:10, cachelines:2 After: structure size:64, holes:1, sum padbytes:2, cachelines:1 Signed-off-by: Bhanuprakash Bodireddy Signed-off-

[ovs-dev] [PATCH 08/12] dpif-netdev: Reorder elements in dp_netdev_port structure.

By reordering the data elements in dp_netdev_port structure, pad bytes can be reduced and there by saving a cache line. Before: structure size:136, holes:3, sum padbytes:15, cachelines:3 After: structure size:128, holes:1, sum padbytes:7, cachelines:2 Signed-off-by: Bhanuprakash Bodireddy Signed

[ovs-dev] [PATCH 06/12] cmap: Remove prefetching in cmap_find_batch().

prefetching the data in to the caches isn't improving the performance in cmap_find_batch(). Moreover its found that there is slight improvement in performance with out prefetching. This patch removes prefetching from cmap_find_batch(). Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio

[ovs-dev] [PATCH 05/12] dpif-netdev: Clear flow batches inside packet_batch_execute.

There is a slight negative performance impact, by zeroing out the flow batch pointers in dp_netdev_input__ ahead of packet_batch_execute(). The issue has been observed with multiple batches test scenario. This patch fixes the problem by removing the extra for loop and clear the flow batches inside

[ovs-dev] [PATCH 04/12] hash: Skip invoking mhash_add__() with zero input.

mhash_add__() is expensive and should be only called with valid input. This patch will validate the input before invoking the mhash_add__ and there by saving some cpu cycles. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio Fischetti --- lib/hash.h | 2 +- 1 file changed, 1 insertio

[ovs-dev] [PATCH 03/12] flow: Skip invoking expensive count_1bits() with zero input.

This patch checks if trash is non-zero and only then resets the flowmap bit and increment the pointer by set bits as found in trash. Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio Fischetti --- lib/flow.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/li

[ovs-dev] [PATCH 00/12] Improve performance of OVS-DPDK classifier

This patch series is aimed at improving the performance of OVS-DPDK dpcls. With few thousands flows installed, the EMC becomes inefficient due to thrashing and the bottleneck moves to the dpcls. In EMC disabled case, through VTune we found that significant performance degradation is due to LLC thr

[ovs-dev] [PATCH 02/12] flow: Add comments to mf_get_next_in_map()

Signed-off-by: Bhanuprakash Bodireddy Signed-off-by: Antonio Fischetti --- lib/flow.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/flow.h b/lib/flow.h index ea24e28..4eb19ae 100644 --- a/lib/flow.h +++ b/lib/flow.h @@ -570,15 +570,27 @@ struct

[ovs-dev] [PATCH 01/12] dpcls: Use 32 packet batches for lookups.

This patch increases the number of packets processed in a batch during a lookup from 16 to 32. Processing batches of 32 packets improves performance and also one of the internal loops can be avoided here. Signed-off-by: Antonio Fischetti Signed-off-by: Bhanuprakash Bodireddy --- lib/dpif-netdev

[ovs-dev] [PATCH] ovn-nb: Document the syntax for an address set name.

Also, it is not necessary to specify that the name must be unique because the schema documentation generator does that for us. Reported-by: Kevin Lin Reported-at: http://openvswitch.org/pipermail/dev/2016-October/080386.html Signed-off-by: Ben Pfaff --- AUTHORS| 1 + ovn/ovn-nb.xml | 3

Re: [ovs-dev] [PATCH] ovn-northd: Drop redundant matching constraints in build_stateful().

On Thu, Oct 06, 2016 at 04:19:59PM -0700, Justin Pettit wrote: > > > On Oct 5, 2016, at 6:27 PM, Ben Pfaff wrote: > > > > ip4.dst implies ip, udp.dst implies udp, and tcp.dst implies tcp. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied to master. ___

Re: [ovs-dev] [PATCH 3/7] ovn: Fix some races in IPAM connectivity test.

On Fri, Oct 07, 2016 at 07:27:54AM -0700, Guru Shetty wrote: > On 5 October 2016 at 18:26, Ben Pfaff wrote: > > > It can take a way for dynamic addresses to propagate through ovn-northd, > > so wait for it to happen. > > > > Signed-off-by: Ben Pfaff > > --- > > tests/ovn.at | 13 - >

Re: [ovs-dev] [PATCH 1/7] ovn: Fix races in MAC_Binding deletion test.

On Fri, Oct 07, 2016 at 07:24:29AM -0700, Guru Shetty wrote: > On 5 October 2016 at 18:26, Ben Pfaff wrote: > > > The test assumed that ovn-northd could delete the MAC_Binding rows > > instantly, but it may take a while. > > > > Signed-off-by: Ben Pfaff > > --- > > tests/ovn.at | 9 - >

Re: [ovs-dev] [PATCH 7/7] ovn: Remove weird or unneeded keywords from tests.

On 5 October 2016 at 18:26, Ben Pfaff wrote: > AT_KEYWORDS are mostly there to make it easier to find the tests you're > looking for. One might, for example, mark tests as "positive" or > "negative" so you can select the tests you want to run on that basis. > They're also useful for cases where

Re: [ovs-dev] [PATCH 6/7] ovn: Fix some races in ovn-controller-vtep tests.

On 5 October 2016 at 18:26, Ben Pfaff wrote: > This fixes a few races for port bindings appearing and being bound to > a chassis. The ones changed to use "ovn-sbctl wait-until" were previously > only waiting until a Port_Binding record appeared (created by ovn-northd), > but not until the Port_B

Re: [ovs-dev] [PATCH 5/7] ovn: Wait for ovn-northd to catch up in "ovn-sbctl" test.

On 5 October 2016 at 18:26, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > tests/ovn-sbctl.at | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tests/ovn-sbctl.at b/tests/ovn-sbctl.at > index 9393eef..26b05af 100644 > --- a/

Re: [ovs-dev] [PATCH 4/7] ovn: Fix race in "ovn -- ipam" test.

On 5 October 2016 at 18:26, Ben Pfaff wrote: > After setting the subnet, ovn-northd needs to process the changes before > setting the dynamic addresses. > > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > tests/ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [ovs-dev] [PATCH 3/7] ovn: Fix some races in IPAM connectivity test.

On 5 October 2016 at 18:26, Ben Pfaff wrote: > It can take a way for dynamic addresses to propagate through ovn-northd, > so wait for it to happen. > > Signed-off-by: Ben Pfaff > --- > tests/ovn.at | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/tests/ovn.

Re: [ovs-dev] [PATCH 2/7] ovn: Fix bugs in port security test.

On 5 October 2016 at 18:26, Ben Pfaff wrote: > A number of instances of "{i}" in this test should have been "${i}". > > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > tests/ovn.at | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/ovn.a

Re: [ovs-dev] [PATCH 1/7] ovn: Fix races in MAC_Binding deletion test.

On 5 October 2016 at 18:26, Ben Pfaff wrote: > The test assumed that ovn-northd could delete the MAC_Binding rows > instantly, but it may take a while. > > Signed-off-by: Ben Pfaff > --- > tests/ovn.at | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/tests/ovn.a