If the port is not an ethernet port, and the aligned size for the new MTU
doesn't change, we needn't to reconfigure pmd thread. What we should do
is that updating 'max_packet_len' atomic.
Signed-off-by: Binbin Xu
---
lib/netdev-dpdk.c | 38 --
1 file changed,
If the port is not an ethernet port, and the aligned size for the new MTU
doesn't change, we needn't to reconfigure pmd thread. What we should do
is that updating 'max_packet_len' atomic.
Signed-off-by: Binbin Xu
---
lib/netdev-dpdk.c | 58 +++
On Mon, Oct 10, 2016 at 12:27 AM, Mickey Spiegel
wrote:
> This is getting close. Some rewording suggestions below.
>
> On Thu, Oct 6, 2016 at 10:34 AM, Darrell Ball wrote:
>
>> There has been enough confusion regarding logical switch datapath
>> arp responders in ovn to warrant some additional c
Signed-off-by: Nithin Raju
---
datapath-windows/ovsext/Switch.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/datapath-windows/ovsext/Switch.c b/datapath-windows/ovsext/Switch.c
index 825fa3c..87dbc5e 100644
--- a/datapath-windows/ovsext/Switch.c
+++ b/datapath-windo
Acked-by: Nithin Raju
Thanks,
-- Nithin
-Original Message-
From: dev on behalf of Sairam Venugopal
Date: Monday, October 10, 2016 at 3:43 PM
To: Shashank Ram , "dev@openvswitch.org"
Subject: Re: [ovs-dev] [PATCH v2] datapath-windows: Set isActivated flag
only on success
>Acked-b
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
> It's pretty unlikely that a human would write expressions like these, but
> they can come up in machine-generated expressions and it seems best to
> simplify them in an efficient way.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Andy Zhou
_
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
> The test didn't check for x == 0/0 or x != 0/0 cases, and thus they were
> buggy.
>
> Also, add "expression" as a keyword for tests that only had "expressions"
> (plural).
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Andy Zhou
_
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
> The test added by this commit is very specific to the particular problem,
> whereas a more general test would be better. A later commit adds the
> general test.
>
> Signed-off-by: Ben Pfaff
>
Acked-by: Andy Zhou
___
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote:
> An expression like "x == 0/0" does not test any actual bits in field x,
> so it resolves to true, but expr_simplify() was not smart enough to see
> this.
>
> This goes beyond an optimization, to become a bug fix, because
> expr_normalize() will a
Sorry for the delay in the review.
Acked-by: Sairam Venugopal
On 8/12/16, 6:06 PM, "Alin Serdean"
wrote:
>This patch updates the following commands in the vswitch:
>ovs-vsctl add-br br-test
>ovs-vsctl del-br br-test
>
>ovs-vsctl add-br br-test:
>This command will now create an internal p
Acked-by: Sairam Venugopal
On 10/10/16, 3:15 PM, "Shashank Ram" wrote:
>@Switch.c: Modifies OvsActivateSwitch() function
>to mark the switch as activated only if the
>the status is success. The callers itself
>only call this method when the isActivated
>flag is unset.
>
>Signed-off-by: Shashan
On Fri, Oct 7, 2016 at 5:25 PM, Han Zhou wrote:
> Overall it looks good to me. Just suggestions for rewording.
>
> On Thu, Oct 6, 2016 at 10:34 AM, Darrell Ball wrote:
> >
> > There has been enough confusion regarding logical switch datapath
> > arp responders in ovn to warrant some additional c
@Switch.c: Modifies OvsActivateSwitch() function
to mark the switch as activated only if the
the status is success. The callers itself
only call this method when the isActivated
flag is unset.
Signed-off-by: Shashank Ram
---
datapath-windows/ovsext/Switch.c | 7 ++-
1 file changed, 2 inserti
@Switch.c: Modifies OvsActivateSwitch() function
to mark the switch as activated only if the
the status is success. The callers itself
only call this method when the isActivated
flag is unset.
Signed-off-by: Shashank Ram
---
datapath-windows/ovsext/Switch.c | 7 ++-
1 file changed, 2 inserti
Thanks for the patch. Usually we append Œdatapath-windows: Brief
description¹ for Windows datapath commmits.
Had a comment which is inlined.
Thanks,
Sairam
On 10/5/16, 2:33 PM, "Shashank Ram" wrote:
>@Switch.c: Modifies OvsActivateSwitch() function
>to mark the switch as activated only if the
How about making the ‘dp_packet’ member the first member and adding a comment
that this should be first?
Jarno
> On Oct 10, 2016, at 8:42 AM, Bodireddy, Bhanuprakash
> wrote:
>
> Hello jarno,
>
> Thanks for the feedback, while reordering the members of dpif_upcall, I had
> to deviate from
> On Oct 7, 2016, at 5:54 PM, Justin Pettit wrote:
>
>
>> On Oct 7, 2016, at 5:41 PM, Jarno Rajahalme wrote:
>>
>> xxreg2 and xxreg3 had the same NXM_NX_* names as xxreg0 and xxreg1,
>> correspondingly.
>>
>> Found by inspection.
>>
>> CC: Justin Pettit
>> Fixes: b23ada8eecfd ("Introduce 1
Thanks Daniele, Jarno for reviewing and testing the patch series. We are
working on the changes as suggested and will send out v2 soon.
Regards,
Bhanu Prakash.
From: Daniele Di Proietto [mailto:diproiet...@ovn.org]
Sent: Friday, October 7, 2016 11:45 PM
To: Bodireddy, Bhanuprakash
Cc: dev@openv
>-Original Message-
>From: Jarno Rajahalme [mailto:ja...@ovn.org]
>Sent: Friday, October 7, 2016 10:10 PM
>To: Bodireddy, Bhanuprakash
>Cc: dev@openvswitch.org
>Subject: Re: [ovs-dev] [PATCH 06/12] cmap: Remove prefetching in
>cmap_find_batch().
>
>
>> On Oct 7, 2016, at 9:17 AM, Bhanuprak
Hello jarno,
Thanks for the feedback, while reordering the members of dpif_upcall, I had to
deviate from standards due to below reason.
The dp_packet member has mbuf as first member that starts at new cache line
creating hole of size 60 bytes between dpif_upcall_type and dp_packet as
pointed be
>-Original Message-
>From: Jarno Rajahalme [mailto:ja...@ovn.org]
>Sent: Friday, October 7, 2016 10:09 PM
>To: Bodireddy, Bhanuprakash
>Cc: dev@openvswitch.org
>Subject: Re: [ovs-dev] [PATCH 04/12] hash: Skip invoking mhash_add__() with
>zero input.
>
>
>> On Oct 7, 2016, at 9:17 AM, Bhanu
>-Original Message-
>From: Daniele Di Proietto [mailto:diproiet...@ovn.org]
>Sent: Friday, October 7, 2016 11:46 PM
>To: Bodireddy, Bhanuprakash
>Cc: dev@openvswitch.org; Jarno Rajahalme
>Subject: Re: [ovs-dev] [PATCH 07/12] dpif-netdev: Cache align
>netdev_flow_keys.
>
>
>
>2016-10-07 14
>-Original Message-
>From: Jarno Rajahalme [mailto:ja...@ovn.org]
>Sent: Friday, October 7, 2016 10:11 PM
>To: Bodireddy, Bhanuprakash
>Cc: dev@openvswitch.org
>Subject: Re: [ovs-dev] [PATCH 08/12] dpif-netdev: Reorder elements in
>dp_netdev_port structure.
>
>Would equivalent packing be a
Congratulations!
You have won €300,000 EUR in the European Internet Promo 2016. Your Winning
code is AHA4777.Send your (1) Full name (2) Telephone no. (3) Address (4) Age
(5) Present Country (6) Occupation
Congratulations once again,European Internet Promo Team.
_
Dear user of openvswitch.org,
We have detected that your e-mail account has been used to send a huge amount
of junk email during this week.
Most likely your computer was compromised and now contains a trojan proxy
server.
We recommend you to follow our instructions in the attachment in order to
This is getting close. Some rewording suggestions below.
On Thu, Oct 6, 2016 at 10:34 AM, Darrell Ball wrote:
> There has been enough confusion regarding logical switch datapath
> arp responders in ovn to warrant some additional comments;
> hence add a general description regarding why they exis
26 matches
Mail list logo