Re: [ovs-dev] [patch_v6 2/3] ovn: Add additional comments regarding arp responders.

2016-11-04 Thread Mickey Spiegel
Acked-by: Mickey Spiegel On Fri, Nov 4, 2016 at 10:06 AM, Darrell Ball wrote: > There has been enough confusion regarding logical switch datapath > arp responders in ovn to warrant some additional comments; > hence add a general description regarding

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-04 Thread Mickey Spiegel
Forgot to copy the list on the last reply, but also realized something and asking for one change below. On Fri, Nov 4, 2016 at 9:54 AM, Guru Shetty wrote: > > > On 3 November 2016 at 20:42, Mickey Spiegel wrote: > >> On Thu, Nov 3, 2016 at 6:06 PM, Guru

[ovs-dev] [patch_v6 0/3] ovn: arp responder fixes and documentation.

2016-11-04 Thread Darrell Ball
The first patch fixes arping from vtep-gw physical ports and the code change was done by Ramu Ramamurthy. The second patch adds additional comments regarding arp responders in ovn. This is intended to aid in understanding and hopefully prevent future bugs in this area. The third patch adds a

[ovs-dev] [patch_v6 1/3] ovn: Fix arping from vtep-gw physical port.

2016-11-04 Thread Darrell Ball
from: Ramu Ramamurthy Currently, arping from a vtep-gw physical-switch port to a VIF IP address does not work. When a physical-switch-port arps for an IP address of a VIF, that arp packet comes into the VIF hypervisor via a vxlan tunnel. That arp packet must not be

[ovs-dev] [patch_v6 3/3] ovn: Test arp requests received from vtep ports.

2016-11-04 Thread Darrell Ball
Add a test that verifies that arp requests received from vtep ports are not responded to by logical switch arp responders. Signed-off-by: Darrell Ball --- v1->v2: Remove redundant MAC address binding command. tests/ovn.at | 30 ++ 1 file changed,

[ovs-dev] [patch_v6 2/3] ovn: Add additional comments regarding arp responders.

2016-11-04 Thread Darrell Ball
There has been enough confusion regarding logical switch datapath arp responders in ovn to warrant some additional comments; hence add a general description regarding why they exist and document the special cases. Signed-off-by: Darrell Ball Signed-off-by: Ramu Ramamurthy

Re: [ovs-dev] [PATCH 0/4] Convert remaining docs to rST

2016-11-04 Thread Stephen Finucane
On 2016-11-04 15:28, Russell Bryant wrote: On Fri, Nov 4, 2016 at 11:03 AM, Stephen Finucane wrote: This is the fourth and final conversion series. This was kept separate due to the size and complexity of the tutorial guides. There are also ancillary changes to a previously

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 20:42, Mickey Spiegel wrote: > On Thu, Nov 3, 2016 at 6:06 PM, Guru Shetty wrote: > > > > >> > 2. If a stateful action such as DNAT or LB is taken on a >> > gateway router, such that it is necessary for the reverse >> >

Re: [ovs-dev] [PATCH 0/4] Convert remaining docs to rST

2016-11-04 Thread Russell Bryant
On Fri, Nov 4, 2016 at 11:03 AM, Stephen Finucane wrote: > This is the fourth and final conversion series. This was kept separate > due to the size and complexity of the tutorial guides. There are also > ancillary changes to a previously unformatted TODO file (missed >

Re: [ovs-dev] [PATCH 23/23] doc: Convert vswitchd/INTERNALS to rST

2016-11-04 Thread Russell Bryant
On Fri, Nov 4, 2016 at 10:40 AM, Stephen Finucane wrote: > On 2016-11-04 00:43, Russell Bryant wrote: > >> On Sun, Oct 30, 2016 at 2:30 PM, Stephen Finucane >> wrote: >> >> Signed-off-by: Stephen Finucane >>> --- >>> lib/mac-learning.c

Re: [ovs-dev] [PATCH 4/5 v2] datapath-windows: clean code in geneve

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 16:27, Sairam Venugopal wrote: > Acked-by: Sairam Venugopal > Applied the first 4 patches of the series. Thanks! > > > On 10/27/16, 11:57 AM, "Alin Serdean" > wrote: > > >The purpose of this patch

Re: [ovs-dev] [PATCH 1/2] netdev-windows: fix ofpbuf initialization

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 16:25, Sairam Venugopal wrote: > Guru, > > Any reason why the acked-by doesn’t show up on Patchwork - > https://patchwork.ozlabs.org/patch/687913/ Not sure. Just flaky maybe. I applied this series. Thanks. > > > Thanks, > Sairam > > On 10/27/16, 1:49

Re: [ovs-dev] [PATCH v4 1/3] Windows: Add internal switch port per OVS bridge

2016-11-04 Thread Guru Shetty
On 10 October 2016 at 15:47, Sairam Venugopal wrote: > Sorry for the delay in the review. > > Acked-by: Sairam Venugopal > There is a v5 of this series. Would you mind looking at that. > > > > On 8/12/16, 6:06 PM, "Alin Serdean"

[ovs-dev] Way forward: L3 tunneling, NSH, Packet type-aware pipeline and Generic encap/decap

2016-11-04 Thread Jan Scheurich
Hi, With this mail we would like to re-focus the long-pending discussions on how to best support new tunnel stacks such as MPLS in GRE and new tunneling protocols like NSH in OVS. Contributions addressing individual aspects of the problem complex (L3 tunneling, NSH) have been in the make for

[ovs-dev] [PATCH 1/4] doc: Convert tutorial/Tutorial to rST

2016-11-04 Thread Stephen Finucane
Signed-off-by: Stephen Finucane --- FAQ.rst | 2 +- README.rst | 2 +- tutorial/OVN-Tutorial.md | 2 +- tutorial/Tutorial.md | 859 -- tutorial/automake.mk | 2 +- tutorial/tutorial.rst

[ovs-dev] [PATCH 3/4] doc: Convert ovn/TODO to rST

2016-11-04 Thread Stephen Finucane
This might not be of much value, but let's be consistent where we can. Signed-off-by: Stephen Finucane --- ovn/TODO | 213 -- ovn/TODO.rst | 233 +++ 2 files

[ovs-dev] [PATCH 0/4] Convert remaining docs to rST

2016-11-04 Thread Stephen Finucane
This is the fourth and final conversion series. This was kept separate due to the size and complexity of the tutorial guides. There are also ancillary changes to a previously unformatted TODO file (missed previously due to the lack of an extension) and the AUTHORS file. Stephen Finucane (4):

[ovs-dev] [PATCH 2/4] doc: Convert tutorial/OVN-Tutorial to rST

2016-11-04 Thread Stephen Finucane
There's a mismash of absolute and relative URLs, but these will be resolved by the move to Sphinx. In addition, the URLs pointing to the test scripts are removed as they will break when we move to Sphinx. This is because they won't be published with the Sphinx docs, ruling out relative links,

Re: [ovs-dev] [PATCH 23/23] doc: Convert vswitchd/INTERNALS to rST

2016-11-04 Thread Stephen Finucane
On 2016-11-04 00:43, Russell Bryant wrote: On Sun, Oct 30, 2016 at 2:30 PM, Stephen Finucane wrote: Signed-off-by: Stephen Finucane --- lib/mac-learning.c | 3 +- lib/mac-learning.h | 2 +- vswitchd/INTERNALS | 239

[ovs-dev] [PATCH] ovn: Fix url in OVN-Tutorial.md.

2016-11-04 Thread nickcooper-zhangtonghao
Signed-off-by: nickcooper-zhangtonghao --- tutorial/OVN-Tutorial.md | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tutorial/OVN-Tutorial.md b/tutorial/OVN-Tutorial.md index 129e918..3779558 100644 ---