Looks good, thanks.
Bruce
On Aug 14, 2014, at 11:02 AM, Alex Wang wrote:
> This commit adds more explanation for the bfd diagnostic and
> bfd remote diagnostic in vswitch and vtep documentation.
>
> Requested-by:Bruce Davie
> Signed-off-by: Alex Wang
> ---
> vswitchd/vswitch.xml | 10 +
The OVS implementation of BFD allows configuration of the source and
destination IP addresses of BFD packets. This patch adds the same
configuration option to the VTEP schema.
Signed-off-by: Bruce Davie
---
vtep/vtep.xml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/vtep
Signed-off-by: Bruce Davie
---
vtep/vtep.ovsschema | 104 -
vtep/vtep.xml | 218 ++--
2 files changed, 161 insertions(+), 161 deletions(-)
diff --git a/vtep/vtep.ovsschema b/vtep/vtep.ovsschema
index 4a25f2f..94494ab
Ben,
Thanks for the review. We have not yet tested any implementations of BFD on
VTEPs, so I’m not too worried about backward compatibility. We discovered the
need for this change to BFD in the schema when looking at how we would
configure BFD tunnels terminating on several VTEPs managed by a
Two new tables are added to the VTEP schema, for ACL entries and
ACLs (which are groups of entries). The physical port table is modified
to allow ACLs to be associated with ports, and the logical router table
is modified to allow ACLs to be attached to logical router ports.
Signed-off-by: Bruce
d to allow ACLs to be attached to logical router ports.
>
> Signed-off-by: Bruce Davie
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> On Sep 10, 2015, at 3:07 PM, Justin Pettit wrote:
>
>
>> On Aug 25, 2015, at 1:03 PM, Bruce Davie wrote:
>>
>> diff --git a/vtep/vtep.xml b/vtep/vtep.xml
>> index ff8d0fe..a554dcf 100644
>> --- a/vtep/vtep.xml
>
v1 -> v2: split typos into separate patch; document VLAN zero meaning
for VLAN bindings and statistics; update VTEP ACL documentation in response
to Justin's review
Bruce Davie (3):
vtep: fix typos
vtep: Document the meaning of VLAN zero for vlan_bindings
vtep: add ACLs to VTE
Two new tables are added to the VTEP schema, for ACL entries and
ACLs (which are groups of entries). The physical port table is modified
to allow ACLs to be associated with ports, and the logical router table
is modified to allow ACLs to be attached to logical router ports.
Signed-off-by: Bruce
Correct a number of typos in vtep.xml
Signed-off-by: Bruce Davie
---
vtep/vtep.xml | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/vtep/vtep.xml b/vtep/vtep.xml
index ff8d0fe..0450999 100644
--- a/vtep/vtep.xml
+++ b/vtep/vtep.xml
@@ -367,7 +367,7
The meaning of a value of zero in the VLAN field when mapping
pairs to
logical switches had not previously been specified in the VTEP schema. It is now
clarified that a value of zero refers to untagged traffic.
Signed-off-by: Bruce Davie
---
vtep/vtep.xml | 7 +--
1 file changed, 5
Signed-off-by: Bruce Davie
---
ovn/northd/ovn-northd.8.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovn/northd/ovn-northd.8.xml b/ovn/northd/ovn-northd.8.xml
index 7954e22..743c939 100644
--- a/ovn/northd/ovn-northd.8.xml
+++ b/ovn/northd/ovn-northd.8.xml
@@ -36,7
Darrell,
Thanks for taking this on, we’ve known for a while that this should have been
cleaned up.
I have a few comments and questions.
First, who decides what mode a switch is in? In most, if not all fields,
either the VTEP or the controller is expected to write the value. In this case,
so
Good, sounds like we’re in sync. One other thing I noticed belatedly. The file
vtep.ovsschema has two entries for version:
line 3: "version": "1.1.0”,
and line 310: "version": “1.5.1"
I don’t think this is what we want. Line 3 should not have been added. And
since this modification adds a col
Darrell,
I don’t think you can handle the error of unsupported replication mode the way
it is described here:
+
+Indicates that the requested source node replication mode cannot be
+supported by the physical switch; this specifically means in this
+context that the
node
> as that was the only mode previously supported. Source node replication
> mode is optionally configurable and resetting the replication mode implicitly
> sets the replication mode back to a default of service node.
>
> Signed-off-by: Dar
replication mode is optionally
> configurable and clearing the replication mode implicitly sets the
> replication mode back to a default of service node. Signed-off-by: Darrell
> Ball
I’m happy with the latest version of the patch.
Acked-by: Bruce Davie
__
I'm happy with this.
Bruce
> On Oct 14, 2015, at 1:59 AM, Justin Pettit wrote:
>
> These fields don't need to be stored, and it causes a lot of unnecessary
> writes to the database log.
>
> This commit also fixes a couple of trivial indentation issues with
> previous ephemeral declarations.
>
vtep/vtep.xml : Tunnel table definitions were reviewed against
latest OVS schema.
Relevant changes taken into HW VTEP schema.
XML formatting of Tunnel table corrected
Signed-off-by: Ariel Tubaltsev http://openvswitch.org/mailman/listinfo/dev>>
Looks good to me.
Bruce
Yes.
Acked-by: Bruce Davie
> On Nov 19, 2015, at 1:58 PM, Russell Bryant wrote:
>
> On 11/16/2015 02:06 PM, Bruce Davie wrote:
>> vtep/vtep.xml : Tunnel table definitions were reviewed against
>> latest OVS schema.
>> Relevant changes taken into HW VTEP schema.
Looks fine to me.
Acked-by: Bruce Davie
> On Nov 20, 2015, at 2:09 PM, Ariel Tubaltsev wrote:
>
> We continue to review HW VTEP schema
> This patch contains only cosmetical changes, to separate it from
> semantical changes
>
> Signed-off-by: Ariel Tubaltsev
>
A number of new key-value pairs have been added to the bfd and bfd_status
columns of the OVS schema since the VTEP schema was created. To aid
interoperability between OVS instances and VTEPs, this patch brings
the VTEP schema into line with that of OVS.
Signed-off-by: Bruce Davie
---
vtep
s what the
+ remote endpoint's BFD session thinks is wrong
Looks like a missing period.
Would you like to update my vtep.xml patch with these improvements?
Bruce
On Oct 24, 2013, at 9:57 AM, Ben Pfaff wrote:
> On Thu, Oct 24, 2013 at 09:53:19AM -0700, Ben Pfaff wrote:
>&
his patch brings
> the VTEP schema into line with that of OVS.
>
> CC: Bruce Davie
> Signed-off-by: Ben Pfaff
> ---
> vtep/vtep.xml | 178 -
> 1 file changed, 127 insertions(+), 51 deletions(-)
>
> diff --git a/v
Add a "switch_fault" and "port_fault" column to the appropriate
tables in the VTEP schema.
Signed-off-by: Bruce Davie
---
vtep/vtep.ovsschema | 16
vtep/vtep.xml | 48 ++--
2 files changed, 58 insertions(+),
The processing for MPLS TTL is somewhat complex compared to IP, because there
are a few different options for what is acceptable when pushing and popping
labels. However, one thing that DOES carry forward straightforwardly from IP is
that if the TTL reaches zero, the packet MUST be discarded. Th
Add two new tables to the VTEP schema in support of distributed L3.
Each table contains MAC addresses to be used by VTEPs (both hardware
and software) when issuing ARP requests on behalf of a logical router.
Signed-off-by: Bruce Davie
---
vtep/vtep.ovsschema | 18 --
vtep
On Dec 16, 2013, at 9:28 AM, Ben Pfaff wrote:
> On Mon, Nov 25, 2013 at 08:19:50AM -0800, Bruce Davie wrote:
>> Add two new tables to the VTEP schema in support of distributed L3.
>> Each table contains MAC addresses to be used by VTEPs (both hardware
>> and software) when
In commit 53ffefe9 (ovsdb-client: Make "server" and "database"
arguments optional.), two errors were introduced. "list-columns"
appeared twice in the list of commands, the first instance should be
"list-tables". "monitor" command now lists
29 matches
Mail list logo
