Re: [ovs-dev] [PATCH net-next v2 0/2] openvswitch: remove unused code

2016-10-19 Thread David Miller
From: Jiri Benc Date: Wed, 19 Oct 2016 11:26:35 +0200 > Removed unused functions and unnecessary EXPORT_SYMBOLs from openvswitch. Series applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2 1/2] openvswitch: fix flow stats accounting when node 0 is not possible

2016-09-18 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Thu, 15 Sep 2016 19:11:52 -0300 > On a system with only node 1 as possible, all statistics is going to be > accounted on node 0 as it will have a single writer. > > However, when getting and clearing the statistics, node 0 is not going > to be considered

Re: [ovs-dev] [PATCH v2 2/2] openvswitch: use percpu flow stats

2016-09-18 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Thu, 15 Sep 2016 19:11:53 -0300 > Instead of using flow stats per NUMA node, use it per CPU. When using > megaflows, the stats lock can be a bottleneck in scalability. > > On a E5-2690 12-core system, usual throughput went from ~4Mpps to > ~15Mpps when f

Re: [ovs-dev] [PATCH net-next] openvswitch: avoid deferred execution of recirc actions

2016-09-15 Thread David Miller
From: Lance Richardson Date: Tue, 13 Sep 2016 10:08:54 -0400 > The ovs kernel data path currently defers the execution of all > recirc actions until stack utilization is at a minimum. > This is too limiting for some packet forwarding scenarios due to > the small size of the deferred action FIFO (

Re: [ovs-dev] [PATCH] openvswitch: use alias for genetlink family names

2016-09-10 Thread David Miller
From: Thadeu Lima de Souza Cascardo Date: Fri, 9 Sep 2016 17:42:30 -0300 > When userspace tries to create datapaths and the module is not loaded, > it will simply fail. With this patch, the module will be automatically > loaded. > > Signed-off-by: Thadeu Lima de Souza Cascardo Applied to net-

Re: [ovs-dev] [PATCH net-next v22 0/3] openvswitch: add 802.1ad support

2016-09-08 Thread David Miller
From: Eric Garver Date: Wed, 7 Sep 2016 12:56:56 -0400 > This series adds 802.1ad support to openvswitch. It is a continuation of the > work originally started by Thomas F Herbert - hence the large rev number. ... Series applied, thanks. ___ dev mail

Re: [ovs-dev] [PATCH v05 62/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

2016-08-22 Thread David Miller
From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:33:19 +0200 > Kernel uapi header are supposed to use them. Fixes userspace compile error: > > linux/openvswitch.h:583:2: error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli Applied. ___ de

Re: [ovs-dev] [PATCH v05 38/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

2016-08-22 Thread David Miller
From: Mikko Rapeli Date: Mon, 22 Aug 2016 20:32:55 +0200 > Fixes userspace compiler error: > > error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listi

Re: [ovs-dev] [PATCH v05 38/72] include/uapi/linux/openvswitch.h: use __u32 from linux/types.h

2016-08-22 Thread David Miller
From: Stephen Hemminger Date: Mon, 22 Aug 2016 12:39:38 -0700 > This is a a real issue, but being buried in a huge patch series of include > file stuff I don't think anyone would see it. It hit netdev and thus patchwork, therefore anyone watching networking patches saw it. I would not call it b

Re: [ovs-dev] [RFC PATCH] openvswitch: use percpu flow stats

2016-08-19 Thread David Miller
From: Eric Dumazet Date: Fri, 19 Aug 2016 12:56:56 -0700 > On Fri, 2016-08-19 at 16:47 -0300, Thadeu Lima de Souza Cascardo wrote: >> Instead of using flow stats per NUMA node, use it per CPU. When using >> megaflows, the stats lock can be a bottleneck in scalability. > > ... > >> >> flo

Re: [ovs-dev] [PATCH] openvswitch: do not ignore netdev errors when creating tunnel vports

2016-08-10 Thread David Miller
From: Martynas Pumputis Date: Tue, 9 Aug 2016 16:24:50 +0100 > The creation of a tunnel vport (geneve, gre, vxlan) brings up a > corresponding netdev, a multi-step operation which can fail. > > For example, changing a vxlan vport's netdev state to 'up' binds the > vport's socket to a UDP port -

Re: [ovs-dev] [PATCH net v2] openvswitch: fix conntrack netlink event delivery

2016-06-29 Thread David Miller
From: Samuel Gauthier Date: Tue, 28 Jun 2016 17:22:26 +0200 > Only the first and last netlink message for a particular conntrack are > actually sent. The first message is sent through nf_conntrack_confirm when > the conntrack is committed. The last one is sent when the conntrack is > destroyed on

Re: [ovs-dev] [PATCH net-next v2] taskstats: fix nl parsing in accounting/getdelays.c

2016-04-27 Thread David Miller
From: Nicolas Dichtel Date: Wed, 27 Apr 2016 17:53:08 +0200 > The type TASKSTATS_TYPE_NULL should always be ignored. > > When jumping to the next attribute, only the length of the current > attribute should be added, not the length of all nested attributes. > This last bug was not visible before

Re: [ovs-dev] [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3)

2016-04-26 Thread David Miller
From: Lars Ellenberg Date: Tue, 26 Apr 2016 13:54:27 +0200 > On Tue, Apr 26, 2016 at 10:06:10AM +0200, Nicolas Dichtel wrote: >> >> This is the continuation (series #3) of the work done to align netlink >> attributes when these attributes contain some 64-bit fields. >> >> It's the last patchset

Re: [ovs-dev] [PATCH net-next 3/8] fs/quota: use nla_put_u64_64bit()

2016-04-26 Thread David Miller
From: Jan Kara Date: Tue, 26 Apr 2016 13:08:48 +0200 > On Tue 26-04-16 10:06:13, Nicolas Dichtel wrote: >> Signed-off-by: Nicolas Dichtel > > OK, so I somewhat miss a description of what will this do to the netlink > message so that I can judge whether the change is fine for the userspace > cou

Re: [ovs-dev] [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3)

2016-04-26 Thread David Miller
From: Nicolas Dichtel Date: Tue, 26 Apr 2016 10:06:10 +0200 > The last user of nla_put_u64() is block/drbd. This module does not use > standard netlink API (see all the stuff in include/linux/genl_magic_struct.h > and include/linux/genl_magic_func.h). Yet another example where doing things in a

Re: [ovs-dev] [PATCH net-next 0/9] netlink: align attributes when needed (patchset #1)

2016-04-23 Thread David Miller
From: Nicolas Dichtel Date: Fri, 22 Apr 2016 17:31:15 +0200 > This is the continuation of the work done to align netlink attributes > when these attributes contain some 64-bit fields. > > David, if the third patch is too big (or maybe the series), I can split it. > Just tell me what you prefer.

Re: [ovs-dev] [PATCH net] openvswitch: use flow protocol when recalculating ipv6 checksums

2016-04-21 Thread David Miller
From: Simon Horman Date: Thu, 21 Apr 2016 11:49:15 +1000 > When using masked actions the ipv6_proto field of an action > to set IPv6 fields may be zero rather than the prevailing protocol > which will result in skipping checksum recalculation. > > This patch resolves the problem by relying on th

Re: [ovs-dev] [PATCH] openvswitch: Use proper buffer size in nla_memcpy

2016-03-28 Thread David Miller
From: Haishuang Yan Date: Mon, 28 Mar 2016 18:08:59 +0800 > For the input parameter count, it's better to use the size > of destination buffer size, as nla_memcpy would take into > account the length of the source netlink attribute when > a data is copied from an attribute. > > Signed-off-by: Ha

Re: [ovs-dev] [PATCH v2] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread David Miller
From: Arnd Bergmann Date: Fri, 18 Mar 2016 14:33:45 +0100 > The openvswitch code has gained support for calling into the > nf-nat-ipv4/ipv6 modules, however those can be loadable modules > in a configuration in which openvswitch is built-in, leading > to link errors: > > net/built-in.o: In funct

Re: [ovs-dev] [net] openvswitch: Allow deferred action fifo to expand during run time

2016-03-19 Thread David Miller
From: Andy Zhou Date: Thu, 17 Mar 2016 21:32:13 -0700 > Current openvswitch implementation allows up to 10 recirculation actions > for each packet. This limit was sufficient for most use cases in the > past, but with more new features, such as supporting connection > tracking, and testing in larg

Re: [ovs-dev] [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static

2016-03-19 Thread David Miller
From: kbuild test robot Date: Sat, 19 Mar 2016 00:54:50 +0800 > Signed-off-by: Fengguang Wu Looks good, applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread David Miller
From: Samuel Gauthier Date: Wed, 16 Mar 2016 16:07:50 +0100 > This patchset adds a netlink api to refresh an existing flow in > openvswitch. This is too late for net-next, please resubmit this after the merge window. Thanks. ___ dev mailing list dev@o

Re: [ovs-dev] [PATCH net-next repost] openvswitch: allow output of MPLS packets on tunnel vports

2016-03-18 Thread David Miller
From: Simon Horman Date: Tue, 15 Mar 2016 12:00:35 +0900 > Currently output of MPLS packets on tunnel vports is not allowed by Open > vSwitch. This is because historically encapsulation was done in such a way > that the inner_protocol field of the skb needed to hold the inner protocol > for both

Re: [ovs-dev] [PATCH v2 net-next] ovs: allow nl 'flow set' to use ufid without flow key

2016-03-13 Thread David Miller
From: Samuel Gauthier Date: Thu, 10 Mar 2016 17:14:59 +0100 > When we want to change a flow using netlink, we have to identify it to > be able to perform a lookup. Both the flow key and unique flow ID > (ufid) are valid identifiers, but we always have to specify the flow > key in the netlink mess

Re: [ovs-dev] [PATCH net v2 2/3] geneve: Relax MTU constraints

2016-02-18 Thread David Miller
From: David Wragg Date: Thu, 18 Feb 2016 16:54:14 + > Tom Herbert writes: >> Please implement like in ip_tunnel_change_mtu (or better yet call it), >> that is the precedent for tunnels. > > I've made geneve_change_mtu follow ip_tunnel_change_mtu in v2. > > If it were to call it instead, ar

Re: [ovs-dev] [PATCH net v3 0/3] Set a large MTU on ovs-created tunnel devices

2016-02-10 Thread David Miller
From: David Wragg Date: Wed, 10 Feb 2016 00:05:54 + > Prior to 4.3, openvswitch tunnel vports (vxlan, gre and geneve) could > transmit vxlan packets of any size, constrained only by the ability to > send out the resulting packets. 4.3 introduced netdevs corresponding > to tunnel vports. The

Re: [ovs-dev] [PATCH v2] net: preserve IP control block during GSO segmentation

2016-01-15 Thread David Miller
From: Florian Westphal Date: Thu, 14 Jan 2016 00:36:28 +0100 > David Miller wrote: >> From: Konstantin Khlebnikov >> Date: Fri, 08 Jan 2016 15:21:46 +0300 >> >> > Skb_gso_segment() uses skb control block during segmentation. >> > This patch adds 32-byte

Re: [ovs-dev] [PATCH v2] net: preserve IP control block during GSO segmentation

2016-01-13 Thread David Miller
From: Konstantin Khlebnikov Date: Fri, 08 Jan 2016 15:21:46 +0300 > Skb_gso_segment() uses skb control block during segmentation. > This patch adds 32-bytes room for previous control block which > will be copied into all resulting segments. > > This patch fixes kernel crash during fragmenting fo

Re: [ovs-dev] [PATCH] Openvswitch: actions.c: Removed line over 80 characters and not necessary braces.

2016-01-12 Thread David Miller
It is not appropriate to submit net-next changes at this time. If you wish to contribute to the networking kernel code, you should read the netdev mailing lists, and read important announcements such as this: http://marc.info/?l=linux-netdev&m=145248145925834&w=2 THanks. ___

Re: [ovs-dev] [PATCH] Removed: missing blank after decaration, line over 80 characters.

2016-01-11 Thread David Miller
There is no way I am applying any of these patches. Improper Subject: prefixes, entire commit messages in the Subject line, etc. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net-next v6 0/7] openvswitch: NAT support.

2016-01-11 Thread David Miller
From: Pablo Neira Ayuso Date: Mon, 11 Jan 2016 19:50:33 +0100 > On Fri, Jan 08, 2016 at 10:29:53AM -0800, Jarno Rajahalme wrote: >> This series adds NAT support to openvswitch kernel module. A few >> changes are needed to the netfilter code to facilitate this (patches >> 1-2/8). Patches 3-6 mak

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread David Miller
From: David Wragg Date: Thu, 07 Jan 2016 23:42:52 + > I'm willing to follow up on Jesse's request to look into the other > tunnel types too, but at the moment I'm wondering what the chances are > that the resulting submission would get accepted. I'm ok with these fixes if you look into Jesse

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-07 Thread David Miller
From: David Wragg Date: Wed, 06 Jan 2016 23:25:56 + > Considering non-openvswitch scenarios, when using vxlan netdevs > directly, a vxlan netdev locked to an underlying device supporting jumbo > frames can use a larger MTU. It's only vxlan netdevs without an > underlying device that have the

Re: [ovs-dev] [PATCH net 0/2] vxlan: Set a large MTU on ovs-created vxlan devices

2016-01-06 Thread David Miller
From: David Wragg Date: Wed, 6 Jan 2016 13:33:04 + > Prior to 4.3, openvswitch vxlan vports could transmit vxlan packets of > any size, constrained only by the ability to transmit the resulting > UDP packets. 4.3 introduced vxlan netdevs corresponding to vxlan > vports. These netdevs have

Re: [ovs-dev] [PATCH net] openvswitch: correct encoding of set tunnel action attributes

2015-12-18 Thread David Miller
From: Simon Horman Date: Fri, 18 Dec 2015 19:43:15 +0900 > In a set action tunnel attributes should be encoded in a > nested action. > > I noticed this because ovs-dpctl was reporting an error > when dumping flows due to the incorrect encoding of tunnel attributes > in a set action. > > Fixes:

Re: [ovs-dev] [PATCH net] openvswitch: fix trivial comment typo

2015-12-14 Thread David Miller
From: Paolo Abeni Date: Mon, 14 Dec 2015 14:29:58 +0100 > The commit 33db4125ec74 ("openvswitch: Rename LABEL->LABELS") left > over an old OVS_CT_ATTR_LABEL instance, fix it. > > Fixes: 33db4125ec74 ("openvswitch: Rename LABEL->LABELS") > Signed-off-by: Paolo Abeni Applied, thanks. ___

Re: [ovs-dev] [PATCH net] openvswitch: fix hangup on vxlan/gre/geneve device deletion

2015-12-03 Thread David Miller
From: Paolo Abeni Date: Tue, 1 Dec 2015 18:33:36 +0100 > Each openvswitch tunnel vport (vxlan,gre,geneve) holds a reference > to the underlying tunnel device, but never released it when such > device is deleted. > Deleting the underlying device via the ip tool cause the kernel to > hangup in the

Re: [ovs-dev] [PATCH net v3] openvswitch: Allocate memory for ovs internal device stats.

2015-10-21 Thread David Miller
From: James Morse Date: Mon, 19 Oct 2015 16:31:55 +0100 > "openvswitch: Remove vport stats" removed the per-vport statistics, in > order to use the netdev's statistics fields. > "openvswitch: Fix ovs_vport_get_stats()" fixed the export of these stats > to user-space, by using the provided netdev_

Re: [ovs-dev] [PATCH net-next v3 0/2] openvswitch: add IPv6 tunneling support

2015-10-07 Thread David Miller
From: Jiri Benc Date: Mon, 5 Oct 2015 13:09:45 +0200 > This builds on the previous work that added IPv6 support to lwtunnels and > adds IPv6 tunneling support to ovs. > > To use IPv6 tunneling, there needs to be a metadata based tunnel net_device > created and added to the ovs bridge. Currently

Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node

2015-10-05 Thread David Miller
From: Konstantin Khlebnikov Date: Fri, 02 Oct 2015 13:18:22 +0300 > When openvswitch tries allocate memory from offline numa node 0: > stats = kmem_cache_alloc_node(flow_stats_cache, GFP_KERNEL | __GFP_ZERO, 0) > It catches VM_BUG_ON(nid < 0 || nid >= MAX_NUMNODES || !node_online(nid)) > [ replac

Re: [ovs-dev] [PATCH v2] openvswitch: retain parsed IPv6 header fields in flow on error skipping extension headers

2015-08-29 Thread David Miller
From: Simon Horman Date: Sat, 29 Aug 2015 09:02:21 +0900 > When an error occurs skipping IPv6 extension headers retain the already > parsed IP protocol and IPv6 addresses in the flow. Also assume that the > packet is not a fragment in the absence of information to the contrary; > that is always u

Re: [ovs-dev] [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-10 Thread David Miller
From: Glenn Griffin Date: Mon, 10 Aug 2015 10:43:16 -0700 > On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote: >> From: Glenn Griffin >> Date: Mon, 3 Aug 2015 09:56:54 -0700 >> >> > openvswitch modifies the L4 checksum of a packet when modifying &

Re: [ovs-dev] [PATCH net-next v3] openvswitch: Make 100 percents packets sampled when sampling rate is 1.

2015-08-07 Thread David Miller
From: Wenyu Zhang Date: Wed, 5 Aug 2015 00:30:47 -0700 > When sampling rate is 1, the sampling probability is UINT32_MAX. The packet > should be sampled even the prandom32() generate the number of UINT32_MAX. > And none packet need be sampled when the probability is 0. > > Signed-off-by: Wenyu Z

Re: [ovs-dev] [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments

2015-08-03 Thread David Miller
From: Glenn Griffin Date: Mon, 3 Aug 2015 09:56:54 -0700 > openvswitch modifies the L4 checksum of a packet when modifying > the ip address. When an IP packet is fragmented only the first > fragment contains an L4 header and checksum. Prior to this change > openvswitch would modify all fragments,

Re: [ovs-dev] [PATCH net-next] openvswitch: Re-add CONFIG_OPENVSWITCH_VXLAN

2015-07-29 Thread David Miller
From: Thomas Graf Date: Wed, 29 Jul 2015 13:52:06 +0200 > This readds the config option CONFIG_OPENVSWITCH_VXLAN to avoid a > hard dependency of OVS on VXLAN. It moves the VXLAN config compat > code to vport-vxlan.c and allows compliation as a module. > > Fixes: 614732eaa12d ("openvswitch: Use r

Re: [ovs-dev] [PATCH net-next V12 2/3] Check for vlan ethernet types for 8021.q or 802.1ad

2015-07-27 Thread David Miller
From: Thomas F Herbert Date: Sun, 26 Jul 2015 10:52:34 -0400 > Signed-off-by: Thomas F Herbert > --- > include/linux/if_vlan.h | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h > index 67ce5bd..88d1be4 100644 > --- a/i

Re: [ovs-dev] [PATCH net-next] openvswitch: Retrieve tunnel metadata when receiving from vport-netdev

2015-07-26 Thread David Miller
From: Thomas Graf Date: Thu, 23 Jul 2015 13:04:44 +0200 > Retrieve the tunnel metadata for packets received by a net_device and > provide it to ovs_vport_receive() for flow key extraction. > > [This hunk was in the GRE patch in the initial series and missed the > cut for the initial submission

Re: [ovs-dev] [PATCH net-next] openvswitch: fix compilation when vxlan is a module

2015-07-26 Thread David Miller
From: Nicolas Dichtel Date: Thu, 23 Jul 2015 11:29:07 +0200 > With CONFIG_VXLAN=m and CONFIG_OPENVSWITCH=y, there was the following > compilation error: > LD init/built-in.o > net/built-in.o: In function `vxlan_tnl_create': > .../net/openvswitch/vport-netdev.c:322: undefined reference

Re: [ovs-dev] [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread David Miller
From: Chris J Arges Date: Tue, 21 Jul 2015 12:36:33 -0500 > Some architectures like POWER can have a NUMA node_possible_map that > contains sparse entries. This causes memory corruption with openvswitch > since it allocates flow_cache with a multiple of num_possible_nodes() and > assumes the node

Re: [ovs-dev] [PATCH net-next 00/22 v2] Lightweight & flow based encapsulation

2015-07-21 Thread David Miller
From: Thomas Graf Date: Tue, 21 Jul 2015 10:43:44 +0200 > This series combines the work previously posted by Roopa, Robert and > myself. It's according to what we discussed at NFWS. The motivation > of this series is to: > > * Consolidate code between OVS and the rest of the kernel and get >

Re: [ovs-dev] [PATCH net] openvswitch: disable LRO unless stated otherwise

2015-05-27 Thread David Miller
From: Flavio Leitner Date: Wed, 27 May 2015 10:24:14 -0300 > On Wed, May 27, 2015 at 10:50:21AM +0200, Jiri Benc wrote: >> On Tue, 26 May 2015 15:03:56 -0700, Pravin Shelar wrote: >> > OVS interface for generic networking device operation looks odd. have >> > you considered adding new device ioct

Re: [ovs-dev] [PATCH net-next V7 0/2] openvswitch: Add support for 802.1AD

2015-04-26 Thread David Miller
net-next is not open at this time, please resubmit this when the net-next tree is open for submissions again, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net] openvswitch: Return vport module ref before destruction

2015-03-31 Thread David Miller
From: Thomas Graf Date: Mon, 30 Mar 2015 13:57:41 +0200 > Return module reference before invoking the respective vport > ->destroy() function. This is needed as ovs_vport_del() is not > invoked inside an RCU read side critical section so the kfree > can occur immediately before returning to ovs_v

Re: [ovs-dev] OVS Offload Decision Proposal

2015-03-05 Thread David Miller
I find it funny that we haven't even got a L3 forwarding implementation fleshed out enough to merge into the tree, and people are talking about VOIP to VLAN classification, hw bug workarounds, and shit like that. Everyone is really jumping the gun on all of this. Nobody knows what we will need,

Re: [ovs-dev] OVS Offload Decision Proposal

2015-03-04 Thread David Miller
From: Tom Herbert Date: Wed, 4 Mar 2015 21:20:41 -0800 > On Wed, Mar 4, 2015 at 9:00 PM, David Miller wrote: >> From: John Fastabend >> Date: Wed, 04 Mar 2015 17:54:54 -0800 >> >>> I think a set operation _is_ necessary for OVS and other >>> applicat

Re: [ovs-dev] OVS Offload Decision Proposal

2015-03-04 Thread David Miller
From: John Fastabend Date: Wed, 04 Mar 2015 17:54:54 -0800 > I think a set operation _is_ necessary for OVS and other > applications that run in user space. It's necessary for the kernel to internally manage the chip flow resources. Full stop. It's not being exported to userspace. That is exa

Re: [ovs-dev] [PATCH][3.13.y-ckt][PATCH 0/1] Backport of mainline commit 4a46b24e for upstream 3.13.y-ckt.

2015-02-27 Thread David Miller
Please line wrap your email to ~80 columns, it was totally unreadable in my plain text email client. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net] openvswitch: Fix net exit.

2015-02-20 Thread David Miller
From: Pravin B Shelar Date: Tue, 17 Feb 2015 11:23:10 -0800 > Open vSwitch allows moving internal vport to different namespace > while still connected to the bridge. But when namespace deleted > OVS does not detach these vports, that results in dangling > pointer to netdevice which causes kernel

Re: [ovs-dev] [PATCH v3] net: openvswitch: Support masked set actions.

2015-02-11 Thread David Miller
From: Jarno Rajahalme Date: Thu, 5 Feb 2015 13:40:49 -0800 > OVS userspace already probes the openvswitch kernel module for > OVS_ACTION_ATTR_SET_MASKED support. This patch adds the kernel module > implementation of masked set actions. > > The existing set action sets many fields at once. Whe

Re: [ovs-dev] [PATCH] openvswitch: Add missing initialization in validate_and_copy_set_tun()

2015-02-11 Thread David Miller
From: Geert Uytterhoeven Date: Wed, 11 Feb 2015 11:23:38 +0100 > net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’: > net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized > in this function > > If ipv4_tun_from_nlattr() returns a different positive

Re: [ovs-dev] [PATCH net-next] openvswitch: Add support for checksums on UDP tunnels.

2015-01-28 Thread David Miller
From: Jesse Gross Date: Wed, 28 Jan 2015 16:32:46 -0800 > Currently, it isn't possible to request checksums on the outer UDP > header of tunnels - the TUNNEL_CSUM flag is ignored. This adds > support for requesting that UDP checksums be computed on transmit > and properly reported if they are pre

Re: [ovs-dev] [PATCH net-next v14 0/5] openvswitch: Introduce 128-bit unique flow identifiers.

2015-01-26 Thread David Miller
From: Joe Stringer Date: Wed, 21 Jan 2015 16:42:47 -0800 > This series extends the openvswitch datapath interface for flow commands to > use > 128-bit unique identifiers as an alternative to the netlink-formatted flow > key. > This significantly reduces the cost of assembling messages between t

Re: [ovs-dev] [PATCH 0/5 net-next v6] VXLAN Group Policy Extension

2015-01-14 Thread David Miller
From: Thomas Graf Date: Thu, 15 Jan 2015 03:53:54 +0100 > Implements supports for the Group Policy VXLAN extension [0] to provide > a lightweight and simple security label mechanism across network peers > based on VXLAN. The security context and associated metadata is mapped > to/from skb->mark.

Re: [ovs-dev] [PATCH net] openvswitch: packet messages need their own probe attribtue

2015-01-14 Thread David Miller
From: Thomas Graf Date: Wed, 14 Jan 2015 13:56:19 + > User space is currently sending a OVS_FLOW_ATTR_PROBE for both flow > and packet messages. This leads to an out-of-bounds access in > ovs_packet_cmd_execute() because OVS_FLOW_ATTR_PROBE > > OVS_PACKET_ATTR_MAX. > > Introduce a new OVS_PA

Re: [ovs-dev] [PATCHv3 net-next] openvswitch: Introduce ovs_tunnel_route_lookup

2015-01-14 Thread David Miller
aFrom: Fan Du Date: Wed, 14 Jan 2015 13:10:35 +0800 > Introduce ovs_tunnel_route_lookup to consolidate route lookup > shared by vxlan, gre, and geneve ports. > > Signed-off-by: Fan Du Applied. ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [PATCH 0/5 net-next v4] VXLAN Group Policy Extension

2015-01-14 Thread David Miller
From: Thomas Graf Date: Tue, 13 Jan 2015 17:20:41 +0100 > Implements supports for the Group Policy VXLAN extension [0] to provide > a lightweight and simple security label mechanism across network peers > based on VXLAN. The security context and associated metadata is mapped > to/from skb->mark.

Re: [ovs-dev] [PATCH 1/1 net-next] openvswitch: Remove unnecessary version.h inclusion

2015-01-13 Thread David Miller
From: Syam Sidhardhan Date: Mon, 12 Jan 2015 20:49:35 +0530 > version.h inclusion is not necessary as detected by versioncheck. > > Signed-off-by: Syam Sidhardhan > Acked-by: Pravin B Shelar > --- > No code changes. Add net-next prefix flag for net-next tree. Applied, thanks.

Re: [ovs-dev] [PATCH 2/6] vxlan: Group Policy extension

2015-01-12 Thread David Miller
Can you PLEASE, PLEASE, not quote and entire full patch just to add two lines of commentary. Quote _only_ the _RELEVANT_ portions of the email you are replying to. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net] openvswitch: Consistently include VLAN header in flow and port stats.

2015-01-02 Thread David Miller
From: Ben Pfaff Date: Wed, 31 Dec 2014 08:45:46 -0800 > Until now, when VLAN acceleration was in use, the bytes of the VLAN header > were not included in port or flow byte counters. They were however > included when VLAN acceleration was not used. This commit corrects the > inconsistency, by al

Re: [ovs-dev] [PATCH] openvswitch: fix odd_ptr_err.cocci warnings

2014-12-24 Thread David Miller
From: Pravin Shelar Date: Wed, 24 Dec 2014 10:49:22 -0800 > On Tue, Dec 23, 2014 at 10:41 PM, kbuild test robot > wrote: >> net/openvswitch/vport-gre.c:188:5-11: inconsistent IS_ERR and PTR_ERR, >> PTR_ERR on line 189 >> >> PTR_ERR should access the value just tested by IS_ERR >> >> Semantic p

Re: [ovs-dev] [PATCH] net: openvswitch: Support masked set actions.

2014-12-10 Thread David Miller
From: Jarno Rajahalme Date: Tue, 9 Dec 2014 16:10:25 -0800 > OVS userspace already probes the openvswitch kernel module for > OVS_ACTION_ATTR_SET_MASKED support. This patch adds the kernel module > implementation of masked set actions. > > The existing set action sets many fields at once. Whe

Re: [ovs-dev] [PATCH net-next] openvswitch: set correct protocol on route lookup

2014-12-09 Thread David Miller
From: Jiri Benc Date: Fri, 5 Dec 2014 17:24:28 +0100 > Respect what the caller passed to ovs_tunnel_get_egress_info. > > Fixes: 8f0aad6f35f7e ("openvswitch: Extend packet attribute for egress tunnel > info") > Signed-off-by: Jiri Benc Applied, thanks.

Re: [ovs-dev] [PATCHv11 net-next 2/2] openvswitch: Add support for unique flow IDs.

2014-12-09 Thread David Miller
Please do not quote an entire patch just to add some simple feedback or signoff/ack. That means someone has to scroll past the entire patch in patchwork or the mailing list archives, unnecessarily. This is one of my largest pet peeves, please do not do this. Thanks.

Re: [ovs-dev] [PATCHv3 net] openvswitch: Don't validate IPv6 label masks.

2014-11-21 Thread David Miller
From: Joe Stringer Date: Wed, 19 Nov 2014 13:54:49 -0800 > When userspace doesn't provide a mask, OVS datapath generates a fully > unwildcarded mask for the flow by copying the flow and setting all bits > in all fields. For IPv6 label, this creates a mask that matches on the > upper 12 bits, caus

Re: [ovs-dev] [PATCH net] openvswitch: Fix mask generation for IPv6 labels.

2014-11-19 Thread David Miller
From: Joe Stringer Date: Tue, 18 Nov 2014 10:54:17 -0800 > When userspace doesn't provide a mask, OVS datapath generates a fully > unwildcarded mask for the flow. This is done by taking a copy of the > flow key, then iterating across its attributes, setting all values to > 0xff. This works for mo

Re: [ovs-dev] [PATCH 1/1 net-next] openvswitch: use PTR_ERR_OR_ZERO

2014-11-16 Thread David Miller
From: Fabian Frederick Date: Fri, 14 Nov 2014 19:32:58 +0100 > Signed-off-by: Fabian Frederick Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] ovs: Turn vports with dependencies into separate modules

2014-10-28 Thread David Miller
From: Alexei Starovoitov Date: Tue, 28 Oct 2014 13:57:13 -0700 > On Tue, Oct 28, 2014 at 11:43 AM, David Miller wrote: >> From: Thomas Graf >> Date: Wed, 22 Oct 2014 17:29:06 +0200 >> >>> The internal and netdev vport remain part of openvswitch.ko. Encap >&g

Re: [ovs-dev] [PATCH net-next] datapath: Rename last_action() as nla_is_last() and move to netlink.h

2014-10-28 Thread David Miller
From: Simon Horman Date: Mon, 27 Oct 2014 16:12:16 +0900 > The original motivation for this change was to allow the helper to be used > in files other than actions.c as part of work on an odp select group > action. > > It was as pointed out by Thomas Graf that this helper would be best off > liv

Re: [ovs-dev] [PATCH] ovs: Turn vports with dependencies into separate modules

2014-10-28 Thread David Miller
From: Thomas Graf Date: Wed, 22 Oct 2014 17:29:06 +0200 > The internal and netdev vport remain part of openvswitch.ko. Encap > vports including vxlan, gre, and geneve can be built as separate > modules and are loaded on demand. Modules can be unloaded after use. > Datapath ports keep a reference

Re: [ovs-dev] [PATCH] ovs: Turn vports with dependencies into separate modules

2014-10-27 Thread David Miller
From: Pravin Shelar Date: Mon, 27 Oct 2014 17:27:11 -0700 > On Mon, Oct 27, 2014 at 2:47 PM, Thomas Graf wrote: >> The patch also brings additional flexibility to users of >> distributions. Distros typically ship something like an allmodconfig >> so a user can either run openvswitch.ko with all

Re: [ovs-dev] [PATCH 1/1 net-next] openvswitch: use vport instead of p

2014-10-15 Thread David Miller
From: Fabian Frederick Date: Wed, 15 Oct 2014 21:03:41 +0200 > All functions used struct vport *vport except > ovs_vport_find_upcall_portid. > > This fixes 1 kerneldoc warning > > Signed-off-by: Fabian Frederick Applied. ___ dev mailing list dev@ope

Re: [ovs-dev] [PATCH 1/1 net-next] openvswitch: kerneldoc warning fix

2014-10-15 Thread David Miller
From: Fabian Frederick Date: Wed, 15 Oct 2014 21:03:18 +0200 > s/sock/gs > > Signed-off-by: Fabian Frederick Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/1 net-next] openvswitch: kerneldoc warning fix

2014-10-15 Thread David Miller
Pravin could you please review these two openvswitch kerneldoc fixes from Fabian? Thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH net v2 2/2] openvswitch: restore OVS_FLOW_CMD_NEW notifications

2014-09-19 Thread David Miller
From: Nicolas Dichtel Date: Thu, 18 Sep 2014 10:31:04 +0200 > From: Samuel Gauthier > > Since commit fb5d1e9e127a ("openvswitch: Build flow cmd netlink reply only if > needed."), > the new flows are not notified to the listeners of OVS_FLOW_MCGROUP. > > This commit fixes the problem by using

Re: [ovs-dev] [PATCH net v2 1/2] genetlink: add function genl_has_listeners()

2014-09-19 Thread David Miller
From: Nicolas Dichtel Date: Thu, 18 Sep 2014 10:31:03 +0200 > This function is the counterpart of the function netlink_has_listeners(). > > Signed-off-by: Nicolas Dichtel Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailma

Re: [ovs-dev] [PATCH] net/openvswitch/flow.c: Replace rcu_dereference() with rcu_access_pointer()

2014-08-22 Thread David Miller
From: Andreea-Cristina Bernat Date: Sun, 17 Aug 2014 16:29:43 +0300 > The "rcu_dereference()" call is used directly in a condition. > Since its return value is never dereferenced it is recommended to use > "rcu_access_pointer()" instead of "rcu_dereference()". > Therefore, this patch makes the re

Re: [ovs-dev] [PATCH net] openvswitch: fix panic with multiple vlan headers

2014-08-22 Thread David Miller
From: Jiri Benc Date: Thu, 21 Aug 2014 21:33:44 +0200 > When there are multiple vlan headers present in a received frame, the first > one is put into vlan_tci and protocol is set to ETH_P_8021Q. Anything in the > skb beyond the VLAN TPID may be still non-linear, including the inner TCI > and ethe

Re: [ovs-dev] [PATCH] openvswitch: Fix memory leak in ovs_vport_alloc() error path

2014-08-12 Thread David Miller
From: Christoph Jaeger Date: Tue, 12 Aug 2014 09:27:57 +0200 > ovs_vport_alloc() bails out without freeing the memory 'vport' points to. > > Picked up by Coverity - CID 1230503. > > Fixes: 5cd667b0a4 ("openvswitch: Allow each vport to have an array of > 'port_id's.") > Signed-off-by: Christoph

Re: [ovs-dev] [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-08-04 Thread David Miller
From: Eric Dumazet Date: Tue, 05 Aug 2014 07:50:07 +0200 > [PATCH net-next] netlink: fix lockdep splats > > With netlink_lookup() conversion to RCU, we need to use appropriate > rcu dereference in netlink_seq_socket_idx() & netlink_seq_next() > > Reported-by: Sasha Levin > Signed-off-by: Eric

Re: [ovs-dev] [PATCH net-next 2/3] netlink: Convert netlink_lookup() to use RCU protected hash table

2014-08-04 Thread David Miller
From: Sasha Levin Date: Mon, 04 Aug 2014 22:10:19 -0400 > On 08/02/2014 05:47 AM, Thomas Graf wrote: >> static void *netlink_seq_start(struct seq_file *seq, loff_t *pos) >> -__acquires(nl_table_lock) >> { >> -read_lock(&nl_table_lock); >> +rcu_read_lock(); >> return *pos ? netl

Re: [ovs-dev] [PATCH net-next v5 0/3] Lockless netlink_lookup() with new concurrent hash table

2014-08-02 Thread David Miller
From: Thomas Graf Date: Sat, 2 Aug 2014 11:47:43 +0200 > Netlink sockets are maintained in a hash table to allow efficient lookup > via the port ID for unicast messages. However, lookups currently require > a read lock to be taken. This series adds a new generic, resizable, > scalable, concurren

Re: [ovs-dev] [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new concurrent hash table

2014-07-31 Thread David Miller
From: David Miller Date: Thu, 31 Jul 2014 22:39:46 -0700 (PDT) > Looks great, series applied, thanks! Actually, this needs more work, reverted: net/netfilter/nft_hash.c: In function ‘nft_hash_destroy’: net/netfilter/nft_hash.c:183:3: error: ‘ht’ undeclared (first use in this function)

Re: [ovs-dev] [PATCH v2 0/3 net-next] Lockless netlink_lookup() with new concurrent hash table

2014-07-31 Thread David Miller
From: Thomas Graf Date: Fri, 1 Aug 2014 00:56:00 +0200 > Netlink sockets are maintained in a hash table to allow efficient lookup > via the port ID for unicast messages. However, lookups currently require > a read lock to be taken. This series adds a new generic, resizable, > scalable, concurren

Re: [ovs-dev] [PATCH 0/2 net-next] Lockless netlink_lookup() with new concurrent hash table

2014-07-30 Thread David Miller
From: Thomas Graf Date: Tue, 29 Jul 2014 13:41:31 +0200 > Netlink sockets are maintained in a hash table to allow efficient lookup > via the port ID for unicast messages. However, lookups currently require > a read lock to be taken. This series adds a new generic, resizable, > scalable, concurren

Re: [ovs-dev] [PATCH net-next] net: Remove unlikely() for WARN_ON() conditions

2014-07-30 Thread David Miller
From: Thomas Graf Date: Wed, 30 Jul 2014 02:31:08 +0200 > No need for the unlikely(), WARN_ON() and BUG_ON() internally use > unlikely() on the condition. > > Signed-off-by: Thomas Graf Applied, thanks. ___ dev mailing list dev@openvswitch.org http:/

Re: [ovs-dev] [PATCH] openvswitch: Use IS_ERR_OR_NULL

2014-07-29 Thread David Miller
From: Himangi Saraogi Date: Sun, 27 Jul 2014 12:37:46 +0530 > This patch introduces the use of the macro IS_ERR_OR_NULL in place of > tests for NULL and IS_ERR. > > The following Coccinelle semantic patch was used for making the change: > > @@ > expression e; > @@ > > - e == NULL || IS_ERR(e)

Re: [ovs-dev] [PATCH net-next] openvswitch: make generic netlink group const

2014-07-16 Thread David Miller
From: Stephen Hemminger Date: Wed, 16 Jul 2014 11:25:52 -0700 > Generic netlink tables can be const. > > Signed-off-by: Stephen Hemminger Applied, thanks Stephen. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [GIT net] Open vSwitch

2014-07-07 Thread David Miller
From: Pravin B Shelar Date: Mon, 30 Jun 2014 23:33:16 -0700 > A set of fixes for net. > First bug is related flow-table management. Second one is in sample > action. Third is related flow stats and last one add gre-err handler for ovs. Pulled, thanks Pravin.

Re: [ovs-dev] [PATCH v2.62] datapath: Add basic MPLS support to kernel

2014-06-24 Thread David Miller
From: Jesse Gross Date: Tue, 24 Jun 2014 16:24:37 -0700 > Applied, thanks for all your work. Time to break out the champagne :) Congrats, what an amazing journey :-) ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

  1   2   3   >