Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 20:42, Mickey Spiegel wrote: > On Thu, Nov 3, 2016 at 6:06 PM, Guru Shetty wrote: > > > > >> > 2. If a stateful action such as DNAT or LB is taken on a >> > gateway router, such that it is necessary for the reverse >> > pa

Re: [ovs-dev] [PATCH 4/5 v2] datapath-windows: clean code in geneve

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 16:27, Sairam Venugopal wrote: > Acked-by: Sairam Venugopal > Applied the first 4 patches of the series. Thanks! > > > On 10/27/16, 11:57 AM, "Alin Serdean" > wrote: > > >The purpose of this patch is to make the code more readable and > >fix a static analyzer warning. >

Re: [ovs-dev] [PATCH 1/2] netdev-windows: fix ofpbuf initialization

2016-11-04 Thread Guru Shetty
On 3 November 2016 at 16:25, Sairam Venugopal wrote: > Guru, > > Any reason why the acked-by doesn’t show up on Patchwork - > https://patchwork.ozlabs.org/patch/687913/ Not sure. Just flaky maybe. I applied this series. Thanks. > > > Thanks, > Sairam > > On 10/27/16, 1:49 PM, "Sairam Venugopa

Re: [ovs-dev] [PATCH v4 1/3] Windows: Add internal switch port per OVS bridge

2016-11-04 Thread Guru Shetty
On 10 October 2016 at 15:47, Sairam Venugopal wrote: > Sorry for the delay in the review. > > Acked-by: Sairam Venugopal > There is a v5 of this series. Would you mind looking at that. > > > > On 8/12/16, 6:06 PM, "Alin Serdean" > wrote: > > >This patch updates the following commands in the

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-03 Thread Guru Shetty
> On Nov 3, 2016, at 7:16 PM, Mickey Spiegel wrote: > > See reply at the bottom. > >> On Thu, Nov 3, 2016 at 6:06 PM, Guru Shetty wrote: >> >> >> >> > It seems to me that the root of the problem has to do with >> > three issues: &g

Re: [ovs-dev] [PATCH 3/3] ovn-northd: SNAT in either direction of gateway router.

2016-11-03 Thread Guru Shetty
> On Nov 3, 2016, at 4:34 PM, Mickey Spiegel wrote: > > Interesting problem. See comments inline. > >> On Thu, Nov 3, 2016 at 3:46 AM, Gurucharan Shetty wrote: >> >> When multiple gateway routers exist, a packet can >> enter any gateway router. Once the packet reaches its >> destination, its

Re: [ovs-dev] [PATCH v2] ovn: Add a case of policy based routing.

2016-11-03 Thread Guru Shetty
On 2 November 2016 at 09:29, Ben Pfaff wrote: > On Wed, Nov 02, 2016 at 09:28:44AM -0700, Ben Pfaff wrote: > > On Thu, Oct 06, 2016 at 03:53:12AM -0700, Gurucharan Shetty wrote: > > > OVN currently supports multiple gateway routers (residing on > > > different chassis) connected to the same logic

Re: [ovs-dev] [PATCH v2] ovn-controller: Container can have connection to a hosting VM.

2016-11-02 Thread Guru Shetty
On 2 November 2016 at 09:09, Ben Pfaff wrote: > On Wed, Oct 05, 2016 at 03:17:44AM -0700, Gurucharan Shetty wrote: > > A Container running inside a VM can have a connection to the > > hosting VM (parent port) in the logical topology (for e.g via a router). > > So we should be able to loop-back in

Re: [ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 04:25, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > Thanks very much. > If it is of interest, something similar can be done for NAT too. > > > On Oct 4, 2016, at 5:12 AM, Guru Shetty wrote: > > > > I applie

Re: [ovs-dev] [PATCH 7/7] ovn: Remove weird or unneeded keywords from tests.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 18:26, Ben Pfaff wrote: > AT_KEYWORDS are mostly there to make it easier to find the tests you're > looking for. One might, for example, mark tests as "positive" or > "negative" so you can select the tests you want to run on that basis. > They're also useful for cases where

Re: [ovs-dev] [PATCH 6/7] ovn: Fix some races in ovn-controller-vtep tests.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 18:26, Ben Pfaff wrote: > This fixes a few races for port bindings appearing and being bound to > a chassis. The ones changed to use "ovn-sbctl wait-until" were previously > only waiting until a Port_Binding record appeared (created by ovn-northd), > but not until the Port_B

Re: [ovs-dev] [PATCH 5/7] ovn: Wait for ovn-northd to catch up in "ovn-sbctl" test.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 18:26, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > tests/ovn-sbctl.at | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tests/ovn-sbctl.at b/tests/ovn-sbctl.at > index 9393eef..26b05af 100644 > --- a/

Re: [ovs-dev] [PATCH 4/7] ovn: Fix race in "ovn -- ipam" test.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 18:26, Ben Pfaff wrote: > After setting the subnet, ovn-northd needs to process the changes before > setting the dynamic addresses. > > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > tests/ovn.at | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [ovs-dev] [PATCH 3/7] ovn: Fix some races in IPAM connectivity test.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 18:26, Ben Pfaff wrote: > It can take a way for dynamic addresses to propagate through ovn-northd, > so wait for it to happen. > > Signed-off-by: Ben Pfaff > --- > tests/ovn.at | 13 - > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/tests/ovn.

Re: [ovs-dev] [PATCH 2/7] ovn: Fix bugs in port security test.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 18:26, Ben Pfaff wrote: > A number of instances of "{i}" in this test should have been "${i}". > > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > tests/ovn.at | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/ovn.a

Re: [ovs-dev] [PATCH 1/7] ovn: Fix races in MAC_Binding deletion test.

2016-10-07 Thread Guru Shetty
On 5 October 2016 at 18:26, Ben Pfaff wrote: > The test assumed that ovn-northd could delete the MAC_Binding rows > instantly, but it may take a while. > > Signed-off-by: Ben Pfaff > --- > tests/ovn.at | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/tests/ovn.a

Re: [ovs-dev] [PATCH] ovn-controller: Container can have connection to a hosting VM.

2016-10-05 Thread Guru Shetty
On 5 October 2016 at 10:44, Ben Pfaff wrote: > On Tue, Oct 04, 2016 at 09:56:15AM -0700, Gurucharan Shetty wrote: > > A Container running inside a VM can have a connection to the > > hosting VM (parent port) in the logical topology (for e.g via a router). > > So we should be able to loop-back int

Re: [ovs-dev] [PATCH] INSTALL.Docker: Explain how to set up a system-id.

2016-10-05 Thread Guru Shetty
On 4 October 2016 at 16:01, Ben Pfaff wrote: > Reported-by: Hui Kang > Signed-off-by: Ben Pfaff > Acked-by: Gurucharan Shetty > --- > INSTALL.Docker.md | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/INSTALL.Docker.md b/INSTALL.Docker.md > index b62922d..097452f 1006

Re: [ovs-dev] [PATCH v1 1/3] ovn-northd: Add logical flows to support native DHCPv4

2016-10-04 Thread Guru Shetty
On 26 July 2016 at 12:24, Numan Siddique wrote: > OVN implements a native DHCPv4 support which caters to the common > use case of providing an IP address to a booting instance by > providing stateless replies to DHCPv4 requests based on statically > configured address mappings. To do this it allo

Re: [ovs-dev] [PATCH] appveyor: Update OpenSSL version

2016-10-04 Thread Guru Shetty
On 4 October 2016 at 07:47, Alin Serdean wrote: > OpenSSL version changed from 1.0.2h to 1.0.2j. > > This patch bumps the version for the appveyor config. > > Signed-off-by: Alin Gabriel Serdean > Applied, thanks. > --- > appveyor.yml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions

Re: [ovs-dev] [RFC 0/2] ovn: add distributed NAT capability

2016-10-03 Thread Guru Shetty
> On Oct 3, 2016, at 3:17 PM, Mickey Spiegel wrote: > > (+ ovs dev mailing list) > >> On Mon, Oct 3, 2016 at 1:40 PM, Guru Shetty wrote: >> >> >>> On 17 August 2016 at 14:11, Mickey Spiegel wrote: >>> Currently OVN supports NAT function

Re: [ovs-dev] [PATCH v2] ovsdb-monitor tests: Allow '--detach' argument to be used on Windows

2016-10-03 Thread Guru Shetty
On 3 October 2016 at 03:47, Alin Serdean wrote: > This patch updates the ovsdb monitor tests to use it. > > The --detach argument is needed to make the unixctl for the ovsdb-client, > to send commands. > > Fixes hanging test: > 1889: monitor-cond-change > > Signed-off-by: Alin Gabriel Serdean >

Re: [ovs-dev] [PATCH v10] ovn-nbctl: Add LB commands.

2016-10-03 Thread Guru Shetty
On 3 October 2016 at 01:57, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have multip

Re: [ovs-dev] [RFC 0/2] ovn: add distributed NAT capability

2016-10-03 Thread Guru Shetty
On 17 August 2016 at 14:11, Mickey Spiegel wrote: > Currently OVN supports NAT functionality by connecting each distributed > logical router to a centralized "l3gateway" router that resides on a > single chassis. NAT is only carried out in the "l3gateway" router. > > This patch set introduces NA

Re: [ovs-dev] [PATCH] Fix missing system-id in INSTALL.Docker

2016-10-03 Thread Guru Shetty
On 3 October 2016 at 12:30, Hui Kang wrote: > Signed-off-by: Hui Kang > Can you please use the same Author and Signed-off-by information. Right now you are: Author: Hui Kang Signed-off-by: Hui Kang > --- > INSTALL.Docker.md | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >

Re: [ovs-dev] [PATCH v9] ovn-nbctl: Add LB commands.

2016-09-29 Thread Guru Shetty
On 29 September 2016 at 02:43, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have mul

Re: [ovs-dev] tx and rx packet

2016-09-29 Thread Guru Shetty
On 29 September 2016 at 07:29, Ashish Kurian wrote: > Dear Developers, > > I am trying to send packets into s1-eth1 and it is receiving the packets in > correct numbers. Then I send those packets to the gtp tunnel port set. But > I am not getting any rx packet count on that port. I am keeping the

Re: [ovs-dev] [PATCH v8] ovn-nbctl: Add LB commands.

2016-09-28 Thread Guru Shetty
On 21 September 2016 at 06:14, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have mul

Re: [ovs-dev] GRE over IPsec on CentOS using openvswitch 2.5.0

2016-09-27 Thread Guru Shetty
On 27 September 2016 at 12:55, Mrityunjay Kumar wrote: > Hi Team > Request you to please answer. GRE over IPsec on CentOS using openvswitch > 2.5.0 is working or not. we need to think accordingly. Please updat only > yes or not ? > Did you read Ansis's reply in disc...@openvswitch.org ? > > If

Re: [ovs-dev] [PATCH v2] INSTALL.md: Add details about kernel module preference.

2016-09-27 Thread Guru Shetty
On 26 September 2016 at 20:52, Darrell Ball wrote: > > > On Mon, Sep 26, 2016 at 7:34 AM, Gurucharan Shetty wrote: > >> Signed-off-by: Gurucharan Shetty >> --- >> INSTALL.md | 23 ++- >> 1 file changed, 22 insertions(+), 1 deletion(-) >> >> diff --git a/INSTALL.md b/INSTALL

Re: [ovs-dev] [PATCH] INSTALL.md: Add details about kernel module preference.

2016-09-26 Thread Guru Shetty
> > > Don't forget to "depmod" after writing this file. > How about the v2? ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH v2] ovn: Initialize the databases.

2016-09-23 Thread Guru Shetty
On 22 September 2016 at 09:54, Ben Pfaff wrote: > On Mon, Sep 19, 2016 at 03:52:55AM -0700, Gurucharan Shetty wrote: > > Without initializing the databases, commands of the form > > 'ovn-nbctl --wait=sb ls-add ls0' will simply hang. > > > > Signed-off-by: Gurucharan Shetty > > Thanks! > > Acked-

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
On 23 September 2016 at 11:25, Justin Pettit wrote: > > > On Sep 23, 2016, at 11:21 AM, Guru Shetty wrote: > > > > > > > > I changed the sentence to the following, since I was worried that "key" > was being used in different contexts in that paragra

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
> > > > I changed the sentence to the following, since I was worried that "key" > was being used in different contexts in that paragraph: > > The name contains a prefix > of ct-zone- followed by the name of the logical > port or the gateway router. > > Are you good with it?

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
On 23 September 2016 at 11:01, Justin Pettit wrote: > > > On Sep 23, 2016, at 10:19 AM, Guru Shetty wrote: > > > > > > > > On 23 September 2016 at 01:53, Justin Pettit wrote: > > If ovn-controller is restarted, it may choose different conntrack zones &

Re: [ovs-dev] [PATCH 3/4] ovn-controller: Store conntrack zone mappings to OVS database.

2016-09-23 Thread Guru Shetty
On 23 September 2016 at 01:53, Justin Pettit wrote: > If ovn-controller is restarted, it may choose different conntrack zones > than had been previously used, which could cause the wrong conntrack > entries to be associated with a logical port. This commit stores in the > integration bridge's OV

Re: [ovs-dev] [PATCH] Windows: Disable python3 tests

2016-09-20 Thread Guru Shetty
On 20 September 2016 at 12:09, Alin Serdean wrote: > Until the effort of the python series is integrated, disable the python3 > tests under Windows. > > Signed-off-by: Alin Gabriel Serdean > Applied, thanks! > --- > tests/atlocal.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tes

Re: [ovs-dev] [PATCH v3] datapath-windows: Add define for last module number

2016-09-20 Thread Guru Shetty
On 19 September 2016 at 16:16, Shashank Ram wrote: > Adds a define for the last defined module number. > > Change-Id: I1ea9230317a849e911900cf69e96ed85a65d3a8c > Signed-off-by: Shashank Ram > I removed the Change-Id, added you to AUTHORS and applied this to master and 2.6 Thanks! > --- > da

Re: [ovs-dev] [PATCH] ovn-ctl: Initialize the databases.

2016-09-19 Thread Guru Shetty
On 19 September 2016 at 11:33, Ben Pfaff wrote: > On Mon, Sep 19, 2016 at 11:18:20AM -0700, Guru Shetty wrote: > > On 19 September 2016 at 11:08, Ben Pfaff wrote: > > > > > On Sun, Sep 18, 2016 at 11:26:52PM -0700, Gurucharan Shetty wrote: > > > > Without ini

Re: [ovs-dev] [PATCH v7] ovn-nbctl: Add LB commands.

2016-09-19 Thread Guru Shetty
On 19 September 2016 at 09:38, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have mul

Re: [ovs-dev] [PATCH v7] ovn-nbctl: Add LB commands.

2016-09-19 Thread Guru Shetty
On 19 September 2016 at 09:38, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have mul

Re: [ovs-dev] [PATCH] ovn-ctl: Initialize the databases.

2016-09-19 Thread Guru Shetty
On 19 September 2016 at 11:08, Ben Pfaff wrote: > On Sun, Sep 18, 2016 at 11:26:52PM -0700, Gurucharan Shetty wrote: > > Without initializing the databases, commands of the form > > 'ovn-nbctl --wait=sb ls-add ls0' will simply hang. > > > > Signed-off-by: Gurucharan Shetty > > It's better if the

Re: [ovs-dev] [PATCH v6] ovn-nbctl: Add LB commands.

2016-09-19 Thread Guru Shetty
On 19 September 2016 at 05:16, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have mul

Re: [ovs-dev] [PATCH v5] ovn-nbctl: Add LB commands.

2016-09-15 Thread Guru Shetty
On 9 September 2016 at 18:30, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it to multiple > switches or routers. A single load balancer can have mult

Re: [ovs-dev] [PATCH] Tests: update monitor-cond tests on Windows

2016-09-14 Thread Guru Shetty
On 14 September 2016 at 09:00, Alin Serdean wrote: > Windows allows '--detach' argument to be used. > This patch updates the ovsdb monitor tests to use it. > > Fixes hanging test: > 1889: monitor-cond-change > > Signed-off-by: Alin Gabriel Serdean > Can you have a look at the commit message of

Re: [ovs-dev] [PATCH] Windows: Extend support for binaries which allow detach

2016-09-14 Thread Guru Shetty
On 14 September 2016 at 08:25, Alin Serdean wrote: > On Windows we require service_start to be called to parse and setup > requirements for '--detach' argument. > Affected binaries: ovn-trace, ovsdb-client, ovs-testcontroller. > > Subsequent patches will be sent to adapt the tests with the new fe

Re: [ovs-dev] [PATCH v2] Windows: Update the Driver and MSI properties

2016-09-13 Thread Guru Shetty
On 12 September 2016 at 14:47, Sairam Venugopal wrote: > Fix the legal notice section in OVSEXT.SYS properties. Update the MSI to > include the properties mentioned in MSDN - 'Extension driver MSI packaging > requirements' section - > https://msdn.microsoft.com/windows/hardware/drivers/ > network

Re: [ovs-dev] [PATCH v2] datapath-windows: Fix conntrack event handler

2016-09-12 Thread Guru Shetty
On 12 September 2016 at 11:50, Sairam Venugopal wrote: > Fix an issue with the OvsReadEventCmdHandler when handling conntrack > events. Driver initiated messages should have zero seq number. > > Reverting the previous review comment since the inputBuffer in > this case will be NULL. > > Signed-of

Re: [ovs-dev] [PATCH] ofctrl: Fix logic for mff_ovn_geneve.

2016-09-10 Thread Guru Shetty
On 9 September 2016 at 15:49, Ben Pfaff wrote: > On Fri, Sep 09, 2016 at 05:38:16AM -0700, Gurucharan Shetty wrote: > > Fixes: 7fa39c6b9376e99 ("Fix memory leak in > recv_S_TLV_TABLE_REQUESTED().") > > Signed-off-by: Gurucharan Shetty > > --- > > ovn/controller/ofctrl.c | 2 +- > > 1 file chang

Re: [ovs-dev] [PATCH v4] ovn-nbctl: Add LB commands.

2016-09-09 Thread Guru Shetty
On 1 September 2016 at 23:47, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it > to multiple switches. A single load balancer can have multiple vips.

Re: [ovs-dev] [PATCH 2/2] ovn-northd: Add load-balancers to gateway routers.

2016-09-09 Thread Guru Shetty
On 9 September 2016 at 13:59, Ben Pfaff wrote: > On Tue, Aug 23, 2016 at 02:46:18AM -0700, Gurucharan Shetty wrote: > > Load-balancers in gateway routers lets us load-balance > > north-south traffic. > > > > This commit adds a new table called "DEFRAG" in the > > logical router pipeline to defrag

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

2016-09-09 Thread Guru Shetty
> > > > I think I understand now. Let's take what you've done. > > Please consider whether any of your explanation here is worth putting > into comments or documentation or the commit log. > Thanks. I added the rationale into the commit message and pushed this. > > Acked-by: Ben Pfaff > ___

Re: [ovs-dev] [PATCH] ovn-northd: Tag allocation for nested containers.

2016-09-09 Thread Guru Shetty
On 9 September 2016 at 13:48, Ben Pfaff wrote: > On Tue, Sep 06, 2016 at 01:25:50AM -0700, Gurucharan Shetty wrote: > > When there are hundreds of nodes controlled by OVN, the workflow > > to track and allocate unique tags across multiple hosts becomes > > complicated. It is much easier to let o

Re: [ovs-dev] [PATCH] datapath-windows: Fixed tcp flags byte order in conntrack

2016-09-09 Thread Guru Shetty
On 9 September 2016 at 04:02, Alin Serdean wrote: > > > > -Original Message- > > From: dev [mailto:dev-boun...@openvswitch.org] On Behalf Of Joe Stringer > > Sent: Friday, September 9, 2016 12:37 AM > > To: Guru Shetty > > Cc: dev@openvswitch.o

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

2016-09-09 Thread Guru Shetty
On 1 September 2016 at 10:02, Ben Pfaff wrote: > Nothing freed 'reply'. This fixes the problem. > > Most of this patch is moving coding around. The essential change is that > breaking the code that works with 'reply' out into a separate function > makes it possible to catch all paths out of the

Re: [ovs-dev] [PATCH 0/2] load-balancer fix for north-south direction.

2016-09-09 Thread Guru Shetty
On 9 September 2016 at 09:03, Ben Pfaff wrote: > On Tue, Aug 23, 2016 at 02:46:16AM -0700, Gurucharan Shetty wrote: > > So far, we have had the ability to add a load-balancer to a switch. > This works > > fine for east-west traffic. It was assumed (and lightly tested) that it > also > > works fo

Re: [ovs-dev] [PATCH] ovn-controller: Fix memory leak in recv_S_TLV_TABLE_REQUESTED().

2016-09-08 Thread Guru Shetty
On 1 September 2016 at 10:02, Ben Pfaff wrote: > Nothing freed 'reply'. This fixes the problem. > > Most of this patch is moving coding around. The essential change is that > breaking the code that works with 'reply' out into a separate function > makes it possible to catch all paths out of the

Re: [ovs-dev] [PATCH] datapath-windows: Fixed tcp flags byte order in conntrack

2016-09-08 Thread Guru Shetty
On 29 August 2016 at 12:11, Paul Boca wrote: > In user mode the flags are interpreted as little endian. > This fix makes the kernel mode compatible with user mode. > > Signed-off-by: Paul-Daniel Boca > Applied, thank you. > --- > datapath-windows/ovsext/Conntrack-tcp.c | 14 -- >

Re: [ovs-dev] [PATCH] INSTALL.Windows.md : Updated the kernel datapath project solution file name

2016-09-01 Thread Guru Shetty
On 31 August 2016 at 13:33, Anand Kumar wrote: > Singed-off-by : Anand Kumar > Thanks you! I applied this and added you to AUTHORS. > --- > INSTALL.Windows.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/INSTALL.Windows.md b/INSTALL.Windows.md > index 6b0f5d8..59f3

Re: [ovs-dev] [PATCH v2] datapath-windows: add assert in OvsHashFlow()

2016-09-01 Thread Guru Shetty
On 31 August 2016 at 23:45, Nithin Raju wrote: > Signed-off-by: Nithin Raju > Applied. > --- > datapath-windows/ovsext/Flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/datapath-windows/ovsext/Flow.c b/datapath-windows/ovsext/ > Flow.c > index 439fb28..2e8b42b 100644 > --- a/dat

Re: [ovs-dev] [PATCH v3] ovn-nbctl: Add LB commands.

2016-09-01 Thread Guru Shetty
On 1 September 2016 at 04:59, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patch provides the command line to create a load balancer. > You can create a load balancer independently and add it > to multiple switches. Add a name column for the load balancer. > With

Re: [ovs-dev] [PATCH v3 2/5] ovn: Introduce l3 gateway router.

2016-09-01 Thread Guru Shetty
On 1 September 2016 at 00:23, Shi Xin Ruan wrote: > Thanks, Amitabha. > > I have 1 more question: is it possible create a l3 gateway router without > SNAT/DNAT? > So traffic from GTRP will not be SNAT, but directly forward to provider > network. > I know distribute router can do this, but I want

Re: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon

2016-08-31 Thread Guru Shetty
On 31 August 2016 at 00:45, Paul Boca wrote: > Hi Guru, > > > > There are other tests that check if the daemon is running fine. > > In my opinion we could skip this test on Windows and let it on Linux to > run. > All right. I applied this. > > > Paul &

Re: [ovs-dev] [PATCH v2] ovn-nbctl: Add LB commands.

2016-08-31 Thread Guru Shetty
On 29 August 2016 at 20:12, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > Add a name column for the load balancer. This must be unique among > all load balancers. This name has no special meaning or purpose > other than to provide convenience for human interaction wi

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

2016-08-30 Thread Guru Shetty
On 30 August 2016 at 14:50, Ben Pfaff wrote: > On Tue, Aug 30, 2016 at 01:42:06PM -0700, Guru Shetty wrote: > > On 30 August 2016 at 13:03, Ben Pfaff wrote: > > > > > On Tue, Aug 23, 2016 at 02:46:17AM -0700, Gurucharan Shetty wrote: > > > > Currently ct_lb(

Re: [ovs-dev] [PATCH 1/2] ovn-controller: Datapath based conntrack zone for load-balancing.

2016-08-30 Thread Guru Shetty
On 30 August 2016 at 13:03, Ben Pfaff wrote: > On Tue, Aug 23, 2016 at 02:46:17AM -0700, Gurucharan Shetty wrote: > > Currently ct_lb() logical action is only added for a logical switch and > > we use the conntrack zone allocated for the logical port. A future > commit > > will use ct_lb() for a

Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

2016-08-30 Thread Guru Shetty
On 29 August 2016 at 11:30, Paul Boca wrote: > > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Monday, August 29, 2016 9:20 PM > *To:* Paul Boca > *Cc:* dev@openvswitch.org > *Subject:* Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output > &g

Re: [ovs-dev] [PATCH V2 02/10] python tests: Skip python tests that kill the python daemon

2016-08-30 Thread Guru Shetty
On 30 August 2016 at 05:00, Paul Boca wrote: > If the python script is killed with `kill` command, the atexit > handler doesn't gets executed on Windows. > The kill of the process is done using NtTerminateProcess which > doesn't sends a signal to the process itself, if just terminates the > proce

Re: [ovs-dev] [PATCH V2 01/10] python tests: Skip python tests specific to Linux

2016-08-30 Thread Guru Shetty
On 30 August 2016 at 05:00, Paul Boca wrote: > There is a difference between POSIX pid and Windows pid, not all the time > are equal. > On Windows when a python script is started, a sh command is triggered as > the parent > for script. So when we try to get the daemon pid with 'echo $!', this wil

Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows

2016-08-30 Thread Guru Shetty
indows. > > I don’t know if ignoring the ‘—detach’ switch is intended or is a porting > error. > It looks like a porting error. > > > Paul > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Friday, August 26, 2016 9:07 PM > *To:* Paul Boca > *Cc

Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

2016-08-29 Thread Guru Shetty
> > > > So you are saying that running $srcdir/test-unixctl.py on Windows > produces output in stderr. Why? Is there a bug with Windows port? > > *[Paul Boca] *This is the way logging library works on both Windows and > Linux (https://docs.python.org/2/howto/logging.html - > > “If you call the func

Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

2016-08-29 Thread Guru Shetty
On 29 August 2016 at 10:36, Paul Boca wrote: > Hi Guru, > > > > please see my comments inline. > > > > Thanks, > > Paul > > > > *From:* Guru Shetty [mailto:g...@ovn.org] > *Sent:* Friday, August 26, 2016 9:04 PM > *To:* Paul Boca > *Cc:* de

Re: [ovs-dev] [PATCH 0/3] Add LB commands.

2016-08-29 Thread Guru Shetty
On 28 August 2016 at 02:05, nickcooper-zhangtonghao < nickcooper-zhangtong...@opencloud.tech> wrote: > This patches provide the command line to create load-balancer and add > the unit tests. > Thank you for working on this. I have a few higher level comments. 1. I do not see the 2nd patch in the

Re: [ovs-dev] [PATCH 11/12] ovsdb-monitor: Skip monitor-cond tests on Windows

2016-08-26 Thread Guru Shetty
On 26 August 2016 at 07:40, Paul Boca wrote: > The ovsdb-client doesn't suport detach and listening on a local port > on Windows. > The --detach switch is ignored. > This looks like a non-Python related test. This used to work before. Is it that something changed recently that you are skipping t

Re: [ovs-dev] [PATCH 10/12] tunnel tests: Skip ipsec_gre tests on Windows

2016-08-26 Thread Guru Shetty
On 26 August 2016 at 07:40, Paul Boca wrote: > The ipsec feature is not implemented on windows. > > Signed-off-by: Paul-Daniel Boca > Applied. > --- > tests/tunnel.at | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/tunnel.at b/tests/tunnel.at > index 477517e..dbc6a11 100644

Re: [ovs-dev] [PATCH 09/12] python tests: Skip ovn-controller-vtep tests on Windows

2016-08-26 Thread Guru Shetty
On 26 August 2016 at 07:40, Paul Boca wrote: > The tests are not intended to run on Windows. > Can you explain why? What part of the test gives a problem in Windows? Is it that the ovs-vtep.py has not been ported to Windows? > Until now they were skipped based on $HAVE_PYTHON only. > > Signed-

Re: [ovs-dev] [PATCH 08/12] python tests: Ignore stderr output

2016-08-26 Thread Guru Shetty
On 26 August 2016 at 07:40, Paul Boca wrote: > test-unixctl.py and test-vlog.py outputs on stderr and on Windows > stderr is not overriden by every AT_CHECK call, the logs are only > apended to the file and subsequent AT_CHECKs get errors from previous > call. > > Signed-off-by: Paul-Daniel Boca

Re: [ovs-dev] [PATCH 06/12] python tests: Fixed flake8 errors in daemon_unix

2016-08-26 Thread Guru Shetty
What flake8 errors do you get? Since this is daemon_unix.py, why weren't we getting these errors till now? On 26 August 2016 at 07:40, Paul Boca wrote: > Fixed small alignement issues. > > Signed-off-by: Paul-Daniel Boca > --- > python/ovs/daemon_unix.py | 7 +-- > 1 file changed, 5 insert

Re: [ovs-dev] [PATCH 03/12] python tests: Ported UNIX sockets to Windows

2016-08-26 Thread Guru Shetty
On 26 August 2016 at 07:40, Paul Boca wrote: > AF_UNIX sockets are not supported on Windows. > Instead of an AF_UNIX socket use named pipes to communicate > between components. This makes the python sockets compatible with > the named pipe used in Windows applications. > Added stream_windows.py w

Re: [ovs-dev] [PATCH 01/12] python tests: Skip python tests specific to Linux

2016-08-26 Thread Guru Shetty
On 26 August 2016 at 07:40, Paul Boca wrote: > There is a difference between POSIX pid and Windows pid, not all the time > are equal. > On Windows when a python script is started, a sh command is triggered as > the parent > for script. So when we try to get the daemon pid with 'echo $!', this wil

Re: [ovs-dev] Load balancer creating method.

2016-08-26 Thread Guru Shetty
had the time to get to it. > > On Aug 26, 2016, at 12:24 PM, Guru Shetty wrote: > > > Examples are in tests/system-ovn.at > > On Aug 25, 2016, at 6:21 PM, nickcooper-zhangtonghao < > nickcooper-zhangtong...@opencloud.tech> wrote: > > > Hi all, > Can we crea

Re: [ovs-dev] Load balancer creating method.

2016-08-25 Thread Guru Shetty
Examples are in tests/system-ovn.at > On Aug 25, 2016, at 6:21 PM, nickcooper-zhangtonghao > wrote: > > > Hi all, > Can we create the “lb" from the “ovn-nbctl” command line? > manipulate directly the database? > > ___ > dev mailing list > dev@open

Re: [ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

2016-08-25 Thread Guru Shetty
On 25 August 2016 at 13:04, Guru Shetty wrote: > > > On 24 August 2016 at 18:30, Ryan Moats wrote: > >> As [1] indicates, incremental processing hasn't resulted >> in an improvement worth the complexity it has added. >> This patch backs out all of the code sp

Re: [ovs-dev] [PATCH v4] ovn-controller: Back out incremental processing

2016-08-25 Thread Guru Shetty
, > logical ports, multicast groups, all_lports, local and patched > datapaths > > [1] http://openvswitch.org/pipermail/dev/2016-August/078272.html > > Signed-off-by: Ryan Moats > Co-authored-by: Guru Shetty > I think you should remove the co-authored-by. I just gave a very si

Re: [ovs-dev] [PATCH v6] ovn: Replace tabs with spaces and clean up alignment in unit tests.

2016-08-25 Thread Guru Shetty
On 24 August 2016 at 14:10, Flavio Fernandes wrote: > Signed-off-by: Flavio Fernandes > Thanks, applied! > --- > v1->v2: fix indentation issues introduced in v1 > v2->v3: noop :P > v3->v4: fix indentation issue introduced in v1, this time for real > v4->v5: fix yet another -- and hopefully fi

Re: [ovs-dev] GRE over IPSEC , facing issues on running ovs-monitor-ipsec

2016-08-25 Thread Guru Shetty
On 25 August 2016 at 07:15, santhu vaddepally wrote: > Hi, > > Now i am able to configure the GRE over IPSEC, but not able to establish > the tunnel. I have checked in the backend, ovs-monitor-ipsec daemon is > running , but no racoon binary is running, even the secrets and policies > were not se

Re: [ovs-dev] [PATCH v3] ovn-controller: Back out incremental processing

2016-08-24 Thread Guru Shetty
On 24 August 2016 at 11:12, Ryan Moats wrote: > > > > Guru Shetty wrote on 08/24/2016 01:07:47 PM: > > > From: Guru Shetty > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 08/24/2016 01:08 PM > > Subject: Re: [ovs-dev] [PATCH v3] ovn-co

Re: [ovs-dev] [PATCH v5] ovn: Replace tabs with spaces and clean up alignment in unit tests.

2016-08-24 Thread Guru Shetty
On 23 August 2016 at 20:06, Flavio Fernandes wrote: > Signed-off-by: Flavio Fernandes > --- > v1->v2: fix indentation issues introduced in v1 > v2->v3: noop :P > v3->v4: fix indentation issue introduced in v1, this time for real > v4->v5: fix yet another -- and hopefully final?!? -- round of ind

Re: [ovs-dev] [PATCH v3] ovn-controller: Back out incremental processing

2016-08-24 Thread Guru Shetty
On 24 August 2016 at 11:03, Ryan Moats wrote: > > Guru Shetty wrote on 08/24/2016 12:46:55 PM: > > > From: Guru Shetty > > To: Ryan Moats/Omaha/IBM@IBMUS > > Cc: ovs dev > > Date: 08/24/2016 12:47 PM > > Subject: Re: [ovs-dev] [PATCH v3] ovn-controll

Re: [ovs-dev] [PATCH v3] ovn-controller: Back out incremental processing

2016-08-24 Thread Guru Shetty
On 23 August 2016 at 22:40, Ryan Moats wrote: > As [1] indicates, incremental processing hasn't resulted > in an improvement worth the complexity it has added. > This patch backs out all of the code specific to incremental > processing, along with the persisting of OF flows, > logical ports and m

Re: [ovs-dev] [PATCH] stream-windows: Disconnect faulty named pipes

2016-08-23 Thread Guru Shetty
On 12 August 2016 at 00:46, Alin Serdean wrote: > Disconnect named pipes that failed connection. > > Found by testing. > > Signed-off-by: Alin Gabriel Serdean > Thanks, applied to master and 2.6 > --- > lib/stream-windows.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/strea

Re: [ovs-dev] [PATCH v4] ovn: Replace tabs with spaces and clean up alignment in unit tests.

2016-08-23 Thread Guru Shetty
On 23 August 2016 at 09:54, Flavio Fernandes wrote: > Signed-off-by: Flavio Fernandes > --- > v1->v2: fix indentation issues introduced in v1 > v2->v3: noop :P > v3->v4: fix indentation issue introduced in v1, this time for real > > tests/ovn.at | 154 +- > ---

Re: [ovs-dev] [PATCH] ovn-trace: add generated files to .gitignore.

2016-08-23 Thread Guru Shetty
On 23 August 2016 at 12:07, Flavio Fernandes wrote: > Signed-off-by: Flavio Fernandes > Applied, thanks! > --- > ovn/utilities/.gitignore | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ovn/utilities/.gitignore b/ovn/utilities/.gitignore > index 5832b6c..2c06825 100644 > --- a/ovn

Re: [ovs-dev] [PATCH v2] system-ovn.at: Fix occasional test failures.

2016-08-19 Thread Guru Shetty
On 18 August 2016 at 21:44, Gurucharan Shetty wrote: > A run of the NAT unit tests hundred times showed some > occasional unit test failures. With this commit, I haven't > seen any failures for 100 runs. > > Reported-by: Joe Stringer > Signed-off-by: Gurucharan Shetty > Joe acked it offline, s

Re: [ovs-dev] [PATCH v6] ovn: Support for GARP for NAT IPs via localnet

2016-08-16 Thread Guru Shetty
On 16 August 2016 at 10:14, Chandra S Vejendla wrote: > In cases where a DNAT IP is moved to a new router or the SNAT IP is reused > with a new mac address, the NAT IPs become unreachable because the external > switches/routers have stale ARP entries. This commit > aims to fix the problem by send

Re: [ovs-dev] [PATCH] ovn: Fix ARP request flow for unknown IP in lrouter

2016-08-16 Thread Guru Shetty
On 16 August 2016 at 04:49, Chandra S Vejendla wrote: > TPA in arp requests generated for unknown MAC-to-IP bindings is currently > set > to DST_IP of the original packet. These arps will not be resolved when the > DST_IP is rechable via the default gateway. This patch fixes the issue by > settin

Re: [ovs-dev] [PATCH v4] ovn: Support for GARP for NAT IPs via localnet

2016-08-13 Thread Guru Shetty
On 12 August 2016 at 12:28, Chandra S Vejendla wrote: > In cases where a DNAT IP is moved to a new router or the SNAT IP is reused > with a new mac address, the NAT IPs become unreachable because the external > switches/routers have stale ARP entries. This commit > aims to fix the problem by send

Re: [ovs-dev] [PATCH 1/2] ovn: Ability to set multiple load balancers.

2016-08-13 Thread Guru Shetty
On 12 August 2016 at 15:48, Joe Stringer wrote: > On 11 August 2016 at 23:34, Gurucharan Shetty wrote: > > The schema prevented one from setting more than one load balancer > > to a switch. This removes that anamoly. > > > > Signed-off-by: Gurucharan Shetty > > The system tests part looks good

Re: [ovs-dev] [PATCH v2 2/2] system-ovn.at: Add another load-balancing test.

2016-08-13 Thread Guru Shetty
On 12 August 2016 at 15:46, Joe Stringer wrote: > On 12 August 2016 at 02:48, Gurucharan Shetty wrote: > > The client and servers are in the same subnet. > > > > (This would not have worked without the recent > > IPv6 patches that let packets to loop back) > > > > Signed-off-by: Gurucharan Shett

Re: [ovs-dev] [PATCH 2/2] system-ovn.at: Add another load-balancing test.

2016-08-12 Thread Guru Shetty
On 12 August 2016 at 11:15, Joe Stringer wrote: > On 11 August 2016 at 23:34, Gurucharan Shetty wrote: > > The client and servers are in the same subnet. > > > > (This would not have worked without the recent > > IPv6 patches that let packets to loop back) > > > > Signed-off-by: Gurucharan Shett

  1   2   3   4   >