Re: [ovs-dev] [PATCH] bitmap: Optimize bitmap_equal and bitmap_scan

2014-07-29 Thread Kmindg G
On Tue, Jul 29, 2014 at 1:01 AM, Ben Pfaff wrote: > Needs a sign-off. > Oh.. I will not forget it in the next version. > > I'm pretty sure that bitmap_equal() is wrong: doesn't it access one > past the end of the bitmap arrays? You are right. I'll fix it. > I think that rightmost_1bit_idx

Re: [ovs-dev] [ovs-discuss] dl_src field didn't function

2014-05-22 Thread Kmindg G
predict which flow will be chosen. It does not mean one flow will not be chosen forever. > > > 2014-05-22 17:46 GMT+08:00 Kmindg G : > >> On Thu, May 22, 2014 at 4:54 PM, chen zhang <3zhangchen9...@gmail.com> >> wrote: >> > but i know that when a ofp_match has

Re: [ovs-dev] [ovs-discuss] dl_src field didn't function

2014-05-22 Thread Kmindg G
ltiple flows, the highest priority of flow will be chosen. > > > 2014-05-22 16:12 GMT+08:00 Kmindg G : > >> On Thu, May 22, 2014 at 3:21 PM, chen zhang <3zhangchen9...@gmail.com> >> wrote: >> > hi, everybody >> > this is my table entry: >> &

[ovs-dev] cmap.c gcc 4.9 compile error

2014-05-20 Thread Kmindg G
Hi Ben, When I compile ovs src on the master branch with gcc 4.9, I get this error: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I ./include -I ./lib -I ./lib -I/usr/include -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wdeclaration-after-statement -Wno-format-zero-length -Ws

Re: [ovs-dev] [PATCH 09/10] lib/flow: Maintain miniflow offline values explicitly.

2014-04-28 Thread Kmindg G
hat I misunderstood these code before. Sorry for the noise. > Ethan > > On Sat, Apr 19, 2014 at 10:09 PM, Kmindg G wrote: >> On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme >> wrote: >>> This allows use of miniflows that have all of their values inline. >>&

Re: [ovs-dev] [PATCH 09/10] lib/flow: Maintain miniflow offline values explicitly.

2014-04-19 Thread Kmindg G
On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme wrote: > This allows use of miniflows that have all of their values inline. > > Signed-off-by: Jarno Rajahalme > --- > lib/classifier.c | 36 +++-- > lib/dpif-netdev.c | 32 ++- > lib/flow.c| 91 > ++

Re: [ovs-dev] [PATCH 10/10] lib/classifier: Support variable sized miniflows.

2014-04-19 Thread Kmindg G
On Sat, Apr 19, 2014 at 3:42 AM, Jarno Rajahalme wrote: > Change the classifier to allocate variable sized miniflows and > minimasks in cls_match and cls_subtable, respectively. Do not > duplicate the mask in cls_rule any more. > > miniflow_clone and miniflow_move can now take variably sized mini

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-04-01 Thread Kmindg G
t; > These tests were introduced by commit 6d56c1f1. > ("ofproto: Update rule's priority in eviction group.") > > Signed-off-by: YAMAMOTO Takashi > Cc: Kmindg G > Acked-by: Ben Pfaff > > diff --git a/tests/ofproto.at b/tests/ofproto.at &g

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-04-01 Thread Kmindg G
> Also, use time/stop to avoid relying on how long an add-flow would take. > > These tests were introduced by commit 6d56c1f1. > ("ofproto: Update rule's priority in eviction group.") > > Signed-off-by: YAMAMOTO Takashi > Cc: Kmindg G > A

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-03-31 Thread Kmindg G
These tests were introduced by commit 6d56c1f1. > ("ofproto: Update rule's priority in eviction group.") > > Signed-off-by: YAMAMOTO Takashi > Cc: Kmindg G > Acked-by: Ben Pfaff > > diff --git a/tests/ofproto.at b/tests/ofproto.at > index e

Re: [ovs-dev] [PATCH 4/5] ofproto.at: Fix races in rule eviciton tests

2014-03-31 Thread Kmindg G
On Mon, Mar 31, 2014 at 2:24 PM, YAMAMOTO Takashi wrote: > Bump timeout differences, because timeouts different by 1s might end up > to have the same position in the heap as rule_eviction_priority() uses > 1024ms as a unit. > > Also, use time/stop to avoid relying on how long an add-flow would tak

Re: [ovs-dev] [ovs-discuss] How to Search in Archives?

2014-03-16 Thread Kmindg G
On Fri, Mar 14, 2014 at 7:13 PM, Rizwan Jamil wrote: > Hi! > > Search is provided in mininet-discuss and openflow-discuss mailing archives. > But why it has not been provided in ovs-dev and ovs-discuss archives? How > can I search my question in ovs-dev and ovs-discuss? google always is your frie

Re: [ovs-dev] [PATCH] stp: Fix bpdu tx problem in listening state

2014-03-16 Thread Kmindg G
On Sun, Mar 16, 2014 at 12:50 AM, Ben Pfaff wrote: > On Wed, Mar 12, 2014 at 03:31:26PM +0800, Kmindg G wrote: >> On Wed, Mar 12, 2014 at 1:41 PM, Ben Pfaff wrote: >> > On Sun, Mar 09, 2014 at 05:48:52PM +0800, kmindg wrote: >> >> The restriction only allows to se

Re: [ovs-dev] [PATCH] stp: Fix bpdu tx problem in listening state

2014-03-12 Thread Kmindg G
On Wed, Mar 12, 2014 at 1:41 PM, Ben Pfaff wrote: > On Sun, Mar 09, 2014 at 05:48:52PM +0800, kmindg wrote: >> The restriction only allows to send bpdu in forwarding state in >> compose_output_action__. But a port could send bpdu in listening >> and learning state according to comments in lib/stp.

Re: [ovs-dev] [PATCH] ofproto: Update rule's priority in eviction group.

2014-03-11 Thread Kmindg G
On Wed, Mar 12, 2014 at 1:36 PM, Ben Pfaff wrote: > On Sun, Mar 09, 2014 at 05:48:04PM +0800, kmindg wrote: >> We do call heap_rebuild in ofproto_run, but we do not update rule's >> priority with latest hard_timeout and idle_timeout before heap_rebuild. >> >> This patch ensures that rule's priorit

Re: [ovs-dev] [PATCH] ofproto: Send port status message for port-mods, right away.

2014-02-21 Thread Kmindg G
On Sat, Feb 22, 2014 at 12:42 AM, Ben Pfaff wrote: > On Fri, Feb 21, 2014 at 10:07:14AM +0800, Kmindg G wrote: >> On Fri, Feb 21, 2014 at 5:19 AM, Ben Pfaff wrote: >> > On Thu, Feb 20, 2014 at 12:45:49PM +0800, Kmindg G wrote: >> >> On Thu, Feb 20, 201

Re: [ovs-dev] [PATCH] ofproto: Send port status message for port-mods, right away.

2014-02-20 Thread Kmindg G
On Fri, Feb 21, 2014 at 5:19 AM, Ben Pfaff wrote: > On Thu, Feb 20, 2014 at 12:45:49PM +0800, Kmindg G wrote: >> On Thu, Feb 20, 2014 at 3:20 AM, Ben Pfaff wrote: >> > Until now, when it processes OFPT_PORT_MOD message, Open vSwitch has waited >> > for ports to noti

Re: [ovs-dev] [PATCH] ofproto: Send port status message for port-mods, right away.

2014-02-19 Thread Kmindg G
se to send such port status updates, > and I couldn't quickly find anything in OF1.3 or OF1.4 that said they > shouldn't be sent. > > Signed-off-by: Ben Pfaff > Reported-by: Kmindg G > --- > AUTHORS |1 + > ofproto/ofproto.c | 25 +--

Re: [ovs-dev] Question about miniflow_hash in lib/flow.c

2014-02-09 Thread Kmindg G
On Sun, Feb 9, 2014 at 9:56 AM, Jarno Rajahalme wrote: > >> On Feb 8, 2014, at 12:49 AM, Kmindg G wrote: >> >> Hi all, >> I have a little question about miniflow_hash(). >> At the end of miniflow_hash, "p - flow->values" is used as the second >

[ovs-dev] Question about miniflow_hash in lib/flow.c

2014-02-08 Thread Kmindg G
Hi all, I have a little question about miniflow_hash(). At the end of miniflow_hash, "p - flow->values" is used as the second paramter of mhash_finish. But "p - flow->valuse" is not the number of bytes which has been added to hash in miniflow_hash. The second parameter should be "sizeof hash_map +