[ovs-dev] FW: Subject: [ovsdb-idl 1/1] Fix issues detected in Partial Map Update feature

2016-06-20 Thread Lutz, Arnoldo
.@hpe.com T +506 2560-4430 x 4011 Hewlett-Packard Company Paseo de las Flores Heredia Costa Rica Please print thoughtfully -Original Message----- From: Lutz, Arnoldo Sent: Monday, June 13, 2016 10:07 AM To: 'dev@openvswitch.org' Subject: Subject: [ovsdb-idl 1/1] Fix issues dete

[ovs-dev] Subject: [ovsdb-idl 1/1] Fix issues detected in Partial Map Update feature

2016-06-13 Thread Lutz, Arnoldo
Hi. We found some issues affecting Partial Map Update feature included in master branch. This patch fixes a memory leak due to lack of freeing datum allocated in the process of requesting a change to a map. It also fix an error produced when NDEBUG flag is not set that causes an assertion when

[ovs-dev] [PATCH 6/7] Add fixes, improvements, refactors and cleans code

2016-02-22 Thread Lutz, Arnoldo
Added delta calculations for PMUs Added additional checks to make sure that only one update operation is performed on each key for each transaction. If several update operations are issued by the client, these are resolved and only one is applied on commit. Delayed operation validity checks until

[ovs-dev] [Partial-Update-Map-Columns 2/7] Add functionality to skeleton functions for Partial Map Update

2016-02-22 Thread Lutz, Arnoldo
Modified ovsdb_idl_row structure to include information on partial map updates, which will be used to create mutate operations on map columns when the transaction is committed. Also filled out generic (skeleton) functions to populate partial map update information on the row when a map is partial

[ovs-dev] [PATCH 4/7] Add and correct functionality of Partial Update Map Columns

2016-02-22 Thread Lutz, Arnoldo
Several memory management errors were fixed. Also, some wrong uses of pointers that produced segmentation faults were fixed. Refactored code into separate files Code for Partial Map Updates and Partial Map Update Lists was extracted into separate files, and the inner contents of structs pmu and p

[ovs-dev] [PATCH 3/7] Add code to create partial map functions in autogenerated code

2016-02-22 Thread Lutz, Arnoldo
Code inserted that autogenerates corresponding map functions to set and delete elements in map columns. Inserts description to the functions that are autogenerated. Changes on autogenerated functions Signed-off-by: arnoldo.lutz.guev...@hpe.com --- ovsdb/ovsdb-idlc.in | 69 +++

[ovs-dev] [PATCH 7/7] Adds usage help on command to test of partial update of map column

2016-02-22 Thread Lutz, Arnoldo
--- tests/test-ovsdb.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/test-ovsdb.c b/tests/test-ovsdb.c index 0ad03bd..8c7aedd 100644 --- a/tests/test-ovsdb.c +++ b/tests/test-ovsdb.c @@ -197,7 +197,11 @@ usage(void) "connect to SERVER and dump the c

[ovs-dev] [PATCH 5/7] Add documentation on how to use partial update of map columns

2016-02-22 Thread Lutz, Arnoldo
Add file PARTIAL-UPDATE-MAP-COLUMN.md with a description on the way to use this feature. Modifies Makefile.am to include documentation in distribution list Signed-off-by: arnoldo.lutz.guev...@hpe.com --- Makefile.am | 1 + PARTIAL-UPDATE-MAP-COLUMN.md | 64 +

[ovs-dev] [Partial-Update-Map-Columns 0/7] Add Initial code for Partia-map-columns funtionality

2016-02-22 Thread Lutz, Arnoldo
In the current implementation, every time an element of either a map or set column has to be modified, the entire content of the column is sent to the server to be updated. This is not a major problem if the information contained in the column for the corresponding row is small, but there are cases

[ovs-dev] [Partial-Update-Map-Columns 1/7] Add Initial code for Partial-map-columns functionality

2016-02-22 Thread Lutz, Arnoldo
This commit adds some definitions and skeleton functions to start working. Ovsdb tests run and pass ok. Signed-off-by: arnoldo.lutz.guev...@hpe.com --- 2 0 lib/ovsdb-idl-provider.h 31 3 lib/ovsdb-idl.c 7 0 lib/ovsdb-idl.h lib/ovsdb-idl-provider.h | 2 ++ lib/o